From patchwork Mon Jun 14 07:12:37 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Siddhesh Poyarekar X-Patchwork-Id: 1491546 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=sourceware.org (client-ip=8.43.85.97; helo=sourceware.org; envelope-from=libc-alpha-bounces+incoming=patchwork.ozlabs.org@sourceware.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=H8VUUyvt; dkim-atps=neutral Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4G3N2Z6G9Xz9sW4 for ; Mon, 14 Jun 2021 17:13:10 +1000 (AEST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 46EC43890418 for ; Mon, 14 Jun 2021 07:13:06 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 46EC43890418 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1623654786; bh=XeFKUOlakThXSAtzptxfqIY7LA/j2oANC+VkgepaXeQ=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=H8VUUyvtPtLD493qyJ+Q2te4X53QQu2d33L+u0EXTiqPrhAilmLByFxNfTOIjKxhe GWt1ZL5tTXjfclkrsXWJE/X+jA4UntlxH+F77Dbuz/IwFiu+p6deJpDFrOjFrL5IzO wjktzL7dy3GJBSnKfUVMZgReM3Qy0IWXAObpN9zc= X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from dormouse.elm.relay.mailchannels.net (dormouse.elm.relay.mailchannels.net [23.83.212.50]) by sourceware.org (Postfix) with ESMTPS id 8BE333851C22 for ; Mon, 14 Jun 2021 07:12:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 8BE333851C22 X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 906B410225F for ; Mon, 14 Jun 2021 07:12:48 +0000 (UTC) Received: from pdx1-sub0-mail-a12.g.dreamhost.com (100-101-162-58.trex.outbound.svc.cluster.local [100.101.162.58]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id D2AC8101E4A for ; Mon, 14 Jun 2021 07:12:47 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org Received: from pdx1-sub0-mail-a12.g.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384) by 100.101.162.58 (trex/6.3.1); Mon, 14 Jun 2021 07:12:48 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|siddhesh@gotplt.org X-MailChannels-Auth-Id: dreamhost X-Society-Versed: 6f6c23e166ecc801_1623654768348_754289185 X-MC-Loop-Signature: 1623654768347:757193151 X-MC-Ingress-Time: 1623654768347 Received: from pdx1-sub0-mail-a12.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a12.g.dreamhost.com (Postfix) with ESMTP id 8F07287E70 for ; Mon, 14 Jun 2021 00:12:47 -0700 (PDT) Received: from rhbox.intra.reserved-bit.com (unknown [1.186.101.110]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: siddhesh@gotplt.org) by pdx1-sub0-mail-a12.g.dreamhost.com (Postfix) with ESMTPSA id 3EDD987E71 for ; Mon, 14 Jun 2021 00:12:45 -0700 (PDT) X-DH-BACKEND: pdx1-sub0-mail-a12 To: libc-alpha@sourceware.org Subject: [PATCH v2] Reinstate gconv-modules as the default configuration file Date: Mon, 14 Jun 2021 12:42:37 +0530 Message-Id: <20210614071237.1652596-1-siddhesh@sourceware.org> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 X-Spam-Status: No, score=-3494.7 required=5.0 tests=BAYES_00, GIT_PATCH_0, JMQ_SPF_NEUTRAL, KAM_DMARC_NONE, KAM_DMARC_STATUS, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NEUTRAL, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Siddhesh Poyarekar via Libc-alpha From: Siddhesh Poyarekar Reply-To: Siddhesh Poyarekar Errors-To: libc-alpha-bounces+incoming=patchwork.ozlabs.org@sourceware.org Sender: "Libc-alpha" Reinstate gconv-modules as the main file so that the configuration files in gconv-modules.d/ become add-on configuration. With this, the effective user visible change is that GCONV_PATH can now have supplementary configuration in GCONV_PATH/gconv-modules.d/ in addition to the main GCONV_PATH/gconv-modules file. --- v1->v2: - Update localedata target and dependency. iconvdata/Makefile | 40 ++++++++++--------- .../{gconv-modules.conf => gconv-modules} | 0 localedata/Makefile | 4 +- 3 files changed, 23 insertions(+), 21 deletions(-) rename iconvdata/{gconv-modules.conf => gconv-modules} (100%) diff --git a/iconvdata/Makefile b/iconvdata/Makefile index 3c6929fb59..bb3f621b49 100644 --- a/iconvdata/Makefile +++ b/iconvdata/Makefile @@ -137,13 +137,12 @@ charmaps = ../localedata/charmaps extra-modules-left := $(modules) include extra-module.mk -gconv-modules = gconv-modules.conf gconv-modules-extra.conf +gconv-modules = gconv-modules gconv-modules.d/gconv-modules-extra.conf modpfx = $(objpfx)gconv-modules.d/ extra-objs += $(modules.so) install-others = $(addprefix $(inst_gconvdir)/, $(modules.so)) \ - $(addprefix $(inst_gconvdir)/gconv-modules.d/, \ - $(gconv-modules)) + $(addprefix $(inst_gconvdir)/, $(gconv-modules)) # We can build the conversion tables for numerous charsets automatically. @@ -185,7 +184,7 @@ generated += $(generated-modules:=.h) $(generated-modules:=.stmp) \ iconv-test.out iconv-rules tst-loading.mtrace \ mtrace-tst-loading.out tst-tables.out iconv-test.xxx ifdef objpfx -generated += $(addprefix gconv-modules.d/,$(gconv-modules)) +generated += $(gconv-modules) endif # Rules to generate the headers. @@ -253,8 +252,8 @@ headers: $(addprefix $(objpfx), $(generated-modules:=.h)) $(addprefix $(inst_gconvdir)/, $(modules.so)): \ $(inst_gconvdir)/%: $(objpfx)% $(+force) $(do-install-program) -$(addprefix $(inst_gconvdir)/gconv-modules.d/, $(gconv-modules)): \ - $(inst_gconvdir)/gconv-modules.d/%: $(modpfx)% $(+force) +$(addprefix $(inst_gconvdir)/, $(gconv-modules)): \ + $(inst_gconvdir)/%: $(objpfx)% $(+force) $(do-install) ifeq (no,$(cross-compiling)) # Update the $(prefix)/lib/gconv/gconv-modules.cache file. This is necessary @@ -307,29 +306,29 @@ $(objpfx)mtrace-tst-loading.out: $(objpfx)tst-loading.out $(common-objpfx)malloc/mtrace $(objpfx)tst-loading.mtrace > $@; \ $(evaluate-test) -$(objpfx)bug-iconv1.out: $(addprefix $(modpfx), $(gconv-modules)) \ +$(objpfx)bug-iconv1.out: $(addprefix $(objpfx), $(gconv-modules)) \ $(addprefix $(objpfx),$(modules.so)) -$(objpfx)bug-iconv2.out: $(addprefix $(modpfx), $(gconv-modules)) \ +$(objpfx)bug-iconv2.out: $(addprefix $(objpfx), $(gconv-modules)) \ $(addprefix $(objpfx),$(modules.so)) -$(objpfx)bug-iconv3.out: $(addprefix $(modpfx), $(gconv-modules)) \ +$(objpfx)bug-iconv3.out: $(addprefix $(objpfx), $(gconv-modules)) \ $(addprefix $(objpfx),$(modules.so)) -$(objpfx)bug-iconv5.out: $(addprefix $(modpfx), $(gconv-modules)) \ +$(objpfx)bug-iconv5.out: $(addprefix $(objpfx), $(gconv-modules)) \ $(addprefix $(objpfx),$(modules.so)) -$(objpfx)tst-loading.out: $(addprefix $(modpfx), $(gconv-modules)) \ +$(objpfx)tst-loading.out: $(addprefix $(objpfx), $(gconv-modules)) \ $(addprefix $(objpfx),$(modules.so)) -$(objpfx)tst-iconv4.out: $(addprefix $(modpfx), $(gconv-modules)) \ +$(objpfx)tst-iconv4.out: $(addprefix $(objpfx), $(gconv-modules)) \ $(addprefix $(objpfx),$(modules.so)) -$(objpfx)tst-iconv7.out: $(addprefix $(modpfx), $(gconv-modules)) \ +$(objpfx)tst-iconv7.out: $(addprefix $(objpfx), $(gconv-modules)) \ $(addprefix $(objpfx),$(modules.so)) -$(objpfx)bug-iconv10.out: $(addprefix $(modpfx), $(gconv-modules)) \ +$(objpfx)bug-iconv10.out: $(addprefix $(objpfx), $(gconv-modules)) \ $(addprefix $(objpfx),$(modules.so)) -$(objpfx)bug-iconv12.out: $(addprefix $(modpfx), $(gconv-modules)) \ +$(objpfx)bug-iconv12.out: $(addprefix $(objpfx), $(gconv-modules)) \ $(addprefix $(objpfx),$(modules.so)) -$(objpfx)bug-iconv14.out: $(addprefix $(modpfx), $(gconv-modules)) \ +$(objpfx)bug-iconv14.out: $(addprefix $(objpfx), $(gconv-modules)) \ $(addprefix $(objpfx),$(modules.so)) $(objpfx)iconv-test.out: run-iconv-test.sh \ - $(addprefix $(modpfx), $(gconv-modules)) \ + $(addprefix $(objpfx), $(gconv-modules)) \ $(addprefix $(objpfx),$(modules.so)) \ $(common-objdir)/iconv/iconv_prog TESTS iconv_modules="$(modules)" \ @@ -338,7 +337,7 @@ $(objpfx)iconv-test.out: run-iconv-test.sh \ $(evaluate-test) $(objpfx)tst-tables.out: tst-tables.sh \ - $(addprefix $(modpfx), $(gconv-modules)) \ + $(addprefix $(objpfx), $(gconv-modules)) \ $(addprefix $(objpfx),$(modules.so)) \ $(objpfx)tst-table-from $(objpfx)tst-table-to $(SHELL) $< $(common-objpfx) $(common-objpfx)iconvdata/ \ @@ -357,7 +356,10 @@ $(modpfx): $(modpfx)%: % $(modpfx) cp $< $@ +$(objpfx)gconv-modules: gconv-modules + cp $^ $@ + # Test requires BIG5HKSCS. $(objpfx)tst-iconv-big5-hkscs-to-2ucs4.out: \ - $(addprefix $(modpfx), $(gconv-modules)) \ + $(addprefix $(objpfx), $(gconv-modules)) \ $(addprefix $(objpfx),$(modules.so)) diff --git a/iconvdata/gconv-modules.conf b/iconvdata/gconv-modules similarity index 100% rename from iconvdata/gconv-modules.conf rename to iconvdata/gconv-modules diff --git a/localedata/Makefile b/localedata/Makefile index 364d7c758d..14e04cd3c5 100644 --- a/localedata/Makefile +++ b/localedata/Makefile @@ -183,7 +183,7 @@ install-others := $(addprefix $(inst_i18ndir)/, \ $(locales)) endif -tests: $(objdir)/iconvdata/gconv-modules.d/gconv-modules.conf +tests: $(objdir)/iconvdata/gconv-modules tests-static += tst-langinfo-newlocale-static tst-langinfo-setlocale-static @@ -464,5 +464,5 @@ $(objpfx)mtrace-tst-leaks.out: $(objpfx)tst-leaks.out bug-setlocale1-ENV-only = LOCPATH=$(objpfx) LC_CTYPE=de_DE.UTF-8 bug-setlocale1-static-ENV-only = $(bug-setlocale1-ENV-only) -$(objdir)/iconvdata/gconv-modules.d/gconv-modules.conf: +$(objdir)/iconvdata/gconv-modules: $(MAKE) -C ../iconvdata subdir=iconvdata $@