From patchwork Tue Jan 23 02:10:46 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wei Yongjun X-Patchwork-Id: 864509 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3zQWnr2k6Tz9s0g for ; Tue, 23 Jan 2018 13:04:32 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751279AbeAWCE2 (ORCPT ); Mon, 22 Jan 2018 21:04:28 -0500 Received: from szxga05-in.huawei.com ([45.249.212.191]:4268 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751071AbeAWCE1 (ORCPT ); Mon, 22 Jan 2018 21:04:27 -0500 Received: from DGGEMS414-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id 1A09B28B3E255; Tue, 23 Jan 2018 10:04:14 +0800 (CST) Received: from localhost.localdomain.localdomain (10.175.113.25) by DGGEMS414-HUB.china.huawei.com (10.3.19.214) with Microsoft SMTP Server id 14.3.361.1; Tue, 23 Jan 2018 10:04:07 +0800 From: Wei Yongjun To: David Arcari , Colin Ian King , David VomLehn , Igor Russkikh , Pavel Belous , Dmitrii Tarakanov , Alexander Loktionov CC: Wei Yongjun , , Subject: [PATCH net-next] net: aquantia: Fix error return code in aq_pci_probe() Date: Tue, 23 Jan 2018 02:10:46 +0000 Message-ID: <1516673446-170729-1-git-send-email-weiyongjun1@huawei.com> X-Mailer: git-send-email 1.8.3.1 MIME-Version: 1.0 X-Originating-IP: [10.175.113.25] X-CFilter-Loop: Reflected Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Fix to return error code -ENOMEM from the aq_ndev_alloc() error handling case instead of 0, as done elsewhere in this function. Fixes: 23ee07ad3c2f ("net: aquantia: Cleanup pci functions module") Signed-off-by: Wei Yongjun Acked-by: Igor Russkikh --- drivers/net/ethernet/aquantia/atlantic/aq_pci_func.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/aquantia/atlantic/aq_pci_func.c b/drivers/net/ethernet/aquantia/atlantic/aq_pci_func.c index f5dd5f7..5cf3542 100644 --- a/drivers/net/ethernet/aquantia/atlantic/aq_pci_func.c +++ b/drivers/net/ethernet/aquantia/atlantic/aq_pci_func.c @@ -210,8 +210,10 @@ static int aq_pci_probe(struct pci_dev *pdev, goto err_pci_func; ndev = aq_ndev_alloc(); - if (!ndev) + if (!ndev) { + err = -ENOMEM; goto err_ndev; + } self = netdev_priv(ndev); self->pdev = pdev;