From patchwork Tue Jun 8 20:05:46 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heinrich Schuchardt X-Patchwork-Id: 1489621 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:e::133; helo=bombadil.infradead.org; envelope-from=opensbi-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=MlOFJLP/; dkim=fail reason="signature verification failed" (1024-bit key; secure) header.d=gmx.net header.i=@gmx.net header.a=rsa-sha256 header.s=badeba3b8450 header.b=HVEuLJA1; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4G01TZ12Smz9s5R for ; Wed, 9 Jun 2021 06:06:23 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=pEjfnF8yD3124EQB2TiPwZkTo4vMNva3ZVfu56q7p54=; b=MlOFJLP/3eIkzT TGFOGbw823RWehhm2s4wOSYMEzFIRdXs3Cbx0fEXfb++KJ+eA7us5VxjhE2uU+m6JcpYLtC5cADad sMh1FILioSg7Z8EJCaJgE+DLGUm1gjTTATB6YW4YNBpMmxEfQRXFQ5/zeWUoilipGZihapsNbLviR Su+5TBlfC/KlydVUMSO0D6IOHhif8KWJ1e82Ov4MLVwW+bRJ9c06ix2C8tEsG0AWrunzGQ/b9yMuv Py2WlE03Q5FyNfguFoczY66Rhh9MeCNXrHc9zurTR4tGXB4Lk8tER3+XLa7CC/HQimq/7eZH8xAs/ fXKdJispvo/mAaS6gtvQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lqhzN-00ANyO-Ij; Tue, 08 Jun 2021 20:06:17 +0000 Received: from mout.gmx.net ([212.227.17.22]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lqhzJ-00ANwM-5I for opensbi@lists.infradead.org; Tue, 08 Jun 2021 20:06:15 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1623182759; bh=OW3SKX9LVgHGagRhMt38U7jCrIMVUqaFeRYSiVa/C1M=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date; b=HVEuLJA1LOjqEUJ5UfuIxCPiZ9Y4DYlfkykyuykPXC1PACOk8peF9b1nqNYBOvVPM Qm3CGKgW+eJfxZwRA4Nib/VjlE9kYRsJZTC0oO52Bv3Z2gKLdSoulpbLyZgp379IvF UkIVUXDHS28s7DbSx3gAWWEVp/aTNmXp06uXK5pU= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from LT02.fritz.box ([62.143.247.63]) by mail.gmx.net (mrgmx104 [212.227.17.174]) with ESMTPSA (Nemesis) id 1M89L1-1llVBs2JaV-005LWK; Tue, 08 Jun 2021 22:05:59 +0200 From: Heinrich Schuchardt To: opensbi@lists.infradead.org Cc: Guo Ren , Anup Patel , Atish Patra , Heinrich Schuchardt Subject: [PATCH 1/1] lib: utils: missing initialization in thead_reset_init Date: Tue, 8 Jun 2021 22:05:46 +0200 Message-Id: <20210608200546.101536-1-xypron.glpk@gmx.de> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 X-Provags-ID: V03:K1:dfp275IzAqifh5FqxdAeL/cJVcp5PhFH0ZBEBbsjsJyoJ45bsuO aQX+RNjyGNucNEBUL+wOwj1c504vnP/TbnijTnAlQiUEN5TWD4p42BiGBAA+tXD9Id8T5oD TvvP6vSyG50NstjPAKLj3nWSXIgt7i3h02bgaqziYW3dSfkRdJyh2IRl22Y0upYtCiEpcqx aH2JLIlFRo45Z1tBZffpQ== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:qPryTFSK1jE=:Gq3REE8bYz2YrjM0J0EzyV RO1X1rsWPUmPognDtU4mYAR1U/EGjTNNYZ4QTQll88y8M7ndwbbkP1V0Vdh8SKmGjqdRmYRMk JKB7UW3bBwhHqxCXnjHwo78bNVdn2AJ/jjLjMtDHbF8RwysAH8uWzvfIlq9C73AFCpToVUrP+ /y2TG/npRXTlWz5Dff6wAqn1ozFhErC+W8OH6cN3cJ4jClRFIMuSpdjoQtMkIiifB3+gRvtVV uiyPekmTA/AJgICgo6Eh7536htxgsKFw/Gax+MBbKQ/Hn0BqsFCbct3K5u3Yvd//Mc3XMwKnV 158x+uCk2mUHV18JK8lESsg55TYBxjDECnzhQPIL+k2OlDgB6OrrfLbouDT36f494vXzCFR/K 8cxCsjByLScX9yaegCSvhFNXkQxtXJIwTa88wUqzXOuGeE4VwOBB51L3zfxk5IAIkJ87pwA1F 1jcHZXu/AvbjNppRvJoTV8/Kc7Cn312bWdEssFmY5GcDcXRh+0NKGwMu6hJGsMtESddCBpNuj QBGrDNtp1Djx0CSCA/uFZZlXatqhJw+M3oLVY2cGOjKRV2qp63ydBYtvlCjbHCErZXO9AJVjd XJAhYzX7+2JG5IcEZQ0SFIgET2Mpkke/3S2zczwYcEM7wtBP7hFh38jff+gNu+TJvvAz7y8l4 FrF4TArMRAzM0SWRniY3MsN/ECVICqjWE6HUfTcaEWBhXxSHCdKNn3e1ymFe0WIliXL/uq0GR SANXmkMLNFe1nRYnihiXjyR9fQxDTmXleqizgcPDF6EMBQVOZmhAdCmdma/SHV6RWsKLpDF+l gQs5vquXgF/R8sYfq4ANav+YsgZdxPLLuU3IZCGNNY1GEoXMTkL6jzyvGel7PILdreh1rlVjv rxwD6bmd6JmMgykcHn1/V0vbile/G+qid6c88ApsNRcyscVZKIesAJ/DfDDiY2YO5/Cf+ZPjJ TUOJT/8iNUngfhVYvB2ZSoDIYwdmZ2pX8zxAQ2VCwQlJAPQt7BpAVPJf42JlmF9VudLJZu2N4 P/HdD6JSBIGc7HfUc1rxrpA2vg990n1LZKa1ttOXzdUz6VoD0FPPXz2afosIDZ1eW253Kj4IE /fNXYG8p/jADTkU2QFKcGqCZ29GvMtuTRbk X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210608_130613_575939_1CD00A8B X-CRM114-Status: GOOD ( 10.58 ) X-Spam-Score: 0.0 (/) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: If property csr-copy does not exist, fdt_getprop() will return NULL and cnt will have a random value from the stack. Call clone_csrs() only if cnt is initialized to a non-zero value. Fixes: 49e422c5ad7a ("lib: utils: reset: Add T-HEAD sample platform reset driver") Signed-off-by: Heinrich Schuchardt --- lib/utils/reset/fdt_reset_thead.c | 10 ++++++---- 1 file changed, 6 insertio [...] Content analysis details: (0.0 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [212.227.17.22 listed in list.dnswl.org] 0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [212.227.17.22 listed in wl.mailspike.net] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider [xypron.glpk[at]gmx.de] -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid 0.0 RCVD_IN_MSPIKE_WL Mailspike good senders X-BeenThere: opensbi@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "opensbi" Errors-To: opensbi-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org If property csr-copy does not exist, fdt_getprop() will return NULL and cnt will have a random value from the stack. Call clone_csrs() only if cnt is initialized to a non-zero value. Fixes: 49e422c5ad7a ("lib: utils: reset: Add T-HEAD sample platform reset driver") Signed-off-by: Heinrich Schuchardt Reviewed-by: Anup Patel --- lib/utils/reset/fdt_reset_thead.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) -- 2.30.2 diff --git a/lib/utils/reset/fdt_reset_thead.c b/lib/utils/reset/fdt_reset_thead.c index 95f8c36..9f2fe03 100644 --- a/lib/utils/reset/fdt_reset_thead.c +++ b/lib/utils/reset/fdt_reset_thead.c @@ -62,24 +62,26 @@ static int thead_reset_init(void *fdt, int nodeoff, void *p; const fdt64_t *val; const fdt32_t *val_w; - int len, i, cnt; + int len, i; u32 t, tmp = 0; /* Prepare clone csrs */ val_w = fdt_getprop(fdt, nodeoff, "csr-copy", &len); if (len > 0 && val_w) { - cnt = len / sizeof(fdt32_t); + int cnt; + cnt = len / sizeof(fdt32_t); if (cnt > MAX_CUSTOM_CSR) sbi_hart_hang(); for (i = 0; i < cnt; i++) { custom_csr[i].index = fdt32_to_cpu(val_w[i]); } + + if (cnt) + clone_csrs(cnt); } - if (cnt) - clone_csrs(cnt); /* Delegate plic enable regs for S-mode */ val = fdt_getprop(fdt, nodeoff, "plic-delegate", &len);