From patchwork Tue Jun 8 17:52:32 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ilya Maximets X-Patchwork-Id: 1489519 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org (client-ip=140.211.166.138; helo=smtp1.osuosl.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=) Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4FzyWL6G3pz9sW7 for ; Wed, 9 Jun 2021 03:52:46 +1000 (AEST) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id EB4BC83C11; Tue, 8 Jun 2021 17:52:44 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id cCtB0c7KwyDF; Tue, 8 Jun 2021 17:52:43 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp1.osuosl.org (Postfix) with ESMTP id 2F02183BFC; Tue, 8 Jun 2021 17:52:42 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 0A0B1C000D; Tue, 8 Jun 2021 17:52:42 +0000 (UTC) X-Original-To: ovs-dev@openvswitch.org Delivered-To: ovs-dev@lists.linuxfoundation.org Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by lists.linuxfoundation.org (Postfix) with ESMTP id 068F7C0001 for ; Tue, 8 Jun 2021 17:52:40 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id E8372402B8 for ; Tue, 8 Jun 2021 17:52:39 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id S4VOIJOZ97dz for ; Tue, 8 Jun 2021 17:52:38 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 Received: from relay12.mail.gandi.net (relay12.mail.gandi.net [217.70.178.232]) by smtp4.osuosl.org (Postfix) with ESMTPS id C2E17402A9 for ; Tue, 8 Jun 2021 17:52:37 +0000 (UTC) Received: (Authenticated sender: i.maximets@ovn.org) by relay12.mail.gandi.net (Postfix) with ESMTPSA id 77EA9200009; Tue, 8 Jun 2021 17:52:34 +0000 (UTC) From: Ilya Maximets To: ovs-dev@openvswitch.org Date: Tue, 8 Jun 2021 19:52:32 +0200 Message-Id: <20210608175232.3019726-1-i.maximets@ovn.org> X-Mailer: git-send-email 2.26.3 MIME-Version: 1.0 Cc: Dumitru Ceara , Ilya Maximets Subject: [ovs-dev] [PATCH ovn] if-status: Fix logging of interface creation. X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: ovs-dev-bounces@openvswitch.org Sender: "dev" 'iface->id' is NULL at this point, so the message is always the same: "Interface (null) create." Fixes: 5c3371922994 ("if-status: Add OVS interface status management module.") Signed-off-by: Ilya Maximets Acked-by: Dumitru Ceara --- controller/if-status.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/controller/if-status.c b/controller/if-status.c index 8d8c8d436..08fb50b87 100644 --- a/controller/if-status.c +++ b/controller/if-status.c @@ -341,7 +341,7 @@ ovs_iface_create(struct if_status_mgr *mgr, const char *iface_id, { struct ovs_iface *iface = xzalloc(sizeof *iface); - VLOG_DBG("Interface %s create.", iface->id); + VLOG_DBG("Interface %s create.", iface_id); iface->id = xstrdup(iface_id); shash_add(&mgr->ifaces, iface_id, iface); ovs_iface_set_state(mgr, iface, state);