From patchwork Mon Jun 7 03:21:08 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Samuel Zou X-Patchwork-Id: 1488382 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=linux-i2c-owner@vger.kernel.org; receiver=) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4Fyypj2tP3z9sRK for ; Mon, 7 Jun 2021 13:02:37 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230178AbhFGDE0 (ORCPT ); Sun, 6 Jun 2021 23:04:26 -0400 Received: from szxga08-in.huawei.com ([45.249.212.255]:4329 "EHLO szxga08-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230147AbhFGDE0 (ORCPT ); Sun, 6 Jun 2021 23:04:26 -0400 Received: from dggemv704-chm.china.huawei.com (unknown [172.30.72.55]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4Fyyj51S6Dz1BJnb; Mon, 7 Jun 2021 10:57:45 +0800 (CST) Received: from dggemi762-chm.china.huawei.com (10.1.198.148) by dggemv704-chm.china.huawei.com (10.3.19.47) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2176.2; Mon, 7 Jun 2021 11:02:33 +0800 Received: from linux-lmwb.huawei.com (10.175.103.112) by dggemi762-chm.china.huawei.com (10.1.198.148) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2; Mon, 7 Jun 2021 11:02:32 +0800 From: Zou Wei To: CC: , , Zou Wei Subject: [PATCH -next] i2c: Fix missing pci_disable_device() on error in ali1535_setup() Date: Mon, 7 Jun 2021 11:21:08 +0800 Message-ID: <1623036068-30668-1-git-send-email-zou_wei@huawei.com> X-Mailer: git-send-email 2.6.2 MIME-Version: 1.0 X-Originating-IP: [10.175.103.112] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To dggemi762-chm.china.huawei.com (10.1.198.148) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-i2c@vger.kernel.org Fix the missing pci_disable_device() before return from ali1535_setup() in the error handling case. Reported-by: Hulk Robot Signed-off-by: Zou Wei --- drivers/i2c/busses/i2c-ali1535.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/i2c/busses/i2c-ali1535.c b/drivers/i2c/busses/i2c-ali1535.c index fb93152..bdbaf79 100644 --- a/drivers/i2c/busses/i2c-ali1535.c +++ b/drivers/i2c/busses/i2c-ali1535.c @@ -206,6 +206,7 @@ static int ali1535_setup(struct pci_dev *dev) exit_free: release_region(ali1535_smba, ALI1535_SMB_IOSIZE); exit: + pci_disable_device(dev); return retval; }