From patchwork Fri Jun 4 05:11:15 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alex Hung X-Patchwork-Id: 1487574 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.ubuntu.com (client-ip=91.189.94.19; helo=huckleberry.canonical.com; envelope-from=fwts-devel-bounces@lists.ubuntu.com; receiver=) Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4Fx9pm1Fxhz9sRK for ; Fri, 4 Jun 2021 15:11:27 +1000 (AEST) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.86_2) (envelope-from ) id 1lp277-0004fg-QM; Fri, 04 Jun 2021 05:11:21 +0000 Received: from youngberry.canonical.com ([91.189.89.112]) by huckleberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1lp276-0004fa-3q for fwts-devel@lists.ubuntu.com; Fri, 04 Jun 2021 05:11:20 +0000 Received: from d75-158-101-9.abhsia.telus.net ([75.158.101.9] helo=canonical.com) by youngberry.canonical.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.93) (envelope-from ) id 1lp275-0006kE-GP; Fri, 04 Jun 2021 05:11:19 +0000 From: Alex Hung To: fwts-devel@lists.ubuntu.com Subject: [PATCH 1/3] sbbr: add checks for mandatory tables Date: Thu, 3 Jun 2021 23:11:15 -0600 Message-Id: <20210604051117.428840-1-alex.hung@canonical.com> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 X-BeenThere: fwts-devel@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Firmware Test Suite Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: fwts-devel-bounces@lists.ubuntu.com Sender: "fwts-devel" This is based on Arm Server Base Boot Requirements (SBBR) 1.2 Signed-off-by: Alex Hung Acked-by: Ivan Hu Acked-by: Colin Ian King --- src/sbbr/acpitables/acpitables.c | 31 ++++++++++++++++++++++++++++++- 1 file changed, 30 insertions(+), 1 deletion(-) diff --git a/src/sbbr/acpitables/acpitables.c b/src/sbbr/acpitables/acpitables.c index fa63be64..0919250b 100644 --- a/src/sbbr/acpitables/acpitables.c +++ b/src/sbbr/acpitables/acpitables.c @@ -195,6 +195,22 @@ static int acpi_table_sbbr_check_test2(fwts_framework *fw) return FWTS_OK; } +/* List of mandatory ACPI tables (SBBR 4.2.1) */ +static const char *mandatory_acpi_tables[] = { + "RSDP", + "XSDT", + "FACP", + "DSDT", + "SSDT", + "MADT", + "GTDT", + "DBG2", + "SPCR", + "MCFG", + "PPTT", + NULL +}; + /* List of ACPI tables recommended by SBBR 4.2.2 */ static const char *recommended_acpi_tables[] = { "MCFG", @@ -235,6 +251,19 @@ static int acpi_table_sbbr_check_test3(fwts_framework *fw) { uint32_t i; + for (i = 0; mandatory_acpi_tables[i] != NULL; i++) { + fwts_acpi_table_info *info; + + info = sbbr_search_acpi_tables(fw, mandatory_acpi_tables[i]); + if (info == NULL) { + fwts_failed(fw, LOG_LEVEL_CRITICAL, "SBBRTableNotFound", + "SBBR mandatory ACPI table \"%s\" not found.", mandatory_acpi_tables[i]); + } else { + fwts_passed(fw, "SBBR mandatory ACPI table \"%s\" found.", + mandatory_acpi_tables[i]); + } + } + for (i = 0; recommended_acpi_tables[i] != NULL; i++) { fwts_acpi_table_info *info; @@ -253,7 +282,7 @@ static int acpi_table_sbbr_check_test3(fwts_framework *fw) static fwts_framework_minor_test acpi_table_sbbr_check_tests[] = { { acpi_table_sbbr_namespace_check_test1, "Test that processors only exist in the _SB namespace." }, { acpi_table_sbbr_check_test2, "Test DSDT and SSDT tables are implemented." }, - { acpi_table_sbbr_check_test3, "Check for recommended ACPI tables." }, + { acpi_table_sbbr_check_test3, "Check for mandatory and recommended ACPI tables." }, { NULL, NULL } }; From patchwork Fri Jun 4 05:11:16 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alex Hung X-Patchwork-Id: 1487573 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.ubuntu.com (client-ip=91.189.94.19; helo=huckleberry.canonical.com; envelope-from=fwts-devel-bounces@lists.ubuntu.com; receiver=) Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4Fx9pm1Tjrz9sSn for ; Fri, 4 Jun 2021 15:11:28 +1000 (AEST) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.86_2) (envelope-from ) id 1lp279-0004g8-St; Fri, 04 Jun 2021 05:11:23 +0000 Received: from youngberry.canonical.com ([91.189.89.112]) by huckleberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1lp278-0004fr-8z for fwts-devel@lists.ubuntu.com; Fri, 04 Jun 2021 05:11:22 +0000 Received: from d75-158-101-9.abhsia.telus.net ([75.158.101.9] helo=canonical.com) by youngberry.canonical.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.93) (envelope-from ) id 1lp277-0006kP-QH; Fri, 04 Jun 2021 05:11:22 +0000 From: Alex Hung To: fwts-devel@lists.ubuntu.com Subject: [PATCH 2/3] sbbr: update recommended tables Date: Thu, 3 Jun 2021 23:11:16 -0600 Message-Id: <20210604051117.428840-2-alex.hung@canonical.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210604051117.428840-1-alex.hung@canonical.com> References: <20210604051117.428840-1-alex.hung@canonical.com> MIME-Version: 1.0 X-BeenThere: fwts-devel@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Firmware Test Suite Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: fwts-devel-bounces@lists.ubuntu.com Sender: "fwts-devel" This is based on APPENDIX E of Arm Server Base Boot Requirements (SBBR) 1.2 Signed-off-by: Alex Hung Acked-by: Ivan Hu Acked-by: Colin Ian King --- src/sbbr/acpitables/acpitables.c | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/src/sbbr/acpitables/acpitables.c b/src/sbbr/acpitables/acpitables.c index 0919250b..3a378e03 100644 --- a/src/sbbr/acpitables/acpitables.c +++ b/src/sbbr/acpitables/acpitables.c @@ -213,20 +213,24 @@ static const char *mandatory_acpi_tables[] = { /* List of ACPI tables recommended by SBBR 4.2.2 */ static const char *recommended_acpi_tables[] = { - "MCFG", + /* I/O Topology */ "IORT", + /* Platform Error Interfaces */ "BERT", "EINJ", "ERST", "HEST", - "RASF", - "SPMI", + "SDEI", + /* NUMA */ "SLIT", "SRAT", - "CSRT", - "ECDT", - "MPST", + "HMAT", + /* Platform Communications Channel (PCC) */ "PCCT", + /* Platform Debug Trigger */ + "PDTT", + /* NVDIMM Firmware Interface */ + "NFIT", NULL }; From patchwork Fri Jun 4 05:11:17 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alex Hung X-Patchwork-Id: 1487575 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.ubuntu.com (client-ip=91.189.94.19; helo=huckleberry.canonical.com; envelope-from=fwts-devel-bounces@lists.ubuntu.com; receiver=) Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4Fx9pp2Hbnz9sRK for ; Fri, 4 Jun 2021 15:11:30 +1000 (AEST) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.86_2) (envelope-from ) id 1lp27B-0004gp-VU; Fri, 04 Jun 2021 05:11:25 +0000 Received: from youngberry.canonical.com ([91.189.89.112]) by huckleberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1lp27A-0004gN-8S for fwts-devel@lists.ubuntu.com; Fri, 04 Jun 2021 05:11:24 +0000 Received: from d75-158-101-9.abhsia.telus.net ([75.158.101.9] helo=canonical.com) by youngberry.canonical.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.93) (envelope-from ) id 1lp279-0006kW-Q3; Fri, 04 Jun 2021 05:11:24 +0000 From: Alex Hung To: fwts-devel@lists.ubuntu.com Subject: [PATCH 3/3] dmicheck: add type 42 to SBBR requirement Date: Thu, 3 Jun 2021 23:11:17 -0600 Message-Id: <20210604051117.428840-3-alex.hung@canonical.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210604051117.428840-1-alex.hung@canonical.com> References: <20210604051117.428840-1-alex.hung@canonical.com> MIME-Version: 1.0 X-BeenThere: fwts-devel@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Firmware Test Suite Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: fwts-devel-bounces@lists.ubuntu.com Sender: "fwts-devel" This is based on 5.2 of Arm Server Base Boot Requirements (SBBR) 1.2 Signed-off-by: Alex Hung Acked-by: Ivan Hu --- src/dmi/dmicheck/dmicheck.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/dmi/dmicheck/dmicheck.c b/src/dmi/dmicheck/dmicheck.c index fa685414..1795f5f5 100644 --- a/src/dmi/dmicheck/dmicheck.c +++ b/src/dmi/dmicheck/dmicheck.c @@ -2105,6 +2105,7 @@ static sbbr_test_entry sbbr_test[] = { { "System Boot Information", 32, 1, 0, 0 }, { "IPMI Device Information", 38, 0, "Required for platforms with IPMI BMC Interface.", 0 }, { "Onboard Devices Extended Information", 41, 0, RECOMMENDED_STRUCTURE_DEFAULT_MSG, 0 }, + { "Redfish Host Interface", 42, 0, "Required for platforms supporting Redfish Host Interface[8].", 0 }, { 0, 0, 0, 0, 0 } };