From patchwork Wed Jun 2 10:17:02 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1486550 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=linux-ide-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=W38vU/EW; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4Fw4jC1pjCz9sRN for ; Wed, 2 Jun 2021 20:17:51 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231287AbhFBKT3 (ORCPT ); Wed, 2 Jun 2021 06:19:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37890 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229963AbhFBKTV (ORCPT ); Wed, 2 Jun 2021 06:19:21 -0400 Received: from mail-wr1-x42d.google.com (mail-wr1-x42d.google.com [IPv6:2a00:1450:4864:20::42d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B782CC061574 for ; Wed, 2 Jun 2021 03:17:36 -0700 (PDT) Received: by mail-wr1-x42d.google.com with SMTP id z17so1707676wrq.7 for ; Wed, 02 Jun 2021 03:17:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ontm/1WjcLjJ2DXWD0FtXaoVFZvxs8qoCFJzel5PQ0U=; b=W38vU/EW6bYFmOA3g3xYUpPqncKZOBFgP9FE8Tajyv8VOuIXHZ4sFj45NbAfVw0Ztd X06O3VbAHu8/lN5gKQtvHjeMujdGrrBTh/agWJMJDKUyQkiOnzYXyWAQ63rqOwH7YCG8 J0T7+GhlyneCD1udpwhQUdG7Cg+YCHkEK9ptIA96DFfoM61B+eRVWWbt5ii5JE+BS9wj 6NOMO+Ee7cbGi1qaoR0lsUCGc2e8HPpT0dqFUjCerFFZmDCrFxHMEC5X3gfkv+mW8/j/ ww5GYUMGGVOdhZV7vUlReDDba0yi/UUCcg8hMwKrNto9/D0LhSAnD8Ci+B4f6pyyzFRD LP3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ontm/1WjcLjJ2DXWD0FtXaoVFZvxs8qoCFJzel5PQ0U=; b=YOOrIiyKQYlge6GUBdpZQOzHu7PBU4p0xgPI16Gvm0aEOCx+E+DZeo7I/p4sIK/vBA wDtz3FQvFuFQzXvH82UtA5HtkxaN+LuU1DosZ5v8s4F9GrK9R9hLTnDUk+A9KcdSuCNr TVV6oz0kYW7AqGvuoYeNllhsjJkedXfW+k4Pd+k/mvONc3ow04xTX47IF1zol/Nc3Eg9 CJaenZzAkkWz4tP4RlpbdyuwkzQPz9LhZlNZ7ABVIQ9FmljTXYnlBiH4mi9N/VfnT4YR OjquFI43O2dXkiKAePi0KZjn1Wgc20uu5BpWga6J+gsZ92RNjccHrnR/vypQYtu9dTNJ xw9w== X-Gm-Message-State: AOAM5317co3LuaudROVMKQKRZI4YaAGGc7I5rhn7EHpzTF3iK/6Bya98 ixs3Fkxc679Ob8UgdWNBj2U/dA== X-Google-Smtp-Source: ABdhPJw86cyIoSYEuZJ5FX7mQpXBSkjDtnc6mTjjIZvtpDICzcmb8kvc5REqdHugefdD2Pndm3mV0Q== X-Received: by 2002:a05:6000:50d:: with SMTP id a13mr31458994wrf.130.1622629055271; Wed, 02 Jun 2021 03:17:35 -0700 (PDT) Received: from dell.default ([91.110.221.214]) by smtp.gmail.com with ESMTPSA id q11sm1593265wmq.1.2021.06.02.03.17.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Jun 2021 03:17:34 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, "David S. Miller" , CJ , Andre Hedrick , Clear Zhang , "Software, Inc" , linux-ide@vger.kernel.org Subject: [PATCH 01/21] ide: alim15x3: Document alim15x3_init_one()'s 'id' param Date: Wed, 2 Jun 2021 11:17:02 +0100 Message-Id: <20210602101722.2276638-2-lee.jones@linaro.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210602101722.2276638-1-lee.jones@linaro.org> References: <20210602101722.2276638-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/ide/alim15x3.c:536: warning: Function parameter or member 'id' not described in 'alim15x3_init_one' Cc: "David S. Miller" Cc: CJ Cc: Andre Hedrick Cc: Clear Zhang Cc: "Software, Inc" Cc: linux-ide@vger.kernel.org Signed-off-by: Lee Jones --- drivers/ide/alim15x3.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/ide/alim15x3.c b/drivers/ide/alim15x3.c index a5043e048f919..39684d12d45e5 100644 --- a/drivers/ide/alim15x3.c +++ b/drivers/ide/alim15x3.c @@ -526,6 +526,7 @@ static const struct ide_port_info ali15x3_chipset = { /** * alim15x3_init_one - set up an ALi15x3 IDE controller * @dev: PCI device to set up + * @id: PCI ID * * Perform the actual set up for an ALi15x3 that has been found by the * hot plug layer. From patchwork Wed Jun 2 10:17:03 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1486552 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=linux-ide-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=ZUfSZ4r0; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4Fw4jD1qJ5z9sVt for ; Wed, 2 Jun 2021 20:17:52 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232552AbhFBKTc (ORCPT ); Wed, 2 Jun 2021 06:19:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37902 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230019AbhFBKTV (ORCPT ); Wed, 2 Jun 2021 06:19:21 -0400 Received: from mail-wr1-x42b.google.com (mail-wr1-x42b.google.com [IPv6:2a00:1450:4864:20::42b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 87BD8C06175F for ; Wed, 2 Jun 2021 03:17:37 -0700 (PDT) Received: by mail-wr1-x42b.google.com with SMTP id c5so1693578wrq.9 for ; Wed, 02 Jun 2021 03:17:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=PRiZwQegLpypubO5RDSe3DP9cu33cnkzeqlprh/CdBE=; b=ZUfSZ4r0ekbkpPypl3sk1km/yceuPaZX/SY6m3/ZXJ0hdoag99pOdEO8woYlHrGcay HCEyu3A9jwOj9rCZzIKhMsCvDO/kzr2Ic/4nbO27wnUZV3htekju4sNnUs+k74DFYjud lqP/ilTWQBHCnfFvLrpaWcv4R3HCMTZ2X7M/gx6/Nn2mulCd7hmZFyRoFgB8WYteA9Ss dx4NyxcZvuqSDrB606jkskMBbITNsmNc8HeIxDfsx0VOu4Y1ni96TKkOxxdtKRv57Vo1 5Lf5wsq8t3MnSRHHSaEmgaFOzLCTht+k+dEO0XLXPGe5hG4xSYmPUkxVnsGKsPwgYo5z jwng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=PRiZwQegLpypubO5RDSe3DP9cu33cnkzeqlprh/CdBE=; b=e71RlWN/t7PdAYYnzuTXw7EEOTKdtMvhm/yjeOxiY7RXNsV/ctMzssFyrt4ywZFk8X APUnqp5t3vW2M+iBljEL9oRayhxYDJIO2zE3Jo3DcwJBfgApyFnjvenemdFEF6YEK3tT zpuQwipnYrG/MnyzDWzItvxrsLHp+5FdDt7XqIo2lq1vr3Rz59cguDgXyRf1W6cyaSnB 88YJMNkWnhFi6Ebw3UR9G7/v07RRqgbCwuAJ7XgRJtaXPtR15XRjuq31aTQDJLBisewq 1HxZiNi+aTSNfymTIDI2nXEZpZ1RCyyFZY9Drv5jO7dggYm4t7mf52aWLovLQ2WljBtJ n1aA== X-Gm-Message-State: AOAM533o4Hw888pNEsuqC++TTv987ht93orBU1mAFEEu4mi32Ccvr1At 0YYvXNaQMs8slDXWZUR3z2hlwnTyeMiHNQ== X-Google-Smtp-Source: ABdhPJyuqmvlr5+2IkzIX35PecGhQyKutFppvcuVEeUcNmlIAib4OdjJW/cMx5u/U616oGKIkq9ssw== X-Received: by 2002:a5d:5271:: with SMTP id l17mr25855771wrc.142.1622629056202; Wed, 02 Jun 2021 03:17:36 -0700 (PDT) Received: from dell.default ([91.110.221.214]) by smtp.gmail.com with ESMTPSA id q11sm1593265wmq.1.2021.06.02.03.17.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Jun 2021 03:17:35 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, "David S. Miller" , Andre Hedrick , "Christopher J. Reimer" , Benoit Poulot-Cazajous , Christian Brunner , Robert Bringman , linux-ide@vger.kernel.org Subject: [PATCH 02/21] ide: ide-dma: Document ide_dma_unmap_sg()'s missing 'cmd' param Date: Wed, 2 Jun 2021 11:17:03 +0100 Message-Id: <20210602101722.2276638-3-lee.jones@linaro.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210602101722.2276638-1-lee.jones@linaro.org> References: <20210602101722.2276638-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/ide/ide-dma.c:165: warning: Function parameter or member 'cmd' not described in 'ide_dma_unmap_sg' Cc: "David S. Miller" Cc: Andre Hedrick Cc: "Christopher J. Reimer" Cc: Benoit Poulot-Cazajous Cc: Christian Brunner Cc: Robert Bringman Cc: linux-ide@vger.kernel.org Signed-off-by: Lee Jones --- drivers/ide/ide-dma.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/ide/ide-dma.c b/drivers/ide/ide-dma.c index 6f344654ef229..a02d02ad9ea23 100644 --- a/drivers/ide/ide-dma.c +++ b/drivers/ide/ide-dma.c @@ -153,6 +153,7 @@ static int ide_dma_map_sg(ide_drive_t *drive, struct ide_cmd *cmd) /** * ide_dma_unmap_sg - clean up DMA mapping * @drive: The drive to unmap + * @cmd: The IDEcommand * * Teardown mappings after DMA has completed. This must be called * after the completion of each use of ide_build_dmatable and before From patchwork Wed Jun 2 10:17:04 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1486553 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=linux-ide-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=SRPujFKD; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4Fw4jK2Ssmz9sVb for ; Wed, 2 Jun 2021 20:17:57 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230019AbhFBKTd (ORCPT ); Wed, 2 Jun 2021 06:19:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37906 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230034AbhFBKTV (ORCPT ); Wed, 2 Jun 2021 06:19:21 -0400 Received: from mail-wr1-x435.google.com (mail-wr1-x435.google.com [IPv6:2a00:1450:4864:20::435]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 75CECC061760 for ; Wed, 2 Jun 2021 03:17:38 -0700 (PDT) Received: by mail-wr1-x435.google.com with SMTP id h8so1698240wrz.8 for ; Wed, 02 Jun 2021 03:17:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=JYcpB4gr4G9b2N/HTEwmEP3ZKhvHq1OB6C2fuW7h01g=; b=SRPujFKDl9FG5cjbsJZqcYMVAtYY7G8LN7erKFPkE6GmvyX4My3D2twyDhgc9eIxqE 7FeRVBOGkN9zRhpg2Z8zxe/GWg5+z5CIXaTjxExBU24lmunFMz7C/u468F2bu+hPTIUS ts7muC4hg1Dov0Mw3GirBXa6Q1RzqQpVYNu6/LXdXreFrODTbnR2bkTZI/Bq5t+93Uia gmeZx02H1ItteO8NfGBXztBcjtVaphcHYQ2K1hupnTZt6OwAbIduK0CzwIYQqkeGaMGM 7co1rWuwrt2910az35uAjSnN9xF4TriNf81GLNPRheX3VD6iby6IOxMuDqdRCtQs3AKK IcqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=JYcpB4gr4G9b2N/HTEwmEP3ZKhvHq1OB6C2fuW7h01g=; b=OAuiSy/aHSunuBoQC9qCfRqDcJVFV9+cFrZsS4tm12hC3WfcTnGyZ0VUDQpXc1gn6+ 5zQckmHQZYC1Hj4appLLHwPTPstwpqtR7EDERuYXn8nNiP3OGHHaHbObaJmNoKHJQ5Kq 4fvrVVHaKWhwVE1wF+aBcYGv/a8Xe1sIv6S/CNYUbNCd6FfYV4bb+dFdGiVKHCiFpPaq +quCK4cQ1wz4VEaDjBdPPYzahHGQ69cwPjA2TL0SVm3msYZI1/x9daR4P3D+aFwzmFYd 3Cwyium7R7tAn/FoR9wuFtHpVa/rEUofpU1cvUJesNKO8irUtCEL/CkOCvObzFI/LMt9 CY6w== X-Gm-Message-State: AOAM530/NgvRYWaiNb1jC33EXjIcyH1SCBWfDGcLJpLgWEox2LUptDBa zS4c2VpVSZrtQNy4hqALjg89nFJE4J73Fw== X-Google-Smtp-Source: ABdhPJz8e++rnMpw2N98w8tVzPOnJlN85qJszJwSFdMRp5oMLbXduiYRmh5S6pRNG2utPxKqiYMKGg== X-Received: by 2002:a5d:4b05:: with SMTP id v5mr644878wrq.330.1622629057037; Wed, 02 Jun 2021 03:17:37 -0700 (PDT) Received: from dell.default ([91.110.221.214]) by smtp.gmail.com with ESMTPSA id q11sm1593265wmq.1.2021.06.02.03.17.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Jun 2021 03:17:36 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, "David S. Miller" , linux-ide@vger.kernel.org Subject: [PATCH 03/21] ide: ide-dma-sff: Provide some missing 'param' descriptions Date: Wed, 2 Jun 2021 11:17:04 +0100 Message-Id: <20210602101722.2276638-4-lee.jones@linaro.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210602101722.2276638-1-lee.jones@linaro.org> References: <20210602101722.2276638-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/ide/ide-dma-sff.c:84: warning: Function parameter or member 'on' not described in 'ide_dma_host_set' drivers/ide/ide-dma-sff.c:116: warning: Function parameter or member 'drive' not described in 'ide_build_dmatable' drivers/ide/ide-dma-sff.c:116: warning: Function parameter or member 'cmd' not described in 'ide_build_dmatable' Cc: "David S. Miller" Cc: linux-ide@vger.kernel.org Signed-off-by: Lee Jones --- drivers/ide/ide-dma-sff.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/ide/ide-dma-sff.c b/drivers/ide/ide-dma-sff.c index b7c2c0bd18b53..8603df4d92fd8 100644 --- a/drivers/ide/ide-dma-sff.c +++ b/drivers/ide/ide-dma-sff.c @@ -75,6 +75,7 @@ static void ide_dma_sff_write_status(ide_hwif_t *hwif, u8 val) /** * ide_dma_host_set - Enable/disable DMA on a host * @drive: drive to control + * @on: whether to enable/disable the IDE controller's DMA * * Enable/disable DMA on an IDE controller following generic * bus-mastering IDE controller behaviour. @@ -98,6 +99,9 @@ EXPORT_SYMBOL_GPL(ide_dma_host_set); /** * ide_build_dmatable - build IDE DMA table * + * @drive: The drive to unmap + * @cmd: The IDEcommand + * * ide_build_dmatable() prepares a dma request. We map the command * to get the pci bus addresses of the buffers and then build up * the PRD table that the IDE layer wants to be fed. From patchwork Wed Jun 2 10:17:05 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1486551 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=linux-ide-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=qo69oY96; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4Fw4jC6LBfz9sVb for ; Wed, 2 Jun 2021 20:17:51 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229963AbhFBKTa (ORCPT ); Wed, 2 Jun 2021 06:19:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37916 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231603AbhFBKTX (ORCPT ); Wed, 2 Jun 2021 06:19:23 -0400 Received: from mail-wr1-x42b.google.com (mail-wr1-x42b.google.com [IPv6:2a00:1450:4864:20::42b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 48C0DC06174A for ; Wed, 2 Jun 2021 03:17:39 -0700 (PDT) Received: by mail-wr1-x42b.google.com with SMTP id n4so1722143wrw.3 for ; Wed, 02 Jun 2021 03:17:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=QpdMnI6lZJkCsy5Zu72i+Sr+X0vOIx3MmORUdfJ8hyo=; b=qo69oY96cVUgH8CpEF59JQYnnYv8mujBkgwt6mI0UM9Ft4rpPiJVpF3/ba9d0F/VWp L9FyXSWm1qMTX5tTrEYMOVMoSnt7amQatRyAXHjUrb+Fo0zLT/SkHNEjSVL5CLbo0cwu sM94BJzV5T+oXjhDiLZJMmZVUy+9XpegtpAl0AkDWJewnPL6kGFDxX3NBb127iv1JbF6 depeUZtcFTTJIl1UvHaBEMQnMhbJURuxwlMt+1tCBXKpuYVBInsqz17O2ThoNFiGmtP9 TosOsEmGLtJ+TEHCtLSJg1rbTa/x3cf2Dl2pwpLsbzHYylMToTjlOWt5qMVdHwJ6pWJ9 DkcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=QpdMnI6lZJkCsy5Zu72i+Sr+X0vOIx3MmORUdfJ8hyo=; b=nPCG04vobH3/Wu5+JbFspz2i7DCqk+azAJcB4Q8HfGWF6N7yDtbzhzlVKWPQaa8T80 Lu1rIK1OuIOUwCZjK0JTlnpxg61r74+19mmF76zQ1bVZqa8MGqcgvANXN51jRdngPkis CL5IJy5d8Thw/8abO2SSapd++8fNpIitUWPFlbjDsydmSoKzHgQtYsEwb1VgVl15zma9 8OcY7B/BiyuiUjCm1oMbDPpfJGDqik0/6ewjVarF18jUWVyaw5rowARZx5iXtPMjadcV YeKU25sR1oAvRJ2X8qR0tlRj/VBKFphL9gOcyxEHy8J1fNcfqX7ySUD5GtcX7o4Wpp7p B1rA== X-Gm-Message-State: AOAM530Y+k5PkzfyM5gDvCJzHjVAn4KvXiwJNelFk+qaX9BlKJk71pIF af0cHm6plSuY7JKqHK/pZ+RfSQ== X-Google-Smtp-Source: ABdhPJyqhVwJ6SErn3vAKpl//MuZ6EJt1iRS2OS+xAv6VopJ6veIdjnTf69oRlL5y6+EI+yzQuWlgw== X-Received: by 2002:a5d:59a4:: with SMTP id p4mr33511361wrr.248.1622629057868; Wed, 02 Jun 2021 03:17:37 -0700 (PDT) Received: from dell.default ([91.110.221.214]) by smtp.gmail.com with ESMTPSA id q11sm1593265wmq.1.2021.06.02.03.17.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Jun 2021 03:17:37 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, "David S. Miller" , linux-ide@vger.kernel.org Subject: [PATCH 04/21] ide: ide-io: Fix a few kernel-doc misdemeanours Date: Wed, 2 Jun 2021 11:17:05 +0100 Message-Id: <20210602101722.2276638-5-lee.jones@linaro.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210602101722.2276638-1-lee.jones@linaro.org> References: <20210602101722.2276638-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/ide/ide-io.c:268: warning: expecting prototype for execute_drive_command(). Prototype was for execute_drive_cmd() instead drivers/ide/ide-io.c:320: warning: Function parameter or member 'drive' not described in 'start_request' drivers/ide/ide-io.c:320: warning: Function parameter or member 'rq' not described in 'start_request' drivers/ide/ide-io.c:618: warning: Function parameter or member 't' not described in 'ide_timer_expiry' drivers/ide/ide-io.c:618: warning: Excess function parameter 'data' description in 'ide_timer_expiry' drivers/ide/ide-io.c:775: warning: Excess function parameter 'regs' description in 'ide_intr' Cc: "David S. Miller" Cc: linux-ide@vger.kernel.org Signed-off-by: Lee Jones --- drivers/ide/ide-io.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/ide/ide-io.c b/drivers/ide/ide-io.c index 4867b67b60d69..bd3e78985bcc7 100644 --- a/drivers/ide/ide-io.c +++ b/drivers/ide/ide-io.c @@ -252,7 +252,7 @@ void ide_init_sg_cmd(struct ide_cmd *cmd, unsigned int nr_bytes) EXPORT_SYMBOL_GPL(ide_init_sg_cmd); /** - * execute_drive_command - issue special drive command + * execute_drive_cmd - issue special drive command * @drive: the drive to issue the command on * @rq: the request structure holding the command * @@ -309,6 +309,8 @@ static ide_startstop_t ide_special_rq(ide_drive_t *drive, struct request *rq) /** * start_request - start of I/O and command issuing for IDE + * @drive: the drive to issue the command on + * @rq: the request structure holding the command * * start_request() initiates handling of a new I/O request. It * accepts commands and I/O (read/write) requests. @@ -602,7 +604,7 @@ static int drive_is_ready(ide_drive_t *drive) /** * ide_timer_expiry - handle lack of an IDE interrupt - * @data: timer callback magic (hwif) + * @t: timer callback magic (hwif) * * An IDE command has timed out before the expected drive return * occurred. At this point we attempt to clean up the current @@ -748,9 +750,7 @@ static void unexpected_intr(int irq, ide_hwif_t *hwif) /** * ide_intr - default IDE interrupt handler - * @irq: interrupt number * @dev_id: hwif - * @regs: unused weirdness from the kernel irq layer * * This is the default IRQ handler for the IDE layer. You should * not need to override it. If you do be aware it is subtle in From patchwork Wed Jun 2 10:17:06 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1486556 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=linux-ide-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=i5fH5Cf/; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4Fw4jQ1W3Nz9sVb for ; Wed, 2 Jun 2021 20:18:02 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229603AbhFBKTm (ORCPT ); Wed, 2 Jun 2021 06:19:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37916 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232523AbhFBKTa (ORCPT ); Wed, 2 Jun 2021 06:19:30 -0400 Received: from mail-wr1-x42d.google.com (mail-wr1-x42d.google.com [IPv6:2a00:1450:4864:20::42d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0FCABC0613CE for ; Wed, 2 Jun 2021 03:17:40 -0700 (PDT) Received: by mail-wr1-x42d.google.com with SMTP id h8so1698339wrz.8 for ; Wed, 02 Jun 2021 03:17:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=w2U6dF+hH5gwzcoqkIhyeiAxmO4AyHDuMvjSLxOZWmU=; b=i5fH5Cf/5TlEl8yM0M75Pv5KaKc40eGR7Z7O4pPGlsTzewG+uV4TditU/mWxxLCfg/ ri2gFrE2zZZ9hdZwK4ZM3EzybMarGmmonOe5u9PHg66NoG34MbN/tS+30FrRcBmIsgrh YB0pFRuLkDV6b6pkGB+93Zkj+wnWeGLwmv1WUOcpfoQbl5664IYp4+cO7Cr6Ncl57J+N IF6Tzd3suzO3rKdbnsqjQK/Pn4uY4QeyZPQyLIFssD6hhf5m9vNAfZ+RgUnvtuTlgiuK aoWjiBsYkVn/ktG1w/fl79TXaGzN3yT/dVKAgsJvDhWCh+z3JD8UJ/SNN7iASUV48GH1 FJJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=w2U6dF+hH5gwzcoqkIhyeiAxmO4AyHDuMvjSLxOZWmU=; b=pTIccVmF+zohITVmpWul1VkpfGZR6Tzgie7bQ5pPKomgn6EnWFFcKLl+880nnGKaKp j/Vj4qUJufT40pgwjQtiSEjUDOummjNEYbQe3w+MGhOjxziRz+ckMtECSLxMsU+GKMKn t38+creD/mpNYTkOzJmZGQkQFJzd07qvO4s1ENxSuMYa5WYQ/4HLLZ/DjAqapwUpTPSK xwcQQPql+4FwnzIKeKjtwyASN7viVVGi2eiAlpWFIBvH2bhg38pPDyV/7yiRyxDIHDQS J1fv458kSCaxxWuTrBVwAH9qbYRSDsp1HpMXH053YACYXc9xuDInzzuiXShJpyQVlhMk quVA== X-Gm-Message-State: AOAM531ylRQC4Iz56mDgynNb73giuODTyhMrymAwbG29amg5g2Hz06LS +fM6PmQTBnDgrsn0pCDpxVdmc3AEhw+dVA== X-Google-Smtp-Source: ABdhPJwMO3wIYStENRGS/URkPemZcpjcLQZbT3eJrVPOcBZQB9pqIW/KfTzr7p0k0DOd5k/LO9jmFQ== X-Received: by 2002:adf:e788:: with SMTP id n8mr19645605wrm.387.1622629058742; Wed, 02 Jun 2021 03:17:38 -0700 (PDT) Received: from dell.default ([91.110.221.214]) by smtp.gmail.com with ESMTPSA id q11sm1593265wmq.1.2021.06.02.03.17.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Jun 2021 03:17:38 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, "David S. Miller" , linux-ide@vger.kernel.org Subject: [PATCH 05/21] ide: ide-proc: Strip out unused fops structure and accompanying call-back Date: Wed, 2 Jun 2021 11:17:06 +0100 Message-Id: <20210602101722.2276638-6-lee.jones@linaro.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210602101722.2276638-1-lee.jones@linaro.org> References: <20210602101722.2276638-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/ide/ide-proc.c:457:37: warning: ‘ide_media_proc_fops’ defined but not used [-Wunused-const-variable=] Fixes: ec7d9c9ce897 ("ide: replace ->proc_fops with ->proc_show") Cc: "David S. Miller" Cc: linux-ide@vger.kernel.org Signed-off-by: Lee Jones --- drivers/ide/ide-proc.c | 13 ------------- 1 file changed, 13 deletions(-) diff --git a/drivers/ide/ide-proc.c b/drivers/ide/ide-proc.c index 15c17f3781ee9..34bed14f88c78 100644 --- a/drivers/ide/ide-proc.c +++ b/drivers/ide/ide-proc.c @@ -449,19 +449,6 @@ static int ide_media_proc_show(struct seq_file *m, void *v) return 0; } -static int ide_media_proc_open(struct inode *inode, struct file *file) -{ - return single_open(file, ide_media_proc_show, PDE_DATA(inode)); -} - -static const struct file_operations ide_media_proc_fops = { - .owner = THIS_MODULE, - .open = ide_media_proc_open, - .read = seq_read, - .llseek = seq_lseek, - .release = single_release, -}; - static ide_proc_entry_t generic_drive_entries[] = { { "driver", S_IFREG|S_IRUGO, ide_driver_proc_show }, { "identify", S_IFREG|S_IRUSR, ide_identify_proc_show }, From patchwork Wed Jun 2 10:17:07 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1486554 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=linux-ide-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=bSW6ZL+7; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4Fw4jN4M61z9sT6 for ; Wed, 2 Jun 2021 20:18:00 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232568AbhFBKTf (ORCPT ); Wed, 2 Jun 2021 06:19:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37946 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232514AbhFBKT3 (ORCPT ); Wed, 2 Jun 2021 06:19:29 -0400 Received: from mail-wm1-x333.google.com (mail-wm1-x333.google.com [IPv6:2a00:1450:4864:20::333]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 13473C06138B for ; Wed, 2 Jun 2021 03:17:41 -0700 (PDT) Received: by mail-wm1-x333.google.com with SMTP id o127so908302wmo.4 for ; Wed, 02 Jun 2021 03:17:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=IaN8N4SwEQrPn+u2HQ3FO/LZbSLlVWFBVcnYwdv3wCs=; b=bSW6ZL+7zZa+QM2ud7nV1QPCqrO5jzc/kHE/vu13Io5qxhLSNzel/Xcaokg8btp8uh FL56n8T+a95Muw3fPonKg9Efx7uJ96x5sUt3BCFgs8FOYSA2igouWXZl28yPG214GWcH QoxHQcvisOjfyHtuaPt+ZZqFQbCpCq/RljymK1gfuxYqfESCyoY0KPfU98koEITUjn8S +Tk1wW+FQ78x5kLAfk+BHpIJgdRmcWDEr6Wvw2lDvQhah0xCbvKV5odlai/ZfGf64MVL DIIoBiqYFOEmABHJVEoDh1WG/lF+JavEJA7hgJlnwiEmx2EVHMgX0O/b2VBroxD92rGn OL+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=IaN8N4SwEQrPn+u2HQ3FO/LZbSLlVWFBVcnYwdv3wCs=; b=Nq+e5i9BCiFjSN1qUVw7KN9mAoI/FjRvH/kcU3O2QjNWxsxli9Ln4df5SynbCm36+t 9ITwamyGmEUEj4IEsq+w8gnrs9f0bCIQD9oMBfo98iO7dnd91Cf2jXhGJYnxAcuDMg1Y cPfPetELmIqn1UecJKbrSqlno27EJLBTlLsx5u8p7m5QQMwXWh5sqxm7hGG0/myaqlQH IFIbdacAmJY5XyvLBSR5ZMjK2DlU2g8SV4RehLdb0vz3UhiffvNKGUHcfGSYZ3QMi/4r Jv+P6obSIC0d/9FoZlltxF5QvRRPHiCPLjdhX5Jnv0jTWJ2iv05q/1Tvws/31K2TxV2U fcZA== X-Gm-Message-State: AOAM532VoIVIBrTGAPyyN42eKEsG/WE/kyHrqrgZ/tQNtLLL0+S8XGxs l7G7hqHnI3riXCAp2DXROpLJNlIA4A1uVw== X-Google-Smtp-Source: ABdhPJxzD2xGXtYBHZW16DWMzaAyYT814nTJ/1+jt7r3sr74FSs387lxf3C8y47yqKxFz6W+MG9v5g== X-Received: by 2002:a05:600c:255:: with SMTP id 21mr2635741wmj.46.1622629059678; Wed, 02 Jun 2021 03:17:39 -0700 (PDT) Received: from dell.default ([91.110.221.214]) by smtp.gmail.com with ESMTPSA id q11sm1593265wmq.1.2021.06.02.03.17.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Jun 2021 03:17:39 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, "David S. Miller" , Andre Hedrick , Mark Lord , linux-ide@vger.kernel.org Subject: [PATCH 06/21] ide: cs5530: Fix incorrect documentation for function init_chipset_cs5530() Date: Wed, 2 Jun 2021 11:17:07 +0100 Message-Id: <20210602101722.2276638-7-lee.jones@linaro.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210602101722.2276638-1-lee.jones@linaro.org> References: <20210602101722.2276638-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/ide/cs5530.c:139: warning: expecting prototype for init_chipset_5530(). Prototype was for init_chipset_cs5530() instead Cc: "David S. Miller" Cc: Andre Hedrick Cc: Mark Lord Cc: linux-ide@vger.kernel.org Signed-off-by: Lee Jones --- drivers/ide/cs5530.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/ide/cs5530.c b/drivers/ide/cs5530.c index 5bb46e7130c8a..366be8c978a6e 100644 --- a/drivers/ide/cs5530.c +++ b/drivers/ide/cs5530.c @@ -129,7 +129,7 @@ static void cs5530_set_dma_mode(ide_hwif_t *hwif, ide_drive_t *drive) } /** - * init_chipset_5530 - set up 5530 bridge + * init_chipset_cs5530 - set up 5530 bridge * @dev: PCI device * * Initialize the cs5530 bridge for reliable IDE DMA operation. From patchwork Wed Jun 2 10:17:08 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1486555 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=linux-ide-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=O6EsFgNy; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4Fw4jP6KGRz9sT6 for ; Wed, 2 Jun 2021 20:18:01 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231902AbhFBKTl (ORCPT ); Wed, 2 Jun 2021 06:19:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37952 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229524AbhFBKTa (ORCPT ); Wed, 2 Jun 2021 06:19:30 -0400 Received: from mail-wm1-x335.google.com (mail-wm1-x335.google.com [IPv6:2a00:1450:4864:20::335]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F2D46C06138E for ; Wed, 2 Jun 2021 03:17:41 -0700 (PDT) Received: by mail-wm1-x335.google.com with SMTP id u5-20020a7bc0450000b02901480e40338bso1016009wmc.1 for ; Wed, 02 Jun 2021 03:17:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=YbCVMb/2RduaP3NxcfVvRqjH6K2Y3C6V43YOwvPOwMo=; b=O6EsFgNyHAS9vEi2z8XPy1Ca5thrAad0/1nVqP+6uFgFy5KxXKPtDVxNlK8o4T/TcN IrnFqTsPyUeJxlF8Ocssr7y+i4Xk2qgguOHOc0mV1lpXCkjg1ZaaGIjF2ceK/01C9aWw KcxCy3hPDLhhA2Vtc7TNFFqINEpwh1240cRlGSeLAAnW+89TJXZD/RwlEULLcfN649kg bZX6gOXReyW4n/2zEpJAABq4PxuaVmDIGC32jLoYW2B2D2gD5mxzmpJKBG/J7txPAkAb jmbUMueShG3M/QmKjdEhl+Zh7CTksIpUaPvHnrVq+nV3GgzHHF/eLVrRofsQsx1SWR0W DgWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=YbCVMb/2RduaP3NxcfVvRqjH6K2Y3C6V43YOwvPOwMo=; b=FpPRdXPyPNoJ2lcVvg1YTkeSTXMNJs9Ypqli6OFeacEpZvkaQB37TS2joeaaR91g5m 1Sqnx/HjZk+zOLntyaKD+vlGXiD/VRPWx0MKxlqogGhCu2xLIz6mSQaXWcRSoUiqJFeR O2jMoTpl4gXvX0sSMJnhebP+cSL4SNKAGxbcdHp13/VrZhOl7k+1jaEenpmeP/arSRrr H8UrFbRMAKp67mffvoZ+rKKf+o4D6+hk8jBJ5/1FxR2OxuAP1iLZuuWnr5Mamn1gy86p 8j4YWHAFWlqqeMNKo2uDt8/4uoQkdWGshGUSo4FlakzLoeldam8IzF/vwdUzCxrAq/Ft KgVA== X-Gm-Message-State: AOAM530w4jsiam6YIEBk3T5TlnvEW+xATtGkjBOU0bbil0KAPjG1O7Zv +kRCyrgNSlNmLkxyjZjsOP17qg== X-Google-Smtp-Source: ABdhPJxx5ArY9ys2+XV4uFcG+agvW9o6SVbd6qQk6h8GpabBTzeaHEUe67VMmppIwU1BTokwk2RGLg== X-Received: by 2002:a05:600c:2250:: with SMTP id a16mr4457914wmm.189.1622629060508; Wed, 02 Jun 2021 03:17:40 -0700 (PDT) Received: from dell.default ([91.110.221.214]) by smtp.gmail.com with ESMTPSA id q11sm1593265wmq.1.2021.06.02.03.17.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Jun 2021 03:17:40 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, "David S. Miller" , Mark Lord , Gadi Oxman , Andre Hedrick , support to Subject: [PATCH 07/21] ide: ide-probe: Fix-up incorrectly documented function probe_for_drive() Date: Wed, 2 Jun 2021 11:17:08 +0100 Message-Id: <20210602101722.2276638-8-lee.jones@linaro.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210602101722.2276638-1-lee.jones@linaro.org> References: <20210602101722.2276638-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/ide/ide-probe.c:476: warning: expecting prototype for probe_for_drives(). Prototype was for probe_for_drive() instead Cc: "David S. Miller" Cc: Mark Lord Cc: Gadi Oxman Cc: Andre Hedrick Cc: support to Cc: linux-ide@vger.kernel.org Signed-off-by: Lee Jones --- drivers/ide/ide-probe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/ide/ide-probe.c b/drivers/ide/ide-probe.c index aefd74c0d8628..c1fde697657d7 100644 --- a/drivers/ide/ide-probe.c +++ b/drivers/ide/ide-probe.c @@ -461,7 +461,7 @@ static int do_probe (ide_drive_t *drive, u8 cmd) } /** - * probe_for_drives - upper level drive probe + * probe_for_drive - upper level drive probe * @drive: drive to probe for * * probe_for_drive() tests for existence of a given drive using do_probe() From patchwork Wed Jun 2 10:17:09 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1486557 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=linux-ide-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=BDdcauGS; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4Fw4jT26kKz9sT6 for ; Wed, 2 Jun 2021 20:18:05 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230178AbhFBKTp (ORCPT ); Wed, 2 Jun 2021 06:19:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37906 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232543AbhFBKTb (ORCPT ); Wed, 2 Jun 2021 06:19:31 -0400 Received: from mail-wm1-x32d.google.com (mail-wm1-x32d.google.com [IPv6:2a00:1450:4864:20::32d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 14656C061343 for ; Wed, 2 Jun 2021 03:17:43 -0700 (PDT) Received: by mail-wm1-x32d.google.com with SMTP id h5-20020a05600c3505b029019f0654f6f1so2891408wmq.0 for ; Wed, 02 Jun 2021 03:17:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=oC9NQ9021w3IDCN0kWXfKOwdq7JNsN8GscpJCnjZMl0=; b=BDdcauGSENaWJe4pI5Cw+RyVU5FDkuoCPZZKUFubXyxrEkSCeDLqDHmAUA5z3U4f+H OIzPOicIlZJWR85BSWLhd0fZ2gRIXU+5m5ynwTbq8hWfnr5A6ktHKk89dwAK7i6LVPRg RyE6McgSDUbH6tl++hb2Pc7C+680MUsAN96wtPkyyV5pCR6i1/vPrL7oIEyADhZ8U5f4 gcLtWnOGVTJyPlOWIlRs+wcmTWJKoEIU1SbsvIxNaG91sLnNJ7A6OuTDstAU3c48MdB/ K+/8U0RAYoXig3eLMzdar254k7SNQgfs2CR1/OZxYWkcXhr41A1ELhvlTJ6rMxDL7aNw IS0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=oC9NQ9021w3IDCN0kWXfKOwdq7JNsN8GscpJCnjZMl0=; b=CpkoniqWiMe3ZQ4qJnDwTEUa7wophQSpWOvuVXYB4FdB66U0gUKDRgZwETWim/Fs6Z xkWqdA5ySmn0zaO85eu/NQnTrgySkUHBeKt1i8nRVzwhwPNch2kfed4rZxi1l8gBu1zr EPbC2wK2aed8tsxX1nJvB0/L+Hc6MglKrqdwac/ycxQ7cLqmLftH9ozuYWNhIQ1JIw8x gRvrDTh3JD29cVDDFRGNb0bBgF30OudfF8Q4cpjJ8Rqi0sw4mQRaaFkoLgiDwLAUxwNA cgM1J9vyatQvyfPISgdg7KFtZaK6CKKxlJhFvhAm+/08ehJE8tYmokJmU2GFkIz24lRW fgOA== X-Gm-Message-State: AOAM5300Xo7ahbLPr0x7ch2E3GedY6OSgrRzRewjF/PAUaDKO3m5bmFp 1wD96J2h+Wdzq3NBeC09G8+HEw== X-Google-Smtp-Source: ABdhPJx1x9r9KkQCQH6nl+ygj9NZHxQrtQjuKCanG6OV0JmKyCjUUsZ7gxOsPVhew+giHhRAOrd+oQ== X-Received: by 2002:a05:600c:198c:: with SMTP id t12mr30486017wmq.145.1622629061739; Wed, 02 Jun 2021 03:17:41 -0700 (PDT) Received: from dell.default ([91.110.221.214]) by smtp.gmail.com with ESMTPSA id q11sm1593265wmq.1.2021.06.02.03.17.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Jun 2021 03:17:41 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, "David S. Miller" , Andre Hedrick , Adrian Sun , Duncan Laurie , Tim Hockin , Mike Waychison , Alan Cox , Sergei Shtylyov , or , linux-ide@vger.kernel.org Subject: [PATCH 08/21] ide: hpt366: Provide some missing descriptions for 'f_{low,high}' Date: Wed, 2 Jun 2021 11:17:09 +0100 Message-Id: <20210602101722.2276638-9-lee.jones@linaro.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210602101722.2276638-1-lee.jones@linaro.org> References: <20210602101722.2276638-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/ide/hpt366.c:849: warning: Function parameter or member 'f_low' not described in 'hpt37x_calibrate_dpll' drivers/ide/hpt366.c:849: warning: Function parameter or member 'f_high' not described in 'hpt37x_calibrate_dpll' Cc: "David S. Miller" Cc: Andre Hedrick Cc: Adrian Sun Cc: Duncan Laurie Cc: Tim Hockin Cc: Mike Waychison Cc: Alan Cox Cc: Sergei Shtylyov Cc: or Cc: linux-ide@vger.kernel.org Signed-off-by: Lee Jones --- drivers/ide/hpt366.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/ide/hpt366.c b/drivers/ide/hpt366.c index b3d44de777cbd..69c7c2abf3e51 100644 --- a/drivers/ide/hpt366.c +++ b/drivers/ide/hpt366.c @@ -841,6 +841,8 @@ static void hpt3xxn_rw_disk(ide_drive_t *drive, struct request *rq) /** * hpt37x_calibrate_dpll - calibrate the DPLL * @dev: PCI device + * @f_low: DPLL low value + * @f_high: DPLL high value * * Perform a calibration cycle on the DPLL. * Returns 1 if this succeeds From patchwork Wed Jun 2 10:17:10 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1486560 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=linux-ide-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=CRC2LTSp; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4Fw4jt02KMz9sVb for ; Wed, 2 Jun 2021 20:18:26 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232680AbhFBKUE (ORCPT ); Wed, 2 Jun 2021 06:20:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37950 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232553AbhFBKTc (ORCPT ); Wed, 2 Jun 2021 06:19:32 -0400 Received: from mail-wm1-x32d.google.com (mail-wm1-x32d.google.com [IPv6:2a00:1450:4864:20::32d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 07CF8C061345 for ; Wed, 2 Jun 2021 03:17:44 -0700 (PDT) Received: by mail-wm1-x32d.google.com with SMTP id g204so903868wmf.5 for ; Wed, 02 Jun 2021 03:17:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=MiECzVNIaAqnnDt6pnKwVNNPdqlT5g0qpNhz7Lhftfc=; b=CRC2LTSpC8iWLc8pLdkBi6pidI9fIS5qX+Bg0OXcSFn6ICsBqVeXNo/d/IJN+DTJrt WeAOuktIBnXDJCv8LGdQWD8DiAIPHLjTaGc0xWFog/WconDc5wK1XD2pH1hRMbSdUNBz GpkASXhYXd2bgru4ihU4Qi87o5yoNpr/RbPpvo/kkWn1J2WlH02iaGvHFZkIyTUtuZCK OQpN9df8bP4Y9mHAENecoyD8PYMLQfBblTo/S/lHPSn9nL55IteQAzbOpWgcyS7jB7nD azKYATo7wOT1jAXysZUcFWTevFpIcV9WO9J+k6XB+dNLQ1Gt7OlvsHcYylm8HwQ8/ER1 /30w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=MiECzVNIaAqnnDt6pnKwVNNPdqlT5g0qpNhz7Lhftfc=; b=OGyJaRcE08b1N/5e/8T52L8+HrKbTHxOPu1RzYgEEwVe0G1SvtdHCcwQOO6ZnuqYIz ILErvwXoLmIA0XwRQgGpGIdJKn/kOvZ78ZS/6Qa4BMOmyFLvezMDQxLM9Zlmx7Z5RzbP /nRld8C/wgUwwdjY2oMdk/g6zrTr4EBBlfe3CkDK3Xp8zd3/VVnea53JoCY2wQKKhSpJ KILQM7LjHHh/7qinFqc0wKbNoPiwhGumEnsJCpCGNbRa/e0QWaU3LOcbkPQCm63IP8B+ lXXK2a+KnOLu2XTiWVaTqzroHKGe4GB+UrP06DMmRH0OWfRGmPrdEvO78VL8+JqpjT+z ruiQ== X-Gm-Message-State: AOAM533qHatXKe4qcQhuvAsFl1C0pGZ7cAAcqxZNXXZ/rxhyC9VHO0V/ cgcVNUI9k8EuXvfoJsajpq8KEA== X-Google-Smtp-Source: ABdhPJw0M02WJo35W/Tt4aHnTpwkrficGrlEkPJpG93ilGGrvX/tTZ8xsqA1edgUt+kS33Y9oXo3LA== X-Received: by 2002:a7b:c852:: with SMTP id c18mr13479869wml.16.1622629062680; Wed, 02 Jun 2021 03:17:42 -0700 (PDT) Received: from dell.default ([91.110.221.214]) by smtp.gmail.com with ESMTPSA id q11sm1593265wmq.1.2021.06.02.03.17.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Jun 2021 03:17:42 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, "David S. Miller" , Andre Hedrick , "Software, Inc" , linux-ide@vger.kernel.org Subject: [PATCH 09/21] ide: piix: Remove unused variable 'sitre' Date: Wed, 2 Jun 2021 11:17:10 +0100 Message-Id: <20210602101722.2276638-10-lee.jones@linaro.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210602101722.2276638-1-lee.jones@linaro.org> References: <20210602101722.2276638-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/ide/piix.c: In function ‘piix_set_dma_mode’: drivers/ide/piix.c:146:8: warning: variable ‘sitre’ set but not used [-Wunused-but-set-variable] Cc: "David S. Miller" Cc: Andre Hedrick Cc: "Software, Inc" Cc: linux-ide@vger.kernel.org Signed-off-by: Lee Jones --- drivers/ide/piix.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/ide/piix.c b/drivers/ide/piix.c index 2634768a4e664..ede42d2a5b0b1 100644 --- a/drivers/ide/piix.c +++ b/drivers/ide/piix.c @@ -143,13 +143,11 @@ static void piix_set_dma_mode(ide_hwif_t *hwif, ide_drive_t *drive) int v_flag = 0x01 << drive->dn; int w_flag = 0x10 << drive->dn; int u_speed = 0; - int sitre; u16 reg4042, reg4a; u8 reg48, reg54, reg55; const u8 speed = drive->dma_mode; pci_read_config_word(dev, maslave, ®4042); - sitre = (reg4042 & 0x4000) ? 1 : 0; pci_read_config_byte(dev, 0x48, ®48); pci_read_config_word(dev, 0x4a, ®4a); pci_read_config_byte(dev, 0x54, ®54); From patchwork Wed Jun 2 10:17:11 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1486559 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=linux-ide-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=ONIgXmYJ; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4Fw4jb2J1Nz9sRK for ; Wed, 2 Jun 2021 20:18:11 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230390AbhFBKTt (ORCPT ); Wed, 2 Jun 2021 06:19:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37966 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232547AbhFBKTc (ORCPT ); Wed, 2 Jun 2021 06:19:32 -0400 Received: from mail-wm1-x331.google.com (mail-wm1-x331.google.com [IPv6:2a00:1450:4864:20::331]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 12651C061346 for ; Wed, 2 Jun 2021 03:17:45 -0700 (PDT) Received: by mail-wm1-x331.google.com with SMTP id m18so938744wmq.0 for ; Wed, 02 Jun 2021 03:17:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=O9iIf6zIMattTW/alV/9VT7gtBfDmu2Z2RdNdHc+834=; b=ONIgXmYJd1qjLKOTGHrbCG3Urp/fw+Op4avACr5zJQCxd60DT/K8uer8Y20+742e+6 9KJZb5lnFhuN1eE6sb/NimLHBWLg6L/fypednUQq8Ir4LWI9lSQzcpgexTJDG0HMA9C3 yRopcrYziW+Eai2VyR2J/YVyO7p0x0f2wtIgzmlZN83cdQ9p9iK1iaiaCnVukMFP81EE ouF0nr9yBSitL0XvK4lxHxuYgRtFiG2aSUSIGf8AgBigEUvNqX6kup6JIvUZKMBC39r1 VmdqgUWFstZsj0rJnJLA9LtLRKiBH7vDLUZDR6XkFVEEGRzzvmw4qYrrUsMobvvSlL9L ROgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=O9iIf6zIMattTW/alV/9VT7gtBfDmu2Z2RdNdHc+834=; b=aIg4KCzis9Hc9nVu15PI7c0fla5Sm0eaZDeJNlqsdqGwNAzpbEE2Z6Sx8pUWZ6mucU 2985rTjSfoPODHu/xS7QThQmWCg8SDw/M29TK2LGYQwCNrX6UnnSTIGcEc6N7+vuVH+Y XmDB8rIRs9L0IgTh7iN47iIX+A8UYUojeTmMM6EDbGs6CBUAjIHypB7+oYXgDa6iJp3r tPsRuczRhyifENwZYAjjWDTAoDh6fa3t4gUX89DjpgMc7NBHc42xiIT6JYK7Xnh+I5Yg mObnAw7lfWpDF9ily75ymXaQ6YlDmxv+4zOyODaiQiyG0UfGL8WVO74ZzY4lW1lwbxjw 8sGg== X-Gm-Message-State: AOAM531vHSsQJtcJV/ZZgg286/gq8kScTaehVDmqVmF+TMuXXckQ3EJh zud18YmrEbmkAmwcCVtiLc9qWA== X-Google-Smtp-Source: ABdhPJwRdQ1H5GkOhiTpyCUEjoVrQCMIlPxMLgxh17oU9dl1M2Cdmlw57RsVhL8ZO/wJ3//pVi98jA== X-Received: by 2002:a1c:ed14:: with SMTP id l20mr4328451wmh.20.1622629063711; Wed, 02 Jun 2021 03:17:43 -0700 (PDT) Received: from dell.default ([91.110.221.214]) by smtp.gmail.com with ESMTPSA id q11sm1593265wmq.1.2021.06.02.03.17.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Jun 2021 03:17:43 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, "David S. Miller" , Andre Hedrick , Frank Tiernan , linux-ide@vger.kernel.org Subject: [PATCH 10/21] ide: pdc202xx_new: Supply missing description for 'set_indexed_reg()'s 'value' param Date: Wed, 2 Jun 2021 11:17:11 +0100 Message-Id: <20210602101722.2276638-11-lee.jones@linaro.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210602101722.2276638-1-lee.jones@linaro.org> References: <20210602101722.2276638-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/ide/pdc202xx_new.c:84: warning: Function parameter or member 'value' not described in 'set_indexed_reg' Cc: "David S. Miller" Cc: Andre Hedrick Cc: Frank Tiernan Cc: linux-ide@vger.kernel.org Signed-off-by: Lee Jones --- drivers/ide/pdc202xx_new.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/ide/pdc202xx_new.c b/drivers/ide/pdc202xx_new.c index 7c276b8aeb5fe..537521213e148 100644 --- a/drivers/ide/pdc202xx_new.c +++ b/drivers/ide/pdc202xx_new.c @@ -79,6 +79,7 @@ static u8 get_indexed_reg(ide_hwif_t *hwif, u8 index) * set_indexed_reg - Set indexed register * @hwif: for the port address * @index: index of the indexed register + * @value: value of the indexed register */ static void set_indexed_reg(ide_hwif_t *hwif, u8 index, u8 value) { From patchwork Wed Jun 2 10:17:12 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1486561 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=linux-ide-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=C2GCEG54; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4Fw4jt5xvRz9sT6 for ; Wed, 2 Jun 2021 20:18:26 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232693AbhFBKUG (ORCPT ); Wed, 2 Jun 2021 06:20:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37968 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232555AbhFBKTc (ORCPT ); Wed, 2 Jun 2021 06:19:32 -0400 Received: from mail-wm1-x32c.google.com (mail-wm1-x32c.google.com [IPv6:2a00:1450:4864:20::32c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E6659C061348 for ; Wed, 2 Jun 2021 03:17:45 -0700 (PDT) Received: by mail-wm1-x32c.google.com with SMTP id n17-20020a7bc5d10000b0290169edfadac9so3427770wmk.1 for ; Wed, 02 Jun 2021 03:17:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=T5FEzmO9RZgKtbCHPkiUM3cWX79WWEVOe+3S3XV/eYg=; b=C2GCEG54UusFDC++LW8FQGhMV9Ae2/NdAiCrbnLSn8Dfc9HJl+/4P0+sz06JqzuqWm /QbsnbxardHjL/6AaH8fWYkB2yByRBcs4tJxiB7fVwBPGf1SUddsjDEpdmUV1HN17SPY hIfBZzGerb0kFyltrpIhV0t+K1sNRmYOieTWrjQZGgSNu6/PJHfj5PHkYIr2JUgIYeCX uRoJNNonKzF5LGjgs45qE8gZkQyILHHaH74MneW1jnQ00vRJ9DGo5ycXZU2JQMG136rU UtxvuZE6+utEsPcNZmXCEusQFKdXGlnFXPHnG/IlFcBic8QHpVKgX+HjD0MWYtjmG1wD kIcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=T5FEzmO9RZgKtbCHPkiUM3cWX79WWEVOe+3S3XV/eYg=; b=ubO2n40Rq3NXJP7KQ4sMJU36a2KFfoS/+Qifg06XbM5wkohPZaVMqknDfH6ZgNli0q S3XMxct6oxO84nMKQziqUIU3e378DjwIsWSSjOSkXCEgy1mvkuyU2wwX5DzTjPTF+fZG i6kj9qF4fipYGjFYGUSm/KoRGNArqqNHSPJO7R4mEVs7LV3j11mWUSyJJz2yW5lF4eTM CUAQNHIcbVCaRLsZVtBvVM1Qzx6a/XnDDAJ8yv/h5zqfmKPvBMKrc8+olRBqW6ri0LQs QxZ/e7ur3gvVEYXrANUnQUvcJZTIE8bWGRR8AD/mmugFaoDiHL1WBaK9+AWRFs0F/5CJ S8GQ== X-Gm-Message-State: AOAM532HIArXoucge5/qauGh+Qy5FC8pKnxKO9k1DdIpPkOZ2RhNidQ5 80MpevEyzDvckFozogbI8MvgOw== X-Google-Smtp-Source: ABdhPJxL98eynQkJFFkPBCCkEwJ33W9JN6L7a5MWz5uDvW4J9kyCTOJk0pF9VP0/RZ3Cq3Hp/W4C4Q== X-Received: by 2002:a7b:cf23:: with SMTP id m3mr4526415wmg.24.1622629064563; Wed, 02 Jun 2021 03:17:44 -0700 (PDT) Received: from dell.default ([91.110.221.214]) by smtp.gmail.com with ESMTPSA id q11sm1593265wmq.1.2021.06.02.03.17.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Jun 2021 03:17:44 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, "David S. Miller" , Andre Hedrick , "Software, Inc" , linux-ide@vger.kernel.org Subject: [PATCH 11/21] ide: slc90e66: Remove unused variable 'sitre' Date: Wed, 2 Jun 2021 11:17:12 +0100 Message-Id: <20210602101722.2276638-12-lee.jones@linaro.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210602101722.2276638-1-lee.jones@linaro.org> References: <20210602101722.2276638-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/ide/slc90e66.c: In function ‘slc90e66_set_dma_mode’: drivers/ide/slc90e66.c:80:6: warning: variable ‘sitre’ set but not used [-Wunused-but-set-variable] Cc: "David S. Miller" Cc: Andre Hedrick Cc: "Software, Inc" Cc: linux-ide@vger.kernel.org Signed-off-by: Lee Jones --- drivers/ide/slc90e66.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/ide/slc90e66.c b/drivers/ide/slc90e66.c index cd47445fda1ff..0b06c74dddf36 100644 --- a/drivers/ide/slc90e66.c +++ b/drivers/ide/slc90e66.c @@ -77,13 +77,12 @@ static void slc90e66_set_dma_mode(ide_hwif_t *hwif, ide_drive_t *drive) { struct pci_dev *dev = to_pci_dev(hwif->dev); u8 maslave = hwif->channel ? 0x42 : 0x40; - int sitre = 0, a_speed = 7 << (drive->dn * 4); + int a_speed = 7 << (drive->dn * 4); int u_speed = 0, u_flag = 1 << drive->dn; u16 reg4042, reg44, reg48, reg4a; const u8 speed = drive->dma_mode; pci_read_config_word(dev, maslave, ®4042); - sitre = (reg4042 & 0x4000) ? 1 : 0; pci_read_config_word(dev, 0x44, ®44); pci_read_config_word(dev, 0x48, ®48); pci_read_config_word(dev, 0x4a, ®4a); From patchwork Wed Jun 2 10:17:13 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1486563 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=linux-ide-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=bI/Id/J3; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4Fw4jx4yN4z9sRK for ; Wed, 2 Jun 2021 20:18:29 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232565AbhFBKUJ (ORCPT ); Wed, 2 Jun 2021 06:20:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37978 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232566AbhFBKTj (ORCPT ); Wed, 2 Jun 2021 06:19:39 -0400 Received: from mail-wm1-x336.google.com (mail-wm1-x336.google.com [IPv6:2a00:1450:4864:20::336]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B5760C06134A for ; Wed, 2 Jun 2021 03:17:46 -0700 (PDT) Received: by mail-wm1-x336.google.com with SMTP id 3-20020a05600c0243b029019f2f9b2b8aso1349554wmj.2 for ; Wed, 02 Jun 2021 03:17:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=5jQZgJxLSK97kuij2epKKmjGvDzAp1XS69EVQaGkB+E=; b=bI/Id/J3vE+NpunaijQxocoJVdgJYwNjSXzd39GknOcYqzeVoEtr5PF9IRtaZSL1GF KIDxwvDXXDXDGjhAAJqKZnd0S/6Zs/ARBaH5p8v9W3AgWLB9SRg0wmT/rmrvo1AS6FWG JwM1Nnft7kWRMZ07XcPks8lcCKy98Gf1n2WIvp0nmtzXoU91fxGGs+YukkyDm7Ci96FX 9HZRlUIeLKL1YG96yaoW9CxhWwF2Xqn9cc9GWa9bwKenw/wNMArfrpZ6rUzJKQlVKYPE 7R2U9f+yvvnzSXpkXdtL3nZxg8Dy0mUsO9WMyTXA6VMjju/7xu7I3kbxWFB9puESmZwW gMwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=5jQZgJxLSK97kuij2epKKmjGvDzAp1XS69EVQaGkB+E=; b=YB2NL+0+u0XZZgoereKqSUbgOIZ4boWNioU9sTel1RGVFa50qphlQFl/Kaj8vyZahg 0jiqMQGicDdylw6ukJemy+hdpTdWVQM2R4XWAEJwUacK4gnRLNzMPwjcSRljX7Qj+Vas PT5S882+AtWwHVIbUjIgCwieBBuSltwAsoSUlC9yjaE68BOlZwyUxnEkFy+6qmyQaaeq p5sNijEugGZyPGrHeFZETIt6nXzwJnLwTN3lXP9SQlXiuGrLiDLuFeYxtCC2F0Zw4lUT +H+9RfQCAzwXukbeG2aB9RJSz+HJlqPggfhsR6XwQ58s658jA/pwguj3k297j/v62wPu PH/w== X-Gm-Message-State: AOAM533IrSZ749W8vYxPxg05X8hV3qD7sMlUlY8ymuTr0VsHq2A3VIxn mwpc3WcCbHaE7a9tGkCczaIx2USxmByiKw== X-Google-Smtp-Source: ABdhPJzWreFQP4zXN2JQs++LA7F3tdEPIobN3r9eUGUZA2C1/ySjJZUxwndWSVJdLTuVNfCsWNlMlA== X-Received: by 2002:a1c:5452:: with SMTP id p18mr18527827wmi.176.1622629065245; Wed, 02 Jun 2021 03:17:45 -0700 (PDT) Received: from dell.default ([91.110.221.214]) by smtp.gmail.com with ESMTPSA id q11sm1593265wmq.1.2021.06.02.03.17.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Jun 2021 03:17:44 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, "David S. Miller" , linux-ide@vger.kernel.org Subject: [PATCH 12/21] ide: it821x: Fix a couple of incorrectly documented functions Date: Wed, 2 Jun 2021 11:17:13 +0100 Message-Id: <20210602101722.2276638-13-lee.jones@linaro.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210602101722.2276638-1-lee.jones@linaro.org> References: <20210602101722.2276638-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/ide/it821x.c:362: warning: expecting prototype for it821x_dma_read(). Prototype was for it821x_dma_start() instead drivers/ide/it821x.c:384: warning: expecting prototype for it821x_dma_write(). Prototype was for it821x_dma_end() instead Cc: "David S. Miller" Cc: linux-ide@vger.kernel.org Signed-off-by: Lee Jones --- drivers/ide/it821x.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/ide/it821x.c b/drivers/ide/it821x.c index aad746007330c..e7c965c3703e5 100644 --- a/drivers/ide/it821x.c +++ b/drivers/ide/it821x.c @@ -346,7 +346,7 @@ static void it821x_tune_udma(ide_drive_t *drive, u8 mode_wanted) } /** - * it821x_dma_read - DMA hook + * it821x_dma_start - DMA hook * @drive: drive for DMA * * The IT821x has a single timing register for MWDMA and for PIO @@ -372,7 +372,7 @@ static void it821x_dma_start(ide_drive_t *drive) } /** - * it821x_dma_write - DMA hook + * it821x_dma_end - DMA hook * @drive: drive for DMA stop * * The IT821x has a single timing register for MWDMA and for PIO From patchwork Wed Jun 2 10:17:14 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1486564 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=linux-ide-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=Gc9btDcQ; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4Fw4jy0YQmz9sT6 for ; Wed, 2 Jun 2021 20:18:30 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232713AbhFBKUJ (ORCPT ); Wed, 2 Jun 2021 06:20:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37984 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232564AbhFBKTl (ORCPT ); Wed, 2 Jun 2021 06:19:41 -0400 Received: from mail-wm1-x32f.google.com (mail-wm1-x32f.google.com [IPv6:2a00:1450:4864:20::32f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A3F4CC061574 for ; Wed, 2 Jun 2021 03:17:47 -0700 (PDT) Received: by mail-wm1-x32f.google.com with SMTP id n17-20020a7bc5d10000b0290169edfadac9so3427818wmk.1 for ; Wed, 02 Jun 2021 03:17:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=+NvljD9Coe3ImbVweUQhRVx0U62sw+qymnCXTI2Y/Fw=; b=Gc9btDcQSoeuLckJ3t8QvsF8N1XiFgL8Yc10DL7jwSYW5cVBidCVJWCiUbQE4cpQTe ABCaHy0bP7v8JrcR3tPLIWbA49QaqUN/UgeznpNE+or3KHcYsZDM8HK43mlpbFUMxuwd My623Iu3a4ApnfO9kDC8b7hvQhJjq3/1mvMT8jYAqR2rWNoqSe//YMUsP0/UZ6itFFKD Biro4D72WU95DpCGE+5osKehNHqaiqYSQE2XY3bsdSJiLI+49OwRQtJ8UKl0mFt8SKYv vjjYQCKvnfbGLqhULN13U6B/D7GVCrYG46OtlYXtQSD3ap/YIY1O7yuXaMnDHzsy1LWo LU3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=+NvljD9Coe3ImbVweUQhRVx0U62sw+qymnCXTI2Y/Fw=; b=dQBVUB+qQZY7bVoIDQ6SBLGW7/7TjacNRUXp1ReujY3VdEvLE9Cp0nZJxYs3oIqtxt hag3+Exm0Q8joqQxZ2z26phedFtW+AXqTE6pKWWi+HGRl4/zdPZk6TC3xBbGrNY/vYN5 UPCVexhncXEnTXEK88QLrEMQMo72RRsmTNvDRNiTf7PhVHx//sETHqmCUn7nNJrB8uJf wjFui7Xbid24DXueYkBoV7/JerK/P077ByfFMhz6EIqJt4QFFg2PCB7jzT0hhoNjd5Z5 nkn6PCtCHTvdetP4XPeyukL4GaCIfxUKHAAloKDBGAiqzN6/PNtTMX3b6PVPKAE3ymjI +LAA== X-Gm-Message-State: AOAM533wATYJkoEDbfs0YwWX4rSav0NIzwKa0vM1KJOkmoCGEHcexntD nNl56ur3lRdFQ/Nfu5QP2+sRsw== X-Google-Smtp-Source: ABdhPJwwcyUY7GSV9q5R5pikjcfL0GaGuqMxRtnHnBtiSkEpFd7Ggbu7+oBDJJL1GrZVcThFLxXdHg== X-Received: by 2002:a1c:1b93:: with SMTP id b141mr20132118wmb.8.1622629066278; Wed, 02 Jun 2021 03:17:46 -0700 (PDT) Received: from dell.default ([91.110.221.214]) by smtp.gmail.com with ESMTPSA id q11sm1593265wmq.1.2021.06.02.03.17.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Jun 2021 03:17:45 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, "David S. Miller" , Andre Hedrick , linux-ide@vger.kernel.org Subject: [PATCH 13/21] ide: siimage: Fix some incorrectly documented functions/params Date: Wed, 2 Jun 2021 11:17:14 +0100 Message-Id: <20210602101722.2276638-14-lee.jones@linaro.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210602101722.2276638-1-lee.jones@linaro.org> References: <20210602101722.2276638-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/ide/siimage.c:115: warning: Function parameter or member 'drive' not described in 'siimage_seldev' drivers/ide/siimage.c:115: warning: Excess function parameter 'hwif' description in 'siimage_seldev' drivers/ide/siimage.c:196: warning: expecting prototype for sil_udma_filter(). Prototype was for sil_pata_udma_filter() instead Cc: "David S. Miller" Cc: Andre Hedrick Cc: linux-ide@vger.kernel.org Signed-off-by: Lee Jones --- drivers/ide/siimage.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/ide/siimage.c b/drivers/ide/siimage.c index c190dc6dfb50a..64fa6b253a824 100644 --- a/drivers/ide/siimage.c +++ b/drivers/ide/siimage.c @@ -103,7 +103,7 @@ static unsigned long siimage_selreg(ide_hwif_t *hwif, int r) /** * siimage_seldev - return register base - * @hwif: interface + * @drive: interface * @r: config offset * * Turn a config register offset into the right address in either @@ -183,7 +183,7 @@ static void sil_iowrite32(struct pci_dev *dev, u32 val, unsigned long addr) } /** - * sil_udma_filter - compute UDMA mask + * sil_pata_udma_filter - compute UDMA mask * @drive: IDE device * * Compute the available UDMA speeds for the device on the interface. From patchwork Wed Jun 2 10:17:15 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1486565 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=linux-ide-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=zjGeF5HC; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4Fw4jy3RZNz9sRN for ; Wed, 2 Jun 2021 20:18:30 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232721AbhFBKUM (ORCPT ); Wed, 2 Jun 2021 06:20:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37916 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232572AbhFBKTm (ORCPT ); Wed, 2 Jun 2021 06:19:42 -0400 Received: from mail-wm1-x32b.google.com (mail-wm1-x32b.google.com [IPv6:2a00:1450:4864:20::32b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 778FBC06175F for ; Wed, 2 Jun 2021 03:17:48 -0700 (PDT) Received: by mail-wm1-x32b.google.com with SMTP id g204so903984wmf.5 for ; Wed, 02 Jun 2021 03:17:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=htzTcpdW4AR6FOO02fF09uyWR4q4i8TTi3eEflccMFY=; b=zjGeF5HCKjXczIh0I1gv61WfZERqc2GBLPFhv816eSDsCbZ0p/YEmcJh0u//noMPzc A5jPOJAxXZUMc0uRxRZwleiKNOWQ2+WuY0t3cZXkkQHvoIYco+zApOZM4bBhC6nUpWtw 4Ovy4k07pWbZ9cYUQaTSUAfhVVatV7S/pRCS7XDVt/cAALLq/Slovj8XTZ7gZZp88v1n fesO8+qq7XNt6PEx9/Yz3n+nTw9tIDftj29lJSSKQB5OwY7x8IYxYEH8YKkr9MzzQne7 Yp/Ut5PClr/daFiaBUpNwxhdcS6CZY8+RkufdL9drv2u32hst4GaQPnfd6m9CCT1QYn3 gKSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=htzTcpdW4AR6FOO02fF09uyWR4q4i8TTi3eEflccMFY=; b=uNw8+YaTn5ab3pnAG9NPkD/HUSwAwRybL59TSlmpBgS0dVYwOiZLXHGbTfsiEJxRPQ nCX4aI4C6V+WOxDFh4TS9c0bXjdL+VlQ7DizVAIfH9XwX7gQpsnxvhMBebFz696b7WYL cAlLA/PbopGB5XGQdCI5338vrKRrYt16cO/2p/yPxMj2Fn9ilrjK90fAw+b4pbGRtadY UgZ9JXxaq97CblaUQ3CbUvLitJmWjdmh5yV1ap0Y4+enzXRLA35t5aD49Bbdch9iYXiP YA7SNA15ZAuiuEXWYG9KPGuLmnV/se2C1BxWBeMnhJU7FUkNUWVPWqUZV+sLaNDZEd7L ODWQ== X-Gm-Message-State: AOAM531DDCLDGpC2l2AN5gODv2CYZ2zEazrLrcnmE7BNJI6yWsExVRy4 v+Ns4S2pmnp3WEpCkYlkIKCfHkfSbqE26w== X-Google-Smtp-Source: ABdhPJywrchhxFcUzDLyRI0gTv8NdS60hjXxQddFSDjmZ8WQbwt6LZhVB7Hc6j6/1S1MD5vEwK84aA== X-Received: by 2002:a1c:1f4a:: with SMTP id f71mr4470189wmf.146.1622629067150; Wed, 02 Jun 2021 03:17:47 -0700 (PDT) Received: from dell.default ([91.110.221.214]) by smtp.gmail.com with ESMTPSA id q11sm1593265wmq.1.2021.06.02.03.17.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Jun 2021 03:17:46 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, "David S. Miller" , linux-ide@vger.kernel.org Subject: [PATCH 14/21] ide: via82cxxx: Fix misdocumentation of via_set_speed()'s 'hwif' param Date: Wed, 2 Jun 2021 11:17:15 +0100 Message-Id: <20210602101722.2276638-15-lee.jones@linaro.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210602101722.2276638-1-lee.jones@linaro.org> References: <20210602101722.2276638-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/ide/via82cxxx.c:122: warning: Function parameter or member 'hwif' not described in 'via_set_speed' drivers/ide/via82cxxx.c:122: warning: Excess function parameter 'dev' description in 'via_set_speed' Cc: "David S. Miller" Cc: linux-ide@vger.kernel.org Signed-off-by: Lee Jones --- drivers/ide/via82cxxx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/ide/via82cxxx.c b/drivers/ide/via82cxxx.c index 166feaeed6e38..9beb25cfa5436 100644 --- a/drivers/ide/via82cxxx.c +++ b/drivers/ide/via82cxxx.c @@ -111,7 +111,7 @@ struct via82cxxx_dev /** * via_set_speed - write timing registers - * @dev: PCI device + * @hwif: IDE interface * @dn: device * @timing: IDE timing data to use * From patchwork Wed Jun 2 10:17:16 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1486566 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=linux-ide-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=wB0s8OGc; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4Fw4k01Snzz9sRN for ; Wed, 2 Jun 2021 20:18:32 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232733AbhFBKUM (ORCPT ); Wed, 2 Jun 2021 06:20:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37944 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232578AbhFBKTm (ORCPT ); Wed, 2 Jun 2021 06:19:42 -0400 Received: from mail-wm1-x331.google.com (mail-wm1-x331.google.com [IPv6:2a00:1450:4864:20::331]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A2DD7C061761 for ; Wed, 2 Jun 2021 03:17:49 -0700 (PDT) Received: by mail-wm1-x331.google.com with SMTP id o127so908573wmo.4 for ; Wed, 02 Jun 2021 03:17:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=zE6oZe1kBhGirjXSzVIMgawNguodFCFABhPx7JeRjyY=; b=wB0s8OGcZQIBjcRX1Bz+xqXw1bfT+Lnt7oXITnkwQRtuxBqR4R3zNKHc2Tde1PnPsU p0ktvhXjM0D1+g8WzN8D+AiU+OYwrZAQL92YB7VgcNvwb8U0qTCWgmXt2sE347ayu1tm ZYpV8GGvH3aVzCjq9pvH7ynkDm965oMzCQ8dlKH9jJuM+mpVK54xr0DyVS1UuGL4JDel irwrYMmOEjbORzk/+h9+P2teEFeMb2QCusMMTqFez9rgLPCtM1OcxvoyYweQKG0OvIjd 1+M5AWqGLl0laIqeuSdP81vWEUChXvTGjUP7FSgar3bhuD0Zv2+q3oF9JzRmxK0EEG5b XVnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=zE6oZe1kBhGirjXSzVIMgawNguodFCFABhPx7JeRjyY=; b=A3dfjOA97M7jXt9V5MWVoDBSAkYhx6AZOdyXJX1jE123ebcD8NGRXlHs52iYXS2+E3 p6CoSo7uDR2ojFlmMwfUx/z9MeL4jyLUvGWkWrO7wM1fV3Tul9ynjgDxUkyGlIoOhxXU b1IvnhfJbwpy7yyrIC/CBlsytSqj9It8e7/ZSvVnzBf0zXi8LQH7lg22Doxfibv0MMHy O3n1rA0E7y2nf/kqf8dCz7gUnI8OfmBEKUfGLtUxYDWLgszjiRh9fNHn+1Wips078U79 EN1KqGYb9wyrsQlv0V56U8TOgplsY5TcBZaki2+jv/ymoqcaF0d076fcmAlJuW6axOOA EIsg== X-Gm-Message-State: AOAM533AbCso6cGgiaT9BucQ4bOfXvhRwfq3huui8uupSEXiaulbdNrm ZgZCFiBMcoe/VSsGwyusMsz8vGLns6kZEg== X-Google-Smtp-Source: ABdhPJwBkFs0G1HfVBAVacPTxpUaZWui9Qw4YuegR/FlDN75E+Vs0l1k1deOKhJlk7KLN1D9F3tvjw== X-Received: by 2002:a7b:c1ce:: with SMTP id a14mr4288251wmj.81.1622629068325; Wed, 02 Jun 2021 03:17:48 -0700 (PDT) Received: from dell.default ([91.110.221.214]) by smtp.gmail.com with ESMTPSA id q11sm1593265wmq.1.2021.06.02.03.17.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Jun 2021 03:17:47 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, "David S. Miller" , Scott Snyder , Erik Andersen , Jens Axboe , linux-ide@vger.kernel.org Subject: [PATCH 15/21] ide: ide-cd_ioctl: Remove unused variable 'stat' Date: Wed, 2 Jun 2021 11:17:16 +0100 Message-Id: <20210602101722.2276638-16-lee.jones@linaro.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210602101722.2276638-1-lee.jones@linaro.org> References: <20210602101722.2276638-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/ide/ide-cd_ioctl.c: In function ‘ide_cdrom_select_speed’: drivers/ide/ide-cd_ioctl.c:212:6: warning: variable ‘stat’ set but not used [-Wunused-but-set-variable] Cc: "David S. Miller" Cc: Scott Snyder Cc: Erik Andersen Cc: Jens Axboe Cc: linux-ide@vger.kernel.org Signed-off-by: Lee Jones --- drivers/ide/ide-cd_ioctl.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/ide/ide-cd_ioctl.c b/drivers/ide/ide-cd_ioctl.c index 011eab9c69b7e..22ec8b7a6b90f 100644 --- a/drivers/ide/ide-cd_ioctl.c +++ b/drivers/ide/ide-cd_ioctl.c @@ -209,7 +209,6 @@ int ide_cdrom_select_speed(struct cdrom_device_info *cdi, int speed) ide_drive_t *drive = cdi->handle; struct cdrom_info *cd = drive->driver_data; u8 buf[ATAPI_CAPABILITIES_PAGE_SIZE]; - int stat; unsigned char cmd[BLK_MAX_CDB]; if (speed == 0) @@ -230,7 +229,7 @@ int ide_cdrom_select_speed(struct cdrom_device_info *cdi, int speed) cmd[5] = speed & 0xff; } - stat = ide_cd_queue_pc(drive, cmd, 0, NULL, NULL, NULL, 0, 0); + ide_cd_queue_pc(drive, cmd, 0, NULL, NULL, NULL, 0, 0); if (!ide_cdrom_get_capabilities(drive, buf)) { ide_cdrom_update_speed(drive, buf); From patchwork Wed Jun 2 10:17:17 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1486568 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=linux-ide-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=dNNpkAf0; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4Fw4k54Hqyz9sRK for ; Wed, 2 Jun 2021 20:18:37 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232778AbhFBKUR (ORCPT ); Wed, 2 Jun 2021 06:20:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37956 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232208AbhFBKTn (ORCPT ); Wed, 2 Jun 2021 06:19:43 -0400 Received: from mail-wm1-x333.google.com (mail-wm1-x333.google.com [IPv6:2a00:1450:4864:20::333]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 81078C0613ED for ; Wed, 2 Jun 2021 03:17:50 -0700 (PDT) Received: by mail-wm1-x333.google.com with SMTP id n17-20020a7bc5d10000b0290169edfadac9so3427906wmk.1 for ; Wed, 02 Jun 2021 03:17:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=8tYu84XEdUSREmqYuOdJdmWRVylLsrzssqO4s6Rt4FM=; b=dNNpkAf0u21yPj8DOlUixn9NR1aoURLKxFc1WiwjrFPrVxOAKf5UbiJx39t/8Dz5jT ZwPGgfft+ER8lPeZzFD1v0CQRDoEl7ehn9dZYXUqD0p79/q0QEgiPE6nWpz7t6BMXhwF jfmKtDLhFy3aVmB5LmXG3VgKChzEQbvaMqVy+AGf9cAxW9Sb3QHoYAbdTtjTRlfVRklT 2yZA7INgiKYonhkPE51/YlJm1FWR2AemX4fpKICC9TYB/LsXBLgd6TYnoj7iGx7gS/Rb pPm5qg3b2KzeuErA+NJmw/bUp9pPGeCqF17Ho9D1pc5PXs0aWuLqLn6KGpkdi/1OhhAA CdVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=8tYu84XEdUSREmqYuOdJdmWRVylLsrzssqO4s6Rt4FM=; b=NmkfYFPN2NuZeDlerPsgLJhVtA9legCADyFXZLZJ976g1riLlUwNSH8Y4WGhrAD1Wg 5OiIj6CHG03QtdvJPTCvzNE7m8+aWEOVsOfoxmKMBWs87CmVwfMUIIRRrkDq2REFbEyg 2WlyRPgb88wEDZ2fl5VEveRCc8cDPCqNKjjblexw7JIGo22lv2OQQNw1xh58X65AFh6a BPWViPXSXJbgc/MuIL2/rDzGny50NNEPAtkbR88TAuFa+90XJHcrs1r3azUJwPSxRcp7 usbIWAZSk3d11gKT1NH7+/q8UpOtYs4oILwCKWdr4c9Lm1XbtUJ1Rsa65C4csY8BhNMA z1Dg== X-Gm-Message-State: AOAM532MopJGhD7LnRc8G4h/ez3rCL9XlHRagh40E9WiE2ii3iU6Zrb6 1hrx1w/pJwQ30gJuk+Vn6KdoSjz6zZrsjg== X-Google-Smtp-Source: ABdhPJxBuw05znOQnIu8WhxlpMLB4/v32lhm44FXCUfzaGCOZA2x1XW5M0Hi3oGGlUfoNsjg5AoA/Q== X-Received: by 2002:a7b:c761:: with SMTP id x1mr4475789wmk.118.1622629069181; Wed, 02 Jun 2021 03:17:49 -0700 (PDT) Received: from dell.default ([91.110.221.214]) by smtp.gmail.com with ESMTPSA id q11sm1593265wmq.1.2021.06.02.03.17.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Jun 2021 03:17:48 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, "David S. Miller" , Scott Snyder , Erik Andersen , Jens Axboe , linux-ide@vger.kernel.org Subject: [PATCH 16/21] ide: ide-cd: Demote kernel-doc abuse Date: Wed, 2 Jun 2021 11:17:17 +0100 Message-Id: <20210602101722.2276638-17-lee.jones@linaro.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210602101722.2276638-1-lee.jones@linaro.org> References: <20210602101722.2276638-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/ide/ide-cd.c:285: warning: Function parameter or member 'drive' not described in 'cdrom_decode_status' drivers/ide/ide-cd.c:285: warning: Function parameter or member 'stat' not described in 'cdrom_decode_status' drivers/ide/ide-cd.c:285: warning: expecting prototype for Returns(). Prototype was for cdrom_decode_status() instead Cc: "David S. Miller" Cc: Scott Snyder Cc: Erik Andersen Cc: Jens Axboe Cc: linux-ide@vger.kernel.org Signed-off-by: Lee Jones --- drivers/ide/ide-cd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/ide/ide-cd.c b/drivers/ide/ide-cd.c index cffbcc27a34cc..5adbb22116fe1 100644 --- a/drivers/ide/ide-cd.c +++ b/drivers/ide/ide-cd.c @@ -275,7 +275,7 @@ static void ide_cd_free_sense(ide_drive_t *drive) drive->sense_rq_armed = false; } -/** +/* * Returns: * 0: if the request should be continued. * 1: if the request will be going through error recovery. From patchwork Wed Jun 2 10:17:18 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1486567 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=linux-ide-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=t9c3Ok2U; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4Fw4k03nKFz9sT6 for ; Wed, 2 Jun 2021 20:18:32 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232578AbhFBKUN (ORCPT ); Wed, 2 Jun 2021 06:20:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38018 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232576AbhFBKTn (ORCPT ); Wed, 2 Jun 2021 06:19:43 -0400 Received: from mail-wr1-x431.google.com (mail-wr1-x431.google.com [IPv6:2a00:1450:4864:20::431]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 98754C06138D for ; Wed, 2 Jun 2021 03:17:51 -0700 (PDT) Received: by mail-wr1-x431.google.com with SMTP id a20so1764162wrc.0 for ; Wed, 02 Jun 2021 03:17:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=gKWfoEYc79d/DZOeZ8NSwXdjHyPPS/zrdGTYbV6jFgI=; b=t9c3Ok2U2XnbkvwgO1ViAtbEPfPg8i++Io7jx1sRwNxylsOdhobN8W3brVzyhGDdQy rivI7LgW3aIcixtJ/Q3Ehm24HetEMmOwZHVOGT/1ePMuyclfalyLIVs38nLEG3EpoMi7 zGNr38BFeFx0xmWW4rjBlebzSYikORdn0JH1alk8TgqmHfhBBujThpYzUf1kjbk/nf7T rYo2fgGE9MBSMwXtJUvOnpJlIpjuLM36wSxbXC/Y6HWJnec1I5FcIun1384JwCTH795m s5r6UA9OOCNWYdVkH8lzAq4PdqNX7ptpVPTf8OC9a5T7XDX1R75sgeawq0+YW0+mFLx7 LP5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=gKWfoEYc79d/DZOeZ8NSwXdjHyPPS/zrdGTYbV6jFgI=; b=EsrKiosjp9xFNmQ8SMG1pOigextQM25FgeZx4y8VwE4F1sBZBbzZ1XE1EJusn8j1q+ MIsUI+KEo2fTq2keKCQ0m0tZ457AGt6gXli96E3lp1NfAVaolKK0r3SSobg0Mk+BQ14C HhK7xTQpyxIEryh8936gtxz7AClaQZcSAr910n62XgyDjZ66Wdv9dC/7VecHkyjtXSRq +2T24Vmif4utTZTu8nsJybUqtOLbmq979DnuNzKUSCMbsnBf4JxWpoJpuWZF+OQfnUPO rurVxOaF+R2xkZakVOFfmoCnaEkByCvx/smTX1SrLlHEkepIYMb0papdbM9vOr1ZuuXv /oYA== X-Gm-Message-State: AOAM531PM4RisIah6mtbIBf7OvVyHySdoNTwfOqYRAC9cHbqXxtmAbPs 8tmcVc64o/tMVxq5379Kvc9MoA== X-Google-Smtp-Source: ABdhPJzgaX9hoMdjBzbQoxzSpt/nMKR1xURv7VlgQLgZOWH3wZ9ZF5Mt6cvMf7q+P6QLZhHeEVc8mg== X-Received: by 2002:a5d:4610:: with SMTP id t16mr4022764wrq.324.1622629070173; Wed, 02 Jun 2021 03:17:50 -0700 (PDT) Received: from dell.default ([91.110.221.214]) by smtp.gmail.com with ESMTPSA id q11sm1593265wmq.1.2021.06.02.03.17.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Jun 2021 03:17:49 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, "David S. Miller" , linux-ide@vger.kernel.org Subject: [PATCH 17/21] ide: ide-acpi: Mark debugging variable 'bus' as __maybe_unused Date: Wed, 2 Jun 2021 11:17:18 +0100 Message-Id: <20210602101722.2276638-18-lee.jones@linaro.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210602101722.2276638-1-lee.jones@linaro.org> References: <20210602101722.2276638-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/ide/ide-acpi.c: In function ‘ide_get_dev_handle’: drivers/ide/ide-acpi.c:126:15: warning: variable ‘bus’ set but not used [-Wunused-but-set-variable] Cc: "David S. Miller" Cc: linux-ide@vger.kernel.org Signed-off-by: Lee Jones --- drivers/ide/ide-acpi.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/ide/ide-acpi.c b/drivers/ide/ide-acpi.c index 9a4ec281b9854..816ebbbf699b5 100644 --- a/drivers/ide/ide-acpi.c +++ b/drivers/ide/ide-acpi.c @@ -123,7 +123,8 @@ static int ide_get_dev_handle(struct device *dev, acpi_handle *handle, u64 *pcidevfn) { struct pci_dev *pdev = to_pci_dev(dev); - unsigned int bus, devnum, func; + unsigned int __maybe_unused bus; + unsigned int devnum, func; u64 addr; acpi_handle dev_handle; acpi_status status; From patchwork Wed Jun 2 10:17:19 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1486569 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=linux-ide-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=YZ50AN5U; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4Fw4kD0ST6z9sVb for ; Wed, 2 Jun 2021 20:18:44 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232827AbhFBKUX (ORCPT ); Wed, 2 Jun 2021 06:20:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37906 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232594AbhFBKTo (ORCPT ); Wed, 2 Jun 2021 06:19:44 -0400 Received: from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com [IPv6:2a00:1450:4864:20::42a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 460BAC06134C for ; Wed, 2 Jun 2021 03:17:52 -0700 (PDT) Received: by mail-wr1-x42a.google.com with SMTP id h8so1699032wrz.8 for ; Wed, 02 Jun 2021 03:17:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=hghg5eiTw+XcFBcIuWtxfTHWZai/nFkGzTUoTFHy7tQ=; b=YZ50AN5U3jBUZLeLdk7DDuN3K2pMrIbrP2OHxpOHagH6mjsZMPmeQDsP5T2ltLpkqK jyb6gYRUE+7u9ExtFV15pSYX8tbD+1umFd/Hg8eP1mBac1Ltzedrfm/6gfD7OfHR+3nb gqyVpZM/tGwNkGDcOy3t0u9hAA6B3vnFnlsPNhUm9a69uhYauQp+PF7rqCIQ8hpjSrKx WaVNka9st+UOsX1NAM9B4S5QJ8FwsNarQeBSPFpAkWM/9LQIHjZ4cuQGKT1p/98hdI5S ZuOT0MskdJg1ZF8ErA3UzdDJNUxMAqIHvZB+vJ8whbQocROtF5g2WW8MiIijMITA9Qmp 3Hhw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=hghg5eiTw+XcFBcIuWtxfTHWZai/nFkGzTUoTFHy7tQ=; b=MJyRfY2LTG+s96CU/kslS6nMw03TBpztv9htopY13x/we4W0dZ9TOJLrlouAHg544A VcB0zTI6zkuFXFcbIF4X+YNYBRBcj0ZSaUs4Hf6dH3rTPlrGHXu20cEC3GQuw8GFn0O3 bqtSdw4UIHqs5aks+DBBlMj3tXwGonkM+qKnV2Pys5utj5kS4X2p7WF/1ECB5loxIgHE LvTmzdlR5WtMZe1mGm96xb1QnBjx1QA+6TbvzTjn4ZpOMSHq7770U4bj29Wqbk1L4SD2 wc0e9jWpkWZm/Sr4SB+A0u8eKVDxhqVO1i2CAwwWJCN0+w8ODefeoH4a+BOH+J3vyOQk quCA== X-Gm-Message-State: AOAM5310YZYiPmhWsQ/xLQmQ/LCjfrYMWFJp2xdKfuDuraw2w6mBtqHl dD8QumkP/naMrL8jQVESzU0YYQ== X-Google-Smtp-Source: ABdhPJwNaESo8dgf3KZKl5D5IQxpN86T+b+Vg1TYMkBROXmXd/GZTTNXjRq21dG0p1Brd60StOt6NA== X-Received: by 2002:adf:a489:: with SMTP id g9mr20930775wrb.103.1622629070953; Wed, 02 Jun 2021 03:17:50 -0700 (PDT) Received: from dell.default ([91.110.221.214]) by smtp.gmail.com with ESMTPSA id q11sm1593265wmq.1.2021.06.02.03.17.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Jun 2021 03:17:50 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, "David S. Miller" , linux-ide@vger.kernel.org Subject: [PATCH 18/21] ide: ide-io: Document ide_intr()'s param 'irq' Date: Wed, 2 Jun 2021 11:17:19 +0100 Message-Id: <20210602101722.2276638-19-lee.jones@linaro.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210602101722.2276638-1-lee.jones@linaro.org> References: <20210602101722.2276638-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/ide/ide-io.c:775: warning: Function parameter or member 'irq' not described in 'ide_intr' Cc: "David S. Miller" Cc: linux-ide@vger.kernel.org Signed-off-by: Lee Jones --- drivers/ide/ide-io.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/ide/ide-io.c b/drivers/ide/ide-io.c index bd3e78985bcc7..129d036645f85 100644 --- a/drivers/ide/ide-io.c +++ b/drivers/ide/ide-io.c @@ -750,6 +750,7 @@ static void unexpected_intr(int irq, ide_hwif_t *hwif) /** * ide_intr - default IDE interrupt handler + * @irq: IRQ number * @dev_id: hwif * * This is the default IRQ handler for the IDE layer. You should From patchwork Wed Jun 2 10:17:20 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1486571 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=linux-ide-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=E4V+Pbwm; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4Fw4km3VWdz9sRK for ; Wed, 2 Jun 2021 20:19:12 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232400AbhFBKUw (ORCPT ); Wed, 2 Jun 2021 06:20:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37950 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232677AbhFBKUD (ORCPT ); Wed, 2 Jun 2021 06:20:03 -0400 Received: from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com [IPv6:2a00:1450:4864:20::42a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1BB5AC061351 for ; Wed, 2 Jun 2021 03:17:53 -0700 (PDT) Received: by mail-wr1-x42a.google.com with SMTP id z17so1708550wrq.7 for ; Wed, 02 Jun 2021 03:17:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ffhlhORa9MD76Qfgf3sMwz4+X77WIAnMaM3VUopGK6E=; b=E4V+Pbwmmui80575wZa/0HhSIL4NfmUAqtTHl/YRjmu6QInCPP/KB5KEEriGSKXHYu s5Hse/hhPpcrhWx0SLnX+Sh+/3HROvL2RP8P06SdD79B5eiv/xEgE4Ponkno2YUEPta1 Duz2MBcgS4T6dmyyC9S0FnOe3cStkUhW0rHGCVDE2Mbw7c7CAdgps0CHZRPE6wTfe+9c QqeMES6A5NarvrSp3SsYlt8oPbdmsYZmxulLxnrEWfeYBrnMz7muy4XYqeR83G1pt8Ox 5+HdsMR+MDvaVQsVHj4m+MoopxDr57VOByrt96OZU3xjrdimwZ+mJcMkk5VnjSzXcJ7w JYhw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ffhlhORa9MD76Qfgf3sMwz4+X77WIAnMaM3VUopGK6E=; b=dWYpKZFolVGkJ0L4ieO1fk2rlc8LAnWGt3CaMJl136I4CIJnSNYB2aEl/Q4WMgdpxW UHGlalAk0NNsabqpCd2G94W4bgCcBUzpYbWIaUN4RSYsQpIQo0NBVQzn0bLxByBd1VC1 ZYccrafRU/5Yp+U9vIsUunRN9m57SsbCDeIM7WNDJ6hmhxSfJIUVhBTwXORfKXwFQOFR vPwaVg59vwQvcDm1po46MUkGhCBCTkC9bZSc0Ljpd8lTWKc4Ou8tSUAA0nkXzLqlnz1x bWz+374S2VsTW5nO5ZWnqlCRVXlso4hogkvkeWjmVy9GEcphArtJZ/hX/8IjRob7zKzH koyg== X-Gm-Message-State: AOAM5336FC2iJ6+z3qYcDpkoDuUHn6AwUVd3ztIBYOsfkB/wkUdI7wO+ 1NWWdUpGZHs9PwjbrwTVxRbYcw== X-Google-Smtp-Source: ABdhPJxxspuwt2Ws7/m8yQcpkZD3Kik31bJdkaR9gIDi5maHoFcQtmHfbDYEw48CsQ+js9D8owBZbQ== X-Received: by 2002:a05:6000:50d:: with SMTP id a13mr31460242wrf.130.1622629071932; Wed, 02 Jun 2021 03:17:51 -0700 (PDT) Received: from dell.default ([91.110.221.214]) by smtp.gmail.com with ESMTPSA id q11sm1593265wmq.1.2021.06.02.03.17.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Jun 2021 03:17:51 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, "David S. Miller" , Andre Hedrick , "Software, Inc" , linux-ide@vger.kernel.org Subject: [PATCH 19/21] ide: piix: Fix incorrectly documented param 'hwif' Date: Wed, 2 Jun 2021 11:17:20 +0100 Message-Id: <20210602101722.2276638-20-lee.jones@linaro.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210602101722.2276638-1-lee.jones@linaro.org> References: <20210602101722.2276638-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/ide/piix.c:69: warning: Function parameter or member 'hwif' not described in 'piix_set_pio_mode' drivers/ide/piix.c:69: warning: Excess function parameter 'port' description in 'piix_set_pio_mode' Cc: "David S. Miller" Cc: Andre Hedrick Cc: "Software, Inc" Cc: linux-ide@vger.kernel.org Signed-off-by: Lee Jones --- drivers/ide/piix.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/ide/piix.c b/drivers/ide/piix.c index ede42d2a5b0b1..6a22c281ea90a 100644 --- a/drivers/ide/piix.c +++ b/drivers/ide/piix.c @@ -59,7 +59,7 @@ static int no_piix_dma; /** * piix_set_pio_mode - set host controller for PIO mode - * @port: port + * @hwif: IDE interface * @drive: drive * * Set the interface PIO mode based upon the settings done by AMI BIOS. From patchwork Wed Jun 2 10:17:21 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1486570 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=linux-ide-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=ENdVDcJ7; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4Fw4kW480Sz9sT6 for ; Wed, 2 Jun 2021 20:18:59 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232625AbhFBKUj (ORCPT ); Wed, 2 Jun 2021 06:20:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37948 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232642AbhFBKT5 (ORCPT ); Wed, 2 Jun 2021 06:19:57 -0400 Received: from mail-wr1-x433.google.com (mail-wr1-x433.google.com [IPv6:2a00:1450:4864:20::433]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1B9B3C061350 for ; Wed, 2 Jun 2021 03:17:54 -0700 (PDT) Received: by mail-wr1-x433.google.com with SMTP id j14so1721047wrq.5 for ; Wed, 02 Jun 2021 03:17:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=O++OUhPnombOqG4IjFy2Q1V542JLHmoGcDivLsFbcQs=; b=ENdVDcJ7hgcy5xRlPjOOnB5DPqcJ9+dvg90YDBjFZ75E0zsuv8ZJhzbszxzoZenlRN aPhKCc5jmqEX8LHBb9AlpT68BAP6QvNx7dHAmeZCV6ZQ359pjZCKd3hX3VG4LZJlxKTB rP/0NaUH/pCrN6WlSwuxr1cfUcJXyD/0L8KKdHFVsE9DfzyB1j3vermBVtvq8/RdUVDw MzJH011vXEgSYCfztXRxTW7KOB8CQ3cH2AEzhYPcTDFMeZSsvzLBDF6EBuAimORLzRhf tWzs0s8WMAtZPiTjejpmI3biH8RvRx8l+VVI8is54w6w7LAn8pmMhO2+qX9uBbPN/EuF AUyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=O++OUhPnombOqG4IjFy2Q1V542JLHmoGcDivLsFbcQs=; b=TUra11SUI5+yeftDoDvpIzB2p661wYghLK+H4xT43+oKiuiGNJK3Es9XcG4RnVxpOC MT9DmpUYkoEXTF7A0iycoFMbX0+7XUCIlUeg5ybpsJWN4qvQ05/upTTmnemjxQv+qR27 ZSOySz/AhewN0o5QZzHfzqtac7EQRmpY/dxyvsVi5IrCqZuAlpLiZijTd2E23j4jBsO+ js0uAeJd8KkFiDuAR30LGvaMDwpmAUk1VxIKK8mHxlIqSKaAaR/xC7MWzsKWpBBO29U3 9VULdk9D7HUPl0n1GJnAdwBaUYxS4Gogu7OzeU0N89jLp9WOztLAReNYiZMvjc6tJ39l xaEg== X-Gm-Message-State: AOAM5308xI7l6arXKXT8OEY6A5ITacD85GdEo2ZwY2V4v0HYkG+3iXT7 Nh/lYaZJluyw9Yyt0Qka20xR6w== X-Google-Smtp-Source: ABdhPJyw4df+1q/Wbu7sw08ZGjECOWBii9wPOGpX7cNc/QnKCMyFaE6vqJ3jJmo9DWrcbDVvM14ISQ== X-Received: by 2002:a5d:5271:: with SMTP id l17mr25857039wrc.142.1622629072927; Wed, 02 Jun 2021 03:17:52 -0700 (PDT) Received: from dell.default ([91.110.221.214]) by smtp.gmail.com with ESMTPSA id q11sm1593265wmq.1.2021.06.02.03.17.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Jun 2021 03:17:52 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, "David S. Miller" , linux-ide@vger.kernel.org Subject: [PATCH 20/21] ide: ide-acpi: Provide missing description for param 'obj_loc' Date: Wed, 2 Jun 2021 11:17:21 +0100 Message-Id: <20210602101722.2276638-21-lee.jones@linaro.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210602101722.2276638-1-lee.jones@linaro.org> References: <20210602101722.2276638-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/ide/ide-acpi.c:229: warning: Function parameter or member 'obj_loc' not described in 'do_drive_get_GTF' Cc: "David S. Miller" Cc: linux-ide@vger.kernel.org Signed-off-by: Lee Jones --- drivers/ide/ide-acpi.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/ide/ide-acpi.c b/drivers/ide/ide-acpi.c index 816ebbbf699b5..fd80789722bbe 100644 --- a/drivers/ide/ide-acpi.c +++ b/drivers/ide/ide-acpi.c @@ -214,6 +214,7 @@ static acpi_handle ide_acpi_hwif_get_handle(ide_hwif_t *hwif) * @drive: the drive for which the taskfile settings should be retrieved * @gtf_length: number of bytes of _GTF data returned at @gtf_address * @gtf_address: buffer containing _GTF taskfile arrays + * @obj_loc: placeholder for return data * * The _GTF method has no input parameters. * It returns a variable number of register set values (registers From patchwork Wed Jun 2 10:17:22 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1486572 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=linux-ide-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=HlDzsjy3; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4Fw4kn1xN2z9sRK for ; Wed, 2 Jun 2021 20:19:13 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232977AbhFBKUy (ORCPT ); Wed, 2 Jun 2021 06:20:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37952 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232700AbhFBKUH (ORCPT ); Wed, 2 Jun 2021 06:20:07 -0400 Received: from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com [IPv6:2a00:1450:4864:20::42a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1C2ACC061354 for ; Wed, 2 Jun 2021 03:17:55 -0700 (PDT) Received: by mail-wr1-x42a.google.com with SMTP id j14so1721102wrq.5 for ; Wed, 02 Jun 2021 03:17:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=WtnD+zGZfyDjb47352gUiRgkQO/5qCyVYr5fUC47UEQ=; b=HlDzsjy3jGmMEPA1Cdi22KnzTcGlVq/CYnYWR/tA+FBDBUn8MQTrxkxf9fCrhb9EiY AP+DCRABV+UBwY2goSJqt0gomdcXSqhl/hLxokVr3BortHhumCHv7V2pt1VWxUzV/wQ2 sIryHyzPAgDSW+3fLjBwyvu/jJaDrExZ7yTTw0jIy0kXCyS1R90d3nX9nVvmtw5tu9pH bE8xKyEEMbd9Y3Oi4fGtsy9Qfc7YSqRMGWSb0koyiriYFxqLAEwj/z0Y4LgrUfjj/u5R aiug7yL15FwpLx2lhNT3PkDP+jip8ZpZQWNQQKDuDaLQ7ccdu+fn3vt+7vt67JEPwev4 sPiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=WtnD+zGZfyDjb47352gUiRgkQO/5qCyVYr5fUC47UEQ=; b=uoMw7r6zi4dcrAvfdi7YPQ17OWefyELyU1o8mv0xDmaWp0mYllGRy1LAIQhcL8XZKK SjVjmrsS96x/Wyp4LSNDIRxv6C311iISrCfOwjFb6nxP0KsjyiyAkBDrlYdFPmurtsEE /EbtRdbhqV2jLMXIDT4zXinRdoyoDHB1SAq6WpDRVU0Ti1+1c6XODZaogRLEk1vid/kx UZHnEjukFmzF8BGwd70PxLXH+Bwq/U8h8o/9fgzLuyHnS3e1+vGxH4gmzLjNGMZODwzg ylxji1qz1Q3Urq+rG9I9HBVa+YsO+/SwS+syvJpeh35gQi0x41GJw9qEp2yPQo0HdWBF rirg== X-Gm-Message-State: AOAM530L8UCuBpd/bTXur6t5k0Nf8c4xlsqLVltXk+1gC2GQPQcF95bx cMlUWEW+hN6afJnlEYy7C3CVSQ== X-Google-Smtp-Source: ABdhPJxx4Lux9HjDIJYRif25LB8bbY+qG3ZeqQpM1q+K1vvbQ3pirOgL8N54fTtJkQHarwFy77UX7w== X-Received: by 2002:a5d:59a4:: with SMTP id p4mr33512577wrr.248.1622629073919; Wed, 02 Jun 2021 03:17:53 -0700 (PDT) Received: from dell.default ([91.110.221.214]) by smtp.gmail.com with ESMTPSA id q11sm1593265wmq.1.2021.06.02.03.17.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Jun 2021 03:17:53 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, "David S. Miller" , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , linux-ide@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Subject: [PATCH 21/21] ide: pmac: Staticise local function 'pmac_ide_probe' Date: Wed, 2 Jun 2021 11:17:22 +0100 Message-Id: <20210602101722.2276638-22-lee.jones@linaro.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210602101722.2276638-1-lee.jones@linaro.org> References: <20210602101722.2276638-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/ide/pmac.c:1418:12: warning: no previous prototype for ‘pmac_ide_probe’ [-Wmissing-prototypes] Cc: "David S. Miller" Cc: Michael Ellerman Cc: Benjamin Herrenschmidt Cc: Paul Mackerras Cc: linux-ide@vger.kernel.org Cc: linuxppc-dev@lists.ozlabs.org Signed-off-by: Lee Jones --- drivers/ide/pmac.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/ide/pmac.c b/drivers/ide/pmac.c index ea0b064b5f56b..d51a2e252b6f2 100644 --- a/drivers/ide/pmac.c +++ b/drivers/ide/pmac.c @@ -1415,7 +1415,7 @@ static struct pci_driver pmac_ide_pci_driver = { }; MODULE_DEVICE_TABLE(pci, pmac_ide_pci_match); -int __init pmac_ide_probe(void) +static int __init pmac_ide_probe(void) { int error;