From patchwork Tue Jun 1 14:34:06 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas De Schampheleire X-Patchwork-Id: 1486005 Return-Path: X-Original-To: incoming-buildroot@patchwork.ozlabs.org Delivered-To: patchwork-incoming-buildroot@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=busybox.net (client-ip=140.211.166.136; helo=smtp3.osuosl.org; envelope-from=buildroot-bounces@busybox.net; receiver=) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=AblkHPRL; dkim-atps=neutral Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4FvZRv1x5Rz9t0p for ; Wed, 2 Jun 2021 00:34:35 +1000 (AEST) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id A4E9660805; Tue, 1 Jun 2021 14:34:33 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 6gtntd-ZK-LG; Tue, 1 Jun 2021 14:34:32 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp3.osuosl.org (Postfix) with ESMTP id E1FCD60890; Tue, 1 Jun 2021 14:34:31 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id 911551BF577 for ; Tue, 1 Jun 2021 14:34:30 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 7E34083A51 for ; Tue, 1 Jun 2021 14:34:30 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Authentication-Results: smtp1.osuosl.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id c4L6abjL7Cgu for ; Tue, 1 Jun 2021 14:34:29 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.8.0 Received: from mail-ej1-x62f.google.com (mail-ej1-x62f.google.com [IPv6:2a00:1450:4864:20::62f]) by smtp1.osuosl.org (Postfix) with ESMTPS id B492B83653 for ; Tue, 1 Jun 2021 14:34:29 +0000 (UTC) Received: by mail-ej1-x62f.google.com with SMTP id jt22so22082865ejb.7 for ; Tue, 01 Jun 2021 07:34:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=fNpSPkRLzauHVC2C+o3Wlmqx5uOvUgLYEwh5L7t4Q7Q=; b=AblkHPRLBHVDv7NP4gNK+Zlf67ak6f8PKEkjMaWQAmZrEEc8ij8hcMbbjFdRw08n3K +p5l/LliqNpJXRK1IbtlFAxhMInCfXKUfES8YOT5MFViw6LmJgKQZEC/kAE6Z2C8J6q9 dGw/tDjV8E4zXXnVwQA0sMnNl60rW7E6DDm1+HEG5rs5rZWPPQRXtQdgtkXTbgOZjK2t o7Bo+7tUUC4gZoyGvv4GzMFfCiEIZY7yPeyq42Rmtj5MKzWi8OQL7Fngyki+0wzaGE5g WIVSx47S07DgTvJlttn6RaevWb2Ll+eJsgrd6D48LWIwjBQuT5EWfrKONaRq3UTEpgBR MAGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=fNpSPkRLzauHVC2C+o3Wlmqx5uOvUgLYEwh5L7t4Q7Q=; b=Ok9b/KUENCnWL0GC1+2I5sh6Ykmd2kcnyjsZw6/KEs7xT/+2nGjugBjGPl6GFcnCsO cJLHMp4IwAxhce5S0PqHK/YZaUCmJetop2yHASFKp0n/hGAhHTHn+WJXRHq6xRaGfAsr V8wU90ae5vOAOJpDtlAldlCylWQxcFy+P3XQyEO8CyHmmR8jePeGDxAJ/Zn1Ia8mh0d+ yKEfdaH1x0MCO3oHLK7JRNg423RznQ7zfwCEjFRszrBQbqCCRqDfOOx8CWKx1ywINdXK 5Iv0cXcsEjr6XIZkX6HkBVzO52RwQJtXYDt5kY+uIiIOWBRwVpwW4RR56ryYmqhuqptP 8W7w== X-Gm-Message-State: AOAM532jMYhggBNg8krjb99sA8Ts+IMgLsO1j1TQ8D7uSenCB98+629S d0VxuQtBOYAAeYiZcQYDLI3bJ0tzvLo1o3Ze X-Google-Smtp-Source: ABdhPJzX6u+Ael5r8IAaKl/x6/EoM8IGU/ggoE/FPdqvdGlqPBkCtlm9eZ76b1apvluIvouqwECo9A== X-Received: by 2002:a17:907:7747:: with SMTP id kx7mr29697113ejc.400.1622558067973; Tue, 01 Jun 2021 07:34:27 -0700 (PDT) Received: from localhost (ptr-5gw9txf6g5tndjqqqz.18120a2.ip6.access.telenet.be. [2a02:1810:510:3800:1b15:18e4:57d1:eb]) by smtp.gmail.com with ESMTPSA id da14sm8681181edb.44.2021.06.01.07.34.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Jun 2021 07:34:27 -0700 (PDT) From: Thomas De Schampheleire To: buildroot@buildroot.org Date: Tue, 1 Jun 2021 16:34:06 +0200 Message-Id: <20210601143422.25064-2-patrickdepinguin@gmail.com> X-Mailer: git-send-email 2.26.3 In-Reply-To: <20210601143422.25064-1-patrickdepinguin@gmail.com> References: <20210601143422.25064-1-patrickdepinguin@gmail.com> MIME-Version: 1.0 Subject: [Buildroot] [PATCHv4 01/16] core: introduce BR2_ENABLE_RUNTIME_DEBUG X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas De Schampheleire Errors-To: buildroot-bounces@busybox.net Sender: "buildroot" From: Thomas De Schampheleire Some packages have optional runtime assertions, extra traces, or other elements that can help in debugging problems. However, such runtime elements can negatively influence performance. In a test program performing 100K gRPC calls from a client to a local server and receiving the returned response, we see following execution time: - runtime debug enabled: 1065 seconds - runtime debug disabled: 48 seconds This is more than a factor 20 (!) difference. Analysis shows that the problem mostly stems from libabseil-cpp (a dependency of gRPC) which enables mutex deadlock analysis when the preprocessor flag 'NDEBUG' is not set, which adds a 'backtrace()' call on every lock/unlock. Potentially worse, when libunwind is enabled and linked with the test program, 'backtrace()' is not provided by glibc but by libunwind itself. For production systems, users expect good performance out-of-the-box. In the example above, the difference is huge and unless explicitly tested and analyzed, users may not realize that the performance could be much better. Address this problem by introducing a new option BR2_ENABLE_RUNTIME_DEBUG, which can be used by packages or package infrastructures to set the necessary flags. Note that BR2_ENABLE_RUNTIME_DEBUG is orthogonal to BR2_ENABLE_DEBUG: the former changes runtime behavior, while the latter is only expected to add debug symbols to the build. Today, the cmake build system does introduce a runtime impact when BR2_ENABLE_DEBUG is set, but that will be rectified in a subsequent commit. Signed-off-by: Thomas De Schampheleire Acked-by: Arnout Vandecappelle (Essensium/Mind) Reviewed-by: Yann E. MORIN --- Config.in | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/Config.in b/Config.in index c65e34bd5e..a008425688 100644 --- a/Config.in +++ b/Config.in @@ -412,6 +412,19 @@ config BR2_DEBUG_3 endchoice endif +config BR2_ENABLE_RUNTIME_DEBUG + bool "build packages with runtime debugging info" + help + Some packages may have runtime assertions, extra traces, and + similar runtime elements that can help debugging. However, + these elements may negatively influence performance so should + normally not be enabled on production systems. + + Enable this option to enable such runtime debugging. + + Note: disabling this option is not a guarantee that all + packages effectively removed these runtime debugging elements. + config BR2_STRIP_strip bool "strip target binaries" default y From patchwork Tue Jun 1 14:34:07 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas De Schampheleire X-Patchwork-Id: 1486007 Return-Path: X-Original-To: incoming-buildroot@patchwork.ozlabs.org Delivered-To: patchwork-incoming-buildroot@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=busybox.net (client-ip=140.211.166.133; helo=smtp2.osuosl.org; envelope-from=buildroot-bounces@busybox.net; receiver=) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=oTImg0KC; dkim-atps=neutral Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4FvZSP021gz9sj1 for ; Wed, 2 Jun 2021 00:35:00 +1000 (AEST) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 5B6C440421; Tue, 1 Jun 2021 14:34:59 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Xbeda-1nKFAp; Tue, 1 Jun 2021 14:34:58 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp2.osuosl.org (Postfix) with ESMTP id 8D5994028D; Tue, 1 Jun 2021 14:34:57 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by ash.osuosl.org (Postfix) with ESMTP id 3881E1BF577 for ; Tue, 1 Jun 2021 14:34:32 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 1F9FA606C9 for ; Tue, 1 Jun 2021 14:34:32 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Authentication-Results: smtp3.osuosl.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id U0L6FMxY2iTg for ; Tue, 1 Jun 2021 14:34:31 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.8.0 Received: from mail-ej1-x634.google.com (mail-ej1-x634.google.com [IPv6:2a00:1450:4864:20::634]) by smtp3.osuosl.org (Postfix) with ESMTPS id 6BD286082E for ; Tue, 1 Jun 2021 14:34:31 +0000 (UTC) Received: by mail-ej1-x634.google.com with SMTP id g20so6592851ejt.0 for ; Tue, 01 Jun 2021 07:34:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=jv+mADvILPMdhq22I+mt6T30UGDtLbYj5vbJgJsSV24=; b=oTImg0KC5d28Y8KfspfXWzE99wJQeg8/89uCTodcAoo2BZJL2LmzEgLGmeQekFwdov xvTk+kiEmE7btPwJABd75rwVDfiIqE1P2XIyGf/UeznhD9xOBHlu+wXIxYoI+HJtqtW7 GSKo9sZfa+z9aFPluKSbVtOl2iNGOafjG0a36Tt/e2iy6siipnOo7uaCau9ge7uCx5Y2 pbggL1BkEJZKdOmVSVcTuJn24Lf7H/1MzCWj/mAUSlJmizeesEoCFlKj7RL4/ih0UqY2 e2pj8C+2rlNuiFeV3sOVmMlLK86wpOflZIthOEZ7KnP1hbKrkeYylU8eQQTfguDzGVAX 4Oew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=jv+mADvILPMdhq22I+mt6T30UGDtLbYj5vbJgJsSV24=; b=pA2rZkYsegh/ayPP9GPcprQMYgUCA+gxjrSi2Bce4eanS99If4VCTXx/XoMw0f+rY4 /4TPWR8CRyG90YU0VEtxe2pvzzveO6xQG7rio0b/0dW3TXMREPLSCaCzeTNZSIoHUsO3 VFa9FCZvgl39fcCbjjy6c3oaRPwlYq23t17gambJR6N+EOkRHlH9CiD+fsIQeacI/0gM AksXbZ2g3hgQn0ZAnkRPAZ5AvCBmlhhydpf6+2nz2khU6UW21V0Zl3zo5PcCUYM+Jr8A qj1LUOfByR/2WZ2Gvg2zh6mKbmRwyCSpEL7+ycMmoOKL7GmhR3PS+kqhsVnqoGIZySao hw+A== X-Gm-Message-State: AOAM533RcPYFW9jAZNpdXWL6XQYgf5Z4icGcMyyrMxLAp9GG1OeYsIal 2jFFKpmZZ67X4xgB4t5OSE2YJEfVji+pFs/Y X-Google-Smtp-Source: ABdhPJyPEw3hAY6DnXAtBCgYYtDDb7cn/lK4lP73HMo0QN+ZguYip2R1MGPv7UeHhdST8KlLOlq5HQ== X-Received: by 2002:a17:906:518b:: with SMTP id y11mr22792647ejk.178.1622558069753; Tue, 01 Jun 2021 07:34:29 -0700 (PDT) Received: from localhost (ptr-5gw9txf6g5tndjqqqz.18120a2.ip6.access.telenet.be. [2a02:1810:510:3800:1b15:18e4:57d1:eb]) by smtp.gmail.com with ESMTPSA id h9sm8476779edt.18.2021.06.01.07.34.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Jun 2021 07:34:29 -0700 (PDT) From: Thomas De Schampheleire To: buildroot@buildroot.org Date: Tue, 1 Jun 2021 16:34:07 +0200 Message-Id: <20210601143422.25064-3-patrickdepinguin@gmail.com> X-Mailer: git-send-email 2.26.3 In-Reply-To: <20210601143422.25064-1-patrickdepinguin@gmail.com> References: <20210601143422.25064-1-patrickdepinguin@gmail.com> MIME-Version: 1.0 Subject: [Buildroot] [PATCHv4 02/16] core: enable 'NDEBUG' unless BR2_ENABLE_RUNTIME_DEBUG is set X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas De Schampheleire Errors-To: buildroot-bounces@busybox.net Sender: "buildroot" From: Thomas De Schampheleire The 'assert' statement in glibc honors the 'NDEBUG' preprocessor macro: if it is set, then the assert statement is compiled away. Define this 'NDEBUG' macro when BR2_ENABLE_RUNTIME_DEBUG is disabled (the default case). Signed-off-by: Thomas De Schampheleire Reviewed-by: Yann E. MORIN --- v4: reintroduced patch on suggestion of Arnout. I had previously dropped it from the series based on an incorrect conclusion. package/Makefile.in | 3 +++ 1 file changed, 3 insertions(+) diff --git a/package/Makefile.in b/package/Makefile.in index 86db62ba5b..955e6a8e8c 100644 --- a/package/Makefile.in +++ b/package/Makefile.in @@ -148,6 +148,9 @@ endif ifeq ($(BR2_DEBUG_3),y) TARGET_DEBUGGING = -g3 endif +ifeq ($(BR2_ENABLE_RUNTIME_DEBUG),) +TARGET_DEBUGGING += -DNDEBUG +endif TARGET_LDFLAGS = $(call qstrip,$(BR2_TARGET_LDFLAGS)) From patchwork Tue Jun 1 14:34:08 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas De Schampheleire X-Patchwork-Id: 1486008 Return-Path: X-Original-To: incoming-buildroot@patchwork.ozlabs.org Delivered-To: patchwork-incoming-buildroot@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=busybox.net (client-ip=2605:bc80:3010::137; helo=smtp4.osuosl.org; envelope-from=buildroot-bounces@busybox.net; receiver=) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=MJ3pASxZ; dkim-atps=neutral Received: from smtp4.osuosl.org (smtp4.osuosl.org [IPv6:2605:bc80:3010::137]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4FvZSg1GCGz9sj1 for ; Wed, 2 Jun 2021 00:35:14 +1000 (AEST) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 6F06F402B9; Tue, 1 Jun 2021 14:35:12 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id aXjyS6AXxmYO; Tue, 1 Jun 2021 14:35:11 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp4.osuosl.org (Postfix) with ESMTP id 4003D402DD; Tue, 1 Jun 2021 14:35:10 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by ash.osuosl.org (Postfix) with ESMTP id B03151BF577 for ; Tue, 1 Jun 2021 14:34:34 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id AD43C404B0 for ; Tue, 1 Jun 2021 14:34:34 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id wRV6ngtU0_Yq for ; Tue, 1 Jun 2021 14:34:33 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.8.0 Received: from mail-ej1-x634.google.com (mail-ej1-x634.google.com [IPv6:2a00:1450:4864:20::634]) by smtp4.osuosl.org (Postfix) with ESMTPS id 5DC5840472 for ; Tue, 1 Jun 2021 14:34:33 +0000 (UTC) Received: by mail-ej1-x634.google.com with SMTP id h24so18130926ejy.2 for ; Tue, 01 Jun 2021 07:34:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=hrjIqoEP9HfHqZS4sB6CbkZq8RyrQPfAQlHyEwY110o=; b=MJ3pASxZMzlZfik1xRuHoqNoLVCDb6BHtZCKBjl+VmzVvSS1EPX3bO2XTPl7GJ8Ub8 OixiAVAHtQj7zxZlJsr9Yds5AaKpqD1GyF1ty5CvhoLnvkZrFIB0P4SsoJL05x+89hKA CF8/CMdZ/V1/aG+LSxsLFGz39Olv++1vZoqbUtnh7mgzkkfHmM4uOcrR5QOiM5sRGGmF R2z/FgoJbBXWXD8b01Y5wwAh+fqlg+fDF9KgzgauWY2lJa4mHYhq0dyxy4thx5nvQUQ6 G1Yexq6tEiaiW12Qpbw5rf8H8wK69WWMMHr9yVMsayKVT98FyYwNeZfmNSc0rvKu/V2z czYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=hrjIqoEP9HfHqZS4sB6CbkZq8RyrQPfAQlHyEwY110o=; b=IMIRcOQrGZkziEXT68L3glk7odiyroGkITxgVshX+jz8d8CV6xHWgMBWUpXVjtIP4/ fjeCfV3uu16IiF5FxFC5Jdo2qNouKtRt3inkh4CMDroUp3AglMNPgfYHJK9Jk0kOtlwr durQ/z6Vy/YQ5CRgEoi2/FAso1wqzMO5u61PnWFYkCY71n9D9HTXekoiXYKS8M4g6v8+ IY7M04yNoLhUJ+W6f95nQ66RtzHiMIyR7Mw/RM7Vno8CeBATPWPHAivngxf6ayBbayyG /EzLQ9FI28kBRUlVxdh4PmSGRwObhoVgPS0x/lA9/l96T1xO2+ba0lG6IW/TUhFCx/1i NS0g== X-Gm-Message-State: AOAM530GzOrc+YlyqNo4BFmGgTFd5HY3mFdF4FereFolHq+O8awbUgra tZ/c3R9R1V28vNYkaTIrEjX85YA1RR0jDXgN X-Google-Smtp-Source: ABdhPJwYrvYnj0/+n5lG2BwmpYajBZNn8wo52nD3MkJuUlE/HkVk6ek0sBdVKWoB4VoqG8i+zuk3PQ== X-Received: by 2002:a17:906:e01:: with SMTP id l1mr4812567eji.280.1622558071671; Tue, 01 Jun 2021 07:34:31 -0700 (PDT) Received: from localhost (ptr-5gw9txf6g5tndjqqqz.18120a2.ip6.access.telenet.be. [2a02:1810:510:3800:1b15:18e4:57d1:eb]) by smtp.gmail.com with ESMTPSA id de19sm1352913edb.70.2021.06.01.07.34.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Jun 2021 07:34:31 -0700 (PDT) From: Thomas De Schampheleire To: buildroot@buildroot.org Date: Tue, 1 Jun 2021 16:34:08 +0200 Message-Id: <20210601143422.25064-4-patrickdepinguin@gmail.com> X-Mailer: git-send-email 2.26.3 In-Reply-To: <20210601143422.25064-1-patrickdepinguin@gmail.com> References: <20210601143422.25064-1-patrickdepinguin@gmail.com> MIME-Version: 1.0 Subject: [Buildroot] [PATCHv4 03/16] package/pkg-cmake.mk: determine CMAKE_BUILD_TYPE depending on BR2_ENABLE_RUNTIME_DEBUG X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Samuel Martin , Thomas De Schampheleire Errors-To: buildroot-bounces@busybox.net Sender: "buildroot" From: Thomas De Schampheleire The CMAKE_BUILD_TYPE is currently set as 'Debug' in case BR2_ENABLE_DEBUG is set, and as 'Release' in other cases. However, while the description of BR2_ENABLE_DEBUG is to enable debug symbols (no runtime impact), the 'Debug' build type in CMake can actually have runtime impact. For one, because it does not set -DNDEBUG like is done for 'Release', but also because packages may do custom things based on it. The question of which CMAKE_BUILD_TYPE Buildroot should set, be it 'Debug', 'Release', 'RelWithDebInfo' or others, has come up several times in the past. See some references below: - July 2016: switch from Debug to RelWithDebInfo: https://git.buildroot.org/buildroot/commit/?id=4b0120183404913f7f7788ef4f0f6b51498ef363 - October 2016: switch from RelWithDebInfo back to Debug: https://git.buildroot.org/buildroot/commit/?id=104bb29e0490bfb487e2e665448dd3ca07fcc2b5 and changes to make sure Buildroot's flags are respected: https://git.buildroot.org/buildroot/commit/?id=12494ef48f893684d0800e7f6fe39a2ceaed0451 - August 2017: bug #10246 - "BR2_ENABLE_DEBUG does not have the expected effect for cmake packages" https://bugs.busybox.net/show_bug.cgi?id=10246 - August 2017: mail thread following bug #10246: http://lists.busybox.net/pipermail/buildroot/2017-August/200778.html In the last mail thread, Samuel Martin confirmed that the 'Release' build type could be used in all cases, because Buildroot is actually making sure that the optimization flags are those determined by Buildroot, not the defaults of cmake, thanks to commit 12494ef48f. But Arnout Vandecappelle objected to using always 'Release', stating that users may actually want the extra assertions. With the introduction of BR2_ENABLE_RUNTIME_DEBUG, Buildroot can now cater for all cases: - use CMAKE_BUILD_TYPE=Release by default. This makes sure that there is no unexpected performance degradation triggered by enabling BR2_ENABLE_DEBUG. - users can optionally enable BR2_ENABLE_RUNTIME_DEBUG if they want runtime debug info like assertions, at the risk of introducing performance degradation. In this case, we switch to CMAKE_BUILD_TYPE=Debug. - orthogonally to the above, BR2_ENABLE_DEBUG still determines passing the '-g' flag to enable debug symbols, and BR2_OPTIMIZE_X still determines the used optimization flags. Signed-off-by: Thomas De Schampheleire Acked-by: Arnout Vandecappelle (Essensium/Mind) Reviewed-by: Yann E. MORIN --- docs/manual/adding-packages-cmake.txt | 2 +- package/pkg-cmake.mk | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/manual/adding-packages-cmake.txt b/docs/manual/adding-packages-cmake.txt index 73f0943024..541d7422cf 100644 --- a/docs/manual/adding-packages-cmake.txt +++ b/docs/manual/adding-packages-cmake.txt @@ -100,7 +100,7 @@ typical packages will therefore only use a few of them. necessary to set them in the package's +*.mk+ file unless you want to override them: -** +CMAKE_BUILD_TYPE+ is driven by +BR2_ENABLE_DEBUG+; +** +CMAKE_BUILD_TYPE+ is driven by +BR2_ENABLE_RUNTIME_DEBUG+; ** +CMAKE_INSTALL_PREFIX+; ** +BUILD_SHARED_LIBS+ is driven by +BR2_STATIC_LIBS+; ** +BUILD_DOC+, +BUILD_DOCS+ are disabled; diff --git a/package/pkg-cmake.mk b/package/pkg-cmake.mk index 37078f3c34..4ee100a0c6 100644 --- a/package/pkg-cmake.mk +++ b/package/pkg-cmake.mk @@ -266,7 +266,7 @@ define TOOLCHAIN_CMAKE_INSTALL_FILES -e 's#@@CMAKE_SYSTEM_PROCESSOR@@#$(call qstrip,$(CMAKE_SYSTEM_PROCESSOR))#' \ -e 's#@@TOOLCHAIN_HAS_CXX@@#$(if $(BR2_INSTALL_LIBSTDCPP),1,0)#' \ -e 's#@@TOOLCHAIN_HAS_FORTRAN@@#$(if $(BR2_TOOLCHAIN_HAS_FORTRAN),1,0)#' \ - -e 's#@@CMAKE_BUILD_TYPE@@#$(if $(BR2_ENABLE_DEBUG),Debug,Release)#' \ + -e 's#@@CMAKE_BUILD_TYPE@@#$(if $(BR2_ENABLE_RUNTIME_DEBUG),Debug,Release)#' \ $(TOPDIR)/support/misc/toolchainfile.cmake.in \ > $(HOST_DIR)/share/buildroot/toolchainfile.cmake $(Q)$(INSTALL) -D -m 0644 support/misc/Buildroot.cmake \ From patchwork Tue Jun 1 14:34:09 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas De Schampheleire X-Patchwork-Id: 1486009 Return-Path: X-Original-To: incoming-buildroot@patchwork.ozlabs.org Delivered-To: patchwork-incoming-buildroot@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=busybox.net (client-ip=2605:bc80:3010::138; helo=smtp1.osuosl.org; envelope-from=buildroot-bounces@busybox.net; receiver=) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=O2U0KZAS; dkim-atps=neutral Received: from smtp1.osuosl.org (smtp1.osuosl.org [IPv6:2605:bc80:3010::138]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4FvZSw03t7z9sj1 for ; Wed, 2 Jun 2021 00:35:27 +1000 (AEST) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 2023D83CB2; Tue, 1 Jun 2021 14:35:25 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id xLZ_DR18IUNB; Tue, 1 Jun 2021 14:35:24 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp1.osuosl.org (Postfix) with ESMTP id 57A6E83CAF; Tue, 1 Jun 2021 14:35:23 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by ash.osuosl.org (Postfix) with ESMTP id 647C31BF577 for ; Tue, 1 Jun 2021 14:34:36 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 5FBB96082C for ; Tue, 1 Jun 2021 14:34:36 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Authentication-Results: smtp3.osuosl.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id cAM25eIMtrvt for ; Tue, 1 Jun 2021 14:34:35 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.8.0 Received: from mail-ej1-x62e.google.com (mail-ej1-x62e.google.com [IPv6:2a00:1450:4864:20::62e]) by smtp3.osuosl.org (Postfix) with ESMTPS id 74DB760793 for ; Tue, 1 Jun 2021 14:34:35 +0000 (UTC) Received: by mail-ej1-x62e.google.com with SMTP id qq22so13802743ejb.9 for ; Tue, 01 Jun 2021 07:34:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=vMPWsPwh0CXvD09VreqPpPVFqoe6ffGHdgq7cOLnwfc=; b=O2U0KZAStELmfI368Gt5ziLmmUuXdkIcuyDekuOVDRbGwEiyeMN0R9nj7DSDuCgcYh ZDBWD3rAYjRgyJrnle+Fnn+qxaaTXdBRF+SfiY3gNgmCIgk4h4H0db93ljvJ/jR8+Ygh Gkd7xrwsZNwK4xNECjiOuaw4UY2LEgA2y9w8XBL61c4T1hXqJ8CoUnSmruMLG13YweNT WDyLWMMdwMs6aSIZQ5Pae8GdPADhAF3kyRgLEdxigVPtoR2vwkqFy7leCPnuba6CkLjr 0ftqwynOHconZEsFZDQxNsRGDMQn5EtiOIAjAX1O0/CEUzUK+FW5u6JM9PFO6cnf5dxK neww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=vMPWsPwh0CXvD09VreqPpPVFqoe6ffGHdgq7cOLnwfc=; b=pIfR28SQ2NpOzhHuJA4zpJ6nzHx0f06RUaBYn9TbI/A3RAQaYO/bIQ6It/j28uW/Ha Y840naxu1UaOeouwFEaD55LyhPLKBy0/i5u/OLyVGtkB0nF9iqi2jpVM92exDGMG07q3 ThDI/eGoSjQKUUKule8JCGcuQAcGziHGfkKS7K3uUAe0KeixSiP9/leOhj8XTjTAkSdt hbELw/83Bjro06g4u2Wp316xFaQcm8km7oXe7YcOVLRGDWggW5ZgpEsl1VeVDDdBsWfN +vQxrW1CPbq32hEnp/jw9yDDEW7XzUqU45//am51bO/0O4nj0I+mNiBh8N0itICjmTsa OU3g== X-Gm-Message-State: AOAM530ULlD/1VITfelbKIwlV8WodXoDNXZf3r5Fz4+HEWqS68+cmImi IS9A9n/+5xdtZP1E3FWdFsMmycmnQln3LLQ9 X-Google-Smtp-Source: ABdhPJzppqun0bsY7Ca0F6AJVF+VuOMzhwuAwTWXteHRvsLInE/8B/yCiq6jfotP3zd3+BN2y8ZZyA== X-Received: by 2002:a17:907:c02:: with SMTP id ga2mr2750057ejc.513.1622558073630; Tue, 01 Jun 2021 07:34:33 -0700 (PDT) Received: from localhost (ptr-5gw9txf6g5tndjqqqz.18120a2.ip6.access.telenet.be. [2a02:1810:510:3800:1b15:18e4:57d1:eb]) by smtp.gmail.com with ESMTPSA id ga3sm7360467ejb.34.2021.06.01.07.34.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Jun 2021 07:34:32 -0700 (PDT) From: Thomas De Schampheleire To: buildroot@buildroot.org Date: Tue, 1 Jun 2021 16:34:09 +0200 Message-Id: <20210601143422.25064-5-patrickdepinguin@gmail.com> X-Mailer: git-send-email 2.26.3 In-Reply-To: <20210601143422.25064-1-patrickdepinguin@gmail.com> References: <20210601143422.25064-1-patrickdepinguin@gmail.com> MIME-Version: 1.0 Subject: [Buildroot] [PATCHv4 04/16] package/flare-engine: disable effect of CMAKE_BUILD_TYPE X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Romain Naour , Thomas De Schampheleire Errors-To: buildroot-bounces@busybox.net Sender: "buildroot" From: Thomas De Schampheleire flare-engine enables profiling when CMAKE_BUILD_TYPE is 'Debug'. The Buildroot package explicitly avoided that by forcing CMAKE_BUILD_TYPE to 'RelWithDebInfo' when pkg-cmake.mk would normally set it to 'Debug'. Until recently, this was the case when BR2_ENABLE_DEBUG was enabled. A previous commit changed the condition under which CMAKE_BUILD_TYPE=Debug was set, from BR2_ENABLE_DEBUG=y to BR2_ENABLE_RUNTIME_DEBUG=y, so logically the flare-engine package would have to be updated accordingly. However, apart from the profiling flag, the flare-engine package only uses CMAKE_BUILD_TYPE to determine flags that Buildroot wants to control itself, like optimization and debugging flags. This means we can fake CMAKE_BUILD_TYPE to a value that has no meaning for flare-engine itself, without needing to check BR2_ENABLE_DEBUG nor BR2_ENABLE_RUNTIME_DEBUG. Incidentally, this trick was already done in case BR2_TOOLCHAIN_HAS_GCC_BUG_85180 was true, so move that line out of this condition. Signed-off-by: Thomas De Schampheleire --- v4: - use a custom build type as suggested by Arnout. package/flare-engine/flare-engine.mk | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/package/flare-engine/flare-engine.mk b/package/flare-engine/flare-engine.mk index e2f3eefa28..b91fc16af3 100644 --- a/package/flare-engine/flare-engine.mk +++ b/package/flare-engine/flare-engine.mk @@ -14,16 +14,12 @@ FLARE_ENGINE_DEPENDENCIES += sdl2 sdl2_image sdl2_mixer sdl2_ttf # Don't use /usr/games and /usr/share/games FLARE_ENGINE_CONF_OPTS += -DBINDIR=bin -DDATADIR=share/flare -# Don't use the default Debug type as it adds -pg (gprof) -ifeq ($(BR2_ENABLE_DEBUG),y) -FLARE_ENGINE_CONF_OPTS += -DCMAKE_BUILD_TYPE=RelWithDebInfo -endif +# CMAKE_BUILD_TYPE is only used to set optimization and debug flags, all of +# which we want Buildroot to steer explicitly. Explicitly set a fake build type +# to get this control. +FLARE_ENGINE_CONF_OPTS += -DCMAKE_BUILD_TYPE=Buildroot ifeq ($(BR2_TOOLCHAIN_HAS_GCC_BUG_85180),y) -# CMakeLists.txt sets CMAKE_CXX_FLAGS_ depending on -# BUILD_TYPE, and this comes after the generic CMAKE_CXX_FLAGS. -# Override CMAKE_BUILD_TYPE so no overrides are applied. -FLARE_ENGINE_CONF_OPTS += -DCMAKE_BUILD_TYPE=Buildroot FLARE_ENGINE_CONF_OPTS += -DCMAKE_CXX_FLAGS="$(TARGET_CXXFLAGS) -O0" endif From patchwork Tue Jun 1 14:34:10 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas De Schampheleire X-Patchwork-Id: 1486010 Return-Path: X-Original-To: incoming-buildroot@patchwork.ozlabs.org Delivered-To: patchwork-incoming-buildroot@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=busybox.net (client-ip=2605:bc80:3010::137; helo=smtp4.osuosl.org; envelope-from=buildroot-bounces@busybox.net; receiver=) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=vLP6GKzG; dkim-atps=neutral Received: from smtp4.osuosl.org (smtp4.osuosl.org [IPv6:2605:bc80:3010::137]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4FvZT80tVvz9sj1 for ; Wed, 2 Jun 2021 00:35:39 +1000 (AEST) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id DB1EA404BA; Tue, 1 Jun 2021 14:35:37 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id rQuAJrmQDJWa; Tue, 1 Jun 2021 14:35:37 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp4.osuosl.org (Postfix) with ESMTP id 0E90F404B8; Tue, 1 Jun 2021 14:35:36 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by ash.osuosl.org (Postfix) with ESMTP id 277B41BF577 for ; Tue, 1 Jun 2021 14:34:38 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 15E4E6082C for ; Tue, 1 Jun 2021 14:34:38 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Authentication-Results: smtp3.osuosl.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id BEHTtQdGHtoe for ; Tue, 1 Jun 2021 14:34:37 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.8.0 Received: from mail-ed1-x529.google.com (mail-ed1-x529.google.com [IPv6:2a00:1450:4864:20::529]) by smtp3.osuosl.org (Postfix) with ESMTPS id 51DA860793 for ; Tue, 1 Jun 2021 14:34:37 +0000 (UTC) Received: by mail-ed1-x529.google.com with SMTP id dj8so5378239edb.6 for ; Tue, 01 Jun 2021 07:34:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=dJNlRb9oWVWJYS5EcvbOvKqdbzSWJtWnTnI8xiXahqE=; b=vLP6GKzGfdmp7DdAj/6gKFShb/gfI5bep9rZCuJUkHIbTAZClECaiZirW0oT8IikBl YQKH1KlirzgtZuBcMoczEWdU6uU5u6twaMgkiga8qz12r8iIpNUflkgHaDQ2njYgfrWg FpovLELPg3Grr4qRWGrXYoBR8ath5iJ+Hiq5JdhlBF9adAFENSoaGiwAHbAlQ2l7YWcH P0VeVJKhpN3vQ0N4bf6cKnjIkrrpdgvLImW5KrmuV/xxSkoMa0c0GWx0Cx5ZOYsgBGPn SN/nia6+c7brz3FXLaINRhS6/o10ysWz0tltyJ/tAMgctIAeeNSEcS4oZU49ahy3Q9Tb IeVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=dJNlRb9oWVWJYS5EcvbOvKqdbzSWJtWnTnI8xiXahqE=; b=GocpNC9bqNFxw4RqdUptqfHKlskB/NvyQmsfn44TL5U5K537/wAXCxAr/9UntDfgl8 ZElJV5rN/sAuoqNdrwjuAwzgoBlFiSqsm3iyBzCnSE/j2OQgFfemV0JbRrktYw9gzInC CEG0Ui4XveGndUpTe1PZpF3tARh+5dLHvzRu9zgoTEjHI26gFRv01989hmiIzMkTW9fY /Q1n7LP8pxiDpiAPnT6PeUXfOjVoLn9hlKFaS+h88/YHxOVh6RXjTZ3KD6hONxJqNo8q I8H/KXoKzyKHIIbqmuH/7AXbRsFiCZeHt+AhkMJIYMr8qxPgO4IJpGq8MnRMyX1RQuKg jkew== X-Gm-Message-State: AOAM533jYa8YFFGgO7rtZRHTvqAgNb8cZzJGdETHypM5sbiscUf5JiOq fayAUECzspxQ0r0rW/Q8eA6E0F5dyFzrQ9pZ X-Google-Smtp-Source: ABdhPJz+uPs8UjQYjQVQkMYtAJwbNQaSef/hViPsLRGf2a7ECx1egnySnlDI4y2j29LdSEnhWIaXyA== X-Received: by 2002:a50:8d84:: with SMTP id r4mr1810736edh.24.1622558075447; Tue, 01 Jun 2021 07:34:35 -0700 (PDT) Received: from localhost (ptr-5gw9txf6g5tndjqqqz.18120a2.ip6.access.telenet.be. [2a02:1810:510:3800:1b15:18e4:57d1:eb]) by smtp.gmail.com with ESMTPSA id z17sm7349336ejc.69.2021.06.01.07.34.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Jun 2021 07:34:35 -0700 (PDT) From: Thomas De Schampheleire To: buildroot@buildroot.org Date: Tue, 1 Jun 2021 16:34:10 +0200 Message-Id: <20210601143422.25064-6-patrickdepinguin@gmail.com> X-Mailer: git-send-email 2.26.3 In-Reply-To: <20210601143422.25064-1-patrickdepinguin@gmail.com> References: <20210601143422.25064-1-patrickdepinguin@gmail.com> MIME-Version: 1.0 Subject: [Buildroot] [PATCHv4 05/16] package/sysrepo: use default CMAKE_BUILD_TYPE for host package X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Heiko Thiery , =?utf-8?q?Jan_Kundr=C3=A1t?= , Thomas De Schampheleire Errors-To: buildroot-bounces@busybox.net Sender: "buildroot" From: Thomas De Schampheleire Use the default build type for host-sysrepo. In the current version of sysrepo, this happens to be 'Debug'. As 'Debug' also enables tests, explicitly disable them. Suggested-by: Arnout Vandecappelle (Essensium/Mind) Signed-off-by: Thomas De Schampheleire Acked-by: Arnout Vandecappelle (Essensium/Mind) Acked-by: Heiko Thiery --- package/sysrepo/sysrepo.mk | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/package/sysrepo/sysrepo.mk b/package/sysrepo/sysrepo.mk index dbc7b16b63..f5be29d2c9 100644 --- a/package/sysrepo/sysrepo.mk +++ b/package/sysrepo/sysrepo.mk @@ -26,8 +26,9 @@ define SYSREPO_INSTALL_INIT_SYSV endef HOST_SYSREPO_CONF_OPTS = \ - -DCMAKE_BUILD_TYPE=Release \ -DBUILD_EXAMPLES=OFF \ + -DENABLE_TESTS=OFF \ + -DENABLE_VALGRIND_TESTS=OFF \ -DREPO_PATH=$(TARGET_DIR)/etc/sysrepo $(eval $(cmake-package)) From patchwork Tue Jun 1 14:34:11 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas De Schampheleire X-Patchwork-Id: 1486011 Return-Path: X-Original-To: incoming-buildroot@patchwork.ozlabs.org Delivered-To: patchwork-incoming-buildroot@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=busybox.net (client-ip=140.211.166.138; helo=smtp1.osuosl.org; envelope-from=buildroot-bounces@busybox.net; receiver=) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=YS+GYPOM; dkim-atps=neutral Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4FvZTN5Zw0z9sj1 for ; Wed, 2 Jun 2021 00:35:52 +1000 (AEST) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id C9CB983CB9; Tue, 1 Jun 2021 14:35:50 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id TpKZUjsafpWH; Tue, 1 Jun 2021 14:35:50 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp1.osuosl.org (Postfix) with ESMTP id 2D7AC83CB8; Tue, 1 Jun 2021 14:35:49 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id 075CC1BF577 for ; Tue, 1 Jun 2021 14:34:41 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id EB951839E6 for ; Tue, 1 Jun 2021 14:34:40 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id pnb1hbojD_UN for ; Tue, 1 Jun 2021 14:34:40 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.8.0 Received: from mail-ej1-x62d.google.com (mail-ej1-x62d.google.com [IPv6:2a00:1450:4864:20::62d]) by smtp1.osuosl.org (Postfix) with ESMTPS id 2F48F8392C for ; Tue, 1 Jun 2021 14:34:40 +0000 (UTC) Received: by mail-ej1-x62d.google.com with SMTP id ci15so18703732ejc.10 for ; Tue, 01 Jun 2021 07:34:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Q4iFV4ROpr7TkJzMC0JMXBPkh17VlpvWguqKXkZAviQ=; b=YS+GYPOMXElRRyMXatl3xp8hIwJ+WB+jhTBrfj0tHl8CiAN3Hka65gq+qFP4rNG8EL Gl2uiLVO4Mux0S/WITlo6778PDoeE+Hu0sbY8YkYVJZ41KwRmaptsF3XuacuMfkJG/Jm GRinMDtz+kGWRiuI7w41HQ7K26wo2h7nud6lC/GNtdaJA8YZARy5ENKQhQdGfPGSCeol 3YgrGRO5gxJBZt47l0ssXa2udNNXHNLZTXw/IGTyuNU3hdPrX9qyHOU3DrqDUjs+hTNr lV2t6KXV+Ch7HcBqW8iuk6llEptSbIqv77DF0QiSQ826gLbznN/h9Szdwu6C1G9ryW+B lllw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Q4iFV4ROpr7TkJzMC0JMXBPkh17VlpvWguqKXkZAviQ=; b=b9nDkB3O9ohP0x+FF/ssx0EaoHgmRi6U9dzKMZ5VUPC16MKK5frZtg4S8wKSgC/j0J eVV5JaBdFCOCW6uc7jRYgIzyNr13dCIY94L8QfwCAPfqzPG6RQrPGNp32QWwh/tHLcCT Xb4f2tqRgb2IM0+SnxJ/ebw2mmgIlEwgApdX2hNnnJ2B50qFf5TY5G3oLjvXZSkEJ4U4 vrnGxZNdOuYRg7MK/t9Mqa7MOnSLwYdYbJfB46Y3IuCp1DMnlbKBMhxDRrx0Z3fd+3LD /CzuseovzEXDl0RmUWcli7FPP+VPgLOrVygoFyFeSzBM685tS6xAsAUw0U7XFoHCLlXr 8sWw== X-Gm-Message-State: AOAM533uPz9dzwVMaBPPoIbtn9PE9WTuTL6+VLFPSt5ZhLy76pNMaiER GQrrQgkv9YOh7DOPvduSD5/JwkCAGcwCRbuG X-Google-Smtp-Source: ABdhPJzmMjT35TfISbAInUukUhp9rHlOVwBs7rAAQgNaWAgMTP6cv3i9Ed/nU6cJXeqhS1fA4lbvtA== X-Received: by 2002:a17:906:9715:: with SMTP id k21mr21447518ejx.553.1622558077707; Tue, 01 Jun 2021 07:34:37 -0700 (PDT) Received: from localhost (ptr-5gw9txf6g5tndjqqqz.18120a2.ip6.access.telenet.be. [2a02:1810:510:3800:1b15:18e4:57d1:eb]) by smtp.gmail.com with ESMTPSA id f7sm8728425edd.5.2021.06.01.07.34.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Jun 2021 07:34:37 -0700 (PDT) From: Thomas De Schampheleire To: buildroot@buildroot.org Date: Tue, 1 Jun 2021 16:34:11 +0200 Message-Id: <20210601143422.25064-7-patrickdepinguin@gmail.com> X-Mailer: git-send-email 2.26.3 In-Reply-To: <20210601143422.25064-1-patrickdepinguin@gmail.com> References: <20210601143422.25064-1-patrickdepinguin@gmail.com> MIME-Version: 1.0 Subject: [Buildroot] [PATCHv4 06/16] package/sysrepo: remove explicit setting of CMAKE_BUILD_TYPE X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Heiko Thiery , =?utf-8?q?Jan_Kundr=C3=A1t?= , Thomas De Schampheleire Errors-To: buildroot-bounces@busybox.net Sender: "buildroot" From: Thomas De Schampheleire sysrepo explicitly sets CMAKE_BUILD_TYPE=Release, ignoring any possible value of BR2_ENABLE_DEBUG (previously) or BR2_ENABLE_RUNTIME_DEBUG (now). With the introduction of BR2_ENABLE_RUNTIME_DEBUG, this change should no longer be necessary. Users that do not wish to have additional runtime debugging just keep BR2_ENABLE_RUNTIME_DEBUG disabled (default value). As the 'Debug' build type enables tests, disable them explicitly. As the 'Debug' build type uses a custom REPO_PATH which does not exist on target, force /etc/sysrepo like in the 'Release' build type. Signed-off-by: Thomas De Schampheleire Acked-by: Arnout Vandecappelle (Essensium/Mind) Acked-by: Heiko Thiery --- package/sysrepo/sysrepo.mk | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/package/sysrepo/sysrepo.mk b/package/sysrepo/sysrepo.mk index f5be29d2c9..c0db05e52c 100644 --- a/package/sysrepo/sysrepo.mk +++ b/package/sysrepo/sysrepo.mk @@ -13,8 +13,10 @@ SYSREPO_DEPENDENCIES = libyang pcre host-sysrepo HOST_SYSREPO_DEPENDENCIES = host-libyang host-pcre SYSREPO_CONF_OPTS = \ - -DCMAKE_BUILD_TYPE=Release \ - -DBUILD_EXAMPLES=$(if $(BR2_PACKAGE_SYSREPO_EXAMPLES),ON,OFF) + -DBUILD_EXAMPLES=$(if $(BR2_PACKAGE_SYSREPO_EXAMPLES),ON,OFF) \ + -DENABLE_TESTS=OFF \ + -DENABLE_VALGRIND_TESTS=OFF \ + -DREPO_PATH=/etc/sysrepo ifeq ($(BR2_TOOLCHAIN_HAS_LIBATOMIC),y) SYSREPO_CONF_OPTS += -DCMAKE_EXE_LINKER_FLAGS=-latomic From patchwork Tue Jun 1 14:34:12 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas De Schampheleire X-Patchwork-Id: 1486012 Return-Path: X-Original-To: incoming-buildroot@patchwork.ozlabs.org Delivered-To: patchwork-incoming-buildroot@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=busybox.net (client-ip=2605:bc80:3010::133; helo=smtp2.osuosl.org; envelope-from=buildroot-bounces@busybox.net; receiver=) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=WgsJ11ci; dkim-atps=neutral Received: from smtp2.osuosl.org (smtp2.osuosl.org [IPv6:2605:bc80:3010::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4FvZTd4v1qz9t0G for ; Wed, 2 Jun 2021 00:36:05 +1000 (AEST) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 81D4F4023D; Tue, 1 Jun 2021 14:36:03 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Dp0d6UA1Q_iG; Tue, 1 Jun 2021 14:36:02 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp2.osuosl.org (Postfix) with ESMTP id E566F40249; Tue, 1 Jun 2021 14:36:01 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by ash.osuosl.org (Postfix) with ESMTP id 1AFBB1BF577 for ; Tue, 1 Jun 2021 14:34:43 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 0AEB64028D for ; Tue, 1 Jun 2021 14:34:43 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Pwo0kwVkHeU3 for ; Tue, 1 Jun 2021 14:34:42 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.8.0 Received: from mail-ej1-x629.google.com (mail-ej1-x629.google.com [IPv6:2a00:1450:4864:20::629]) by smtp2.osuosl.org (Postfix) with ESMTPS id 04A1E40288 for ; Tue, 1 Jun 2021 14:34:41 +0000 (UTC) Received: by mail-ej1-x629.google.com with SMTP id c10so833068eja.11 for ; Tue, 01 Jun 2021 07:34:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=CwoIEc6hImsHkPW/O0v+0EaKooRJp1BxaKiB19+44iY=; b=WgsJ11ciMpndxbQDYabvwy0dP5dICksxZEYaO0zCz1RV7ik4ESn0f/mHEd13xHQYpE iE7ZEp8Bq214BoRaTN5VX+Ka4yYrRr8hKsbCsEN+rBminJcLG7sF251FSfnR6HN/Ja/r 86WCYKKorfZPvvGuJo/THIzDb3i8pAkXrJHCoz2puqruKGvth4Zg8sThjor/5jGYhWGE DohluXkjXycFAX6cS4dd1XK+fzFh3z0JwDNFvlnaI7XGUZDdPiP5jcsBq2SJirywPUt1 YRiD850lk5Ab9P5VyqiuvNjgNUKCaYJ3aIVvnnZlaKvCjuQD2YDxn2QxQh9C+Tbgann/ gv4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=CwoIEc6hImsHkPW/O0v+0EaKooRJp1BxaKiB19+44iY=; b=ckQVMfblz5LBl6a56gOihbEHxcZFz6GJMJ2iyvaNbPEmbASzTCcWDkDy34IRTr7mPH ddZVn6zBWeWLMvaR/5kiVHzK7LICW+UQZb7tvWXPFKI1maSTkf510RxEubd2UCcDB35h b2s80xdD2JTDPZb+1im9/+ioHy/yldZyTi5kTzNVRGFKI5H3I2BdWxsZguzdHWfcsWC6 t4YHSztWfeMlSNx8PafcF4J77CRCE+rkCD8Jq5sZ0LeNUwKKUy5xpo9lp8y9zrkxCNG5 HkK9Gn2DzhPcP0UB957Oz8W0kKmERRDJCgIaZ+wuZYN+EsoU3m/0Jov9n98VNF9Yqksl H8cg== X-Gm-Message-State: AOAM532ydRp6zQbp5abRszviQJ8033nBtNiwZmn0X2pNPb+FTxMxtpqf AB5GTsNENWipK+taeTjbe5ip90ODuffSO8Wm X-Google-Smtp-Source: ABdhPJzUIVNMa3EgvBjEHuN4YsU02FPcynB6GvlEBugqLs1bwEDkeufcZqN3atlHzWkyROa8vpjq5w== X-Received: by 2002:a17:906:7203:: with SMTP id m3mr28848962ejk.381.1622558080241; Tue, 01 Jun 2021 07:34:40 -0700 (PDT) Received: from localhost (ptr-5gw9txf6g5tndjqqqz.18120a2.ip6.access.telenet.be. [2a02:1810:510:3800:1b15:18e4:57d1:eb]) by smtp.gmail.com with ESMTPSA id t2sm5249582ejx.72.2021.06.01.07.34.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Jun 2021 07:34:39 -0700 (PDT) From: Thomas De Schampheleire To: buildroot@buildroot.org Date: Tue, 1 Jun 2021 16:34:12 +0200 Message-Id: <20210601143422.25064-8-patrickdepinguin@gmail.com> X-Mailer: git-send-email 2.26.3 In-Reply-To: <20210601143422.25064-1-patrickdepinguin@gmail.com> References: <20210601143422.25064-1-patrickdepinguin@gmail.com> MIME-Version: 1.0 Subject: [Buildroot] [PATCHv4 07/16] package/boost: use BR2_ENABLE_RUNTIME_DEBUG iso BR2_ENABLE_DEBUG X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas De Schampheleire Errors-To: buildroot-bounces@busybox.net Sender: "buildroot" From: Thomas De Schampheleire BR2_ENABLE_DEBUG should just steer the availability of debug symbols and should have no negative effect on performance. Introduction of 'assert' statements, 'debug'-type builds with additional logging, etc. should be steered by BR2_ENABLE_RUNTIME_DEBUG instead. Signed-off-by: Thomas De Schampheleire --- package/boost/boost.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package/boost/boost.mk b/package/boost/boost.mk index 8d745ecc72..e72ddf897c 100644 --- a/package/boost/boost.mk +++ b/package/boost/boost.mk @@ -95,7 +95,7 @@ BOOST_OPTS += --no-cmake-config \ toolset=gcc \ threading=multi \ abi=$(BOOST_ABI) \ - variant=$(if $(BR2_ENABLE_DEBUG),debug,release) + variant=$(if $(BR2_ENABLE_RUNTIME_DEBUG),debug,release) ifeq ($(BR2_sparc64),y) BOOST_OPTS += architecture=sparc instruction-set=ultrasparc From patchwork Tue Jun 1 14:34:13 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas De Schampheleire X-Patchwork-Id: 1486013 Return-Path: X-Original-To: incoming-buildroot@patchwork.ozlabs.org Delivered-To: patchwork-incoming-buildroot@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=busybox.net (client-ip=140.211.166.136; helo=smtp3.osuosl.org; envelope-from=buildroot-bounces@busybox.net; receiver=) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=a/y9Z0Yr; dkim-atps=neutral Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4FvZTs5SXcz9sj1 for ; Wed, 2 Jun 2021 00:36:17 +1000 (AEST) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 0DAFC60793; Tue, 1 Jun 2021 14:36:16 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Wwu_MN6quqLE; Tue, 1 Jun 2021 14:36:15 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp3.osuosl.org (Postfix) with ESMTP id 5695B60758; Tue, 1 Jun 2021 14:36:14 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by ash.osuosl.org (Postfix) with ESMTP id 9A6131BF577 for ; Tue, 1 Jun 2021 14:34:44 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 96AC44049D for ; Tue, 1 Jun 2021 14:34:44 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Authentication-Results: smtp4.osuosl.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 0ERzQPBnP5dH for ; Tue, 1 Jun 2021 14:34:43 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.8.0 Received: from mail-ed1-x535.google.com (mail-ed1-x535.google.com [IPv6:2a00:1450:4864:20::535]) by smtp4.osuosl.org (Postfix) with ESMTPS id AEB6040472 for ; Tue, 1 Jun 2021 14:34:43 +0000 (UTC) Received: by mail-ed1-x535.google.com with SMTP id cb9so5742051edb.1 for ; Tue, 01 Jun 2021 07:34:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=DnXdvsaWJVpURiaEHuow2ZERxu8f/Vv/epqfHhLU7Tc=; b=a/y9Z0Yr3rkefLhNFZXbGHqkYE6GO/xL9WMDvwRMt+JmUxOQUz5jys/hWi06BwJ5q4 0NgCkXELJ32MLAvsokKR5c3qkLy8Brrpzbzz22f/56Af8fHHbPR8Nk0L9DaZ/ZAPejzK 3O9UHKMBU1IIzZeoDLeK7XVo1vhwvy4B7rt/mVpn4iSyTz6qXV0Q00ZoPoNRILRd46TL 1bjWYoHF2PXTI4VcXyOtwlVkGTJ0wWEeoW4clXxoknFifJ0LZGM1s7Y4JJ+ngRYQT4lz IXtX2ViNxFTcLaOWQGfWAuB+zkAOwZsLYP38Yam/1PIL1fcJgXQS+//MFzPC/o8sTA3o Q7IQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=DnXdvsaWJVpURiaEHuow2ZERxu8f/Vv/epqfHhLU7Tc=; b=RLwSyd9dMKkeqeT35G10bcP7tvd23231Yr7E8GlVjzLzGTxDsVMlo5yIP8/aSzkF3Y IHYU5ZkMCP813fDApVwJilP3EB4p2ZCTVSLZ3qlyo4luKji38ubrWwzeYToTrSb6tbOp PV304YDtoa/U495LfcJiGNne2IO7VS2m+az2nhyA4K7G9ywxAagUgT/yEqrh3uiginTV rPfJng6rqyeGAdDWO15Jq1nF//blUsJA1Wt1atkEVolzhPdZB4DWyCwaDmiE30YpXN8p vEw2EP0pHt6WlawN7RyIw01fVCzbMxkkXzTOner0HacSNwuVvEmUkRI+IlK+CCZgy4UP 9hug== X-Gm-Message-State: AOAM530ABJ/DgN/5HCJcglTrXp9SXh8WVNwgkYZPal07I3BZHG2vR55j Ew6mh2ZxLHCM3GiiwVO7ZqDjcKGEfVEtRkZv X-Google-Smtp-Source: ABdhPJx3bsCpxLs0VnQxk4s2LHox+y4XTCPRymHsqGkCG6G2k1xpFvQGAuNSvEgX2f3D6s+hdKDvcA== X-Received: by 2002:a05:6402:885:: with SMTP id e5mr777164edy.248.1622558082029; Tue, 01 Jun 2021 07:34:42 -0700 (PDT) Received: from localhost (ptr-5gw9txf6g5tndjqqqz.18120a2.ip6.access.telenet.be. [2a02:1810:510:3800:1b15:18e4:57d1:eb]) by smtp.gmail.com with ESMTPSA id j22sm7502859ejt.11.2021.06.01.07.34.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Jun 2021 07:34:41 -0700 (PDT) From: Thomas De Schampheleire To: buildroot@buildroot.org Date: Tue, 1 Jun 2021 16:34:13 +0200 Message-Id: <20210601143422.25064-9-patrickdepinguin@gmail.com> X-Mailer: git-send-email 2.26.3 In-Reply-To: <20210601143422.25064-1-patrickdepinguin@gmail.com> References: <20210601143422.25064-1-patrickdepinguin@gmail.com> MIME-Version: 1.0 Subject: [Buildroot] [PATCHv4 08/16] package/oracle-mysql: use BR2_ENABLE_RUNTIME_DEBUG iso BR2_ENABLE_DEBUG X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas De Schampheleire Errors-To: buildroot-bounces@busybox.net Sender: "buildroot" From: Thomas De Schampheleire BR2_ENABLE_DEBUG should just steer the availability of debug symbols and should have no negative effect on performance. Introduction of 'assert' statements, 'debug'-type builds with additional logging, etc. should be steered by BR2_ENABLE_RUNTIME_DEBUG instead. Signed-off-by: Thomas De Schampheleire Acked-by: Arnout Vandecappelle (Essensium/Mind) --- package/oracle-mysql/oracle-mysql.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package/oracle-mysql/oracle-mysql.mk b/package/oracle-mysql/oracle-mysql.mk index ccfa40cfb1..e7d6354ed8 100644 --- a/package/oracle-mysql/oracle-mysql.mk +++ b/package/oracle-mysql/oracle-mysql.mk @@ -95,7 +95,7 @@ ORACLE_MYSQL_CONF_OPTS += \ # Debugging is only available for the server, so no need for # this if-block outside of the server if-block -ifeq ($(BR2_ENABLE_DEBUG),y) +ifeq ($(BR2_ENABLE_RUNTIME_DEBUG),y) ORACLE_MYSQL_CONF_OPTS += --with-debug=full else ORACLE_MYSQL_CONF_OPTS += --without-debug From patchwork Tue Jun 1 14:34:14 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas De Schampheleire X-Patchwork-Id: 1486014 Return-Path: X-Original-To: incoming-buildroot@patchwork.ozlabs.org Delivered-To: patchwork-incoming-buildroot@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=busybox.net (client-ip=140.211.166.137; helo=smtp4.osuosl.org; envelope-from=buildroot-bounces@busybox.net; receiver=) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=VQUQ/rAt; dkim-atps=neutral Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4FvZV65xvKz9sj1 for ; Wed, 2 Jun 2021 00:36:30 +1000 (AEST) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id C7231402B9; Tue, 1 Jun 2021 14:36:28 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id gVAYeGjMKZjs; Tue, 1 Jun 2021 14:36:27 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp4.osuosl.org (Postfix) with ESMTP id CFF794049D; Tue, 1 Jun 2021 14:36:26 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id 4BACD1BF577 for ; Tue, 1 Jun 2021 14:34:46 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 3AED78392C for ; Tue, 1 Jun 2021 14:34:46 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Authentication-Results: smtp1.osuosl.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id sjfpZiQGg91s for ; Tue, 1 Jun 2021 14:34:45 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.8.0 Received: from mail-ed1-x533.google.com (mail-ed1-x533.google.com [IPv6:2a00:1450:4864:20::533]) by smtp1.osuosl.org (Postfix) with ESMTPS id 859A383653 for ; Tue, 1 Jun 2021 14:34:45 +0000 (UTC) Received: by mail-ed1-x533.google.com with SMTP id df21so17639079edb.3 for ; Tue, 01 Jun 2021 07:34:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=v2E8PzUGiN24wMARZuIsbZqrcQogf6KZyWxAMu8Qolc=; b=VQUQ/rAt5F6Ww+oyMkJ79JF2N1wG43xgGaDLp+PJHNUy29jX5oWkJ63mOclIAYkhCZ nbW/vbGCI0DgGATufyASJ5XgzTNRe4fwI4ToSkOPrVuKxSfU9a1ydl6UYPZURj+l74bd 99pZn0T5sGaMBGWp+aw2EryyPqJlu+GHACNIB977wcHSE4BLRIcFY5I6wyYQ69aB26NP 3326mk87QpJKA6Gyut+vya1WMt4KwS9xVxLsxo+sOJEjnqxdpVivVikwt6oqMVUhYh1S eSQOIDGlLOqqMRMZbGYK3ro57m4gmhMZ7LmYDa96IOcybdEs4ClFSH8L1dQEggeE5ypP USkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=v2E8PzUGiN24wMARZuIsbZqrcQogf6KZyWxAMu8Qolc=; b=E3mEm0l525hj/uXsjDCy9QRxU/M/APF0MDRkrSLJU0BVlOKXtyUoLVq3878gi6cS2q gL8a7AzNu11DYncHeyO1ihr3zV+Mf5BQIagmvrwslvuaSAUXI3mYJcT9ndHiwvUZaib2 xYwOdD3vNKkvmX62wIJNs8Esgj1qtNwww4UfBgFnf+D1rR6oMoSjZ331VMkDygmLJIdD chKykSm44FkODoAR5V5Aopb21HfT/tF/+ITPk1daHvArqjUkqt1AF3tDSPNX5m74Utyz uLo5g1SxYG6BE+EM+4fv8Yg9reh+rNsTsE2XZ/v9GX9yMo9ich5JmdWPvLwzUI4gOJnH zu6Q== X-Gm-Message-State: AOAM531oGFVfmfP9Hgi2b+5DrRkCBa4YSRlxKq2hJVdVOLOYcAUvCDr0 mKvmWLsLFGeUg5lZH0bTJvY5sDkxD2TxOPOD X-Google-Smtp-Source: ABdhPJwpPi4sKhSrMe/PnupNBETsAtUpL4j+ZAy7w9VM6HKLTNWtZ2A0td84187pGTzv1eOm+thHjA== X-Received: by 2002:aa7:dc12:: with SMTP id b18mr32600771edu.52.1622558083800; Tue, 01 Jun 2021 07:34:43 -0700 (PDT) Received: from localhost (ptr-5gw9txf6g5tndjqqqz.18120a2.ip6.access.telenet.be. [2a02:1810:510:3800:1b15:18e4:57d1:eb]) by smtp.gmail.com with ESMTPSA id b24sm2500065eje.71.2021.06.01.07.34.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Jun 2021 07:34:43 -0700 (PDT) From: Thomas De Schampheleire To: buildroot@buildroot.org Date: Tue, 1 Jun 2021 16:34:14 +0200 Message-Id: <20210601143422.25064-10-patrickdepinguin@gmail.com> X-Mailer: git-send-email 2.26.3 In-Reply-To: <20210601143422.25064-1-patrickdepinguin@gmail.com> References: <20210601143422.25064-1-patrickdepinguin@gmail.com> MIME-Version: 1.0 Subject: [Buildroot] [PATCHv4 09/16] package/qt5: use BR2_ENABLE_RUNTIME_DEBUG iso BR2_ENABLE_DEBUG X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Seiderer , Julien Corjon , Thomas De Schampheleire Errors-To: buildroot-bounces@busybox.net Sender: "buildroot" From: Thomas De Schampheleire BR2_ENABLE_DEBUG should just steer the availability of debug symbols and should have no negative effect on performance. Introduction of 'assert' statements, 'debug'-type builds with additional logging, etc. should be steered by BR2_ENABLE_RUNTIME_DEBUG instead. Signed-off-by: Thomas De Schampheleire Acked-by: Arnout Vandecappelle (Essensium/Mind) --- package/qt5/qt5base/qt5base.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package/qt5/qt5base/qt5base.mk b/package/qt5/qt5base/qt5base.mk index 84e9fa4edb..8b55aa3098 100644 --- a/package/qt5/qt5base/qt5base.mk +++ b/package/qt5/qt5base/qt5base.mk @@ -86,7 +86,7 @@ else QT5BASE_CONFIGURE_OPTS += -no-gbm endif -ifeq ($(BR2_ENABLE_DEBUG),y) +ifeq ($(BR2_ENABLE_RUNTIME_DEBUG),y) QT5BASE_CONFIGURE_OPTS += -debug else QT5BASE_CONFIGURE_OPTS += -release From patchwork Tue Jun 1 14:34:15 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas De Schampheleire X-Patchwork-Id: 1486015 Return-Path: X-Original-To: incoming-buildroot@patchwork.ozlabs.org Delivered-To: patchwork-incoming-buildroot@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=busybox.net (client-ip=140.211.166.138; helo=smtp1.osuosl.org; envelope-from=buildroot-bounces@busybox.net; receiver=) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=jDjHmYYL; dkim-atps=neutral Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4FvZVM1vMCz9sj1 for ; Wed, 2 Jun 2021 00:36:43 +1000 (AEST) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 9E5CA83CED; Tue, 1 Jun 2021 14:36:41 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id fCASuy1U9nKV; Tue, 1 Jun 2021 14:36:40 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp1.osuosl.org (Postfix) with ESMTP id EE10A83CDD; Tue, 1 Jun 2021 14:36:39 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by ash.osuosl.org (Postfix) with ESMTP id 9AAD21BF577 for ; Tue, 1 Jun 2021 14:34:48 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 9749E60869 for ; Tue, 1 Jun 2021 14:34:48 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Authentication-Results: smtp3.osuosl.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id v0FUol_WDENl for ; Tue, 1 Jun 2021 14:34:48 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.8.0 Received: from mail-ed1-x531.google.com (mail-ed1-x531.google.com [IPv6:2a00:1450:4864:20::531]) by smtp3.osuosl.org (Postfix) with ESMTPS id DF5E360793 for ; Tue, 1 Jun 2021 14:34:47 +0000 (UTC) Received: by mail-ed1-x531.google.com with SMTP id r11so17585163edt.13 for ; Tue, 01 Jun 2021 07:34:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=eYHlxjarjqTCr1qyblnF5JgA/Os8TaGMVNhonwpgLNI=; b=jDjHmYYLpsqsr5hvKMA+m4wrcY3co3b2NsYBwrdhHJaqW/w3eWbKE2tF7zgDFImnEQ gPm8UXt/A+Q1gk5e735RM4l8St9EiaxiwRiimv730P3x/GgGwi5Me1BS64pfuM8E9IxS aXCwPD3k1LB1njd8UPoS/P4rCZ6c85eo3qkBv6ALdINyZc3xPNhzw8ZcZcnYI6MECGy/ oqiEYIBeGrTdkdWNbtbcNnjEggfsTi/sx5GNqOK2AvZDWaz4HN0kng98mSQ+4d5q3Rqk Pmtl336SJYt1rdLIHdnILHdB33cQfgmZqIB3QuTtbJpaZ98aWg4Grr5P8OAzE1Q3xnZy hjzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=eYHlxjarjqTCr1qyblnF5JgA/Os8TaGMVNhonwpgLNI=; b=pLaKcMbrdwBieVK5qILmxprw8XJ8fiY8P88RqGnrTUxFaog+S3j3pFKtj1E79jN706 iscRswPwGanCpD82rN9XJPE3ENHsrlnA97lyxTSXg+MYdSadnGWXP7F4pLfRZIfk/qN1 hwgEllmZh9M9yT/HJRp5zQQsxx6zMVKd5Ji2r6clQgRe2t4ssbuqKvTVCrmIIEqu30sF kIslXZQolMg4Iz2FYGDU5ZZTpM5jlgB24fCOgbd5Z77x5PdZtRn4J196X87Egn28x5wI tDarJQ9Yh+06keDf7uxVhLvZiq/6Q+lFW+6rt0dkd6tCVJp6voJm9u572rv0lwi0GUAs PjqQ== X-Gm-Message-State: AOAM5328Kf7daSW7esDCXiaFOmwnIE40EfoLoHlKMtogiO8vmWrNvugZ Gqo9hwIXP5ww7LYRWXWgBDsD0nRCJmAKKPNd X-Google-Smtp-Source: ABdhPJxpg7bvQLL3i6mSZNp9wR4iLI1xQR72YK1m6iFLHRmSgf+O2AvvYvDRONic7cbnucPTm6QB+w== X-Received: by 2002:a05:6402:344:: with SMTP id r4mr14426702edw.226.1622558085974; Tue, 01 Jun 2021 07:34:45 -0700 (PDT) Received: from localhost (ptr-5gw9txf6g5tndjqqqz.18120a2.ip6.access.telenet.be. [2a02:1810:510:3800:1b15:18e4:57d1:eb]) by smtp.gmail.com with ESMTPSA id gv11sm2151999ejb.13.2021.06.01.07.34.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Jun 2021 07:34:45 -0700 (PDT) From: Thomas De Schampheleire To: buildroot@buildroot.org Date: Tue, 1 Jun 2021 16:34:15 +0200 Message-Id: <20210601143422.25064-11-patrickdepinguin@gmail.com> X-Mailer: git-send-email 2.26.3 In-Reply-To: <20210601143422.25064-1-patrickdepinguin@gmail.com> References: <20210601143422.25064-1-patrickdepinguin@gmail.com> MIME-Version: 1.0 Subject: [Buildroot] [PATCHv4 10/16] package/ripgrep: use BR2_ENABLE_RUNTIME_DEBUG iso BR2_ENABLE_DEBUG X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sam Voss , Thomas De Schampheleire Errors-To: buildroot-bounces@busybox.net Sender: "buildroot" From: Thomas De Schampheleire BR2_ENABLE_DEBUG should just steer the availability of debug symbols and should have no negative effect on performance. Introduction of 'assert' statements, 'debug'-type builds with additional logging, etc. should be steered by BR2_ENABLE_RUNTIME_DEBUG instead. Signed-off-by: Thomas De Schampheleire Acked-by: Arnout Vandecappelle (Essensium/Mind) --- package/ripgrep/ripgrep.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package/ripgrep/ripgrep.mk b/package/ripgrep/ripgrep.mk index 9dd8d58de1..c3c12fd185 100644 --- a/package/ripgrep/ripgrep.mk +++ b/package/ripgrep/ripgrep.mk @@ -18,7 +18,7 @@ RIPGREP_CARGO_OPTS = \ --target=$(RUSTC_TARGET_NAME) \ --manifest-path=$(@D)/Cargo.toml -ifeq ($(BR2_ENABLE_DEBUG),y) +ifeq ($(BR2_ENABLE_RUNTIME_DEBUG),y) RIPGREP_CARGO_BIN_SUBDIR = debug else RIPGREP_CARGO_OPTS += --release From patchwork Tue Jun 1 14:34:16 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas De Schampheleire X-Patchwork-Id: 1486016 Return-Path: X-Original-To: incoming-buildroot@patchwork.ozlabs.org Delivered-To: patchwork-incoming-buildroot@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=busybox.net (client-ip=2605:bc80:3010::138; helo=smtp1.osuosl.org; envelope-from=buildroot-bounces@busybox.net; receiver=) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=JWLMBj7O; dkim-atps=neutral Received: from smtp1.osuosl.org (smtp1.osuosl.org [IPv6:2605:bc80:3010::138]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4FvZVc3Mgfz9sj1 for ; Wed, 2 Jun 2021 00:36:56 +1000 (AEST) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 4189983D04; Tue, 1 Jun 2021 14:36:54 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id zrriwx4a8t6x; Tue, 1 Jun 2021 14:36:53 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp1.osuosl.org (Postfix) with ESMTP id 893CA83D00; Tue, 1 Jun 2021 14:36:52 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id 425B01BF577 for ; Tue, 1 Jun 2021 14:34:50 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 3F515839E6 for ; Tue, 1 Jun 2021 14:34:50 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id SfF1CAsw3Fmd for ; Tue, 1 Jun 2021 14:34:49 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.8.0 Received: from mail-ej1-x62f.google.com (mail-ej1-x62f.google.com [IPv6:2a00:1450:4864:20::62f]) by smtp1.osuosl.org (Postfix) with ESMTPS id 8891E83653 for ; Tue, 1 Jun 2021 14:34:49 +0000 (UTC) Received: by mail-ej1-x62f.google.com with SMTP id g8so13636518ejx.1 for ; Tue, 01 Jun 2021 07:34:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=tecdzflxL6ZWF+W+2Lvauu8U2z2+o5tCnG5jrbvYdL0=; b=JWLMBj7O5kRVZdcfk44jPMtmxAij7zhiv4C6dNMxkCchY2HYihNIEU2m9z2KwC4Vrz Y7lQNN3xx15279C1CVvKFSEjL3QffZYSASTszv7nVhnYSzsYPIVBDYoRTTINIwNNIaff l6wtLVzzqiUDxg3u240p07RrLOw/jPFzEmqc1Ecb7xQOfksKa8lhJF7EjBnm+CkKxmXe R5odd9ADk3w3TTBfsYvIG8tbcAJWpkQ/1/y/MNz/3MNc8kjgUOZaZf3ZQvUAqVdZGSnP 6hi3Ov/H00bCuXvTuQyxQoE0WAjN4xQq9Wy22sfc/+5x0Ld1c8b4m1AF1TxanpuldGHu Bigg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=tecdzflxL6ZWF+W+2Lvauu8U2z2+o5tCnG5jrbvYdL0=; b=rB/AuYy52nFj/vFKn6yHgSK4qluX4S7JHd2e1wjt7SVTQxsNqWPxH5K+p/OOC3z6ha /bK09Y8cgJVtMj1+VRyB4eATRinJDF3zq1mZfTIdOH1qq2mS+ieCNp49vK/GmclfaYKH 2zc8fD0lKYIRTZhOSwmChooHnnzF1wVgsdMF76+mDBL57JIjbfFSi9IXoLSrUOxj2lpj fv+XoJigQDNMfx6kvU1SWjNd1KkkZ51cLjpRPckb5L+Pa/eC0aG24sZ3POu1Z97Hs/b9 Mbcaaf2OJvMuNEON+dGS/a4bJRu49a4yGQxTv1e7L/Y/GO1PhMuazNIZA5tTxI2ohATi 6EbA== X-Gm-Message-State: AOAM530v4+yE0dWGsmWQmhz3LMeZ/PIoq6xnRYeq+CoHbanudxdMGoDo HMqK+09cOdpMviViN+uJw7NcJjtqwjKAXJpc X-Google-Smtp-Source: ABdhPJxvn5DxwGCqBGMxJpFyAkw79GBw7dxS/6npYu/euXOQ7U8hw/s7oimBcmStzq1QMsHzsJ3V6w== X-Received: by 2002:a17:907:1117:: with SMTP id qu23mr21304942ejb.71.1622558087831; Tue, 01 Jun 2021 07:34:47 -0700 (PDT) Received: from localhost (ptr-5gw9txf6g5tndjqqqz.18120a2.ip6.access.telenet.be. [2a02:1810:510:3800:1b15:18e4:57d1:eb]) by smtp.gmail.com with ESMTPSA id a7sm8393633edr.15.2021.06.01.07.34.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Jun 2021 07:34:47 -0700 (PDT) From: Thomas De Schampheleire To: buildroot@buildroot.org Date: Tue, 1 Jun 2021 16:34:16 +0200 Message-Id: <20210601143422.25064-12-patrickdepinguin@gmail.com> X-Mailer: git-send-email 2.26.3 In-Reply-To: <20210601143422.25064-1-patrickdepinguin@gmail.com> References: <20210601143422.25064-1-patrickdepinguin@gmail.com> MIME-Version: 1.0 Subject: [Buildroot] [PATCHv4 11/16] package/sofia-sip: correct passing of '--enable-ndebug' X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Gregory Dymarek , Thomas De Schampheleire Errors-To: buildroot-bounces@busybox.net Sender: "buildroot" From: Thomas De Schampheleire The preprocessor option NDEBUG, triggered by the configure option '--enable-ndebug', should be read as 'no-debug'. When NDEBUG is set, asserts are _disabled_. The sofia-sip package had inverted logic, and set '--enable-ndebug' when BR2_ENABLE_DEBUG was enabled, while it should be the other way around. Reported-by: Arnout Vandecappelle (Essensium/Mind) Signed-off-by: Thomas De Schampheleire --- v4: new patch; Even though the next patch will remove this block altogether, I keep this correction as a separate patch to make it clear that the original code was incorrect, and allow potential backporting to other branches. package/sofia-sip/sofia-sip.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package/sofia-sip/sofia-sip.mk b/package/sofia-sip/sofia-sip.mk index 5c383400ff..274c72fce8 100644 --- a/package/sofia-sip/sofia-sip.mk +++ b/package/sofia-sip/sofia-sip.mk @@ -30,7 +30,7 @@ SOFIA_SIP_CONF_OPTS += \ --without-openssl endif -ifeq ($(BR2_ENABLE_DEBUG),y) +ifeq ($(BR2_ENABLE_DEBUG),) SOFIA_SIP_CONF_OPTS += --enable-ndebug endif From patchwork Tue Jun 1 14:34:17 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas De Schampheleire X-Patchwork-Id: 1486017 Return-Path: X-Original-To: incoming-buildroot@patchwork.ozlabs.org Delivered-To: patchwork-incoming-buildroot@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=busybox.net (client-ip=140.211.166.133; helo=smtp2.osuosl.org; envelope-from=buildroot-bounces@busybox.net; receiver=) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=Dhgoxgk8; dkim-atps=neutral Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4FvZVr2Fqhz9srX for ; Wed, 2 Jun 2021 00:37:08 +1000 (AEST) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id BEC5540249; Tue, 1 Jun 2021 14:37:06 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Ruh9FDcZ4rAR; Tue, 1 Jun 2021 14:37:06 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp2.osuosl.org (Postfix) with ESMTP id 218C24028C; Tue, 1 Jun 2021 14:37:05 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by ash.osuosl.org (Postfix) with ESMTP id 37D061BF577 for ; Tue, 1 Jun 2021 14:34:52 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 272264028C for ; Tue, 1 Jun 2021 14:34:52 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id V3KsdQ6M29El for ; Tue, 1 Jun 2021 14:34:51 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.8.0 Received: from mail-ej1-x62c.google.com (mail-ej1-x62c.google.com [IPv6:2a00:1450:4864:20::62c]) by smtp2.osuosl.org (Postfix) with ESMTPS id 327AB40288 for ; Tue, 1 Jun 2021 14:34:51 +0000 (UTC) Received: by mail-ej1-x62c.google.com with SMTP id qq22so13804246ejb.9 for ; Tue, 01 Jun 2021 07:34:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=zobfvqb6O9PZzxkZcIxY6qmGzZxsUwXJg6k0tIsODxk=; b=Dhgoxgk8B8S4cd5sN4LwD2LTomku+JA7J9ebrpKKhqgU+Tj5NdzhAOWXWwpk0T5dta 7cnH1YKGL1MrN+BmHtyiKFMN5cWKtHf/uzPOa8HAWx+Ygs6giCCkgOPfO+Fg0ePC6wce mcObPjz5WRGY3ni0fIuwZNObPWa5y5XkraKyU6uamMTHGZhXBNYXXFwKNoSbDGM4RvR8 jbGLjolRgrwvUppGJjZcGvMLjU4QdRK2RIICgGdqAfhbuGuWex6HDhfWAzLW124wZyCQ AR3To8vv6sTmGQG/zovM6LDR1CkI9BM3YduY5L2Nm/U6cEWzimxyiWboNIw5Lirrfxxv n4dg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=zobfvqb6O9PZzxkZcIxY6qmGzZxsUwXJg6k0tIsODxk=; b=UUzU2+chFD3BEi3ohu0lzldL3QIFrevp3QCnmArQxDxQfVaBYcHMw8NyOfJPzy7Ckf Ok6yVzawQ+1keZ6XFQ55k24P+gPz0nm/xCa8u4I1ETBObNNPeyAX9fJuIlTQcdKbojxM 9sisWmlPg6/XmOETzjjrXM7DmZa5bWlmwC2ys7dIV91z9TGMUk2DpEAvr4uP7okSeu/x zDLDfOJmlSUHIbeiWyf8JGSOn26csTuawmTTwCe9NX0R+C8vZVGyPTg0inE9eRU1rCML QYifgXX0GLUXrFentdSxaitvmLGrkERCrJpPSk4oytkFlRnEDbPj+0fDr40CvkjMqYBN Pqrw== X-Gm-Message-State: AOAM531dsnKPwg6hfQ3pnBfJH9HljSto88TpgwNOApLILyrrN3vhGcY8 XAqAt1rlMZo9XjFEmY+uH/eNo+HRMs+DsG2Y X-Google-Smtp-Source: ABdhPJzN3RAT+163FrvVjh7mNwY5+63HCCfOA53n4wXeOrGkhDyE6KcSKlP2tXk+wM6KBHSVZ7fb5g== X-Received: by 2002:a17:906:2bc5:: with SMTP id n5mr29675804ejg.531.1622558089434; Tue, 01 Jun 2021 07:34:49 -0700 (PDT) Received: from localhost (ptr-5gw9txf6g5tndjqqqz.18120a2.ip6.access.telenet.be. [2a02:1810:510:3800:1b15:18e4:57d1:eb]) by smtp.gmail.com with ESMTPSA id n15sm1392384eds.28.2021.06.01.07.34.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Jun 2021 07:34:49 -0700 (PDT) From: Thomas De Schampheleire To: buildroot@buildroot.org Date: Tue, 1 Jun 2021 16:34:17 +0200 Message-Id: <20210601143422.25064-13-patrickdepinguin@gmail.com> X-Mailer: git-send-email 2.26.3 In-Reply-To: <20210601143422.25064-1-patrickdepinguin@gmail.com> References: <20210601143422.25064-1-patrickdepinguin@gmail.com> MIME-Version: 1.0 Subject: [Buildroot] [PATCHv4 12/16] package/sofia-sip: don't set 'NDEBUG' explicitly X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Gregory Dymarek , Thomas De Schampheleire Errors-To: buildroot-bounces@busybox.net Sender: "buildroot" From: Thomas De Schampheleire BR2_ENABLE_DEBUG should just steer the availability of debug symbols and should have no negative effect on performance. Introduction of 'assert' statements, 'debug'-type builds with additional logging, etc. should be steered by BR2_ENABLE_RUNTIME_DEBUG instead. The sofia-sip package was setting '--enable-ndebug' conditionally based on BR2_ENABLE_DEBUG, and this would have to be updated to be based on BR2_ENABLE_RUNTIME_DEBUG. However, the sofia-sip option '--enable-ndebug' only sets the 'NDEBUG' preprocessor macro, and the core package infrastructure already sets this macro correctly based on BR2_ENABLE_RUNTIME_DEBUG. This means that the explicit '--enable-ndebug' flag can be removed. Suggested-by: Arnout Vandecappelle (Essensium/Mind) Signed-off-by: Thomas De Schampheleire --- package/sofia-sip/sofia-sip.mk | 4 ---- 1 file changed, 4 deletions(-) diff --git a/package/sofia-sip/sofia-sip.mk b/package/sofia-sip/sofia-sip.mk index 274c72fce8..fb565637eb 100644 --- a/package/sofia-sip/sofia-sip.mk +++ b/package/sofia-sip/sofia-sip.mk @@ -30,8 +30,4 @@ SOFIA_SIP_CONF_OPTS += \ --without-openssl endif -ifeq ($(BR2_ENABLE_DEBUG),) -SOFIA_SIP_CONF_OPTS += --enable-ndebug -endif - $(eval $(autotools-package)) From patchwork Tue Jun 1 14:34:18 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas De Schampheleire X-Patchwork-Id: 1486018 Return-Path: X-Original-To: incoming-buildroot@patchwork.ozlabs.org Delivered-To: patchwork-incoming-buildroot@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=busybox.net (client-ip=140.211.166.133; helo=smtp2.osuosl.org; envelope-from=buildroot-bounces@busybox.net; receiver=) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=QoNsNUZN; dkim-atps=neutral Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4FvZW52hmSz9srX for ; Wed, 2 Jun 2021 00:37:21 +1000 (AEST) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id B248940443; Tue, 1 Jun 2021 14:37:19 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id egjrOUpY_EPv; Tue, 1 Jun 2021 14:37:19 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp2.osuosl.org (Postfix) with ESMTP id 1085A4040D; Tue, 1 Jun 2021 14:37:18 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id 9DFDD1BF577 for ; Tue, 1 Jun 2021 14:34:53 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 9B03283C69 for ; Tue, 1 Jun 2021 14:34:53 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Authentication-Results: smtp1.osuosl.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 0fmYbuIf_LB2 for ; Tue, 1 Jun 2021 14:34:53 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.8.0 Received: from mail-ej1-x62c.google.com (mail-ej1-x62c.google.com [IPv6:2a00:1450:4864:20::62c]) by smtp1.osuosl.org (Postfix) with ESMTPS id CFFBF83C37 for ; Tue, 1 Jun 2021 14:34:52 +0000 (UTC) Received: by mail-ej1-x62c.google.com with SMTP id t15so9071776eju.3 for ; Tue, 01 Jun 2021 07:34:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=TMHyNJBDmnU55A0stuuXdVFzKU7QdiisdEVQlap7UvM=; b=QoNsNUZNJ6amVgpWNzjrIylAA20+YChP8rZ5RH5YncQ5n4Wl0robEBGVx4pb0LaSM7 tBBh39fsUl28iaOE3MSH5v+a2UyQG4vl2GKZUAVWeslJAO6L2L8LbJEXriUq4sGxyPhS n9OLtPVWwxF1jOEvzQ9WF/6dmb6N0pGKo8HlQGB8SHycQWYmBH2VJzO+BbdnAAdIXWb7 dVpQEgu7jvsQiW6GRpuSaGWPxk5cih+X9grjJ9GXt0K2SuphojCUcuwMzfnW1mP/hQ3L Bgj3Fe98hEHftNMPp03hF1nGjjhoL8QHR3tNqUYcX7ZlLkMFD/m32UdCaBV2JtdiunE3 79rQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=TMHyNJBDmnU55A0stuuXdVFzKU7QdiisdEVQlap7UvM=; b=YJiT9TL4n9919xg1xeI5IOT6AZf4zvtLGyADGKUa6yq+hIQCi+KqrdcL5CfkPUF5UJ asbdENukgRchzxMW5sF6Ak8G82GDenRK3c9Uos8bayEpjYQOrv6qCpIdCymoOF8Xcvbx 5Zcpu09+7NfQcyhkbGvtyQx7EzEp//c2LyQ/fhul5TutJGwXuP9kxMRCYIlZnassE5zc rMSFhGdS+v3KmzKQTpwOCLDwtFpadR/Y58Epn+qz7IkdSxL0/C/YekN8H04rYknQWLrg iYyWyRfN4W4IEd86ySjPSOV0JX3y6Eo66BPsACRb00DYlSJLl1v3bxCtsLcNMzMKInLM FiRA== X-Gm-Message-State: AOAM5323glGilbLZDnYfVlwGDRakQ/4JowMEl1M7G5ZXhBKD8FY20MQa czxWBUK6QiYNN0UEI2U/Tg+RnDoXUxUTv4qd X-Google-Smtp-Source: ABdhPJyxL1sOUoyaNnlUal2biS/IjkwQkqmftGja5c5DkSmerL0H0LNhrayChkbMUAHKY45w5JTTTA== X-Received: by 2002:a17:906:c0c9:: with SMTP id bn9mr29974897ejb.7.1622558091146; Tue, 01 Jun 2021 07:34:51 -0700 (PDT) Received: from localhost (ptr-5gw9txf6g5tndjqqqz.18120a2.ip6.access.telenet.be. [2a02:1810:510:3800:1b15:18e4:57d1:eb]) by smtp.gmail.com with ESMTPSA id p5sm7276145ejm.115.2021.06.01.07.34.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Jun 2021 07:34:50 -0700 (PDT) From: Thomas De Schampheleire To: buildroot@buildroot.org Date: Tue, 1 Jun 2021 16:34:18 +0200 Message-Id: <20210601143422.25064-14-patrickdepinguin@gmail.com> X-Mailer: git-send-email 2.26.3 In-Reply-To: <20210601143422.25064-1-patrickdepinguin@gmail.com> References: <20210601143422.25064-1-patrickdepinguin@gmail.com> MIME-Version: 1.0 Subject: [Buildroot] [PATCHv4 13/16] package/zmqpp: don't set CONFIG=debug X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Simon Dawson , Thomas De Schampheleire Errors-To: buildroot-bounces@busybox.net Sender: "buildroot" From: Thomas De Schampheleire Below are the flags set by zmqpp depending on the specified CONFIG variable: CONFIG_FLAGS = ifeq ($(CONFIG),debug) CONFIG_FLAGS = -g -fno-inline -ftemplate-depth-1000 endif ifeq ($(CONFIG),valgrind) CONFIG_FLAGS = -g -O1 -DNO_DEBUG_LOG -DNO_TRACE_LOG endif ifeq ($(CONFIG),max) CONFIG_FLAGS = -O3 -funroll-loops -ffast-math -finline-functions \ -fomit-frame-pointer -DNDEBUG endif ifneq (,$(findstring $(CONFIG),release loadtest)) CONFIG_FLAGS = -O3 -funroll-loops -ffast-math -finline-functions \ -fomit-frame-pointer -DNO_DEBUG_LOG -DNO_TRACE_LOG -DNDEBUG endif For the flags added with CONFIG=debug, '-g' is to be steered by the core infrastructure (could be '-g1', '-g2' etc.) The flag '-ftemplate-depth' is only a protection against incorrect code and not really needed in Buildroot context. Finally, the flag '-fno-inline' may be useful when really stepping through zmqpp code, but is a very specific use case. With the above in mind, not passing CONFIG=debug may actually be better. Use 'CONFIG=buildroot' instead. Note that we don't pass an empty 'CONFIG' to avoid confusion, as this variable is also passed through to the variable BUILD_ENV, even though it is currently unused. Signed-off-by: Thomas De Schampheleire --- package/zmqpp/zmqpp.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package/zmqpp/zmqpp.mk b/package/zmqpp/zmqpp.mk index 3cd19d644a..c629f14920 100644 --- a/package/zmqpp/zmqpp.mk +++ b/package/zmqpp/zmqpp.mk @@ -19,7 +19,7 @@ ZMQPP_LDFLAGS = $(TARGET_LDFLAGS) -lpthread # -ffast-math -finline-functions -fomit-frame-pointer are disabled, # so only set CONFIG for the non-affected cases. ifneq ($(BR2_or1k):$(BR2_TOOLCHAIN_GCC_AT_LEAST_6),y:) -ZMQPP_CONFIG = $(if $(BR2_ENABLE_DEBUG),debug,release) +ZMQPP_CONFIG = $(if $(BR2_ENABLE_DEBUG),buildroot,release) endif ifeq ($(BR2_TOOLCHAIN_HAS_LIBATOMIC),y) From patchwork Tue Jun 1 14:34:19 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas De Schampheleire X-Patchwork-Id: 1486019 Return-Path: X-Original-To: incoming-buildroot@patchwork.ozlabs.org Delivered-To: patchwork-incoming-buildroot@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=busybox.net (client-ip=140.211.166.138; helo=smtp1.osuosl.org; envelope-from=buildroot-bounces@busybox.net; receiver=) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=EGiBAofv; dkim-atps=neutral Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4FvZWK6ZL4z9sj1 for ; Wed, 2 Jun 2021 00:37:33 +1000 (AEST) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 6B4A583CFA; Tue, 1 Jun 2021 14:37:32 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 86qcpW4p4G_k; Tue, 1 Jun 2021 14:37:31 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp1.osuosl.org (Postfix) with ESMTP id D985083CDD; Tue, 1 Jun 2021 14:37:30 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by ash.osuosl.org (Postfix) with ESMTP id A98091BF577 for ; Tue, 1 Jun 2021 14:34:55 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 993AF402A0 for ; Tue, 1 Jun 2021 14:34:55 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Authentication-Results: smtp2.osuosl.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id JZhQVu71ypdx for ; Tue, 1 Jun 2021 14:34:54 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.8.0 Received: from mail-ej1-x635.google.com (mail-ej1-x635.google.com [IPv6:2a00:1450:4864:20::635]) by smtp2.osuosl.org (Postfix) with ESMTPS id 934394028C for ; Tue, 1 Jun 2021 14:34:54 +0000 (UTC) Received: by mail-ej1-x635.google.com with SMTP id c10so834317eja.11 for ; Tue, 01 Jun 2021 07:34:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=axcQMzzogg/iX6/HnOTRXebd84+iqOuXJMyO+YRmQlM=; b=EGiBAofv1P/04KC0GGldEZQud5h25GNoc2MDyXxXfdV09MYR9ULslQlQ4YAGvI+LqW RN7ImBnst+lOgxT5OotNW8atzG8rbzIKG5519Ua1JkPgVqFcYTp00awDbSgSGBqcJDSQ kDNvfJg//wrPJsd4hvn7GJY1lX8gIfYxfqoxPhf65uH5V+wu/S3Gh3DCAD80SANW+Paa FXIQb6aCrCWzZOipGFLHM1+92w6cVZOlcZP/2CGxmUbrQ3fAdeuazuF0AKq1+xNRsR10 l7w6tSzfF/wtf5Yye6ssQ9MBsicVpepReG9jSlXP0v48O1nTKpgOa//W5nqheNz78y+Y 7n0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=axcQMzzogg/iX6/HnOTRXebd84+iqOuXJMyO+YRmQlM=; b=nQY82Mu3FHhbIzneAyUQfxjlqlg3HzH/3Us8tqEIddhGtLsig07lmo+POE1v/ohkh2 ultDtug9vG6L2PVO/Fe3qdJu3qsn7T4Bfy2+vsdiE3oxw/414JQ1nQvkXXiYuUu2cSs8 0JX3ofhD+wEQbQig2d4yixo4npGWadGqRrnDG819Yt5uHe/PRIR8QPm8Dl0I+ss5wQzX lLh2zM+vxrJVVx9I021nOBHf8jRDwwP9VGUdd0552N/IXV/wlGDX9a5Ea4GF0CXJi3pT PBspXJShJltNSMVN7fQU//EfUA37K+gStHrmDSOXtG0NvK9SQMDuAa7EkknQNhcVDgG6 U11Q== X-Gm-Message-State: AOAM530dUZr+cFCH9zABLK/uFQin/VXP4MqhCJILiwiYfOyIUjeLsHJG Tkbji/5ECfOok5M6RMA8BzB0+bJGgw04aZvb X-Google-Smtp-Source: ABdhPJwXOTRK3crKkQtF0wWEf6ChFjFjVJx44tyy7LQyoEcJ0x9YMl9LIAfs0c3ubRO55bpp9klACw== X-Received: by 2002:a17:907:2709:: with SMTP id w9mr15230734ejk.118.1622558092853; Tue, 01 Jun 2021 07:34:52 -0700 (PDT) Received: from localhost (ptr-5gw9txf6g5tndjqqqz.18120a2.ip6.access.telenet.be. [2a02:1810:510:3800:1b15:18e4:57d1:eb]) by smtp.gmail.com with ESMTPSA id q9sm1858976edw.51.2021.06.01.07.34.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Jun 2021 07:34:52 -0700 (PDT) From: Thomas De Schampheleire To: buildroot@buildroot.org Date: Tue, 1 Jun 2021 16:34:19 +0200 Message-Id: <20210601143422.25064-15-patrickdepinguin@gmail.com> X-Mailer: git-send-email 2.26.3 In-Reply-To: <20210601143422.25064-1-patrickdepinguin@gmail.com> References: <20210601143422.25064-1-patrickdepinguin@gmail.com> MIME-Version: 1.0 Subject: [Buildroot] [PATCHv4 14/16] package/zmqpp: use BR2_ENABLE_RUNTIME_DEBUG iso BR2_ENABLE_DEBUG X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Simon Dawson , Thomas De Schampheleire Errors-To: buildroot-bounces@busybox.net Sender: "buildroot" From: Thomas De Schampheleire BR2_ENABLE_DEBUG should just steer the availability of debug symbols and should have no negative effect on performance. Introduction of 'assert' statements, 'debug'-type builds with additional logging, etc. should be steered by BR2_ENABLE_RUNTIME_DEBUG instead. Signed-off-by: Thomas De Schampheleire --- package/zmqpp/zmqpp.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package/zmqpp/zmqpp.mk b/package/zmqpp/zmqpp.mk index c629f14920..32fabf26ef 100644 --- a/package/zmqpp/zmqpp.mk +++ b/package/zmqpp/zmqpp.mk @@ -19,7 +19,7 @@ ZMQPP_LDFLAGS = $(TARGET_LDFLAGS) -lpthread # -ffast-math -finline-functions -fomit-frame-pointer are disabled, # so only set CONFIG for the non-affected cases. ifneq ($(BR2_or1k):$(BR2_TOOLCHAIN_GCC_AT_LEAST_6),y:) -ZMQPP_CONFIG = $(if $(BR2_ENABLE_DEBUG),buildroot,release) +ZMQPP_CONFIG = $(if $(BR2_ENABLE_RUNTIME_DEBUG),buildroot,release) endif ifeq ($(BR2_TOOLCHAIN_HAS_LIBATOMIC),y) From patchwork Tue Jun 1 14:34:20 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas De Schampheleire X-Patchwork-Id: 1486020 Return-Path: X-Original-To: incoming-buildroot@patchwork.ozlabs.org Delivered-To: patchwork-incoming-buildroot@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=busybox.net (client-ip=2605:bc80:3010::133; helo=smtp2.osuosl.org; envelope-from=buildroot-bounces@busybox.net; receiver=) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=mvB+ZlM9; dkim-atps=neutral Received: from smtp2.osuosl.org (smtp2.osuosl.org [IPv6:2605:bc80:3010::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4FvZWb0lthz9t0p for ; Wed, 2 Jun 2021 00:37:46 +1000 (AEST) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 0C5C040421; Tue, 1 Jun 2021 14:37:45 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id aXqQdQJCp-Fm; Tue, 1 Jun 2021 14:37:44 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp2.osuosl.org (Postfix) with ESMTP id 48EFD4028C; Tue, 1 Jun 2021 14:37:43 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id 2362C1BF577 for ; Tue, 1 Jun 2021 14:34:57 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 1EAE983C69 for ; Tue, 1 Jun 2021 14:34:57 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Authentication-Results: smtp1.osuosl.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 9mkv-q3CEB5o for ; Tue, 1 Jun 2021 14:34:56 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.8.0 Received: from mail-ej1-x62c.google.com (mail-ej1-x62c.google.com [IPv6:2a00:1450:4864:20::62c]) by smtp1.osuosl.org (Postfix) with ESMTPS id 5E29083C37 for ; Tue, 1 Jun 2021 14:34:56 +0000 (UTC) Received: by mail-ej1-x62c.google.com with SMTP id qq22so13804768ejb.9 for ; Tue, 01 Jun 2021 07:34:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=KCNs2cYhwPVIOx+ySXRNkbeZEYymT7lRa8kJlLeSOb0=; b=mvB+ZlM9OyaxcfZstunnAHVE485u/ktPWB1lUMK/v+KXv6uewzOg00soVnWDLHJ5EH YT1F91xK1iUlOeHWBQKmOat4xMKd6iKu4dNrri6/RuXZkRX+yVuel0X9Z9gpiZHyO+W/ CttGGHSS37k7qmXaQZf/fF4feEK2+NCV9u1EdsHGf2Ez6KcIESfPlLlR888hahL7xIs1 dkOH9Hb4VUNnm2sXa5AfGV+CgH/0KDqNWVqrRSgwfBF/RYTm6i+rw92CiJycIt9F9Ymk JzDZzGhRRk9+P3ESSfLT/RnTaoMRf2HGXcqKNw3XEFpWrlesoGLEKfX8/CJzY2WgA2F6 s/Dw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=KCNs2cYhwPVIOx+ySXRNkbeZEYymT7lRa8kJlLeSOb0=; b=RhNMAg7DqTX0Xwzblrp4oDJ4FXgF1lzVktVaEHLmhiFMNPi7BykgHeH/EFDS1sPeFp MdSHj0N6cVaGlmBFPPJjLXzZAZIQobJJ/JotW2PrMpDDomdGE2cSijBNHG0RSHWgmzAm kYcHlPjqyLfCYywHINKBC2r3YMrbWrsX6y9B7zF7jOkhDiJbPx9oxBaWAotN3FOWICLK sVS5IzNg+p5eipQHn07AlXedofm7D5hr8ug0SKsAf0lZVe8iidoSIU4n+qbXrNkccFMQ 1D7397gu1zpmOfH+rlX3JkWUrZQ8LGyRFX3MXGyoupP1ZEZhc9g8QZc/QtqBTdciCaBh yeIw== X-Gm-Message-State: AOAM5338MNO1hwMun+2YdP05zLN5eVdfpECPFP2KyTrnw2/QtjzsbDpq GTLhPAo7owQfiNVAEe8SDcUHyXtVp003I+RN X-Google-Smtp-Source: ABdhPJwU9eCiBeeTHFskOJjV3ShAvbu5b1J2NHQicNnoa5LAGRUmDoH0BUHLqBlEdv6tQGtgyuBJow== X-Received: by 2002:a17:906:1d11:: with SMTP id n17mr12895634ejh.215.1622558094605; Tue, 01 Jun 2021 07:34:54 -0700 (PDT) Received: from localhost (ptr-5gw9txf6g5tndjqqqz.18120a2.ip6.access.telenet.be. [2a02:1810:510:3800:1b15:18e4:57d1:eb]) by smtp.gmail.com with ESMTPSA id p11sm8564749edt.22.2021.06.01.07.34.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Jun 2021 07:34:54 -0700 (PDT) From: Thomas De Schampheleire To: buildroot@buildroot.org Date: Tue, 1 Jun 2021 16:34:20 +0200 Message-Id: <20210601143422.25064-16-patrickdepinguin@gmail.com> X-Mailer: git-send-email 2.26.3 In-Reply-To: <20210601143422.25064-1-patrickdepinguin@gmail.com> References: <20210601143422.25064-1-patrickdepinguin@gmail.com> MIME-Version: 1.0 Subject: [Buildroot] [PATCHv4 15/16] package/pkg-meson.mk: determine 'buildtype' based on BR2_ENABLE_RUNTIME_DEBUG iso BR2_ENABLE_DEBUG X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Eric Le Bihan , Thomas De Schampheleire Errors-To: buildroot-bounces@busybox.net Sender: "buildroot" From: Thomas De Schampheleire BR2_ENABLE_DEBUG should just steer the availability of debug symbols and should have no negative effect on performance. Introduction of 'assert' statements, 'debug'-type builds with additional logging, etc. should be steered by BR2_ENABLE_RUNTIME_DEBUG instead. Signed-off-by: Thomas De Schampheleire --- package/pkg-meson.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package/pkg-meson.mk b/package/pkg-meson.mk index a57820d4d2..dafad3b1eb 100644 --- a/package/pkg-meson.mk +++ b/package/pkg-meson.mk @@ -89,7 +89,7 @@ define $(2)_CONFIGURE_CMDS --prefix=/usr \ --libdir=lib \ --default-library=$(if $(BR2_STATIC_LIBS),static,shared) \ - --buildtype=$(if $(BR2_ENABLE_DEBUG),debug,release) \ + --buildtype=$(if $(BR2_ENABLE_RUNTIME_DEBUG),debug,release) \ --cross-file=$$($$(PKG)_SRCDIR)/build/cross-compilation.conf \ -Dstrip=false \ -Dbuild.pkg_config_path=$$(HOST_DIR)/lib/pkgconfig \ From patchwork Tue Jun 1 14:34:21 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas De Schampheleire X-Patchwork-Id: 1486021 Return-Path: X-Original-To: incoming-buildroot@patchwork.ozlabs.org Delivered-To: patchwork-incoming-buildroot@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=busybox.net (client-ip=2605:bc80:3010::136; helo=smtp3.osuosl.org; envelope-from=buildroot-bounces@busybox.net; receiver=) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=WuJeWlUp; dkim-atps=neutral Received: from smtp3.osuosl.org (smtp3.osuosl.org [IPv6:2605:bc80:3010::136]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4FvZWr3JfGz9sj1 for ; Wed, 2 Jun 2021 00:38:00 +1000 (AEST) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 6A7926079E; Tue, 1 Jun 2021 14:37:57 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 3TRYdBDVl66U; Tue, 1 Jun 2021 14:37:56 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp3.osuosl.org (Postfix) with ESMTP id CC71960758; Tue, 1 Jun 2021 14:37:55 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by ash.osuosl.org (Postfix) with ESMTP id C6BF11BF577 for ; Tue, 1 Jun 2021 14:34:58 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id B61A06079E for ; Tue, 1 Jun 2021 14:34:58 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id HkOuGsOMxqmH for ; Tue, 1 Jun 2021 14:34:58 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.8.0 Received: from mail-ej1-x62b.google.com (mail-ej1-x62b.google.com [IPv6:2a00:1450:4864:20::62b]) by smtp3.osuosl.org (Postfix) with ESMTPS id 1401060758 for ; Tue, 1 Jun 2021 14:34:57 +0000 (UTC) Received: by mail-ej1-x62b.google.com with SMTP id g20so6595271ejt.0 for ; Tue, 01 Jun 2021 07:34:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=s9yh6i1thwGME7Rrt0hW7weutcN85kqkrh9bZ4/BStE=; b=WuJeWlUpoMPCRKxhiEMcDHlJ82R2eAjauBwzgeiulSIe13+nowHvQOre/iyz4q4BKW F2LnMqe/rxi+Vl03Cec+Luf4paJ2SSRI121DG9gJpnRvFwcvoyuU3M0W30Pr7yRLFFNK d5JEFlj1KZSJi8S4Fhs9TKy2w/H+rioCy/V/vbf4x8HIpprZtHOZhhNYo9EXKkryRveU GZ4GNuKjOlM9aNQIIPP7PnRogEsMGJvKUpe2Ux55X3QR8Ncr5IvaHUgPO5xemh60GZIi dgLcQuUwBqA7ERplcD1auJc0R4LE9eX9rvyUkkgA/3qw93+qjNnzZYb8tuQnIFfqggzB ijEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=s9yh6i1thwGME7Rrt0hW7weutcN85kqkrh9bZ4/BStE=; b=P3Qd8qtPF67XBSLZ9EAh29peQ66i0HVyaqn8XYBPHbXZCOEwFesVRfmybPYJE7tHy9 LwxRQlHxqeD350NnzsvqtIRFYWu7Tsm9w0pfWVjImMXp8qds6kePllng5pM61NypN0AV Db6NdcjO36JeFDMNCoZIUj8ruj0v0Jj9jN8Smc1sDDQKtyieQf0nQkWl2Ut1ytjoGjY6 PVu5xmVkNiz3Q69nja4KLh4lpKjXnI+kZAj4qgDjdRjigcF28knR2TWEcOXdgVNbx1OZ v6G17vuNb9p9JIicILawgSH563p71dwsgmPhW3vRncJ+ru3lCkUBDDyUYOE6baF3ow6G CoXg== X-Gm-Message-State: AOAM531WA4RgMBP9s0VsAfItr2syrJqGQOq1xUSdy0VwhtCuWq3g7v5O LYTWZKJAEZddzbBty4I4rKeXItfyu43kmKO1 X-Google-Smtp-Source: ABdhPJwJi5qnmaLlLKmpg1G6keNtBoPmRLu0pgTkqfWKCLr0khuEkCmPMPbMn6os+GowlrZ4GSzekw== X-Received: by 2002:a17:906:6899:: with SMTP id n25mr15546670ejr.462.1622558096357; Tue, 01 Jun 2021 07:34:56 -0700 (PDT) Received: from localhost (ptr-5gw9txf6g5tndjqqqz.18120a2.ip6.access.telenet.be. [2a02:1810:510:3800:1b15:18e4:57d1:eb]) by smtp.gmail.com with ESMTPSA id a97sm8785485edf.72.2021.06.01.07.34.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Jun 2021 07:34:55 -0700 (PDT) From: Thomas De Schampheleire To: buildroot@buildroot.org Date: Tue, 1 Jun 2021 16:34:21 +0200 Message-Id: <20210601143422.25064-17-patrickdepinguin@gmail.com> X-Mailer: git-send-email 2.26.3 In-Reply-To: <20210601143422.25064-1-patrickdepinguin@gmail.com> References: <20210601143422.25064-1-patrickdepinguin@gmail.com> MIME-Version: 1.0 Subject: [Buildroot] [PATCHv4 16/16] utils/genrandconfig: also test BR2_ENABLE_RUNTIME_DEBUG X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas De Schampheleire Errors-To: buildroot-bounces@busybox.net Sender: "buildroot" From: Thomas De Schampheleire ... similar to BR2_ENABLE_DEBUG. Signed-off-by: Thomas De Schampheleire Acked-by: Arnout Vandecappelle (Essensium/Mind) --- utils/genrandconfig | 2 ++ 1 file changed, 2 insertions(+) diff --git a/utils/genrandconfig b/utils/genrandconfig index 93dc6d898b..ca3e77e3e3 100755 --- a/utils/genrandconfig +++ b/utils/genrandconfig @@ -357,6 +357,8 @@ def gen_config(args): # Amend the configuration with a few things. if randint(0, 20) == 0: configlines.append("BR2_ENABLE_DEBUG=y\n") + if randint(0, 20) == 0: + configlines.append("BR2_ENABLE_RUNTIME_DEBUG=y\n") if randint(0, 1) == 0: configlines.append("BR2_INIT_BUSYBOX=y\n") elif randint(0, 15) == 0: