From patchwork Tue Jun 1 14:05:57 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?Martin_Li=C5=A1ka?= X-Patchwork-Id: 1486000 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=2620:52:3:1:0:246e:9693:128c; helo=sourceware.org; envelope-from=gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=suse.cz header.i=@suse.cz header.a=rsa-sha256 header.s=susede2_rsa header.b=s76YSF1a; dkim=fail reason="signature verification failed" header.d=suse.cz header.i=@suse.cz header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=T2QgR0U1; dkim=fail reason="signature verification failed" (1024-bit key) header.d=suse.cz header.i=@suse.cz header.a=rsa-sha256 header.s=susede2_rsa header.b=s76YSF1a; dkim=neutral header.d=suse.cz header.i=@suse.cz header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=T2QgR0U1; dkim-atps=neutral Received: from sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4FvYq86r80z9sj1 for ; Wed, 2 Jun 2021 00:06:12 +1000 (AEST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 656C53B8A43B for ; Tue, 1 Jun 2021 14:06:10 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by sourceware.org (Postfix) with ESMTPS id BBA14388980B for ; Tue, 1 Jun 2021 14:05:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org BBA14388980B Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.cz Received: from imap.suse.de (imap-alt.suse-dmz.suse.de [192.168.254.47]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 9E4C81FD2A; Tue, 1 Jun 2021 14:05:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1622556357; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=e33KUSCnohICcQKjjWeSgHJPwPeHI4DnTofZYeEzFxk=; b=s76YSF1aslMYXlyI4q6HKSt9YxPWlvEDCIylpYcNJkfFzoIiFex+bEftZgFfaCL2GXIqil lxprAXTFKWV/vrJNq8+T6i1n9pc5drKYDKeC6FbukAgrdS6H96ZETfL8tJPVtOk24aVABU xSeLOMZvOgwMS4AWdf8ls2A/HsWQG08= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1622556357; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=e33KUSCnohICcQKjjWeSgHJPwPeHI4DnTofZYeEzFxk=; b=T2QgR0U1R7KulmUVCpBssSaC9h5TXU/3LC0uqtQBww+LFl57KkFc4FMv06apz62odhUjkJ wg/KwRMUWgnKxBCQ== Received: from imap3-int (imap-alt.suse-dmz.suse.de [192.168.254.47]) by imap.suse.de (Postfix) with ESMTP id 792BC118DD; Tue, 1 Jun 2021 14:05:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1622556357; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=e33KUSCnohICcQKjjWeSgHJPwPeHI4DnTofZYeEzFxk=; b=s76YSF1aslMYXlyI4q6HKSt9YxPWlvEDCIylpYcNJkfFzoIiFex+bEftZgFfaCL2GXIqil lxprAXTFKWV/vrJNq8+T6i1n9pc5drKYDKeC6FbukAgrdS6H96ZETfL8tJPVtOk24aVABU xSeLOMZvOgwMS4AWdf8ls2A/HsWQG08= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1622556357; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=e33KUSCnohICcQKjjWeSgHJPwPeHI4DnTofZYeEzFxk=; b=T2QgR0U1R7KulmUVCpBssSaC9h5TXU/3LC0uqtQBww+LFl57KkFc4FMv06apz62odhUjkJ wg/KwRMUWgnKxBCQ== Received: from director2.suse.de ([192.168.254.72]) by imap3-int with ESMTPSA id X55nHMU+tmCCHQAALh3uQQ (envelope-from ); Tue, 01 Jun 2021 14:05:57 +0000 From: =?utf-8?q?Martin_Li=C5=A1ka?= Subject: [PATCH] ARM: reset arm_fp16_format To: gcc-patches@gcc.gnu.org Message-ID: <66e2cc2d-e409-1a11-5b0a-82e0e90201aa@suse.cz> Date: Tue, 1 Jun 2021 16:05:57 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.2 MIME-Version: 1.0 Content-Language: en-US X-Spam-Status: No, score=-10.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_SHORT, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org Sender: "Gcc-patches" Hello. The patch fixes https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98636#c20 where target option restore can be called and arm_fp16_format should be reset to ARM_FP16_FORMAT_NONE. It fixes the ICE in the PR. Can please ARM folks test me the patch on a Arm machine? Thanks, Martin gcc/ChangeLog: PR target/98636 * config/arm/arm.c (arm_option_reconfigure_globals): Reset the option if isa_bit_fp16 is not set. --- gcc/config/arm/arm.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/gcc/config/arm/arm.c b/gcc/config/arm/arm.c index 7b37e1b602c..4543f3c6b55 100644 --- a/gcc/config/arm/arm.c +++ b/gcc/config/arm/arm.c @@ -3765,6 +3765,8 @@ arm_option_reconfigure_globals (void) error ("selected fp16 options are incompatible"); arm_fp16_format = ARM_FP16_FORMAT_IEEE; } + else + arm_fp16_format = ARM_FP16_FORMAT_NONE; arm_arch_cde = 0; arm_arch_cde_coproc = 0;