From patchwork Tue Jun 1 11:06:19 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jiapeng Chong X-Patchwork-Id: 1485959 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=linux-ide-owner@vger.kernel.org; receiver=) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4FvTqt2sPcz9sXL for ; Tue, 1 Jun 2021 21:06:34 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231576AbhFALIM (ORCPT ); Tue, 1 Jun 2021 07:08:12 -0400 Received: from out30-133.freemail.mail.aliyun.com ([115.124.30.133]:37350 "EHLO out30-133.freemail.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231219AbhFALIL (ORCPT ); Tue, 1 Jun 2021 07:08:11 -0400 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R171e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04395;MF=jiapeng.chong@linux.alibaba.com;NM=1;PH=DS;RN=4;SR=0;TI=SMTPD_---0Uav8Pdd_1622545585; Received: from j63c13417.sqa.eu95.tbsite.net(mailfrom:jiapeng.chong@linux.alibaba.com fp:SMTPD_---0Uav8Pdd_1622545585) by smtp.aliyun-inc.com(127.0.0.1); Tue, 01 Jun 2021 19:06:29 +0800 From: Jiapeng Chong To: axboe@kernel.dk Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org, Jiapeng Chong Subject: [PATCH] ata: libata-pmp: Fix missing error code in sata_pmp_eh_recover() Date: Tue, 1 Jun 2021 19:06:19 +0800 Message-Id: <1622545579-19345-1-git-send-email-jiapeng.chong@linux.alibaba.com> X-Mailer: git-send-email 1.8.3.1 Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org The error code is missing in this code scenario, add the error code '-EINVAL' to the return value 'rc'. Eliminate the follow smatch warning: drivers/ata/libata-pmp.c:980 sata_pmp_eh_recover() warn: missing error code 'rc'. Reported-by: Abaci Robot Signed-off-by: Jiapeng Chong --- drivers/ata/libata-pmp.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/ata/libata-pmp.c b/drivers/ata/libata-pmp.c index ba7be3f..66985af 100644 --- a/drivers/ata/libata-pmp.c +++ b/drivers/ata/libata-pmp.c @@ -977,6 +977,7 @@ static int sata_pmp_eh_recover(struct ata_port *ap) ata_link_warn(pmp_link, "failed to disable NOTIFY (err_mask=0x%x)\n", err_mask); + rc = -EINVAL; goto pmp_fail; } }