From patchwork Tue May 25 12:27:36 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas De Schampheleire X-Patchwork-Id: 1483359 Return-Path: X-Original-To: incoming-buildroot@patchwork.ozlabs.org Delivered-To: patchwork-incoming-buildroot@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=busybox.net (client-ip=2605:bc80:3010::136; helo=smtp3.osuosl.org; envelope-from=buildroot-bounces@busybox.net; receiver=) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=bxdnoFbJ; dkim-atps=neutral Received: from smtp3.osuosl.org (smtp3.osuosl.org [IPv6:2605:bc80:3010::136]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4FqCzS734tz9sCD for ; Tue, 25 May 2021 22:28:20 +1000 (AEST) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 65EFB60AE6; Tue, 25 May 2021 12:28:18 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id je7u427ewIuQ; Tue, 25 May 2021 12:28:17 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp3.osuosl.org (Postfix) with ESMTP id B45EF60ACB; Tue, 25 May 2021 12:28:16 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id 201081BF396 for ; Tue, 25 May 2021 12:28:03 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 1C76E83C72 for ; Tue, 25 May 2021 12:28:03 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Authentication-Results: smtp1.osuosl.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id rgQey8kxFhXK for ; Tue, 25 May 2021 12:28:02 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.8.0 Received: from mail-ej1-x62d.google.com (mail-ej1-x62d.google.com [IPv6:2a00:1450:4864:20::62d]) by smtp1.osuosl.org (Postfix) with ESMTPS id DBBF383C7A for ; Tue, 25 May 2021 12:28:01 +0000 (UTC) Received: by mail-ej1-x62d.google.com with SMTP id p24so45786937ejb.1 for ; Tue, 25 May 2021 05:28:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=pK8PJw/fHuysc2Y4BL/X4V3Lw1OAxjxW1mRJGt1coLE=; b=bxdnoFbJ1pS8U2ST7KZwWA9FWkkqI2d/53Y6QInXZcXmya7WCcTG9TaatOYYYPWyF/ XiGvhFvY5ORDfq4FDTtQ9cOXYdlq6gT4bZjgv9eahZTxmYKBMpGdAHs3CoYWh4gtEQox kHMYPcta6sQA7RpengqicikFN/cqvZ2XgFyw0l9SJPNBbumN/ptJu2WRrk24vbIIilF3 IZNvu8wNV6BhlHqsWa4fqvplAyAC3wFF9a60Z+4gGrucQxl9e4HBFg5IwbNqylO/QKEf RJ208WmO24auQr8AOhx5ycVo82BHr/RxlpcY2FtYkcpj//MO1aitWuIE04ZhfdFJvk45 m0gQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=pK8PJw/fHuysc2Y4BL/X4V3Lw1OAxjxW1mRJGt1coLE=; b=YH3E1CgHCClXdpFqvS1ruGAvA6TXz29e2TWJyadCoZZu/N98SvYtznHHK3EkKSLIgC +uPlVCzmcqlVNJJbfb3Z0VCr+KhPe0OkXarH3Er14eVC92X9b8wFODJupcDGE2k2vumw 1ZSIwWn/mwdVZg/JdNvoBJBv5Z+goamfD3hx/riYoTdjMlmuCiwiB98copjPu3PqQ2zY qHCo4lt/85uAFvGwTztth+qC2bKtmX9kThUNgoXDb4q1F+PMXt8PCwmclISYqlJA6ew1 YCQpjIttAr9kgFVaiz8t8LzzkN70tyoCGT9yWI5z1dhnB4DpKXKJ04osHEo2mALfc6op sDTQ== X-Gm-Message-State: AOAM532gTTPPLUZbOMNx6bxJHeFaonye6XMMkI9egczXSA8My/MZe8rm 9uHtNC8V+j/hjggfr2IbUoQY7zS4qr3BFw== X-Google-Smtp-Source: ABdhPJy+SOUvHQr68UQzZbg2T+lc/jZhxcZgw2w6JmUJvCM5wjRfsJ/kQ/Zzzayxe4446fDQfeiNOA== X-Received: by 2002:a17:906:c314:: with SMTP id s20mr25089430ejz.521.1621945680112; Tue, 25 May 2021 05:28:00 -0700 (PDT) Received: from localhost (ptr-5gw9txf6g5tndjqqqz.18120a2.ip6.access.telenet.be. [2a02:1810:510:3800:1b15:18e4:57d1:eb]) by smtp.gmail.com with ESMTPSA id r17sm10640327edt.33.2021.05.25.05.27.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 May 2021 05:27:59 -0700 (PDT) From: Thomas De Schampheleire To: buildroot@buildroot.org Date: Tue, 25 May 2021 14:27:36 +0200 Message-Id: <20210525122750.5022-2-patrickdepinguin@gmail.com> X-Mailer: git-send-email 2.26.3 In-Reply-To: <20210525122750.5022-1-patrickdepinguin@gmail.com> References: <20210525122750.5022-1-patrickdepinguin@gmail.com> MIME-Version: 1.0 Subject: [Buildroot] [PATCHv3 01/15] package/Makefile.in: pass '-g0' explicitly if !BR2_ENABLE_DEBUG X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas De Schampheleire Errors-To: buildroot-bounces@busybox.net Sender: "buildroot" From: Thomas De Schampheleire If BR2_ENABLE_DEBUG is not set, Buildroot did not pass any flag to control debug level. This means that the build system of the package itself would control it. Instead, provide an explicit '-g0' (no debugging symbols) to get consistent behavior across packages. Suggested-by: Arnout Vandecappelle Signed-off-by: Thomas De Schampheleire --- package/Makefile.in | 3 +++ 1 file changed, 3 insertions(+) diff --git a/package/Makefile.in b/package/Makefile.in index f4028bc67c..86db62ba5b 100644 --- a/package/Makefile.in +++ b/package/Makefile.in @@ -136,6 +136,9 @@ endif ifeq ($(BR2_OPTIMIZE_FAST),y) TARGET_OPTIMIZATION = -Ofast endif +ifeq ($(BR2_ENABLE_DEBUG),) +TARGET_DEBUGGING = -g0 +endif ifeq ($(BR2_DEBUG_1),y) TARGET_DEBUGGING = -g1 endif From patchwork Tue May 25 12:27:37 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas De Schampheleire X-Patchwork-Id: 1483360 Return-Path: X-Original-To: incoming-buildroot@patchwork.ozlabs.org Delivered-To: patchwork-incoming-buildroot@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=busybox.net (client-ip=140.211.166.138; helo=smtp1.osuosl.org; envelope-from=buildroot-bounces@busybox.net; receiver=) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=b9Hc6bf/; dkim-atps=neutral Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4FqD014l7zz9sCD for ; Tue, 25 May 2021 22:28:47 +1000 (AEST) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id F1ECC83C84; Tue, 25 May 2021 12:28:44 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id v9VsM2wIAS6R; Tue, 25 May 2021 12:28:44 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp1.osuosl.org (Postfix) with ESMTP id 35C9083C89; Tue, 25 May 2021 12:28:43 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id 3F7181BF396 for ; Tue, 25 May 2021 12:28:05 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 4C24083C7A for ; Tue, 25 May 2021 12:28:04 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id EQ7kZCPSOzCg for ; Tue, 25 May 2021 12:28:03 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.8.0 Received: from mail-ej1-x62c.google.com (mail-ej1-x62c.google.com [IPv6:2a00:1450:4864:20::62c]) by smtp1.osuosl.org (Postfix) with ESMTPS id 77C1A82FC9 for ; Tue, 25 May 2021 12:28:03 +0000 (UTC) Received: by mail-ej1-x62c.google.com with SMTP id z12so45577278ejw.0 for ; Tue, 25 May 2021 05:28:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=FagAqAaiz8MXzRyNpyonC+TBx5Qm8MMEzHi4astGSfw=; b=b9Hc6bf/QJ/abYph8OLSdyG5hmHP6d3u7c5i7mgaFSBSYeyxjNOSvJ560PFXT6PlAI wAGO49p1EjhUNrrxC+HmwPhKD9EXas8FVwZ14vou23lVV48MdfwUOkZET+VtSCD8yTZd I2zK8IZjYmiwmHOkNeNgdtIJ98YsrUPZVzPe6Aw6C7Py1qqpOvmpRTv9sojPL/J5A4eX SRyCiR0Jh6TyigG4oSgXMZCUw1CWCD7hTLC4FT0V/91BRBzFjgZ5o1Q7f6LTG76NeOHv 9t1n9xQCm2I3iUTz4GHXfes0UTDXB954TWj4i85aJP7GrnLYFugL7ymbMlPbAljuUv3d JRaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=FagAqAaiz8MXzRyNpyonC+TBx5Qm8MMEzHi4astGSfw=; b=hq29iE8gAWhYwu6h3ELWXQsU+Agzu5/r2EMgcjuHShxleu1MsLoZRZpuabTFOigNG+ kD8TjGdXOKvw3FklMCmmzPBK5uoDUcTtTDT0c+3q8RCKdJ7vaWnPmTGoG7rCxknSklU1 q2oCvY4sG3q0qcCEp31/uQJfMfMdktnlvJmDV6G/zY8IlaxUJV9DZEgWznQulUCLWiGi ujYDLXCQH0907i8Utx2nbzeEtPRjYMrbcOcBU9TpR5Rz4kqGhVT+91JLHSNXE8bOFoCo JjkGy3fzoqule3In0b9vae1q5YWAIvz1J7n2VMw4940nhHcfWC3flMbjz861fGongtBi BDiw== X-Gm-Message-State: AOAM533C2t3p+ug16RHSKjJxG/oehJkpljqapnW+u43NK+Hes2RAe+WE Ss/qAjhxzGVIwlYerZArm9RpWJ1SF4JW7A== X-Google-Smtp-Source: ABdhPJyFJ/s6HY1nJqxmyEhWkZMfNAKy/vkfDUJRnKWgHTppCjTHkwFpCiWJfGjfR3me4jz5bymJgA== X-Received: by 2002:a17:906:bcf9:: with SMTP id op25mr29209668ejb.453.1621945681773; Tue, 25 May 2021 05:28:01 -0700 (PDT) Received: from localhost (ptr-5gw9txf6g5tndjqqqz.18120a2.ip6.access.telenet.be. [2a02:1810:510:3800:1b15:18e4:57d1:eb]) by smtp.gmail.com with ESMTPSA id p11sm4242036edt.22.2021.05.25.05.28.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 May 2021 05:28:01 -0700 (PDT) From: Thomas De Schampheleire To: buildroot@buildroot.org Date: Tue, 25 May 2021 14:27:37 +0200 Message-Id: <20210525122750.5022-3-patrickdepinguin@gmail.com> X-Mailer: git-send-email 2.26.3 In-Reply-To: <20210525122750.5022-1-patrickdepinguin@gmail.com> References: <20210525122750.5022-1-patrickdepinguin@gmail.com> MIME-Version: 1.0 Subject: [Buildroot] [PATCHv3 02/15] core: introduce BR2_ENABLE_RUNTIME_DEBUG X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas De Schampheleire Errors-To: buildroot-bounces@busybox.net Sender: "buildroot" From: Thomas De Schampheleire Some packages have optional runtime assertions, extra traces, or other elements that can help in debugging problems. However, such runtime elements can negatively influence performance. In a test program performing 100K gRPC calls from a client to a local server and receiving the returned response, we see following execution time: - runtime debug enabled: 1065 seconds - runtime debug disabled: 48 seconds This is more than a factor 20 (!) difference. Analysis shows that the problem mostly stems from libabseil-cpp (a dependency of gRPC) which enables mutex deadlock analysis when the preprocessor flag 'NDEBUG' is not set, which adds a 'backtrace()' call on every lock/unlock. Potentially worse, when libunwind is enabled and linked with the test program, 'backtrace()' is not provided by glibc but by libunwind itself. For production systems, users expect good performance out-of-the-box. In the example above, the difference is huge and unless explicitly tested and analyzed, users may not realize that the performance could be much better. Address this problem by introducing a new option BR2_ENABLE_RUNTIME_DEBUG, which can be used by packages or package infrastructures to set the necessary flags. Note that BR2_ENABLE_RUNTIME_DEBUG is orthogonal to BR2_ENABLE_DEBUG: the former changes runtime behavior, while the latter is only expected to add debug symbols to the build. Today, the cmake build system does introduce a runtime impact when BR2_ENABLE_DEBUG is set, but that will be rectified in a subsequent commit. Signed-off-by: Thomas De Schampheleire Acked-by: Arnout Vandecappelle (Essensium/Mind) --- Config.in | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/Config.in b/Config.in index c65e34bd5e..a008425688 100644 --- a/Config.in +++ b/Config.in @@ -412,6 +412,19 @@ config BR2_DEBUG_3 endchoice endif +config BR2_ENABLE_RUNTIME_DEBUG + bool "build packages with runtime debugging info" + help + Some packages may have runtime assertions, extra traces, and + similar runtime elements that can help debugging. However, + these elements may negatively influence performance so should + normally not be enabled on production systems. + + Enable this option to enable such runtime debugging. + + Note: disabling this option is not a guarantee that all + packages effectively removed these runtime debugging elements. + config BR2_STRIP_strip bool "strip target binaries" default y From patchwork Tue May 25 12:27:38 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas De Schampheleire X-Patchwork-Id: 1483361 Return-Path: X-Original-To: incoming-buildroot@patchwork.ozlabs.org Delivered-To: patchwork-incoming-buildroot@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=busybox.net (client-ip=2605:bc80:3010::137; helo=smtp4.osuosl.org; envelope-from=buildroot-bounces@busybox.net; receiver=) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=a86SQWxk; dkim-atps=neutral Received: from smtp4.osuosl.org (smtp4.osuosl.org [IPv6:2605:bc80:3010::137]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4FqD0F18cKz9sCD for ; Tue, 25 May 2021 22:29:00 +1000 (AEST) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id E4D024022F; Tue, 25 May 2021 12:28:57 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 4VCuPXujPQPK; Tue, 25 May 2021 12:28:56 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp4.osuosl.org (Postfix) with ESMTP id D538240231; Tue, 25 May 2021 12:28:55 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id 11AFA1BF396 for ; Tue, 25 May 2021 12:28:07 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 69B0283C83 for ; Tue, 25 May 2021 12:28:06 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Authentication-Results: smtp1.osuosl.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id E6REJ6MLpI7i for ; Tue, 25 May 2021 12:28:05 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.8.0 Received: from mail-ej1-x62d.google.com (mail-ej1-x62d.google.com [IPv6:2a00:1450:4864:20::62d]) by smtp1.osuosl.org (Postfix) with ESMTPS id 3DED983C7F for ; Tue, 25 May 2021 12:28:05 +0000 (UTC) Received: by mail-ej1-x62d.google.com with SMTP id gb17so28992776ejc.8 for ; Tue, 25 May 2021 05:28:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ZZPbEMKRqlxYWzlUTGXukQkzt3waaBTYHt9PFpUkpIQ=; b=a86SQWxkOO1SYWCN7ihqmhIbdYpC6yRT4GFsb8SPlrSpVTisInqDD7ejbrPz/gmOPi Ujo3HHmuQ4SB3saFwC5aEOJhIROxanMtgy/vhLPp76j9SFT5Q2j7HFSikaZ1WFlJwMgb Uu0Wb2c+b5Y2S4EFvkcZf5cRYoY/Pzp1XgKrQRfW1NTGkPcT+HY9Cy2sOW3A3IGf8r6X jVl8ztv2Pzi/S9O8Krs1S54ivY5zvQdDwMIOoRK+bJYj46LNP6YifqM9Oo01t2yHb944 lydNjVgg+/doJreMDrJZenQyj9ILLvVrry2P4u9mefltUs+7x5L63Z+q0Ds2dpqoBDb+ 6pwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ZZPbEMKRqlxYWzlUTGXukQkzt3waaBTYHt9PFpUkpIQ=; b=CHPFncszeROsqtHfhDsF/bkZjXG7i65Ef2g7+vi4XJEwZiyWI0TJPa0iEumN0EOI8G gi2Uy1DqoCMzi+dG9a34NcrKVMmNwHok1Ni+V3mZvctGOy5rCuqr3qWbDUT6lmSbCTVv FtI18fbr2kFs5Zx/Dx63ngj6Ftih4I43nSv+augi2WT8umCJlj18hi96y7G5kDWTylh1 MSF87N40L32FQIDh4wDlgN5sk/0p54uqmEuO1GsxSpMnCAwfDe7zCFMux4l9Yw2d8vCc 8Ts+2wO3lnhJg739dTCr1Fipw/EV+wJ5jrChzRuLlnKWVA/wGEOXuE4fKTajSugF1xiu 3+VQ== X-Gm-Message-State: AOAM5316yWDJE6y7Z4xNOr2r8tCyFfbZndsEQrqBQBYWrQKZHcl1jws2 aNGDkEA4w3ojRvncFB7F2tHS35tls69iJQ== X-Google-Smtp-Source: ABdhPJzU6rr4PUHmxomdIrN+f5qJRi7UaIe/UEZJr09jBRY6VkMKAGsjpRbs29Rz+kNZegRKEjHyNg== X-Received: by 2002:a17:907:927:: with SMTP id au7mr29165204ejc.267.1621945683540; Tue, 25 May 2021 05:28:03 -0700 (PDT) Received: from localhost (ptr-5gw9txf6g5tndjqqqz.18120a2.ip6.access.telenet.be. [2a02:1810:510:3800:1b15:18e4:57d1:eb]) by smtp.gmail.com with ESMTPSA id ju17sm9030195ejc.72.2021.05.25.05.28.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 May 2021 05:28:03 -0700 (PDT) From: Thomas De Schampheleire To: buildroot@buildroot.org Date: Tue, 25 May 2021 14:27:38 +0200 Message-Id: <20210525122750.5022-4-patrickdepinguin@gmail.com> X-Mailer: git-send-email 2.26.3 In-Reply-To: <20210525122750.5022-1-patrickdepinguin@gmail.com> References: <20210525122750.5022-1-patrickdepinguin@gmail.com> MIME-Version: 1.0 Subject: [Buildroot] [PATCHv3 03/15] package/pkg-cmake.mk: determine CMAKE_BUILD_TYPE depending on BR2_ENABLE_RUNTIME_DEBUG X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Samuel Martin , Thomas De Schampheleire Errors-To: buildroot-bounces@busybox.net Sender: "buildroot" From: Thomas De Schampheleire The CMAKE_BUILD_TYPE is currently set as 'Debug' in case BR2_ENABLE_DEBUG is set, and as 'Release' in other cases. However, while the description of BR2_ENABLE_DEBUG is to enable debug symbols (no runtime impact), the 'Debug' build type in CMake can actually have runtime impact. For one, because it does not set -DNDEBUG like is done for 'Release', but also because packages may do custom things based on it. The question of which CMAKE_BUILD_TYPE Buildroot should set, be it 'Debug', 'Release', 'RelWithDebInfo' or others, has come up several times in the past. See some references below: - July 2016: switch from Debug to RelWithDebInfo: https://git.buildroot.org/buildroot/commit/?id=4b0120183404913f7f7788ef4f0f6b51498ef363 - October 2016: switch from RelWithDebInfo back to Debug: https://git.buildroot.org/buildroot/commit/?id=104bb29e0490bfb487e2e665448dd3ca07fcc2b5 and changes to make sure Buildroot's flags are respected: https://git.buildroot.org/buildroot/commit/?id=12494ef48f893684d0800e7f6fe39a2ceaed0451 - August 2017: bug #10246 - "BR2_ENABLE_DEBUG does not have the expected effect for cmake packages" https://bugs.busybox.net/show_bug.cgi?id=10246 - August 2017: mail thread following bug #10246: http://lists.busybox.net/pipermail/buildroot/2017-August/200778.html In the last mail thread, Samuel Martin confirmed that the 'Release' build type could be used in all cases, because Buildroot is actually making sure that the optimization flags are those determined by Buildroot, not the defaults of cmake, thanks to commit 12494ef48f. But Arnout Vandecappelle objected to using always 'Release', stating that users may actually want the extra assertions. With the introduction of BR2_ENABLE_RUNTIME_DEBUG, Buildroot can now cater for all cases: - use CMAKE_BUILD_TYPE=Release by default. This makes sure that there is no unexpected performance degradation triggered by enabling BR2_ENABLE_DEBUG. - users can optionally enable BR2_ENABLE_RUNTIME_DEBUG if they want runtime debug info like assertions, at the risk of introducing performance degradation. In this case, we switch to CMAKE_BUILD_TYPE=Debug. - orthogonally to the above, BR2_ENABLE_DEBUG still determines passing the '-g' flag to enable debug symbols, and BR2_OPTIMIZE_X still determines the used optimization flags. Signed-off-by: Thomas De Schampheleire Acked-by: Arnout Vandecappelle (Essensium/Mind) --- docs/manual/adding-packages-cmake.txt | 2 +- package/pkg-cmake.mk | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/manual/adding-packages-cmake.txt b/docs/manual/adding-packages-cmake.txt index 73f0943024..541d7422cf 100644 --- a/docs/manual/adding-packages-cmake.txt +++ b/docs/manual/adding-packages-cmake.txt @@ -100,7 +100,7 @@ typical packages will therefore only use a few of them. necessary to set them in the package's +*.mk+ file unless you want to override them: -** +CMAKE_BUILD_TYPE+ is driven by +BR2_ENABLE_DEBUG+; +** +CMAKE_BUILD_TYPE+ is driven by +BR2_ENABLE_RUNTIME_DEBUG+; ** +CMAKE_INSTALL_PREFIX+; ** +BUILD_SHARED_LIBS+ is driven by +BR2_STATIC_LIBS+; ** +BUILD_DOC+, +BUILD_DOCS+ are disabled; diff --git a/package/pkg-cmake.mk b/package/pkg-cmake.mk index 37078f3c34..4ee100a0c6 100644 --- a/package/pkg-cmake.mk +++ b/package/pkg-cmake.mk @@ -266,7 +266,7 @@ define TOOLCHAIN_CMAKE_INSTALL_FILES -e 's#@@CMAKE_SYSTEM_PROCESSOR@@#$(call qstrip,$(CMAKE_SYSTEM_PROCESSOR))#' \ -e 's#@@TOOLCHAIN_HAS_CXX@@#$(if $(BR2_INSTALL_LIBSTDCPP),1,0)#' \ -e 's#@@TOOLCHAIN_HAS_FORTRAN@@#$(if $(BR2_TOOLCHAIN_HAS_FORTRAN),1,0)#' \ - -e 's#@@CMAKE_BUILD_TYPE@@#$(if $(BR2_ENABLE_DEBUG),Debug,Release)#' \ + -e 's#@@CMAKE_BUILD_TYPE@@#$(if $(BR2_ENABLE_RUNTIME_DEBUG),Debug,Release)#' \ $(TOPDIR)/support/misc/toolchainfile.cmake.in \ > $(HOST_DIR)/share/buildroot/toolchainfile.cmake $(Q)$(INSTALL) -D -m 0644 support/misc/Buildroot.cmake \ From patchwork Tue May 25 12:27:39 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas De Schampheleire X-Patchwork-Id: 1483362 Return-Path: X-Original-To: incoming-buildroot@patchwork.ozlabs.org Delivered-To: patchwork-incoming-buildroot@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=busybox.net (client-ip=140.211.166.138; helo=smtp1.osuosl.org; envelope-from=buildroot-bounces@busybox.net; receiver=) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=g/7FebXF; dkim-atps=neutral Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4FqD0T0CBqz9sCD for ; Tue, 25 May 2021 22:29:13 +1000 (AEST) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 2E66583C86; Tue, 25 May 2021 12:29:11 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id h5_zkQxCsd2N; Tue, 25 May 2021 12:29:10 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp1.osuosl.org (Postfix) with ESMTP id 7933283C89; Tue, 25 May 2021 12:29:09 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id 264661BF396 for ; Tue, 25 May 2021 12:28:08 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id DC42A83C9A for ; Tue, 25 May 2021 12:28:07 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id VQ-iWIs7QjeK for ; Tue, 25 May 2021 12:28:07 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.8.0 Received: from mail-ej1-x633.google.com (mail-ej1-x633.google.com [IPv6:2a00:1450:4864:20::633]) by smtp1.osuosl.org (Postfix) with ESMTPS id 08FF883C89 for ; Tue, 25 May 2021 12:28:06 +0000 (UTC) Received: by mail-ej1-x633.google.com with SMTP id f18so16859733ejq.10 for ; Tue, 25 May 2021 05:28:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=emiDhWA1lQZ1OA+++9cKG0ewoKc1z3SEg+12M3zR3H0=; b=g/7FebXFBiboOA0mqHnU0HMdYndGY3cAT2DAXlNaCSeQYqSnmPnQR9NmSVOJnwnmBC 6sOHVIj+XAblGmM5Y90ZQbh2n9gNTnOFWZKCvzZsBS0uYzA96wSg1u/9JPlAtbmq+Oo4 G3M623rqkyf5zntUSBAyy3fh+gPz5M/tIPnTi3kWpRtkF4rGu3uRh7xgwZRybtcXlSmq wsh3Wmqd0GTuPbbP1D+Qhm7gzisy+7bExUQssD9LTCk6pMdUSIvXbsZTe+/Ye4W6i2ht FwEeUH8U0hFz/71Sn4t9O985TVfBuwZGxLuLj2HhzNr2U5jbvL8pU3ogzSw9dA8LkiIX FHFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=emiDhWA1lQZ1OA+++9cKG0ewoKc1z3SEg+12M3zR3H0=; b=hfwCcQwayGPp3KJMlWDagslb5rKCKMjISPecd7HKPwi908F0xukAuJU2AdHr6DklUA Q+OmM6WZ8AKOumnRHNJNul9CxMyTOzlj9PqAD4MMUVy2uLFTRBGqjRxMnKeklsQgtQSd 78KzDM74dGbj+W6n0gE9DRDb5Q8AvHaMWknlc/2/CJBn4mavQyI8CARd6qU7Jv2gFK1e S9gdAuXI07BWIrKaI+Nc73l5qs+WPnmM+6xXFW9j+kaUhkl8Ptft6kVbGJZJZR79EZRi s8rXS2GL28UCfbNiijpyx0HoR4NvpM3tD/coBPSNHQj4CwOpdXqXfQYcXExIahIOlrUR LkgA== X-Gm-Message-State: AOAM5327kL4gugZrVNC9Dp1IaiOqs+8jMSXWzJvykB8gxQcr2YMmCyb0 RrC6IQJpu0M9D0gZIzckq84AEluEWHkjJw== X-Google-Smtp-Source: ABdhPJwjo6Do0MntxaIy+ERt3jcJfAND+9kEL7it/MGjsrJVmaFxPg1g6jI4HaUDmRQS8h059h/lCw== X-Received: by 2002:a17:906:2a56:: with SMTP id k22mr28956331eje.551.1621945685231; Tue, 25 May 2021 05:28:05 -0700 (PDT) Received: from localhost (ptr-5gw9txf6g5tndjqqqz.18120a2.ip6.access.telenet.be. [2a02:1810:510:3800:1b15:18e4:57d1:eb]) by smtp.gmail.com with ESMTPSA id d15sm10799633eds.68.2021.05.25.05.28.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 May 2021 05:28:04 -0700 (PDT) From: Thomas De Schampheleire To: buildroot@buildroot.org Date: Tue, 25 May 2021 14:27:39 +0200 Message-Id: <20210525122750.5022-5-patrickdepinguin@gmail.com> X-Mailer: git-send-email 2.26.3 In-Reply-To: <20210525122750.5022-1-patrickdepinguin@gmail.com> References: <20210525122750.5022-1-patrickdepinguin@gmail.com> MIME-Version: 1.0 Subject: [Buildroot] [PATCHv3 04/15] package/flare-engine: update explicit setting of CMAKE_BUILD_TYPE X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Romain Naour , Thomas De Schampheleire Errors-To: buildroot-bounces@busybox.net Sender: "buildroot" From: Thomas De Schampheleire The flare-engine package forces CMAKE_BUILD_TYPE=RelWithDebInfo in case Buildroot would normally set CMAKE_BUILD_TYPE=Debug. Previously, this would happen if BR2_ENABLE_DEBUG is set, but now we should check BR2_ENABLE_RUNTIME_DEBUG instead. Signed-off-by: Thomas De Schampheleire --- package/flare-engine/flare-engine.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package/flare-engine/flare-engine.mk b/package/flare-engine/flare-engine.mk index e2f3eefa28..503eb0825f 100644 --- a/package/flare-engine/flare-engine.mk +++ b/package/flare-engine/flare-engine.mk @@ -15,7 +15,7 @@ FLARE_ENGINE_DEPENDENCIES += sdl2 sdl2_image sdl2_mixer sdl2_ttf FLARE_ENGINE_CONF_OPTS += -DBINDIR=bin -DDATADIR=share/flare # Don't use the default Debug type as it adds -pg (gprof) -ifeq ($(BR2_ENABLE_DEBUG),y) +ifeq ($(BR2_ENABLE_RUNTIME_DEBUG),y) FLARE_ENGINE_CONF_OPTS += -DCMAKE_BUILD_TYPE=RelWithDebInfo endif From patchwork Tue May 25 12:27:40 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas De Schampheleire X-Patchwork-Id: 1483363 Return-Path: X-Original-To: incoming-buildroot@patchwork.ozlabs.org Delivered-To: patchwork-incoming-buildroot@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=busybox.net (client-ip=2605:bc80:3010::133; helo=smtp2.osuosl.org; envelope-from=buildroot-bounces@busybox.net; receiver=) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=UppByRC7; dkim-atps=neutral Received: from smtp2.osuosl.org (smtp2.osuosl.org [IPv6:2605:bc80:3010::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4FqD0k4XK7z9sRf for ; Tue, 25 May 2021 22:29:26 +1000 (AEST) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id B4448401D6; Tue, 25 May 2021 12:29:23 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id pWOYzQ_mDJxJ; Tue, 25 May 2021 12:29:23 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp2.osuosl.org (Postfix) with ESMTP id 1971A40139; Tue, 25 May 2021 12:29:22 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by ash.osuosl.org (Postfix) with ESMTP id 6E09E1BF396 for ; Tue, 25 May 2021 12:28:09 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 5D34A60ACB for ; Tue, 25 May 2021 12:28:09 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Authentication-Results: smtp3.osuosl.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id g7WP_k8vVNIJ for ; Tue, 25 May 2021 12:28:08 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.8.0 Received: from mail-ed1-x535.google.com (mail-ed1-x535.google.com [IPv6:2a00:1450:4864:20::535]) by smtp3.osuosl.org (Postfix) with ESMTPS id 9FA3560AB2 for ; Tue, 25 May 2021 12:28:08 +0000 (UTC) Received: by mail-ed1-x535.google.com with SMTP id i13so35970619edb.9 for ; Tue, 25 May 2021 05:28:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=QBDi30aiIusXSDj76bhiFXHOZRfp2oXN5QmuB5HmCXA=; b=UppByRC7v8BwZfxR2dn5gAZcIemGcG9lU/XshPNwki1OyhR9RL8fmXLu2dpawhESKh o+G1n8UjzrVZ2G4sc8cqdgGJKbbCIAc8NBug9a9oSqertDnEYjANmXoPVPtE1EW2zbkb dQU4J5QDcBlWGg9YJO/71UN13i5cW7QN2/hzepRBa/us+t/zVxBPzQnarLM4Lt1Jrgdj 5jSF/rx7oxEMnxYXNvoszO57DLbdsifKybWds2DPVDK/QypQGagUiz0QqFIFOPT+ZC6v EvvvQZvL+icbDbZe1NJt0pY07UiYkimaYE0OjLxnfHlvdtrdFqDntA40K4P1ZTyCPtWq hF9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=QBDi30aiIusXSDj76bhiFXHOZRfp2oXN5QmuB5HmCXA=; b=eR8waHFHATUSDZmSzs2mn3EIj49h7+VMtFI3SC8itlX3vgqGZUP41bsuuBtFWOebex neeLgHrLTDYN25JL8f8QbQeF1F5BF8r3gaXhcoz861VOxl+MA1RgWnumuORqhYvAKINT y7cdAzJr0xT3aE4m6fLYjlFU6kKqFSzJBzVZk2qpkAoxc240EV8ImJ9fp2DH+156DxBn WGaf65r4pX1MHqg6YtX0++BuA7YdBXl1kZoJPMm9focOXenxJJudx3ZDGFcDXktL6Q69 IoE9sO0Tind8C/Xo8FncN1fs8NwiWQVJnXpg/+Qj1sk9bQFwnNIj3lf8Z9eia6HNOODq gXmA== X-Gm-Message-State: AOAM532msJ/nZ0SGykMaEQtomuXtmo32ZjOia8/fD+EYpM3QmSW1+ZUd 3AJEM8PVfMRX0MoIeZiaZExqUNhT3X68cA== X-Google-Smtp-Source: ABdhPJwCKmHxWkHh6vI0ReG10sboFwIyLlyagYibhVTRf09RzodMJXYAKeqnO67FtjaldHclf1CBmg== X-Received: by 2002:a50:c09a:: with SMTP id k26mr31706002edf.27.1621945686917; Tue, 25 May 2021 05:28:06 -0700 (PDT) Received: from localhost (ptr-5gw9txf6g5tndjqqqz.18120a2.ip6.access.telenet.be. [2a02:1810:510:3800:1b15:18e4:57d1:eb]) by smtp.gmail.com with ESMTPSA id m19sm11217151edd.12.2021.05.25.05.28.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 May 2021 05:28:06 -0700 (PDT) From: Thomas De Schampheleire To: buildroot@buildroot.org Date: Tue, 25 May 2021 14:27:40 +0200 Message-Id: <20210525122750.5022-6-patrickdepinguin@gmail.com> X-Mailer: git-send-email 2.26.3 In-Reply-To: <20210525122750.5022-1-patrickdepinguin@gmail.com> References: <20210525122750.5022-1-patrickdepinguin@gmail.com> MIME-Version: 1.0 Subject: [Buildroot] [PATCHv3 05/15] package/sysrepo: use default CMAKE_BUILD_TYPE for host package X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?utf-8?q?Jan_Kundr=C3=A1t?= , Heiko Thiery , Thomas De Schampheleire Errors-To: buildroot-bounces@busybox.net Sender: "buildroot" From: Thomas De Schampheleire Use the default build type for host-sysrepo. In the current version of sysrepo, this happens to be 'Debug'. As 'Debug' also enables tests, explicitly disable them. Suggested-by: Arnout Vandecappelle Signed-off-by: Thomas De Schampheleire Acked-by: Arnout Vandecappelle (Essensium/Mind) Acked-by: Heiko Thiery --- package/sysrepo/sysrepo.mk | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/package/sysrepo/sysrepo.mk b/package/sysrepo/sysrepo.mk index dbc7b16b63..f5be29d2c9 100644 --- a/package/sysrepo/sysrepo.mk +++ b/package/sysrepo/sysrepo.mk @@ -26,8 +26,9 @@ define SYSREPO_INSTALL_INIT_SYSV endef HOST_SYSREPO_CONF_OPTS = \ - -DCMAKE_BUILD_TYPE=Release \ -DBUILD_EXAMPLES=OFF \ + -DENABLE_TESTS=OFF \ + -DENABLE_VALGRIND_TESTS=OFF \ -DREPO_PATH=$(TARGET_DIR)/etc/sysrepo $(eval $(cmake-package)) From patchwork Tue May 25 12:27:41 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas De Schampheleire X-Patchwork-Id: 1483364 Return-Path: X-Original-To: incoming-buildroot@patchwork.ozlabs.org Delivered-To: patchwork-incoming-buildroot@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=busybox.net (client-ip=140.211.166.136; helo=smtp3.osuosl.org; envelope-from=buildroot-bounces@busybox.net; receiver=) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=rcFl/aEB; dkim-atps=neutral Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4FqD0y11Szz9sCD for ; Tue, 25 May 2021 22:29:38 +1000 (AEST) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 9A27760ACB; Tue, 25 May 2021 12:29:36 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id L_q9JdOuh32l; Tue, 25 May 2021 12:29:35 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp3.osuosl.org (Postfix) with ESMTP id E3F4A60AD1; Tue, 25 May 2021 12:29:34 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by ash.osuosl.org (Postfix) with ESMTP id 575661BF396 for ; Tue, 25 May 2021 12:28:11 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 542D360AE1 for ; Tue, 25 May 2021 12:28:11 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id uWSzNRpg4ayz for ; Tue, 25 May 2021 12:28:10 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.8.0 Received: from mail-ed1-x52f.google.com (mail-ed1-x52f.google.com [IPv6:2a00:1450:4864:20::52f]) by smtp3.osuosl.org (Postfix) with ESMTPS id 8030660A64 for ; Tue, 25 May 2021 12:28:10 +0000 (UTC) Received: by mail-ed1-x52f.google.com with SMTP id i13so35970754edb.9 for ; Tue, 25 May 2021 05:28:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=o6ZuqCZU0d6g9B1S/C59O5l0KkSJjkUNPS7EFoKUvJE=; b=rcFl/aEBgeyGNXl/1IgpyZu2otZSMDagaTtPVMCTqYhwVOr28qsB2kPAlxLqfjzYUi 97mvJfbymkTy36hsbPkwFdmfZhukzzcNYN2+o4XVkA/YbXjMkTgcyNIXcOIG9RpxQCvu +9il2GP39OotEGTq+huI5dld0ukRgdh5xhShvqakS6lL2LddjEnXafmOP26NYyHa1WMM KpukjTwzy3YrNax0VTHr7JNG3avZ85QK2PcZ0H5Q4OMo47IK5v24yA6d3zgTHQUSNLEM uBHzw/WKErxzhIRzTugBeHjT1mMc4yrQsWapsYYEJmnGzFDfRdP+1Qk6BwEQ7QOYrGk+ 4urQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=o6ZuqCZU0d6g9B1S/C59O5l0KkSJjkUNPS7EFoKUvJE=; b=o3/eC8TKD41DeJLkZQuslCXEAseL6TBBju1zst2HQhQ6CrOKoRbObkNFmtCjZ5OfCE 3kP9g/6+lbil6jg0aMW4tteokbcIRUAvkFrIbHfB2Az/LG6dYgBdOkj/SgWXi5HJLaLg wSP7RvFPLIZ3o27FB8NP7Pf5LhvfW/ex0xnG7l5bsqP5Zcv8oZWsKIAMwFVcLoijb/K5 xsRYKvr1E4s1e/QdVkwtw0y4uUgvFu+GVmuBWUBMu3xby17aV9LK/y9TXRGzJJB5qW+2 sbU/IdsbvZDiHXUcererOmlTHSn67mIqT4eYGbZCdGQ8xABzIAdrV209dUcpcTYbTvzf So+g== X-Gm-Message-State: AOAM531TlWPOORldJSIW5n1KLygcZHNZeQD8ynL7O2pmaTvlK5KprY0u 8quluG718KCZ4FoLlNvWH9rP5U5iWOgapg== X-Google-Smtp-Source: ABdhPJzYgEYcV8NWJOp92Ny/Ph5rhWLGR3vuKwljUjSdxv2m4cybDmamnH/tCdMfizCiKMm0Cj5TPw== X-Received: by 2002:a50:eb47:: with SMTP id z7mr32125995edp.68.1621945688734; Tue, 25 May 2021 05:28:08 -0700 (PDT) Received: from localhost (ptr-5gw9txf6g5tndjqqqz.18120a2.ip6.access.telenet.be. [2a02:1810:510:3800:1b15:18e4:57d1:eb]) by smtp.gmail.com with ESMTPSA id d11sm8844278ejr.58.2021.05.25.05.28.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 May 2021 05:28:08 -0700 (PDT) From: Thomas De Schampheleire To: buildroot@buildroot.org Date: Tue, 25 May 2021 14:27:41 +0200 Message-Id: <20210525122750.5022-7-patrickdepinguin@gmail.com> X-Mailer: git-send-email 2.26.3 In-Reply-To: <20210525122750.5022-1-patrickdepinguin@gmail.com> References: <20210525122750.5022-1-patrickdepinguin@gmail.com> MIME-Version: 1.0 Subject: [Buildroot] [PATCHv3 06/15] package/sysrepo: remove explicit setting of CMAKE_BUILD_TYPE X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Heiko Thiery , =?utf-8?q?Jan_Kundr=C3=A1t?= , Thomas De Schampheleire Errors-To: buildroot-bounces@busybox.net Sender: "buildroot" From: Thomas De Schampheleire sysrepo explicitly sets CMAKE_BUILD_TYPE=Release, ignoring any possible value of BR2_ENABLE_DEBUG (previously) or BR2_ENABLE_RUNTIME_DEBUG (now). With the introduction of BR2_ENABLE_RUNTIME_DEBUG, this change should no longer be necessary. Users that do not wish to have additional runtime debugging just keep BR2_ENABLE_RUNTIME_DEBUG disabled (default value). As the 'Debug' build type enables tests, disable them explicitly. As the 'Debug' build type uses a custom REPO_PATH which does not exist on target, force /etc/sysrepo like in the 'Release' build type. Signed-off-by: Thomas De Schampheleire Acked-by: Arnout Vandecappelle (Essensium/Mind) Acked-by: Heiko Thiery --- package/sysrepo/sysrepo.mk | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/package/sysrepo/sysrepo.mk b/package/sysrepo/sysrepo.mk index f5be29d2c9..c0db05e52c 100644 --- a/package/sysrepo/sysrepo.mk +++ b/package/sysrepo/sysrepo.mk @@ -13,8 +13,10 @@ SYSREPO_DEPENDENCIES = libyang pcre host-sysrepo HOST_SYSREPO_DEPENDENCIES = host-libyang host-pcre SYSREPO_CONF_OPTS = \ - -DCMAKE_BUILD_TYPE=Release \ - -DBUILD_EXAMPLES=$(if $(BR2_PACKAGE_SYSREPO_EXAMPLES),ON,OFF) + -DBUILD_EXAMPLES=$(if $(BR2_PACKAGE_SYSREPO_EXAMPLES),ON,OFF) \ + -DENABLE_TESTS=OFF \ + -DENABLE_VALGRIND_TESTS=OFF \ + -DREPO_PATH=/etc/sysrepo ifeq ($(BR2_TOOLCHAIN_HAS_LIBATOMIC),y) SYSREPO_CONF_OPTS += -DCMAKE_EXE_LINKER_FLAGS=-latomic From patchwork Tue May 25 12:27:42 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas De Schampheleire X-Patchwork-Id: 1483365 Return-Path: X-Original-To: incoming-buildroot@patchwork.ozlabs.org Delivered-To: patchwork-incoming-buildroot@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=busybox.net (client-ip=2605:bc80:3010::133; helo=smtp2.osuosl.org; envelope-from=buildroot-bounces@busybox.net; receiver=) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=e9P9R1Rf; dkim-atps=neutral Received: from smtp2.osuosl.org (smtp2.osuosl.org [IPv6:2605:bc80:3010::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4FqD1C456Rz9sCD for ; Tue, 25 May 2021 22:29:51 +1000 (AEST) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 2D84B402EB; Tue, 25 May 2021 12:29:49 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id E05YbCtwkoWN; Tue, 25 May 2021 12:29:48 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp2.osuosl.org (Postfix) with ESMTP id 76D34403F4; Tue, 25 May 2021 12:29:47 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by ash.osuosl.org (Postfix) with ESMTP id 8FDA31BF396 for ; Tue, 25 May 2021 12:28:13 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 7EFE240513 for ; Tue, 25 May 2021 12:28:13 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Authentication-Results: smtp4.osuosl.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id V4yH-8IKZkay for ; Tue, 25 May 2021 12:28:12 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.8.0 Received: from mail-ej1-x62e.google.com (mail-ej1-x62e.google.com [IPv6:2a00:1450:4864:20::62e]) by smtp4.osuosl.org (Postfix) with ESMTPS id 5456D4054D for ; Tue, 25 May 2021 12:28:12 +0000 (UTC) Received: by mail-ej1-x62e.google.com with SMTP id et19so39990801ejc.4 for ; Tue, 25 May 2021 05:28:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=CwoIEc6hImsHkPW/O0v+0EaKooRJp1BxaKiB19+44iY=; b=e9P9R1RfLDMXneleNnIXecO9XLTftrrdDQA32V+MRDWODjgSCRSpWMLIRskOsFTMmF iKlSpkolZujaHO9RD8y1GVJ+YtfB+W5jUh1MNvln0bU67l9UIcWxPg6jv67TihFffhXM BIAVbjf2cB1O3sZOYmGUCQtCqnUWWzP7KBRLLBXfqBlFszHFH8rV7WEOUcgkpTk9lEV6 mjrcbPOs3mWQu1a0qd9AoIx+MUGRTStXagivFK+uV40UTab53WsPm6Rxe4d6zbIwcoIu GcefQ9Vxh7PAg6kYWiSUDGwleZgZ2WQ71CG4/ctE2kZZDleHBJiNlSlkw3INAJNT2qAe udXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=CwoIEc6hImsHkPW/O0v+0EaKooRJp1BxaKiB19+44iY=; b=av0Oz+QlPlkCsiD7Dq4Anqs9FE1qZPWHxo+h6fMv/iHqjH9iv57SI3kOTGeQISwiMY gbljK7B0OEfYdvRF1zr0P7WINcGgPWnCicLZtYVkn5SBvTkNpq/f2lKBFUBJA1jrZs+F Egc/Rptq1pKCWv5y61mBsAVVkUP5n4yHv7TbBN1llbkTPPZTukDtuvGlXFPof2eBd4OU +YyOvdg6JOnGYo0Jrh+TO1SIM8dmZwajdhnn1P9Mc9TFvRG87s4Qsi3QtkdOjxqCMsHo PfGRtF+yS3fmMJ1JyetnH0bIvOsaJG6WYXC039huCUKOadwdGjN3iUWEQ4HDDPk9TJDY nK/Q== X-Gm-Message-State: AOAM532HOG3FIlQZDLFo4fW3esF9eHoivFadOJkD41UQzB6jAC10FT1d zY0bG+syAS9Dk5zxKvT3Rt23deeO3Nqasg== X-Google-Smtp-Source: ABdhPJzZk/B0UOtFgUo8evNjoD+2MdfHmr0gg6nElYjjLsmXUhq1kGPhP38nJRPUg/2XzadgglNHow== X-Received: by 2002:a17:907:1b11:: with SMTP id mp17mr28861866ejc.1.1621945690493; Tue, 25 May 2021 05:28:10 -0700 (PDT) Received: from localhost (ptr-5gw9txf6g5tndjqqqz.18120a2.ip6.access.telenet.be. [2a02:1810:510:3800:1b15:18e4:57d1:eb]) by smtp.gmail.com with ESMTPSA id c22sm10766650edy.59.2021.05.25.05.28.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 May 2021 05:28:10 -0700 (PDT) From: Thomas De Schampheleire To: buildroot@buildroot.org Date: Tue, 25 May 2021 14:27:42 +0200 Message-Id: <20210525122750.5022-8-patrickdepinguin@gmail.com> X-Mailer: git-send-email 2.26.3 In-Reply-To: <20210525122750.5022-1-patrickdepinguin@gmail.com> References: <20210525122750.5022-1-patrickdepinguin@gmail.com> MIME-Version: 1.0 Subject: [Buildroot] [PATCHv3 07/15] package/boost: use BR2_ENABLE_RUNTIME_DEBUG iso BR2_ENABLE_DEBUG X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas De Schampheleire Errors-To: buildroot-bounces@busybox.net Sender: "buildroot" From: Thomas De Schampheleire BR2_ENABLE_DEBUG should just steer the availability of debug symbols and should have no negative effect on performance. Introduction of 'assert' statements, 'debug'-type builds with additional logging, etc. should be steered by BR2_ENABLE_RUNTIME_DEBUG instead. Signed-off-by: Thomas De Schampheleire --- package/boost/boost.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package/boost/boost.mk b/package/boost/boost.mk index 8d745ecc72..e72ddf897c 100644 --- a/package/boost/boost.mk +++ b/package/boost/boost.mk @@ -95,7 +95,7 @@ BOOST_OPTS += --no-cmake-config \ toolset=gcc \ threading=multi \ abi=$(BOOST_ABI) \ - variant=$(if $(BR2_ENABLE_DEBUG),debug,release) + variant=$(if $(BR2_ENABLE_RUNTIME_DEBUG),debug,release) ifeq ($(BR2_sparc64),y) BOOST_OPTS += architecture=sparc instruction-set=ultrasparc From patchwork Tue May 25 12:27:43 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas De Schampheleire X-Patchwork-Id: 1483366 Return-Path: X-Original-To: incoming-buildroot@patchwork.ozlabs.org Delivered-To: patchwork-incoming-buildroot@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=busybox.net (client-ip=140.211.166.133; helo=smtp2.osuosl.org; envelope-from=buildroot-bounces@busybox.net; receiver=) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=aB1RCsyS; dkim-atps=neutral Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4FqD1R6N8wz9sCD for ; Tue, 25 May 2021 22:30:03 +1000 (AEST) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 069274041C; Tue, 25 May 2021 12:30:02 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id P3XuUYAo_wHo; Tue, 25 May 2021 12:30:01 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp2.osuosl.org (Postfix) with ESMTP id 4A7CF40415; Tue, 25 May 2021 12:30:00 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by ash.osuosl.org (Postfix) with ESMTP id 1AE651BF396 for ; Tue, 25 May 2021 12:28:15 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id C0FEE403D5 for ; Tue, 25 May 2021 12:28:14 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id mtWPEHujXHba for ; Tue, 25 May 2021 12:28:14 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.8.0 Received: from mail-ej1-x631.google.com (mail-ej1-x631.google.com [IPv6:2a00:1450:4864:20::631]) by smtp2.osuosl.org (Postfix) with ESMTPS id 01F6040401 for ; Tue, 25 May 2021 12:28:13 +0000 (UTC) Received: by mail-ej1-x631.google.com with SMTP id p24so45787785ejb.1 for ; Tue, 25 May 2021 05:28:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=u5CMgigYgR7PYhLc/3bEk7b8DJ4BahIwVFTyim9vR68=; b=aB1RCsySNcgvozKYJAqVhDZ+zqrJbS8cpfctqAzMlUFcytUQpLmvsoZ9UXyxlm7SZ5 25KO+cmX6LbqnkUkp1q7jSWY7Ze7wN7rY0zU2nYCWz/mkBxqIUP0GW1VjYP5mOn5GiLA ErYgch+La8qY6UsHbYwdgvRVCwDC6ATFvy4MZOLOB1toAAOzth1RgzfcJSZLXbEA3/id OGYnyiaBb7vJRoO1FpaactO/kXkAIsGfRuvNCJWYSj8ISIZ6wXmhGm19QejJQ0sUfgKP DnLyMUlpurjbeBJaenBWI9rtV3c4PPah+jlWOWukXwCTfm75LT0iP++2cYU+QUpfk/XA s4Ug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=u5CMgigYgR7PYhLc/3bEk7b8DJ4BahIwVFTyim9vR68=; b=Bo0o5xO35mOYZ9MyTsa54wObB91OcZvA5EfwDiEJ7MEMOqyRLCavB8cLzMiu/JAPDF xUAxxNLJdLPnUMRv2p0zF7ZbgB1wrWdttaxKlBGgNPbt/zbjXMqTgc8M5yA2tTsal73Z PMEYkiZR9fgNSJmiB5cL4LohzRZW3Qc9MFvjTrVH9VvIjUV5O3QaYCcMEhJZyL28LwXw sPpXOBLArwxv0f0upWXth1kxK7xKVkkpqx+1/PU3BBxUpNiNyUUVOqm/t94pqO2GO/T1 IlSH3RfYDcfVbB17dhA0j+AmF/70t7WGo9xXU1zKjkayG1scC9HVJlFvcU/axX0M+9zn ZIcw== X-Gm-Message-State: AOAM530EMGMG9JukaWoYWw9QHLNFWEVV0vE2sjZcMWO9I7h1FrR7hx6x 56M9p+fMwUrRWCke/RABvstIZhvSgeWpxA== X-Google-Smtp-Source: ABdhPJyW0TSaJc2AsTCMaDa5g5oPvLZh2X7k6aEf83lHbQ+mWMwV6b0M17j9Rf8ysKjhRgGXwzoNNQ== X-Received: by 2002:a17:906:1b57:: with SMTP id p23mr28890610ejg.176.1621945692280; Tue, 25 May 2021 05:28:12 -0700 (PDT) Received: from localhost (ptr-5gw9txf6g5tndjqqqz.18120a2.ip6.access.telenet.be. [2a02:1810:510:3800:1b15:18e4:57d1:eb]) by smtp.gmail.com with ESMTPSA id p11sm4242284edt.22.2021.05.25.05.28.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 May 2021 05:28:11 -0700 (PDT) From: Thomas De Schampheleire To: buildroot@buildroot.org Date: Tue, 25 May 2021 14:27:43 +0200 Message-Id: <20210525122750.5022-9-patrickdepinguin@gmail.com> X-Mailer: git-send-email 2.26.3 In-Reply-To: <20210525122750.5022-1-patrickdepinguin@gmail.com> References: <20210525122750.5022-1-patrickdepinguin@gmail.com> MIME-Version: 1.0 Subject: [Buildroot] [PATCHv3 08/15] package/oracle-mysql: use BR2_ENABLE_RUNTIME_DEBUG iso BR2_ENABLE_DEBUG X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas De Schampheleire Errors-To: buildroot-bounces@busybox.net Sender: "buildroot" From: Thomas De Schampheleire BR2_ENABLE_DEBUG should just steer the availability of debug symbols and should have no negative effect on performance. Introduction of 'assert' statements, 'debug'-type builds with additional logging, etc. should be steered by BR2_ENABLE_RUNTIME_DEBUG instead. Signed-off-by: Thomas De Schampheleire Acked-by: Arnout Vandecappelle (Essensium/Mind) --- package/oracle-mysql/oracle-mysql.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package/oracle-mysql/oracle-mysql.mk b/package/oracle-mysql/oracle-mysql.mk index ccfa40cfb1..e7d6354ed8 100644 --- a/package/oracle-mysql/oracle-mysql.mk +++ b/package/oracle-mysql/oracle-mysql.mk @@ -95,7 +95,7 @@ ORACLE_MYSQL_CONF_OPTS += \ # Debugging is only available for the server, so no need for # this if-block outside of the server if-block -ifeq ($(BR2_ENABLE_DEBUG),y) +ifeq ($(BR2_ENABLE_RUNTIME_DEBUG),y) ORACLE_MYSQL_CONF_OPTS += --with-debug=full else ORACLE_MYSQL_CONF_OPTS += --without-debug From patchwork Tue May 25 12:27:44 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas De Schampheleire X-Patchwork-Id: 1483367 Return-Path: X-Original-To: incoming-buildroot@patchwork.ozlabs.org Delivered-To: patchwork-incoming-buildroot@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=busybox.net (client-ip=2605:bc80:3010::136; helo=smtp3.osuosl.org; envelope-from=buildroot-bounces@busybox.net; receiver=) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=t3TPOMfN; dkim-atps=neutral Received: from smtp3.osuosl.org (smtp3.osuosl.org [IPv6:2605:bc80:3010::136]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4FqD1h67kFz9sCD for ; Tue, 25 May 2021 22:30:16 +1000 (AEST) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 93DC060AEF; Tue, 25 May 2021 12:30:14 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id gIFFOj80bK4H; Tue, 25 May 2021 12:30:13 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp3.osuosl.org (Postfix) with ESMTP id EE33160AEE; Tue, 25 May 2021 12:30:12 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id 6985B1BF396 for ; Tue, 25 May 2021 12:28:16 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 641E383C82 for ; Tue, 25 May 2021 12:28:16 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Authentication-Results: smtp1.osuosl.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id NZxNA7TQxqmd for ; Tue, 25 May 2021 12:28:15 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.8.0 Received: from mail-ed1-x529.google.com (mail-ed1-x529.google.com [IPv6:2a00:1450:4864:20::529]) by smtp1.osuosl.org (Postfix) with ESMTPS id 9F78F83C5E for ; Tue, 25 May 2021 12:28:15 +0000 (UTC) Received: by mail-ed1-x529.google.com with SMTP id t3so35942995edc.7 for ; Tue, 25 May 2021 05:28:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=HhE5WlZVKsNmOF8rUx6DL1WzuJ5KuelxFJ/Qi9sH9QQ=; b=t3TPOMfNdY8QFmYL8dmiDmtzBTyh5i8uv3x7sThs/D7kjE+IhFcbhidGkd13UsclcH Iij0K+pEyNkMN1U+Yevlg0vchjlfkMDXVYVJMueDLhRqYP+aV2VMHTDUZH1cxB9vaFye BBi0xs+FsGN4mGTUbXylr3wbiOn3ddB6U8c5EigIXpBfImVlk7SihzRoAygzF/5s1Ono nQayk317+zyuYz5k3bP2qXYCSn47f87yWpHJwGeRWJz5gqFAeIRfzyJkTn07dfWvRg6w RNu7YcxmF4QQJnICADL7r7sf4a9BNY377rxVjvUweWMpHoluiwmwfBxUhMSj82jBvLiv QgHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=HhE5WlZVKsNmOF8rUx6DL1WzuJ5KuelxFJ/Qi9sH9QQ=; b=HBXyxMvpPWBbBJMoBXUB3As8VtPl2D5JdcfmRbMupyVeY0vS9quWTuZYGMdkGg5/LQ EwY6Y6Srg6jmSIEMhspL8UgA/BK2IvU9fFfOODlrwR7aoMusskfU5PJoBZjXnF2BHWfb 3rj5BTpRNQW/f12W+0s1jgCq5KBHDmyTy3jTAGhXAR1H9Qmv6XJodUj88s3u5HrhAHaP S1D1xtZDk7ilMob4y203bZSf4z8LODzeWUrSIcof7Z+1VmGUf6pjjqLcvrXXjvCxBo0w LRLfC6apEQAF8VhooP3a09Dot3d79+MfXhBDY/gGp8zaVHX5dTufr2v+EIevyhJeI+16 1obw== X-Gm-Message-State: AOAM530e/mwGZrStedsydSAK7pe1MbVxzskwJPlpQqB4mItcIl+BTVsU huBIzQqLXCfkYeXdxtJgqU+6iDa+0+yqrQ== X-Google-Smtp-Source: ABdhPJxbNUv6TZx6AjXofTZh1rQEZ/LlK/WLvALVSYC3maV7RlQJ2Q5mNDNPCk57W/FCDgO0xtWFNA== X-Received: by 2002:a05:6402:1713:: with SMTP id y19mr31229534edu.286.1621945693902; Tue, 25 May 2021 05:28:13 -0700 (PDT) Received: from localhost (ptr-5gw9txf6g5tndjqqqz.18120a2.ip6.access.telenet.be. [2a02:1810:510:3800:1b15:18e4:57d1:eb]) by smtp.gmail.com with ESMTPSA id s26sm10677637edr.97.2021.05.25.05.28.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 May 2021 05:28:13 -0700 (PDT) From: Thomas De Schampheleire To: buildroot@buildroot.org Date: Tue, 25 May 2021 14:27:44 +0200 Message-Id: <20210525122750.5022-10-patrickdepinguin@gmail.com> X-Mailer: git-send-email 2.26.3 In-Reply-To: <20210525122750.5022-1-patrickdepinguin@gmail.com> References: <20210525122750.5022-1-patrickdepinguin@gmail.com> MIME-Version: 1.0 Subject: [Buildroot] [PATCHv3 09/15] package/qt5: use BR2_ENABLE_RUNTIME_DEBUG iso BR2_ENABLE_DEBUG X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Seiderer , Julien Corjon , Thomas De Schampheleire Errors-To: buildroot-bounces@busybox.net Sender: "buildroot" From: Thomas De Schampheleire BR2_ENABLE_DEBUG should just steer the availability of debug symbols and should have no negative effect on performance. Introduction of 'assert' statements, 'debug'-type builds with additional logging, etc. should be steered by BR2_ENABLE_RUNTIME_DEBUG instead. Signed-off-by: Thomas De Schampheleire Acked-by: Arnout Vandecappelle (Essensium/Mind) --- package/qt5/qt5base/qt5base.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package/qt5/qt5base/qt5base.mk b/package/qt5/qt5base/qt5base.mk index 84e9fa4edb..8b55aa3098 100644 --- a/package/qt5/qt5base/qt5base.mk +++ b/package/qt5/qt5base/qt5base.mk @@ -86,7 +86,7 @@ else QT5BASE_CONFIGURE_OPTS += -no-gbm endif -ifeq ($(BR2_ENABLE_DEBUG),y) +ifeq ($(BR2_ENABLE_RUNTIME_DEBUG),y) QT5BASE_CONFIGURE_OPTS += -debug else QT5BASE_CONFIGURE_OPTS += -release From patchwork Tue May 25 12:27:45 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas De Schampheleire X-Patchwork-Id: 1483368 Return-Path: X-Original-To: incoming-buildroot@patchwork.ozlabs.org Delivered-To: patchwork-incoming-buildroot@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=busybox.net (client-ip=2605:bc80:3010::133; helo=smtp2.osuosl.org; envelope-from=buildroot-bounces@busybox.net; receiver=) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=GBB2g7B+; dkim-atps=neutral Received: from smtp2.osuosl.org (smtp2.osuosl.org [IPv6:2605:bc80:3010::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4FqD1x2w6Jz9sRN for ; Tue, 25 May 2021 22:30:29 +1000 (AEST) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 2D14340375; Tue, 25 May 2021 12:30:27 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id xXWpBwPMaC8L; Tue, 25 May 2021 12:30:26 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp2.osuosl.org (Postfix) with ESMTP id 8CE214018E; Tue, 25 May 2021 12:30:25 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by ash.osuosl.org (Postfix) with ESMTP id 121D21BF396 for ; Tue, 25 May 2021 12:28:18 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 00E8C403D5 for ; Tue, 25 May 2021 12:28:18 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id w99WR3zoNYlW for ; Tue, 25 May 2021 12:28:17 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.8.0 Received: from mail-ej1-x635.google.com (mail-ej1-x635.google.com [IPv6:2a00:1450:4864:20::635]) by smtp2.osuosl.org (Postfix) with ESMTPS id 497FD4040C for ; Tue, 25 May 2021 12:28:17 +0000 (UTC) Received: by mail-ej1-x635.google.com with SMTP id et19so39991204ejc.4 for ; Tue, 25 May 2021 05:28:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=hg8zGZWqfBuoIevb4TzwnQexwga88EtScc4cu3RqgJ4=; b=GBB2g7B+qS7Y5jpmnixlUPBFexWz4XXxLMy+jn9J0bhZMHdS9XkWIGzW2DPuqRspJX EgncL2fb6F440FdqQm1W6nF/7aMvAmv+QTE/Zpl/DilaX2mnYmEsDHhzDVpUpVbHiCnp FVzwtwqrjhoRu2gmgreOfMjOKkc1JokCYUzhev3hHeeUpAuHuxuJRWI5z/AzvOuZbQGK l+2bySE1jYYspXHFyklaEYZ4/FJwlBK86iicn/+UEnoFAf+u+rK48WCmgHLQY63MX2qc x8MvI2MPnMu/5RdzbgjmJ41F3mqdOrfDKe7pxjfw890NAlqf+QrjdWEyubwV+d8JbJ+N whzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=hg8zGZWqfBuoIevb4TzwnQexwga88EtScc4cu3RqgJ4=; b=IkPVjxxYCmwOK7PwKgila4y3Ipckt7vFvYG3S11ZM/eAC9cHkEIlsEOIHH1zCNVAas KByED56CJOzc/HntmZB4Gw5+hymhN6HHqrBUOlhcKr0wBBE/5oqNrN+17962x87jEdPc BjJ76ptDCYjyOtZB8zVUBIWm7cR/q+OEh9kBErUhOu6o450BAIfbO2fgU1zGVv2/LJVh uLS67Ee5GxhM7/NYWCe+spcWn8HHS4V+WXkpjvwBntxp06XcJ2jWiH7b/VPk+lwUHo+0 iu7vjA5dR1I1/s/SclQu4xolWhkSJrcdB/4PLlBPeYWv5yeCfipH2TMe5XDj1sAw5WlT ZE3Q== X-Gm-Message-State: AOAM533DMdAFNcCNZX2N8ctRVQboXGK6/7GoRlkqv5jWo0GYynnKWsim zrqqP5MKkh07+jjlPtd7TQbgF7eJtpu64w== X-Google-Smtp-Source: ABdhPJwk/wcGtMqnmTRyNUCq1Lwp1s08PvWEU6GstiXthI1aSaNM+y7Bq4FBTsY5HkqIbcoENxbISQ== X-Received: by 2002:a17:906:4c54:: with SMTP id d20mr29094394ejw.513.1621945695573; Tue, 25 May 2021 05:28:15 -0700 (PDT) Received: from localhost (ptr-5gw9txf6g5tndjqqqz.18120a2.ip6.access.telenet.be. [2a02:1810:510:3800:1b15:18e4:57d1:eb]) by smtp.gmail.com with ESMTPSA id v23sm10714197edx.31.2021.05.25.05.28.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 May 2021 05:28:15 -0700 (PDT) From: Thomas De Schampheleire To: buildroot@buildroot.org Date: Tue, 25 May 2021 14:27:45 +0200 Message-Id: <20210525122750.5022-11-patrickdepinguin@gmail.com> X-Mailer: git-send-email 2.26.3 In-Reply-To: <20210525122750.5022-1-patrickdepinguin@gmail.com> References: <20210525122750.5022-1-patrickdepinguin@gmail.com> MIME-Version: 1.0 Subject: [Buildroot] [PATCHv3 10/15] package/ripgrep: use BR2_ENABLE_RUNTIME_DEBUG iso BR2_ENABLE_DEBUG X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sam Voss , Thomas De Schampheleire Errors-To: buildroot-bounces@busybox.net Sender: "buildroot" From: Thomas De Schampheleire BR2_ENABLE_DEBUG should just steer the availability of debug symbols and should have no negative effect on performance. Introduction of 'assert' statements, 'debug'-type builds with additional logging, etc. should be steered by BR2_ENABLE_RUNTIME_DEBUG instead. Signed-off-by: Thomas De Schampheleire Acked-by: Arnout Vandecappelle (Essensium/Mind) --- package/ripgrep/ripgrep.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package/ripgrep/ripgrep.mk b/package/ripgrep/ripgrep.mk index 9dd8d58de1..c3c12fd185 100644 --- a/package/ripgrep/ripgrep.mk +++ b/package/ripgrep/ripgrep.mk @@ -18,7 +18,7 @@ RIPGREP_CARGO_OPTS = \ --target=$(RUSTC_TARGET_NAME) \ --manifest-path=$(@D)/Cargo.toml -ifeq ($(BR2_ENABLE_DEBUG),y) +ifeq ($(BR2_ENABLE_RUNTIME_DEBUG),y) RIPGREP_CARGO_BIN_SUBDIR = debug else RIPGREP_CARGO_OPTS += --release From patchwork Tue May 25 12:27:46 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas De Schampheleire X-Patchwork-Id: 1483369 Return-Path: X-Original-To: incoming-buildroot@patchwork.ozlabs.org Delivered-To: patchwork-incoming-buildroot@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=busybox.net (client-ip=140.211.166.137; helo=smtp4.osuosl.org; envelope-from=buildroot-bounces@busybox.net; receiver=) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=FIQjtS0G; dkim-atps=neutral Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4FqD2D2hs6z9sCD for ; Tue, 25 May 2021 22:30:43 +1000 (AEST) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 0AED34027E; Tue, 25 May 2021 12:30:40 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 40imC4qjBdnQ; Tue, 25 May 2021 12:30:39 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp4.osuosl.org (Postfix) with ESMTP id 23D404050B; Tue, 25 May 2021 12:30:38 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by ash.osuosl.org (Postfix) with ESMTP id 10CFB1BF990 for ; Tue, 25 May 2021 12:28:20 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id C0C0D60ACB for ; Tue, 25 May 2021 12:28:19 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Authentication-Results: smtp3.osuosl.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id p2Si84vvQ6nx for ; Tue, 25 May 2021 12:28:19 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.8.0 Received: from mail-ed1-x532.google.com (mail-ed1-x532.google.com [IPv6:2a00:1450:4864:20::532]) by smtp3.osuosl.org (Postfix) with ESMTPS id 0403960905 for ; Tue, 25 May 2021 12:28:18 +0000 (UTC) Received: by mail-ed1-x532.google.com with SMTP id a25so35966560edr.12 for ; Tue, 25 May 2021 05:28:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=CaPRF/mXtF/k6hTLdmBV/G6B+HC0YBJgBE+fjqcjkkg=; b=FIQjtS0G8XYerUSAOz21mM1VELyw8VWJfxSR9Dls/d2IsZRfZ7PqGJpzbXLyzAoit3 GnRW+E/1r/s7EJUUbkRxig0GVZA1oXBgTjohdRP3e7jD0u/IG7dHHtIZ4t4VE6g93DlF uP0iUcUgOwr0Zcq+ElF/c/sS0tlAh1ymNsre8B0EkxKuIYIciU1AsxFyb1R/pT+kvj/E x9u1SmpV0Y3326fVCNtUjm2xqrLWulaXsqnd9uFhZ12+cZyN2hX34hSZ4Mu8f0gmOFPv EY/SAGlA04hJb/8vezxd5VJr34qvZrI4V+19NZqgaV9/w81P11GBGdAkWm8oDwE4EPKK gu6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=CaPRF/mXtF/k6hTLdmBV/G6B+HC0YBJgBE+fjqcjkkg=; b=ILRfqyS0mj9UJFAjXyjEpvZRfimDvV1vojLlYtCx6kvWaK9usi+MHbhMywh+8LKvZ0 SOiWyimMC4LFJRSDvWrqFvcaJDgugsEAIIyo/MbS0LEvHqvJ2S9PCXDVKPBZkcWdIv7y 2DGxOOKJGXuNj2nnu4EEGlzEvmf6OF/pDAPAG7TU9VL1l1Typ46axOKqgCdkKz3eLFQj W8jMnETRJhjQICvnx7Bp6DXZdgtuT6XfqSqj59u6G9BNGFG+fkHHtBmcRVk6BODrsl0j UyELeQ/ChfINnp3hI8eS1SGwwWZmhjYarw+mgJ8QWq37+dD917D6J/OYtJLnAdYxq8yM pT7A== X-Gm-Message-State: AOAM530jzL1dcPsOxQBPoX1MySXGwcoBPA1fMSQldRzpDFO0uAfgWMcB hNJBfXWfX4BJzg8CAgo1pyAETAi2hkjgvw== X-Google-Smtp-Source: ABdhPJwhWN2KH4HJOGCmnlCjVXZRTKsNXZ/cqhw8JuDsNgQjJSZO5m8Aj6t4P2/rWUrjPYfhxilWQg== X-Received: by 2002:aa7:c718:: with SMTP id i24mr31277783edq.43.1621945697312; Tue, 25 May 2021 05:28:17 -0700 (PDT) Received: from localhost (ptr-5gw9txf6g5tndjqqqz.18120a2.ip6.access.telenet.be. [2a02:1810:510:3800:1b15:18e4:57d1:eb]) by smtp.gmail.com with ESMTPSA id gu16sm9097867ejb.88.2021.05.25.05.28.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 May 2021 05:28:16 -0700 (PDT) From: Thomas De Schampheleire To: buildroot@buildroot.org Date: Tue, 25 May 2021 14:27:46 +0200 Message-Id: <20210525122750.5022-12-patrickdepinguin@gmail.com> X-Mailer: git-send-email 2.26.3 In-Reply-To: <20210525122750.5022-1-patrickdepinguin@gmail.com> References: <20210525122750.5022-1-patrickdepinguin@gmail.com> MIME-Version: 1.0 Subject: [Buildroot] [PATCHv3 11/15] package/sofia-sip: use BR2_ENABLE_RUNTIME_DEBUG iso BR2_ENABLE_DEBUG X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Gregory Dymarek , Thomas De Schampheleire Errors-To: buildroot-bounces@busybox.net Sender: "buildroot" From: Thomas De Schampheleire BR2_ENABLE_DEBUG should just steer the availability of debug symbols and should have no negative effect on performance. Introduction of 'assert' statements, 'debug'-type builds with additional logging, etc. should be steered by BR2_ENABLE_RUNTIME_DEBUG instead. Signed-off-by: Thomas De Schampheleire --- package/sofia-sip/sofia-sip.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package/sofia-sip/sofia-sip.mk b/package/sofia-sip/sofia-sip.mk index 5c383400ff..cb867ba0dc 100644 --- a/package/sofia-sip/sofia-sip.mk +++ b/package/sofia-sip/sofia-sip.mk @@ -30,7 +30,7 @@ SOFIA_SIP_CONF_OPTS += \ --without-openssl endif -ifeq ($(BR2_ENABLE_DEBUG),y) +ifeq ($(BR2_ENABLE_RUNTIME_DEBUG),y) SOFIA_SIP_CONF_OPTS += --enable-ndebug endif From patchwork Tue May 25 12:27:47 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas De Schampheleire X-Patchwork-Id: 1483370 Return-Path: X-Original-To: incoming-buildroot@patchwork.ozlabs.org Delivered-To: patchwork-incoming-buildroot@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=busybox.net (client-ip=2605:bc80:3010::136; helo=smtp3.osuosl.org; envelope-from=buildroot-bounces@busybox.net; receiver=) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=Vb4nRt9M; dkim-atps=neutral Received: from smtp3.osuosl.org (smtp3.osuosl.org [IPv6:2605:bc80:3010::136]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4FqD2R0ssjz9sRN for ; Tue, 25 May 2021 22:30:55 +1000 (AEST) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 1762660ADD; Tue, 25 May 2021 12:30:53 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id oMwps9jXnkjc; Tue, 25 May 2021 12:30:52 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp3.osuosl.org (Postfix) with ESMTP id 5EE1560ACD; Tue, 25 May 2021 12:30:51 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by ash.osuosl.org (Postfix) with ESMTP id 6387B1BF396 for ; Tue, 25 May 2021 12:28:22 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 8678B403D5 for ; Tue, 25 May 2021 12:28:21 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Authentication-Results: smtp2.osuosl.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id SNZj_ZsupR3C for ; Tue, 25 May 2021 12:28:21 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.8.0 Received: from mail-ed1-x534.google.com (mail-ed1-x534.google.com [IPv6:2a00:1450:4864:20::534]) by smtp2.osuosl.org (Postfix) with ESMTPS id D092C403F4 for ; Tue, 25 May 2021 12:28:20 +0000 (UTC) Received: by mail-ed1-x534.google.com with SMTP id y7so18438734eda.2 for ; Tue, 25 May 2021 05:28:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=g6JSEEy57jfwF8tYbEIgxRL3DCwXdoB3oKzpG6zQZ/o=; b=Vb4nRt9MpM406BgmnJm5BAgZM4NJY8KbDVcvWbnsyCf8uTAiKYz/KAuN5jlmNKSJSE AhZugJNTx+BjeQMVtgrlMf2FEB97sOW4R7+c1Jd70ak7GjPlM7KXs5Z+d4+0bvjyifgz hpdCh/ZiVkb+8/5xfPgqkgN3pd4Nvr4DS54NXP6ectauesMka+ZedESGqczHvat9U8hs nL+Q10hCtp+5CvzdQ0Pp6+waiHIrAYUzXCnz92IcEBFMpHYOsWoFbJuKbTRJFSYW7b+m PY2a00qk2Mt1/vMkCFDvKAKglcQqeLkm3E3cD4uO5fHBQlCHyrJ7bjMrmn5BHm/Mg6Qa X5Lg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=g6JSEEy57jfwF8tYbEIgxRL3DCwXdoB3oKzpG6zQZ/o=; b=nHsss3h49hTYJsEdxCvqrAouunbNqNgDroXZUM5aPLKaWeW/3CqKgK23agtEdEU3+5 kJJwQwBOyt/XObpkncPYrDtHMYyKAK/0GalTorRa29zeJqAd+xrMLg2m8sXMeKyXTewv IktdJ3nJThF9Sk+2GAFXYv3Qh3HPUUq/1Dr1jjGqvqUmWcfQO4zy9YrD+aO2k25qPbA0 9AlET+gWr/QMxBqtbYk8dLeA7HGzWnIiAQM4UxB/uvn2lducs6wPTkYs2LkzaiOtfq7k fiuwZl4U1j6CWl11+sIDJwVjS8b7BNAbZcdmyUSl63jJvgk5LdNLQjSvs6RKakXs7GqO etfA== X-Gm-Message-State: AOAM531IDORqq70IDikgQVKMcL9GKz33ckBw7Xq9iyFHOC5K4vtLzXIF tLRi8G77W6GoHxy7UylqG7X9OKuT9S8kZg== X-Google-Smtp-Source: ABdhPJwdtl6R1sijoJ9TPDqCNSKUpcnpF8vnDtXXJjKBtBgSH8JeLoolSObUMc1exArN82ExJuAsCQ== X-Received: by 2002:aa7:cb84:: with SMTP id r4mr31282448edt.187.1621945699041; Tue, 25 May 2021 05:28:19 -0700 (PDT) Received: from localhost (ptr-5gw9txf6g5tndjqqqz.18120a2.ip6.access.telenet.be. [2a02:1810:510:3800:1b15:18e4:57d1:eb]) by smtp.gmail.com with ESMTPSA id j14sm9039901eja.49.2021.05.25.05.28.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 May 2021 05:28:18 -0700 (PDT) From: Thomas De Schampheleire To: buildroot@buildroot.org Date: Tue, 25 May 2021 14:27:47 +0200 Message-Id: <20210525122750.5022-13-patrickdepinguin@gmail.com> X-Mailer: git-send-email 2.26.3 In-Reply-To: <20210525122750.5022-1-patrickdepinguin@gmail.com> References: <20210525122750.5022-1-patrickdepinguin@gmail.com> MIME-Version: 1.0 Subject: [Buildroot] [PATCHv3 12/15] package/uclibc: use BR2_ENABLE_RUNTIME_DEBUG iso BR2_ENABLE_DEBUG X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas De Schampheleire Errors-To: buildroot-bounces@busybox.net Sender: "buildroot" From: Thomas De Schampheleire BR2_ENABLE_DEBUG should just steer the availability of debug symbols and should have no negative effect on performance. Introduction of 'assert' statements, 'debug'-type builds with additional logging, etc. should be steered by BR2_ENABLE_RUNTIME_DEBUG instead. Signed-off-by: Thomas De Schampheleire --- package/uclibc/uclibc.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package/uclibc/uclibc.mk b/package/uclibc/uclibc.mk index 3d253d93bc..61bdbd50a0 100644 --- a/package/uclibc/uclibc.mk +++ b/package/uclibc/uclibc.mk @@ -205,7 +205,7 @@ endif # # Debug # -ifeq ($(BR2_ENABLE_DEBUG),y) +ifeq ($(BR2_ENABLE_RUNTIME_DEBUG),y) define UCLIBC_DEBUG_CONFIG $(call KCONFIG_ENABLE_OPT,DODEBUG) endef From patchwork Tue May 25 12:27:48 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas De Schampheleire X-Patchwork-Id: 1483371 Return-Path: X-Original-To: incoming-buildroot@patchwork.ozlabs.org Delivered-To: patchwork-incoming-buildroot@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=busybox.net (client-ip=2605:bc80:3010::136; helo=smtp3.osuosl.org; envelope-from=buildroot-bounces@busybox.net; receiver=) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=Ibhxif7Q; dkim-atps=neutral Received: from smtp3.osuosl.org (smtp3.osuosl.org [IPv6:2605:bc80:3010::136]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4FqD2g6YTVz9sRN for ; Tue, 25 May 2021 22:31:07 +1000 (AEST) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id A744660AFF; Tue, 25 May 2021 12:31:05 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id P9KXgSOi7O9K; Tue, 25 May 2021 12:31:04 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp3.osuosl.org (Postfix) with ESMTP id DB4AC60AEE; Tue, 25 May 2021 12:31:03 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by ash.osuosl.org (Postfix) with ESMTP id 57AD71BF396 for ; Tue, 25 May 2021 12:28:23 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 46A9D403D5 for ; Tue, 25 May 2021 12:28:23 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Authentication-Results: smtp2.osuosl.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id aTFD9NV_4LDA for ; Tue, 25 May 2021 12:28:22 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.8.0 Received: from mail-ej1-x630.google.com (mail-ej1-x630.google.com [IPv6:2a00:1450:4864:20::630]) by smtp2.osuosl.org (Postfix) with ESMTPS id 90427400E4 for ; Tue, 25 May 2021 12:28:22 +0000 (UTC) Received: by mail-ej1-x630.google.com with SMTP id b9so11826294ejc.13 for ; Tue, 25 May 2021 05:28:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=opCamjBwUbHLSgbrGaACImRshpzBXWQvoPOjCMvZdM8=; b=Ibhxif7Q5J1LsKR6aTpjYerfffVnpwKhLINfLGqiavpxX7BTC9T3NJSSt3iz29K0nQ /1ZMKBRfD7oAGdbYPbRUBDOKtjm7QfHjSp32SIwVn7Drs2/aCBdb+42AFbfLHxayHWA9 1pCxHq+U24D6z8QyV3fNq2GDALKu5LNszWUEt8Bh5ONJFnM8j41l31sxVJDqAQ46hXl0 J2Yz/RKsxhRNxZNdWla6ndvcYDzxWly19xzVgsWPLrY6g4bONxWkMfGXx3BKqAedQZWc U9FsbVQezXHO1KvBK19pHzggDyVG1Is8q/gKAllHqjI4zXa75pBxrSXn7lChj3j3rcRf TZQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=opCamjBwUbHLSgbrGaACImRshpzBXWQvoPOjCMvZdM8=; b=BNbKQLuYcNXhodTxw3mFNjJ5TfFkBfaMH4SxQ0mbySDzd1p5QndAqfSokd3pVYTPT5 /W5Bnw0UvO3BSLH0EZuXfUaTiHFy0/lg/YRRBbbDX9h2oNSMTxRlXctTiQDYQCtEVadU iSFmQXKD99057DMBk6Iu0sNOfA1wDoa9pCOCy9PTsyZPM+HXTXVMJRC99XHHlppu2Jsg N1QgRUR8YPPqoLdDgiLhxTQlDJm5UhBui3u6Wv88zxIoVTERlmdDX71fUGZNmFbjmB66 lfZ+mQgXEr6YZeq86WoNQfdMzpRaGyuNoSVFlvO9+bD25yFEYAmXfSOR6Q2tf5D/zsPY B1Iw== X-Gm-Message-State: AOAM5307/l3QJG567R7UPUUghEDR7VhCTst3BXP5hpThWPHiymSvqkGB l0VPyI5uYhhiW4IRoWMOz6hRZ2QGj247Cg== X-Google-Smtp-Source: ABdhPJyCztH16de9FPeRNv0GswfeJe3e+Ryl0lXQmHLJcgqoMMJ7wHMjxJRSR325+GJv3gAW5XpSGA== X-Received: by 2002:a17:906:2da1:: with SMTP id g1mr28211344eji.47.1621945700840; Tue, 25 May 2021 05:28:20 -0700 (PDT) Received: from localhost (ptr-5gw9txf6g5tndjqqqz.18120a2.ip6.access.telenet.be. [2a02:1810:510:3800:1b15:18e4:57d1:eb]) by smtp.gmail.com with ESMTPSA id yh21sm9188298ejb.124.2021.05.25.05.28.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 May 2021 05:28:20 -0700 (PDT) From: Thomas De Schampheleire To: buildroot@buildroot.org Date: Tue, 25 May 2021 14:27:48 +0200 Message-Id: <20210525122750.5022-14-patrickdepinguin@gmail.com> X-Mailer: git-send-email 2.26.3 In-Reply-To: <20210525122750.5022-1-patrickdepinguin@gmail.com> References: <20210525122750.5022-1-patrickdepinguin@gmail.com> MIME-Version: 1.0 Subject: [Buildroot] [PATCHv3 13/15] package/zmqpp: use BR2_ENABLE_RUNTIME_DEBUG iso BR2_ENABLE_DEBUG X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Simon Dawson , Thomas De Schampheleire Errors-To: buildroot-bounces@busybox.net Sender: "buildroot" From: Thomas De Schampheleire BR2_ENABLE_DEBUG should just steer the availability of debug symbols and should have no negative effect on performance. Introduction of 'assert' statements, 'debug'-type builds with additional logging, etc. should be steered by BR2_ENABLE_RUNTIME_DEBUG instead. Signed-off-by: Thomas De Schampheleire --- package/zmqpp/zmqpp.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package/zmqpp/zmqpp.mk b/package/zmqpp/zmqpp.mk index 3cd19d644a..cfef9874d0 100644 --- a/package/zmqpp/zmqpp.mk +++ b/package/zmqpp/zmqpp.mk @@ -19,7 +19,7 @@ ZMQPP_LDFLAGS = $(TARGET_LDFLAGS) -lpthread # -ffast-math -finline-functions -fomit-frame-pointer are disabled, # so only set CONFIG for the non-affected cases. ifneq ($(BR2_or1k):$(BR2_TOOLCHAIN_GCC_AT_LEAST_6),y:) -ZMQPP_CONFIG = $(if $(BR2_ENABLE_DEBUG),debug,release) +ZMQPP_CONFIG = $(if $(BR2_ENABLE_RUNTIME_DEBUG),debug,release) endif ifeq ($(BR2_TOOLCHAIN_HAS_LIBATOMIC),y) From patchwork Tue May 25 12:27:49 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas De Schampheleire X-Patchwork-Id: 1483372 Return-Path: X-Original-To: incoming-buildroot@patchwork.ozlabs.org Delivered-To: patchwork-incoming-buildroot@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=busybox.net (client-ip=140.211.166.136; helo=smtp3.osuosl.org; envelope-from=buildroot-bounces@busybox.net; receiver=) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=VgqoLX9v; dkim-atps=neutral Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4FqD2v622Vz9sCD for ; Tue, 25 May 2021 22:31:19 +1000 (AEST) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 651CE60AE7; Tue, 25 May 2021 12:31:18 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id OTNVnZGRU9t4; Tue, 25 May 2021 12:31:17 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp3.osuosl.org (Postfix) with ESMTP id A12C460AEA; Tue, 25 May 2021 12:31:16 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by ash.osuosl.org (Postfix) with ESMTP id EF8AB1BF396 for ; Tue, 25 May 2021 12:28:24 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id EC4D860A4E for ; Tue, 25 May 2021 12:28:24 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id tPdDLrMgRxml for ; Tue, 25 May 2021 12:28:24 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.8.0 Received: from mail-ed1-x52d.google.com (mail-ed1-x52d.google.com [IPv6:2a00:1450:4864:20::52d]) by smtp3.osuosl.org (Postfix) with ESMTPS id 396BA60905 for ; Tue, 25 May 2021 12:28:24 +0000 (UTC) Received: by mail-ed1-x52d.google.com with SMTP id o5so26982626edc.5 for ; Tue, 25 May 2021 05:28:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=KCNs2cYhwPVIOx+ySXRNkbeZEYymT7lRa8kJlLeSOb0=; b=VgqoLX9vcvEFIWUvMOJfoc8nt6dyLBTEjpYn8eJe89Ty84NcVzIwchUvSfG3kq864x MV98RW1THZafp4OMS0tmK7byzhVjR/Pg9xRSG0cUSr2zhCA3L038P95hyn4lD7VXY+UT kSw7KdA/m9JzGzXITR7QDYtcGp/DjaayjB2FsPgkFzAvYDoxJwihvP9VSdNI3E5f4Lze SkMotd19eLT9yqCWjGvE8NsZKI4CAnt/RjRHAdnoopbqsDHQBcEPbe5Le80wZfb4FnGT zskIKhPvb88NbuG3f4GD5UxFvR8y+FnqP8XK64BQ1KpaKSfyvpLcz4Fzmw7OKS52KlGQ fNiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=KCNs2cYhwPVIOx+ySXRNkbeZEYymT7lRa8kJlLeSOb0=; b=qV/9XFK93OKPuaTUZcdxmOEXC56rq8zZSLOAN+SVuntqLctIUVmMVAzUuC8ZyxIGub H4AGFviejOytr26Akbo+dUjotBj8Mqc4n9hpvj7kh6SaglNdmSoQBiKySn1+uGSbgtM4 LLmy6T+IKNE0sq0KlLBnn0x27BrDGJzar2E7iarMbWhV6KE91IKp+h6crVxOv4lS/3SA vbX45om+zO+NzIKRATIwIXd71p6WAJHobGXbx3mom7drbgExPThIYG2eYGtayUXj0xXk icJGvRXMs9Os7Locdn8FzwzUHwuSzYKBD7nSkcWaoEWnNIPP9adddkBhPBQHvItr7fF7 /52w== X-Gm-Message-State: AOAM530wxMZIAZft1gNCkYLHnJImI2RlukuOL1Yf2+vAcNkh1YmClMWH jROBC3VF15maB3YgXaCpdljrYsKZnBiJmA== X-Google-Smtp-Source: ABdhPJzNuKQWOgVqg8yEp2bl72w7qQiEZdGGjrkyJdzBImo4rSOZlDgoKyWJ0+Ejees6YguspWINkA== X-Received: by 2002:aa7:cc19:: with SMTP id q25mr30900189edt.56.1621945702504; Tue, 25 May 2021 05:28:22 -0700 (PDT) Received: from localhost (ptr-5gw9txf6g5tndjqqqz.18120a2.ip6.access.telenet.be. [2a02:1810:510:3800:1b15:18e4:57d1:eb]) by smtp.gmail.com with ESMTPSA id cn21sm10684687edb.36.2021.05.25.05.28.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 May 2021 05:28:22 -0700 (PDT) From: Thomas De Schampheleire To: buildroot@buildroot.org Date: Tue, 25 May 2021 14:27:49 +0200 Message-Id: <20210525122750.5022-15-patrickdepinguin@gmail.com> X-Mailer: git-send-email 2.26.3 In-Reply-To: <20210525122750.5022-1-patrickdepinguin@gmail.com> References: <20210525122750.5022-1-patrickdepinguin@gmail.com> MIME-Version: 1.0 Subject: [Buildroot] [PATCHv3 14/15] package/pkg-meson.mk: determine 'buildtype' based on BR2_ENABLE_RUNTIME_DEBUG iso BR2_ENABLE_DEBUG X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Eric Le Bihan , Thomas De Schampheleire Errors-To: buildroot-bounces@busybox.net Sender: "buildroot" From: Thomas De Schampheleire BR2_ENABLE_DEBUG should just steer the availability of debug symbols and should have no negative effect on performance. Introduction of 'assert' statements, 'debug'-type builds with additional logging, etc. should be steered by BR2_ENABLE_RUNTIME_DEBUG instead. Signed-off-by: Thomas De Schampheleire --- package/pkg-meson.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package/pkg-meson.mk b/package/pkg-meson.mk index a57820d4d2..dafad3b1eb 100644 --- a/package/pkg-meson.mk +++ b/package/pkg-meson.mk @@ -89,7 +89,7 @@ define $(2)_CONFIGURE_CMDS --prefix=/usr \ --libdir=lib \ --default-library=$(if $(BR2_STATIC_LIBS),static,shared) \ - --buildtype=$(if $(BR2_ENABLE_DEBUG),debug,release) \ + --buildtype=$(if $(BR2_ENABLE_RUNTIME_DEBUG),debug,release) \ --cross-file=$$($$(PKG)_SRCDIR)/build/cross-compilation.conf \ -Dstrip=false \ -Dbuild.pkg_config_path=$$(HOST_DIR)/lib/pkgconfig \ From patchwork Tue May 25 12:27:50 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas De Schampheleire X-Patchwork-Id: 1483373 Return-Path: X-Original-To: incoming-buildroot@patchwork.ozlabs.org Delivered-To: patchwork-incoming-buildroot@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=busybox.net (client-ip=2605:bc80:3010::138; helo=smtp1.osuosl.org; envelope-from=buildroot-bounces@busybox.net; receiver=) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=HvdXxJEm; dkim-atps=neutral Received: from smtp1.osuosl.org (smtp1.osuosl.org [IPv6:2605:bc80:3010::138]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4FqD392y6kz9sCD for ; Tue, 25 May 2021 22:31:33 +1000 (AEST) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 0510183C88; Tue, 25 May 2021 12:31:31 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 98ZkJFx9RxMA; Tue, 25 May 2021 12:31:30 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp1.osuosl.org (Postfix) with ESMTP id 6A83E83C7C; Tue, 25 May 2021 12:31:29 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id 0AAD51BF396 for ; Tue, 25 May 2021 12:28:27 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id EE70783C7F for ; Tue, 25 May 2021 12:28:26 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Oq6O2gtGpApE for ; Tue, 25 May 2021 12:28:26 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.8.0 Received: from mail-ed1-x52d.google.com (mail-ed1-x52d.google.com [IPv6:2a00:1450:4864:20::52d]) by smtp1.osuosl.org (Postfix) with ESMTPS id EA97683C5E for ; Tue, 25 May 2021 12:28:25 +0000 (UTC) Received: by mail-ed1-x52d.google.com with SMTP id b17so36002298ede.0 for ; Tue, 25 May 2021 05:28:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=fziYona8aNcDF9piObfGsZ/IU+c5wDG0YY7Di5qmX5s=; b=HvdXxJEmrgfKuFKnUyVvNObEqPKI5bEuWzUKl8siZl61+Swke4lJEWtfrpIcOyrmGt Rwj0i3pYrhp1jGhu46ZZIlOd2g6mRIVWtglQnxLtpoINyQk9HAk66dmYcdROfy9GgKzR ZJtkzIbO8fYbOkx5fJ0Pc4fxecTGeILGJ5Ckm8YShfWw+jeGkkCpikSCHhtkmcKE8BC1 ldfztu0oqSH5ewWGvyNNvkw27HdM2YHyF2nzX9apSJtzQ30OeZ8+mpVSXnv0IpzJn81U 1TMrSQ6zQMl9TgO9JMbDonNNOtvLvO4lrSvBw/Rhl92Jf1fWl9+2heRULfOB1Dj5A9pK XOzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=fziYona8aNcDF9piObfGsZ/IU+c5wDG0YY7Di5qmX5s=; b=gJyjeF+3UvFAzcszAAgCXjAlhF3rCivK2wc9bvKeQ08//4oHvLuHbMiElTGpOWS1+f B5moKQ8AAv2gOWJrmJda81zHrWPSDko3HG4XtqZ9ZXUuK0h4dg9Uaq686xuFvsQBe99c mehX83Xtiu+fyy2oR0ZQHrTi1L0vi5P1BfISr5rMklXjgQ/Hqi/Y7fhXxmsSBj4PgC4w DNjr1gfrVqTIikVznYGBaJjFo2xxZyTgncPWdK+kzPHKYGVHeacAzuggPrQk26Pql5/Y dloqvLqSAP8KSVDA5htE2Zj4cdQ/HynjJ2zS9BvXJcpUXG9V37L/TXQF5BXOGk/nGtfF 6yJg== X-Gm-Message-State: AOAM533wDX/PdNJ9s7wwXCHyfy5/9uySUjOri7ZhVzb9ampYaycVST73 Qv7ynpoOlmH8l1SonYnq/Jisu+06Ve8Q/w== X-Google-Smtp-Source: ABdhPJwODgYYjX/4Y+OpaBXCzH9l0GKH9E4fWJznDuuMleWd5hLEq+bKEw6kj0JY56ZCV6r2FsT+oA== X-Received: by 2002:aa7:d04a:: with SMTP id n10mr31629868edo.33.1621945704187; Tue, 25 May 2021 05:28:24 -0700 (PDT) Received: from localhost (ptr-5gw9txf6g5tndjqqqz.18120a2.ip6.access.telenet.be. [2a02:1810:510:3800:1b15:18e4:57d1:eb]) by smtp.gmail.com with ESMTPSA id gn26sm3413198ejc.6.2021.05.25.05.28.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 May 2021 05:28:23 -0700 (PDT) From: Thomas De Schampheleire To: buildroot@buildroot.org Date: Tue, 25 May 2021 14:27:50 +0200 Message-Id: <20210525122750.5022-16-patrickdepinguin@gmail.com> X-Mailer: git-send-email 2.26.3 In-Reply-To: <20210525122750.5022-1-patrickdepinguin@gmail.com> References: <20210525122750.5022-1-patrickdepinguin@gmail.com> MIME-Version: 1.0 Subject: [Buildroot] [PATCHv3 15/15] utils/genrandconfig: also test BR2_ENABLE_RUNTIME_DEBUG X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas De Schampheleire Errors-To: buildroot-bounces@busybox.net Sender: "buildroot" From: Thomas De Schampheleire ... similar to BR2_ENABLE_DEBUG. Signed-off-by: Thomas De Schampheleire Acked-by: Arnout Vandecappelle (Essensium/Mind) --- utils/genrandconfig | 2 ++ 1 file changed, 2 insertions(+) diff --git a/utils/genrandconfig b/utils/genrandconfig index 93dc6d898b..ca3e77e3e3 100755 --- a/utils/genrandconfig +++ b/utils/genrandconfig @@ -357,6 +357,8 @@ def gen_config(args): # Amend the configuration with a few things. if randint(0, 20) == 0: configlines.append("BR2_ENABLE_DEBUG=y\n") + if randint(0, 20) == 0: + configlines.append("BR2_ENABLE_RUNTIME_DEBUG=y\n") if randint(0, 1) == 0: configlines.append("BR2_INIT_BUSYBOX=y\n") elif randint(0, 15) == 0: