From patchwork Wed May 19 15:57:05 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: miter X-Patchwork-Id: 1481019 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org (client-ip=2605:bc80:3010::136; helo=smtp3.osuosl.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=outlook.com header.i=@outlook.com header.a=rsa-sha256 header.s=selector1 header.b=gMY/RFzl; dkim-atps=neutral Received: from smtp3.osuosl.org (smtp3.osuosl.org [IPv6:2605:bc80:3010::136]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4FlcvW3Txqz9sSs for ; Thu, 20 May 2021 01:57:27 +1000 (AEST) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 1779360A51; Wed, 19 May 2021 15:57:25 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id LeBnQ1XpcFXm; Wed, 19 May 2021 15:57:24 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [IPv6:2605:bc80:3010:104::8cd3:938]) by smtp3.osuosl.org (Postfix) with ESMTP id 54E776061B; Wed, 19 May 2021 15:57:23 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 229C0C000E; Wed, 19 May 2021 15:57:23 +0000 (UTC) X-Original-To: ovs-dev@openvswitch.org Delivered-To: ovs-dev@lists.linuxfoundation.org Received: from smtp2.osuosl.org (smtp2.osuosl.org [IPv6:2605:bc80:3010::133]) by lists.linuxfoundation.org (Postfix) with ESMTP id D5F72C0001 for ; Wed, 19 May 2021 15:57:21 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id B7D224010C for ; Wed, 19 May 2021 15:57:21 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Authentication-Results: smtp2.osuosl.org (amavisd-new); dkim=pass (2048-bit key) header.d=outlook.com Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id YRM-LZ8ilw5A for ; Wed, 19 May 2021 15:57:20 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.8.0 Received: from APC01-HK2-obe.outbound.protection.outlook.com (mail-hk2apc01olkn0820.outbound.protection.outlook.com [IPv6:2a01:111:f400:febc::820]) by smtp2.osuosl.org (Postfix) with ESMTPS id 8D695400A4 for ; Wed, 19 May 2021 15:57:20 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KeAYuyd4llJrHZU4RGyhoE0MUVbWO4Nm+ewQxqJE81Dh+dKZPI3/QMYzXIH20D+vtwsHI5gsicBPLkhBbWU8rkXJuc+i6V4xP3+yq5I9KsMQ8UqiytIJ1w5lDQcj1u5qMyMd+M48pDrerP9Gwbd31td7IESLHrgeQbkY4+y4VDFZsD/tXt9YCrGUs/FQRu/82QqORWK+drfqKFYk4XvmND/y2sftGOc+0EjxvknwJ8cH6/EeLGUuJJ5FdvDPDPmL4Om4Ucls71DdRjkvyQl3axR7tdqEC95guehTlWDjoXPtqBGRo2yPwOus5LySHUg+DOeNNFAOykLcMPgaZCfD3A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=S/wXbRVILd/pXXyafsFarerHbGA74wMx2BUnFBA9k48=; b=kSyeingv8nJDzSUQIIloEaogxwQjFeurE92gZXpfAIpR3PrjEaVGFQdnhJbq0y47JO0uNUluE0QdMyi2U6KhaOzT5XGZ/lXwvi/QQErRnpN9+pNCI+xcKVFqOncCgNktGKlrP6hRPZsEKamED/m12VgkR+inmKA1XYQHZVDu8YLFXMIrNqvC83SFV+Xql7XkeXqCeO93MSa8OXRMAW3fiIUTgmrQlO4diIlbO86G7Da3OWJ35FE6xDxY03wM8zOJk34LGLvfmGTFpaz0ASV2GwwkuvIAvaSmyG1HDkaxgJsbuHsX1h+5VFd5UyeCbG2Hh7Q7hV7y4ZN422/IMNemsQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=S/wXbRVILd/pXXyafsFarerHbGA74wMx2BUnFBA9k48=; b=gMY/RFzlAaEdQ8WWfEKiNC3VrYCggQnBO2+pEO7idSrI7DNzrrRHY/wKX4nVoPEwF0kw19WM54gRDy8eKm1w20wJlSbU8ubBZJ7J3MzxX3kkwwZD1bx14SXsjT/h5AiF0VskkCwGhuPz5VGmFy/dOmz3JwkD3Y1C93hIzTWNRJnywR/okcezHWm8O7SkpSG4V1jTf9T+N3Trr5unJrYKzpveRR79036gctiM5Kb7xWX5OOIHyXcZ9CKINCF7Koy1/NVwbK0Qasi7VheiHmYSyOGMrcktUu4MzeEM8YaYqF7ev3ZTo1LR5k+6hYDJLJrvBYhnoF1TzCT9VY2b85Oc7A== Received: from HKAPR03CA0007.apcprd03.prod.outlook.com (2603:1096:203:c8::12) by PSBPR01MB3654.apcprd01.prod.exchangelabs.com (2603:1096:301:a::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4129.25; Wed, 19 May 2021 15:57:07 +0000 Received: from HK2APC01FT006.eop-APC01.prod.protection.outlook.com (2603:1096:203:c8:cafe::bf) by HKAPR03CA0007.outlook.office365.com (2603:1096:203:c8::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4150.11 via Frontend Transport; Wed, 19 May 2021 15:57:07 +0000 Received: from ME3PR01MB5781.ausprd01.prod.outlook.com (2a01:111:e400:7ebc::51) by HK2APC01FT006.mail.protection.outlook.com (2a01:111:e400:7ebc::74) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4129.25 via Frontend Transport; Wed, 19 May 2021 15:57:07 +0000 Received: from ME3PR01MB5781.ausprd01.prod.outlook.com ([fe80::70f7:fd46:87cc:96a]) by ME3PR01MB5781.ausprd01.prod.outlook.com ([fe80::70f7:fd46:87cc:96a%7]) with mapi id 15.20.4129.032; Wed, 19 May 2021 15:57:05 +0000 From: lin huang To: "ovs-dev@openvswitch.org" Thread-Topic: [ovs-dev] [PATCH] netdev-linux.c : nl_sock_listen_all_nsid triggers NULL deref. Thread-Index: AQHXTHW2AzcnVnDc+EO4II6dplwj56rq9W2r Date: Wed, 19 May 2021 15:57:05 +0000 Message-ID: References: In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-incomingtopheadermarker: OriginalChecksum:4BA81E52A70D3026F0B7233163FC9A92825E16879AA54497B615C933515386CB; UpperCasedChecksum:D784B02CBD0ADD88744CF26C642A7E6F3A29A01B28656C3FF1C4A43CC3B2ADFE; SizeAsReceived:7046; Count:43 x-tmn: [xKG1giwMh/cM5XmFXqj6fEI26hOnsOEwnj7mvFRPNCauEvW4W0tpk0jOc/gmXPdC] x-ms-publictraffictype: Email x-incomingheadercount: 43 x-eopattributedmessage: 0 x-ms-office365-filtering-correlation-id: 2ea1d880-74c2-43d7-6c91-08d91adec01d x-ms-traffictypediagnostic: PSBPR01MB3654: x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: VN9MC7GmMkAjw0dHk/0cnYtWVOU3W7y2RijbpMV/rmo/W94VlHRzG5ykl4pEoNwwquXo+DcoTSWwZKgE40c6ndmTUw5L8tgt+9wcWs4x/vbfmewvVfwoPcfzf5MUybHq1LwOgt7PsRhTZPYVWP6Em055T2zkFiVRJkCrDkevCaNyz/nBbqjrhNEKPa5IOdeo/9er7732bx7DzFbDtaMMYuEIkS/Fq75YuKk9ZNoVb/pvcKPnX1lNLTPpOLZkoIvg5z+KW1FeV+FGByktxmb+kKv7Yd97Ypvv3RsqFmFTOc3+P/mWBpYxET1Log3vkM7L8Ed1PP47J+FFynfcxDAs98pktqFyqLmtel9u5KBR9fOpThM5YalbVg2FFLOxV+zw x-ms-exchange-antispam-messagedata: 3sP5IugijQKyA0mTltFtr5wgnses1pAFTZ2wM0eWekrNd/dP1uHY2+OYXaGLrWisIp/FXOqoLryWphw5s3bL7T7qAon8Z9VWDG4Lv8Y7ITszjg83JyS0+OSGy5yBYqquWJHSTwna32Hrj9pX31gTt4G1JNziN5KvFomBKiDxAqC3XRmux8KtOxNMeNq/WC+vMMmYLaBMfzGg0+4zt4wCbA== x-ms-exchange-transport-forked: True MIME-Version: 1.0 X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-AuthSource: HK2APC01FT006.eop-APC01.prod.protection.outlook.com X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: 2ea1d880-74c2-43d7-6c91-08d91adec01d X-MS-Exchange-CrossTenant-originalarrivaltime: 19 May 2021 15:57:05.6676 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Internet X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PSBPR01MB3654 X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: [ovs-dev] [PATCH] netdev-linux.c : nl_sock_listen_all_nsid triggers NULL deref. X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: ovs-dev-bounces@openvswitch.org Sender: "dev" netdev-linux.c : nl_sock_listen_all_nsid triggers NULL deref. Signed-off-by: miter --- lib/netdev-linux.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) -- 2.31.1 diff --git a/lib/netdev-linux.c b/lib/netdev-linux.c index 15b25084b..0994044ec 100644 --- a/lib/netdev-linux.c +++ b/lib/netdev-linux.c @@ -634,7 +634,9 @@ netdev_linux_notify_sock(void) } } } - nl_sock_listen_all_nsid(sock, true); + if (sock) { + nl_sock_listen_all_nsid(sock, true); + } ovsthread_once_done(&once); }