From patchwork Mon May 10 20:22:46 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jonathan Wakely X-Patchwork-Id: 1476708 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=2620:52:3:1:0:246e:9693:128c; helo=sourceware.org; envelope-from=gcc-patches-bounces@gcc.gnu.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.a=rsa-sha256 header.s=default header.b=mAAPFj+9; dkim-atps=neutral Received: from sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4FfCD44zfsz9sX5 for ; Tue, 11 May 2021 06:23:00 +1000 (AEST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id D05DF3848006; Mon, 10 May 2021 20:22:54 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D05DF3848006 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1620678174; bh=/qw38TYhe5HUfgNPLGsbeCx1MaKNFfvduoyAjKi5A/w=; h=Date:To:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=mAAPFj+93cLhBtMmash2dJhLwjMnjlwDfNWfPX0iEP2t89D9yX93Wiu4fWGk4wCyf wUGMsMZxvaCDG7ibuJOLbioMMOkAdXL4Q563SJHac4I7IlQlDlLDif+iaPyFzNfSXv QC788sTYtT5IWxFpmZOPiDcGOrCZGUmNXSvEvY64= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id 42E85384F028 for ; Mon, 10 May 2021 20:22:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 42E85384F028 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-283-sLWWZ16lMQy8EmEjpkucgA-1; Mon, 10 May 2021 16:22:48 -0400 X-MC-Unique: sLWWZ16lMQy8EmEjpkucgA-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 7A02C8186E1; Mon, 10 May 2021 20:22:47 +0000 (UTC) Received: from localhost (unknown [10.33.36.164]) by smtp.corp.redhat.com (Postfix) with ESMTP id 26A0460BD8; Mon, 10 May 2021 20:22:47 +0000 (UTC) Date: Mon, 10 May 2021 21:22:46 +0100 To: libstdc++@gcc.gnu.org, gcc-patches@gcc.gnu.org Subject: [committed] libstdc++: Remove TODO comment Message-ID: MIME-Version: 1.0 X-Clacks-Overhead: GNU Terry Pratchett X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline X-Spam-Status: No, score=-15.1 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Jonathan Wakely via Gcc-patches From: Jonathan Wakely Reply-To: Jonathan Wakely Errors-To: gcc-patches-bounces@gcc.gnu.org Sender: "Gcc-patches" We have a comment saying to replace the simple binary_semaphore type with std::binary_semaphore, which has been done. However, that isn't defined on all targets. So keep the simple one here that just implements the parts of the API needed by , and remove the comment suggesting it should be replaced. libstdc++-v3/ChangeLog: * include/std/stop_token: Remove TODO comment. Tested powerpc64le-linux. Committed to trunk. commit 151154a21da8b0784894b2463a117f4e283d5525 Author: Jonathan Wakely Date: Mon May 10 21:06:22 2021 libstdc++: Remove TODO comment We have a comment saying to replace the simple binary_semaphore type with std::binary_semaphore, which has been done. However, that isn't defined on all targets. So keep the simple one here that just implements the parts of the API needed by , and remove the comment suggesting it should be replaced. libstdc++-v3/ChangeLog: * include/std/stop_token: Remove TODO comment. diff --git a/libstdc++-v3/include/std/stop_token b/libstdc++-v3/include/std/stop_token index fffc215d2a8..d0cfcf31097 100644 --- a/libstdc++-v3/include/std/stop_token +++ b/libstdc++-v3/include/std/stop_token @@ -107,7 +107,6 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION } #ifndef __cpp_lib_semaphore - // TODO: replace this with a real implementation of std::binary_semaphore struct binary_semaphore { explicit binary_semaphore(int __d) : _M_counter(__d > 0) { }