From patchwork Fri Jan 19 00:30:18 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Morton X-Patchwork-Id: 863239 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.infradead.org (client-ip=65.50.211.133; helo=bombadil.infradead.org; envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="AJQQN8f1"; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3zN1vd4KLGz9s7f for ; Fri, 19 Jan 2018 11:30:52 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Subject:To:From :Date:Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=h+c2jOOA5+XXG3xizKitCD1DCIDijmm4AQSDyeAcUPY=; b=AJQQN8f1hVC+YV e9Wvnnm7l4nndhZ2jt27FuzNJfIq8TIXAsuqDEeOfyYL14ddZjSDO1df8Zdoss+62OobI3sSAflAZ 8XifBkwvCbcWWAZEJsugV8sv8hEj0TDWm9PL+wbmO7hjiZb1bkFx/SyRGKJzMLZ8285WfuUE0TksD vOz7/pXDnCFNlgbCBEk5X5/BEZCg9tdBCX2dPHYA+uhOls6AsIqrES20iEf5DRSVR9YtbJrM0uv/c bSC4Lj3QH72ilw+qIZ2W+OqMxEdQOEbqT7SGK3LtEzXK+nQf3aVfyizXpDQ+y2lTpP2Yx6DM8szSB WcRTaVscRfnGC/owKNlA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.89 #1 (Red Hat Linux)) id 1ecKZw-00047o-9A; Fri, 19 Jan 2018 00:30:44 +0000 Received: from mail.linuxfoundation.org ([140.211.169.12]) by bombadil.infradead.org with esmtps (Exim 4.89 #1 (Red Hat Linux)) id 1ecKZs-00044R-Hy for linux-mtd@lists.infradead.org; Fri, 19 Jan 2018 00:30:42 +0000 Received: from akpm3.svl.corp.google.com (unknown [104.133.9.92]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id 07ED0EC7; Fri, 19 Jan 2018 00:30:28 +0000 (UTC) Date: Thu, 18 Jan 2018 16:30:18 -0800 From: akpm@linux-foundation.org To: boris.brezillon@free-electrons.com, linux-mtd@lists.infradead.org, akpm@linux-foundation.org, miquel.raynal@free-electrons.com, richard@nod.at, sean.nyekjaer@prevas.dk, w@1wt.eu Subject: [patch 1/1] include/linux/mtd/rawnand.h: fix build with gcc-4.4.4 Message-ID: <5a613c1a.p+Q5+DVAaEi8ctNz%akpm@linux-foundation.org> User-Agent: Heirloom mailx 12.5 6/20/10 MIME-Version: 1.0 X-Spam-Note: CRM114 invocation failed X-Spam-Score: -4.2 (----) X-Spam-Report: SpamAssassin version 3.4.1 on bombadil.infradead.org summary: Content analysis details: (-4.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at http://www.dnswl.org/, medium trust [140.211.169.12 listed in list.dnswl.org] -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.0 SPF_PASS SPF: sender matches SPF record -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-mtd" Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org From: Andrew Morton Subject: include/linux/mtd/rawnand.h: fix build with gcc-4.4.4 gcc-4.4.4 has issues with anon union initializers. Work aound this. drivers/mtd/nand/marvell_nand.c:1936: warning: missing braces around initializer drivers/mtd/nand/marvell_nand.c:1936: warning: (near initialization for '(anonymous)[1].') drivers/mtd/nand/marvell_nand.c:1936: error: unknown field 'data' specified in initializer drivers/mtd/nand/marvell_nand.c:1936: error: unknown field 'addr' specified in initializer drivers/mtd/nand/marvell_nand.c:1936: warning: missing braces around initializer drivers/mtd/nand/marvell_nand.c:1936: warning: (near initialization for '(anonymous)[1].') drivers/mtd/nand/marvell_nand.c:1936: error: unknown field 'data' specified in initializer drivers/mtd/nand/marvell_nand.c:1936: error: unknown field 'addr' specified in i Fixes: 02f26ecf8c77275 ("mtd: nand: add reworked Marvell NAND controller driver") Cc: Miquel Raynal Cc: Sean Nyekjaer Cc: Willy Tarreau Cc: Boris Brezillon Cc: Richard Weinberger Signed-off-by: Andrew Morton --- include/linux/mtd/rawnand.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff -puN include/linux/mtd/rawnand.h~include-linux-mtd-rawnandh-fix-build-with-gcc-444 include/linux/mtd/rawnand.h --- a/include/linux/mtd/rawnand.h~include-linux-mtd-rawnandh-fix-build-with-gcc-444 +++ a/include/linux/mtd/rawnand.h @@ -975,21 +975,21 @@ struct nand_op_parser_pattern_elem { { \ .type = NAND_OP_ADDR_INSTR, \ .optional = _opt, \ - .addr.maxcycles = _maxcycles, \ + { .addr = { .maxcycles = _maxcycles }, }, \ } #define NAND_OP_PARSER_PAT_DATA_IN_ELEM(_opt, _maxlen) \ { \ .type = NAND_OP_DATA_IN_INSTR, \ .optional = _opt, \ - .data.maxlen = _maxlen, \ + { .data = { .maxlen = _maxlen, }, }, \ } #define NAND_OP_PARSER_PAT_DATA_OUT_ELEM(_opt, _maxlen) \ { \ .type = NAND_OP_DATA_OUT_INSTR, \ .optional = _opt, \ - .data.maxlen = _maxlen, \ + { .data = { .maxlen = _maxlen, }, }, \ } #define NAND_OP_PARSER_PAT_WAITRDY_ELEM(_opt) \