From patchwork Tue May 4 12:43:43 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Khaled ROMDHANI X-Patchwork-Id: 1473826 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=linux-cifs-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=cYGmmOIL; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4FZKK85Mc0z9sRf for ; Tue, 4 May 2021 22:43:56 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230322AbhEDMot (ORCPT ); Tue, 4 May 2021 08:44:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34476 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230362AbhEDMot (ORCPT ); Tue, 4 May 2021 08:44:49 -0400 Received: from mail-wr1-x436.google.com (mail-wr1-x436.google.com [IPv6:2a00:1450:4864:20::436]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B4187C061574; Tue, 4 May 2021 05:43:53 -0700 (PDT) Received: by mail-wr1-x436.google.com with SMTP id t18so9271672wry.1; Tue, 04 May 2021 05:43:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=UkcPfOw1zL7OvDlpQg+xfIeD/O5P0yQ5Qy64lO5GzLE=; b=cYGmmOIL0DZvq0tOcTQpB6OosRqnot+QaUnl0KYl+CG77yzYbkAaerHcRzXja5Xhr1 lS8xJhxjpAzhKvgWXfWhb+q9ZezccnHFUwm2cU1UuQry//iJUl2XAyVmxqeIyd1shS/f UbLGgUnWbv43d6fjU9plVAo7QcXFHyJJZ4wN/Dizsqs/rBlMDOPbYzWsYHMD70HJnGv0 xJ9rGFQiU0grCfgMgh/Q0MCHUvzkPGdjRGNx4prjKwtucYTITy3UfSdhWzZ7SNt6EoNM KXSev60Cv33V4ecm6ZYtrlsUQb9QN+7w21equ4WgQaRddF8WBp7DTeH2BcDxjjkn3pPl 0mxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=UkcPfOw1zL7OvDlpQg+xfIeD/O5P0yQ5Qy64lO5GzLE=; b=Oqok33nEbDIFl4danWfJ9rKA81uHUuJQzt1Uo4r4wTbcwHlEN0nB2Z9TRjf4RftRwm Qod5heiHLPbG6FYJ5XH7l5Iw01nNH6/pfcht/4dFjsLsCp908cx+LVbyby0Tlav+UdK6 U6PfHLYexqxzzIhqFsHKPeEBe/BX6CQ8g8g7pNh6Y4a+eygAPFOKKrbCvBbjiPDsHCu2 7jZcC465FcXUk/wculbhns0+0euJagj2EiLVftJPEKvAuGP2VMHSzGE+tqwJeBiz68dM VYx5okIPsXD6xZQb6APdTwQBJohcv7+SJ0m834RMBAUlMaFI8/SNgWLvcgcabYOBFBzF pwKA== X-Gm-Message-State: AOAM532asTrSgoK/yJ6gFNt3y4v80puxwkuscJlhe3oas6AAi398ssMs UmTLdz9bmnpVZPDKoUcDINo= X-Google-Smtp-Source: ABdhPJwBEUAltlS9MdL420XVTKnQOM1FVxbisDjEDRdT/oObO9i972dnrB9jZUTfEYQ3frGwvXLvPw== X-Received: by 2002:a5d:53c3:: with SMTP id a3mr14349476wrw.376.1620132232466; Tue, 04 May 2021 05:43:52 -0700 (PDT) Received: from localhost.localdomain ([197.2.237.199]) by smtp.gmail.com with ESMTPSA id f25sm16627965wrd.67.2021.05.04.05.43.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 May 2021 05:43:52 -0700 (PDT) From: Khaled ROMDHANI To: sfrench@samba.org Cc: Khaled ROMDHANI , linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH-next] fs/cifs: Fix resource leak Date: Tue, 4 May 2021 13:43:43 +0100 Message-Id: <20210504124343.22611-1-khaledromdhani216@gmail.com> X-Mailer: git-send-email 2.17.1 Precedence: bulk List-ID: X-Mailing-List: linux-cifs@vger.kernel.org The -EIO error return path is leaking memory allocated to page. Fix this by invoking the free_dentry_path before the return. Addresses-Coverity: ("Resource leak") Signed-off-by: Khaled ROMDHANI --- fs/cifs/link.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/fs/cifs/link.c b/fs/cifs/link.c index 1cbe7ec73728..1485c6095ba1 100644 --- a/fs/cifs/link.c +++ b/fs/cifs/link.c @@ -686,8 +686,10 @@ cifs_symlink(struct user_namespace *mnt_userns, struct inode *inode, void *page = alloc_dentry_path(); struct inode *newinode = NULL; - if (unlikely(cifs_forced_shutdown(cifs_sb))) + if (unlikely(cifs_forced_shutdown(cifs_sb))) { + free_dentry_path(page); return -EIO; + } xid = get_xid();