From patchwork Tue Apr 27 18:53:47 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fabrice Fontaine X-Patchwork-Id: 1470848 Return-Path: X-Original-To: incoming-buildroot@patchwork.ozlabs.org Delivered-To: patchwork-incoming-buildroot@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=busybox.net (client-ip=140.211.166.136; helo=smtp3.osuosl.org; envelope-from=buildroot-bounces@busybox.net; receiver=) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=LnsE7LYr; dkim-atps=neutral Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4FV9x35KwGz9sW8 for ; Wed, 28 Apr 2021 04:57:05 +1000 (AEST) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 5597D608EC; Tue, 27 Apr 2021 18:56:58 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id wGCzFuYKwN9n; Tue, 27 Apr 2021 18:56:57 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp3.osuosl.org (Postfix) with ESMTP id A7FB1608CE; Tue, 27 Apr 2021 18:56:56 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id 571E41C119D for ; Tue, 27 Apr 2021 18:56:55 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 4F0F983B98 for ; Tue, 27 Apr 2021 18:56:55 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Authentication-Results: smtp1.osuosl.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id XY9vf2aGN9Go for ; Tue, 27 Apr 2021 18:56:54 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.8.0 Received: from mail-wr1-x429.google.com (mail-wr1-x429.google.com [IPv6:2a00:1450:4864:20::429]) by smtp1.osuosl.org (Postfix) with ESMTPS id 4082D83B85 for ; Tue, 27 Apr 2021 18:56:54 +0000 (UTC) Received: by mail-wr1-x429.google.com with SMTP id h15so8271466wre.11 for ; Tue, 27 Apr 2021 11:56:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=ZlPRERGW0wQej/jSpttkZiOF65WqUwuJFF1tqL1jjG4=; b=LnsE7LYrEcalWSpokjY8lhztPREkb5I25xrYr8KQ7iSSvgTWZIY7nuxb6Z3cChYVTv QwxWdkay++H1nI94aJ877QIJLVl76MSYxRgue41vawQ+dQgeMpq+8lV1yNDcqCce3AoI uwfrLYy8oXfUurUXw4W2oGTEVbe4BbtqQxDUawkrFVk+u2OYJfeIssEi0+hij+2MLnsC IZhtdX7vP2Pfz/DoovLEX+CTNzX0B3Q3E2g1kdaptImq+mZkkxx1QNAjra3cX74Rg5mH 4NmYIL+XNfBLio/iiPOTwn1btRooL9frBus8iDR21LZIk7UfxIlJFQPspHIROZ+1rNl3 6rYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=ZlPRERGW0wQej/jSpttkZiOF65WqUwuJFF1tqL1jjG4=; b=M2zM2oKjfgkRISH/hHYzaArLyixJsS3H9y4i7ANQMe8v9LhThp6+2WPIkZi3Hq9hpG 8hUVr20x9i+lN+4bOiAzpLpU7ikuTi0Bn0A26elDjfCWLGBWwsKz/Qvj789LEyvGk4tR DPGN4mY4QuFGEjY1HTjsuee73512ItD2Wfa0U/JmqR0bEdRJv+bVXQZfYuOexns+gCZA 95P9spuTmvyWebbsojKqr1PJaO5RhcTbgbgglV7ujtwvt4Gl83HHFW1ODp4EhrlzfdZo IOYOh0bGlhksOTNgpyLiUAlfaHRKEHP7EGlpV63q1ybvq/ifbzneFemmGfnno45mbX7x CH1w== X-Gm-Message-State: AOAM532p4KCc19XjiJAwMdqkbS4ZH7AXN7MPmN7SqhiyyRclA4SWhLps esbBK8H48LPPZPPJ/rMWt1srApIIwE0= X-Google-Smtp-Source: ABdhPJwT/Tyrii1khDyjQrbA0+gdU4Gshif6lKdBvU/ExP/PWhuXXftNCbgjaDgBEt9cDnVtOSGofg== X-Received: by 2002:a5d:61d0:: with SMTP id q16mr4699735wrv.383.1619549812185; Tue, 27 Apr 2021 11:56:52 -0700 (PDT) Received: from kali.home (lfbn-ren-1-1383-171.w86-229.abo.wanadoo.fr. [86.229.230.171]) by smtp.gmail.com with ESMTPSA id n5sm3375570wrx.92.2021.04.27.11.56.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Apr 2021 11:56:51 -0700 (PDT) From: Fabrice Fontaine To: buildroot@buildroot.org Date: Tue, 27 Apr 2021 20:53:47 +0200 Message-Id: <20210427185347.158518-1-fontaine.fabrice@gmail.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Subject: [Buildroot] [PATCH 1/1] package/gd: fix addition of -liconv in gdlib.pc.in X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fabrice Fontaine Errors-To: buildroot-bounces@busybox.net Sender: "buildroot" Static build of gnuplot with gd and libiconv is broken since bump to version 2.3.1 in commit 970b2ca3cc3f927f679c871eeadb22ec110b0ed5: /home/giuliobenetti/autobuild/run/instance-3/output-1/host/opt/ext-toolchain/bin/../lib/gcc/powerpc-buildroot-linux-uclibc/9.3.0/../../../../powerpc-buildroot-linux-uclibc/bin/ld: /home/giuliobenetti/autobuild/run/instance-3/output-1/host/bin/../powerpc-buildroot-linux-uclibc/sysroot/usr/lib/libgd.a(gdkanji.o): in function `do_convert': gdkanji.c:(.text+0x148): undefined reference to `libiconv_open' /home/giuliobenetti/autobuild/run/instance-3/output-1/host/opt/ext-toolchain/bin/../lib/gcc/powerpc-buildroot-linux-uclibc/9.3.0/../../../../powerpc-buildroot-linux-uclibc/bin/ld: gdkanji.c:(.text+0x1d0): undefined reference to `libiconv' This build failure is raised because LIBS has been replaced by LIBS_PRIVATES in gdlib.pc.in since https://github.com/libgd/libgd/commit/28ecfe77c817aff8ce56422d3e4e8533a281bc76 Fixes: - http://autobuild.buildroot.org/results/5ab5f4744adfd8d8be483204a9c7f59e34ce26c6 Signed-off-by: Fabrice Fontaine --- package/gd/gd.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package/gd/gd.mk b/package/gd/gd.mk index 97a1a143ec..2df81e6d37 100644 --- a/package/gd/gd.mk +++ b/package/gd/gd.mk @@ -36,7 +36,7 @@ endif ifeq ($(BR2_PACKAGE_LIBICONV),y) GD_DEPENDENCIES += libiconv # not strictly needed for gd, but ensures -liconv ends up in gdlib.pc -GD_CONF_ENV += LIBS="-liconv" +GD_CONF_ENV += LIBS_PRIVATES="-liconv" endif ifeq ($(BR2_PACKAGE_JPEG),y)