From patchwork Mon Apr 26 11:38:55 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?Christoph_M=C3=BCllner?= X-Patchwork-Id: 1470256 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=2620:52:3:1:0:246e:9693:128c; helo=sourceware.org; envelope-from=gcc-patches-bounces@gcc.gnu.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.a=rsa-sha256 header.s=default header.b=jQhw82GV; dkim-atps=neutral Received: from sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4FTNG30FFJz9sX2 for ; Mon, 26 Apr 2021 21:39:06 +1000 (AEST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 6F158385E442; Mon, 26 Apr 2021 11:39:03 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 6F158385E442 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1619437143; bh=blQh/XxVdEsPBG0AV6Zo0pjZtGHN2ewNKkTF44Al4fI=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=jQhw82GVpcb3hd6RgdoJYZJx5oVOuYQtNUaRxHtYpSApUiShWv70gtMb0y+fqiJtp 1uaiWnFFTXYy1BGpwNaAwAhf/mXr2NaU57lHjMMWhvuo2bBlMc6fhG0ffqj7L2kJqV ZxGQv08qzmqVqld8Mfnym3LY/Y3tUXeV9XPslC9c= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mail-ed1-f45.google.com (mail-ed1-f45.google.com [209.85.208.45]) by sourceware.org (Postfix) with ESMTPS id 7079F385E442; Mon, 26 Apr 2021 11:39:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 7079F385E442 Received: by mail-ed1-f45.google.com with SMTP id q6so6037423edr.3; Mon, 26 Apr 2021 04:39:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=blQh/XxVdEsPBG0AV6Zo0pjZtGHN2ewNKkTF44Al4fI=; b=tP9H+O12olpFOcN7G4FSgdCgx1APyQyt4G2C099fPaYQdmF8/1+58FzLTAs9KjFiVI 2YuNjhzZxg2iCXRyBBFwHM020LSFecky2xALiu3R82UR4e1E4sM7Sxj/bhbQHBwe0eBG Li2V988Tz8LQDnzGI/9qlEPXuRs2plXMi4HAbx8Tz3GKexnmDHKPEkXHdYdXk7/Dwa1a 5zYpagKGopCf7l/1UimzNBq9KJTSHQB7GW+if6jygW75d1Dyy3a0lbIAu6JnfJcB+Ii1 YZG/lrQt7QXWq6xG9RI81EasqD0mOeVRj1ddbD/h5HSj1jfHW20hiM0IDNkizTtbHYcK eUmw== X-Gm-Message-State: AOAM531rdzL23ora1AqWMvTKeeEdcQJb2BCHSOCJjAjhda4bXvc6Ns3X W6VIyszYp6/1tbJxuaPlBR7Nc76nnUNQaQ== X-Google-Smtp-Source: ABdhPJxamERCMbSRtXsFwWDbSkO8q90YCtB4HR7mZXWUX+m0gEU3fetIJhK0UsBfaclMLKgpxCr5/A== X-Received: by 2002:aa7:c4d0:: with SMTP id p16mr12348975edr.102.1619437139155; Mon, 26 Apr 2021 04:38:59 -0700 (PDT) Received: from beast.fritz.box (62-178-178-158.cable.dynamic.surfer.at. [62.178.178.158]) by smtp.gmail.com with ESMTPSA id q25sm11152680ejd.9.2021.04.26.04.38.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Apr 2021 04:38:58 -0700 (PDT) To: gcc-patches@gcc.gnu.org Subject: [PATCH 1/2] REE: PR rtl-optimization/100264: Handle more PARALLEL SET expressions Date: Mon, 26 Apr 2021 13:38:55 +0200 Message-Id: <20210426113855.3291810-1-cmuellner@gcc.gnu.org> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 X-Spam-Status: No, score=-11.8 required=5.0 tests=BAYES_00, FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM, GIT_PATCH_0, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Christoph Muellner via Gcc-patches From: =?utf-8?q?Christoph_M=C3=BCllner?= Reply-To: Christoph Muellner Errors-To: gcc-patches-bounces@gcc.gnu.org Sender: "Gcc-patches" [ree] PR rtl-optimization/100264: Handle more PARALLEL SET expressions PR rtl-optimization/100264 * ree.c (get_sub_rtx): Ignore SET expressions without register destinations. (merge_def_and_ext): Eliminate destination check for register as such SET expressions can't occur anymore. (combine_reaching_defs): Likewise. --- gcc/ree.c | 30 ++++++++++++++++++------------ 1 file changed, 18 insertions(+), 12 deletions(-) diff --git a/gcc/ree.c b/gcc/ree.c index 65457c582c6a..1eaaaf9e1eb5 100644 --- a/gcc/ree.c +++ b/gcc/ree.c @@ -658,10 +658,11 @@ make_defs_and_copies_lists (rtx_insn *extend_insn, const_rtx set_pat, return ret; } -/* If DEF_INSN has single SET expression, possibly buried inside - a PARALLEL, return the address of the SET expression, else - return NULL. This is similar to single_set, except that - single_set allows multiple SETs when all but one is dead. */ +/* If DEF_INSN has single SET expression with a register + destination, possibly buried inside a PARALLEL, return + the address of the SET expression, else return NULL. + This is similar to single_set, except that single_set + allows multiple SETs when all but one is dead. */ static rtx * get_sub_rtx (rtx_insn *def_insn) { @@ -675,6 +676,8 @@ get_sub_rtx (rtx_insn *def_insn) rtx s_expr = XVECEXP (PATTERN (def_insn), 0, i); if (GET_CODE (s_expr) != SET) continue; + if (!REG_P (SET_DEST (s_expr))) + continue; if (sub_rtx == NULL) sub_rtx = &XVECEXP (PATTERN (def_insn), 0, i); @@ -686,7 +689,13 @@ get_sub_rtx (rtx_insn *def_insn) } } else if (code == SET) - sub_rtx = &PATTERN (def_insn); + { + rtx s_expr = PATTERN (def_insn); + if (!REG_P (SET_DEST (s_expr))) + return NULL; + + sub_rtx = &PATTERN (def_insn); + } else { /* It is not a PARALLEL or a SET, what could it be ? */ @@ -712,13 +721,12 @@ merge_def_and_ext (ext_cand *cand, rtx_insn *def_insn, ext_state *state) if (sub_rtx == NULL) return false; - if (REG_P (SET_DEST (*sub_rtx)) - && (GET_MODE (SET_DEST (*sub_rtx)) == ext_src_mode + if (GET_MODE (SET_DEST (*sub_rtx)) == ext_src_mode || ((state->modified[INSN_UID (def_insn)].kind == (cand->code == ZERO_EXTEND ? EXT_MODIFIED_ZEXT : EXT_MODIFIED_SEXT)) && state->modified[INSN_UID (def_insn)].mode - == ext_src_mode))) + == ext_src_mode)) { if (GET_MODE_UNIT_SIZE (GET_MODE (SET_DEST (*sub_rtx))) >= GET_MODE_UNIT_SIZE (cand->mode)) @@ -853,8 +861,7 @@ combine_reaching_defs (ext_cand *cand, const_rtx set_pat, ext_state *state) CAND->insn, then this transformation is not safe. Note we have to test in the widened mode. */ rtx *dest_sub_rtx = get_sub_rtx (def_insn); - if (dest_sub_rtx == NULL - || !REG_P (SET_DEST (*dest_sub_rtx))) + if (dest_sub_rtx == NULL) return false; rtx tmp_reg = gen_rtx_REG (GET_MODE (SET_DEST (set)), @@ -947,8 +954,7 @@ combine_reaching_defs (ext_cand *cand, const_rtx set_pat, ext_state *state) break; rtx *dest_sub_rtx2 = get_sub_rtx (def_insn2); - if (dest_sub_rtx2 == NULL - || !REG_P (SET_DEST (*dest_sub_rtx2))) + if (dest_sub_rtx2 == NULL) break; /* On RISC machines we must make sure that changing the mode of