From patchwork Wed Apr 14 16:00:37 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tim Gardner X-Patchwork-Id: 1466315 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.ubuntu.com (client-ip=91.189.94.19; helo=huckleberry.canonical.com; envelope-from=kernel-team-bounces@lists.ubuntu.com; receiver=) Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4FL6f738yyz9sVb; Thu, 15 Apr 2021 02:01:18 +1000 (AEST) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.86_2) (envelope-from ) id 1lWhx4-0000aX-9M; Wed, 14 Apr 2021 16:01:14 +0000 Received: from youngberry.canonical.com ([91.189.89.112]) by huckleberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1lWhx1-0000Zr-QI for kernel-team@lists.ubuntu.com; Wed, 14 Apr 2021 16:01:11 +0000 Received: from mail-pg1-f197.google.com ([209.85.215.197]) by youngberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1lWhx1-0005kV-Eg for kernel-team@lists.ubuntu.com; Wed, 14 Apr 2021 16:01:11 +0000 Received: by mail-pg1-f197.google.com with SMTP id v5so972795pgj.7 for ; Wed, 14 Apr 2021 09:01:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=a+ZOKZLAGShWrkUJ0qw6bVw4HEXfDvzJ7wSdKMKTqiM=; b=Je1J2RX7KktLM7RxYqfMfXSXEDQVI0QPz2I6sGDshfIjfU3LlLKoYiXBpkzcB3SY/M aWJFziuYCNyZnQo3iEZ/SNWQhsEkJVhkECUQLbnZopu9WFSvpsPmhZc6TpKFMj05dArm n6riH2rOiq+Jy1pUoz8sG+n6s77ewuF3OW7HB3rREXtDblbsGu/in6RqizIlbjK3PcF3 j7N+gg4bfUYz80QvRU3v6rxq+gkaD0shkLX1RwrOTYJht/1UZFQx+0wYDkghZG8ljObK QbgB9BvUFirpDy1SHz82mP2Xy9tmiEFu2eKiAb+JZiDEaC/NVY1c50hql9Ur8Mk0hXHw CN2A== X-Gm-Message-State: AOAM533bSUZLPNZnSUkaONX+IONKi51D5E0302+q+snhhHeBWFRuO1RC Ff/K68/BCuhfbG9hcj19me1MTpvT6dErYq7tTe1RX1OqALRAWQP2ldrLiUwAx1QG42p1Qt16S8n HKmXKxa14mmQnh/ULDpg53txLuSINKrZ54D5eAzeYpA== X-Received: by 2002:a63:f104:: with SMTP id f4mr37582492pgi.241.1618416069818; Wed, 14 Apr 2021 09:01:09 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwIRkLpsi1XyHjpfQ7X9Sh30a2HDX5h8QhECxH1LhEkOAcrX0mtiSzbPoG3SiKPCZgRCm6Rpg== X-Received: by 2002:a63:f104:: with SMTP id f4mr37582475pgi.241.1618416069553; Wed, 14 Apr 2021 09:01:09 -0700 (PDT) Received: from localhost.localdomain ([69.163.84.166]) by smtp.gmail.com with ESMTPSA id z17sm5136283pjn.47.2021.04.14.09.01.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Apr 2021 09:01:08 -0700 (PDT) From: Tim Gardner To: kernel-team@lists.ubuntu.com Subject: [PATCH] Revert "cifs: Set CIFS_MOUNT_USE_PREFIX_PATH flag on setting cifs_sb->prepath." Date: Wed, 14 Apr 2021 10:00:37 -0600 Message-Id: <20210414160037.15265-2-tim.gardner@canonical.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20210414160037.15265-1-tim.gardner@canonical.com> References: <20210414160037.15265-1-tim.gardner@canonical.com> X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Kernel team discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: kernel-team-bounces@lists.ubuntu.com Sender: "kernel-team" From: Greg Kroah-Hartman BugLink: https://bugs.launchpad.net/bugs/1923670 This reverts commit a2c5e4a083a7e24b35b3eb808b760af6de15bac2 which is commit a738c93fb1c17e386a09304b517b1c6b2a6a5a8b upstream. It is reported to cause problems in older kernels, so revert it for now until we can figure it out... Reported-by: Salvatore Bonaccorso Link: https://lore.kernel.org/r/YG7r0UaivWZL762N@eldamar.lan Cc: Shyam Prasad N Cc: Aurelien Aptel Cc: Steve French Cc: Sasha Levin Signed-off-by: Greg Kroah-Hartman (cherry picked from commit ea42fd91d3041b81d704624b87f35b56f3a00841 v5.4.y) Signed-off-by: Tim Gardner Acked-by: Kleber Sacilotto de Souza Acked-by: Kamal Mostafa --- fs/cifs/connect.c | 1 - 1 file changed, 1 deletion(-) diff --git a/fs/cifs/connect.c b/fs/cifs/connect.c index 67c2e6487479..ab9eeb5ff8e5 100644 --- a/fs/cifs/connect.c +++ b/fs/cifs/connect.c @@ -4198,7 +4198,6 @@ int cifs_setup_cifs_sb(struct smb_vol *pvolume_info, cifs_sb->prepath = kstrdup(pvolume_info->prepath, GFP_KERNEL); if (cifs_sb->prepath == NULL) return -ENOMEM; - cifs_sb->mnt_cifs_flags |= CIFS_MOUNT_USE_PREFIX_PATH; } return 0;