From patchwork Mon Apr 12 01:20:05 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dominique MARTINET X-Patchwork-Id: 1464927 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=googlegroups.com (client-ip=2607:f8b0:4864:20::23d; helo=mail-oi1-x23d.google.com; envelope-from=swupdate+bncbcwivbv7sugrbt6az2bqmgqeejy6qma@googlegroups.com; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=googlegroups.com header.i=@googlegroups.com header.a=rsa-sha256 header.s=20161025 header.b=a2P1I4PU; dkim-atps=neutral Received: from mail-oi1-x23d.google.com (mail-oi1-x23d.google.com [IPv6:2607:f8b0:4864:20::23d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4FJWBX1t9dz9sVt for ; Mon, 12 Apr 2021 11:20:18 +1000 (AEST) Received: by mail-oi1-x23d.google.com with SMTP id m1-20020a0568080f01b029013d33a44097sf2297339oiw.16 for ; Sun, 11 Apr 2021 18:20:18 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1618190415; cv=pass; d=google.com; s=arc-20160816; b=tVbmwa/b518kYhGaPtPh7GKO1wsKX3HeXVUieG7CM/l5mYTjBWQ6whxQGo2L5bqR9m I/a0+VBZAWIjYK0jN7G/tyCoxtPwNG99/8GIjg/yhffF7tHUHugpniISSxqSW1XJgc7p SyiTFrOLANI0bonveOpAJ+rcSXvPkEMIxSaC65dcHmzYapU+b6GNru9GGaxUVFlkktgd VYkM8RmVWv9w1e/VTrw8+d/0BhtRlVtdNNSeRdNm9EhfoEGah61sk3YWwbEKTGbaqfw+ IEBTDLSgxKcJTnl+0hukLUBK0EnboX+oug9AKJOq8yJkS2Wcq9ajNHgK58uHm2fY2LII 2sKw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:dkim-signature; bh=6zYlujIxCL/fNx2/FafUCqlvbhg2yN1g/oetc3AzCB0=; b=bCsoQ81yDMr8rOj/YUYimnlwAM1fawQxMhPxVj9J6ylP6IVFzXtsR7jV1ewrEs906c VSo/uv88TxQYuFwq+a6NDwIJb/ThVCPFXa5q5agMMnQVwdWJOpQgMDlQkM6QtFlAnoW5 6f9+iB2Lj9c2FXOwplBZTYcWVHPlWxSuKGy8ppE+JuGPoO30cGpCQvtNxw4iBQ/bQp4h s1rv7WupI5y4OLCF/NsFs0hCpq7+u6Fcq6IxgbaCx8A3Qsnl7ds/2zoa4BSYO/1wKwKR 4WOYo93FZx2p1V1eAD3wGnLxPHmOLbdy3nRqJN4bnnn5OKJhltphDIGLRBMRjhjsV7nP 1CYw== ARC-Authentication-Results: i=2; gmr-mx.google.com; spf=pass (google.com: domain of dominique.martinet@atmark-techno.com designates 13.115.124.170 as permitted sender) smtp.mailfrom=dominique.martinet@atmark-techno.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:x-original-sender:x-original-authentication-results :precedence:mailing-list:list-id:list-post:list-help:list-archive :list-subscribe:list-unsubscribe; bh=6zYlujIxCL/fNx2/FafUCqlvbhg2yN1g/oetc3AzCB0=; b=a2P1I4PUGOTtF9EvQyHI3zJPWjq+Zvv6JDna9JIMCj/yE868EAvtqQNXNhpPbj7kDM 6YgAwqKOrBHvfE885WpZIbbJrEBjn+NjnUUlv8mAMwqpWbVNxYDvVukgnqZjpndt7qww I9i/JtU314eGRHSRDJZtPcSt5Azvmy3AZpKf/mlQjNPhJLiSZ5rbdbRIYn0g7FfsQY7w c+OXdervRY2cnbZknUpkWbwehN/G4/Jxpij1SRNAABKwCF4GzcWkYwmzZ7k/4VOlyGDa Rni59BTGQfBA7tLcQ5SX7UFdCOpAVQOWskWsZlBca0ELkSHPVUQh6+/VU0aRVjfad6ef FPIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=sender:x-gm-message-state:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:x-original-sender :x-original-authentication-results:precedence:mailing-list:list-id :x-spam-checked-in-group:list-post:list-help:list-archive :list-subscribe:list-unsubscribe; bh=6zYlujIxCL/fNx2/FafUCqlvbhg2yN1g/oetc3AzCB0=; b=LX8AK/+snE6KsP6+U3CAWaasJ0G8yCzy9gBFkDXh4N3yEH2xoU51JBkfRSpARBWGkR AoRgprsixuzOn+CKrdSh5DPO1ODKlSakJMAQfV70Xd+YD+qcW/TauVDs/As8VIgbUTt/ LevTomU2PD+iorD9YBo0EcohcwdgDGW44UwzwFbK7OckHQ1HNSALjkuGymxrkAYIBX2Z YWrwfWwLH3qPJFW67Sizc9BBC2jTVPA7MBba3Udeyn3spZsNstLnrPZLpye6h5mU6YVn b1iHuOhuHL0u6KQeIs5Qf4JztZK6xH0cjR7cXge1lHiQky6W1/DTMrsnhPux7cpzlrqa RVkA== Sender: swupdate@googlegroups.com X-Gm-Message-State: AOAM531ep+Ied8XUn1u0vihoxG+F+1bgydiwNMkr1hOJgVs8V9pQuHOl Wdqp3xjQlypRb007WG9pPPU= X-Google-Smtp-Source: ABdhPJxot1XA9iZcyuRU2lgO4cBoEarMNce+MQa0G9Xlms9fpX722D/hohYrUQCNP1m1JsoBwj2AZA== X-Received: by 2002:a05:6830:1e45:: with SMTP id e5mr20991865otj.40.1618190415645; Sun, 11 Apr 2021 18:20:15 -0700 (PDT) X-BeenThere: swupdate@googlegroups.com Received: by 2002:a4a:9732:: with SMTP id u47ls925984ooi.5.gmail; Sun, 11 Apr 2021 18:20:15 -0700 (PDT) X-Received: by 2002:a4a:304a:: with SMTP id z10mr21146689ooz.26.1618190414991; Sun, 11 Apr 2021 18:20:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1618190414; cv=none; d=google.com; s=arc-20160816; b=EJN44HOsVPcDRlgNsZ+VUqva1Oi+LDRCYIydlKdELqejPrVjw+6oQFSsnOknQ0Crpi Uun7wjz84mjc30azc4cgmR4TzvTuYW0zQTmSDI95XndiMkT4dA5+Lo/ia8cNZUPEFdKK hnWfwVfqx6AWVLkk+Fump0ApER80MaLoNmwfCNGlw2622tD/jCYMf39S8UhIxWUNUorX XWM7jKgnn8GYhGLLfX+IgRixgmAmi9eRrssu/1vQ9IG5Tz9Ql95Oq7k97rZXsOkHLQFw OZJfoDUPwxYEREAhfWVsvf3Bh49eNkPYnVNV229vFNlrX1QNmN79A+u8ihqW/mL28TI+ pNWw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from; bh=Ow9echsUk1bgTnmbiYWQ32jrIoDHEywfvmyUETrqOhM=; b=GpFbAOkEr6kqT22vaxRUtXueNgI2fd303qpsvLrVabgdbYY+pUt/JOV3j5owsjbjXd INvNwd+zIJ+MBATLuSPuedKZ9D39v+gocn76JZFmhYScx8Pf3RQaC73gbxz8ntbigbA6 LoldeDm2Ke3SWczvJnGTsf32BP8AlYQBkF82DLu0dH5e8YRheaEdZqWt9/QvGOEJFbEs 9CxGXFFg3MVi8ekrMmSI3J8Rdrhbtr/CHKPc8LtlMAXWuocu80JnHR38LAl5ywTIS09q 45GQx1ixx8+io9qJzsfknIk9WgHcqsW1lxUUnkfh5u3815/njp4lACn8Sh3YSe/PzsyZ AqUA== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of dominique.martinet@atmark-techno.com designates 13.115.124.170 as permitted sender) smtp.mailfrom=dominique.martinet@atmark-techno.com Received: from gw.atmark-techno.com (gw.atmark-techno.com. [13.115.124.170]) by gmr-mx.google.com with ESMTP id v31si509200ott.5.2021.04.11.18.20.14 for ; Sun, 11 Apr 2021 18:20:14 -0700 (PDT) Received-SPF: pass (google.com: domain of dominique.martinet@atmark-techno.com designates 13.115.124.170 as permitted sender) client-ip=13.115.124.170; Received: from gw.atmark-techno.com (localhost [127.0.0.1]) by gw.atmark-techno.com (Postfix) with ESMTP id 790C18021E for ; Mon, 12 Apr 2021 10:20:13 +0900 (JST) Received: from mail-pj1-f70.google.com (mail-pj1-f70.google.com [209.85.216.70]) by gw.atmark-techno.com (Postfix) with ESMTPS id 332938021E for ; Mon, 12 Apr 2021 10:20:13 +0900 (JST) Received: by mail-pj1-f70.google.com with SMTP id q60-20020a17090a7542b02900ddfd0d8edcso1275568pjk.6 for ; Sun, 11 Apr 2021 18:20:13 -0700 (PDT) X-Received: by 2002:a17:90a:fa0c:: with SMTP id cm12mr18667843pjb.54.1618190412008; Sun, 11 Apr 2021 18:20:12 -0700 (PDT) X-Received: by 2002:a17:90a:fa0c:: with SMTP id cm12mr18667832pjb.54.1618190411851; Sun, 11 Apr 2021 18:20:11 -0700 (PDT) Received: from pc-0115 (35.112.198.104.bc.googleusercontent.com. [104.198.112.35]) by smtp.gmail.com with ESMTPSA id e11sm7750579pfv.48.2021.04.11.18.20.10 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 11 Apr 2021 18:20:11 -0700 (PDT) Received: from martinet by pc-0115 with local (Exim 4.94) (envelope-from ) id 1lVlFJ-000UEz-JW; Mon, 12 Apr 2021 10:20:09 +0900 From: Dominique Martinet To: swupdate@googlegroups.com Cc: Dominique Martinet Subject: [swupdate] [PATCH v2] downloader: do not execute post command if install failed Date: Mon, 12 Apr 2021 10:20:05 +0900 Message-Id: <20210412012005.116200-1-dominique.martinet@atmark-techno.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210408052542.3509794-2-dominique.martinet@atmark-techno.com> References: <20210408052542.3509794-2-dominique.martinet@atmark-techno.com> MIME-Version: 1.0 X-Original-Sender: dominique.martinet@atmark-techno.com X-Original-Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of dominique.martinet@atmark-techno.com designates 13.115.124.170 as permitted sender) smtp.mailfrom=dominique.martinet@atmark-techno.com Precedence: list Mailing-list: list swupdate@googlegroups.com; contact swupdate+owners@googlegroups.com List-ID: X-Spam-Checked-In-Group: swupdate@googlegroups.com X-Google-Group-Id: 605343134186 List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , download_from_url should not ignore errors from ipc_wait_for_complete Signed-off-by: Dominique Martinet --- v2: remove unnecessary ipc_wait_for_complete change v2: remove "if (result == FAILURE) result = FAILURE" useless assignment Sorry for the noise. corelib/downloader.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/corelib/downloader.c b/corelib/downloader.c index 6d6a132fd307..a2a7d44eafdb 100644 --- a/corelib/downloader.c +++ b/corelib/downloader.c @@ -54,7 +54,7 @@ static RECOVERY_STATUS download_from_url(channel_data_t* channel_data) if (chanresult != CHANNEL_OK) { result = FAILURE; } - ipc_wait_for_complete(NULL); + result = ipc_wait_for_complete(NULL); channel->close(channel); free(channel); return result;