From patchwork Wed Apr 7 18:50:38 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Manish Varma X-Patchwork-Id: 1463473 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=linux-i2c-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20161025 header.b=V6qtOQFN; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4FFtkx3YS7z9sTD for ; Thu, 8 Apr 2021 04:50:49 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348554AbhDGSu5 (ORCPT ); Wed, 7 Apr 2021 14:50:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49352 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344935AbhDGSu5 (ORCPT ); Wed, 7 Apr 2021 14:50:57 -0400 Received: from mail-pl1-x649.google.com (mail-pl1-x649.google.com [IPv6:2607:f8b0:4864:20::649]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 52EB4C06175F for ; Wed, 7 Apr 2021 11:50:47 -0700 (PDT) Received: by mail-pl1-x649.google.com with SMTP id p12so9552344plw.0 for ; Wed, 07 Apr 2021 11:50:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:in-reply-to:message-id:mime-version:references:subject:from:to :cc; bh=dqDD41JostnIm+5y/7MqI3OZhpg7yT/Ds6kd9YTd5p8=; b=V6qtOQFNTM8SvBnpDbHVJOUk9A/Y1MlH+gwu+i0fp2Uhl4xf6A8Muhkdr6DqS0gyg2 Lx9z/iXySzVYWIteNxCMtLcJtbJjb4VSlukj3WZr+D6vAcHAzf7FaEu/tus8JSWcI3oP uchDpqksWIyKy1kWELyrl81rqPwz9kQaNqE7OCsaKKtuO9SkJ4Fj+lm5mBmPNZ06lHJa Rn6Id6s3YyfPoBYU42NfiVBwoBnYLTix3SW9sRq8Uyq4W08jphMfBg0wKeDdnBJKwm1H djjkVrPt+iGyExNgSQj4S99PPFRu86IvHk1ybjulSMkx3H/SIsAzupgkQqG1ThOl5cZc nMmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc; bh=dqDD41JostnIm+5y/7MqI3OZhpg7yT/Ds6kd9YTd5p8=; b=nXr0E65udpPdLspGGlU9kxXAqgBZlNYdY1I0Id63nxQipLEZitQSZJ4uZoblVWG5uB 3CynoVGExyPB8JcbGhMrTqVFrjtCkfo3yhwhKvRHgpqbH9iN8CnuzmWBbV6wjv0XPI3P +CcgP+E51xeNNlNLBQSfk5EuUBiM59hk0T3i74Ry02jCod4N3+qFLnwd817QDMCyFLmZ dlo2XrOvg7+wetSTrH71b7RRIKwR53aPblPTjYfnEEesFTIFI7rPYkFqcLbGXHO6SudX y+3wOKuQPW7VbOtEnp7prBHRsxlRw4dW/vK6Lq8w/kc+KLX2epRwDL3F04HyxiMx3ZtK 3ygA== X-Gm-Message-State: AOAM533HqX3RiOlarExrWdaP2U6JmG+ML6gfhetq6Ru0195eGu//s4/o 7rA4AbtkmZRQeprNBng61nT1/9gktMg= X-Google-Smtp-Source: ABdhPJwcfgtPigjtbMFrXtAYH7cJZKm/YtGrt45cVvCx8ohPcxcCTAQhVTsdBUYFxOLebvyNwOkBetKj/A0= X-Received: from legoland2.mtv.corp.google.com ([2620:15c:211:1:c151:20a4:9e4a:b11e]) (user=varmam job=sendgmr) by 2002:a17:902:c3cb:b029:e9:706a:1a5c with SMTP id j11-20020a170902c3cbb02900e9706a1a5cmr2797468plj.58.1617821446775; Wed, 07 Apr 2021 11:50:46 -0700 (PDT) Date: Wed, 7 Apr 2021 11:50:38 -0700 In-Reply-To: <20210407185039.621248-1-varmam@google.com> Message-Id: <20210407185039.621248-2-varmam@google.com> Mime-Version: 1.0 References: <20210407185039.621248-1-varmam@google.com> X-Mailer: git-send-email 2.31.0.208.g409f899ff0-goog Subject: [PATCH v1 1/2] dt-bindings: i2c: add "dev-name" property to assign specific device name From: Manish Varma To: Wolfram Sang , Rob Herring Cc: linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@android.com, Manish Varma Precedence: bulk List-ID: X-Mailing-List: linux-i2c@vger.kernel.org I2C devices currently are named dynamically using - convention, unless they are instantiated through ACPI. This means the device name may vary for the same device across different systems, infact even on the same system if the I2C bus enumeration order changes, i.e. because of device tree modifications. By adding an optional "dev-name" property, it provides a mechanism to set consistent and easy to recognize names for I2C devices. Signed-off-by: Manish Varma --- Documentation/devicetree/bindings/i2c/i2c.txt | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/Documentation/devicetree/bindings/i2c/i2c.txt b/Documentation/devicetree/bindings/i2c/i2c.txt index df41f72afc87..6fb03f464b81 100644 --- a/Documentation/devicetree/bindings/i2c/i2c.txt +++ b/Documentation/devicetree/bindings/i2c/i2c.txt @@ -130,6 +130,11 @@ wants to support one of the below features, it should adapt these bindings. - wakeup-source device can be used as a wakeup source. +- dev-name + Name of the device. + Overrides the default device name which is in the form of + -. + Binding may contain optional "interrupts" property, describing interrupts used by the device. I2C core will assign "irq" interrupt (or the very first interrupt if not using interrupt names) as primary interrupt for the slave. From patchwork Wed Apr 7 18:50:39 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Manish Varma X-Patchwork-Id: 1463475 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=linux-i2c-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20161025 header.b=datFYg43; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4FFtl32fX8z9sRf for ; Thu, 8 Apr 2021 04:50:55 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1355436AbhDGSvB (ORCPT ); Wed, 7 Apr 2021 14:51:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49378 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1348580AbhDGSvA (ORCPT ); Wed, 7 Apr 2021 14:51:00 -0400 Received: from mail-yb1-xb4a.google.com (mail-yb1-xb4a.google.com [IPv6:2607:f8b0:4864:20::b4a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 83200C061760 for ; Wed, 7 Apr 2021 11:50:50 -0700 (PDT) Received: by mail-yb1-xb4a.google.com with SMTP id 71so21829543ybl.0 for ; Wed, 07 Apr 2021 11:50:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:in-reply-to:message-id:mime-version:references:subject:from:to :cc; bh=Z+cU0cubea5IW7G2rrulWCH4/axSqIvQteecVrrdERs=; b=datFYg43GzeOSYAuHMH4cqmENNE1YOtm17ojn/kK6cIRea+OF2hpgmVjn/o0YHNJ5k Ewdy0SXBoIjyZic7xDF/r4V92e+lchqNyynmUlCFVLIkCDAeSIRWS75aMmQJadTjntUK KLg/QA4uWUHOdOU0UqYooSENsQfAi7s9dwIyTZCiCAOTwYYO7cw8gD9LHD+l3JskoWMD rQR9QcfITlveNjXK8hynavgw2wMFWb2Kv79R2ZTOiUdb1s0qQl9JithlJXzHsMvL4/HT q/DlQ5OOnyX2HxiFIpkmdItdRHlzRs/T/xSy1HEUDRVcIVk535XJNurcXX8RoH9jfGsb zhkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc; bh=Z+cU0cubea5IW7G2rrulWCH4/axSqIvQteecVrrdERs=; b=PnYrRMXYHTwPjN2yyi0PKRvyqLGGoXrRdZr37w3IuyiZiu87l9ulfb2mc5ny8klEmQ 6GZeXRDb1ySFbIcltR5m61NjA/BLqfQx5lEP50iVpdEi/DXp4npw1U2VFk/802tZQpJV vWrn0j/rslLqEerWkgw+I9YHMzf8ViNn/M3JEzyhsiSOaOBprHjRMhUqkOTf0JMCX3eB WiXv2Ta1NMXDwjJwhchHAa/crqvL9clGPlcB21vZapCmsnldbANu/7Chlqe1b2KUh5jA ep7jGMmma8X1uVUqaz3pZksTT5qxKfZp1pHxExHFS8QUi2kDDHpKqMLMcisoMmi//kuy lqkA== X-Gm-Message-State: AOAM53242SbiOanEFp2xRRJXrACi346rPjOwPdRcqpwymObSir778TRX aYjpiWMehFbEkvadJc+DnRgXpUyE8TA= X-Google-Smtp-Source: ABdhPJzEGo2Im1fwYKE3dyy1xIw1Znu1ydIrq8lcJTb+KNSnCGfz5TR15GLDVFpKnfKOo7fjBPs3VaJsHuk= X-Received: from legoland2.mtv.corp.google.com ([2620:15c:211:1:c151:20a4:9e4a:b11e]) (user=varmam job=sendgmr) by 2002:a25:3057:: with SMTP id w84mr6161945ybw.62.1617821449791; Wed, 07 Apr 2021 11:50:49 -0700 (PDT) Date: Wed, 7 Apr 2021 11:50:39 -0700 In-Reply-To: <20210407185039.621248-1-varmam@google.com> Message-Id: <20210407185039.621248-3-varmam@google.com> Mime-Version: 1.0 References: <20210407185039.621248-1-varmam@google.com> X-Mailer: git-send-email 2.31.0.208.g409f899ff0-goog Subject: [PATCH v1 2/2] i2c: use "dev-name" device tree property to override device name From: Manish Varma To: Wolfram Sang , Rob Herring Cc: linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@android.com, Manish Varma Precedence: bulk List-ID: X-Mailing-List: linux-i2c@vger.kernel.org Since the dev_name field of i2c_board_info is not set while instantiating an I2C device, they are named like -, unless they are instantiated through ACPI. These coded names are less desirable in some situations as they will vary across systems with different hardware configurations, and even also on the same system as the adapter_id may change with change in the order of i2c bus enumeration (i.e. due to device tree modifications). These device names are further used by other modules like "system wakeup events framework" to assign the name of wakeup_source. So overall this causes somewhat difficult to interpret device and wakeup source names, and hence presents difficulties debuging issues at multiple levels. This change addresses above mentioned problem by setting dev_name field based on value assigned to an optional "dev-name" property of device tree (if present). And as a result of this, i2c_dev_set_name() should now use the actual device name instead of made up one. Signed-off-by: Manish Varma --- drivers/i2c/i2c-core-of.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/i2c/i2c-core-of.c b/drivers/i2c/i2c-core-of.c index 3ed74aa4b44b..d7a85a9cc499 100644 --- a/drivers/i2c/i2c-core-of.c +++ b/drivers/i2c/i2c-core-of.c @@ -58,6 +58,8 @@ int of_i2c_get_board_info(struct device *dev, struct device_node *node, if (of_get_property(node, "wakeup-source", NULL)) info->flags |= I2C_CLIENT_WAKE; + of_property_read_string(node, "dev-name", &(info->dev_name)); + return 0; } EXPORT_SYMBOL_GPL(of_i2c_get_board_info);