From patchwork Mon Mar 22 08:08:37 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gwendal Grignou X-Patchwork-Id: 1456410 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=linux-ide-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256 header.s=google header.b=mlisv27t; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4F3nGg09YCz9sW1 for ; Mon, 22 Mar 2021 19:09:47 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229692AbhCVIJN (ORCPT ); Mon, 22 Mar 2021 04:09:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51496 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229574AbhCVIIo (ORCPT ); Mon, 22 Mar 2021 04:08:44 -0400 Received: from mail-pg1-x52f.google.com (mail-pg1-x52f.google.com [IPv6:2607:f8b0:4864:20::52f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A8B06C061756 for ; Mon, 22 Mar 2021 01:08:43 -0700 (PDT) Received: by mail-pg1-x52f.google.com with SMTP id 32so1973744pgm.1 for ; Mon, 22 Mar 2021 01:08:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Kh/xmFXhfHtNnqJEg2fD821X69nj58fO7kUzZqMc42Y=; b=mlisv27tJfvboLmPEj1JWnpGIbJugxo3Agmmvfkxi+/5ARKINWIPHc7dt+WSC8nX9d oejV3PK5oTscj446aBJVgdKZsbBdx+WlGyV2jX12cYuRR2iKTMTL8px2tVYo1ryofRGc /r6BgJNiCswdx+n67KUDicklcE8OP8URigWeE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Kh/xmFXhfHtNnqJEg2fD821X69nj58fO7kUzZqMc42Y=; b=WXJSl7GDpMw99idHPkrEC3N6HjjPlHbiglfxk5xt8Df0hl+9FjYGXeBC0pzY03su6b FaUt+OzQnFLIVRmJIgIvw6q02XDGxh2zjVVKjOpSl7ZdkjM0wBlMvnL4l21GtZbROscq nNyNog2hIxjClHSzP7FCTe/pRhZlSTbSn8O3W6wx4usWbEFqFYBAAWU3rcFxBQbqQo/l 2R57J5dsPb2FMqm9xwhIsbqAIXc3RUp9tcedDYW8IqionJ6WLTsbz+Yyd7E501YDA1HR 6n1JlMFfI7ckX4EnWExlGLhS/VIvt2yVzqepy5KH9hNo7zUXD/wegSGiAAe0PRaW5KDW YknA== X-Gm-Message-State: AOAM531zSycfY0Fsm3EyK1509BK2bweRN5TmUExKk6EworAVWG9jXtSt aSrYECX3xy/1lILsHrSoqM98Ou4/cgrbkw== X-Google-Smtp-Source: ABdhPJxrjGOntJAWM/d1E6/2YCUkeyR+w5dUrpLdC/fp1IQLZ3qUhJ/N0nqxJxT+5UxdP592h6HZMA== X-Received: by 2002:a63:df09:: with SMTP id u9mr21704387pgg.64.1616400523274; Mon, 22 Mar 2021 01:08:43 -0700 (PDT) Received: from localhost ([2620:15c:202:201:90ec:f36d:f115:8c9e]) by smtp.gmail.com with UTF8SMTPSA id gm10sm12691994pjb.4.2021.03.22.01.08.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 22 Mar 2021 01:08:42 -0700 (PDT) From: Gwendal Grignou To: tj@kernel.org, sergei.shtylyov@gmail.com Cc: linux-ide@vger.kernel.org, Gwendal Grignou Subject: [PATCH v2 1/2] driver: ahci: Allow disabling dlpm for all bios version Date: Mon, 22 Mar 2021 01:08:37 -0700 Message-Id: <20210322080838.1640805-2-gwendal@chromium.org> X-Mailer: git-send-email 2.31.0.291.g576ba9dcdaf-goog In-Reply-To: <20210322080838.1640805-1-gwendal@chromium.org> References: <20210322080838.1640805-1-gwendal@chromium.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org In ahci_broken_lpm(), dmi->driver_data is encoded as a date: if the date of the current BIOS is older than driver_data, the LPM horkage is not applied. Allow dmi->driver_data to be empty in case a problem is not fixed in any BIOS version. Signed-off-by: Gwendal Grignou --- Changes in v2: Fix cut and paste error in commit message. drivers/ata/ahci.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c index 5f1f049063dd2..9132201f1353e 100644 --- a/drivers/ata/ahci.c +++ b/drivers/ata/ahci.c @@ -1279,6 +1279,9 @@ static bool ahci_broken_lpm(struct pci_dev *pdev) if (!dmi) return false; + if (!dmi->driver_data) + return true; + dmi_get_date(DMI_BIOS_DATE, &year, &month, &date); snprintf(buf, sizeof(buf), "%04d%02d%02d", year, month, date); From patchwork Mon Mar 22 08:08:38 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gwendal Grignou X-Patchwork-Id: 1456408 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=linux-ide-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256 header.s=google header.b=F02NqvEb; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4F3nGf4jCjz9sVt for ; Mon, 22 Mar 2021 19:09:46 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229574AbhCVIJO (ORCPT ); Mon, 22 Mar 2021 04:09:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51504 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229872AbhCVIIp (ORCPT ); Mon, 22 Mar 2021 04:08:45 -0400 Received: from mail-pj1-x1031.google.com (mail-pj1-x1031.google.com [IPv6:2607:f8b0:4864:20::1031]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0FB5CC061762 for ; Mon, 22 Mar 2021 01:08:45 -0700 (PDT) Received: by mail-pj1-x1031.google.com with SMTP id s21so7985046pjq.1 for ; Mon, 22 Mar 2021 01:08:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ceWIJkraNk4zg/iwScfPX26TgRjVfcMLFyh1eZXV7JM=; b=F02NqvEbBpYoGKlemzhDNLk9mqNsPvWGB9TA6POHCKFxPBRmHqbZO/hyACWUFXEMca DK8ysDpNm2HNfxe4Hb4d6QNWQZJPNnK90UFjGXokbvWWi/jKwnbFgoMu9VbTpie17ri/ eKv6AcVz7tbsjehrxEgC54JVsXHUQjWJlx1FE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ceWIJkraNk4zg/iwScfPX26TgRjVfcMLFyh1eZXV7JM=; b=kov1XXwT82ZivTtYaCl72HtaxeGRjtlY6n+QjY1gf9LfJmAR2M9sKmikuWrZRRl8Hj tdeBZOQ7AqvxgJoZirWj7h3yqsnFwGPZ8320aDKdsA0gMI5M2ZxgMAUrpAdeWZyknwXe Mgbs7LJPyFuam8JxvMnEAmXwrWA/uLTt51wfIZ2OSisLUZ0P+6I6fKnAQct1rmPOqDBt HnSR8HONh6k5O14ShxJiO6dAv5sXi3MwnYaWO0OAqHCTkXz+y3ao9CenI4QFofIPFXrn dTDHojrpGpdHgFn5cox/Pl0AuBG+ITTeINAzwMRAJ7kwWb8v+NnKMqQiVxupajEt4tPT EeRQ== X-Gm-Message-State: AOAM5317nvEGrdlPEAvsT3q8jG+2z28YHU89YNSwq3WJsD3clDvGd7aG i7AzJLcVxPDw++aKPO3PghwXXL5NRQP9cA== X-Google-Smtp-Source: ABdhPJzDbk6X4pTI4NCXvkM612xhOhHrbwRVTIoCm/aTaD/AVaVovzaw3xdN0IxHMI2JiEMk5/b1gg== X-Received: by 2002:a17:902:f20a:b029:e6:6d5b:88bf with SMTP id m10-20020a170902f20ab02900e66d5b88bfmr25942464plc.13.1616400524649; Mon, 22 Mar 2021 01:08:44 -0700 (PDT) Received: from localhost ([2620:15c:202:201:90ec:f36d:f115:8c9e]) by smtp.gmail.com with UTF8SMTPSA id t1sm12960867pfc.173.2021.03.22.01.08.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 22 Mar 2021 01:08:44 -0700 (PDT) From: Gwendal Grignou To: tj@kernel.org, sergei.shtylyov@gmail.com Cc: linux-ide@vger.kernel.org, Gwendal Grignou Subject: [PATCH v2 2/2] driver: ahci: Disable DLPM on Fizz chromebox Date: Mon, 22 Mar 2021 01:08:38 -0700 Message-Id: <20210322080838.1640805-3-gwendal@chromium.org> X-Mailer: git-send-email 2.31.0.291.g576ba9dcdaf-goog In-Reply-To: <20210322080838.1640805-1-gwendal@chromium.org> References: <20210322080838.1640805-1-gwendal@chromium.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org On Chromebox Fizz platform, (HP Chromebox G2, ASUS Chromebox 3, ...), hard CPU freeze were observed when the SSD DLPM is engaged at 'min_power'. Ensure we can not change the |link_power_management_policy| of the host controller connected to the root SSD. (Operation not supported). Signed-off-by: Gwendal Grignou --- No changes in v2. drivers/ata/ahci.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c index 9132201f1353e..4b932bb4ed570 100644 --- a/drivers/ata/ahci.c +++ b/drivers/ata/ahci.c @@ -1270,6 +1270,12 @@ static bool ahci_broken_lpm(struct pci_dev *pdev) */ .driver_data = "20180310", /* 2.35 */ }, + { + .matches = { + DMI_MATCH(DMI_BOARD_VENDOR, "Google"), + DMI_MATCH(DMI_BOARD_NAME, "Fizz"), + }, + }, { } /* terminate list */ }; const struct dmi_system_id *dmi = dmi_first_match(sysids);