From patchwork Thu Mar 18 10:40:27 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1455221 Return-Path: X-Original-To: incoming-dt@patchwork.ozlabs.org Delivered-To: patchwork-incoming-dt@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=devicetree-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=TBI1ujph; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4F1Nqf508yz9sVw for ; Thu, 18 Mar 2021 21:41:34 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230263AbhCRKlC (ORCPT ); Thu, 18 Mar 2021 06:41:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33340 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230218AbhCRKkq (ORCPT ); Thu, 18 Mar 2021 06:40:46 -0400 Received: from mail-wr1-x433.google.com (mail-wr1-x433.google.com [IPv6:2a00:1450:4864:20::433]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7C6AAC06174A for ; Thu, 18 Mar 2021 03:40:46 -0700 (PDT) Received: by mail-wr1-x433.google.com with SMTP id x13so4956626wrs.9 for ; Thu, 18 Mar 2021 03:40:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=1tEtqfwOT8tRZ9fytdoNTk6qtPKeMjP57sn7aBTbcvY=; b=TBI1ujphYCROOuN2IGHeqLZfcbf6KaQWLfajxnq9SCUdvYO9iPY2o0LiqFSfmSQ9Ql 6bMjy/Sm9mueCSJr2bWsg75dXG9XIMnxgYBiEQUFbpSG3y8DGI8NudQvBtdfjQhuDvng BVvbYOFNGWUoanC/VkrYNk2IDFJHjyhJkryajzdxM+z2v2gOpgmuwgvIweZ6+2zeA6fa NLdFNBi75WhvLVWRwYlS7aI22rJCpvjmuJ65mqjVEL0r+MchSpxieyNM8NFGWURuXzXE G1i1tiMaKvrLAS8ns84rr8v74hdGh9iWc1m3tQXHEkaKi5DbguxiqvdiFocllQnvtqs9 Yjpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=1tEtqfwOT8tRZ9fytdoNTk6qtPKeMjP57sn7aBTbcvY=; b=Du4n3R+ncDWZdsPF68+RPFee79M2ZCSR/Cp2jC98R4jIosI+vvvmUm4OtoWAAjXOKI J3LYINNVEMq2TdRvZ9erA+PxKVYCaNdcWS6MPyv+9ENfuxEpHkQRKeBOkDMb1PGM9cxV b2SofPDPVnoPNttgFFg2yRPKQveIaaKQwwBk+3vC5nJH4/PtATmphurpURiShXlL49lC 2KqPNtddurxv25TIFF0IwMhyosPugTb1ExPZLqO67UViwNfhYJe2bwrUHTWXeynef5xo M3uzlBNUhiTtZ57DOXWS6Fq+7U2XNERXVc6F+M44sMx1cPvevgtM9F8loSqMDpV04Gkj pt5g== X-Gm-Message-State: AOAM531XXp6Wb3zheBdxBH4GZlCrAp+b8ZkRLVEpvrLufdFpmI13D4vg akUXxUwQ3pe9UKDZix9bWXZRfw== X-Google-Smtp-Source: ABdhPJydJChfSJV1NmxCjDp6DMd0HgDgPwmtfA49Tck2MQgoEEEkqrOYyzMyq6clS6JgzRfYWwJiDQ== X-Received: by 2002:adf:fcc9:: with SMTP id f9mr8989118wrs.420.1616064045253; Thu, 18 Mar 2021 03:40:45 -0700 (PDT) Received: from dell.default ([91.110.221.194]) by smtp.gmail.com with ESMTPSA id z1sm2426033wru.95.2021.03.18.03.40.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Mar 2021 03:40:44 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Rob Herring , Frank Rowand , devicetree@vger.kernel.org Subject: [PATCH 01/10] of: device: Fix function name in header and provide missing descriptions Date: Thu, 18 Mar 2021 10:40:27 +0000 Message-Id: <20210318104036.3175910-2-lee.jones@linaro.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210318104036.3175910-1-lee.jones@linaro.org> References: <20210318104036.3175910-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/of/device.c:72: warning: expecting prototype for of_dma_configure(). Prototype was for of_dma_configure_id() instead drivers/of/device.c:263: warning: Function parameter or member 'dev' not described in 'of_device_modalias' drivers/of/device.c:263: warning: Function parameter or member 'str' not described in 'of_device_modalias' drivers/of/device.c:263: warning: Function parameter or member 'len' not described in 'of_device_modalias' drivers/of/device.c:280: warning: Function parameter or member 'dev' not described in 'of_device_uevent' drivers/of/device.c:280: warning: Function parameter or member 'env' not described in 'of_device_uevent' Cc: Rob Herring Cc: Frank Rowand Cc: devicetree@vger.kernel.org Signed-off-by: Lee Jones --- drivers/of/device.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/of/device.c b/drivers/of/device.c index 6cb86de404f1c..c5a9473a5fb1a 100644 --- a/drivers/of/device.c +++ b/drivers/of/device.c @@ -53,7 +53,7 @@ int of_device_add(struct platform_device *ofdev) } /** - * of_dma_configure - Setup DMA configuration + * of_dma_configure_id - Setup DMA configuration * @dev: Device to apply DMA configuration * @np: Pointer to OF node having DMA configuration * @force_dma: Whether device is to be set up by of_dma_configure() even if @@ -258,6 +258,9 @@ EXPORT_SYMBOL_GPL(of_device_request_module); /** * of_device_modalias - Fill buffer with newline terminated modalias string + * @dev: Calling device + * @str: Modalias string + * @len: Size of @str */ ssize_t of_device_modalias(struct device *dev, char *str, ssize_t len) { @@ -275,6 +278,8 @@ EXPORT_SYMBOL_GPL(of_device_modalias); /** * of_device_uevent - Display OF related uevent information + * @dev: Device to apply DMA configuration + * @env: Kernel object's userspace event reference */ void of_device_uevent(struct device *dev, struct kobj_uevent_env *env) { From patchwork Thu Mar 18 10:40:28 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1455222 Return-Path: X-Original-To: incoming-dt@patchwork.ozlabs.org Delivered-To: patchwork-incoming-dt@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=devicetree-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=R8uOHjvb; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4F1Nqh44Z7z9sWF for ; Thu, 18 Mar 2021 21:41:36 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230246AbhCRKlD (ORCPT ); Thu, 18 Mar 2021 06:41:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33342 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230221AbhCRKkr (ORCPT ); Thu, 18 Mar 2021 06:40:47 -0400 Received: from mail-wm1-x32a.google.com (mail-wm1-x32a.google.com [IPv6:2a00:1450:4864:20::32a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5C144C061760 for ; Thu, 18 Mar 2021 03:40:47 -0700 (PDT) Received: by mail-wm1-x32a.google.com with SMTP id t5-20020a1c77050000b029010e62cea9deso3064642wmi.0 for ; Thu, 18 Mar 2021 03:40:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=hNM7oYxDpUVruJupFtOo+nkAp1rdd1yt5xHzqF7N4tE=; b=R8uOHjvb96TRkgdKsmr7NEuIsHxxOwB9zHlgFIeN32iHimikWiYHdnN3fdKtYnf8ZY kUtsqru6YrMhLZrJZixPy94Ie+6GMpH9wPAjnVbCDKvO5ZwJuQh3+VzY8Mb32KtFuAlm aIRao9qjYO6RrR9T0T7oAWUFDROSvvW/PNGXzcNT90JMG2xklFEuIdRUUIPCtzD99xqW Ofwuq8Ocm0dqlL2pl2nvhwGovLNzOiWZF6JwLICdkW4KEZ9BecxPY0kMo1k8p6M3BM9E FLaBI2SsciwtncY8+0Jck3PWFbDo+jsgx7VsqD4Uk8MNQlFiQZmGe8u7wQXgPR0WjBm7 vU1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=hNM7oYxDpUVruJupFtOo+nkAp1rdd1yt5xHzqF7N4tE=; b=XfXSnHrSlI1ps4YAFUtToW9foZlh7zmuT14lh3ap/qVNfOJyIURoZVQ9mE+4C1zNTr QFlc9VoGm1Jw0uBpaqmv5PfNwgLUy85rwTk5CMDaB9Sn9sJ1+ko4AjTyvoGUTpSNCAtg 8LcGKwkv6f4gWYfM3wzW351xXTIve9lTGxEd8WW0neK4uW/OXhC5QF4jhiG11m5pELq0 wizDU0YNazElzh4kVS5My266IQm3dX1IlQznXTvSLeZnLPtwu+RQjsYeJhgNDR71fHk9 qe6jJfQJ53GAZqlONJvqUQJv5AxWUCKf0ofvoCMGaoxHb4Y09flFrgtM8gpmo7IQUy1t FvYg== X-Gm-Message-State: AOAM530nMMCV1WoAi2V0UBxMlm4br4JdZqHuIwDFbw8gpjTeXSZkbrAS xz7Oi4MbqAk4ddAOCX0o+qjJMA== X-Google-Smtp-Source: ABdhPJxbhtsgPmv0QKMRvdkSNXXI59ugi2qKs01BGhNK/DMFYqd5nNsrW4PCHCP0Q4jn8MjMzTc2vA== X-Received: by 2002:a7b:cf16:: with SMTP id l22mr2938633wmg.26.1616064046073; Thu, 18 Mar 2021 03:40:46 -0700 (PDT) Received: from dell.default ([91.110.221.194]) by smtp.gmail.com with ESMTPSA id z1sm2426033wru.95.2021.03.18.03.40.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Mar 2021 03:40:45 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Rob Herring , Frank Rowand , devicetree@vger.kernel.org Subject: [PATCH 02/10] of: dynamic: Fix incorrect parameter name and provide missing descriptions Date: Thu, 18 Mar 2021 10:40:28 +0000 Message-Id: <20210318104036.3175910-3-lee.jones@linaro.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210318104036.3175910-1-lee.jones@linaro.org> References: <20210318104036.3175910-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/of/dynamic.c:234: warning: Function parameter or member 'np' not described in 'of_attach_node' drivers/of/dynamic.c:286: warning: Function parameter or member 'np' not described in 'of_detach_node' drivers/of/dynamic.c:326: warning: Function parameter or member 'kobj' not described in 'of_node_release' drivers/of/dynamic.c:326: warning: Excess function parameter 'kref' description in 'of_node_release' Cc: Rob Herring Cc: Frank Rowand Cc: devicetree@vger.kernel.org Signed-off-by: Lee Jones --- drivers/of/dynamic.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/of/dynamic.c b/drivers/of/dynamic.c index 9a824decf61f1..1d7a22e44d787 100644 --- a/drivers/of/dynamic.c +++ b/drivers/of/dynamic.c @@ -229,6 +229,7 @@ static void __of_attach_node(struct device_node *np) /** * of_attach_node() - Plug a device node into the tree and global list. + * @np: Pointer to the caller's Device Node */ int of_attach_node(struct device_node *np) { @@ -281,6 +282,7 @@ void __of_detach_node(struct device_node *np) /** * of_detach_node() - "Unplug" a node from the device tree. + * @np: Pointer to the caller's Device Node */ int of_detach_node(struct device_node *np) { @@ -318,7 +320,7 @@ static void property_list_free(struct property *prop_list) /** * of_node_release() - release a dynamically allocated node - * @kref: kref element of the node to be released + * @kobj: kernel object of the node to be released * * In of_node_put() this function is passed to kref_put() as the destructor. */ From patchwork Thu Mar 18 10:40:29 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1455225 Return-Path: X-Original-To: incoming-dt@patchwork.ozlabs.org Delivered-To: patchwork-incoming-dt@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=devicetree-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=GuBzzHwN; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4F1Nqj6hz7z9sWF for ; Thu, 18 Mar 2021 21:41:37 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230185AbhCRKlE (ORCPT ); Thu, 18 Mar 2021 06:41:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33342 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230228AbhCRKks (ORCPT ); Thu, 18 Mar 2021 06:40:48 -0400 Received: from mail-wr1-x431.google.com (mail-wr1-x431.google.com [IPv6:2a00:1450:4864:20::431]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4852DC06174A for ; Thu, 18 Mar 2021 03:40:48 -0700 (PDT) Received: by mail-wr1-x431.google.com with SMTP id 61so4940734wrm.12 for ; Thu, 18 Mar 2021 03:40:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=D47E9cXI25ZmpKM2KpzUfb+svP/iduBPVqgRHs8FW7k=; b=GuBzzHwNpGCMJsxMH0vBYUieY3F/wvAkaVX80KXINM+vaKEoLZmDYmeJSPOWRQP9HM hM03aKE5RZlY82CF2l5i85NmKPGjOE6gFdSg4k5ue910yMkF1o/lU8GgxcfC7xBpPd+4 4oCxFRCEDVyrx3RDhO+qcncsO/JSZL+BvKPKLJyG6MxodvsKHgpb+TvsbFj6Gj6LXiRT L9YpCaXCptAYJz8aDsTbBi+KnvYZ0lfzbe5XqjCiAF6vcx6QzRRqoNtZ1fkqSRjgTEvl BaBERZ9mJcEgQ2Gy5TWPLIUeLXoSFFImWDdmgKcsFkeEXhCH3tXlnve/f9RO/vM24iQ3 j0wQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=D47E9cXI25ZmpKM2KpzUfb+svP/iduBPVqgRHs8FW7k=; b=gULLDHsxtOw5fjdguDkxruyxCWOvU9IEONRPvcwt7oyHuQGqFLhSfSv4J6VobDtaWy at8YEylZPVgNO7ZKTZx0/RZ3IgcEwAQBKkyjz81khuwi+Oj/xGAtXGZY9AmvQl0xM1on BrQ6YduVZeOcQkz5zv97XxK1W3apYg6i1S/Lvx43ul1TBvhHpfLwvnjnnKqbOMO5g0Gb lFfdWP1QW2bgaqP+u84u0CxXXPz8x9OPs44DNVOwyCytHYWrSXA9tzbR48yGFwkhRBCl eIooRDasZF/7UyL2WJmENnIhYLp1Mc7L6l4uJhyYSh3VUNR8C3awVW2PVrw/DOv2tchq Xrfg== X-Gm-Message-State: AOAM5310W+kjNJh5OhCsL49v71iP1+aoQFsNTC/4cNBs2F3zV1XIBJUP vJ+5KRzrFQmCOzRRcBJY9n4BKA== X-Google-Smtp-Source: ABdhPJwVNci206Jnw2L2wqrutJvXe9n0Oeaa4TKVFK/3tRWitjZGQk3GPzIKJgENvQ/7dixs5d2p6A== X-Received: by 2002:a5d:640b:: with SMTP id z11mr8689752wru.327.1616064047033; Thu, 18 Mar 2021 03:40:47 -0700 (PDT) Received: from dell.default ([91.110.221.194]) by smtp.gmail.com with ESMTPSA id z1sm2426033wru.95.2021.03.18.03.40.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Mar 2021 03:40:46 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Rob Herring , Frank Rowand , Kees Cook , Anton Vorontsov , Colin Cross , Tony Luck , benh@kernel.crashing.org, devicetree@vger.kernel.org Subject: [PATCH 03/10] of: platform: Demote kernel-doc abuse Date: Thu, 18 Mar 2021 10:40:29 +0000 Message-Id: <20210318104036.3175910-4-lee.jones@linaro.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210318104036.3175910-1-lee.jones@linaro.org> References: <20210318104036.3175910-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/of/platform.c:298: warning: Function parameter or member 'lookup' not described in 'of_dev_lookup' drivers/of/platform.c:298: warning: Function parameter or member 'np' not described in 'of_dev_lookup' Cc: Rob Herring Cc: Frank Rowand Cc: Kees Cook Cc: Anton Vorontsov Cc: Colin Cross Cc: Tony Luck Cc: benh@kernel.crashing.org Cc: devicetree@vger.kernel.org Signed-off-by: Lee Jones --- drivers/of/platform.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/of/platform.c b/drivers/of/platform.c index 0da86209ddaab..0ed46d301431b 100644 --- a/drivers/of/platform.c +++ b/drivers/of/platform.c @@ -290,7 +290,7 @@ static struct amba_device *of_amba_device_create(struct device_node *node, } #endif /* CONFIG_ARM_AMBA */ -/** +/* * of_dev_lookup() - Given a device node, lookup the preferred Linux name */ static const struct of_dev_auxdata *of_dev_lookup(const struct of_dev_auxdata *lookup, From patchwork Thu Mar 18 10:40:30 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1455224 Return-Path: X-Original-To: incoming-dt@patchwork.ozlabs.org Delivered-To: patchwork-incoming-dt@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=devicetree-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=KRRNlLMv; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4F1Nqj3dlvz9sVw for ; Thu, 18 Mar 2021 21:41:37 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230203AbhCRKlE (ORCPT ); Thu, 18 Mar 2021 06:41:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33358 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230232AbhCRKkt (ORCPT ); Thu, 18 Mar 2021 06:40:49 -0400 Received: from mail-wr1-x434.google.com (mail-wr1-x434.google.com [IPv6:2a00:1450:4864:20::434]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1046EC061763 for ; Thu, 18 Mar 2021 03:40:49 -0700 (PDT) Received: by mail-wr1-x434.google.com with SMTP id 61so4940763wrm.12 for ; Thu, 18 Mar 2021 03:40:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=E4h/C6T84HxYsM0qAYAlk6c6TY3ISMeByeH+9EbuzfU=; b=KRRNlLMvzBiVLMTp4uW28iRLrI+eTs1hQfXzmzC2/MtESViCMqhjBq0SsrvYsW5I4O eJB+PRtNxU8nWaByICbJeuEzTmZBsoMRpgyZ5L8Q8GbRk+QlVXInAPDIImQ/qacJGwbq HKE4iXo6wFAav6YXwFyW1UmHhZNIrYpreymbLoxTE0pZgPyTiZqWvqB5VugcD7Cy8MBu iPFRfqzXkDsYbSsL6GKFiXINf2umU1CY0dMd4QrSazFCsnZ1p0LNRnsRPRL+dJcwYzSa jreeMZYqEOnFjB5yATGGgLCIx+SEhmS1w0XprLmL++OpkJFv8Vl1CHra0MdezCw5Q4H3 AlOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=E4h/C6T84HxYsM0qAYAlk6c6TY3ISMeByeH+9EbuzfU=; b=J6IJhr4nis2/cGFaOG9BkOWyRW83BX6t56Gd70LAqEnTzwOao2VNIigwOASw+sVy71 5DeoHLEx58+ok84h/ASH/o7GaizmYD3C/ictliOkYaDEf1rmDy7/kfPJhSPyZx4ZeuVS QPEkA9RNiP+Ffpm3+PNS4HW7D3UMtWzfHec2NxBjN3fmHPIL0hwEJ52oqTsJDTmbxkVx T8eECOwfeGp6XTL3LHue3tuyeLFp12WOT0wfDrIToZ3R9YbuCQIiexa9LexxTZFXI+VA 7+6M/AlOdQLcNi3kK86Abf4TNz03b5glSQjPcka53smWjelZMZ5KEAHIXP5QhJTiku6Z gqqg== X-Gm-Message-State: AOAM533tsVnIGimUdmIUmcSxtlJwDX2CAaRuS7xmgJ9mtscxZPtZBtz9 8PK2swUBwvPohq751Btb+y8Mkg== X-Google-Smtp-Source: ABdhPJzqh3WkVA8+9bX4WzO9yrw28Rt//sQJneyWO1w1Svu7x5bsUmRfIW7gjP+RbexuUKJrA7WBnA== X-Received: by 2002:a5d:42d2:: with SMTP id t18mr8945779wrr.258.1616064047835; Thu, 18 Mar 2021 03:40:47 -0700 (PDT) Received: from dell.default ([91.110.221.194]) by smtp.gmail.com with ESMTPSA id z1sm2426033wru.95.2021.03.18.03.40.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Mar 2021 03:40:47 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Rob Herring , Frank Rowand , "David S. Miller" , devicetree@vger.kernel.org Subject: [PATCH 04/10] of: base: Fix some formatting issues and provide missing descriptions Date: Thu, 18 Mar 2021 10:40:30 +0000 Message-Id: <20210318104036.3175910-5-lee.jones@linaro.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210318104036.3175910-1-lee.jones@linaro.org> References: <20210318104036.3175910-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/of/base.c:315: warning: Function parameter or member 'cpun' not described in '__of_find_n_match_cpu_property' drivers/of/base.c:315: warning: Function parameter or member 'prop_name' not described in '__of_find_n_match_cpu_property' drivers/of/base.c:315: warning: Function parameter or member 'cpu' not described in '__of_find_n_match_cpu_property' drivers/of/base.c:315: warning: Function parameter or member 'thread' not described in '__of_find_n_match_cpu_property' drivers/of/base.c:315: warning: expecting prototype for property holds the physical id of the(). Prototype was for __of_find_n_match_cpu_property() instead drivers/of/base.c:1139: warning: Function parameter or member 'match' not described in 'of_find_matching_node_and_match' drivers/of/base.c:1779: warning: Function parameter or member 'np' not described in '__of_add_property' drivers/of/base.c:1779: warning: Function parameter or member 'prop' not described in '__of_add_property' drivers/of/base.c:1800: warning: Function parameter or member 'np' not described in 'of_add_property' drivers/of/base.c:1800: warning: Function parameter or member 'prop' not described in 'of_add_property' drivers/of/base.c:1849: warning: Function parameter or member 'np' not described in 'of_remove_property' drivers/of/base.c:1849: warning: Function parameter or member 'prop' not described in 'of_remove_property' drivers/of/base.c:2137: warning: Function parameter or member 'dn' not described in 'of_console_check' drivers/of/base.c:2137: warning: Function parameter or member 'name' not described in 'of_console_check' drivers/of/base.c:2137: warning: Function parameter or member 'index' not described in 'of_console_check' Cc: Rob Herring Cc: Frank Rowand Cc: "David S. Miller" Cc: devicetree@vger.kernel.org Signed-off-by: Lee Jones --- drivers/of/base.c | 16 +++++++++++----- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/drivers/of/base.c b/drivers/of/base.c index 8a348f0d3c5e7..457d1ec27300b 100644 --- a/drivers/of/base.c +++ b/drivers/of/base.c @@ -305,7 +305,7 @@ bool __weak arch_match_cpu_phys_id(int cpu, u64 phys_id) return (u32)phys_id == cpu; } -/** +/* * Checks if the given "prop_name" property holds the physical id of the * core/thread corresponding to the logical cpu 'cpu'. If 'thread' is not * NULL, local thread number within the core is returned in it. @@ -1128,7 +1128,7 @@ EXPORT_SYMBOL(of_match_node); * will; typically, you pass what the previous call * returned. of_node_put() will be called on it * @matches: array of of device match structures to search in - * @match Updated to point at the matches entry which matched + * @match: Updated to point at the matches entry which matched * * Returns a node pointer with refcount incremented, use * of_node_put() on it when done. @@ -1774,6 +1774,8 @@ EXPORT_SYMBOL(of_count_phandle_with_args); /** * __of_add_property - Add a property to a node without lock operations + * @np: Caller's Device Node + * @prob: Property to add */ int __of_add_property(struct device_node *np, struct property *prop) { @@ -1795,6 +1797,8 @@ int __of_add_property(struct device_node *np, struct property *prop) /** * of_add_property - Add a property to a node + * @np: Caller's Device Node + * @prob: Property to add */ int of_add_property(struct device_node *np, struct property *prop) { @@ -1839,6 +1843,8 @@ int __of_remove_property(struct device_node *np, struct property *prop) /** * of_remove_property - Remove a property from a node. + * @np: Caller's Device Node + * @prob: Property to remove * * Note that we don't actually remove it, since we have given out * who-knows-how-many pointers to the data using get-property. @@ -2125,9 +2131,9 @@ EXPORT_SYMBOL_GPL(of_alias_get_highest_id); /** * of_console_check() - Test and setup console for DT setup - * @dn - Pointer to device node - * @name - Name to use for preferred console without index. ex. "ttyS" - * @index - Index to use for preferred console. + * @dn: Pointer to device node + * @name: Name to use for preferred console without index. ex. "ttyS" + * @index: Index to use for preferred console. * * Check if the given device node matches the stdout-path property in the * /chosen node. If it does then register it as the preferred console and return From patchwork Thu Mar 18 10:40:31 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1455227 Return-Path: X-Original-To: incoming-dt@patchwork.ozlabs.org Delivered-To: patchwork-incoming-dt@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=devicetree-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=m2pcdvCl; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4F1Nql0zzbz9sVw for ; Thu, 18 Mar 2021 21:41:39 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230221AbhCRKlF (ORCPT ); Thu, 18 Mar 2021 06:41:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33342 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230239AbhCRKku (ORCPT ); Thu, 18 Mar 2021 06:40:50 -0400 Received: from mail-wm1-x332.google.com (mail-wm1-x332.google.com [IPv6:2a00:1450:4864:20::332]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EA34BC061762 for ; Thu, 18 Mar 2021 03:40:49 -0700 (PDT) Received: by mail-wm1-x332.google.com with SMTP id g25so3245285wmh.0 for ; Thu, 18 Mar 2021 03:40:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=s/yHaiIW3zZWGJ7IRLS4o0qlm7CjCLAYQPe2urNviwU=; b=m2pcdvClE33ozLIPbSCd7+x7Q5KpPi5D4AaEREh1vozlK8Hd+MYr/QoN1Xh66Y8bGi fkNBubXz0/9Cn8Q4R795drJ4rXwaLj/joqxqx/njXrlYcjFlKkvkQoK5yMdO4Za08xQR v2mZJxqNqfXG28y5nllnqPk3Mb//QsIkRXsri40zEnTOLaauXjmmmo5YCQk0FtoON74j WzKF2gOqdse0xY9KkoXTFUrnGAp+f0ByCjaFYHEJmz98IeghfPymtgTjyfOtpDikLQl+ sP5RN2cxVXPsCQEA7xXyuYfhEh4gzt0aSRm76gi5vM5znzdJj/zoJwGGYUCXmQgOvmgf U00w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=s/yHaiIW3zZWGJ7IRLS4o0qlm7CjCLAYQPe2urNviwU=; b=Zz8lrLYBE8riwpnmQnrM7CbSAjpW7be/4snkaUCHfSZHzToQThhhx83vIFFbQG6J2g AmrQe9AIMmP3XqLNKfWi7czeUTaPVprWcD0Uo9y/kO/LlFGRbvoNJpLZViFKSfkPqSU/ 1aQJYMUoK3A43qtAJGGKYSRgIbuQM2XynAHIVJdyRT3eXJDoesLc6p30BNRKbpxowSpY eXLW0ItkusZ4tVfeM35qPRz/M0f5ZpLDvfDhxOvqk96UVz6/8UM0Bm8c3NZsgI/HHcbS /gHF0xHZvxlLiA7UZW5bySYjujoglMuBLquYZUEVGorgrOeEWqIyaP3elgNfz9oXz8Tu xeXw== X-Gm-Message-State: AOAM531aRjUlAQ1mxVEQ4o8zme9OQD2nu1u9qegtCgk0M+NvKtK3YC3N XGwzLoJq8dsPVj+i9vOa5TgHQg== X-Google-Smtp-Source: ABdhPJw6V5oOhMmLLeGM1gmgu2LIqdAbHQZzvnxE9xL4JhW+pJnB4qvN1QvR6asUNlJLEJZOoSfilA== X-Received: by 2002:a1c:1cc:: with SMTP id 195mr2969782wmb.41.1616064048713; Thu, 18 Mar 2021 03:40:48 -0700 (PDT) Received: from dell.default ([91.110.221.194]) by smtp.gmail.com with ESMTPSA id z1sm2426033wru.95.2021.03.18.03.40.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Mar 2021 03:40:48 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Rob Herring , Frank Rowand , "David S. Miller" , devicetree@vger.kernel.org Subject: [PATCH 05/10] of: property: Provide missing member description and remove excess param Date: Thu, 18 Mar 2021 10:40:31 +0000 Message-Id: <20210318104036.3175910-6-lee.jones@linaro.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210318104036.3175910-1-lee.jones@linaro.org> References: <20210318104036.3175910-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/of/property.c:1239: warning: Function parameter or member 'optional' not described in 'supplier_bindings' drivers/of/property.c:1366: warning: Excess function parameter 'dev' description in 'of_link_property' Cc: Rob Herring Cc: Frank Rowand Cc: "David S. Miller" Cc: devicetree@vger.kernel.org Signed-off-by: Lee Jones --- drivers/of/property.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/of/property.c b/drivers/of/property.c index 23816959c6966..c000ed01db018 100644 --- a/drivers/of/property.c +++ b/drivers/of/property.c @@ -1225,6 +1225,7 @@ static struct device_node *parse_##fname(struct device_node *np, \ * @parse_prop.prop_name: Name of property holding a phandle value * @parse_prop.index: For properties holding a list of phandles, this is the * index into the list + * @optional: Describes whether a supplier is mandatory or not * * Returns: * parse_prop() return values are @@ -1344,7 +1345,6 @@ static const struct supplier_bindings of_supplier_bindings[] = { /** * of_link_property - Create device links to suppliers listed in a property - * @dev: Consumer device * @con_np: The consumer device tree node which contains the property * @prop_name: Name of property to be parsed * From patchwork Thu Mar 18 10:40:32 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1455226 Return-Path: X-Original-To: incoming-dt@patchwork.ozlabs.org Delivered-To: patchwork-incoming-dt@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=devicetree-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=LWbXmDN3; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4F1Nqk4LL3z9sWb for ; Thu, 18 Mar 2021 21:41:38 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230239AbhCRKlF (ORCPT ); Thu, 18 Mar 2021 06:41:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33342 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230241AbhCRKkv (ORCPT ); Thu, 18 Mar 2021 06:40:51 -0400 Received: from mail-wr1-x430.google.com (mail-wr1-x430.google.com [IPv6:2a00:1450:4864:20::430]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CFD21C06174A for ; Thu, 18 Mar 2021 03:40:50 -0700 (PDT) Received: by mail-wr1-x430.google.com with SMTP id k8so4947413wrc.3 for ; Thu, 18 Mar 2021 03:40:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=/yMyTx/PpExLvmIr8KOOoFx0Kjtq3v/0W3wLq2/Ei0c=; b=LWbXmDN3q+yD7+Q955ekFxtm0xCrculnsCqRaoaJ0kzLDZCRQjA0lTbP4IRdre01sE prSEqoK6g7fj92lXouxAtmctw+TmODnQapL+d+g8FTgAL/B89pWQ/7t6rhYgvxC2nj1T MmbrY+NiBnqDRqGOVxspdnfBSZa+yiSw++DSzOqUn+pcUTKRY5eMTfoR8TZcLI2MpgJp tDuwKqU3v2i5UPUjtu2YVEv2L8TQsbY9AJylLYhGYGILkLea5DsoS+rvrmN//tvX9eN/ PcYS8SL4BWXCUoo/Lg7r2zPIcSFbWXJ9nMZO/f5mXroke/BHjowSFyR0zrGWYrST1Jji P/Ug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=/yMyTx/PpExLvmIr8KOOoFx0Kjtq3v/0W3wLq2/Ei0c=; b=MgqfmqCxm4iKGEUGwx9kQhPVCf9RzHqIwNwPM4yAjRWGd/z4gaZF/nvo6SoU40A/9b qHrrUc/mPJjRnTWJoM8zYKy2c9NQv9idi0VZEGDBpO5ET1RxyAKQ1oM2gs8T5+4cS/uG xYO4pzhW82Q3geBjuk0QrRuUUSzTJwiQJ+d0B49BtpmQ3J2ao/YQ1fXLH8tc+Vv9whr/ /ocu0TTtDrFNsvDBgfkFrP56n94zvIIwOxObPPfgd8XAlJzKiTwaNNGawBNCN/1rgohu f98SoYgPl9OK5e5raBLDI39g4opNqCIWyjWOf0dvsfckme9t9man+qtCdRjTBqLkleUt EhGg== X-Gm-Message-State: AOAM530wa+sre7Oa5uvdiHnciS2yTRVb+DtfLv433mGg7QUMyD6jE2TV CnczeaDx3fyGuZtZ/okAaP9QItlwVAZdcQ== X-Google-Smtp-Source: ABdhPJwwDKrMDYyQi6OEXvXPYtdXQ7+sEYKtvGl0FhUt2Pow5rxP+eWZK74XejGe429hox7g47UkaQ== X-Received: by 2002:a5d:4e83:: with SMTP id e3mr9051990wru.82.1616064049654; Thu, 18 Mar 2021 03:40:49 -0700 (PDT) Received: from dell.default ([91.110.221.194]) by smtp.gmail.com with ESMTPSA id z1sm2426033wru.95.2021.03.18.03.40.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Mar 2021 03:40:49 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Rob Herring , Frank Rowand , devicetree@vger.kernel.org Subject: [PATCH 06/10] of: address: Provide descriptions for 'of_address_to_resource's params Date: Thu, 18 Mar 2021 10:40:32 +0000 Message-Id: <20210318104036.3175910-7-lee.jones@linaro.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210318104036.3175910-1-lee.jones@linaro.org> References: <20210318104036.3175910-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/of/address.c:868: warning: Function parameter or member 'dev' not described in 'of_address_to_resource' drivers/of/address.c:868: warning: Function parameter or member 'index' not described in 'of_address_to_resource' drivers/of/address.c:868: warning: Function parameter or member 'r' not described in 'of_address_to_resource' Cc: Rob Herring Cc: Frank Rowand Cc: devicetree@vger.kernel.org Signed-off-by: Lee Jones --- drivers/of/address.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/of/address.c b/drivers/of/address.c index 73ddf2540f3fe..7de41abe7153f 100644 --- a/drivers/of/address.c +++ b/drivers/of/address.c @@ -857,6 +857,9 @@ static int __of_address_to_resource(struct device_node *dev, /** * of_address_to_resource - Translate device tree address and return as resource + * @dev: Caller's Device Node + * @index: Index into the array + * @r: Pointer to resource array * * Note that if your address is a PIO address, the conversion will fail if * the physical address can't be internally converted to an IO token with From patchwork Thu Mar 18 10:40:33 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1455231 Return-Path: X-Original-To: incoming-dt@patchwork.ozlabs.org Delivered-To: patchwork-incoming-dt@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=devicetree-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=rO8Z4QIM; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4F1NrG4KVvz9sWF for ; Thu, 18 Mar 2021 21:42:06 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230352AbhCRKle (ORCPT ); Thu, 18 Mar 2021 06:41:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33342 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230260AbhCRKlB (ORCPT ); Thu, 18 Mar 2021 06:41:01 -0400 Received: from mail-wm1-x32a.google.com (mail-wm1-x32a.google.com [IPv6:2a00:1450:4864:20::32a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C30B0C06174A for ; Thu, 18 Mar 2021 03:40:51 -0700 (PDT) Received: by mail-wm1-x32a.google.com with SMTP id a132-20020a1c668a0000b029010f141fe7c2so2880772wmc.0 for ; Thu, 18 Mar 2021 03:40:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=p93RSQraOmdRnXpBn6AdELj34NhQouUv0hXIunYHDbU=; b=rO8Z4QIM1BizCvyGUPP8TY5VqNFZM8Vtqw56fkZnF7B95OJSVNgMK+BKygDffOJkpn YAjoTpAYUFF9DlpyryfL20qh+5X7p3YnkjPp8e+UU9kGv8TcG8bg/ABwhqiEJZHzkaxW qqTSmn+zBqQ8BOUSmmiGmrYP5gnHGTr+B1yJ3qBNS81fIPocdKG6j957kbdkZp3CkY+f JVtoQ3KkVkofgujrLhV/1pRxdowN9V6MQc5g3+0nrnw0yFiuBOSy9oUbCpJIveYLIxv0 5NUA7qq3IgPYSNaUgRVH6914CYTeGScMvvnRyhkkFal7QIh8LqVGvzac8th/NRdjet/V uuQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=p93RSQraOmdRnXpBn6AdELj34NhQouUv0hXIunYHDbU=; b=WnPY1B/B27iTcbksBNxBK+Rq8s0UQwtHL4kCG3NJE7piqbTHP0l56pfE+u1hFjsasJ /gXB9f7KUBBWeubGK/uaLHRX2Hl/A8VoNwmfOgPG3cxv4FcHFhs6m2C/pEhNxJTnG3t3 PPcSEq9JYY4ccDMgQuTJ+Vfr5GyNqazvrou3v1AyfNcZo57kj6pCG2QyItw7bpzBw+vC 0zVQTHdWsDwWHMyQCd8P5XmgI7wnfNSEZ45UZlD+adwD7OqVBAPFMMq/hzXcEG4HgaBV suuThw4Wd08fjYosa6wrIL/nOz79RF81OBQEZo6BvFCH5o5b2BV22BajlM+OcYNc2TkW yUsw== X-Gm-Message-State: AOAM531ygQ8iaUFQ92ynUFHa0bF6qH5QTM07EHbhJM5iXFnw+Y21yqt3 71994UqH8ugrplQ4iFQrWUIe7g== X-Google-Smtp-Source: ABdhPJygumVBjWwtTQSPa436+pkbEEukKwr3djzv0rDa0LOMEz/aF9CSC12YFnqy2NLbD5RK7tjI7w== X-Received: by 2002:a05:600c:608:: with SMTP id o8mr3096483wmm.42.1616064050494; Thu, 18 Mar 2021 03:40:50 -0700 (PDT) Received: from dell.default ([91.110.221.194]) by smtp.gmail.com with ESMTPSA id z1sm2426033wru.95.2021.03.18.03.40.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Mar 2021 03:40:50 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Rob Herring , Frank Rowand , benh@kernel.crashing.org, devicetree@vger.kernel.org Subject: [PATCH 07/10] of: fdt: Demote kernel-doc abuses and fix function naming Date: Thu, 18 Mar 2021 10:40:33 +0000 Message-Id: <20210318104036.3175910-8-lee.jones@linaro.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210318104036.3175910-1-lee.jones@linaro.org> References: <20210318104036.3175910-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/of/fdt.c:478: warning: Function parameter or member 'node' not described in '__reserved_mem_reserve_reg' drivers/of/fdt.c:478: warning: Function parameter or member 'uname' not described in '__reserved_mem_reserve_reg' drivers/of/fdt.c:525: warning: Function parameter or member 'node' not described in '__reserved_mem_check_root' drivers/of/fdt.c:547: warning: Function parameter or member 'node' not described in '__fdt_scan_reserved_mem' drivers/of/fdt.c:547: warning: Function parameter or member 'uname' not described in '__fdt_scan_reserved_mem' drivers/of/fdt.c:547: warning: Function parameter or member 'depth' not described in '__fdt_scan_reserved_mem' drivers/of/fdt.c:547: warning: Function parameter or member 'data' not described in '__fdt_scan_reserved_mem' drivers/of/fdt.c:547: warning: expecting prototype for fdt_scan_reserved_mem(). Prototype was for __fdt_scan_reserved_mem() instead drivers/of/fdt.c:663: warning: Function parameter or member 'parent' not described in 'of_scan_flat_dt_subnodes' drivers/of/fdt.c:708: warning: Function parameter or member 'node' not described in 'of_get_flat_dt_prop' drivers/of/fdt.c:708: warning: Function parameter or member 'name' not described in 'of_get_flat_dt_prop' drivers/of/fdt.c:708: warning: Function parameter or member 'size' not described in 'of_get_flat_dt_prop' drivers/of/fdt.c:758: warning: Function parameter or member 'node' not described in 'of_flat_dt_match' drivers/of/fdt.c:758: warning: Function parameter or member 'compat' not described in 'of_flat_dt_match' drivers/of/fdt.c:778: warning: Function parameter or member 'node' not described in 'of_get_flat_dt_phandle' drivers/of/fdt.c:778: warning: expecting prototype for of_get_flat_dt_prop(). Prototype was for of_get_flat_dt_phandle() instead drivers/of/fdt.c:955: warning: Function parameter or member 'node' not described in 'early_init_dt_scan_root' drivers/of/fdt.c:955: warning: Function parameter or member 'uname' not described in 'early_init_dt_scan_root' drivers/of/fdt.c:955: warning: Function parameter or member 'depth' not described in 'early_init_dt_scan_root' drivers/of/fdt.c:955: warning: Function parameter or member 'data' not described in 'early_init_dt_scan_root' drivers/of/fdt.c:991: warning: Function parameter or member 'node' not described in 'early_init_dt_scan_memory' drivers/of/fdt.c:991: warning: Function parameter or member 'uname' not described in 'early_init_dt_scan_memory' drivers/of/fdt.c:991: warning: Function parameter or member 'depth' not described in 'early_init_dt_scan_memory' drivers/of/fdt.c:991: warning: Function parameter or member 'data' not described in 'early_init_dt_scan_memory' Cc: Rob Herring Cc: Frank Rowand Cc: benh@kernel.crashing.org Cc: devicetree@vger.kernel.org Signed-off-by: Lee Jones --- drivers/of/fdt.c | 23 ++++++++++++----------- 1 file changed, 12 insertions(+), 11 deletions(-) diff --git a/drivers/of/fdt.c b/drivers/of/fdt.c index dcc1dd96911a9..4d6d195e089aa 100644 --- a/drivers/of/fdt.c +++ b/drivers/of/fdt.c @@ -470,7 +470,7 @@ void *initial_boot_params __ro_after_init; static u32 of_fdt_crc32; -/** +/* * __reserved_mem_reserve_reg() - reserve all memory described in 'reg' property */ static int __init __reserved_mem_reserve_reg(unsigned long node, @@ -516,7 +516,7 @@ static int __init __reserved_mem_reserve_reg(unsigned long node, return 0; } -/** +/* * __reserved_mem_check_root() - check if #size-cells, #address-cells provided * in /reserved-memory matches the values supported by the current implementation, * also check if ranges property has been provided @@ -539,8 +539,8 @@ static int __init __reserved_mem_check_root(unsigned long node) return 0; } -/** - * fdt_scan_reserved_mem() - scan a single FDT node for reserved memory +/* + * __fdt_scan_reserved_mem() - scan a single FDT node for reserved memory */ static int __init __fdt_scan_reserved_mem(unsigned long node, const char *uname, int depth, void *data) @@ -650,6 +650,7 @@ int __init of_scan_flat_dt(int (*it)(unsigned long node, /** * of_scan_flat_dt_subnodes - scan sub-nodes of a node call callback on each. + * @parent: parent node * @it: callback function * @data: context data pointer * @@ -689,7 +690,7 @@ int __init of_get_flat_dt_subnode_by_name(unsigned long node, const char *uname) return fdt_subnode_offset(initial_boot_params, node, uname); } -/** +/* * of_get_flat_dt_root - find the root node in the flat blob */ unsigned long __init of_get_flat_dt_root(void) @@ -697,7 +698,7 @@ unsigned long __init of_get_flat_dt_root(void) return 0; } -/** +/* * of_get_flat_dt_prop - Given a node in the flat blob, return the property ptr * * This function can be used within scan_flattened_dt callback to get @@ -751,7 +752,7 @@ int __init of_flat_dt_is_compatible(unsigned long node, const char *compat) return of_fdt_is_compatible(initial_boot_params, node, compat); } -/** +/* * of_flat_dt_match - Return true if node matches a list of compatible values */ static int __init of_flat_dt_match(unsigned long node, const char *const *compat) @@ -771,8 +772,8 @@ static int __init of_flat_dt_match(unsigned long node, const char *const *compat return score; } -/** - * of_get_flat_dt_prop - Given a node in the flat blob, return the phandle +/* + * of_get_flat_dt_phandle - Given a node in the flat blob, return the phandle */ uint32_t __init of_get_flat_dt_phandle(unsigned long node) { @@ -947,7 +948,7 @@ int __init early_init_dt_scan_chosen_stdout(void) } #endif -/** +/* * early_init_dt_scan_root - fetch the top level address and size cells */ int __init early_init_dt_scan_root(unsigned long node, const char *uname, @@ -983,7 +984,7 @@ u64 __init dt_mem_next_cell(int s, const __be32 **cellp) return of_read_number(p, s); } -/** +/* * early_init_dt_scan_memory - Look for and parse memory nodes */ int __init early_init_dt_scan_memory(unsigned long node, const char *uname, From patchwork Thu Mar 18 10:40:34 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1455229 Return-Path: X-Original-To: incoming-dt@patchwork.ozlabs.org Delivered-To: patchwork-incoming-dt@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=devicetree-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=MzKuC6Yn; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4F1Nqm00Lwz9sWb for ; Thu, 18 Mar 2021 21:41:39 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230255AbhCRKlG (ORCPT ); Thu, 18 Mar 2021 06:41:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33366 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230248AbhCRKkx (ORCPT ); Thu, 18 Mar 2021 06:40:53 -0400 Received: from mail-wm1-x334.google.com (mail-wm1-x334.google.com [IPv6:2a00:1450:4864:20::334]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AEAE3C061765 for ; Thu, 18 Mar 2021 03:40:52 -0700 (PDT) Received: by mail-wm1-x334.google.com with SMTP id k128so805146wmk.4 for ; Thu, 18 Mar 2021 03:40:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=YeqXEpROOp+iMp8r4X/XCNvaZ1Q9W0JDqwahteeA6AI=; b=MzKuC6YnZurZf0L4f2hzTY8fKELqD9l8PjwaxpCOd9JxaDHWDQE/qpt74TPeOPX2Zn Xk//2XeHA0jI2tcWPiftkGf/8iIiPCQCkcmy5JUEbThY6pFjrUkd0nLGTdeO0pH0aSNF znJ6A7t8Z84suozRc6yHxZDiDMqnQNTG4kFlsaustDOuSqoNQ26psemHCBK4oqY8lhEL D6eU6CwBtD8pLRPlV2P15XgfgM5qVNHyLs67wDnvRwkyEQSA8WgnFFmdtwwD1qYaSnUJ rKP5KPZVkjN/S415+Bp8p+KNQb/txxip2PgRXmjni5DCv8oGfqZFV95yuUAGCBPqbZPS /z7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=YeqXEpROOp+iMp8r4X/XCNvaZ1Q9W0JDqwahteeA6AI=; b=VwPBa1eSdsftvUabkuvrWZGClmyyamN7YBEqkk+W7qiixmjfA8P4kUI4wKrm+BJ+2O 9HStzXvuhFAHCrXvzYNodpf0+nIGsBxUmqgtmo7818G6sSnd9o4oWJuWxYVoJ5FnOIex 2oIQ+9Qj2VnfgRO0/o0u/IFgB5eswkGED4EN83KGrSghy9Y9yEmV9cBMHuHdVmwUj6r7 mLAnLtrxvs3nFXSnZBjsx4c0AAwsDN4c+gizHOCQSApqsTtEzEo43JMyfnnGFWE++54t elVahugfXzH3cvh52KZdOV+r7Aw7LumLsCp93JJGR7Mk+ydUlYR2h4m1jlxLcODkgZEP Holg== X-Gm-Message-State: AOAM531mxxVHLMWOuIEGFaKB5o7zyQ6XBmb8IWXpqf514H+unqQazlRY 9msblA3ju2qzVx+2RWYmsMo1tA== X-Google-Smtp-Source: ABdhPJzW1MNHQw5/b2G8K0upazSv+a5i+rQsabgUnXUoFC/kZAwv2SHREiGWb7z58KsAoeqZV2TygA== X-Received: by 2002:a1c:bac2:: with SMTP id k185mr3044552wmf.148.1616064051464; Thu, 18 Mar 2021 03:40:51 -0700 (PDT) Received: from dell.default ([91.110.221.194]) by smtp.gmail.com with ESMTPSA id z1sm2426033wru.95.2021.03.18.03.40.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Mar 2021 03:40:51 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Andrew Lunn , Heiner Kallweit , Russell King , Rob Herring , Frank Rowand , netdev@vger.kernel.org, devicetree@vger.kernel.org Subject: [PATCH 08/10] of: of_net: Provide function name and param description Date: Thu, 18 Mar 2021 10:40:34 +0000 Message-Id: <20210318104036.3175910-9-lee.jones@linaro.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210318104036.3175910-1-lee.jones@linaro.org> References: <20210318104036.3175910-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/of/of_net.c:104: warning: Function parameter or member 'np' not described in 'of_get_mac_address' drivers/of/of_net.c:104: warning: expecting prototype for mac(). Prototype was for of_get_mac_address() instead Cc: Andrew Lunn Cc: Heiner Kallweit Cc: Russell King Cc: Rob Herring Cc: Frank Rowand Cc: netdev@vger.kernel.org Cc: devicetree@vger.kernel.org Signed-off-by: Lee Jones Reviewed-by: Andrew Lunn --- drivers/of/of_net.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/of/of_net.c b/drivers/of/of_net.c index 6e411821583e4..bc0a27de69d4c 100644 --- a/drivers/of/of_net.c +++ b/drivers/of/of_net.c @@ -79,6 +79,9 @@ static const void *of_get_mac_addr_nvmem(struct device_node *np) } /** + * of_get_mac_address() + * @np: Caller's Device Node + * * Search the device tree for the best MAC address to use. 'mac-address' is * checked first, because that is supposed to contain to "most recent" MAC * address. If that isn't set, then 'local-mac-address' is checked next, From patchwork Thu Mar 18 10:40:35 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1455228 Return-Path: X-Original-To: incoming-dt@patchwork.ozlabs.org Delivered-To: patchwork-incoming-dt@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=devicetree-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=iyszRt+q; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4F1Nql3q75z9sWF for ; Thu, 18 Mar 2021 21:41:39 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230220AbhCRKlG (ORCPT ); Thu, 18 Mar 2021 06:41:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33366 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230250AbhCRKkx (ORCPT ); Thu, 18 Mar 2021 06:40:53 -0400 Received: from mail-wr1-x436.google.com (mail-wr1-x436.google.com [IPv6:2a00:1450:4864:20::436]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9C687C061764 for ; Thu, 18 Mar 2021 03:40:53 -0700 (PDT) Received: by mail-wr1-x436.google.com with SMTP id z2so4948991wrl.5 for ; Thu, 18 Mar 2021 03:40:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=0qmJtn2ROcq97cCAA/GgmHQVBHx/QLh0PdVV8I8LApw=; b=iyszRt+qnglpKenDT7tSKvwnF7XSjKMucfcncfvxvC0oJVpSZ38UxRbu4Oyh7jfuGo 2Ii2HBDIKTLsU8IU7MletnbtM+gSuYYwWmuG8t6qiCThOPDEvezjJ78Yvfdd76115zsq e8zLfOaOyAeSaggFcy/kh44hc3Pjij6gcaAYlz62Gv4xUuvo3OFZ7my+BsspnlRUBiB7 F4yrRl2Kwe5ir62MBY7TLaXaosGX6p6S/bzsfDzh0XQsZzEQrE7gHCKpdZ+rpS0luB+6 5yBFhglOCsQ2u8nrKVyUcfAOQf5ShDa5zrjeZPcOKb0ekFjJIYl+Lqcf1ebjhHEKaJmu PADg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=0qmJtn2ROcq97cCAA/GgmHQVBHx/QLh0PdVV8I8LApw=; b=Xd/kkympkmZ5+Oh2Ev82QglxrND4WsjCktOeYVf5b/rOWojddEN2zW+oOdmobVSFhx 1hA7GmqRoeOpWIe+xLJOeXyyQB7vlJBgYLV2NtjcWcO8b+U28YvrJLGnVAHnWYKQWdab PKdV/p7FotR1/36IODNbYs2U44y2k1RcI12KbDKx3lbUSeeXFl8yWtpJENsHeQxlBZBz hyoEtUgpiZUPj3S1yJvruYdsg8sxVkXG9ed3kTDg+6xuM/y0Mm7YlATsvN/5qWavvciO 8w8bSeFmQcJslCeDlJ7WetUxgdHzpd5NdqjkZ8z2Fvu3Kx8zyTMeItJc+tQ7CT4r6/Q2 y+vw== X-Gm-Message-State: AOAM533COqErBaPOOPWICIL8T9RJl3ac19KTysiXdQivul/AyUY/zICQ eR5iU91o1Th4Qy5PzwQl0oeCmw== X-Google-Smtp-Source: ABdhPJwMp9iRDNvao+XEbdBR8svEJrBe3NcG5BTs9NahQPQEQJ9wTZyLfbM2gl07kazSUr/wWXs6+Q== X-Received: by 2002:adf:fb0e:: with SMTP id c14mr4143667wrr.140.1616064052384; Thu, 18 Mar 2021 03:40:52 -0700 (PDT) Received: from dell.default ([91.110.221.194]) by smtp.gmail.com with ESMTPSA id z1sm2426033wru.95.2021.03.18.03.40.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Mar 2021 03:40:51 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Pantelis Antoniou , Frank Rowand , Rob Herring , devicetree@vger.kernel.org Subject: [PATCH 09/10] of: overlay: Fix function name disparity Date: Thu, 18 Mar 2021 10:40:35 +0000 Message-Id: <20210318104036.3175910-10-lee.jones@linaro.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210318104036.3175910-1-lee.jones@linaro.org> References: <20210318104036.3175910-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/of/overlay.c:147: warning: expecting prototype for of_overlay_notifier_register(). Prototype was for of_overlay_notifier_unregister() instead Cc: Pantelis Antoniou Cc: Frank Rowand Cc: Rob Herring Cc: devicetree@vger.kernel.org Signed-off-by: Lee Jones --- drivers/of/overlay.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/of/overlay.c b/drivers/of/overlay.c index 50bbe0edf5380..1c867a5e4c7c2 100644 --- a/drivers/of/overlay.c +++ b/drivers/of/overlay.c @@ -140,7 +140,7 @@ int of_overlay_notifier_register(struct notifier_block *nb) EXPORT_SYMBOL_GPL(of_overlay_notifier_register); /** - * of_overlay_notifier_register() - Unregister notifier for overlay operations + * of_overlay_notifier_unregister() - Unregister notifier for overlay operations * @nb: Notifier block to unregister */ int of_overlay_notifier_unregister(struct notifier_block *nb) From patchwork Thu Mar 18 10:40:36 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1455230 Return-Path: X-Original-To: incoming-dt@patchwork.ozlabs.org Delivered-To: patchwork-incoming-dt@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=devicetree-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=c4aKYDLx; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4F1Nqm3NW2z9sX2 for ; Thu, 18 Mar 2021 21:41:40 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230250AbhCRKlH (ORCPT ); Thu, 18 Mar 2021 06:41:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33370 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230253AbhCRKky (ORCPT ); Thu, 18 Mar 2021 06:40:54 -0400 Received: from mail-wr1-x429.google.com (mail-wr1-x429.google.com [IPv6:2a00:1450:4864:20::429]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 88171C061764 for ; Thu, 18 Mar 2021 03:40:54 -0700 (PDT) Received: by mail-wr1-x429.google.com with SMTP id t9so4940387wrn.11 for ; Thu, 18 Mar 2021 03:40:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=CqsJEFNZDm1zRQWkx9oBbTS7v3YGOj5LKMbHcTRx7PQ=; b=c4aKYDLxmr57pQXCsjKqPoy8XCYciLJ9N+tpcorGz9F1LHX8NQi74FoEND8uug/RN9 ez8yaDpAtg1IBvk6MF+7xPlErckecdqr+nzp5lbuxNtkNfT6LZoqPLuFqTx5AItUiLs4 cpR47f/qAHTx5O7CFGZYiaWFrRcnQrAy8cfiM4wd4m0I0MLFvXOVTfybuZi1YvkIX83V PWq1hO/o0XKYiVRZus1sUq7jtZ+9NLsPUAMM3Ii/seGT3LznUtLbPGUWtt6mz2+8iMmx rXzTbVfv37DGISLqNJT9UFXZNdoZBH+R5EUarBa1KulLq+8o1XilACquFpnkIho/LwvO HPVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=CqsJEFNZDm1zRQWkx9oBbTS7v3YGOj5LKMbHcTRx7PQ=; b=JnUoI5jT5plGtdpvgeujXzTUFAafX8l9t/8ZHnSgSjq/sHOBhNLBmV3E0wFqHXsxd3 2xP+PsEfypVCPn0zMWNgaGaLC4H/H4340bfnu3cphe8iZM+VSP4nK3rhFGXRrufm5eDK gQA70XOJQvqhc9GtYV4qlAJiUNOTOYgnUt0EP8V192HZwB+OZMJvSwpKpPJYgJyrjAGC 5L5egiNwmyQqTbAVQVNgCcAok/GGzVSO7A4KFwFmPXQmD/rfIZjBtATiUt4tK1AV2vQL dXfypgbYKa2m91CiKJVBaTGMGppY6PX2i3qw2NPvXSwrRyZIfi2519E5S4IiQLmVS0ZD n1qQ== X-Gm-Message-State: AOAM533jX5VMUyFUrFcdkGbVdhqy52p5c3lJLXRgQ95N2r8pc8PGRLy2 E7Fk8nTXPwHYWiynhS4kH8JPTA== X-Google-Smtp-Source: ABdhPJywv7telrZhgTo8CVB0g7RRIFhem/IKumPSW4fk8cikOR2kTnVdQri7On5rsLI1iJA9gcO6RQ== X-Received: by 2002:adf:f4ce:: with SMTP id h14mr8895057wrp.257.1616064053290; Thu, 18 Mar 2021 03:40:53 -0700 (PDT) Received: from dell.default ([91.110.221.194]) by smtp.gmail.com with ESMTPSA id z1sm2426033wru.95.2021.03.18.03.40.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Mar 2021 03:40:52 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Rob Herring , Frank Rowand , Marek Szyprowski , Josh Cartwright , devicetree@vger.kernel.org Subject: [PATCH 10/10] of: of_reserved_mem: Demote kernel-doc abuses Date: Thu, 18 Mar 2021 10:40:36 +0000 Message-Id: <20210318104036.3175910-11-lee.jones@linaro.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210318104036.3175910-1-lee.jones@linaro.org> References: <20210318104036.3175910-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/of/of_reserved_mem.c:53: warning: Function parameter or member 'node' not described in 'fdt_reserved_mem_save_node' drivers/of/of_reserved_mem.c:53: warning: Function parameter or member 'uname' not described in 'fdt_reserved_mem_save_node' drivers/of/of_reserved_mem.c:53: warning: Function parameter or member 'base' not described in 'fdt_reserved_mem_save_node' drivers/of/of_reserved_mem.c:53: warning: Function parameter or member 'size' not described in 'fdt_reserved_mem_save_node' drivers/of/of_reserved_mem.c:76: warning: Function parameter or member 'node' not described in '__reserved_mem_alloc_size' drivers/of/of_reserved_mem.c:76: warning: Function parameter or member 'uname' not described in '__reserved_mem_alloc_size' drivers/of/of_reserved_mem.c:76: warning: Function parameter or member 'res_base' not described in '__reserved_mem_alloc_size' drivers/of/of_reserved_mem.c:76: warning: Function parameter or member 'res_size' not described in '__reserved_mem_alloc_size' drivers/of/of_reserved_mem.c:171: warning: Function parameter or member 'rmem' not described in '__reserved_mem_init_node' Cc: Rob Herring Cc: Frank Rowand Cc: Marek Szyprowski Cc: Josh Cartwright Cc: devicetree@vger.kernel.org Signed-off-by: Lee Jones --- drivers/of/of_reserved_mem.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/of/of_reserved_mem.c b/drivers/of/of_reserved_mem.c index a7fbc5e37e19e..15e2417974d67 100644 --- a/drivers/of/of_reserved_mem.c +++ b/drivers/of/of_reserved_mem.c @@ -45,7 +45,7 @@ static int __init early_init_dt_alloc_reserved_memory_arch(phys_addr_t size, return memblock_reserve(base, size); } -/** +/* * fdt_reserved_mem_save_node() - save fdt node for second pass initialization */ void __init fdt_reserved_mem_save_node(unsigned long node, const char *uname, @@ -67,7 +67,7 @@ void __init fdt_reserved_mem_save_node(unsigned long node, const char *uname, return; } -/** +/* * __reserved_mem_alloc_size() - allocate reserved memory described by * 'size', 'alignment' and 'alloc-ranges' properties. */ @@ -164,7 +164,7 @@ static int __init __reserved_mem_alloc_size(unsigned long node, static const struct of_device_id __rmem_of_table_sentinel __used __section("__reservedmem_of_table_end"); -/** +/* * __reserved_mem_init_node() - call region specific reserved memory init code */ static int __init __reserved_mem_init_node(struct reserved_mem *rmem)