From patchwork Tue Mar 16 20:51:44 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dario Binacchi X-Patchwork-Id: 1454273 X-Patchwork-Delegate: trini@ti.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=libero.it header.i=@libero.it header.a=rsa-sha256 header.s=s2021 header.b=D2l1zpuB; dkim-atps=neutral Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4F0QT05SFVz9sVb for ; Wed, 17 Mar 2021 07:52:04 +1100 (AEDT) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 14B7C81FB4; Tue, 16 Mar 2021 21:51:59 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=libero.it Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=libero.it header.i=@libero.it header.b="D2l1zpuB"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 6FA4182047; Tue, 16 Mar 2021 21:51:56 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=0.5 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FORGED_SPF_HELO,FREEMAIL_FROM, RCVD_IN_SORBS_WEB,SPF_HELO_PASS autolearn=no autolearn_force=no version=3.4.2 Received: from libero.it (smtp-17.italiaonline.it [213.209.10.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 11C2181C7C for ; Tue, 16 Mar 2021 21:51:53 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=libero.it Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=dariobin@libero.it Received: from passgat-Modern-14-A10M.homenet.telecomitalia.it ([87.20.116.197]) by smtp-17.iol.local with ESMTPA id MGfKlZCFKtpGHMGfQlR2mj; Tue, 16 Mar 2021 21:51:52 +0100 x-libjamoibt: 1601 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=libero.it; s=s2021; t=1615927912; bh=kB1F6Fpd0DazRdS4VsnZWHUpKvofWWTjVWGDtNudzHw=; h=From; b=D2l1zpuBfK1uF9ap8w4RQbys1tt6lgeJGPtqJabnRS4iQIGASVnpFe67QfOrIR7EF HSoGd0NVHsf/f63HCcOLt5G/eGh08lNwnfwyQoxT6nOqe9SZEXOj/c0fdIfzff/Rae MXia2krbRN+kboISzquGP4Hsu8OmZj0+AJyg7jHqpvUlE0pdOUJSX7+zeoCYE89Iho 0z7UjJRZqsocuo3dij+Ing+4CsFUHE7Y6MNPylasPSOYdL2X99wXsd7YgpFC4uN9z/ 4USn3ZRY0xTmvVkvLtJr/ghvyGYNd1gFdqcmTq0by6oyWj93Ag9/jBqFMb+zF16nQh c8yxnRtZ7Zqlw== X-CNFS-Analysis: v=2.4 cv=Q7IXX66a c=1 sm=1 tr=0 ts=60511a68 cx=a_exe a=AVqmXbCQpuNSdJmApS5GbQ==:117 a=AVqmXbCQpuNSdJmApS5GbQ==:17 a=CiIi_yFUAF5k2rq7YHgA:9 From: Dario Binacchi To: u-boot@lists.denx.de Cc: Dario Binacchi , Simon Glass Subject: [PATCH v2] bus: ti-sysc: change in a normal driver Date: Tue, 16 Mar 2021 21:51:44 +0100 Message-Id: <20210316205145.4631-1-dariobin@libero.it> X-Mailer: git-send-email 2.17.1 X-CMAE-Envelope: MS4xfDiOqB7878jNhag1z29/t38uWux6yQp03QL2Ek6VYreZzZN5Lz7a1SkmFzAooL9isbdZO/eKLmDQm4Jg72cclAp5a9zqsTFieosVGwh+jAivzl1KZ3lE YFLtzqIGJsPaJIyjUhvHY6i1EEQOjen2MjwHoZ2tpxDq6soQd17G+ngg1Xo0gTlkkP5qhPix5ckvgTN5ZEQHl+h2OjQhFepBGFtNCd2LAUJPL86eLXEp52Zv FAS7lmALr5hGBlc3V6DlsXAmol4uIwLwrY4XnWeK/b7L4VHhRp3kCZbTjS7FefUM X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.102.4 at phobos.denx.de X-Virus-Status: Clean The module defines a duplicate uclass driver for UCLASS_SIMPLE_BUS, but it is not allowed. This breaks of-platdata and makes the result non-deterministic. The driver does not need to be an uclass driver, so lets remove it. I had turned it into an uclass driver because I thought wrongly it had to call the dm_scan_fdt_dev routine to work properly, but some tests on the board have shown otherwise. Signed-off-by: Dario Binacchi Reviewed-by: Simon Glass --- Changes in v2: - Remove UCLASS_SYSC id. - Change ti-sysc in a normal driver instead of an uclass driver. Previous tests, where I had removed the uclass driver, failed because I added the dm_scan_fdt_dev routine to the driver bind routine (I moved it from the uclass driver post_bind routine to the normal driver bind one). drivers/bus/ti-sysc.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/drivers/bus/ti-sysc.c b/drivers/bus/ti-sysc.c index 4e3d610300..778c0654f6 100644 --- a/drivers/bus/ti-sysc.c +++ b/drivers/bus/ti-sysc.c @@ -148,12 +148,6 @@ clocks_err: return err; } -UCLASS_DRIVER(ti_sysc) = { - .id = UCLASS_SIMPLE_BUS, - .name = "ti_sysc", - .post_bind = dm_scan_fdt_dev -}; - U_BOOT_DRIVER(ti_sysc) = { .name = "ti_sysc", .id = UCLASS_SIMPLE_BUS,