From patchwork Fri Mar 12 13:53:33 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michal Simek X-Patchwork-Id: 1452074 X-Patchwork-Delegate: trini@ti.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=monstr-eu.20150623.gappssmtp.com header.i=@monstr-eu.20150623.gappssmtp.com header.a=rsa-sha256 header.s=20150623 header.b=fQdpt/dK; dkim-atps=neutral Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4DxnNB1bNtz9sRR for ; Sat, 13 Mar 2021 00:53:46 +1100 (AEDT) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 2F0D482E23; Fri, 12 Mar 2021 14:53:43 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=xilinx.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=monstr-eu.20150623.gappssmtp.com header.i=@monstr-eu.20150623.gappssmtp.com header.b="fQdpt/dK"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 574CB82E24; Fri, 12 Mar 2021 14:53:41 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,SPF_HELO_NONE autolearn=ham autolearn_force=no version=3.4.2 Received: from mail-ej1-x631.google.com (mail-ej1-x631.google.com [IPv6:2a00:1450:4864:20::631]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 727A282E1C for ; Fri, 12 Mar 2021 14:53:38 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=xilinx.com Authentication-Results: phobos.denx.de; spf=none smtp.mailfrom=monstr@monstr.eu Received: by mail-ej1-x631.google.com with SMTP id bm21so53499457ejb.4 for ; Fri, 12 Mar 2021 05:53:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monstr-eu.20150623.gappssmtp.com; s=20150623; h=sender:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=GQS7ZbyXBx8R9Wa4mUkP1PXF0KGvBGe4JzrXzCzVuQg=; b=fQdpt/dK+jRFs8WCYeE/ht9y7wnO6iMuUQ9F2e9+hYbABn0u3+kbxFkaNwik3dE2kp M45z0YI63ZPLXx+GAtgoHmiiWdE+bQeWB40ea+Fyb7WnHNu+UK8KI7UVFXx1MmYhy2xW G3b3H57WPw8LJX3N3w4tLFxLmCDY73dqTShSrJoLWTur7pXK5YSQ+mYG+RaTHYyTjCDT zZM+tRPljuezA1jyHo/wsLZnpvGAQE4TeTWDML6oIio/6BrSrX43V8FN+Z/sQl5rwXM1 Bylp8vQibTDKWbENhEoC5RbajJjBOLgriKn5HcxwpSgg7N0QX2N3dm0oyNUCv+B+GSiP /9ug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :mime-version:content-transfer-encoding; bh=GQS7ZbyXBx8R9Wa4mUkP1PXF0KGvBGe4JzrXzCzVuQg=; b=k9emEpr+1GCZ6DLXFu29KWW4iKsU19o7VfdYkNa79HgN3YkEqcCfcCwwEMH2iBF6Ar CIX37eeTjRLL5ITRdVeE+pm5Tw0DVDazM7kMnXc9acmrOmWzpqzhwz8Bq0B4nwCS78oW uyAjcCZTV4rVia7002CdA/C37XA9abci4DR2nsBHDsnZODUXoowrLBb8NQYq5Iaoou0T LIof53mauXvL6jlVZRqXNdjDcYA8aWCeKmAuvMbafOhcdvV+atV9UVPk+1E5jatXpVc8 rzDIFRsCl7KHG1d/+Up19mKmSQ1FKWyExFV8kB8+1gX9eDe5hiqghZGcFXAwXMJvweZU u89A== X-Gm-Message-State: AOAM533wzMNfbrflRxn1s4C9PykF46xl4fqa13Q1DDBpbfiUxweANiX0 24lIYqJn7z1hc24rYCRqYcRDcQD5GW5nXkgj X-Google-Smtp-Source: ABdhPJzaoP39whoeP2ogg5TRxOMCPc8trJ8ca03bxz1RyV1pE0+kE/H9VorJmJl5rO0PzQX1fU2z1A== X-Received: by 2002:a17:906:a413:: with SMTP id l19mr8675754ejz.421.1615557217970; Fri, 12 Mar 2021 05:53:37 -0800 (PST) Received: from localhost ([2a02:768:2307:40d6::45a]) by smtp.gmail.com with ESMTPSA id r19sm2785810ejr.55.2021.03.12.05.53.37 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 12 Mar 2021 05:53:37 -0800 (PST) From: Michal Simek To: u-boot@lists.denx.de, git@xilinx.com Cc: Jagan Teki Subject: [PATCH] spi: zynqmp_gqspi: Simplify baud_rate_val calculation Date: Fri, 12 Mar 2021 14:53:33 +0100 Message-Id: <6d2c13d27ae54e0721bd6640ae6dc238aa8425e7.1615557211.git.michal.simek@xilinx.com> X-Mailer: git-send-email 2.30.1 MIME-Version: 1.0 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.102.4 at phobos.denx.de X-Virus-Status: Clean Condition to setup GQSPI_DFLT_BAUD_RATE_VAL(number 2) in case when baud_rate_val is more then 7 is wrong. There should be really the biggest possible value which is 7. This can be achieve in easier way by enabling calculation till GQSPI_MAX_BAUD_RATE_VAL. Signed-off-by: Michal Simek --- drivers/spi/zynqmp_gqspi.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/spi/zynqmp_gqspi.c b/drivers/spi/zynqmp_gqspi.c index f8d13d193e30..900cb2610c7f 100644 --- a/drivers/spi/zynqmp_gqspi.c +++ b/drivers/spi/zynqmp_gqspi.c @@ -324,14 +324,10 @@ static int zynqmp_qspi_set_speed(struct udevice *bus, uint speed) if (plat->speed_hz != speed) { /* Set the clock frequency */ /* If speed == 0, default to lowest speed */ - while ((baud_rate_val < 8) && - ((plat->frequency / - (2 << baud_rate_val)) > speed)) + while (baud_rate_val < GQSPI_MAX_BAUD_RATE_VAL && + (plat->frequency / (2 << baud_rate_val)) > speed) baud_rate_val++; - if (baud_rate_val > GQSPI_MAX_BAUD_RATE_VAL) - baud_rate_val = GQSPI_DFLT_BAUD_RATE_VAL; - plat->speed_hz = plat->frequency / (2 << baud_rate_val); confr = readl(®s->confr);