From patchwork Sat Feb 27 13:53:54 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fabio Estevam X-Patchwork-Id: 1445177 X-Patchwork-Delegate: sbabic@denx.de Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=WM+WGV+c; dkim-atps=neutral Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4Dnp0n3gTSz9sCD for ; Sun, 28 Feb 2021 00:54:17 +1100 (AEDT) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 416EB81FDD; Sat, 27 Feb 2021 14:54:11 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="WM+WGV+c"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 1325D82016; Sat, 27 Feb 2021 14:54:09 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,SPF_HELO_NONE autolearn=ham autolearn_force=no version=3.4.2 Received: from mail-qv1-xf2d.google.com (mail-qv1-xf2d.google.com [IPv6:2607:f8b0:4864:20::f2d]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id D8CD381FB4 for ; Sat, 27 Feb 2021 14:54:05 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=festevam@gmail.com Received: by mail-qv1-xf2d.google.com with SMTP id n4so3641954qvl.4 for ; Sat, 27 Feb 2021 05:54:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=dKuymcCcy1r+cNInuE02jd8U56iPPaFXUg4hQ0iV0mI=; b=WM+WGV+cSEaNdPkkrrOu7S3PY4EIhC+ES4kCmYeUvsfqQRDIAo0azB1gSp54Pe2VDu 1+IWvp3oU7gqLpmhI8cxUq2by3EAXoHQRieQQKHXqp7bYfiHWF1DP9inoLmHG3oG78Lh vqv53ue+dzVkVMmCutSoRU6fKBnPmpTEQ0uK+Kekt7NzmSg+xA+KsCtPh72BX5nGAneK hNIRZYH+tCiz702gAHNSHXnwH98Tuw+uupHDwqBwgg9Tmi0GkPL5BXSSj3RuG9zcUv6A H0bjJ2pfYPZDXAW6Ua0vxUSfVpFSJ9COZ6QFzWtjYQsh9MwkiETiIjAZpEL+LiHQ513w +UkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=dKuymcCcy1r+cNInuE02jd8U56iPPaFXUg4hQ0iV0mI=; b=ZSZ/GtQQCpF/HOWGBIYfsucKcWY+Ukb7b3r5qiHGmVMHUY5tinivznQc2lOjEZCkel EzaMvT8vDv8jIBrjPPHYGlllZs/31k5aLRRZkXO0KhMyYYH45MaTDDPFaWS0Rvwjvb9F gA2NZjpMzEb3BsfLIWOfIfds2VysNXXazqQqtS/Rkcdxvf6Bp3WUu+cnyReLe4YmIwz1 xttQWxHn3GsyzndroK6ui1Fp08zsTzLwDEXCRHXS+c6K674HkseumlWOOL8C5yfQAPlK i9XbH1HYVsnZgGS+PTJGcvEmPP+tQCuKEaN2CuE52WgWnp4WwhnwYchrtqmdVwB6BuzE bEZw== X-Gm-Message-State: AOAM531qNvfB5dK6shB8y5kzA4rJnDRG7U1qLXFdav1V7E96qtzkuh2M x0R4o5bKv7LxfEn6WZQ9w4k= X-Google-Smtp-Source: ABdhPJyvH7E+48vxBxlnmBnoyT735qG724lP/NOr4QhIuXgX3Vse27NgWSO36TnHlYdBcs7ayIVBsA== X-Received: by 2002:a0c:b2d3:: with SMTP id d19mr6938872qvf.21.1614434044660; Sat, 27 Feb 2021 05:54:04 -0800 (PST) Received: from localhost.localdomain ([2804:431:d77f:6978:6462:ee55:dda2:e9ce]) by smtp.gmail.com with ESMTPSA id x12sm8219100qkj.20.2021.02.27.05.54.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 27 Feb 2021 05:54:03 -0800 (PST) From: Fabio Estevam To: peng.fan@nxp.com Cc: u-boot@lists.denx.de, lorusak@gmail.com, andrey.zhizhikin@leica-geosystems.com, ye.li@nxp.com, haibo.chen@nxp.com, sbabic@denx.de, trini@konsulko.com, Fabio Estevam Subject: [PATCH] Revert "mmc: fsl_esdhc_imx: remove the 1ms delay before sending command" Date: Sat, 27 Feb 2021 10:53:54 -0300 Message-Id: <20210227135354.1696310-1-festevam@gmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.102.4 at phobos.denx.de X-Virus-Status: Clean Removing the 1ms delay before sending command causes a regression on imx8mq-evk where the SD card cannot be accessed. Since this 1ms delay has been present since the driver introduction in 2008, keep it to avoid regressions. This reverts commit 9098682200e6cca4b776638a51200dafa16f50fb. Reported-by: Ye Li Signed-off-by: Fabio Estevam --- drivers/mmc/fsl_esdhc_imx.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/mmc/fsl_esdhc_imx.c b/drivers/mmc/fsl_esdhc_imx.c index e0e132698e30..a0a5c8960563 100644 --- a/drivers/mmc/fsl_esdhc_imx.c +++ b/drivers/mmc/fsl_esdhc_imx.c @@ -463,6 +463,13 @@ static int esdhc_send_cmd_common(struct fsl_esdhc_priv *priv, struct mmc *mmc, while (esdhc_read32(®s->prsstat) & PRSSTAT_DLA) ; + /* Wait at least 8 SD clock cycles before the next command */ + /* + * Note: This is way more than 8 cycles, but 1ms seems to + * resolve timing issues with some cards + */ + udelay(1000); + /* Set up for a data transfer if we have one */ if (data) { err = esdhc_setup_data(priv, mmc, data);