From patchwork Fri Feb 26 15:11:31 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexandre Oliva X-Patchwork-Id: 1444958 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=8.43.85.97; helo=sourceware.org; envelope-from=gcc-patches-bounces@gcc.gnu.org; receiver=) Received: from sourceware.org (unknown [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4DnCmq2Fw7z9sBJ for ; Sat, 27 Feb 2021 02:11:54 +1100 (AEDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 9B467384B061; Fri, 26 Feb 2021 15:11:48 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from rock.gnat.com (rock.gnat.com [205.232.38.15]) by sourceware.org (Postfix) with ESMTP id F34E4385781D for ; Fri, 26 Feb 2021 15:11:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org F34E4385781D Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=oliva@adacore.com Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id B4C29117E5A; Fri, 26 Feb 2021 10:11:45 -0500 (EST) X-Virus-Scanned: Debian amavisd-new at gnat.com Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 2VAkfQGmSSqo; Fri, 26 Feb 2021 10:11:45 -0500 (EST) Received: from free.home (tron.gnat.com [IPv6:2620:20:4000:0:46a8:42ff:fe0e:e294]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by rock.gnat.com (Postfix) with ESMTPS id 55FE1117CA6; Fri, 26 Feb 2021 10:11:45 -0500 (EST) Received: from livre (livre.home [172.31.160.2]) by free.home (8.15.2/8.15.2) with ESMTPS id 11QFBWSR714602 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 26 Feb 2021 12:11:34 -0300 From: Alexandre Oliva To: gcc-patches@gcc.gnu.org Subject: [FYI] Add missing dg-require-effective-target fpic directives to powerpc tests Organization: Free thinker, does not speak for AdaCore Date: Fri, 26 Feb 2021 12:11:31 -0300 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 X-Spam-Status: No, score=-12.3 required=5.0 tests=BAYES_00, GIT_PATCH_0, KAM_DMARC_STATUS, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces@gcc.gnu.org Sender: "Gcc-patches" With the understanding that we have preapproval to install testsuite patches that add misisng fpic requires, I'm going ahead and installing this patch. I've tested it on x86_64-linux-gnu and on ppc64-vx7r2. for gcc/testsuite/ChangeLog * gcc.target/powerpc/compress-float-ppc-pic.c: Add dg-require-effective-target fpic. * gcc.target/powerpc/ppc-eabi.c: Likewise. * gcc.target/powerpc/pr26350.c: Likewise. * gcc.target/powerpc/pr67789.c: Likewise. * gcc.target/powerpc/pr79439-1.c: Likewise. * gcc.target/powerpc/pr79439-2.c: Likewise. * gcc.target/powerpc/pr79439-3.c: Likewise. * gcc.target/powerpc/pr83629.c: Likewise. * gcc.target/powerpc/pr84112.c: Likewise. --- .../gcc.target/powerpc/compress-float-ppc-pic.c | 1 + gcc/testsuite/gcc.target/powerpc/ppc-eabi.c | 2 ++ gcc/testsuite/gcc.target/powerpc/pr26350.c | 1 + gcc/testsuite/gcc.target/powerpc/pr67789.c | 1 + gcc/testsuite/gcc.target/powerpc/pr79439-1.c | 1 + gcc/testsuite/gcc.target/powerpc/pr79439-2.c | 1 + gcc/testsuite/gcc.target/powerpc/pr79439-3.c | 1 + gcc/testsuite/gcc.target/powerpc/pr83629.c | 1 + gcc/testsuite/gcc.target/powerpc/pr84112.c | 1 + 9 files changed, 10 insertions(+) diff --git a/gcc/testsuite/gcc.target/powerpc/compress-float-ppc-pic.c b/gcc/testsuite/gcc.target/powerpc/compress-float-ppc-pic.c index 6be1753ec710b..8961be51d2f2d 100644 --- a/gcc/testsuite/gcc.target/powerpc/compress-float-ppc-pic.c +++ b/gcc/testsuite/gcc.target/powerpc/compress-float-ppc-pic.c @@ -1,5 +1,6 @@ /* { dg-do compile { target powerpc_fprs } } */ /* { dg-options "-O2 -fpic -mdejagnu-cpu=power5" } */ +/* { dg-require-effective-target fpic } */ double foo (double x) { return x + 1.75; diff --git a/gcc/testsuite/gcc.target/powerpc/ppc-eabi.c b/gcc/testsuite/gcc.target/powerpc/ppc-eabi.c index cd15586c29e1a..8718430fafa8f 100644 --- a/gcc/testsuite/gcc.target/powerpc/ppc-eabi.c +++ b/gcc/testsuite/gcc.target/powerpc/ppc-eabi.c @@ -2,4 +2,6 @@ /* { dg-do compile } */ /* { dg-require-effective-target powerpc_eabi_ok } */ /* { dg-options "-meabi -mrelocatable" } */ +/* { dg-require-effective-target fpic } */ + char *s = "boo"; diff --git a/gcc/testsuite/gcc.target/powerpc/pr26350.c b/gcc/testsuite/gcc.target/powerpc/pr26350.c index ee081602e2f3b..76b0c0f664726 100644 --- a/gcc/testsuite/gcc.target/powerpc/pr26350.c +++ b/gcc/testsuite/gcc.target/powerpc/pr26350.c @@ -1,5 +1,6 @@ /* { dg-do compile { target { powerpc*-*-darwin* powerpc*-*-aix* rs6000-*-* powerpc*-*-linux* } } } */ /* { dg-options "-O2 -mlong-double-128 -fpic" } */ +/* { dg-require-effective-target fpic } */ typedef int int32_t __attribute__ ((__mode__ (__SI__))); typedef unsigned char uint8_t; diff --git a/gcc/testsuite/gcc.target/powerpc/pr67789.c b/gcc/testsuite/gcc.target/powerpc/pr67789.c index 05d01ef20d777..ea77ec979cd5a 100644 --- a/gcc/testsuite/gcc.target/powerpc/pr67789.c +++ b/gcc/testsuite/gcc.target/powerpc/pr67789.c @@ -1,6 +1,7 @@ /* { dg-do assemble } */ /* { dg-require-effective-target fpic } */ /* { dg-options "-O2 -msecure-plt -fPIC" } */ +/* { dg-require-effective-target fpic } */ /* { dg-skip-if "" { powerpc*-*-darwin* powerpc-ibm-aix* } } */ #define FE_TONEAREST 0 diff --git a/gcc/testsuite/gcc.target/powerpc/pr79439-1.c b/gcc/testsuite/gcc.target/powerpc/pr79439-1.c index 8eb08a4e76246..04f2f9645e7d3 100644 --- a/gcc/testsuite/gcc.target/powerpc/pr79439-1.c +++ b/gcc/testsuite/gcc.target/powerpc/pr79439-1.c @@ -1,5 +1,6 @@ /* { dg-do compile { target { powerpc*-*-linux* && lp64 } } } */ /* { dg-options "-O2 -fpic -fno-reorder-blocks -fno-inline-functions -mno-pcrel" } */ +/* { dg-require-effective-target fpic } */ /* On the Linux 64-bit ABIs, we eliminate NOP in the 'rec' call even if -fpic is used. The recursive call should call the local alias. The diff --git a/gcc/testsuite/gcc.target/powerpc/pr79439-2.c b/gcc/testsuite/gcc.target/powerpc/pr79439-2.c index 9ebcf2579abc0..ec142081ff309 100644 --- a/gcc/testsuite/gcc.target/powerpc/pr79439-2.c +++ b/gcc/testsuite/gcc.target/powerpc/pr79439-2.c @@ -1,5 +1,6 @@ /* { dg-do compile { target { powerpc*-*-linux* && lp64 } } } */ /* { dg-options "-O2 -fpic -fno-reorder-blocks -mno-pcrel" } */ +/* { dg-require-effective-target fpic } */ /* On the Linux 64-bit ABIs, we should not eliminate NOP in the 'rec' call if -fpic is used because rec can be interposed at link time (since it has an diff --git a/gcc/testsuite/gcc.target/powerpc/pr79439-3.c b/gcc/testsuite/gcc.target/powerpc/pr79439-3.c index 762ca44b17772..0cc80f4af4274 100644 --- a/gcc/testsuite/gcc.target/powerpc/pr79439-3.c +++ b/gcc/testsuite/gcc.target/powerpc/pr79439-3.c @@ -1,5 +1,6 @@ /* { dg-do compile { target { powerpc-*-linux* && ilp32 } } } */ /* { dg-options "-O2 -fpic -fno-reorder-blocks" } */ +/* { dg-require-effective-target fpic } */ /* Analog of pr79439-1.c for 32-bit Linux. */ diff --git a/gcc/testsuite/gcc.target/powerpc/pr83629.c b/gcc/testsuite/gcc.target/powerpc/pr83629.c index 976b564e927d7..8900010fb1d0a 100644 --- a/gcc/testsuite/gcc.target/powerpc/pr83629.c +++ b/gcc/testsuite/gcc.target/powerpc/pr83629.c @@ -1,6 +1,7 @@ /* { dg-require-effective-target ilp32 } */ /* { dg-require-effective-target fpic } */ /* { dg-options "-O2 -fPIC -frename-registers --param=sched-autopref-queue-depth=0 -mdejagnu-cpu=603" } */ +/* { dg-require-effective-target fpic } */ extern void bar (void *); diff --git a/gcc/testsuite/gcc.target/powerpc/pr84112.c b/gcc/testsuite/gcc.target/powerpc/pr84112.c index 8fbafa1b1ca59..82a7d2a60f055 100644 --- a/gcc/testsuite/gcc.target/powerpc/pr84112.c +++ b/gcc/testsuite/gcc.target/powerpc/pr84112.c @@ -1,6 +1,7 @@ /* { dg-do compile } */ /* { dg-require-effective-target fpic } */ /* { dg-options "-mdejagnu-cpu=power8 -O3 -fstack-protector-strong -fpic" } */ +/* { dg-require-effective-target fpic } */ char *b; int c, d, e, f;