From patchwork Sat Feb 20 16:03:53 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "H.J. Lu" X-Patchwork-Id: 1442640 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=sourceware.org (client-ip=8.43.85.97; helo=sourceware.org; envelope-from=libc-alpha-bounces@sourceware.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=dwDbeYm3; dkim-atps=neutral Received: from sourceware.org (unknown [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4DjYCs5RvZz9sVv for ; Sun, 21 Feb 2021 03:04:09 +1100 (AEDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id AC7343850420; Sat, 20 Feb 2021 16:04:04 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org AC7343850420 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1613837044; bh=oLdw4Ooyt1mAtLA6aeNrtEYQ7wSPkBD8ENItA1STJ2w=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=dwDbeYm386wiB6RI5+Cwfj4R55qHsueJvkasSv+PIfLXKSGepOPxvyJutXOPCxOuI kQ9vai+dRqR+hipNX6sU/vttEn/JK34UZkQ6ItP+0oFkWyVWzBTbesQtlyYGe9ZEYX CKAJGhoFmbrRQEpgkUXtJGvKrlFq8f8WPXb27OlU= X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from mail-pj1-x102e.google.com (mail-pj1-x102e.google.com [IPv6:2607:f8b0:4864:20::102e]) by sourceware.org (Postfix) with ESMTPS id DF6B83858038 for ; Sat, 20 Feb 2021 16:03:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org DF6B83858038 Received: by mail-pj1-x102e.google.com with SMTP id kr16so5520724pjb.2 for ; Sat, 20 Feb 2021 08:03:58 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=oLdw4Ooyt1mAtLA6aeNrtEYQ7wSPkBD8ENItA1STJ2w=; b=WSZ7RkTFlHaMtA72t2Za32FtwQ4Kp1l3l1fQDc5WqEmwb1AwbyT1Wtk2CpBT1NyHgv SiSQpiinpga6/bp6E6aS9cdBfwVJ39aOnlkdOfn3zn/g0R9GiU6yyamM/cYmrzbCVJBT CmnUCjs1nVdosh8jiWIFnidrVE5hRwKs5Im6rM7j0yuGQII6dOAgM0CYBTl+Eds/E8uu Bg/CWXLrauC46Gljy2Ayj1FVHzjQos+wFHIy5+BIRtQtY4tPBh+0nN6GUmUWtQyKAVi4 o7UzNtG0aIhjytMdAl5EAe9BUAQq9DJbQ4ZUuh+Any3VD2YtiEWuZu+7FgBHoDVIqyQ3 54gg== X-Gm-Message-State: AOAM533+v3qSs57puFSXYHOlaGJ9xVoyOn8fHilSdja+Rq+f6ab2pmNt jmXCAO/wBdn2Co7SkKOeLngBGGTIkgs= X-Google-Smtp-Source: ABdhPJy+vQ9lwNCLu49RD9JqJVa4eEifL7S2mOoF3HWY0Cf1UcepjuouNYG5LtvTiWAvS9YCvO713g== X-Received: by 2002:a17:90a:990f:: with SMTP id b15mr14801622pjp.56.1613837037603; Sat, 20 Feb 2021 08:03:57 -0800 (PST) Received: from gnu-cfl-2.localdomain (c-69-181-90-243.hsd1.ca.comcast.net. [69.181.90.243]) by smtp.gmail.com with ESMTPSA id o1sm12401792pgq.1.2021.02.20.08.03.56 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 20 Feb 2021 08:03:56 -0800 (PST) Received: from gnu-cfl-2.localdomain (localhost [IPv6:::1]) by gnu-cfl-2.localdomain (Postfix) with ESMTP id 0CB4D1A0156 for ; Sat, 20 Feb 2021 08:03:56 -0800 (PST) To: libc-alpha@sourceware.org Subject: [PATCH] i386/clone.S: Remove redundant EBX load Date: Sat, 20 Feb 2021 08:03:53 -0800 Message-Id: <20210220160353.318800-1-hjl.tools@gmail.com> X-Mailer: git-send-email 2.29.2 MIME-Version: 1.0 X-Spam-Status: No, score=-3038.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: "H.J. Lu via Libc-alpha" From: "H.J. Lu" Reply-To: "H.J. Lu" Errors-To: libc-alpha-bounces@sourceware.org Sender: "Libc-alpha" There is no neeed for call L(here) L(here): popl %ebx addl $_GLOBAL_OFFSET_TABLE_+[.-L(here)], %ebx before movl %eax, %ebx --- sysdeps/unix/sysv/linux/i386/clone.S | 6 ------ 1 file changed, 6 deletions(-) diff --git a/sysdeps/unix/sysv/linux/i386/clone.S b/sysdeps/unix/sysv/linux/i386/clone.S index 91c4b65fea..8ec84491bb 100644 --- a/sysdeps/unix/sysv/linux/i386/clone.S +++ b/sysdeps/unix/sysv/linux/i386/clone.S @@ -106,12 +106,6 @@ L(thread_start): /* Note: %esi is zero. */ movl %esi,%ebp /* terminate the stack frame */ call *%ebx -#ifdef PIC - call L(here) -L(here): - popl %ebx - addl $_GLOBAL_OFFSET_TABLE_+[.-L(here)], %ebx -#endif movl %eax, %ebx movl $SYS_ify(exit), %eax ENTER_KERNEL