From patchwork Fri Feb 5 18:20:41 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marcelo Ricardo Leitner X-Patchwork-Id: 1436815 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org (client-ip=140.211.166.137; helo=fraxinus.osuosl.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=HUQ64RhF; dkim-atps=neutral Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4DXNyX28qtz9sWR for ; Sat, 6 Feb 2021 05:20:52 +1100 (AEDT) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id D91DA86BE1; Fri, 5 Feb 2021 18:20:50 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id cPPeBU-926w2; Fri, 5 Feb 2021 18:20:50 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by fraxinus.osuosl.org (Postfix) with ESMTP id 5A89B86BA6; Fri, 5 Feb 2021 18:20:50 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 495FAC0174; Fri, 5 Feb 2021 18:20:50 +0000 (UTC) X-Original-To: dev@openvswitch.org Delivered-To: ovs-dev@lists.linuxfoundation.org Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by lists.linuxfoundation.org (Postfix) with ESMTP id 8014BC013A for ; Fri, 5 Feb 2021 18:20:49 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id 7408186BB3 for ; Fri, 5 Feb 2021 18:20:49 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Nr3qY6hOe5KK for ; Fri, 5 Feb 2021 18:20:48 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-qt1-f175.google.com (mail-qt1-f175.google.com [209.85.160.175]) by fraxinus.osuosl.org (Postfix) with ESMTPS id 2EC9086BA6 for ; Fri, 5 Feb 2021 18:20:48 +0000 (UTC) Received: by mail-qt1-f175.google.com with SMTP id l23so5622141qtq.13 for ; Fri, 05 Feb 2021 10:20:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=SG5vrhpP7gAyI7EWTuuQf6+qGzaliclbRbs93tHnphw=; b=HUQ64RhFcfzprSUaLVBATKRTQVNDbPZGUSJxr3XPwFE5g2YLyfWHDQi1hXbB8gj3LZ vot7otfcbs2YUlmBX6eAMKkZEnHKilEvhxCYDaK5bhwifsBuDT5KC+SArT5wKtdyF0Nr gtDGRVLl+6EFOyHw0ruUHrFWlH+jMgv5yAsOPYqqDT+4dwHITRCHF0fIGqY68TXPVVDE /+H/oZ6zuW3WKktC9hTubcq/7blLp3VH+GO5YT2JyXndmVaBbNUs6ccTkXaLGboYPsZn 34OjbkwLoT07q8SDJ+W6dzRBTtph8S0kpORmSc2u0EacpfGwQ3Rkekjqos6T2bjndwGf 4C2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=SG5vrhpP7gAyI7EWTuuQf6+qGzaliclbRbs93tHnphw=; b=c7zGe0qEIsCD0hGCSgqFo0HnEWNHGxSD3laXjNfjTVGdN6yUzLh5ApDcPm4V/WPiDr 5Z3bywQgtU9P7K7sq4YFUv7+cf598JOKwJb0ew7hLtDBevZCERABEtNdfYBIw8bqejTh ruQjxvpnuPs3Y4F8DqnSBPhlzglOvXuVtqus+xW1U7R8dnlJAwX/dlhwy209AbIDec73 6ESc7u+0Ncvz5Zo2QCC3eFDgYAPAWQVbuQfTfJLDHnScMbjaYLfY5TZo6TEo6ZEODBOb W/rY/lL4qhYi0X2IlHbTnFo1GeBEr5ceOnDPcCQthmIbyRtGH+/0W4nU7itVU8+HjZsr JtQQ== X-Gm-Message-State: AOAM530jBLF8Mb99XgkZEkxNQy3TfWsjmvaYC2Kez4yVA6v5SpZ29Ra/ /0cwPcgN5tDD/jQfFbTiGfg= X-Google-Smtp-Source: ABdhPJyKevRAw9SSZW4PfVF/6uWVp6NToxT9Ai8hix2y6Wn1OeVzQNLdBPRIU4iHA6TZEIwmPw3Jvg== X-Received: by 2002:ac8:72c2:: with SMTP id o2mr5273229qtp.273.1612549247054; Fri, 05 Feb 2021 10:20:47 -0800 (PST) Received: from horizon.localdomain ([2001:1284:f013:33b1:1bdf:3c19:7173:82ba]) by smtp.gmail.com with ESMTPSA id o3sm9455667qkg.15.2021.02.05.10.20.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Feb 2021 10:20:46 -0800 (PST) Received: by horizon.localdomain (Postfix, from userid 1000) id AD560C13A6; Fri, 5 Feb 2021 15:20:43 -0300 (-03) From: Marcelo Ricardo Leitner To: dev@openvswitch.org Date: Fri, 5 Feb 2021 15:20:41 -0300 Message-Id: X-Mailer: git-send-email 2.29.2 In-Reply-To: <5e267fbc-a3ce-73a2-91d9-9d3c51545d11@ovn.org> References: <5e267fbc-a3ce-73a2-91d9-9d3c51545d11@ovn.org> MIME-Version: 1.0 Cc: Paul Blakey , Ilya Maximets Subject: [ovs-dev] [PATCH v4] vswitchd: update tc hwol docs regarding vswitchd restarts X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: ovs-dev-bounces@openvswitch.org Sender: "dev" hw-offload is can actually be enabled without a restart. Then, once enabled, a restart is needed in order to make the new value effective. tc-policy, just like hw-offload, is protected by ovsthread_once_start() in netdev_set_flow_api_enabled() and is only parsed when hw-offload is enabled. So lets document that if hw-offload was already enabled changing it requires a restart in order for it to have effect. Signed-off-by: Marcelo Ricardo Leitner --- Notes: v2: include changes regarding the new understanding on hw-offload v3: fixed warnings v4: fix wording vswitchd/vswitch.xml | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/vswitchd/vswitch.xml b/vswitchd/vswitch.xml index 5b2a174ab813139d3f3253be47758d4bfb1beac3..cde791d4e19f69f49ab7f77ec3abfc6b8f4f30f9 100644 --- a/vswitchd/vswitch.xml +++ b/vswitchd/vswitch.xml @@ -228,8 +228,9 @@ Set this value to true to enable netdev flow offload.

- The default value is false. Changing this value requires - restarting the daemon + The default value is false. Changing this value from + true to false requires restarting the + daemon.

Currently Open vSwitch supports hardware offloading on @@ -267,7 +268,9 @@ is enabled.

- The default value is none. + The default value is none. Changing this value requires + restarting the daemon if + was already enabled.