From patchwork Wed Feb 3 13:22:40 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bin Meng X-Patchwork-Id: 1435367 X-Patchwork-Delegate: sjg@chromium.org Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=85.214.62.61; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=vOIJTtUn; dkim-atps=neutral Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4DW2Rk09NGz9tlV for ; Thu, 4 Feb 2021 00:22:57 +1100 (AEDT) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 1A9CA8273C; Wed, 3 Feb 2021 14:22:52 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="vOIJTtUn"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 976BF8294C; Wed, 3 Feb 2021 14:22:50 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE autolearn=ham autolearn_force=no version=3.4.2 Received: from mail-ej1-x62c.google.com (mail-ej1-x62c.google.com [IPv6:2a00:1450:4864:20::62c]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 12F7A82709 for ; Wed, 3 Feb 2021 14:22:47 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=bmeng.cn@gmail.com Received: by mail-ej1-x62c.google.com with SMTP id i8so19256021ejc.7 for ; Wed, 03 Feb 2021 05:22:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id; bh=EmfHIPU/f3H1/q37wE5nHQx3+E3kOWx16lDHbLEtQ34=; b=vOIJTtUnvMgbzX9IT0wYy0AoDnM2FA+dGrqkbP7ZlTpjwBIbOLHyu9X2nR3UCvCOW2 v4JxMVx/v02fZFl9EJgfSzzWK+stGG/5N7IAK1c4lKY5gnu9HI/+OaMsx6aglHAkN5JR Zs+hPAV2s3iayMfqm5Mq/g8AkW8fiE+AUkcyoUUm+ArI1NTrPDFynBuQ0XPjAg1oZX4K In0eZzljccHEXDuK6gctgEntHiu7nMFyKZA9Z0XdO/gUA+qhDsUm9ajEH0XPIf6E7qBv z1IlrN06dRiQRWI/78x0Im0I01yr9XNfjWbczER4ZcnvIBdKee/vh9wFNjiXUg2udeZe L7uA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id; bh=EmfHIPU/f3H1/q37wE5nHQx3+E3kOWx16lDHbLEtQ34=; b=XmaXO1QcoFsJ61FMIHt/qqtx0wZKV537NNCFW0U1u7HWqdvUK7qkqC9GuA90gIHwzP tWAxpAKNgoCmCH3qS8M91v40o3J3KnnneG+OWVk08HgwP4Hls28A1A722hT5/vbBxw1o eZ4/r/a60uveuvwrQRNKZnDkyii2BqgGURAjVd69gUOqETj6ElmVDl3QrXsyWGl4+FvR y75CcCY7xuETJJv3I39lhxAoHA+Qatt+xuYL/gDHVolak4mjRYMgOsHv7JrMLS3+DpyR qSKpilEHIgcPojGIm7GEzbt+dPMCa2+px4f458IJc9QU+YWLJrtl5lmWyuy3kV9tjfyl nMAg== X-Gm-Message-State: AOAM533ovfsmcCdF6r/wX+zHKeyvOh649etXpp7GnaLXYOrDuwQHjucu GwNgJiWsUAnpXTgMFyuwy1M= X-Google-Smtp-Source: ABdhPJwveyj/+oMpwZFIYCVZxjrAu7KtUMpub8b4rIIaenCMsIw46n+COkVpQZl3wry4mZelXKmjFA== X-Received: by 2002:a17:907:da9:: with SMTP id go41mr3194525ejc.326.1612358566796; Wed, 03 Feb 2021 05:22:46 -0800 (PST) Received: from pek-vx-bsp2.wrs.com (ec2-44-242-66-180.us-west-2.compute.amazonaws.com. [44.242.66.180]) by smtp.gmail.com with ESMTPSA id p10sm879912edj.2.2021.02.03.05.22.44 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 03 Feb 2021 05:22:46 -0800 (PST) From: Bin Meng To: Simon Glass , u-boot@lists.denx.de Subject: [PATCH] serial: ns16550: Correct the base address type Date: Wed, 3 Feb 2021 21:22:40 +0800 Message-Id: <1612358560-89527-1-git-send-email-bmeng.cn@gmail.com> X-Mailer: git-send-email 2.7.4 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.102.3 at phobos.denx.de X-Virus-Status: Clean Currently ns16550_serial_assign_base() treats the argument 'base' with type `ulong`. This is incorrect because the base address was obtained from device tree with type `fdt_addr_t` that can represent a physical address larger than 32-bit in a 32-bit system. Fixes: 9e6ce62190b7 ("serial: ns16550: Fix ordering of getting base address") Signed-off-by: Bin Meng Reviewed-by: Simon Glass Reviewed-by: Simon Glass --- drivers/serial/ns16550.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/serial/ns16550.c b/drivers/serial/ns16550.c index 65c6db0..da903c1 100644 --- a/drivers/serial/ns16550.c +++ b/drivers/serial/ns16550.c @@ -482,7 +482,7 @@ static int ns16550_serial_getinfo(struct udevice *dev, return 0; } -static int ns16550_serial_assign_base(struct ns16550_plat *plat, ulong base) +static int ns16550_serial_assign_base(struct ns16550_plat *plat, fdt_addr_t base) { if (base == FDT_ADDR_T_NONE) return -EINVAL;