From patchwork Mon Feb 1 14:39:21 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1434162 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=linux-ide-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=v7jsGj3c; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4DTrGd39DJz9tkx for ; Tue, 2 Feb 2021 01:40:57 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229513AbhBAOk3 (ORCPT ); Mon, 1 Feb 2021 09:40:29 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59230 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229981AbhBAOk0 (ORCPT ); Mon, 1 Feb 2021 09:40:26 -0500 Received: from mail-wr1-x42b.google.com (mail-wr1-x42b.google.com [IPv6:2a00:1450:4864:20::42b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 50316C061756 for ; Mon, 1 Feb 2021 06:39:46 -0800 (PST) Received: by mail-wr1-x42b.google.com with SMTP id s7so13842195wru.5 for ; Mon, 01 Feb 2021 06:39:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=cK/LGNOy9DsyBBjFZYPOvNZ8xWqyFdDwYmos4fe8lCA=; b=v7jsGj3c2vJL0l7/Fu2OSvsuxoyQFhNE4460l4Oc/ZpdEjZIPWubnmtOTaHB+ZH1nd JlKrNKlAnJe9xP4T+XhobMsQgAZ8+72DYoqRddOxCwUxVg6zn7ccvOaQE8+/QMeEf0e5 dr10Uqyy5cYD60fNSDrzIPMSDQHw61wO40qV2bGU3EqEFm0o35VsWU1AwXK99FVUgAvL QFvdcFRggJKIyjxkECKikuYzJz2Tace8M66CJIhJNuMhet5GJicaNUklymubJuZ+rqA5 XQY9eeTQecQ5Z7R3ThUe+OR7Tl5Zk7pEJ5rNm2SnE9AYxNXvAZiOLLFmIvlYxngGs3Wk jRlw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=cK/LGNOy9DsyBBjFZYPOvNZ8xWqyFdDwYmos4fe8lCA=; b=PywS74hB+x2aJUGPwHHS9HBwgbjGgVldeGzH4qnJaF8PwfuW4VGGn7asN1f0yKXXKY YQmAJpnDFwC3ewC2/Wr5r0fZFcFh+Es+CXgMDpHoXvul+e12E6MyjWnhMcdIKqmvBWU5 NMH/RCFg5/AmPpkFmBPwdXHDRUxTIpaQU37aorD7paLiMf3YUfhzMENhRcAOgJFu7pJQ BY68wfvl/FbN3JV5OG4mwkdgxtkfZtuNtIIayhtrRSCycKsR0ObZIJi6JCdR8N1aRYGG BtGeNsXVUQ29LDQgYm5sEHnJ/poXjic4YSNTqXPwP6pC5tmZD5L+izJ+uTRKJOJma4DR cbzw== X-Gm-Message-State: AOAM532zDeF7ZXaOS/FnCAw3Y258rIn9I0HDPI6RvaitlCv/g1uJsTFN xegaIgngUdy+HGpBr57OctmVWDM7aFiTTdkJ X-Google-Smtp-Source: ABdhPJwuQyoZQsAT9aMUOrjHlteD3alQz281cVZJn0OBUEwFjaOkfuf4odwSaW6VYXE3F1Uii2uHRg== X-Received: by 2002:adf:dd10:: with SMTP id a16mr18521703wrm.207.1612190384969; Mon, 01 Feb 2021 06:39:44 -0800 (PST) Received: from dell.default ([91.110.221.188]) by smtp.gmail.com with ESMTPSA id h15sm27301359wrt.10.2021.02.01.06.39.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Feb 2021 06:39:44 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Jens Axboe , linux-ide@vger.kernel.org Subject: [PATCH 01/20] ata: libata-transport: Fix some potential doc-rot issues Date: Mon, 1 Feb 2021 14:39:21 +0000 Message-Id: <20210201143940.2070919-2-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210201143940.2070919-1-lee.jones@linaro.org> References: <20210201143940.2070919-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/ata/libata-transport.c:258: warning: Function parameter or member 'ap' not described in 'ata_tport_delete' drivers/ata/libata-transport.c:258: warning: Excess function parameter 'port' description in 'ata_tport_delete' drivers/ata/libata-transport.c:384: warning: Function parameter or member 'link' not described in 'ata_tlink_delete' drivers/ata/libata-transport.c:384: warning: Excess function parameter 'port' description in 'ata_tlink_delete' drivers/ata/libata-transport.c:640: warning: Function parameter or member 'ata_dev' not described in 'ata_tdev_delete' drivers/ata/libata-transport.c:640: warning: Excess function parameter 'port' description in 'ata_tdev_delete' Cc: Jens Axboe Cc: linux-ide@vger.kernel.org Signed-off-by: Lee Jones --- drivers/ata/libata-transport.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/ata/libata-transport.c b/drivers/ata/libata-transport.c index 6a40e3c6cf492..34bb4608bdc67 100644 --- a/drivers/ata/libata-transport.c +++ b/drivers/ata/libata-transport.c @@ -250,7 +250,7 @@ static int ata_tport_match(struct attribute_container *cont, /** * ata_tport_delete -- remove ATA PORT - * @port: ATA PORT to remove + * @ap: ATA PORT to remove * * Removes the specified ATA PORT. Remove the associated link as well. */ @@ -376,7 +376,7 @@ static int ata_tlink_match(struct attribute_container *cont, /** * ata_tlink_delete -- remove ATA LINK - * @port: ATA LINK to remove + * @link: ATA LINK to remove * * Removes the specified ATA LINK. remove associated ATA device(s) as well. */ @@ -632,7 +632,7 @@ static void ata_tdev_free(struct ata_device *dev) /** * ata_tdev_delete -- remove ATA device - * @port: ATA PORT to remove + * @ata_dev: ATA device to remove * * Removes the specified ATA device. */ From patchwork Mon Feb 1 14:39:22 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1434164 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=linux-ide-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=fH2blJ/9; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4DTrHP4KyWz9tkx for ; Tue, 2 Feb 2021 01:41:37 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229669AbhBAOlR (ORCPT ); Mon, 1 Feb 2021 09:41:17 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59376 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230192AbhBAOlH (ORCPT ); Mon, 1 Feb 2021 09:41:07 -0500 Received: from mail-wr1-x436.google.com (mail-wr1-x436.google.com [IPv6:2a00:1450:4864:20::436]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 75E0BC061786 for ; Mon, 1 Feb 2021 06:39:47 -0800 (PST) Received: by mail-wr1-x436.google.com with SMTP id c12so16832236wrc.7 for ; Mon, 01 Feb 2021 06:39:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=gat9ASy8Tcpn7xEHDYjYiqg8W2NDPEgsm5bh/q38djM=; b=fH2blJ/9WloA7c89067CkGeyLeJbGeZw97hzfm2jXLSDKqrGNCmhB0L6CaC6Zc6ufn kT9E8zZ2amBOvGyKjiU7u6EtNTshpZDBlKJZ9uiaqv561tbIbxQ+VLATlcCWlbW2IVfY JMm5X0w4Rs2ddWn+z17hxVYRLfJWpafg08jgGQwrPATJw1kl0hky35KbS9ZPBdg5EhyF Ye7J7RO7U8gfgqG7JFMjLgSvurKEtqr45gZcCreyIlJnnPL9N7FpwjO2jrhgL4YvQW2M Czqy/DUiI9GXpNu5zHk/OImSrwrqCGCU6e9gksGS/GERyHaCx8MUFfEvjyz4wCSv9h4e nTzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=gat9ASy8Tcpn7xEHDYjYiqg8W2NDPEgsm5bh/q38djM=; b=Nwq1GflFBQsHFZqtTgQT/1n5Ee5ZcRoFnClMl8aWjKW6J3eIQBsRxufCwOKg5PDgkF dM1O6LAYOAdFUXT+QRfdyyWzpixNV1Z1GMcOC9gLbXb/+XP+5yk+tPynj8Gywfqnv+by v+l1wiwwLcK4VrcNazCQM4vbH46GhSX3NbAXwa3Zwb7Lp+QQBCT7OrthzKKkOQZ0B5ts YK7a6CjLt1Ck2kYksyMBjR8FsU+/tyJPtLcEvXOBLeVHFATZQe+k1MLA0bbWkgBVgqr8 ZFvLa/UfgkAoJtWe1pXtvB+cT2mY3BymfeG/5SAxlDeMgrI9xXypMuMCalwRfiZYZl6V ePkQ== X-Gm-Message-State: AOAM5329GTUDexco2lieSbQfsPYplfHvvPwBResgnzQa6PDquBR8j6Ax 91xClTWOUZCsDFgzE7Qsi0PaL77zEHItURfT X-Google-Smtp-Source: ABdhPJw+uU75gzUzR2FPFtHoivrzYTgwqNZQDYPKKKrkJsc+UJDKK4YBDEFjSE8aXRzHRkuVgLBA7A== X-Received: by 2002:a5d:4806:: with SMTP id l6mr18974135wrq.389.1612190386171; Mon, 01 Feb 2021 06:39:46 -0800 (PST) Received: from dell.default ([91.110.221.188]) by smtp.gmail.com with ESMTPSA id h15sm27301359wrt.10.2021.02.01.06.39.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Feb 2021 06:39:45 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Jens Axboe , Tejun Heo , linux-ide@vger.kernel.org Subject: [PATCH 02/20] ata: libata-sata: Fix function names in header comments Date: Mon, 1 Feb 2021 14:39:22 +0000 Message-Id: <20210201143940.2070919-3-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210201143940.2070919-1-lee.jones@linaro.org> References: <20210201143940.2070919-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/ata/libata-sata.c:1085: warning: expecting prototype for port_alloc(). Prototype was for ata_sas_port_alloc() instead drivers/ata/libata-sata.c:1140: warning: expecting prototype for ata_port_stop(). Prototype was for ata_sas_port_stop() instead Cc: Jens Axboe Cc: Tejun Heo Cc: linux-ide@vger.kernel.org Signed-off-by: Lee Jones --- drivers/ata/libata-sata.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/ata/libata-sata.c b/drivers/ata/libata-sata.c index c16423e445255..8adeab76dd382 100644 --- a/drivers/ata/libata-sata.c +++ b/drivers/ata/libata-sata.c @@ -1067,7 +1067,7 @@ int ata_scsi_change_queue_depth(struct scsi_device *sdev, int queue_depth) EXPORT_SYMBOL_GPL(ata_scsi_change_queue_depth); /** - * port_alloc - Allocate port for a SAS attached SATA device + * ata_sas_port_alloc - Allocate port for a SAS attached SATA device * @host: ATA host container for all SAS ports * @port_info: Information from low-level host driver * @shost: SCSI host that the scsi device is attached to @@ -1127,7 +1127,7 @@ int ata_sas_port_start(struct ata_port *ap) EXPORT_SYMBOL_GPL(ata_sas_port_start); /** - * ata_port_stop - Undo ata_sas_port_start() + * ata_sas_port_stop - Undo ata_sas_port_start() * @ap: Port to shut down * * May be used as the port_stop() entry in ata_port_operations. From patchwork Mon Feb 1 14:39:23 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1434166 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=linux-ide-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=mapxxoiz; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4DTrHQ2mfjz9tlC for ; Tue, 2 Feb 2021 01:41:38 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229974AbhBAOlS (ORCPT ); Mon, 1 Feb 2021 09:41:18 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59378 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230304AbhBAOlH (ORCPT ); Mon, 1 Feb 2021 09:41:07 -0500 Received: from mail-wm1-x331.google.com (mail-wm1-x331.google.com [IPv6:2a00:1450:4864:20::331]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 92C05C061788 for ; Mon, 1 Feb 2021 06:39:48 -0800 (PST) Received: by mail-wm1-x331.google.com with SMTP id a16so46701wmm.0 for ; Mon, 01 Feb 2021 06:39:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=bM4mPrdGCmHIaP6sSEhqZR0ycPeA2MFnqRQ1Q2Z5NPg=; b=mapxxoizbqOdhL11CoWUraeZYOx5+PqR/p8mC5NxGcTDTQIuJkhsHdh1bXNCU9ADcZ j6YoODnzj2h3IFBHK/69d2IHLnPUZ2sF8zeVuWpjPwk8Y7LG0n7Km76U7zGNajBCrv1T m+SOn6WpVqUEDSpxdczlSX4Z6PThPVcue3a408x+5HNODq+4GBIt777xGiPS4YE0Z8QH +LrupyqH78BeEk1f1u2M9E8Wmt5u/us7gG6VawZa3ef/wYULl/Gwf/Q2I7HacgqCXnkm Oa+0Win/kSyStHptPyUH49e8bYY/4/LfJ9z5Nct7qfvSY42tZznM6I1xpb+YA1gggypV lA2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=bM4mPrdGCmHIaP6sSEhqZR0ycPeA2MFnqRQ1Q2Z5NPg=; b=IicyW4iEGIzghvijFmmPR/OVxXsaG6i4XX3UUAecXWb5nMd+eLlf8eeAgPBL3hYn33 58JCa7q+2jMiDmEfkbgKKWUaBscH5/yah5QueT0zDfJiStK1RP/ATgU4rujJh77JYBRU lJQM1Rp8LSflPT/Av9evnDWpJSJnUN03q1EGMNL8zsXKo26cgrByYSddIvrVv2tMWz5C BjXnH+idYx/RZ2+ItwIVFQLQWJy8Xzpmk94tVxmSU+2vmXpfR32/dedD4+gDaAqdWHqb lYArfTw1EpsI1LM3S5Vqn7y8Uix/vICmod6pAHlGEqRJB2ns1ZhgzrRjmetT7CJm04sl UMsg== X-Gm-Message-State: AOAM533/zGW+5BKEm+WXBmSNOSRLrxx/ifvV3VZGudT2bWdJ0q9O1+re 9sVFPVIg1BnqfNUeQbuCgC9geg== X-Google-Smtp-Source: ABdhPJwSS3qcNCTIijeUJvFc07Hg1M5sq5oqgoWJwehXRFxKDf9xzf9DLuwxxWGKtYcpCq9CaQIcAg== X-Received: by 2002:a05:600c:4fce:: with SMTP id o14mr10071229wmq.140.1612190387319; Mon, 01 Feb 2021 06:39:47 -0800 (PST) Received: from dell.default ([91.110.221.188]) by smtp.gmail.com with ESMTPSA id h15sm27301359wrt.10.2021.02.01.06.39.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Feb 2021 06:39:46 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Jens Axboe , Tejun Heo , linux-ide@vger.kernel.org Subject: [PATCH 03/20] ata: libata-pmp: Fix misspelling of 'val' Date: Mon, 1 Feb 2021 14:39:23 +0000 Message-Id: <20210201143940.2070919-4-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210201143940.2070919-1-lee.jones@linaro.org> References: <20210201143940.2070919-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/ata/libata-pmp.c:76: warning: Function parameter or member 'val' not described in 'sata_pmp_write' drivers/ata/libata-pmp.c:76: warning: Excess function parameter 'r_val' description in 'sata_pmp_write' Cc: Jens Axboe Cc: Tejun Heo Cc: linux-ide@vger.kernel.org Signed-off-by: Lee Jones --- drivers/ata/libata-pmp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/ata/libata-pmp.c b/drivers/ata/libata-pmp.c index 79f2aeeb482ab..ba7be3f386171 100644 --- a/drivers/ata/libata-pmp.c +++ b/drivers/ata/libata-pmp.c @@ -62,7 +62,7 @@ static unsigned int sata_pmp_read(struct ata_link *link, int reg, u32 *r_val) * sata_pmp_write - write PMP register * @link: link to write PMP register for * @reg: register to write - * @r_val: value to write + * @val: value to write * * Write PMP register. * From patchwork Mon Feb 1 14:39:24 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1434165 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=linux-ide-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=ra/HweOf; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4DTrHQ08cpz9tl7 for ; Tue, 2 Feb 2021 01:41:38 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230208AbhBAOlT (ORCPT ); Mon, 1 Feb 2021 09:41:19 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59390 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231131AbhBAOlJ (ORCPT ); Mon, 1 Feb 2021 09:41:09 -0500 Received: from mail-wr1-x42c.google.com (mail-wr1-x42c.google.com [IPv6:2a00:1450:4864:20::42c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9F2A3C06178C for ; Mon, 1 Feb 2021 06:39:49 -0800 (PST) Received: by mail-wr1-x42c.google.com with SMTP id p15so16785121wrq.8 for ; Mon, 01 Feb 2021 06:39:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=lDwxjOTNwRK/jrgXFyt6Q5KAd5bTTyW5pp6F8HQ+RfM=; b=ra/HweOfs/gsoL7RyLujE631F/5dEYvUbwH3AyoP0y+0qLVXdfz9LBEfiacR6k0Uiv /hmLUtwrpWpF8pMBw/JnZJFgp3UrAG8o0tGYTfvesq3H+057BEMzHQDVk0Wr3l9jmSFC sQzdhrMyVmMfr3Ez5VoTReuvdHasOXOM/18O+D1LAzBmAXSRs8eO/N7sUd611slNq5SP N9HIlQNxRDHpL2M8WPcGlCx9Ea2ECGM94xa9XIVHyGxgO8jfqnoiQoX/e8iMriwr5voJ YLqbsL1SCCeUlEumVhEdHwbDxaC0y4iw28JMpVgAKglMmGIvkmJeRCLSmLOsfFoIJXCN AG5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=lDwxjOTNwRK/jrgXFyt6Q5KAd5bTTyW5pp6F8HQ+RfM=; b=ITkjkMolJyTE4Lt07gfvZc99bCXjsTbTAoeeuhgMQtg9qnm6+Y0zZiGfu3tQDfQzY+ vdNpHnEHhTrlGIy6cBg2p3X09Y/XJkrpLv479PjtgHrdw50T7BMgqBmJBHV+XZm5+jB4 dv/BC0jIRO/jKo5l+hqX5+FYUFHBSyq7sawnxoxm5132lADezh5yawNxl8qTX1CYI+WC ihg/u27yV9p9zN9iUH4c9uNFTNo+bbYOvI8+IPrWsgItQC3kAh68YQTiCbKrnyLRdnaz yL4qQjik3PY5g6YXdR8XKbHxAtgFexwNuKRDr4vykSRrZE6ulosGErU5cPTxVyfxaY/6 +sMQ== X-Gm-Message-State: AOAM532r2sg7i4M67C61TkbmgXG6t8fvqO/sLPOypnhF3VcJLJJKpdtJ XWrUxL3LE2bTMMbR6KVoWs+ugQ== X-Google-Smtp-Source: ABdhPJw4cRTTRwXoePbizxuey8YfKHu06X58Br5OOurPNGDHnCrrdn6vczKshahRCQ+oD4IRxt4AXg== X-Received: by 2002:a05:6000:1202:: with SMTP id e2mr6890968wrx.328.1612190388422; Mon, 01 Feb 2021 06:39:48 -0800 (PST) Received: from dell.default ([91.110.221.188]) by smtp.gmail.com with ESMTPSA id h15sm27301359wrt.10.2021.02.01.06.39.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Feb 2021 06:39:47 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Jens Axboe , CJ , Andre Hedrick , Alan Cox , Clear Zhang , linux-ide@vger.kernel.org, and cc Subject: [PATCH 04/20] ata: pata_ali: Repair some misnamed kernel-doc issues Date: Mon, 1 Feb 2021 14:39:24 +0000 Message-Id: <20210201143940.2070919-5-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210201143940.2070919-1-lee.jones@linaro.org> References: <20210201143940.2070919-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/ata/pata_ali.c:119: warning: Function parameter or member 'mask' not described in 'ali_20_filter' drivers/ata/pata_ali.c:119: warning: Excess function parameter 'ap' description in 'ali_20_filter' drivers/ata/pata_ali.c:322: warning: Function parameter or member 'qc' not described in 'ali_check_atapi_dma' drivers/ata/pata_ali.c:322: warning: Excess function parameter 'adev' description in 'ali_check_atapi_dma' Cc: Jens Axboe Cc: CJ Cc: Andre Hedrick Cc: Alan Cox Cc: Clear Zhang Cc: linux-ide@vger.kernel.org Cc: and cc Signed-off-by: Lee Jones --- drivers/ata/pata_ali.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/ata/pata_ali.c b/drivers/ata/pata_ali.c index 0b122f903b8a8..e18aa02f89530 100644 --- a/drivers/ata/pata_ali.c +++ b/drivers/ata/pata_ali.c @@ -108,7 +108,7 @@ static int ali_c2_cable_detect(struct ata_port *ap) /** * ali_20_filter - filter for earlier ALI DMA - * @ap: ALi ATA port + * @adev: ATA device * @adev: attached device * * Ensure that we do not do DMA on CD devices. We may be able to @@ -313,7 +313,7 @@ static void ali_lock_sectors(struct ata_device *adev) /** * ali_check_atapi_dma - DMA check for most ALi controllers - * @adev: Device + * @qc: Command to complete * * Called to decide whether commands should be sent by DMA or PIO */ From patchwork Mon Feb 1 14:39:25 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1434201 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=linux-ide-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=xVIql7+8; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4DTsRv1BbJz9tl5 for ; Tue, 2 Feb 2021 02:34:03 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231660AbhBAPdt (ORCPT ); Mon, 1 Feb 2021 10:33:49 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59392 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231142AbhBAOlJ (ORCPT ); Mon, 1 Feb 2021 09:41:09 -0500 Received: from mail-wr1-x429.google.com (mail-wr1-x429.google.com [IPv6:2a00:1450:4864:20::429]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A8C37C061793 for ; Mon, 1 Feb 2021 06:39:50 -0800 (PST) Received: by mail-wr1-x429.google.com with SMTP id 6so16824094wri.3 for ; Mon, 01 Feb 2021 06:39:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=MvoGC7duOzp4QbVV73i8hwf4OtQFHAIOE3fctv618Vg=; b=xVIql7+8TZzLoGu0iro7M7rirVPW9tOh49bUKNDnqpyfpS3Whpmo74e7k4lVX93ghK QVGYeqDOTJbMgRuJisjN6jlFYsAmrD+1P3mj9jsLVvBnWVm93kEo66OucYsaQBVYoZYr WM8V68r8BOc6HohzdC0WhjVN9tseqS2ku2aX7l+ITaO++9MncJahBMgIDGPEt2RxBtgS CXTLa4/2IRIAwYScQVkcvkn7w4U3ydCD0dC+OX0X9QNUjRy3cR/9kPWc4jgx/qNGvH+r /ADOr10H5E40G+f43FuGXghvCW2ZAX+RXgxPJkCGSOjZhjjynyC4OFLmSxqdBnpPZNr3 XkeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=MvoGC7duOzp4QbVV73i8hwf4OtQFHAIOE3fctv618Vg=; b=fu4QzztvMVz9slWh3XrA2Dt7kUbzJCrmHAWmk2buBJOesM+0WGZDTdacLFRJh78MnR d3dQx+u/hN2XRPQrcuVDXdOAdCsSOW8vG1nLXQkQNb0Mi+aB1JUDR0BGyum3Z963FdKo PEDpiS6Q2COp7ZeeSEeXR+ar64p6KJfa5qFM5Zwaw94VZM/JRVG5UR9ukKEzlcM0blQs Fi/6e895LFGJ0KZ98YJedBJiBPAZvfXDhGbUtNObc7M9J7f9049HGxIPK+tigPwk96lQ d6+SVbfh7yhX9Y8Cx87y128Rx893nThvBStmAjxc/m5MWC2gUTCVa+WPv/6PHiE7iycr FbyQ== X-Gm-Message-State: AOAM5305d3ARY8/rCqMePea6/SvhohajIAATU+LcUEOE2YrOBekG7juf nYsS8xYaUpwqynTB12vxTuPCqw== X-Google-Smtp-Source: ABdhPJwqgKID1G0doaFBi2aHMNjBaJI2XDkLWh9DLrsoMChHmb+g5MausIaS5inHIRB+Z2DvD+UAaQ== X-Received: by 2002:adf:e3c2:: with SMTP id k2mr18373016wrm.337.1612190389474; Mon, 01 Feb 2021 06:39:49 -0800 (PST) Received: from dell.default ([91.110.221.188]) by smtp.gmail.com with ESMTPSA id h15sm27301359wrt.10.2021.02.01.06.39.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Feb 2021 06:39:48 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Jens Axboe , Andre Hedrick , Thibaut VARENE , Alessandro Zummo , linux-ide@vger.kernel.org Subject: [PATCH 05/20] ata: pata_artop: Fix a function name and parameter description Date: Mon, 1 Feb 2021 14:39:25 +0000 Message-Id: <20210201143940.2070919-6-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210201143940.2070919-1-lee.jones@linaro.org> References: <20210201143940.2070919-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/ata/pata_artop.c:278: warning: expecting prototype for artop_6210_qc_defer(). Prototype was for artop6210_qc_defer() instead drivers/ata/pata_artop.c:359: warning: Function parameter or member 'id' not described in 'artop_init_one' drivers/ata/pata_artop.c:359: warning: Excess function parameter 'ent' description in 'artop_init_one' Cc: Jens Axboe Cc: Andre Hedrick Cc: Thibaut VARENE Cc: Alessandro Zummo Cc: linux-ide@vger.kernel.org Signed-off-by: Lee Jones --- drivers/ata/pata_artop.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/ata/pata_artop.c b/drivers/ata/pata_artop.c index 6bd2228bb6ffa..02e4fd5e3b934 100644 --- a/drivers/ata/pata_artop.c +++ b/drivers/ata/pata_artop.c @@ -344,7 +344,7 @@ static void atp8xx_fixup(struct pci_dev *pdev) /** * artop_init_one - Register ARTOP ATA PCI device with kernel services * @pdev: PCI device to register - * @ent: Entry in artop_pci_tbl matching with @pdev + * @id: PCI device ID * * Called from kernel PCI layer. * From patchwork Mon Feb 1 14:39:26 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1434167 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=linux-ide-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=naPZ9ARq; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4DTrHZ3gpVz9tl5 for ; Tue, 2 Feb 2021 01:41:46 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231236AbhBAOl2 (ORCPT ); Mon, 1 Feb 2021 09:41:28 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59440 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230304AbhBAOlU (ORCPT ); Mon, 1 Feb 2021 09:41:20 -0500 Received: from mail-wm1-x32a.google.com (mail-wm1-x32a.google.com [IPv6:2a00:1450:4864:20::32a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AB754C0617A9 for ; Mon, 1 Feb 2021 06:39:51 -0800 (PST) Received: by mail-wm1-x32a.google.com with SMTP id u14so12840036wml.4 for ; Mon, 01 Feb 2021 06:39:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=psxck1KMWyXDOgBCEv3jYVYq9cj2r/nvdYNmqCZ8a8o=; b=naPZ9ARqYCwvn9JncVu9nING3uu/kiOgXUcGuQTkTs7taI4zz63FAnlO5iWAGDACmP iNXjbxhfFKnGqviFm5BLJpk/Wu4a/5bfixHBp9hT6evXG6ay6VrzNclsUPnPqWPYmkD/ +w7SdPm01xRq9T6iWux+jV3mGiLopxx0qBwFqKjz/4hrdP/SFrID+68Z7Qk/DJAR79Eh vHDJNIff4gd6ZinI4ir9DLGQgSubMZQZcEV4PIb3oNELlQsB7ldgGt9YCfDhmAf2G/LJ rST08acpa2/lv7Z/NoEnoBnODJBs/6tuJql74+yjwK5N5xolpDFN3w3VpKgo3hFV/L2z o3eg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=psxck1KMWyXDOgBCEv3jYVYq9cj2r/nvdYNmqCZ8a8o=; b=JkhZ/LVnzrwkl0t0id8oQvUj3KJPQiBrnyqyN5wwZOPHqCa74m1i0TtuoIrNzQfDOX iiLKlI/haYk/I66Q0yVDJXfPpGvDuHKYhfVuB5NZygEWisUyLr4UN8k8QTlVfaco/Rnq OXzVQUz/Sp3WoaZpXfLRspgAlLJZcqYy972nwg9ZKps5AVs22XsYDfRMTHhETGJOYCZ4 JaOUg0mnv1cAtLYHScMKiHkwDT2otRgjxu3Qf7+LBpjKadiEfk+0oEGElReiGvGY537A H6gsCPlNJqKH26ve3iIBsCutN+gZzf13SDvk4FRQBmCiT9BXDit9qFiaDN8d6PxTXPdq zRwQ== X-Gm-Message-State: AOAM530tGWwBgumVv2I5eZCWSf4MOzErXMiNV61UYHHKcjIadi0fI9nC j0VVLBKiwYLN+Zs2mz2NFwy11A== X-Google-Smtp-Source: ABdhPJx79fAmVLm4zlWTVY4xGoZWThx6TZd/7y+7bG+tOG2ZTCyfUiiFTet7/Ct3roidAjr1wfd10Q== X-Received: by 2002:a1c:5f89:: with SMTP id t131mr7153496wmb.148.1612190390339; Mon, 01 Feb 2021 06:39:50 -0800 (PST) Received: from dell.default ([91.110.221.188]) by smtp.gmail.com with ESMTPSA id h15sm27301359wrt.10.2021.02.01.06.39.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Feb 2021 06:39:49 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Jens Axboe , linux-ide@vger.kernel.org Subject: [PATCH 06/20] ata: pata_amd: Remove superfluous, add missing and fix broken params Date: Mon, 1 Feb 2021 14:39:26 +0000 Message-Id: <20210201143940.2070919-7-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210201143940.2070919-1-lee.jones@linaro.org> References: <20210201143940.2070919-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/ata/pata_amd.c:179: warning: Excess function parameter 'adev' description in 'amd_fifo_setup' drivers/ata/pata_amd.c:331: warning: Function parameter or member 'link' not described in 'nv_pre_reset' drivers/ata/pata_amd.c:331: warning: Function parameter or member 'deadline' not described in 'nv_pre_reset' drivers/ata/pata_amd.c:331: warning: expecting prototype for nv_probe_init(). Prototype was for nv_pre_reset() instead Cc: Jens Axboe Cc: linux-ide@vger.kernel.org Signed-off-by: Lee Jones --- drivers/ata/pata_amd.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/ata/pata_amd.c b/drivers/ata/pata_amd.c index 987967f976cb2..75b830eb3c542 100644 --- a/drivers/ata/pata_amd.c +++ b/drivers/ata/pata_amd.c @@ -167,7 +167,6 @@ static int amd_cable_detect(struct ata_port *ap) /** * amd_fifo_setup - set the PIO FIFO for ATA/ATAPI * @ap: ATA interface - * @adev: ATA device * * Set the PCI fifo for this device according to the devices present * on the bus at this point in time. We need to turn the post write buffer @@ -321,7 +320,8 @@ static unsigned long nv_mode_filter(struct ata_device *dev, /** * nv_probe_init - cable detection - * @lin: ATA link + * @link: ATA link + * @deadline: deadline jiffies for the operation * * Perform cable detection. The BIOS stores this in PCI config * space for us. From patchwork Mon Feb 1 14:39:27 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1434200 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=linux-ide-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=XCEabafG; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4DTsRt4ZGbz9tkv for ; Tue, 2 Feb 2021 02:34:02 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231654AbhBAPdf (ORCPT ); Mon, 1 Feb 2021 10:33:35 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59384 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231259AbhBAOl2 (ORCPT ); Mon, 1 Feb 2021 09:41:28 -0500 Received: from mail-wm1-x336.google.com (mail-wm1-x336.google.com [IPv6:2a00:1450:4864:20::336]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C6ED5C0617AB for ; Mon, 1 Feb 2021 06:39:52 -0800 (PST) Received: by mail-wm1-x336.google.com with SMTP id j18so12853774wmi.3 for ; Mon, 01 Feb 2021 06:39:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=bku/TZDwGiY5vuh8zroI/7gSSOC7kKg9Wo8De+jk1lQ=; b=XCEabafGuemjP1gHa/5Xw5MSj0MuP0PquR4NvFr1yb8kbn3KLr8XI51ghFUwxjmjtb EMCfX9DQ2UCxv1vxTyJHuDfrHPoONZ2KQblr2bZtBHkGBLDokAW8foKVYhpMotiuRXUC 7ZqdxGZUINgl233YDbGXfPeXCqnvaW0smpv9zfiJlxemAW4xYidNk24MIdbEkMxKJEux RzwSsopK79UNjf/BwZkkvQfq/3BrqE7BM5ALD568moghnjCvDK92ydVS+aK8KCsZOkoJ muswkVkTtJZXJlZBobBcOASS68KtGdceyC1xoRV/GZkDor+g5XPsIRX5L0IvzEU8eQmL 8Jmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=bku/TZDwGiY5vuh8zroI/7gSSOC7kKg9Wo8De+jk1lQ=; b=OStgAkFxMw43uUFzn3xhyzvSzn/qAtOUr1CpIC/LbGJicB/zD/eGRH1Pk9QjGYnmvR DVxYld/XaK3ONWIIie4Da7NYrfPQkQeUKqmnzwsPIX6pRt+r+urAhcruG4gdUwjApSbh 04ud8gIYvqFeg+NeKlM7tHipmt1U5uOOfdIUAay9JcD/0+uq1uTO+NCYqa8eive7xKiI 4Z031DKaU5254qRZJZeBnAJNWcuPq0DQUJJRT3ZUkAnCuBbNFl5ftveBQfs07u6GrXh1 c8l1jmEAbdV3ooNJVJAHPOJingzLXSA9IY1s8OdrpTfD0juUBqvGV8X9nUByxF2WAFpG 98yg== X-Gm-Message-State: AOAM532oEev/jW5tT8tlYH5tfLfa65VggOP8+3ERs2bc+ihZ55GQMzpa EVFiN0HFF4kohcRO/UhNXLwQgA== X-Google-Smtp-Source: ABdhPJx00o3B7KG5YWycXJnUp+FrSSgY1g5OgGjWmWV4YzRws8GYDs6sikt6/4gGY6Wdo6s34X5ILA== X-Received: by 2002:a1c:7914:: with SMTP id l20mr15820968wme.85.1612190391549; Mon, 01 Feb 2021 06:39:51 -0800 (PST) Received: from dell.default ([91.110.221.188]) by smtp.gmail.com with ESMTPSA id h15sm27301359wrt.10.2021.02.01.06.39.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Feb 2021 06:39:50 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Jens Axboe , Andre Hedrick , linux-ide@vger.kernel.org Subject: [PATCH 07/20] ata: pata_hpt366: Provide missing description for 'hpt366_filter()'s 'mask' param Date: Mon, 1 Feb 2021 14:39:27 +0000 Message-Id: <20210201143940.2070919-8-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210201143940.2070919-1-lee.jones@linaro.org> References: <20210201143940.2070919-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/ata/pata_hpt366.c:200: warning: Function parameter or member 'mask' not described in 'hpt366_filter' Cc: Jens Axboe Cc: Andre Hedrick Cc: linux-ide@vger.kernel.org Signed-off-by: Lee Jones --- drivers/ata/pata_hpt366.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/ata/pata_hpt366.c b/drivers/ata/pata_hpt366.c index 2574d6fbb1ad3..06b7c4a9ec954 100644 --- a/drivers/ata/pata_hpt366.c +++ b/drivers/ata/pata_hpt366.c @@ -192,6 +192,7 @@ static int hpt_dma_blacklisted(const struct ata_device *dev, char *modestr, /** * hpt366_filter - mode selection filter * @adev: ATA device + * @mask: Current mask to manipulate and pass back * * Block UDMA on devices that cause trouble with this controller. */ From patchwork Mon Feb 1 14:39:28 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1434175 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=linux-ide-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=N14fXMdf; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4DTrRS46yQz9tl5 for ; Tue, 2 Feb 2021 01:48:36 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229808AbhBAOsU (ORCPT ); Mon, 1 Feb 2021 09:48:20 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59560 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230085AbhBAOly (ORCPT ); Mon, 1 Feb 2021 09:41:54 -0500 Received: from mail-wr1-x433.google.com (mail-wr1-x433.google.com [IPv6:2a00:1450:4864:20::433]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D5ABEC061352 for ; Mon, 1 Feb 2021 06:39:53 -0800 (PST) Received: by mail-wr1-x433.google.com with SMTP id d16so16793693wro.11 for ; Mon, 01 Feb 2021 06:39:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=0PbmlJv/q/qmETwokGHFJjxp6oe2rW16X/lQKCZKsiQ=; b=N14fXMdfJ2dY7UVo6YqvhbGGyRE7Akw/jRTJP4tcKHzwsHYQi8NDJqUkPOXyzSuN1+ xEcc4Ay6vMNarhmuhQ/x57mdTja1HJlBVOU5YFqxXOTccKCiWebmJNiRTDden3uPxTt1 2PvnirLGXFdSJISunOh5hfbJ7xpNpDlTA6NLZCou1Ce408pt5es0qNDWkWWQ+E2GAtEN O2lKyGmZHI3pC6QrW/kQ3iZdTmIn43oPXXHEtfK8ZBOz2m0tjwlF6Ln5V4jcJd+qp+9L SX/Zn458jPa2nQnbHUhYnyOpnsIXmPuxfdctiEM7cCY+gbAQIKMFjTRc6rvGQTWj4x7u U0cw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=0PbmlJv/q/qmETwokGHFJjxp6oe2rW16X/lQKCZKsiQ=; b=m1IdWETMEfuYlJh/mvDAGOOYUmRgB2JXGkiBIW2hMKRRlcfkLwZvUjBKPYrR61aPJZ /A6wVqF39Mp5GeSiD99TN7z+xh+4jVSHS2m5HP0LNLLcsj2sGaX72vvCBBxxYsPlU4a5 smssvaLrkfEAAli8DCBeKW3PH7bExWiBwH1JAAfH1DXaIAgkwsCBv1Vo36fbg5kZj3oS UbEvV/SAuT4R/BVi8QGkXj5kQ4hlwNBJ7qrSgX8VaiL/aQoUbTUJFbT6fN1p0aG6qdxw KwivpdReRUF6MOvwOOGVIboHoDuh7Zsviqsgj9FbKWE0qEDnSCjtiBsC4DluBdXwB3G7 tPZg== X-Gm-Message-State: AOAM531bd9SFekFlEW9XBQ/qlR7oEyvCPalvQqhqB9jI1YGerjVWTVnE OOFj+vyEt+PYNVihjpfCFKyJnQ== X-Google-Smtp-Source: ABdhPJxWCUUYP+Zom+mOzHMrYuXDGlYfLGnUzNJnvCnLg7JI1fuFV8GAZT1yQ7wBEdpWmPWJ2R8dJg== X-Received: by 2002:a05:6000:234:: with SMTP id l20mr18426866wrz.212.1612190392539; Mon, 01 Feb 2021 06:39:52 -0800 (PST) Received: from dell.default ([91.110.221.188]) by smtp.gmail.com with ESMTPSA id h15sm27301359wrt.10.2021.02.01.06.39.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Feb 2021 06:39:52 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Jens Axboe , Andre Hedrick , linux-ide@vger.kernel.org Subject: [PATCH 08/20] ata: pata_hpt37x: Fix some function misnaming and missing param issues Date: Mon, 1 Feb 2021 14:39:28 +0000 Message-Id: <20210201143940.2070919-9-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210201143940.2070919-1-lee.jones@linaro.org> References: <20210201143940.2070919-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/ata/pata_hpt37x.c:283: warning: Function parameter or member 'mask' not described in 'hpt370_filter' drivers/ata/pata_hpt37x.c:301: warning: Function parameter or member 'mask' not described in 'hpt370a_filter' drivers/ata/pata_hpt37x.c:473: warning: expecting prototype for hpt370_bmdma_end(). Prototype was for hpt370_bmdma_stop() instead drivers/ata/pata_hpt37x.c:567: warning: expecting prototype for hpt37x_bmdma_end(). Prototype was for hpt37x_bmdma_stop() instead Cc: Jens Axboe Cc: Andre Hedrick Cc: linux-ide@vger.kernel.org Signed-off-by: Lee Jones --- drivers/ata/pata_hpt37x.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/ata/pata_hpt37x.c b/drivers/ata/pata_hpt37x.c index fad6c6a873130..f242157bc81bb 100644 --- a/drivers/ata/pata_hpt37x.c +++ b/drivers/ata/pata_hpt37x.c @@ -275,6 +275,7 @@ static const char * const bad_ata100_5[] = { /** * hpt370_filter - mode selection filter * @adev: ATA device + * @mask: mode mask * * Block UDMA on devices that cause trouble with this controller. */ @@ -293,6 +294,7 @@ static unsigned long hpt370_filter(struct ata_device *adev, unsigned long mask) /** * hpt370a_filter - mode selection filter * @adev: ATA device + * @mask: mode mask * * Block UDMA on devices that cause trouble with this controller. */ @@ -463,7 +465,7 @@ static void hpt370_set_dmamode(struct ata_port *ap, struct ata_device *adev) } /** - * hpt370_bmdma_end - DMA engine stop + * hpt370_bmdma_stop - DMA engine stop * @qc: ATA command * * Work around the HPT370 DMA engine. @@ -557,7 +559,7 @@ static void hpt372_set_dmamode(struct ata_port *ap, struct ata_device *adev) } /** - * hpt37x_bmdma_end - DMA engine stop + * hpt37x_bmdma_stop - DMA engine stop * @qc: ATA command * * Clean up after the HPT372 and later DMA engine From patchwork Mon Feb 1 14:39:29 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1434176 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=linux-ide-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=F0SiN9Dm; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4DTrRS6lQHz9tkx for ; Tue, 2 Feb 2021 01:48:36 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230085AbhBAOsV (ORCPT ); Mon, 1 Feb 2021 09:48:21 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59562 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230350AbhBAOly (ORCPT ); Mon, 1 Feb 2021 09:41:54 -0500 Received: from mail-wr1-x42b.google.com (mail-wr1-x42b.google.com [IPv6:2a00:1450:4864:20::42b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DB998C061353 for ; Mon, 1 Feb 2021 06:39:54 -0800 (PST) Received: by mail-wr1-x42b.google.com with SMTP id g10so16847006wrx.1 for ; Mon, 01 Feb 2021 06:39:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=BlJPa4weJ+jes2vrsBZmFk9aHoMXb6b/UAhdjjLI1xw=; b=F0SiN9DmZ1Xdcfbxi61rTAlrPyojJUgAzZ/1RiUTkgtwwca9O5QhFjwlBbbEQtWEHX WNAMHH+XxfmPqKtxm/uEYnrLU7lY+o5PYd9ilDZP9bztnMjeVYm/PI9cvtl4iTAlI8N/ z4JGm0Ea3lMswss6UGbF4P3vWPMQRotQvB59WFypEUG0ta9Zgr3Pjr6ftz90vwk4DIAI 1iK9KD+iUQ3zjKDzlOdKpp2hK5vOPIzfP7IQIPSCmBgg7YMCnH9kSIelnxRfa21Zo6Rb cpra3uvnXL4N66hgn+AshdROd6hPH+soSkrdyyveu/XnE+eCcMG4AtbFc/+RAlnO+7/c RP1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=BlJPa4weJ+jes2vrsBZmFk9aHoMXb6b/UAhdjjLI1xw=; b=dm5GjrZlIkxs9OBkMN+5rQUWeeNPfYHd0hP8FX5dlGCNI7AaEkF0+UqGciNCbLGlyN iiERx4CmcsVnHLg56bt0/+7Sxg/qmcFs1BOeBDQ7zdaOaVlcHVPL0Vs5OkbsOvAHkp6I BTrfHnhvpyzuetTsdY7T33zTROkrd5eMCU1BAvMKpfTPkdcT3b/6LDnu6K8Dix3GnfT/ X/3h0lVW+UpOU4EarIu+IhXVIwCH4evdlThGnUhZtVkMPG7IF2yTDq05+RAIVQhPX2vw 0dRBXIYsb7fvrOXxoU4Ic6O86ZOPJyE2qd780o7rh+vvdOeGJ6v8/uSx+RvvZ08dXw1u vnqg== X-Gm-Message-State: AOAM531yNqQjYFslx8XQVyrwLklbTvj8dYIQpS6jC495JkHbk3ucWFUJ oEBF7QMBanCBp0u/wKp5hXDDNw== X-Google-Smtp-Source: ABdhPJwmhRhU9Ly9NFrfSfP/oHtPUxEQBV7+5lmrquiTKc1I6Z5/0LBvOlyxwZje10Yq+NQTGg9UNg== X-Received: by 2002:adf:f749:: with SMTP id z9mr18083441wrp.327.1612190393694; Mon, 01 Feb 2021 06:39:53 -0800 (PST) Received: from dell.default ([91.110.221.188]) by smtp.gmail.com with ESMTPSA id h15sm27301359wrt.10.2021.02.01.06.39.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Feb 2021 06:39:53 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Jens Axboe , Loc Ho , Tuan Phan , Suman Tripathi , linux-ide@vger.kernel.org Subject: [PATCH 09/20] ata: ahci_xgene: Fix incorrect naming of 'xgene_ahci_handle_broken_edge_irq()'s 'host' param Date: Mon, 1 Feb 2021 14:39:29 +0000 Message-Id: <20210201143940.2070919-10-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210201143940.2070919-1-lee.jones@linaro.org> References: <20210201143940.2070919-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/ata/ahci_xgene.c:564: warning: Function parameter or member 'host' not described in 'xgene_ahci_handle_broken_edge_irq' drivers/ata/ahci_xgene.c:564: warning: Excess function parameter 'ata_host' description in 'xgene_ahci_handle_broken_edge_irq' Cc: Jens Axboe Cc: Loc Ho Cc: Tuan Phan Cc: Suman Tripathi Cc: linux-ide@vger.kernel.org Signed-off-by: Lee Jones --- drivers/ata/ahci_xgene.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/ata/ahci_xgene.c b/drivers/ata/ahci_xgene.c index 16246c843365e..dffc432b9d54a 100644 --- a/drivers/ata/ahci_xgene.c +++ b/drivers/ata/ahci_xgene.c @@ -537,7 +537,7 @@ static int xgene_ahci_softreset(struct ata_link *link, unsigned int *class, /** * xgene_ahci_handle_broken_edge_irq - Handle the broken irq. - * @ata_host: Host that recieved the irq + * @host: Host that recieved the irq * @irq_masked: HOST_IRQ_STAT value * * For hardware with broken edge trigger latch From patchwork Mon Feb 1 14:39:30 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1434171 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=linux-ide-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=vG3UQ+l+; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4DTrJq3x3Jz9tl5 for ; Tue, 2 Feb 2021 01:42:51 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231356AbhBAOmh (ORCPT ); Mon, 1 Feb 2021 09:42:37 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59578 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231293AbhBAOl5 (ORCPT ); Mon, 1 Feb 2021 09:41:57 -0500 Received: from mail-wm1-x32a.google.com (mail-wm1-x32a.google.com [IPv6:2a00:1450:4864:20::32a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 05CA9C061356 for ; Mon, 1 Feb 2021 06:39:56 -0800 (PST) Received: by mail-wm1-x32a.google.com with SMTP id f16so12846888wmq.5 for ; Mon, 01 Feb 2021 06:39:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=uUtjn0S2LB1hEBiPsRyILzvTGxsfFgJnwAguVJkwf8M=; b=vG3UQ+l+muIGDHGg3gEgTsa/CSGlQIvpCl4ZeEr0EUUKg3YWINzSdhoBAXfkpa2NA7 k1N1BRCVDpz19btJTYIJ1WI9JUk2Kx9jISuQsSypXosLNdFcmohr7FzEVNgWrTz+UImc rDfla+w1wScD7ZvEd7gTr6eLiI+mt4KHtfV6HO++7kUqx0jCKprmVUoVvYzPfeiS+Erw sc/IiAWKSTXjbBXcFX6PK0E6y82cr57noddv08jT9SmQC9oETCriihIINqAtAH5Pn0WZ kBH8UEH/bl7hcokw0v6FJ2Oer4+orEg6AUzBVU6lv2PWvjWY/STzxRZZgU4YioNgH+FR 1rkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=uUtjn0S2LB1hEBiPsRyILzvTGxsfFgJnwAguVJkwf8M=; b=C7O/UMhasR6NcCULoA0a0Ai6v+Rat6GiQIzE7PEUCTlnJgzlex+MQhp3UGxpvVs+iV Eeg+ntQ2q/IV2G4h0Ph48yY07KVEyKWFK+OOyqlnS3ey0xWkincF6T/j4FuLIM7DPZUp ICb5FH4IAUZraHXL47qazqBfeFC0NzBA3UV0qhcf20as+7wJLzxymWuPaEjhavifeRTI KoZuCmTHL+QWl6NOEVS6N+PoV28zNktsiaKIY3EkBePl3xA/aJIGo2HuX607It3ouaRe 3pJ4mq122sIX/q7toZkBMeSeIbK/FuKEFVokdfN86vTh0H5Xca3vQDBPXX+ttE+TQe/1 zHlw== X-Gm-Message-State: AOAM533N0mlX7A5grgy3OTO2fv2XaqkanUMHkvxAvLJyePabFlo6A6d2 TbNGID+h73KihtIiNPRjQSEYTtnvB+tkG9X5 X-Google-Smtp-Source: ABdhPJxobTaw4erHEZXaTGvIHvRL7goO2idA9MkntLyU+8VAP9P3xHuQvw/0uWnOuztJqpKMs8DHBQ== X-Received: by 2002:a7b:c196:: with SMTP id y22mr15365130wmi.91.1612190394771; Mon, 01 Feb 2021 06:39:54 -0800 (PST) Received: from dell.default ([91.110.221.188]) by smtp.gmail.com with ESMTPSA id h15sm27301359wrt.10.2021.02.01.06.39.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Feb 2021 06:39:54 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Jens Axboe , Mark Lord , ALWAYS copy Subject: [PATCH 10/20] ata: sata_mv: Fix worthy headers and demote others Date: Mon, 1 Feb 2021 14:39:30 +0000 Message-Id: <20210201143940.2070919-11-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210201143940.2070919-1-lee.jones@linaro.org> References: <20210201143940.2070919-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/ata/sata_mv.c:1162: warning: Function parameter or member 'ap' not described in 'mv_start_edma' drivers/ata/sata_mv.c:1162: warning: Function parameter or member 'port_mmio' not described in 'mv_start_edma' drivers/ata/sata_mv.c:1162: warning: Function parameter or member 'protocol' not described in 'mv_start_edma' drivers/ata/sata_mv.c:1162: warning: Excess function parameter 'base' description in 'mv_start_edma' drivers/ata/sata_mv.c:1535: warning: Function parameter or member 'enable_bmdma' not described in 'mv_bmdma_enable_iie' drivers/ata/sata_mv.c:1535: warning: expecting prototype for mv_bmdma_enable(). Prototype was for mv_bmdma_enable_iie() instead drivers/ata/sata_mv.c:1930: warning: Function parameter or member 'ap' not described in 'mv_bmdma_stop_ap' drivers/ata/sata_mv.c:1930: warning: expecting prototype for mv_bmdma_stop(). Prototype was for mv_bmdma_stop_ap() instead drivers/ata/sata_mv.c:2228: warning: Function parameter or member 'ap' not described in 'mv_send_fis' drivers/ata/sata_mv.c:3263: warning: Function parameter or member 'hpriv' not described in 'mv6_reset_hc' drivers/ata/sata_mv.c:3263: warning: Function parameter or member 'n_hc' not described in 'mv6_reset_hc' drivers/ata/sata_mv.c:3541: warning: Function parameter or member 'hpriv' not described in 'soc_is_65n' drivers/ata/sata_mv.c:3541: warning: expecting prototype for soc_is_65(). Prototype was for soc_is_65n() instead Cc: Jens Axboe Cc: Mark Lord Cc: ALWAYS copy Cc: linux-ide@vger.kernel.org Signed-off-by: Lee Jones --- drivers/ata/sata_mv.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/ata/sata_mv.c b/drivers/ata/sata_mv.c index 664ef658a955f..eafca46d8feb4 100644 --- a/drivers/ata/sata_mv.c +++ b/drivers/ata/sata_mv.c @@ -1146,9 +1146,8 @@ static void mv_set_irq_coalescing(struct ata_host *host, spin_unlock_irqrestore(&host->lock, flags); } -/** +/* * mv_start_edma - Enable eDMA engine - * @base: port base address * @pp: port private data * * Verify the local cache of the eDMA state is accurate with a @@ -1519,7 +1518,7 @@ static void mv_60x1_errata_sata25(struct ata_port *ap, int want_ncq) writel(new, hpriv->base + GPIO_PORT_CTL); } -/** +/* * mv_bmdma_enable - set a magic bit on GEN_IIE to allow bmdma * @ap: Port being initialized * @@ -1919,7 +1918,7 @@ static void mv_bmdma_start(struct ata_queued_cmd *qc) /** * mv_bmdma_stop - Stop BMDMA transfer - * @qc: queued command to stop DMA on. + * @ap: port to stop * * Clears the ATA_DMA_START flag in the bmdma control register * @@ -2221,6 +2220,7 @@ static u8 mv_sff_check_status(struct ata_port *ap) /** * mv_send_fis - Send a FIS, using the "Vendor-Unique FIS" register + * @ap: ATA port to send a FIS * @fis: fis to be sent * @nwords: number of 32-bit words in the fis */ @@ -3249,7 +3249,7 @@ static void mv6_reset_flash(struct mv_host_priv *hpriv, void __iomem *mmio) writel(tmp, mmio + GPIO_PORT_CTL); } -/** +/* * mv6_reset_hc - Perform the 6xxx global soft reset * @mmio: base address of the HBA * @@ -3530,7 +3530,7 @@ static void mv_soc_65n_phy_errata(struct mv_host_priv *hpriv, writel(reg, port_mmio + PHY_MODE9_GEN1); } -/** +/* * soc_is_65 - check if the soc is 65 nano device * * Detect the type of the SoC, this is done by reading the PHYCFG_OFS From patchwork Mon Feb 1 14:39:31 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1434168 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=linux-ide-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=qbYFQrEy; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4DTrJp2c5kz9tl5 for ; Tue, 2 Feb 2021 01:42:50 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230070AbhBAOm0 (ORCPT ); Mon, 1 Feb 2021 09:42:26 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59584 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231294AbhBAOl5 (ORCPT ); Mon, 1 Feb 2021 09:41:57 -0500 Received: from mail-wm1-x32f.google.com (mail-wm1-x32f.google.com [IPv6:2a00:1450:4864:20::32f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 16708C06121C for ; Mon, 1 Feb 2021 06:39:57 -0800 (PST) Received: by mail-wm1-x32f.google.com with SMTP id e15so13385383wme.0 for ; Mon, 01 Feb 2021 06:39:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=JAIDQ52yty18Fyb/YeAsOfkiyO3vjgo1F5NJ+/twun8=; b=qbYFQrEymhU8IyMyd/W+xyHgEQS2ALYVHHu3Tmj3qxjxObq+xE7GMPhYo/3nV3cd0M ixDzbn2zT0p+kMc8QZsuiA0ERK352J/+GcNUjkSyKyEEhsSzFiVO5FlhQoUY7nSRzaFh XmVLFlfxHvX74H3Y1amefFPvgpi9eTCHXUVB2ryU4PWC2IlV1Qk6+CF2SuWAu8RaqTYK eiD0LcqRMTvjUjtgQITUtKJ1+j/eDT3ul7E5b1FhQSSKuQzZyHKPm0CAAYiEboMo2EQE rDw6lpdnu8UPktc1UKCLMzIMun+bgsZenUqIyLyDN18GnXvO6vOjHV5e6la/pwmrTPQt 0y5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=JAIDQ52yty18Fyb/YeAsOfkiyO3vjgo1F5NJ+/twun8=; b=YlY7ED4USGc+51aM3D6NXbt50RF+06Cn256H1hhFIJBAi8p7g0AcTToKMWBPAiq19Z j+e1c2hivDeHSDi0UWLtBauSR42p0+z9pPjAFohbMxqOblzbBA9LdmWxJh8uSMoKEgt4 tGmqvDkZYn8bR+4zljcPyPGbXmlcqbzk6SGLQnYNWDGFvdtwi/GIVUMRr1kTnPeBWvEh Rwl2lg2wiaAPbCRakvtOTL64xv+YSQd+7WyGhw0EvXfCT/ke8Mxj/srx4v8yDC5VA3Lv o6ziHrfMvZvubkVKu3mipO1aAH8ycwWUbYMCWpcsveD/CqrPpyXK6GmXibFW9a/0Ydm1 4bqQ== X-Gm-Message-State: AOAM533zIpkjIxbQdNvbOsFdftr04kQIR20pG3O3JOKsJ8o3kQxZeWAc uiWLFKa56o7sCvMp2buWJOIu4w== X-Google-Smtp-Source: ABdhPJyigSkulBFJW/jNpdf7+2zKlUAzb6spDNuflsbOwKmOfK+waKamOJQYIESQRrdt2LY7eekrUA== X-Received: by 2002:a1c:f70f:: with SMTP id v15mr15072829wmh.38.1612190395853; Mon, 01 Feb 2021 06:39:55 -0800 (PST) Received: from dell.default ([91.110.221.188]) by smtp.gmail.com with ESMTPSA id h15sm27301359wrt.10.2021.02.01.06.39.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Feb 2021 06:39:55 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Jens Axboe , CJ , Andre Hedrick , Alan Cox , Clear Zhang , linux-ide@vger.kernel.org, and cc Subject: [PATCH 11/20] ata: pata_ali: Supply description for 'ali_20_filter()'s 'mask' param Date: Mon, 1 Feb 2021 14:39:31 +0000 Message-Id: <20210201143940.2070919-12-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210201143940.2070919-1-lee.jones@linaro.org> References: <20210201143940.2070919-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/ata/pata_ali.c:119: warning: Function parameter or member 'mask' not described in 'ali_20_filter' Cc: Jens Axboe Cc: CJ Cc: Andre Hedrick Cc: Alan Cox Cc: Clear Zhang Cc: linux-ide@vger.kernel.org Cc: and cc Signed-off-by: Lee Jones --- drivers/ata/pata_ali.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/ata/pata_ali.c b/drivers/ata/pata_ali.c index e18aa02f89530..557ecf4661022 100644 --- a/drivers/ata/pata_ali.c +++ b/drivers/ata/pata_ali.c @@ -109,7 +109,7 @@ static int ali_c2_cable_detect(struct ata_port *ap) /** * ali_20_filter - filter for earlier ALI DMA * @adev: ATA device - * @adev: attached device + * @mask: received mask to manipulate and pass back * * Ensure that we do not do DMA on CD devices. We may be able to * fix that later on. Also ensure we do not do UDMA on WDC drives From patchwork Mon Feb 1 14:39:32 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1434198 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=linux-ide-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=nfEkhzEb; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4DTsR66P5Mz9tkv for ; Tue, 2 Feb 2021 02:33:22 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231250AbhBAPdU (ORCPT ); Mon, 1 Feb 2021 10:33:20 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59390 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231282AbhBAOld (ORCPT ); Mon, 1 Feb 2021 09:41:33 -0500 Received: from mail-wr1-x432.google.com (mail-wr1-x432.google.com [IPv6:2a00:1450:4864:20::432]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 009C5C06121D for ; Mon, 1 Feb 2021 06:39:57 -0800 (PST) Received: by mail-wr1-x432.google.com with SMTP id c4so14119249wru.9 for ; Mon, 01 Feb 2021 06:39:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=g/xsj8QnzTyjZTuByN2rtr+7Bim8nVB2CCDQafkvd6A=; b=nfEkhzEbgz14R/tMpOwQ02Eojho5vUVU6vM5evj27Ooo/l1N7p5vTWgkfFKNa0uKE7 +gL6H7kg3w41Bpb8ofpNmElwXHFyNIzGswnfbEVq/OFUytD3g/H/mgX+4QlicbyFv0/w WljXKAe/AzV6xBwDr0P8gni8A31IN+pDSzCjGJuPRXFeFypKWYwrh+IzBWGDbTzPOHlm bIWi94gCiNKCUhCft7VLMbp9LwTOu26W7vti9odQn6WaLswVKDBHrRMrkc85EeApTMHC YbMkMAAZXD/5paEW4cT6W09tmhnY1tzAB/fUOvKHbMBAcCbWQrVd5pc3c1Lh7e9sI2He OsOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=g/xsj8QnzTyjZTuByN2rtr+7Bim8nVB2CCDQafkvd6A=; b=EP8vjL1YDk5KByLpXY3NXa4uO+oFOnFSG8HSPgTuFye3DNZq0Mo3QFmz+wTRtJnNpG gyGCc97I4W4N4ACn2oNvPWVOeyqH8pPAL0L0ykOxZZ+chX9Qhz3Vc7u5BAdDHl0G0XkD TwGLdc6iUuHe4xBN7F58jkzWj9WiRoanntdR7wiSpTkilRifrObmv56myeuISmGoZ8eo DnZApjwn7/Tf+6QfJE7cbOMfsubaTLAIucbXID8ev3s1JArf4xE6Q/Bs+SXqcCAhN7Hy ByWpraPHKw6IIaSPDdhmJepZ4YAIIv+9tuJSqo0R8MgtHgYIkiaFjoI7woNY8oypncJk z/zA== X-Gm-Message-State: AOAM53087iP5K9OLGqZtI3Ll7KWmmmztA7bcSCMsCqinBVwyJyMqdnn1 rS+nLQ61FsEVBOXDCmm9gUpOww== X-Google-Smtp-Source: ABdhPJzPmYic1cm2Sz5pCBPwPCfylEgtpIbm5kuKCNjN5CBDvdpU0QDAwGLOOSsk3STc3hYIRx2dGQ== X-Received: by 2002:adf:dd10:: with SMTP id a16mr18522509wrm.207.1612190396737; Mon, 01 Feb 2021 06:39:56 -0800 (PST) Received: from dell.default ([91.110.221.188]) by smtp.gmail.com with ESMTPSA id h15sm27301359wrt.10.2021.02.01.06.39.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Feb 2021 06:39:56 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Jens Axboe , linux-ide@vger.kernel.org Subject: [PATCH 12/20] ata: pata_amd: Fix incorrectly named function in the header Date: Mon, 1 Feb 2021 14:39:32 +0000 Message-Id: <20210201143940.2070919-13-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210201143940.2070919-1-lee.jones@linaro.org> References: <20210201143940.2070919-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/ata/pata_amd.c:331: warning: expecting prototype for nv_probe_init(). Prototype was for nv_pre_reset() instead Cc: Jens Axboe Cc: linux-ide@vger.kernel.org Signed-off-by: Lee Jones --- drivers/ata/pata_amd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/ata/pata_amd.c b/drivers/ata/pata_amd.c index 75b830eb3c542..c8acba162d02f 100644 --- a/drivers/ata/pata_amd.c +++ b/drivers/ata/pata_amd.c @@ -319,7 +319,7 @@ static unsigned long nv_mode_filter(struct ata_device *dev, } /** - * nv_probe_init - cable detection + * nv_pre_reset - cable detection * @link: ATA link * @deadline: deadline jiffies for the operation * From patchwork Mon Feb 1 14:39:33 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1434197 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=linux-ide-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=BcdbDpUn; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4DTsR533J0z9tkT for ; Tue, 2 Feb 2021 02:33:21 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230438AbhBAPdC (ORCPT ); Mon, 1 Feb 2021 10:33:02 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59398 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231186AbhBAOle (ORCPT ); Mon, 1 Feb 2021 09:41:34 -0500 Received: from mail-wr1-x430.google.com (mail-wr1-x430.google.com [IPv6:2a00:1450:4864:20::430]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1BC2FC06121F for ; Mon, 1 Feb 2021 06:39:59 -0800 (PST) Received: by mail-wr1-x430.google.com with SMTP id v15so16864621wrx.4 for ; Mon, 01 Feb 2021 06:39:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=aMe7a3VhppfmWxSaJ9lM7zaGZfgpPGsI1NmH6z3NMlY=; b=BcdbDpUnb48xUjDHyx+e2GZVxndB7U/KUWaPtWTaDHqFfJbSXUNkZHX++3YaFlDs1d v4DqOQnLLK8V3qLaJWQ8mfTuEJLc/FiVzS01Rgxw8mZdHae27NwDTTxbRCpnNJKTNzAZ Oe3naI2SbGdvzXzxewWpclopEeQe+VzbtaOSpOi0w2GZ+Q+wP6OLNMro9W1BnDqIXC71 fHgWMMnQpBNVQnN0RTDJCbm8zSM0KPdM08gD8f07e52K4Tod8/nYPrcOqdqfo3C1djTc aU+oCj8RhJvWpun80Sg1GZRyIsl5fFCT4PzDE+m/S7OTTqLS9/dxVC+2GWDOWfCcmxvd kIwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=aMe7a3VhppfmWxSaJ9lM7zaGZfgpPGsI1NmH6z3NMlY=; b=ro17x7soKcoSfWu9KD2YUi8clRsd1q7cMJUkMtwQ/7izcY5bZnTaxnWN0czezGIHHG cCUxDSzGrJFX/BQLVsYyqCLgSinWh5k67g4VTewM9h6QCQuJEHN5JK17lnVsEDnO9Azz FImpp0alRc+I6Xzsqd67SCq0fbIRUb4c0g+erR0a88Dako7K7IZyq2P+I2ldG7d3Lun1 rLr6qXd1phsGHTodBMUpaTbmkqVpfYirmtdAdReQeca4hcWcF7Vaajg2qjSu7et3OojF y57AuwYkMYFZ4kJlVbW+DmsSldOq1cDEihPrsz0F2mRUCweCNNr7fapwHuIrwMDQhuQJ gh+Q== X-Gm-Message-State: AOAM533+NCyadb132ITGYJ+giJ2ulKwAz2X4sw0SzAmzprwar/urZ6wH 6qfLuXBCSwQY7LQoGyjSpOiscg== X-Google-Smtp-Source: ABdhPJzeOP1pJu5xl/+NmIPMfTjbgeyKY82fMKBoQz6WDykeOZ8f2/+1+uXUaS6hiuxPKbwonPdTBA== X-Received: by 2002:a05:6000:1202:: with SMTP id e2mr6891636wrx.328.1612190397886; Mon, 01 Feb 2021 06:39:57 -0800 (PST) Received: from dell.default ([91.110.221.188]) by smtp.gmail.com with ESMTPSA id h15sm27301359wrt.10.2021.02.01.06.39.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Feb 2021 06:39:57 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Jens Axboe , Andre Hedrick , Thibaut VARENE , Alessandro Zummo , linux-ide@vger.kernel.org Subject: [PATCH 13/20] ata: pata_artop: Repair possible copy/paste issue in 'artop_6210_qc_defer()'s header Date: Mon, 1 Feb 2021 14:39:33 +0000 Message-Id: <20210201143940.2070919-14-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210201143940.2070919-1-lee.jones@linaro.org> References: <20210201143940.2070919-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/ata/pata_artop.c:278: warning: expecting prototype for artop_6210_qc_defer(). Prototype was for artop6210_qc_defer() instead Cc: Jens Axboe Cc: Andre Hedrick Cc: Thibaut VARENE Cc: Alessandro Zummo Cc: linux-ide@vger.kernel.org Signed-off-by: Lee Jones --- drivers/ata/pata_artop.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/ata/pata_artop.c b/drivers/ata/pata_artop.c index 02e4fd5e3b934..ad3c5808aaad6 100644 --- a/drivers/ata/pata_artop.c +++ b/drivers/ata/pata_artop.c @@ -268,7 +268,7 @@ static void artop6260_set_dmamode (struct ata_port *ap, struct ata_device *adev) } /** - * artop_6210_qc_defer - implement serialization + * artop6210_qc_defer - implement serialization * @qc: command * * Issue commands per host on this chip. From patchwork Mon Feb 1 14:39:34 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1434179 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=linux-ide-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=nBNTL8Nl; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4DTrWc03bFz9tkx for ; Tue, 2 Feb 2021 01:52:12 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229981AbhBAOtZ (ORCPT ); Mon, 1 Feb 2021 09:49:25 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59400 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231283AbhBAOle (ORCPT ); Mon, 1 Feb 2021 09:41:34 -0500 Received: from mail-wm1-x334.google.com (mail-wm1-x334.google.com [IPv6:2a00:1450:4864:20::334]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 26F1FC061221 for ; Mon, 1 Feb 2021 06:40:00 -0800 (PST) Received: by mail-wm1-x334.google.com with SMTP id i9so13408896wmq.1 for ; Mon, 01 Feb 2021 06:40:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=9JDBMmgrFoXz6Tq0/RYZRCcswI9jrwMOoIxfQ3LDYhE=; b=nBNTL8NllFuSIqpu9W87YK9Jyo6ZKRW4b3Efot8Fbhi8ZYVkCfVHFFNUuk+wle657W VFaXvFYoaSgc4skwFELv1JFyX/Nf9mKDuV79+hTvtUqGbVQdl+ZPQJoFIxCIOe4axf1W JhLt4ECV+Gkth0ae5s6owEii/hMXqeTBeSzddcE3xqXL/lB2O2WMKCI1Ypt0t0JXi0+X AIli0lASNRDooifXIYIKbM+oh+KTi/abrUZ+TWb1zIkNe+a1SK7JB+KsWn6fU2SY47rc PqWP7DCpwPuIMieFkjDlFIASLzRa3fr6U1qaO0pdIcxP0uTC760nmaDel/fB0z15I5Jp rc1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=9JDBMmgrFoXz6Tq0/RYZRCcswI9jrwMOoIxfQ3LDYhE=; b=h4PXM0PFamQj6DDM1d5mjdEL3V2MPNpeJy02EIPB+/qh67mcmTa7YVw4Tz8dk97uUN BV4/RcG5wMoF+SQUCtfJOnUf0o0Nv/iKmQ2fIBVsrIGBtY2Pcrtiq98ZzEbBJzxgWyeS F1USsLKNSvB/9VnTiw5UsM2XIvyqzXra60P/ar+zYBw8Wj7jUhuXVtYWDqyZSqYIoNhM wy0EEna8st5feOvecJS5I4qzfh10avz5iYNAhBh3kIc/TT0oyatB3W7JFs6YF0os1Ftu Upl8l1alHkq6bWxDwIfOuny98fUh4De/0OB6DTl5KK+o8eaAXWp3WOhP/PxwFZWLzp5K G2Mw== X-Gm-Message-State: AOAM532QDuKVwWo1evlsn1YUuiPH8Fe/Oe29McSoFR/gDPEOo9hQtqL0 b7gB4dYaNvhgH9Cja5TF9MhODkiPrPxrpxxO X-Google-Smtp-Source: ABdhPJzETHP18h8WFbldkDtgdSCitWNoRnpxhK0ewYLbgWMleHO3cRkXllWdeuLFsAfYkmzie4btGA== X-Received: by 2002:a05:600c:3504:: with SMTP id h4mr2789387wmq.168.1612190398918; Mon, 01 Feb 2021 06:39:58 -0800 (PST) Received: from dell.default ([91.110.221.188]) by smtp.gmail.com with ESMTPSA id h15sm27301359wrt.10.2021.02.01.06.39.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Feb 2021 06:39:58 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Jens Axboe , ATI Inc , linux-ide@vger.kernel.org Subject: [PATCH 14/20] ata: pata_atiixp: Fix a function name and supply description for 'pio' Date: Mon, 1 Feb 2021 14:39:34 +0000 Message-Id: <20210201143940.2070919-15-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210201143940.2070919-1-lee.jones@linaro.org> References: <20210201143940.2070919-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/ata/pata_atiixp.c:103: warning: Function parameter or member 'pio' not described in 'atiixp_set_pio_timing' drivers/ata/pata_atiixp.c:241: warning: expecting prototype for atiixp_dma_stop(). Prototype was for atiixp_bmdma_stop() instead Cc: Jens Axboe Cc: ATI Inc Cc: linux-ide@vger.kernel.org Signed-off-by: Lee Jones --- drivers/ata/pata_atiixp.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/ata/pata_atiixp.c b/drivers/ata/pata_atiixp.c index c68aa3f585f22..d671d33ef2874 100644 --- a/drivers/ata/pata_atiixp.c +++ b/drivers/ata/pata_atiixp.c @@ -93,6 +93,7 @@ static int atiixp_prereset(struct ata_link *link, unsigned long deadline) * atiixp_set_pio_timing - set initial PIO mode data * @ap: ATA interface * @adev: ATA device + * @pio: Requested PIO * * Called by both the pio and dma setup functions to set the controller * timings for PIO transfers. We must load both the mode number and @@ -227,7 +228,7 @@ static void atiixp_bmdma_start(struct ata_queued_cmd *qc) } /** - * atiixp_dma_stop - DMA stop callback + * atiixp_bmdma_stop - DMA stop callback * @qc: Command in progress * * DMA has completed. Clear the UDMA flag as the next operations will From patchwork Mon Feb 1 14:39:35 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1434172 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=linux-ide-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=xmgCh16H; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4DTrJr01gFz9tl7 for ; Tue, 2 Feb 2021 01:42:52 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231260AbhBAOmd (ORCPT ); Mon, 1 Feb 2021 09:42:33 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59610 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231310AbhBAOmC (ORCPT ); Mon, 1 Feb 2021 09:42:02 -0500 Received: from mail-wm1-x333.google.com (mail-wm1-x333.google.com [IPv6:2a00:1450:4864:20::333]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9FF7BC061224 for ; Mon, 1 Feb 2021 06:40:01 -0800 (PST) Received: by mail-wm1-x333.google.com with SMTP id o5so3207830wmq.2 for ; Mon, 01 Feb 2021 06:40:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=lZQZ2+RpbHKZWQO23K1r/ewrXGBIiSW5L8ZHxuWPrs8=; b=xmgCh16HvTuwSIDl5iaFrhej4lliLPb1/BAdCNM/4oGwvBx0dXS74eJ/pTA2+zLcKF YeGTByROdLeXKb8VBwPsQNK47AZB2dFO8HW9a270MFO9IEsEkkOY7S9YrC7YRLNoLGv4 vnAAWpgX7ie714uBfKY1FzVEbgP1Az2DlMsVLzA2d0MuTmclo4A3D3MucgxrK8yXZ0cS 0IT8ZbUp6D4pfkV9A1Bst3Oed1rx/MfN2RzzUdjP7KXf9+letuhvsGaLUPF97DhIePEl GMMON83O4v2QPudunlw7MkvT9u4t5DQaXDd/ivJcTFPkkTo5L8bbloek5K4Mhxb1lW+V SzSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=lZQZ2+RpbHKZWQO23K1r/ewrXGBIiSW5L8ZHxuWPrs8=; b=fUX5eOD+ZiH8hMdsfBhOvtGXzomNH8WEM+O3Q4Xl2kZC6VGtJmH7w485QHy7iQzxau Q+e5AW05gfxx5uPKzP8vRnveTIcRAfWlakOFkijdvqbov07sJDYVfLcVTdvVapokpzub EL3ESa5WJ7ZihUZFs2IzSag4HH+OubCRb5S2tBvjBIjbQWeXKP76e/HJqaZ9QEDHjIV2 AaF/vYKje+pNJ5a9PzMpWF1RqaigyR2EIjHse1iaQHFqT1aPF/E7i/32tN/b8pkEbrV0 /zhyisHX8jYx4MD/ESzOawyjA0W+oUzkZ3SHJivmdvdA7sEQnZ6PuId4SWFf+/5UcSrZ HPIQ== X-Gm-Message-State: AOAM532bNjwA30VV46sGL7+gyc3OujWehUzjmxNrVeZx8E/0XMCavbmF vxXhK0m1vyDfShvIZPPjWTUN2g== X-Google-Smtp-Source: ABdhPJwZ0G6ijrnEYSz7NgxKOh/BkCcPUmv/6NSvL43tf/tSWGXYgq+H2fprAKcMsJcJ7tFRP9DRzw== X-Received: by 2002:a1c:bcd4:: with SMTP id m203mr15142721wmf.120.1612190400345; Mon, 01 Feb 2021 06:40:00 -0800 (PST) Received: from dell.default ([91.110.221.188]) by smtp.gmail.com with ESMTPSA id h15sm27301359wrt.10.2021.02.01.06.39.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Feb 2021 06:39:59 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Jens Axboe , linux-ide@vger.kernel.org Subject: [PATCH 15/20] ata: pata_cs5520: Add a couple of missing param descriptions Date: Mon, 1 Feb 2021 14:39:35 +0000 Message-Id: <20210201143940.2070919-16-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210201143940.2070919-1-lee.jones@linaro.org> References: <20210201143940.2070919-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/ata/pata_cs5520.c:61: warning: Function parameter or member 'pio' not described in 'cs5520_set_timings' drivers/ata/pata_cs5520.c:257: warning: Function parameter or member 'mesg' not described in 'cs5520_pci_device_suspend' Cc: Jens Axboe Cc: linux-ide@vger.kernel.org Signed-off-by: Lee Jones --- drivers/ata/pata_cs5520.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/ata/pata_cs5520.c b/drivers/ata/pata_cs5520.c index 9052148b306d9..d09d432d3c442 100644 --- a/drivers/ata/pata_cs5520.c +++ b/drivers/ata/pata_cs5520.c @@ -52,6 +52,7 @@ static const struct pio_clocks cs5520_pio_clocks[]={ * cs5520_set_timings - program PIO timings * @ap: ATA port * @adev: ATA device + * @pio: PIO ID * * Program the PIO mode timings for the controller according to the pio * clocking table. @@ -246,6 +247,7 @@ static int cs5520_reinit_one(struct pci_dev *pdev) /** * cs5520_pci_device_suspend - device suspend * @pdev: PCI device + * @mesg: PM event message * * We have to cut and waste bits from the standard method because * the 5520 is a bit odd and not just a pure ATA device. As a result From patchwork Mon Feb 1 14:39:36 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1434177 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=linux-ide-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=WH4TudRd; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4DTrRT2Flbz9tl5 for ; Tue, 2 Feb 2021 01:48:37 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230350AbhBAOsW (ORCPT ); Mon, 1 Feb 2021 09:48:22 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59440 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231287AbhBAOlm (ORCPT ); Mon, 1 Feb 2021 09:41:42 -0500 Received: from mail-wr1-x435.google.com (mail-wr1-x435.google.com [IPv6:2a00:1450:4864:20::435]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 811AFC061225 for ; Mon, 1 Feb 2021 06:40:02 -0800 (PST) Received: by mail-wr1-x435.google.com with SMTP id 6so16824863wri.3 for ; Mon, 01 Feb 2021 06:40:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=c13mHJ9q4khjz3HwzXj0RVixkGCKPHZCZNKDXnyAPKA=; b=WH4TudRdMpbtfWTgz3kZxyfD4xxbcAxrnxExnwv52RKJdsQciElU5atM3mvLIWKCo4 akyCXc3l1pwmQHiKrQ1TdBh5FirhGwBrhP/08yHl5/WYFOd3wQrynGBQ4WeiFchqLKEY 6SjClh99xFLDo7kGMUePuwCZx7K5wTVc/gs6LkO3Vays5jjTblnbgTSlsOiV0UNQHtWE z8mpj0GpZ/3CkH2EA9oQNpMxR/SSTV6h9aDEAN4sqXNaIOBfdaCNeZbHR9UKsidX+Mkz /lMM3WCQG2VuEqh9R61Ikh4k0eLqx0vatbWNy8P/xz4XQjGmQiCk57gTguUZQMGYskzJ K0lA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=c13mHJ9q4khjz3HwzXj0RVixkGCKPHZCZNKDXnyAPKA=; b=GabM2VDWb/8JLAFgzggqkRpsW4ZVauCzdn12UniW5/7WGhWQEHcI+ps+e4PhmdsLYN 2U0uzn5VuWok/ceIbBT8F38YMCtldTn6vmhxPusejKPgu0LdjucT8Qsa/uSbMg05ftid X6FEBcrB4Wfs43Jr2D3pRgXXhE01f9rDrtXaJ2k5hwPUqgV5vjwNu3+gt8GkLa3RaDBD RfUKRfwxYl/jCSt+ONjXGNXIRnIRN+nTWImwDSaWIruk2u4ccBZZe1BDaAd3p0/6Nxf0 4dvWoQ0inTxGAc0SZD+qE8vvBwqKdasFlSdIHNLNV/zEf4F60sl/naojrY+5TYw+hc+Z TXpA== X-Gm-Message-State: AOAM531161pjV3ndfzbUBtwLqL7JXgB/lr5zwDSIigqHDQqB9bRuVrPh 9RMG5xjd1Nl2uLIEZTN4/k8pD8fB46yASDwG X-Google-Smtp-Source: ABdhPJxmGE3JK7wr0XyMbiF60DgeRRAUKAjBPS36IT8pEnVa6IVYU7eGywYdD12qP9vrfvp1AAtmqw== X-Received: by 2002:a05:6000:234:: with SMTP id l20mr18427477wrz.212.1612190401316; Mon, 01 Feb 2021 06:40:01 -0800 (PST) Received: from dell.default ([91.110.221.188]) by smtp.gmail.com with ESMTPSA id h15sm27301359wrt.10.2021.02.01.06.40.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Feb 2021 06:40:00 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Jens Axboe , Andre Hedrick , linux-ide@vger.kernel.org Subject: [PATCH 16/20] ata: pata_hpt3x2n: Fix possible doc-rotted function name Date: Mon, 1 Feb 2021 14:39:36 +0000 Message-Id: <20210201143940.2070919-17-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210201143940.2070919-1-lee.jones@linaro.org> References: <20210201143940.2070919-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/ata/pata_hpt3x2n.c:247: warning: expecting prototype for hpt3x2n_bmdma_end(). Prototype was for hpt3x2n_bmdma_stop() instead Cc: Jens Axboe Cc: Andre Hedrick Cc: linux-ide@vger.kernel.org Signed-off-by: Lee Jones --- drivers/ata/pata_hpt3x2n.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/ata/pata_hpt3x2n.c b/drivers/ata/pata_hpt3x2n.c index 9cb2d50db8768..48eef338e0507 100644 --- a/drivers/ata/pata_hpt3x2n.c +++ b/drivers/ata/pata_hpt3x2n.c @@ -237,7 +237,7 @@ static void hpt3x2n_set_dmamode(struct ata_port *ap, struct ata_device *adev) } /** - * hpt3x2n_bmdma_end - DMA engine stop + * hpt3x2n_bmdma_stop - DMA engine stop * @qc: ATA command * * Clean up after the HPT3x2n and later DMA engine From patchwork Mon Feb 1 14:39:37 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1434169 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=linux-ide-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=SG05VYxh; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4DTrJp5gl5z9tl7 for ; Tue, 2 Feb 2021 01:42:50 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230214AbhBAOma (ORCPT ); Mon, 1 Feb 2021 09:42:30 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59384 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231309AbhBAOmB (ORCPT ); Mon, 1 Feb 2021 09:42:01 -0500 Received: from mail-wm1-x32f.google.com (mail-wm1-x32f.google.com [IPv6:2a00:1450:4864:20::32f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 059F3C0611C1 for ; Mon, 1 Feb 2021 06:40:04 -0800 (PST) Received: by mail-wm1-x32f.google.com with SMTP id f16so12847282wmq.5 for ; Mon, 01 Feb 2021 06:40:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=WJaD217hQSKXajKZh4odA4Ej+1+v0RwQsiQWigDD874=; b=SG05VYxhmiATV5Ec3tvOkXLMrtpO6V14Fm3Zwv0mZhiDBH4OZFX5TaUa9sOHOjC+Tu d10ZRrDCUN6tUnyWCTknGMLanH76OlM07HYXalx1cPDtjztamew6UjyupxXAgpe9Uj9b RHsaF6AvlaoQbyIJqOYIfVBlVOFAFLYmn4fWjNmb0xG4/DIdg2fjrkeIj9vIgRJpolOu 029hZeLOkgBTeWwhiStraalAbZ2mGo8Qm7kKukpgOTgMvkBpJPf0fqvLtsutVVvIR9x4 wpu3bCQzEOyj/tv/aaZEjLyuRyU1lcHSQHESU/XWfFbDAsc6l/rK4Xtla45p1qX84lI1 nzlQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=WJaD217hQSKXajKZh4odA4Ej+1+v0RwQsiQWigDD874=; b=pHbvdokrccvXPbrUCsdQVu3SMW/18yf/EqTe/Nls3x+zW0a8KW4cJzmrRPEuCkqniE aFTGfyG/FluqJp1XUTNxbYsDr4mskNWZ1EdoZX832UktW4gn9XZTxJG6pZnhAELvPt/o qpVUhMfMgJwANt2/mESHUmSIVA08W5WyFgJ/az9cQBIDO5LYk1wRSHJPyZOKr4tG+h37 kT2eXZzoCcjcFB1oe2E0nMOpOr1ZFzL21jatSNcU0lmeEx2MvQh7/QNJc4+vcdIYQ/F6 +PSixcS+15w7DDeCsf11RyUsqfT7Be3qhZ0qXTJDUwUKgAbo/kzgoQV3Cl0El5XdluKL rBRQ== X-Gm-Message-State: AOAM533iSZ4QX9UIROTlMMNnhXRKgVTYCw7Y2T1w7fsBvswhCH8XNQNz A4QWhXzkXqnlejT1rnPwLYZXEg== X-Google-Smtp-Source: ABdhPJxypag9z0BgoaEL/svkoZORBrkuDUZgll+5UCqGmWHIy0AIcFk/35ta5jgAWFKrNRwwoacCAQ== X-Received: by 2002:a05:600c:358e:: with SMTP id p14mr15081905wmq.73.1612190402700; Mon, 01 Feb 2021 06:40:02 -0800 (PST) Received: from dell.default ([91.110.221.188]) by smtp.gmail.com with ESMTPSA id h15sm27301359wrt.10.2021.02.01.06.40.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Feb 2021 06:40:02 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Jens Axboe , linux-ide@vger.kernel.org Subject: [PATCH 17/20] ata: pata_marvell: Fix incorrectly documented function parameter Date: Mon, 1 Feb 2021 14:39:37 +0000 Message-Id: <20210201143940.2070919-18-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210201143940.2070919-1-lee.jones@linaro.org> References: <20210201143940.2070919-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/ata/pata_marvell.c:125: warning: Function parameter or member 'id' not described in 'marvell_init_one' drivers/ata/pata_marvell.c:125: warning: Excess function parameter 'ent' description in 'marvell_init_one' Cc: Jens Axboe Cc: linux-ide@vger.kernel.org Signed-off-by: Lee Jones --- drivers/ata/pata_marvell.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/ata/pata_marvell.c b/drivers/ata/pata_marvell.c index b066809ba9a11..361597d14c569 100644 --- a/drivers/ata/pata_marvell.c +++ b/drivers/ata/pata_marvell.c @@ -110,7 +110,7 @@ static struct ata_port_operations marvell_ops = { /** * marvell_init_one - Register Marvell ATA PCI device with kernel services * @pdev: PCI device to register - * @ent: Entry in marvell_pci_tbl matching with @pdev + * @id: PCI device ID * * Called from kernel PCI layer. * From patchwork Mon Feb 1 14:39:38 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1434170 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=linux-ide-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=bYvX8DN6; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4DTrJq1Hq5z9tlC for ; Tue, 2 Feb 2021 01:42:51 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231309AbhBAOmg (ORCPT ); Mon, 1 Feb 2021 09:42:36 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59388 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231356AbhBAOmV (ORCPT ); Mon, 1 Feb 2021 09:42:21 -0500 Received: from mail-wm1-x333.google.com (mail-wm1-x333.google.com [IPv6:2a00:1450:4864:20::333]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DC8D3C0611C3 for ; Mon, 1 Feb 2021 06:40:04 -0800 (PST) Received: by mail-wm1-x333.google.com with SMTP id m1so10118414wml.2 for ; Mon, 01 Feb 2021 06:40:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=em+gLbL0BxMKq+E5i1mocv9ySIOeHFQQcLtILPjRTbE=; b=bYvX8DN6puR8b7BNSHbtD3EGzAX8GmRCTU9rZXqtMjFG8LsRvf5JgcpaN5Eg0SuSzD v99HFxVFAj4ouotyGhhoykw4QRJfl/7p+A2qApaZbAHT1nHbG7qnrUZ9f4puKZ7LT1tw IlB1YbGoj3a2T781/UyZ8YUsJmq92yP5RpBbBSWALaZ0a3O43XpW8mnCdZacEkinmW+3 voPWPhDAVw+bGAy/2SlDMcy9MUs1jlwLqRz/f9WZJJ+o+T4KCR8gWp0NpxbTDNVe3gMK HtFGJNFUl3rO9Db476SSvjfd2gPKGcAR0ylzGjZJL2AZwnJcQ1ytaC/Bof4zUO577TxC Qg4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=em+gLbL0BxMKq+E5i1mocv9ySIOeHFQQcLtILPjRTbE=; b=iIjaGJRAejjryrk3dmC7PDJ8+jwqCiUdmHscSIRK3V1Zfre3WZJRn03MHAEgpIlpDY yHGYWvNREuI5Rl6IuMkQcTh5R/0ArhkImx56kByWBIcF/hg84g88c5JuEJiYGlPmpetj 6ms4Bt4iBpAO/UQkGALiXCi2fbgGbnCB4FRKUhljWM7ypb8FuWS0W3EZdyghnvYUwvL2 Y5maitno0JC+PToyQ/DYYk1Sil07y4jA5lqJMSuuU4+EzAhSXn5gaG23upouKv3I5ll4 2v7yOeQGzxf0KJlcqM/rvQokeGgQkkVt25r4tdPRg14VJ2JxwzUow4XOJ2psctSO+tca UOqA== X-Gm-Message-State: AOAM532SxyCxWwWC4nf0x6hP/ANpuj6uI/338jG1EgdKLiB1FhtztQrp YIEl0aObgcosb/d1MH+mBAEJYG4CT8HrNigJ X-Google-Smtp-Source: ABdhPJyc08NDT3zH5UVhJCpxD73EWT+WifUl/TRZitj6I91P0mVM4NzVQNWwyLo3J7Rjs8SPDueCtQ== X-Received: by 2002:a1c:e912:: with SMTP id q18mr15422813wmc.162.1612190403647; Mon, 01 Feb 2021 06:40:03 -0800 (PST) Received: from dell.default ([91.110.221.188]) by smtp.gmail.com with ESMTPSA id h15sm27301359wrt.10.2021.02.01.06.40.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Feb 2021 06:40:03 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Jens Axboe , linux-ide@vger.kernel.org Subject: [PATCH 18/20] ata: pata_jmicron: Fix incorrectly documented function parameter Date: Mon, 1 Feb 2021 14:39:38 +0000 Message-Id: <20210201143940.2070919-19-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210201143940.2070919-1-lee.jones@linaro.org> References: <20210201143940.2070919-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/ata/pata_jmicron.c:135: warning: Function parameter or member 'id' not described in 'jmicron_init_one' drivers/ata/pata_jmicron.c:135: warning: Excess function parameter 'ent' description in 'jmicron_init_one' Cc: Jens Axboe Cc: linux-ide@vger.kernel.org Signed-off-by: Lee Jones --- drivers/ata/pata_jmicron.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/ata/pata_jmicron.c b/drivers/ata/pata_jmicron.c index c3dedd3e71fb7..d1b3ce8958ddc 100644 --- a/drivers/ata/pata_jmicron.c +++ b/drivers/ata/pata_jmicron.c @@ -120,7 +120,7 @@ static struct ata_port_operations jmicron_ops = { /** * jmicron_init_one - Register Jmicron ATA PCI device with kernel services * @pdev: PCI device to register - * @ent: Entry in jmicron_pci_tbl matching with @pdev + * @id: PCI device ID * * Called from kernel PCI layer. * From patchwork Mon Feb 1 14:39:39 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1434174 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=linux-ide-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=B4G7JSQd; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4DTrRS0VlYz9tkx for ; Tue, 2 Feb 2021 01:48:36 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229629AbhBAOsT (ORCPT ); Mon, 1 Feb 2021 09:48:19 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59392 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231381AbhBAOmX (ORCPT ); Mon, 1 Feb 2021 09:42:23 -0500 Received: from mail-wr1-x429.google.com (mail-wr1-x429.google.com [IPv6:2a00:1450:4864:20::429]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 068F1C0611BD for ; Mon, 1 Feb 2021 06:40:06 -0800 (PST) Received: by mail-wr1-x429.google.com with SMTP id l12so16849975wry.2 for ; Mon, 01 Feb 2021 06:40:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=g5vWVj1PxyNkZrXGNhPOfAFboUN5KZo8O3CdBy4NesU=; b=B4G7JSQdB4HA8+vgLEnKbugF9Ks5XEiRVYap9L6+9NSD+70VrhCfdfm7XnfeA2Dn15 FuZC8w+qFLpr86V5MFxKi/66rZoqFvOwKHShk6axOBXrEb7qs4C0J0KIo5V4kiujlvql U9rY5/Envm5r/vBZ3LVjS7VGPvqxN+cXTIJuGk2N83ODoP72l2QuCJi48ly+JROj9ptR BfIeTExkdYJuCwedU75cYifeXxEqNlZM2YkOAk3lAEM7mL/Je4x3TwgNY6fB5Ofy2vXM 1P/WNFhlit/SaOFpzYyCiwhnMqbZzlHuHZuSJj0PWKHjVXj7D/y/xE/da33gjtlpLkHn Qc6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=g5vWVj1PxyNkZrXGNhPOfAFboUN5KZo8O3CdBy4NesU=; b=O8yfAklXtgdyEtxfdZWvsAAyYiNwEIp+/MKUjZNGLpBtym48HuAFBhvaeLyLHZ7yzD bYCG5NiVlEn2EOajSqbSxaHPslMFg+YchvxJYzk1559oR+Avoy0yNYhUUYssAec8RCCT D9FjYPmM4RGgk/jaKYjk/Mnoi+zuwQSl18Xde1fhblK+jPrUqV6ApUaCSB9aPiSxGLzT c00/kvX6Bh6En5njhHY8fBuSAPkiFbQ2yxsfNIoEyZ8U4cMGbeSTRLsd26YDSwZKZPkW R0NR4yUNll4ApcL6lvTV69UHZtUfgCr032xKUqixXd+u457yT69Uhkst+Fmxm8kln8aV Uv5w== X-Gm-Message-State: AOAM533rGBVD7Fw5MyfL3DWYuLTBBQrfDJfHZ8RnWSi7SN16lVFaFFEZ M7JENwr3IJW6pL/nxhzsrH12/A== X-Google-Smtp-Source: ABdhPJyHgmUqVQc96gVAt9CQolaGiQEbbEm8oddOV9JXaA61Fnhy21TVEPpeAq8fVb/tJI/+LbQi8g== X-Received: by 2002:a5d:6a85:: with SMTP id s5mr17869868wru.283.1612190404772; Mon, 01 Feb 2021 06:40:04 -0800 (PST) Received: from dell.default ([91.110.221.188]) by smtp.gmail.com with ESMTPSA id h15sm27301359wrt.10.2021.02.01.06.40.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Feb 2021 06:40:04 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Jens Axboe , linux-ide@vger.kernel.org Subject: [PATCH 19/20] ata: pata_optidma: Fix a function misnaming, a formatting issue and a missing description Date: Mon, 1 Feb 2021 14:39:39 +0000 Message-Id: <20210201143940.2070919-20-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210201143940.2070919-1-lee.jones@linaro.org> References: <20210201143940.2070919-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/ata/pata_optidma.c:298: warning: expecting prototype for optidma_make_bits(). Prototype was for optidma_make_bits43() instead drivers/ata/pata_optidma.c:319: warning: Function parameter or member 'r_failed' not described in 'optidma_set_mode' drivers/ata/pata_optidma.c:361: warning: Function parameter or member 'pdev' not described in 'optiplus_with_udma' Cc: Jens Axboe Cc: linux-ide@vger.kernel.org Signed-off-by: Lee Jones --- drivers/ata/pata_optidma.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/ata/pata_optidma.c b/drivers/ata/pata_optidma.c index fbcf0af34924d..f6278d9de3486 100644 --- a/drivers/ata/pata_optidma.c +++ b/drivers/ata/pata_optidma.c @@ -287,7 +287,7 @@ static void optiplus_set_dma_mode(struct ata_port *ap, struct ata_device *adev) } /** - * optidma_make_bits - PCI setup helper + * optidma_make_bits43 - PCI setup helper * @adev: ATA device * * Turn the ATA device setup into PCI configuration bits @@ -309,6 +309,7 @@ static u8 optidma_make_bits43(struct ata_device *adev) /** * optidma_set_mode - mode setup * @link: link to set up + * @r_failed: out parameter for failed device * * Use the standard setup to tune the chipset and then finalise the * configuration by writing the nibble of extra bits of data into @@ -354,7 +355,7 @@ static struct ata_port_operations optiplus_port_ops = { /** * optiplus_with_udma - Look for UDMA capable setup - * @pdev; ATA controller + * @pdev: ATA controller */ static int optiplus_with_udma(struct pci_dev *pdev) From patchwork Mon Feb 1 14:39:40 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1434173 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=linux-ide-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=Ypd5PZfS; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4DTrKW6bdJz9tl5 for ; Tue, 2 Feb 2021 01:43:27 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231352AbhBAOnB (ORCPT ); Mon, 1 Feb 2021 09:43:01 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59398 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231294AbhBAOmg (ORCPT ); Mon, 1 Feb 2021 09:42:36 -0500 Received: from mail-wr1-x42d.google.com (mail-wr1-x42d.google.com [IPv6:2a00:1450:4864:20::42d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2E3E6C0611BE for ; Mon, 1 Feb 2021 06:40:07 -0800 (PST) Received: by mail-wr1-x42d.google.com with SMTP id g10so16847706wrx.1 for ; Mon, 01 Feb 2021 06:40:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=QyQtn17PTBrcRsPcgHDOZTKxROdnGY6b4VlV5omsb8Y=; b=Ypd5PZfSNYNiJAYSx+BZ9Vu97SLXnMdYKLrCGZ9szRSzrZ1Rdtn03RWttjlyxVJTEP x1llYip6JKBwInGWquGAjb560vGHl7wDHBy7Oehttp2kBaOkOYYDswDAx1yoI7APC8tp vS8kIq4zGoGmeAJlRPyGLWLukENBH8CfRM719g3o8TU7iheZQGGgMynx2+hfWCUj3l9Q w1c59YWEum5h1/HYaFd4thKrhS1fSq3Nu6sNMjr/8UncUEY/6+E3k5oV69wEel2dfx5Z vBSvfkhUurg85FpU//XAbzQ9txe8BDaJg2VdYSEJrc9UKrAKqGM84PftrPe08C38rapL wKVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=QyQtn17PTBrcRsPcgHDOZTKxROdnGY6b4VlV5omsb8Y=; b=iWViqgA3pXDocyrVUMwfSv9q8icuTfev+2qZLjGBjzvEJq8WETd00pVlzYlGEmevwr 0R0BtYkx96gBNBsioEVKeXi5lFIqL9dasILPvqsgBIYaRl1c29Xe5G1mHtFeyy797gal ZJUJOk4TyRjcVB5tUCt3eYM4/uqzA1ZOiBVeanTlUHoFspSZSX0kehgn1JOE/VlyQZkY XrgHWLRn5Iv1pBY1LDKhzIFqqJFiJQHc5vfi0Yv1yrukzkdM1cpgj6t9lg5Kpg+Psc4C 37zOCjFkY1OzBDubP/N/lfkf8FMY4hEllO9f4Y4FruJnJ7shLwkCj4Pdy7xr3GTszNe5 KhuQ== X-Gm-Message-State: AOAM531LtEf56ll0LVWDh26++7yxrO2/ZpMsT8tDtwQkKfSl1zUlMCvD 9T+lKel3cb3+PWoCm8LOOkTqIQ== X-Google-Smtp-Source: ABdhPJz8aTRKHvddtB5nncbPFCCIBsYnVI7a6DdrYz/XZgAQ2mtfhZTen/1AL1goK6IY5AAhRytGag== X-Received: by 2002:a5d:60d0:: with SMTP id x16mr18578011wrt.269.1612190405951; Mon, 01 Feb 2021 06:40:05 -0800 (PST) Received: from dell.default ([91.110.221.188]) by smtp.gmail.com with ESMTPSA id h15sm27301359wrt.10.2021.02.01.06.40.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Feb 2021 06:40:05 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Jens Axboe , Albert Lee , Andre Hedrick , Frank Tiernan , linux-ide@vger.kernel.org Subject: [PATCH 20/20] ata: pata_pdc2027x: Fix some incorrect function names and parameter docs Date: Mon, 1 Feb 2021 14:39:40 +0000 Message-Id: <20210201143940.2070919-21-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210201143940.2070919-1-lee.jones@linaro.org> References: <20210201143940.2070919-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/ata/pata_pdc2027x.c:209: warning: expecting prototype for pdc2027x_pata_cable_detect(). Prototype was for pdc2027x_cable_detect() instead drivers/ata/pata_pdc2027x.c:262: warning: expecting prototype for pdc2720x_mode_filter(). Prototype was for pdc2027x_mode_filter() instead drivers/ata/pata_pdc2027x.c:513: warning: Function parameter or member 'board_idx' not described in 'pdc_adjust_pll' drivers/ata/pata_pdc2027x.c:513: warning: expecting prototype for adjust_pll(). Prototype was for pdc_adjust_pll() instead drivers/ata/pata_pdc2027x.c:599: warning: expecting prototype for detect_pll_input_clock(). Prototype was for pdc_detect_pll_input_clock() instead Cc: Jens Axboe Cc: Albert Lee Cc: Andre Hedrick Cc: Frank Tiernan Cc: linux-ide@vger.kernel.org Signed-off-by: Lee Jones --- drivers/ata/pata_pdc2027x.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/ata/pata_pdc2027x.c b/drivers/ata/pata_pdc2027x.c index de834fbb6dfe6..effc1a09444de 100644 --- a/drivers/ata/pata_pdc2027x.c +++ b/drivers/ata/pata_pdc2027x.c @@ -196,7 +196,7 @@ static inline void __iomem *dev_mmio(struct ata_port *ap, struct ata_device *ade } /** - * pdc2027x_pata_cable_detect - Probe host controller cable detect info + * pdc2027x_cable_detect - Probe host controller cable detect info * @ap: Port for which cable detect info is desired * * Read 80c cable indicator from Promise extended register. @@ -251,7 +251,7 @@ static int pdc2027x_prereset(struct ata_link *link, unsigned long deadline) } /** - * pdc2720x_mode_filter - mode selection filter + * pdc2027x_mode_filter - mode selection filter * @adev: ATA device * @mask: list of modes proposed * @@ -503,11 +503,11 @@ static long pdc_read_counter(struct ata_host *host) } /** - * adjust_pll - Adjust the PLL input clock in Hz. + * pdc_adjust_pll - Adjust the PLL input clock in Hz. * - * @pdc_controller: controller specific information * @host: target ATA host * @pll_clock: The input of PLL in HZ + * @board_idx: board identifier */ static void pdc_adjust_pll(struct ata_host *host, long pll_clock, unsigned int board_idx) { @@ -590,7 +590,7 @@ static void pdc_adjust_pll(struct ata_host *host, long pll_clock, unsigned int b } /** - * detect_pll_input_clock - Detect the PLL input clock in Hz. + * pdc_detect_pll_input_clock - Detect the PLL input clock in Hz. * @host: target ATA host * Ex. 16949000 on 33MHz PCI bus for pdc20275. * Half of the PCI clock.