From patchwork Thu Jan 28 18:02:20 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1432951 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=linux-ide-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=BEIFtbiL; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4DRT0q5ls8z9sWL for ; Fri, 29 Jan 2021 05:05:47 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231582AbhA1SF1 (ORCPT ); Thu, 28 Jan 2021 13:05:27 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60818 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231158AbhA1SDe (ORCPT ); Thu, 28 Jan 2021 13:03:34 -0500 Received: from mail-wm1-x330.google.com (mail-wm1-x330.google.com [IPv6:2a00:1450:4864:20::330]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C625FC0613ED for ; Thu, 28 Jan 2021 10:02:44 -0800 (PST) Received: by mail-wm1-x330.google.com with SMTP id z16so2726614wml.2 for ; Thu, 28 Jan 2021 10:02:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Q8dNJasVRLn/usmEjlw+r/WiHjA7itNZyTC4iBox9OE=; b=BEIFtbiLYui7i5/dK8Bzf4Sp/HnMwiI8qwC5Eq9mDJR/PlW8Oy5ZcdR6cFBRg0RWvu m1xMJBXcVw/0tMl152QNrNboilxrvP6WwFx/F0VP/X7Poxu411PsronDlfbmmxF9qOGc 6UgK3Q+hxvizl/QnZaeG//DtubPyDt2lcGEtZv+c9dyULOWOcgKByNKv0RW1IGLAOpk0 LsqGLPD9jZ6pJff9mag9GVsnq+RGxzLWJRvc+BoLGIjNPdwYkUEEXJKGI7fMxmej5xGi 44+QIR72AT/K4VT/Znpc4+B8nUdgqbQQixMLcygHrVdmdRPo0ROAjQv2VxJs+l9huj2r cYBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Q8dNJasVRLn/usmEjlw+r/WiHjA7itNZyTC4iBox9OE=; b=gZQf6fsjCu8+1SOSmiO/j+l1TngNDp9+GKzJoHWsj3lrbT1mpSa+RcuRE8xoo7lVxI ehlpPeZygoELycqZKIEE8DwZHerEUhDSJKxGiyrKygjvbwvn70LK8I+SrSWyCflOevm+ zk+MVgIyvtFBB2NDDgWcDlCNhRorxUy6QhwSMzYGcHSglNqECScTI81m/CPKjQNrl+UD C3+fhtnnXTVdZTj1lvbdcC4nsqnZ/Y27rEs82EFfsDemWM7uO3C0lPAMmkPzMaO8diKA fwR2rmvmuyjQ5FPuluJKA4O1uBgwHx/6hS9JRLCrNKB0pTTFl8tnNmNLpJ30rHpJL+cC KVxg== X-Gm-Message-State: AOAM53378UVMNgc9VGxlHdn39ebbqAOQKrvU5PTSKYQmWhYb0lSqdNAx xL1FXJNPHu7upIzc8Xss4jTf3g== X-Google-Smtp-Source: ABdhPJyUftLDpHNUfD3jbKYPjUbXco7613rE8AOb0mliJLVNCNsrJ8XZcvKWXWqnwRH+I1hsLPUN0A== X-Received: by 2002:a05:600c:21c1:: with SMTP id x1mr477664wmj.48.1611856963384; Thu, 28 Jan 2021 10:02:43 -0800 (PST) Received: from dell.default ([91.110.221.188]) by smtp.gmail.com with ESMTPSA id u6sm8280794wro.75.2021.01.28.10.02.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Jan 2021 10:02:42 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Jens Axboe , linux-ide@vger.kernel.org Subject: [PATCH 01/20] ata: ahci_dm816: Ignore -Woverride-init Date: Thu, 28 Jan 2021 18:02:20 +0000 Message-Id: <20210128180239.548512-2-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210128180239.548512-1-lee.jones@linaro.org> References: <20210128180239.548512-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org Some ATA drivers use the SCSI host template, a series of interwoven macros, to aid with initialisation. Some of these macros conflict, resulting in the over-writing of previously set values. This is known behaviour and can be safely ignored. Fixes the following W=1 kernel build warning(s): In file included from drivers/ata/ahci_dm816.c:16: drivers/ata/ahci.h:387:16: warning: initialized field overwritten [-Woverride-init] drivers/ata/ahci_dm816.c:138:2: note: in expansion of macro ‘AHCI_SHT’ drivers/ata/ahci.h:387:16: note: (near initialization for ‘ahci_dm816_platform_sht.can_queue’) drivers/ata/ahci_dm816.c:138:2: note: in expansion of macro ‘AHCI_SHT’ drivers/ata/ahci.h:391:17: warning: initialized field overwritten [-Woverride-init] drivers/ata/ahci_dm816.c:138:2: note: in expansion of macro ‘AHCI_SHT’ drivers/ata/ahci.h:391:17: note: (near initialization for ‘ahci_dm816_platform_sht.sdev_attrs’) drivers/ata/ahci_dm816.c:138:2: note: in expansion of macro ‘AHCI_SHT’ Cc: Jens Axboe Cc: linux-ide@vger.kernel.org Signed-off-by: Lee Jones --- drivers/ata/Makefile | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/ata/Makefile b/drivers/ata/Makefile index b8aebfb14e825..d24bf4d2b08d6 100644 --- a/drivers/ata/Makefile +++ b/drivers/ata/Makefile @@ -1,5 +1,7 @@ # SPDX-License-Identifier: GPL-2.0 +CFLAGS_ahci_dm816.o = $(call cc-disable-warning, override-init) + obj-$(CONFIG_ATA) += libata.o # non-SFF interface From patchwork Thu Jan 28 18:02:21 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1432950 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=linux-ide-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=l6j6sHis; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4DRT083PnHz9sWQ for ; Fri, 29 Jan 2021 05:05:12 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231502AbhA1SE7 (ORCPT ); Thu, 28 Jan 2021 13:04:59 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60848 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229561AbhA1SDe (ORCPT ); Thu, 28 Jan 2021 13:03:34 -0500 Received: from mail-wr1-x42c.google.com (mail-wr1-x42c.google.com [IPv6:2a00:1450:4864:20::42c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 28DEFC061797 for ; Thu, 28 Jan 2021 10:02:46 -0800 (PST) Received: by mail-wr1-x42c.google.com with SMTP id m13so6324821wro.12 for ; Thu, 28 Jan 2021 10:02:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=cK/LGNOy9DsyBBjFZYPOvNZ8xWqyFdDwYmos4fe8lCA=; b=l6j6sHisEv3Syi3TRnQNqc6U3bhlxtCL6A+8C76hJHNJyVyr2m5puQfClCPg6ZQlYy qIKIMq29we6Ef0IFTdty05v59otQXhQpGmu00fGYgNcVq8S1dohwX+DfUYzv5f8rjxyc Op/DMGdmrp5jxBiUJqDn5BhvW+8aIV81BH/L1ULv14ruptw2hVA9jmGmdjd0Fl8q2L18 Qkc+9TkH/UESqbJzNw7c9r4QbOiXRd3S6vNHnrjcg372P1gE103rhsJB73kSxPCbsZdd Jeq0lMdmK3c9QVQcgjKjcXUWIOH32xuIn5bbrE0PTyUQWjLMeQw0uTIZDvCyNBxOC1Y7 9DSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=cK/LGNOy9DsyBBjFZYPOvNZ8xWqyFdDwYmos4fe8lCA=; b=VfRa8UlVMqq+53ZXqHNBK9H+mo/8X+qAp0GWNC+c/CkwfPt4VrA7W8fEFdOKOAO9id MvEfQ4zIsgLvDWHqhYfTTlGKYJin+ZAmYS3GZ127YWJHVudehAAbLEhMoiJo+ZPQi/F7 Q/BVW5Ey6YMta72xl2GeI2k4TFRcFoZbq9KyaiQOXiHQ9k8BeLRVh8pQwh0pGVmYgdo9 PXhSm7R/96hBV6TsPTpwSkXv9eixG7tgtCkqTg2F0wTbAo//aHqI2+medJXWYHbDV/OY J4ewWzOSuHDR4AKWv7nrSGfUURHFZxC84vc1DaWDUfSfd+nb6ngIlBIGD5SxPohaoXQd ZAYQ== X-Gm-Message-State: AOAM533ka402qAxiBh4Lyw1Ko8imcZfSgsB9Lpk8FJSbCJVBNLnin5LY vWlnMaiZZlSCoVFbc+jNgBLTdQ== X-Google-Smtp-Source: ABdhPJzEkZVqERpDZYMPU4xNVbLl99aNDBErtpPPLk/+9aUXBl1cYJw/1Z0WP+KPvVGOpdjOKb/3hw== X-Received: by 2002:adf:f512:: with SMTP id q18mr291783wro.55.1611856964946; Thu, 28 Jan 2021 10:02:44 -0800 (PST) Received: from dell.default ([91.110.221.188]) by smtp.gmail.com with ESMTPSA id u6sm8280794wro.75.2021.01.28.10.02.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Jan 2021 10:02:44 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Jens Axboe , linux-ide@vger.kernel.org Subject: [PATCH 02/20] ata: libata-transport: Fix some potential doc-rot issues Date: Thu, 28 Jan 2021 18:02:21 +0000 Message-Id: <20210128180239.548512-3-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210128180239.548512-1-lee.jones@linaro.org> References: <20210128180239.548512-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/ata/libata-transport.c:258: warning: Function parameter or member 'ap' not described in 'ata_tport_delete' drivers/ata/libata-transport.c:258: warning: Excess function parameter 'port' description in 'ata_tport_delete' drivers/ata/libata-transport.c:384: warning: Function parameter or member 'link' not described in 'ata_tlink_delete' drivers/ata/libata-transport.c:384: warning: Excess function parameter 'port' description in 'ata_tlink_delete' drivers/ata/libata-transport.c:640: warning: Function parameter or member 'ata_dev' not described in 'ata_tdev_delete' drivers/ata/libata-transport.c:640: warning: Excess function parameter 'port' description in 'ata_tdev_delete' Cc: Jens Axboe Cc: linux-ide@vger.kernel.org Signed-off-by: Lee Jones --- drivers/ata/libata-transport.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/ata/libata-transport.c b/drivers/ata/libata-transport.c index 6a40e3c6cf492..34bb4608bdc67 100644 --- a/drivers/ata/libata-transport.c +++ b/drivers/ata/libata-transport.c @@ -250,7 +250,7 @@ static int ata_tport_match(struct attribute_container *cont, /** * ata_tport_delete -- remove ATA PORT - * @port: ATA PORT to remove + * @ap: ATA PORT to remove * * Removes the specified ATA PORT. Remove the associated link as well. */ @@ -376,7 +376,7 @@ static int ata_tlink_match(struct attribute_container *cont, /** * ata_tlink_delete -- remove ATA LINK - * @port: ATA LINK to remove + * @link: ATA LINK to remove * * Removes the specified ATA LINK. remove associated ATA device(s) as well. */ @@ -632,7 +632,7 @@ static void ata_tdev_free(struct ata_device *dev) /** * ata_tdev_delete -- remove ATA device - * @port: ATA PORT to remove + * @ata_dev: ATA device to remove * * Removes the specified ATA device. */ From patchwork Thu Jan 28 18:02:22 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1432949 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=linux-ide-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=HNGSfsRP; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4DRT0658YFz9sWK for ; Fri, 29 Jan 2021 05:05:10 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231481AbhA1SEt (ORCPT ); Thu, 28 Jan 2021 13:04:49 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60620 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231262AbhA1SDM (ORCPT ); Thu, 28 Jan 2021 13:03:12 -0500 Received: from mail-wm1-x330.google.com (mail-wm1-x330.google.com [IPv6:2a00:1450:4864:20::330]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BD43CC0617A7 for ; Thu, 28 Jan 2021 10:02:47 -0800 (PST) Received: by mail-wm1-x330.google.com with SMTP id u14so5031610wml.4 for ; Thu, 28 Jan 2021 10:02:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=azFmqObNrsq2Y9KjmcVwLZnWbMejrbRgZoxiCEhbXjM=; b=HNGSfsRPfXOsvjYZ7/0xtd7uCashfdor2Eo/qkjTDPQH12ec/MO+9jNMbB/dyUMQJF 7g7ReSrcfoqkCpBh36rKtsCpmczMvqyXaqetvt0+xbGorohmXiyHF4TV6gSc/b823c4F Vj0PNNYViEBVsnqcbx1shl+9VrWnH6e0WqnUQIwB1IAe9c0ExAWS1DFrBTcxuUQA2YBx BEBQH0xDA2qAMIH9+d18aK01tAQU8lO0h3mmIOeJgtduRGovJYc824139kQtmg8YqrlQ lSYBB4/O0IG4u4n7m3Z0LgwauIq46AiQHti0NdSxXJXdIR/QdhDfdcDyU3XzbKRnKp9B qXag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=azFmqObNrsq2Y9KjmcVwLZnWbMejrbRgZoxiCEhbXjM=; b=uKqRZH3VUo60NYkAKdJCjaGjGwQ0ZzAs9vG2zasOsIWWYMAMLSC3njOWmnpfc1wqYT Zudpp90n5wCfWxDjo0Y1kurCEVk3opWF/DauVKOL2L3FvfFuJoWhvY9P8J7B3v0KATFT eSQob9qJSQPDBzajQ8GpWLRk5m6Cwxw5BJ2ghLfc9YsEJ5+Rxys7YnKHXGy6B7TkgFq4 1ZL0AhHb31JNzyIaSh6GheF6sIlCiTo676iKdl8KxvfER6e4LY2xBLaAPRyBEFDM/INY vz/Jrn2TPGmauMO9BWQZlJn2pvf9GGNJpKVrQECn7LidfSv4C/8GfBNWrmDkgBx6/hQt FQvQ== X-Gm-Message-State: AOAM533lvSYfEXkD1D3F9Iii+chFWhSrIQRNjzd+2m1Bun+6LLzqAqOs xyPnULB5TH+4VmdKIGvwaoCc6g== X-Google-Smtp-Source: ABdhPJw9yt3wZkSFszLXr+EE6OLfe4qNPCK4cG+E8VjybhnGF87k5wzXMes6R+iUcVwPwSLVR6gq2Q== X-Received: by 2002:a1c:ab57:: with SMTP id u84mr422142wme.115.1611856966567; Thu, 28 Jan 2021 10:02:46 -0800 (PST) Received: from dell.default ([91.110.221.188]) by smtp.gmail.com with ESMTPSA id u6sm8280794wro.75.2021.01.28.10.02.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Jan 2021 10:02:45 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Jens Axboe , linux-ide@vger.kernel.org Subject: [PATCH 03/20] ata: ahci_platform: Ignore -Woverride-init Date: Thu, 28 Jan 2021 18:02:22 +0000 Message-Id: <20210128180239.548512-4-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210128180239.548512-1-lee.jones@linaro.org> References: <20210128180239.548512-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org Some ATA drivers use the SCSI host template, a series of interwoven macros, to aid with initialisation. Some of these macros conflict, resulting in the over-writing of previously set values. This is known behaviour and can be safely ignored. Fixes the following W=1 kernel build warning(s): In file included from drivers/ata/ahci_platform.c:21: drivers/ata/ahci.h:387:16: warning: initialized field overwritten [-Woverride-init] drivers/ata/ahci_platform.c:40:2: note: in expansion of macro ‘AHCI_SHT’ drivers/ata/ahci.h:387:16: note: (near initialization for ‘ahci_platform_sht.can_queue’) drivers/ata/ahci_platform.c:40:2: note: in expansion of macro ‘AHCI_SHT’ drivers/ata/ahci.h:391:17: warning: initialized field overwritten [-Woverride-init] drivers/ata/ahci_platform.c:40:2: note: in expansion of macro ‘AHCI_SHT’ drivers/ata/ahci.h:391:17: note: (near initialization for ‘ahci_platform_sht.sdev_attrs’) drivers/ata/ahci_platform.c:40:2: note: in expansion of macro ‘AHCI_SHT’ Cc: Jens Axboe Cc: linux-ide@vger.kernel.org Signed-off-by: Lee Jones --- drivers/ata/Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/ata/Makefile b/drivers/ata/Makefile index d24bf4d2b08d6..c7c26a0ef7632 100644 --- a/drivers/ata/Makefile +++ b/drivers/ata/Makefile @@ -1,6 +1,7 @@ # SPDX-License-Identifier: GPL-2.0 CFLAGS_ahci_dm816.o = $(call cc-disable-warning, override-init) +CFLAGS_ahci_platform.o = $(call cc-disable-warning, override-init) obj-$(CONFIG_ATA) += libata.o From patchwork Thu Jan 28 18:02:23 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1432965 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=linux-ide-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=b5xBeNFk; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4DRTFm62fgz9sW0 for ; Fri, 29 Jan 2021 05:17:00 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231444AbhA1SQn (ORCPT ); Thu, 28 Jan 2021 13:16:43 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60888 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229747AbhA1SDo (ORCPT ); Thu, 28 Jan 2021 13:03:44 -0500 Received: from mail-wm1-x32d.google.com (mail-wm1-x32d.google.com [IPv6:2a00:1450:4864:20::32d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8CAEDC0617AB for ; Thu, 28 Jan 2021 10:02:49 -0800 (PST) Received: by mail-wm1-x32d.google.com with SMTP id m1so2021080wml.2 for ; Thu, 28 Jan 2021 10:02:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=gat9ASy8Tcpn7xEHDYjYiqg8W2NDPEgsm5bh/q38djM=; b=b5xBeNFkkABV7SRryiujgGned41DWkKsqVPxa7b6HABsi9v4EUrkgIVNmNINQsl+t8 3K1wC/j55Mcw3dh9HxtKtr9wr1Edho9KPRcRaBMuzsIWNMRHvnG9VC7UQ/EZo5EDaDHZ dzulJbBlu406tRkTlB+XK4O2lltBNCzfT5xxhYqDq45Ha80kBl/gT+k4FrKUFOyjqjE+ vQJaGZqh1H9HuEB9Pt4yzLirEcsoed8yM9OPZmCI4FvezHyZewWmK5V/u8rL+osYuyZU /cZ2ZNh5YbHjjwuCse9zdVYkXE5zJBR7EVP/pvsMG3EsaNyri+Eu3IzsNwbJtgFbDjre KmaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=gat9ASy8Tcpn7xEHDYjYiqg8W2NDPEgsm5bh/q38djM=; b=HiP3hOTEBy82JuGqkITtjwWD4JG3Mv39GCYnANO8k1X+86h5hto3HpXxlId0U43xJc TEgbB6GDeOupY+37z4PRCD6hN/fvj7OL3kpjL15B+NTBbLs4IXH/IFuruo/AzvWe3JnK dH3acvrfJpy4Nu0QYu4ANDx9bswUSBIcpI3f+tNYQjS2go62jYAL1ingARA0OuVU08FG AcjUGuH463wzmo5NZHID62fm8VLHHPMVnZacgAYT5X705K/UQH4veit2isWiViHhNPPy ow+EIKVIwGeTIngpQXFWAYnhtFk7jof8ve7kjpdCXQKBdZzo5fP6VJpr/8noYF/mOFO8 WJJA== X-Gm-Message-State: AOAM531XVkJDVWO4xofep94zSix+EgnBMdRfJ6lp6o1vCcMPm7dbIVDG W8Wm4P/CLkOPqxepjN8lxobraw== X-Google-Smtp-Source: ABdhPJwX8a9ezXdt3Bhrl3TVpigZPvvrLgEpT+OvBZe6ZFqkp3d9fNtfAqGIZNRobORWb2k6E6sy/w== X-Received: by 2002:a1c:a549:: with SMTP id o70mr411325wme.71.1611856968288; Thu, 28 Jan 2021 10:02:48 -0800 (PST) Received: from dell.default ([91.110.221.188]) by smtp.gmail.com with ESMTPSA id u6sm8280794wro.75.2021.01.28.10.02.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Jan 2021 10:02:47 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Jens Axboe , Tejun Heo , linux-ide@vger.kernel.org Subject: [PATCH 04/20] ata: libata-sata: Fix function names in header comments Date: Thu, 28 Jan 2021 18:02:23 +0000 Message-Id: <20210128180239.548512-5-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210128180239.548512-1-lee.jones@linaro.org> References: <20210128180239.548512-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/ata/libata-sata.c:1085: warning: expecting prototype for port_alloc(). Prototype was for ata_sas_port_alloc() instead drivers/ata/libata-sata.c:1140: warning: expecting prototype for ata_port_stop(). Prototype was for ata_sas_port_stop() instead Cc: Jens Axboe Cc: Tejun Heo Cc: linux-ide@vger.kernel.org Signed-off-by: Lee Jones --- drivers/ata/libata-sata.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/ata/libata-sata.c b/drivers/ata/libata-sata.c index c16423e445255..8adeab76dd382 100644 --- a/drivers/ata/libata-sata.c +++ b/drivers/ata/libata-sata.c @@ -1067,7 +1067,7 @@ int ata_scsi_change_queue_depth(struct scsi_device *sdev, int queue_depth) EXPORT_SYMBOL_GPL(ata_scsi_change_queue_depth); /** - * port_alloc - Allocate port for a SAS attached SATA device + * ata_sas_port_alloc - Allocate port for a SAS attached SATA device * @host: ATA host container for all SAS ports * @port_info: Information from low-level host driver * @shost: SCSI host that the scsi device is attached to @@ -1127,7 +1127,7 @@ int ata_sas_port_start(struct ata_port *ap) EXPORT_SYMBOL_GPL(ata_sas_port_start); /** - * ata_port_stop - Undo ata_sas_port_start() + * ata_sas_port_stop - Undo ata_sas_port_start() * @ap: Port to shut down * * May be used as the port_stop() entry in ata_port_operations. From patchwork Thu Jan 28 18:02:24 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1432953 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=linux-ide-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=QMd8ysJW; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4DRT3H1lp1z9sWK for ; Fri, 29 Jan 2021 05:07:55 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231515AbhA1SH0 (ORCPT ); Thu, 28 Jan 2021 13:07:26 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32782 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231450AbhA1SES (ORCPT ); Thu, 28 Jan 2021 13:04:18 -0500 Received: from mail-wm1-x332.google.com (mail-wm1-x332.google.com [IPv6:2a00:1450:4864:20::332]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E3AE2C061352 for ; Thu, 28 Jan 2021 10:02:50 -0800 (PST) Received: by mail-wm1-x332.google.com with SMTP id c127so5289514wmf.5 for ; Thu, 28 Jan 2021 10:02:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=bM4mPrdGCmHIaP6sSEhqZR0ycPeA2MFnqRQ1Q2Z5NPg=; b=QMd8ysJWDHZdQ5sbfXQG3sQzlvqAiSI5lr91/8U20X+H+I3kdNCkCJXHnQkgTYJu4l 2w2rQvHn6a4fdnfbV8+Sq1xUAQLlDGIKpCtw5Kj4LGJtUsqufzAhSG3iHsJfGDGD0ENO FUYJ9UDZJOfwZ9CLljbkHF40uLscAogqmxILS11Y25FuP+g1mVCAq9n7zCg18V0HAOJZ 8/qc91mGfJC0uKQPpJAehuePNEq0Hd3iLBecOKhJesV4mjzuP+FxT+Hi1EDQTqPXrpjp AR5qcxG8aIFT754quwEfLCi5oQn9mi2/HTVRDpoZiKkhbKZnELie6kUCvERc3c0kx75q YT7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=bM4mPrdGCmHIaP6sSEhqZR0ycPeA2MFnqRQ1Q2Z5NPg=; b=XR2nfdcGRe5xKXkcb/fkoUp0nH0/EHBPq1LlCVJ41vM4dalOrPmyOOqP2jOWLANbc8 whAwmknk17AoMM8UM7PZYoqqDUjVcvhOekOrd0alBGngCTYNsuLBLtAFYpIVr6PVzm5w 3xCL26hWMXlSlLy01uRsXDY1K6oAEszX5iYKrLF+jE9rS+dIfuUong/oHxoaOVguR4Mx FRy7DlpPojLrHAl8o7cQOO4n0/Gldxlx41rrINwEXPAxbF0QHfqUmfgfPt3dh7e959ac 4w0R8A6SsEBhCzmp54pHgo2o+aImN0p4XyZTlsZx1suz0yEk1gxQCrZ4qLYUORhg3yeS iQgg== X-Gm-Message-State: AOAM530fq2zULHHsReIkxFlzAqA2VJ/z71NogsvNcNf/kSwFdyqwj0X7 WgdrnN70q50s2L4qnuUH6oFYATqjIgPyPJrf X-Google-Smtp-Source: ABdhPJzt+efXXKYitxJSG0qkBeBvxKXFSW53cPvWKdkouaGicDhbubEjfCFFyjhotrF0vhCXh1dV/A== X-Received: by 2002:a1c:3c04:: with SMTP id j4mr401685wma.177.1611856969662; Thu, 28 Jan 2021 10:02:49 -0800 (PST) Received: from dell.default ([91.110.221.188]) by smtp.gmail.com with ESMTPSA id u6sm8280794wro.75.2021.01.28.10.02.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Jan 2021 10:02:49 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Jens Axboe , Tejun Heo , linux-ide@vger.kernel.org Subject: [PATCH 05/20] ata: libata-pmp: Fix misspelling of 'val' Date: Thu, 28 Jan 2021 18:02:24 +0000 Message-Id: <20210128180239.548512-6-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210128180239.548512-1-lee.jones@linaro.org> References: <20210128180239.548512-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/ata/libata-pmp.c:76: warning: Function parameter or member 'val' not described in 'sata_pmp_write' drivers/ata/libata-pmp.c:76: warning: Excess function parameter 'r_val' description in 'sata_pmp_write' Cc: Jens Axboe Cc: Tejun Heo Cc: linux-ide@vger.kernel.org Signed-off-by: Lee Jones --- drivers/ata/libata-pmp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/ata/libata-pmp.c b/drivers/ata/libata-pmp.c index 79f2aeeb482ab..ba7be3f386171 100644 --- a/drivers/ata/libata-pmp.c +++ b/drivers/ata/libata-pmp.c @@ -62,7 +62,7 @@ static unsigned int sata_pmp_read(struct ata_link *link, int reg, u32 *r_val) * sata_pmp_write - write PMP register * @link: link to write PMP register for * @reg: register to write - * @r_val: value to write + * @val: value to write * * Write PMP register. * From patchwork Thu Jan 28 18:02:25 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1432954 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=linux-ide-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=PCshDChF; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4DRT3H4x2sz9sW0 for ; Fri, 29 Jan 2021 05:07:55 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231745AbhA1SHd (ORCPT ); Thu, 28 Jan 2021 13:07:33 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32834 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231469AbhA1SEd (ORCPT ); Thu, 28 Jan 2021 13:04:33 -0500 Received: from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com [IPv6:2a00:1450:4864:20::42a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EFAFDC061354 for ; Thu, 28 Jan 2021 10:02:51 -0800 (PST) Received: by mail-wr1-x42a.google.com with SMTP id v15so6355159wrx.4 for ; Thu, 28 Jan 2021 10:02:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=oz1ysPXY6dIT/8FVs8doLP4WQeUP6R82FsIHTFVdMfY=; b=PCshDChF2psB5lznsc62jLqInBWsbrTH3AsmsS8j2tnSnEfifferJeJSlH4zGWQzsU iC4RcRAUfGIvKi/vPDfg9w/x7etN9PzJkIi5f8VvJb7BPg47PRIDFpdylo4VvZ7Efd95 HfabLRFDScWwg8o7flnyeAymFkEGMwFNrtvna1xFnI3y2Vzwa+RXPJuyjZlbOV6JWJmJ S3Au8Yxi1BJYHRunWw8lVec29AtpSKx/7UNsnmRMjW0D4RjcVyEfpKJVcb+2QZESr1rF pSKAx2L2ObvxqaSlLGnZNsNXo1Mjp93Wq9aROO75mDXn3HH4Djc7Z9lbIQOiToyuGk/K ICww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=oz1ysPXY6dIT/8FVs8doLP4WQeUP6R82FsIHTFVdMfY=; b=aP7XhW0hjZV05Lc7YFpA4Pyp9hXV/A1F3C+qMDx8Gk2sE6om/zTJvNv7y87f8Onuf4 uhTjF6ZFSz+gbkAiz9jXo2cil+tThlNBtQyBHS20JYnbPs5b7w8L1Jiv4AHLx4mlEIRy UIRXprJAX39pakiyKztERorhHOjYC6dCvagsIlAcqQ1jv78N+7Z4VB8wUAxPgrh7Hxwc 7kpJLY4NI9gaOkiOYk0XhHVwPKlREh0NdvwyC0iDL1ppZ+t5apSfUw3TBaBp9xkXDYFP 5ZafN6gV1v87P0Yc/OFEMD606wHKAFAcgSoUYnPpE5NZYJW17ccNJa0sXTlIW9CKaTZi pmVA== X-Gm-Message-State: AOAM531JCneGMG7jupCKWcbrJQp3uKoRbT8z+wJMmThP5OKb52OPMhiV GwTeeu2tYrAfEq4lKWDkEgWrmQ== X-Google-Smtp-Source: ABdhPJwjPI5OWXbhQTA/ivFPtXo+b03sqvS4hAl+8fbvpeLCkCYcA4RrTpzKqjyfPmdSuPmatlQZ2g== X-Received: by 2002:adf:e807:: with SMTP id o7mr331333wrm.308.1611856970720; Thu, 28 Jan 2021 10:02:50 -0800 (PST) Received: from dell.default ([91.110.221.188]) by smtp.gmail.com with ESMTPSA id u6sm8280794wro.75.2021.01.28.10.02.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Jan 2021 10:02:50 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Jens Axboe , linux-ide@vger.kernel.org Subject: [PATCH 06/20] ata: ahci_mtk: Ignore -Woverride-init Date: Thu, 28 Jan 2021 18:02:25 +0000 Message-Id: <20210128180239.548512-7-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210128180239.548512-1-lee.jones@linaro.org> References: <20210128180239.548512-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org Some ATA drivers use the SCSI host template, a series of interwoven macros, to aid with initialisation. Some of these macros conflict, resulting in the over-writing of previously set values. This is known behaviour and can be safely ignored. Fixes the following W=1 kernel build warning(s): In file included from drivers/ata/ahci_mtk.c:18: drivers/ata/ahci.h:387:16: warning: initialized field overwritten [-Woverride-init] drivers/ata/ahci_mtk.c:41:2: note: in expansion of macro ‘AHCI_SHT’ drivers/ata/ahci.h:387:16: note: (near initialization for ‘ahci_platform_sht.can_queue’) drivers/ata/ahci_mtk.c:41:2: note: in expansion of macro ‘AHCI_SHT’ drivers/ata/ahci.h:391:17: warning: initialized field overwritten [-Woverride-init] drivers/ata/ahci_mtk.c:41:2: note: in expansion of macro ‘AHCI_SHT’ drivers/ata/ahci.h:391:17: note: (near initialization for ‘ahci_platform_sht.sdev_attrs’) drivers/ata/ahci_mtk.c:41:2: note: in expansion of macro ‘AHCI_SHT’ Cc: Jens Axboe Cc: linux-ide@vger.kernel.org Signed-off-by: Lee Jones --- drivers/ata/Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/ata/Makefile b/drivers/ata/Makefile index c7c26a0ef7632..79c59550c23a0 100644 --- a/drivers/ata/Makefile +++ b/drivers/ata/Makefile @@ -1,6 +1,7 @@ # SPDX-License-Identifier: GPL-2.0 CFLAGS_ahci_dm816.o = $(call cc-disable-warning, override-init) +CFLAGS_ahci_mtk.o = $(call cc-disable-warning, override-init) CFLAGS_ahci_platform.o = $(call cc-disable-warning, override-init) obj-$(CONFIG_ATA) += libata.o From patchwork Thu Jan 28 18:02:26 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1432952 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=linux-ide-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=e15ABOPK; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4DRT3G3KxHz9sW0 for ; Fri, 29 Jan 2021 05:07:54 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231152AbhA1SHT (ORCPT ); Thu, 28 Jan 2021 13:07:19 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60626 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231407AbhA1SEQ (ORCPT ); Thu, 28 Jan 2021 13:04:16 -0500 Received: from mail-wr1-x42c.google.com (mail-wr1-x42c.google.com [IPv6:2a00:1450:4864:20::42c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 57660C061788 for ; Thu, 28 Jan 2021 10:02:53 -0800 (PST) Received: by mail-wr1-x42c.google.com with SMTP id 7so6361827wrz.0 for ; Thu, 28 Jan 2021 10:02:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=lDwxjOTNwRK/jrgXFyt6Q5KAd5bTTyW5pp6F8HQ+RfM=; b=e15ABOPKKSkb+A+yzXSg3oWGdKhKBFvuayIyU7x7O9IWe6tZK6N/gu6rO7l0S2hugw rwwIHwJ+rxrWgPhnhQeolBYxEnt17NAVO9s7PgeV09/HenT2OnZv3lhmasdL5EmvEnOG 8AWeWwvoe9hDkviDX8GnXzVvDJg+ZlNKIJTgh6vQxOuNFbBz1uQbpO40tXYywJ32IE7I 6pulN78q2w+jAykFNHWVSpBNxSEHSww+8xk/8mcP/m2s7LdowUovoFxZNN4cypJPoXZ3 VBTT2omEbJYEthiAKgD9wgjuc8JBgzOXBBAPT2DAv2m3AzPztYwwoevO3ccAmrjpqQeF iZIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=lDwxjOTNwRK/jrgXFyt6Q5KAd5bTTyW5pp6F8HQ+RfM=; b=rBhy1hDepJc+fpYXqCbanBB1pbJoQxlKjnA+OGL5CE+nZ3mwwCwEEs2XYSdj58ju0l ZwMyGygz/uZuNyFdeKl4Q3ehgg3X6NKtbYYxTH1hbNi7Hz719hthZ4wL+t6rETzA2Uje hyntovPhXixHOoDwY3tnIMv391G0zfw7SkwQ+kjDkk3JQnTjZP4Oyajv8aE1n85nZ0BO ESA6KxfDOFTJsmFePWkpOfrqh5WYPmL6bRJ/YNriFODD+zwvepRgR4WRfya/lDp5ZQtg xko8FVc72a61zCgS4DlBaCWDRAprQ/gPOIAcKpFEZGVe/1pFThswkfb9AkPEVEJgKlQl 2WGA== X-Gm-Message-State: AOAM532rw/8y5RDf+6fPUFLINqLCRfYNPUeRb7SDzulBsAbeHJlLnIOa mKNuKbq4O/L3N80vMjKZSTpNww== X-Google-Smtp-Source: ABdhPJzWIx/SFzMc8lRIlMQ0pH/4OykRg1Xgf+E2QnrCoAgIO+1y6+Izb7pmAkfbT9U/ZC2paA+aww== X-Received: by 2002:adf:9523:: with SMTP id 32mr244948wrs.361.1611856972100; Thu, 28 Jan 2021 10:02:52 -0800 (PST) Received: from dell.default ([91.110.221.188]) by smtp.gmail.com with ESMTPSA id u6sm8280794wro.75.2021.01.28.10.02.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Jan 2021 10:02:51 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Jens Axboe , CJ , Andre Hedrick , Alan Cox , Clear Zhang , linux-ide@vger.kernel.org, and cc Subject: [PATCH 07/20] ata: pata_ali: Repair some misnamed kernel-doc issues Date: Thu, 28 Jan 2021 18:02:26 +0000 Message-Id: <20210128180239.548512-8-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210128180239.548512-1-lee.jones@linaro.org> References: <20210128180239.548512-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/ata/pata_ali.c:119: warning: Function parameter or member 'mask' not described in 'ali_20_filter' drivers/ata/pata_ali.c:119: warning: Excess function parameter 'ap' description in 'ali_20_filter' drivers/ata/pata_ali.c:322: warning: Function parameter or member 'qc' not described in 'ali_check_atapi_dma' drivers/ata/pata_ali.c:322: warning: Excess function parameter 'adev' description in 'ali_check_atapi_dma' Cc: Jens Axboe Cc: CJ Cc: Andre Hedrick Cc: Alan Cox Cc: Clear Zhang Cc: linux-ide@vger.kernel.org Cc: and cc Signed-off-by: Lee Jones --- drivers/ata/pata_ali.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/ata/pata_ali.c b/drivers/ata/pata_ali.c index 0b122f903b8a8..e18aa02f89530 100644 --- a/drivers/ata/pata_ali.c +++ b/drivers/ata/pata_ali.c @@ -108,7 +108,7 @@ static int ali_c2_cable_detect(struct ata_port *ap) /** * ali_20_filter - filter for earlier ALI DMA - * @ap: ALi ATA port + * @adev: ATA device * @adev: attached device * * Ensure that we do not do DMA on CD devices. We may be able to @@ -313,7 +313,7 @@ static void ali_lock_sectors(struct ata_device *adev) /** * ali_check_atapi_dma - DMA check for most ALi controllers - * @adev: Device + * @qc: Command to complete * * Called to decide whether commands should be sent by DMA or PIO */ From patchwork Thu Jan 28 18:02:27 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1432959 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=linux-ide-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=LCSL/fcw; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4DRT495wfVz9sW0 for ; Fri, 29 Jan 2021 05:08:41 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231407AbhA1SHW (ORCPT ); Thu, 28 Jan 2021 13:07:22 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60628 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231414AbhA1SEQ (ORCPT ); Thu, 28 Jan 2021 13:04:16 -0500 Received: from mail-wr1-x431.google.com (mail-wr1-x431.google.com [IPv6:2a00:1450:4864:20::431]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 78BDCC061356 for ; Thu, 28 Jan 2021 10:02:54 -0800 (PST) Received: by mail-wr1-x431.google.com with SMTP id v15so6355273wrx.4 for ; Thu, 28 Jan 2021 10:02:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=MvoGC7duOzp4QbVV73i8hwf4OtQFHAIOE3fctv618Vg=; b=LCSL/fcwhlSrm7/lPGXpRlMQ0n2aJQsdeAOcuIr7kBIZyWGO4wpdPQ3TUqEgqrxZA0 UMkH9ME6yeqoYFSIQnabalTsyaacEnMVFhkVr1ipyzQsoI+JO5RNSw3V93yhVo6vn33h G2OhqiZzDjzJVgIWhHhm0szCYXY4TBHp7P/G9LVdxZ/c0FZSEJjFEUyFSLNNtJiIEC6O 5B7SIsdJhLuG8JwhcDL1QYWQgXLcN+GMDFNV1TKFXEmFd4E+UzHQdmWrzTXDBkgnYvDJ BZSKMH3/TfZg3sdClckaTszuFVK11UbU+Yber7oT1ea+wdx0+EcSrCutdlkh60sA2OWF bHrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=MvoGC7duOzp4QbVV73i8hwf4OtQFHAIOE3fctv618Vg=; b=SyolQ4WGPVP/AEzYPEzDhuNu5Nq976rcDdiq0OeuCnJJbdQOFfqvz4DygjUDT/AkmH E5ctx6LYPODcKBLK/5rItc1nZTLJ93NIxKryE4H/o8e84IqG06ImIvD/Dxxh/Slu/UIu e0l7inCXlpy/aV98+EmN/z+5SHxVgD7ZtSjMhwXKbwiqb/ijXJ0XmJpT8bKx0HIZ4vK2 SUuTUEQwitbzoyK72Xo1SefAds8mwQmqwd9YM+Vv/xwN9XXgWxuSbnyJw8StqKGj0hDt 8bESCEqlR+21jXRt3FBPiecczWlIaN2UkEG4FYdSXVcgmq/S5lzMlOFv7Hbu7xjYceTg +VHQ== X-Gm-Message-State: AOAM533PKwWieCUUxyiPj7CEv+yuZWMzVEUZ4SjI7++nh+0N0svW+0pa P3mhxuNz5XSMokHsCpv8c0mZjw== X-Google-Smtp-Source: ABdhPJwlRmBQ0XlMBMJkoz0Jvfl43UE6ncweVPFdcFHqoMnwtYyXiwnmj5wsqPFr3KRph9ft58miLw== X-Received: by 2002:a5d:6884:: with SMTP id h4mr359995wru.106.1611856973290; Thu, 28 Jan 2021 10:02:53 -0800 (PST) Received: from dell.default ([91.110.221.188]) by smtp.gmail.com with ESMTPSA id u6sm8280794wro.75.2021.01.28.10.02.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Jan 2021 10:02:52 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Jens Axboe , Andre Hedrick , Thibaut VARENE , Alessandro Zummo , linux-ide@vger.kernel.org Subject: [PATCH 08/20] ata: pata_artop: Fix a function name and parameter description Date: Thu, 28 Jan 2021 18:02:27 +0000 Message-Id: <20210128180239.548512-9-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210128180239.548512-1-lee.jones@linaro.org> References: <20210128180239.548512-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/ata/pata_artop.c:278: warning: expecting prototype for artop_6210_qc_defer(). Prototype was for artop6210_qc_defer() instead drivers/ata/pata_artop.c:359: warning: Function parameter or member 'id' not described in 'artop_init_one' drivers/ata/pata_artop.c:359: warning: Excess function parameter 'ent' description in 'artop_init_one' Cc: Jens Axboe Cc: Andre Hedrick Cc: Thibaut VARENE Cc: Alessandro Zummo Cc: linux-ide@vger.kernel.org Signed-off-by: Lee Jones --- drivers/ata/pata_artop.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/ata/pata_artop.c b/drivers/ata/pata_artop.c index 6bd2228bb6ffa..02e4fd5e3b934 100644 --- a/drivers/ata/pata_artop.c +++ b/drivers/ata/pata_artop.c @@ -344,7 +344,7 @@ static void atp8xx_fixup(struct pci_dev *pdev) /** * artop_init_one - Register ARTOP ATA PCI device with kernel services * @pdev: PCI device to register - * @ent: Entry in artop_pci_tbl matching with @pdev + * @id: PCI device ID * * Called from kernel PCI layer. * From patchwork Thu Jan 28 18:02:28 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1432956 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=linux-ide-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=UntfUA2V; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4DRT3J33XZz9sW0 for ; Fri, 29 Jan 2021 05:07:56 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231286AbhA1SHp (ORCPT ); Thu, 28 Jan 2021 13:07:45 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32958 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231526AbhA1SFH (ORCPT ); Thu, 28 Jan 2021 13:05:07 -0500 Received: from mail-wr1-x435.google.com (mail-wr1-x435.google.com [IPv6:2a00:1450:4864:20::435]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9952EC06121D for ; Thu, 28 Jan 2021 10:02:55 -0800 (PST) Received: by mail-wr1-x435.google.com with SMTP id s7so3347763wru.5 for ; Thu, 28 Jan 2021 10:02:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=sxf8NqRslTnnCXUblNlG5//kELg1DL3clvbNvmI4mXU=; b=UntfUA2Vm6vrDU0WjZudlXKWSikByvxdHCdDF5CbmQw3+MSfBhMuBIX9Enta75PVUy ZafVqU2JFFP2bgb/HB9XGStGpkBLCINlVTYcWr277dRkq3KHOHi8RpFY03XKOKFFZWQr ugd8TxEpgC8eHyHl43kMeekO21MEKrYzyUYn+hrZX5eyGuJLtVrQqaoWaYwReXkffcAU npHQo6LDWhX6wqeRMdzJ0F11GT0gYkcRECALKZXMgSprXWMMW1a3C0h2fmW+DhjzN1EP D1sn+56xVrQJIbe5lRXBVSBWVEix2KyPEM5d1r4RRkGW8mk2q+t7ro/403rhrJNc0rg2 Jz5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=sxf8NqRslTnnCXUblNlG5//kELg1DL3clvbNvmI4mXU=; b=EsaNlje3mH5G+axEX9HqrfYsHksviIS4eZWhp+pq/dLKHIdy+wOsSCBBun1eZuN+Hh eRg3gkrb450yxGKvleSPPbZ3uqVahd1bommwmLM+ecjUIGt3oLulzp8MyXmEGSeBA4Cc q0qlE28hcRq8DJ0WWTM9VCwMcEJBaWNcMaFIq4UpWghzeQLFYrPYdMuCYAgEjISUs+Qr dXjMEimwhAyRxGE8UrD5+KuX+dHeYuW8wWpF2OCKDuEwQ/qmneHyIVLtXM+SrIQtnTvw bPkYFyLc1M/8XOfRCLzVUURSiUzSQ9NvzG664aQX0BJiULnbZSI8ElKjwcOi27PFdK0R fSgg== X-Gm-Message-State: AOAM532+VeVfVD/4dMK+B8pHjLo55SW977EIVqJxmDpWy3JuoqzdVW31 /vdh+DfK8XHcbfXxjZ2G++RFoQ== X-Google-Smtp-Source: ABdhPJx5KaLH/cy/rUYXXolnbXr9+dS6SYxaMQVUWhpOrqyckolzbwAaCpN7Ih3WkdcMbMbbGlfKww== X-Received: by 2002:a5d:6311:: with SMTP id i17mr264514wru.195.1611856974407; Thu, 28 Jan 2021 10:02:54 -0800 (PST) Received: from dell.default ([91.110.221.188]) by smtp.gmail.com with ESMTPSA id u6sm8280794wro.75.2021.01.28.10.02.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Jan 2021 10:02:53 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Jens Axboe , linux-ide@vger.kernel.org Subject: [PATCH 09/20] ata: acard-ahci: Ignore -Woverride-init Date: Thu, 28 Jan 2021 18:02:28 +0000 Message-Id: <20210128180239.548512-10-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210128180239.548512-1-lee.jones@linaro.org> References: <20210128180239.548512-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org Some ATA drivers use the SCSI host template, a series of interwoven macros, to aid with initialisation. Some of these macros conflict, resulting in the over-writing of previously set values. This is known behaviour and can be safely ignored. Fixes the following W=1 kernel build warning(s): In file included from drivers/ata/acard-ahci.c:33: drivers/ata/ahci.h:387:16: warning: initialized field overwritten [-Woverride-init] drivers/ata/acard-ahci.c:70:2: note: in expansion of macro ‘AHCI_SHT’ drivers/ata/ahci.h:387:16: note: (near initialization for ‘acard_ahci_sht.can_queue’) drivers/ata/acard-ahci.c:70:2: note: in expansion of macro ‘AHCI_SHT’ drivers/ata/ahci.h:391:17: warning: initialized field overwritten [-Woverride-init] drivers/ata/acard-ahci.c:70:2: note: in expansion of macro ‘AHCI_SHT’ drivers/ata/ahci.h:391:17: note: (near initialization for ‘acard_ahci_sht.sdev_attrs’) drivers/ata/acard-ahci.c:70:2: note: in expansion of macro ‘AHCI_SHT’ Cc: Jens Axboe Cc: linux-ide@vger.kernel.org Signed-off-by: Lee Jones --- drivers/ata/Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/ata/Makefile b/drivers/ata/Makefile index 79c59550c23a0..4542f101042ac 100644 --- a/drivers/ata/Makefile +++ b/drivers/ata/Makefile @@ -1,5 +1,6 @@ # SPDX-License-Identifier: GPL-2.0 +CFLAGS_acard-ahci.o = $(call cc-disable-warning, override-init) CFLAGS_ahci_dm816.o = $(call cc-disable-warning, override-init) CFLAGS_ahci_mtk.o = $(call cc-disable-warning, override-init) CFLAGS_ahci_platform.o = $(call cc-disable-warning, override-init) From patchwork Thu Jan 28 18:02:29 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1432958 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=linux-ide-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=IcehFqxg; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4DRT475CPfz9sW0 for ; Fri, 29 Jan 2021 05:08:39 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231450AbhA1SHi (ORCPT ); Thu, 28 Jan 2021 13:07:38 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60620 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231416AbhA1SEp (ORCPT ); Thu, 28 Jan 2021 13:04:45 -0500 Received: from mail-wr1-x432.google.com (mail-wr1-x432.google.com [IPv6:2a00:1450:4864:20::432]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 819A2C06121E for ; Thu, 28 Jan 2021 10:02:56 -0800 (PST) Received: by mail-wr1-x432.google.com with SMTP id l12so6350563wry.2 for ; Thu, 28 Jan 2021 10:02:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=E/DwODThT9yC2p7TIC8q4FOkFeXMx+9HaJ4TFjAbkcM=; b=IcehFqxg+qhB/Bt2N/xmvTOQuNtPxLWBYFNOY1uPVKFq6t37B8P6+QnybvCbJfIA0g mHUNP7ASctifTUszQvOB+5y7G0oU/eSaeZKeAreNjtBPSzoijZeIitNytsMQ793/pOOS l0T0sWha6HXVk5kMRVejg7Z2bHFXa46jLIbiy0rTXPg0nPwTFrRrRDbSIq+2zXlWGmbL RWXJHlbHhMfR9Hucr89j3YzuE8r2piliwu92LDTV0LHIpbg1c6KOAlenjcx8HChqLW79 S5JiOCzAh1OIDpQPJ/npZfS0jnteGMOhfBJ0KpNOtHj5xvkgxYTlExW+zELNTPJ/vYAg tS9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=E/DwODThT9yC2p7TIC8q4FOkFeXMx+9HaJ4TFjAbkcM=; b=iVDeCcosrdj5qt8+54pnSQUWs1DYUT5URrzy6jtPDDHf9K1Huo/5PzSCVWI97mvO01 gn39+FMY1ORbOTTxx/0H7jpa+Kx7/OhVdHRewhYrA12aLOwtniAIQEOCORLXOYN9pAfq q3rMVlST8kXjB4Sqeb/bH8xqBVkzwupAq+9hkWKzA3opRPDLCljS0OzS5rDyD3Bv7vmT U0OnbToJbYpbDIHP/78eq3nuU28ct7XTzSGtzAHUrWgJO8TEdWI7T9XOPjw4dPyawUex KyTz2BL02++UqMw7zmG+WUpg6+SsepDWxaixtmUL9/XQmMQhcQQcbuyKuObQJlHqF3wn SWlw== X-Gm-Message-State: AOAM533QTjvGP6QBz7HPj6rUPSNC929iItZdkZXf/oKgO/uiVQecbZR6 EU5BLnQ3tSfZKaP3BGV+fZK4Yg== X-Google-Smtp-Source: ABdhPJxVOhutxcNoDQUOFr31hXwp4y4YTk/hM1DXXDnAs/FBnB2x/NCn3+pnA2qCqgH/1pK5aeCmXg== X-Received: by 2002:adf:b64f:: with SMTP id i15mr244663wre.279.1611856975325; Thu, 28 Jan 2021 10:02:55 -0800 (PST) Received: from dell.default ([91.110.221.188]) by smtp.gmail.com with ESMTPSA id u6sm8280794wro.75.2021.01.28.10.02.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Jan 2021 10:02:54 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Jens Axboe , linux-ide@vger.kernel.org Subject: [PATCH 10/20] ata: ahci_ceva: Ignore -Woverride-init Date: Thu, 28 Jan 2021 18:02:29 +0000 Message-Id: <20210128180239.548512-11-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210128180239.548512-1-lee.jones@linaro.org> References: <20210128180239.548512-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org Some ATA drivers use the SCSI host template, a series of interwoven macros, to aid with initialisation. Some of these macros conflict, resulting in the over-writing of previously set values. This is known behaviour and can be safely ignored. Fixes the following W=1 kernel build warning(s): In file included from drivers/ata/ahci_ceva.c:15: drivers/ata/ahci.h:387:16: warning: initialized field overwritten [-Woverride-init] drivers/ata/ahci_ceva.c:187:2: note: in expansion of macro ‘AHCI_SHT’ drivers/ata/ahci.h:387:16: note: (near initialization for ‘ahci_platform_sht.can_queue’) drivers/ata/ahci_ceva.c:187:2: note: in expansion of macro ‘AHCI_SHT’ drivers/ata/ahci.h:391:17: warning: initialized field overwritten [-Woverride-init] drivers/ata/ahci_ceva.c:187:2: note: in expansion of macro ‘AHCI_SHT’ drivers/ata/ahci.h:391:17: note: (near initialization for ‘ahci_platform_sht.sdev_attrs’) drivers/ata/ahci_ceva.c:187:2: note: in expansion of macro ‘AHCI_SHT’ drivers/ata/sata_sil24.c:378:16: warning: initialized field overwritten [-Woverride-init] drivers/ata/sata_sil24.c:378:16: note: (near initialization for ‘sil24_sht.can_queue’) Cc: Jens Axboe Cc: linux-ide@vger.kernel.org Signed-off-by: Lee Jones --- drivers/ata/Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/ata/Makefile b/drivers/ata/Makefile index 4542f101042ac..c7460c6b94c1d 100644 --- a/drivers/ata/Makefile +++ b/drivers/ata/Makefile @@ -1,6 +1,7 @@ # SPDX-License-Identifier: GPL-2.0 CFLAGS_acard-ahci.o = $(call cc-disable-warning, override-init) +CFLAGS_ahci_ceva.o = $(call cc-disable-warning, override-init) CFLAGS_ahci_dm816.o = $(call cc-disable-warning, override-init) CFLAGS_ahci_mtk.o = $(call cc-disable-warning, override-init) CFLAGS_ahci_platform.o = $(call cc-disable-warning, override-init) From patchwork Thu Jan 28 18:02:30 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1432955 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=linux-ide-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=lBHSuYaf; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4DRT3J0RWjz9sWK for ; Fri, 29 Jan 2021 05:07:56 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231416AbhA1SHm (ORCPT ); Thu, 28 Jan 2021 13:07:42 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60624 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231262AbhA1SEw (ORCPT ); Thu, 28 Jan 2021 13:04:52 -0500 Received: from mail-wm1-x32a.google.com (mail-wm1-x32a.google.com [IPv6:2a00:1450:4864:20::32a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 191BBC06178A for ; Thu, 28 Jan 2021 10:02:58 -0800 (PST) Received: by mail-wm1-x32a.google.com with SMTP id u14so5031984wml.4 for ; Thu, 28 Jan 2021 10:02:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=psxck1KMWyXDOgBCEv3jYVYq9cj2r/nvdYNmqCZ8a8o=; b=lBHSuYaf+ThEC3XoD0nFSMFQjdNXO6266Ggd88khh8AtoBXvl5UBglSmIvSRwJwD/P IU+b4wERYdnenTF6z5UMj7tvpnI2dsyL4IgBsQpv5O0O8Fodim0dN50K9Is4SYp+x238 EHO/MnRTxnmFfSeI9jdmrzpL+a5AQzn2G2BuvDfXa7Ctui6GlQkZpxkp13i4VaKrl/en wMa/Mm1CvgoWI9IFvVRU1EorTkSXe4SkFGacVGi+RiAWSYltYNF2/zEr5+ZrI1Vru+OU xkDX6pGasijORHWcwHiMpzLFKoCevZIiJ4RPRx7IYiiUpkulawfPN0j1SZfCt188cWup S8MQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=psxck1KMWyXDOgBCEv3jYVYq9cj2r/nvdYNmqCZ8a8o=; b=UfcHEEARiXyhiN10Fn1QsBShncWcOpIm/mwK8xS4sHBVG8T+syjHaIHNLq71fkfRYX USrMcczPNFDstDNQGk+57/WRyX4TjDfdHKVSV+2fjvUemVFGdGzvnnGuV4jW1VHlK58h nCU+GJOrtXFAo8cAqLXOqI94KaKWWGkNWSdpEwNYE7HWjn2UaZ4o2cljQ2xHyiyhgDcS nHOw614HdFnh9YYNG/xpGEGJA0AuHg4fSaMjTKwC9pqSpU88S4nvkRuLNQfpBqpsiAx0 IH0uTNEMNgiqlhIMs8CykrcaFB6ypdfv/ypc/okZRFMytJtac8cANR9IRlphM9P69xp8 XP5Q== X-Gm-Message-State: AOAM530bcl2jidsJS1D+dwrusCQEaCGcWVCX4SCIyPO02PuF3jGV6ark pccCLJknWh5DpruMOSUQg78WgA== X-Google-Smtp-Source: ABdhPJylmz84beCkITbxAGADN4SRcalxnpuBzHeS1s4xaAKVu0RnbM6Gdx3NAZPS52cxhsCp1GI+tA== X-Received: by 2002:a1c:b682:: with SMTP id g124mr473279wmf.10.1611856976813; Thu, 28 Jan 2021 10:02:56 -0800 (PST) Received: from dell.default ([91.110.221.188]) by smtp.gmail.com with ESMTPSA id u6sm8280794wro.75.2021.01.28.10.02.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Jan 2021 10:02:56 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Jens Axboe , linux-ide@vger.kernel.org Subject: [PATCH 11/20] ata: pata_amd: Remove superfluous, add missing and fix broken params Date: Thu, 28 Jan 2021 18:02:30 +0000 Message-Id: <20210128180239.548512-12-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210128180239.548512-1-lee.jones@linaro.org> References: <20210128180239.548512-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/ata/pata_amd.c:179: warning: Excess function parameter 'adev' description in 'amd_fifo_setup' drivers/ata/pata_amd.c:331: warning: Function parameter or member 'link' not described in 'nv_pre_reset' drivers/ata/pata_amd.c:331: warning: Function parameter or member 'deadline' not described in 'nv_pre_reset' drivers/ata/pata_amd.c:331: warning: expecting prototype for nv_probe_init(). Prototype was for nv_pre_reset() instead Cc: Jens Axboe Cc: linux-ide@vger.kernel.org Signed-off-by: Lee Jones --- drivers/ata/pata_amd.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/ata/pata_amd.c b/drivers/ata/pata_amd.c index 987967f976cb2..75b830eb3c542 100644 --- a/drivers/ata/pata_amd.c +++ b/drivers/ata/pata_amd.c @@ -167,7 +167,6 @@ static int amd_cable_detect(struct ata_port *ap) /** * amd_fifo_setup - set the PIO FIFO for ATA/ATAPI * @ap: ATA interface - * @adev: ATA device * * Set the PCI fifo for this device according to the devices present * on the bus at this point in time. We need to turn the post write buffer @@ -321,7 +320,8 @@ static unsigned long nv_mode_filter(struct ata_device *dev, /** * nv_probe_init - cable detection - * @lin: ATA link + * @link: ATA link + * @deadline: deadline jiffies for the operation * * Perform cable detection. The BIOS stores this in PCI config * space for us. From patchwork Thu Jan 28 18:02:31 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1432957 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=linux-ide-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=Nurqslu0; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4DRT3L4JPHz9sW0 for ; Fri, 29 Jan 2021 05:07:58 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231526AbhA1SHs (ORCPT ); Thu, 28 Jan 2021 13:07:48 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60814 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231534AbhA1SFJ (ORCPT ); Thu, 28 Jan 2021 13:05:09 -0500 Received: from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com [IPv6:2a00:1450:4864:20::42a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 143BAC061222 for ; Thu, 28 Jan 2021 10:02:59 -0800 (PST) Received: by mail-wr1-x42a.google.com with SMTP id s7so3347925wru.5 for ; Thu, 28 Jan 2021 10:02:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=bku/TZDwGiY5vuh8zroI/7gSSOC7kKg9Wo8De+jk1lQ=; b=Nurqslu0d9ZwZ10IWWGqE6G9xt1JePKcmpIrRynNCMdLIAc+57LzYLJKEL7PvrBXjw 6bGtME1fvy03oT7Jllc0teJLFoQrunhkSoJfyUIWryc3t0vG0CnlN7sFstoC6Ko9HM4x /UzgUlxzWm9yrbEHJB8EcxTBGS/m98p7ZpId/OcKIhvBHeFPZ2tm4clYfnYWLSBw/DKE yRmbLqUkhOlJ/BmotlqnwRtmPduKAJHrfOcNs2DsYl9yz5s3FNzw71H1HvDIznGpfL+b vy4ulT08Wj2ss/C1JDa2ZnxFTJ3DiZ3PZhrdAPB0YttCZ83ZbVSp6dbRcqb0GldlIUq6 J5XQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=bku/TZDwGiY5vuh8zroI/7gSSOC7kKg9Wo8De+jk1lQ=; b=HQ0SZr4CdsbWQCN0VM9jT5lEBRvOsL4YXxoNtmFO9P/L2yezV1SaehF9JpifD+jppy KHNWP5Gc6JYuo9/a6qL1MHa6VS11sXkOrf5zjlHdCZMdR3tbIWjQyJW2ORaUWWrpybuN ajY8CZZ+wcq8QNfVpYvn+mYjMvp+l3q4k5iCZMoOWwz6uWFQND7sfP7YXSRufnEP2Oq8 /kag3ZAoy89yrrBo7IKS/jA7I29iLTSXLCn2Q2DkkmYMys66NerHKuArVkFA9SALyPtH cabz/W2TNg89WYR/4p2xw8blsH4Rjj79JZL0BpUDmc4evzlUFwPHGtQpj0L9k8YGIfuh bBPA== X-Gm-Message-State: AOAM5333vrB18SCkUOogvVak98rQ/CkIYG8Of/1N0HAw+y5z5zUcYq1c txx1PmaLM9Fgw93LsOJ3XXVD9g== X-Google-Smtp-Source: ABdhPJxrEupt53VzeI+7GcG+/MAFplgDc5K42e8phIxQ6WxAavhFiIMN6vtlA3P8N4zstFeBVpogiw== X-Received: by 2002:a5d:4e47:: with SMTP id r7mr323827wrt.312.1611856977884; Thu, 28 Jan 2021 10:02:57 -0800 (PST) Received: from dell.default ([91.110.221.188]) by smtp.gmail.com with ESMTPSA id u6sm8280794wro.75.2021.01.28.10.02.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Jan 2021 10:02:57 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Jens Axboe , Andre Hedrick , linux-ide@vger.kernel.org Subject: [PATCH 12/20] ata: pata_hpt366: Provide missing description for 'hpt366_filter()'s 'mask' param Date: Thu, 28 Jan 2021 18:02:31 +0000 Message-Id: <20210128180239.548512-13-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210128180239.548512-1-lee.jones@linaro.org> References: <20210128180239.548512-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/ata/pata_hpt366.c:200: warning: Function parameter or member 'mask' not described in 'hpt366_filter' Cc: Jens Axboe Cc: Andre Hedrick Cc: linux-ide@vger.kernel.org Signed-off-by: Lee Jones --- drivers/ata/pata_hpt366.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/ata/pata_hpt366.c b/drivers/ata/pata_hpt366.c index 2574d6fbb1ad3..06b7c4a9ec954 100644 --- a/drivers/ata/pata_hpt366.c +++ b/drivers/ata/pata_hpt366.c @@ -192,6 +192,7 @@ static int hpt_dma_blacklisted(const struct ata_device *dev, char *modestr, /** * hpt366_filter - mode selection filter * @adev: ATA device + * @mask: Current mask to manipulate and pass back * * Block UDMA on devices that cause trouble with this controller. */ From patchwork Thu Jan 28 18:02:32 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1432966 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=linux-ide-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=aq2rx7gW; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4DRTFn5HkWz9sWK for ; Fri, 29 Jan 2021 05:17:01 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231465AbhA1SQn (ORCPT ); Thu, 28 Jan 2021 13:16:43 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60816 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231531AbhA1SFO (ORCPT ); Thu, 28 Jan 2021 13:05:14 -0500 Received: from mail-wr1-x42b.google.com (mail-wr1-x42b.google.com [IPv6:2a00:1450:4864:20::42b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2819DC061223 for ; Thu, 28 Jan 2021 10:03:00 -0800 (PST) Received: by mail-wr1-x42b.google.com with SMTP id g10so6349949wrx.1 for ; Thu, 28 Jan 2021 10:03:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=0PbmlJv/q/qmETwokGHFJjxp6oe2rW16X/lQKCZKsiQ=; b=aq2rx7gWn31iQw3uOa+4G2xrcd0Ag4/SNRBj05WKYiunjcU1KlddQNhyZ1fcQ/dtoB SPO9bBPkOGwQtiKibTcbhvJs60PbSDUmp0VRcawAh2W6A1zoP/LJc5//u/q4/hLW12V8 5vZIAkfYlWeqXL4YzNjdfH6o13EoReLKM3Gt/K1bg9dq7e4d0LyTayz48f9xi2vmQ7UF GvdeGkq9Ul9LXP7TJX7ASnm4uACJAP3JvF1sk+FlvcS6C5gdWV4Ac8Q4eOg863EAlE6F 7JGV178gMSQLFb8H6FGx/SUCWBEfAffcpxrilkZeg6M2qYftLplKDfo5u+/uE2inU4W/ IkMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=0PbmlJv/q/qmETwokGHFJjxp6oe2rW16X/lQKCZKsiQ=; b=lkKB7kYe3ahiFlcxRGRxxH1Z7Xfk+a1qCTY/3pW9lkQgLQ3ByNZJdRZJLmAIOiXkop JnVA2v4G21VTvwpFyQ6nC/bAroM+5HB7Rk4NNBMSLop3CVtx11Nd4IMWmbu8Nif6urf4 R1wBpy6eHz/h002YuUvzJPO/yKzt3FLfuZYeIfM1qftQB9mhw9ndeN4Pt+mWzHuZ73ry bo2IBfvZyV6QIfCPxZ7spL2IBNejcg/C48UqWio0g/FCeu/Eg6CfKYsJPw5mCKoWTV74 u3QZ/kq15H8VioYu3y8aXT7QaND/pknhgtcknPZrab6MQcR44qnxUOZqD8U/QdwaSDEr ujSw== X-Gm-Message-State: AOAM532Y+R2PW+p1FrpTobRBBECLUDAKtTweiHQkp38kVQlizCYYITnb Sf2Ju+kerNwBI9+Fbd9vat5ffg== X-Google-Smtp-Source: ABdhPJyEcDd7yiOxUxD1pLbTrCZvB+TDHAxJTgsLzlGu6YxDq6qnzCZCrM8xJAD9ArHOrLI/HJAyUw== X-Received: by 2002:adf:f28b:: with SMTP id k11mr304880wro.418.1611856978969; Thu, 28 Jan 2021 10:02:58 -0800 (PST) Received: from dell.default ([91.110.221.188]) by smtp.gmail.com with ESMTPSA id u6sm8280794wro.75.2021.01.28.10.02.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Jan 2021 10:02:58 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Jens Axboe , Andre Hedrick , linux-ide@vger.kernel.org Subject: [PATCH 13/20] ata: pata_hpt37x: Fix some function misnaming and missing param issues Date: Thu, 28 Jan 2021 18:02:32 +0000 Message-Id: <20210128180239.548512-14-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210128180239.548512-1-lee.jones@linaro.org> References: <20210128180239.548512-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/ata/pata_hpt37x.c:283: warning: Function parameter or member 'mask' not described in 'hpt370_filter' drivers/ata/pata_hpt37x.c:301: warning: Function parameter or member 'mask' not described in 'hpt370a_filter' drivers/ata/pata_hpt37x.c:473: warning: expecting prototype for hpt370_bmdma_end(). Prototype was for hpt370_bmdma_stop() instead drivers/ata/pata_hpt37x.c:567: warning: expecting prototype for hpt37x_bmdma_end(). Prototype was for hpt37x_bmdma_stop() instead Cc: Jens Axboe Cc: Andre Hedrick Cc: linux-ide@vger.kernel.org Signed-off-by: Lee Jones --- drivers/ata/pata_hpt37x.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/ata/pata_hpt37x.c b/drivers/ata/pata_hpt37x.c index fad6c6a873130..f242157bc81bb 100644 --- a/drivers/ata/pata_hpt37x.c +++ b/drivers/ata/pata_hpt37x.c @@ -275,6 +275,7 @@ static const char * const bad_ata100_5[] = { /** * hpt370_filter - mode selection filter * @adev: ATA device + * @mask: mode mask * * Block UDMA on devices that cause trouble with this controller. */ @@ -293,6 +294,7 @@ static unsigned long hpt370_filter(struct ata_device *adev, unsigned long mask) /** * hpt370a_filter - mode selection filter * @adev: ATA device + * @mask: mode mask * * Block UDMA on devices that cause trouble with this controller. */ @@ -463,7 +465,7 @@ static void hpt370_set_dmamode(struct ata_port *ap, struct ata_device *adev) } /** - * hpt370_bmdma_end - DMA engine stop + * hpt370_bmdma_stop - DMA engine stop * @qc: ATA command * * Work around the HPT370 DMA engine. @@ -557,7 +559,7 @@ static void hpt372_set_dmamode(struct ata_port *ap, struct ata_device *adev) } /** - * hpt37x_bmdma_end - DMA engine stop + * hpt37x_bmdma_stop - DMA engine stop * @qc: ATA command * * Clean up after the HPT372 and later DMA engine From patchwork Thu Jan 28 18:02:33 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1432968 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=linux-ide-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=Gt5dMryv; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4DRTFp58Jnz9sWL for ; Fri, 29 Jan 2021 05:17:02 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231480AbhA1SQo (ORCPT ); Thu, 28 Jan 2021 13:16:44 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60888 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231607AbhA1SGC (ORCPT ); Thu, 28 Jan 2021 13:06:02 -0500 Received: from mail-wm1-x335.google.com (mail-wm1-x335.google.com [IPv6:2a00:1450:4864:20::335]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1AE67C061226 for ; Thu, 28 Jan 2021 10:03:01 -0800 (PST) Received: by mail-wm1-x335.google.com with SMTP id u14so5296274wmq.4 for ; Thu, 28 Jan 2021 10:03:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=gT2cxZw+MQ4seB7v8/9B4WCOA4wG3O/G2z6VtzkvCxE=; b=Gt5dMryvvJiG5ucbCvgM4VjHdED5lacseCJlduFYa9/RYb8Bm1pjJ4JzVsgtIkE84H 599RG1ThbTLLHDxyXnlh3p3x86BIL5+7WKkaExWDEF1fP9nqoTeaUIEPsyEjJYyEyRHZ 4A23gg+N2xnAK5nIX94CM6M4BUgTLujxp62Aj1tcJafnWQAGy5nQWDeYhURbX/VPxGLY g7D6Lq4P1iQw7ivC8Mdoz7dgjXpAOlsGJcdfvtDwJV+HvSBNGJ14Q85YOXpW+m6o0Bzf m8/9azLHkPwSK4T4CX5vzzUevFGd3SYfX8scgbLostDbjpidxT9jZQ0dNLuY5Av9YnzO sT3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=gT2cxZw+MQ4seB7v8/9B4WCOA4wG3O/G2z6VtzkvCxE=; b=BktyLO7dZ4Fdvz6IiyjOy3QTJp1843mieYklgbS9sEh4THGsS+74pB6tknfdyQw5+H P/bXhsmkNlNQi4iiEeTpzYqCI/SvCQ8SRej503lnXEyiWruHFFgH3/Zu0P38HCJEp5om 33acm7JR8Y1l/BeCElLQQ6a8S+4euqdEBfPyaxGhT7a7xE5eQKoHhzvnAhamaxb/H2mp MdTBJdd3pl25H79aVzaBZXHFQf5sOw27+jMiaDPZIR5rNVzqM+RWvn59mn/dVxAlvx0o uTBzb78US+tc/JJtWShjcEcasgIbLbM0df9Fq8wTr+sdBj/ey0/mj/rLYtI2SgCTcHUo /xKA== X-Gm-Message-State: AOAM532CTnJMK6yaeHeBapPxM8/SCwAYC5JgCup0lyDphgLd2OXyXALO XRFaO5vocjPEIjmraQEEqXqxRw== X-Google-Smtp-Source: ABdhPJwVi4H8wPonjuSrecsMlYCH9jt2QZgzS6XQr3HaYK95r2i3Rcv1jRARG6htvkqqNF6A2B32yw== X-Received: by 2002:a1c:6089:: with SMTP id u131mr405984wmb.99.1611856979878; Thu, 28 Jan 2021 10:02:59 -0800 (PST) Received: from dell.default ([91.110.221.188]) by smtp.gmail.com with ESMTPSA id u6sm8280794wro.75.2021.01.28.10.02.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Jan 2021 10:02:59 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Jens Axboe , linux-ide@vger.kernel.org Subject: [PATCH 14/20] ata: sata_sil24: Ignore -Woverride-init Date: Thu, 28 Jan 2021 18:02:33 +0000 Message-Id: <20210128180239.548512-15-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210128180239.548512-1-lee.jones@linaro.org> References: <20210128180239.548512-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org Some ATA drivers use the SCSI host template, a series of interwoven macros, to aid with initialisation. Some of these macros conflict, resulting in the over-writing of previously set values. This is known behaviour and can be safely ignored. Fixes the following W=1 kernel build warning(s): In file included from drivers/ata/sata_sil24.c:14: drivers/ata/sata_sil24.c:381:22: note: in expansion of macro ‘BLK_TAG_ALLOC_FIFO’ drivers/ata/sata_sil24.c:381:22: note: in expansion of macro ‘BLK_TAG_ALLOC_FIFO’ drivers/ata/libata-pmp.c:76: warning: Function parameter or member 'val' not described in 'sata_pmp_write' drivers/ata/libata-pmp.c:76: warning: Excess function parameter 'r_val' description in 'sata_pmp_write' Cc: Jens Axboe Cc: linux-ide@vger.kernel.org Signed-off-by: Lee Jones --- drivers/ata/Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/ata/Makefile b/drivers/ata/Makefile index c7460c6b94c1d..d46703777cdd4 100644 --- a/drivers/ata/Makefile +++ b/drivers/ata/Makefile @@ -5,6 +5,7 @@ CFLAGS_ahci_ceva.o = $(call cc-disable-warning, override-init) CFLAGS_ahci_dm816.o = $(call cc-disable-warning, override-init) CFLAGS_ahci_mtk.o = $(call cc-disable-warning, override-init) CFLAGS_ahci_platform.o = $(call cc-disable-warning, override-init) +CFLAGS_sata_sil24.o = $(call cc-disable-warning, override-init) obj-$(CONFIG_ATA) += libata.o From patchwork Thu Jan 28 18:02:34 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1432967 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=linux-ide-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=GmTt6uep; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4DRTFp20CPz9sWC for ; Fri, 29 Jan 2021 05:17:02 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231531AbhA1SQp (ORCPT ); Thu, 28 Jan 2021 13:16:45 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60628 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231158AbhA1SGc (ORCPT ); Thu, 28 Jan 2021 13:06:32 -0500 Received: from mail-wr1-x42d.google.com (mail-wr1-x42d.google.com [IPv6:2a00:1450:4864:20::42d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 24C6AC0611C1 for ; Thu, 28 Jan 2021 10:03:02 -0800 (PST) Received: by mail-wr1-x42d.google.com with SMTP id a1so6360051wrq.6 for ; Thu, 28 Jan 2021 10:03:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=RnaBivPDyIR6gMAHAoH39HuDWPvuUIfAphuD3A1F0ZE=; b=GmTt6uepAz3Dn8NZmdm/BpZmoDDL7JOogKQSj/2DdscZhtv74SQ3r/PuDlDeSForKM o5+rbKyl5ATV6x06CbajjAu6abcqUq8sObBpfUXgwKD0GdKkoDwniAUcuFY2a0FwAAYu +Qa/Na6KUrTg9/jQlzFcZZHJdIRb1NImmmQTvvy4YdSjlu+lqINGVXOodnVNaPh74vkA AP7antxMT6B0JYzbuXNgSrb07xCThkY03NIQZ3aS9mvKs8mQacXQCIm9chMlc0BHDWot Yl4K3CbN5hKt54wYnGPI3eKRLPdl70gICFBfr34rg4I2NgmbT8mdl1H8PZl/DV6+75aI HMUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=RnaBivPDyIR6gMAHAoH39HuDWPvuUIfAphuD3A1F0ZE=; b=m9U4mYuuzxSpRA0XZjfIFL/OWYdGWAujd2ztZTi1DvMmATjCefi8EnKzbOhco553Bs oP5vGLMgtJjCCedYPLC2l/RI6JIiWCnaz0ndY8GfyQglpaj5OSekU5D7ylrlkY5cddIg oVmhatgcWh2bvUQ5v5NNIc+Ufyi2/b5w8AUXVfK7V6+bZ8zBm4EiHRdZl+rQdGG21wsb L7/dvIvD0mttHzm8JzVSBa7ue/J3dXxy8Kj8A8ujXCjuYikVo7juIxQ2B3cClvP5DhXc 4HO/DUoUu0wDwsncilH4okRsyLQQ0l/JptwOVs1ueQt8wxv8QG5cg7XGRMkOobDjEHzX oDeg== X-Gm-Message-State: AOAM532E2vwV/Fci3DF0wcZlp9Ntwph5DyBoliiLFuJ091cn+d7GZejB c5Ab0au8nxhcHcaZq9oI3M4EaQ== X-Google-Smtp-Source: ABdhPJyQoFfgxJ9wREOuyYhhU7/FmotdW8dZeHkvFg/1RJHmXWvNuU2KrLPJd6Ia32VJzLOcpRkxQg== X-Received: by 2002:a05:6000:108b:: with SMTP id y11mr233167wrw.379.1611856980901; Thu, 28 Jan 2021 10:03:00 -0800 (PST) Received: from dell.default ([91.110.221.188]) by smtp.gmail.com with ESMTPSA id u6sm8280794wro.75.2021.01.28.10.02.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Jan 2021 10:03:00 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Jens Axboe , linux-ide@vger.kernel.org Subject: [PATCH 15/20] ata: sata_highbank: Ignore -Woverride-init Date: Thu, 28 Jan 2021 18:02:34 +0000 Message-Id: <20210128180239.548512-16-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210128180239.548512-1-lee.jones@linaro.org> References: <20210128180239.548512-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org Some ATA drivers use the SCSI host template, a series of interwoven macros, to aid with initialisation. Some of these macros conflict, resulting in the over-writing of previously set values. This is known behaviour and can be safely ignored. Fixes the following W=1 kernel build warning(s): In file included from drivers/ata/sata_highbank.c:25: drivers/ata/ahci.h:387:16: warning: initialized field overwritten [-Woverride-init] drivers/ata/sata_highbank.c:442:2: note: in expansion of macro ‘AHCI_SHT’ drivers/ata/ahci.h:387:16: note: (near initialization for ‘ahci_highbank_platform_sht.can_queue’) drivers/ata/sata_highbank.c:442:2: note: in expansion of macro ‘AHCI_SHT’ drivers/ata/ahci.h:391:17: warning: initialized field overwritten [-Woverride-init] drivers/ata/sata_highbank.c:442:2: note: in expansion of macro ‘AHCI_SHT’ drivers/ata/ahci.h:391:17: note: (near initialization for ‘ahci_highbank_platform_sht.sdev_attrs’) drivers/ata/sata_highbank.c:442:2: note: in expansion of macro ‘AHCI_SHT’ Cc: Jens Axboe Cc: linux-ide@vger.kernel.org Signed-off-by: Lee Jones --- drivers/ata/Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/ata/Makefile b/drivers/ata/Makefile index d46703777cdd4..cf851f5a4e7fd 100644 --- a/drivers/ata/Makefile +++ b/drivers/ata/Makefile @@ -5,6 +5,7 @@ CFLAGS_ahci_ceva.o = $(call cc-disable-warning, override-init) CFLAGS_ahci_dm816.o = $(call cc-disable-warning, override-init) CFLAGS_ahci_mtk.o = $(call cc-disable-warning, override-init) CFLAGS_ahci_platform.o = $(call cc-disable-warning, override-init) +CFLAGS_sata_highbank.o = $(call cc-disable-warning, override-init) CFLAGS_sata_sil24.o = $(call cc-disable-warning, override-init) obj-$(CONFIG_ATA) += libata.o From patchwork Thu Jan 28 18:02:35 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1432960 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=linux-ide-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=uY4tumtm; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4DRT4S4d4Qz9sW0 for ; Fri, 29 Jan 2021 05:08:56 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231298AbhA1SIq (ORCPT ); Thu, 28 Jan 2021 13:08:46 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60630 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231220AbhA1SGc (ORCPT ); Thu, 28 Jan 2021 13:06:32 -0500 Received: from mail-wr1-x431.google.com (mail-wr1-x431.google.com [IPv6:2a00:1450:4864:20::431]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7811FC0611C3 for ; Thu, 28 Jan 2021 10:03:03 -0800 (PST) Received: by mail-wr1-x431.google.com with SMTP id a1so6360127wrq.6 for ; Thu, 28 Jan 2021 10:03:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=9Kb16WgSiv4QCUnRh1QxmaZs22WYIlooIF+TJGzI06k=; b=uY4tumtm8YxOImI9ocT2XoW8jBaWMaHHZiFSt4FEuXv9bdzGN9Xj+osrJCQGerKD/P sSgI2L4hb4qjMt7aVvkNRMKuZ6rj0dJ7y396CeWuYr+K5hDfG0ixH0Mwj/jWYlHVTDDO ZUAiIdWz/0iGZCKsHCQSS9R4hek/lPkeCB40HrUQRcjNokwQKG7GwmrVAvVR8eDczZY0 LO5KJDXrrVmjxg+x/mySwzjkG8UG/5mvat7AgllpymQ6UA2+ssRaQdKkCoCFvnNseHJ0 3ZT37UgpKQ+OBZllJcKKbHglPTxM3GSUNQYr92qAEjJ4y/Jk3R+/h3imz9I/qP1n3zZr qXEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=9Kb16WgSiv4QCUnRh1QxmaZs22WYIlooIF+TJGzI06k=; b=N0zNyfGbvd/podW5gbOc9N+VQZlZZM1maQhEnZ3f5bFBK1zcW2BD90hlxQKdjMH6EE 8s2NY5qVTRSaRbMT1Vu0IW8jCQ2tPP/8SiMu5hW5McY1+5hOjFWIV8ZEnHgJ6V1YqPaE JbMHYlcAN/X/bbgidUiuFgkDu4xM5h1VVreXteQPUaJnkRTok82/f1ZznfG0OGR1h5/D Vd8iW/rJHA1Oc4uzprPGQxfY8Gh/4YkokW0l6Ilzn0lokuJ+Anq9ov+A1a+M1qN4dZKI 7JbEEKtBLn384OE5Yn2/UXN8gBS0uqQQgeBQMOqGpkTJSqT7SgBsK+VE7ZmSFLWAKXgz rIJw== X-Gm-Message-State: AOAM533LEWMc1OZ2tU81dYVJorZ2s5nCN9XmlPqVEy9BynXZPQehIML+ SQbKutMh8UuMzu9lVNilXRIC5A== X-Google-Smtp-Source: ABdhPJy0q7zmSeCorDLSuCQkUi+uvpRw9C9SmnsugADQK5tQ2YEsviEZpL2JQSzXWWVaz05j2FO+8w== X-Received: by 2002:adf:dc88:: with SMTP id r8mr238462wrj.401.1611856982219; Thu, 28 Jan 2021 10:03:02 -0800 (PST) Received: from dell.default ([91.110.221.188]) by smtp.gmail.com with ESMTPSA id u6sm8280794wro.75.2021.01.28.10.03.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Jan 2021 10:03:01 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Jens Axboe , linux-ide@vger.kernel.org Subject: [PATCH 16/20] ata: ahci_brcm: Ignore -Woverride-init Date: Thu, 28 Jan 2021 18:02:35 +0000 Message-Id: <20210128180239.548512-17-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210128180239.548512-1-lee.jones@linaro.org> References: <20210128180239.548512-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org Some ATA drivers use the SCSI host template, a series of interwoven macros, to aid with initialisation. Some of these macros conflict, resulting in the over-writing of previously set values. This is known behaviour and can be safely ignored. Fixes the following W=1 kernel build warning(s): In file included from drivers/ata/ahci_brcm.c:22: drivers/ata/ahci.h:387:16: warning: initialized field overwritten [-Woverride-init] drivers/ata/ahci_brcm.c:414:2: note: in expansion of macro ‘AHCI_SHT’ drivers/ata/ahci.h:387:16: note: (near initialization for ‘ahci_platform_sht.can_queue’) drivers/ata/ahci_brcm.c:414:2: note: in expansion of macro ‘AHCI_SHT’ drivers/ata/ahci.h:391:17: warning: initialized field overwritten [-Woverride-init] drivers/ata/ahci_brcm.c:414:2: note: in expansion of macro ‘AHCI_SHT’ drivers/ata/ahci.h:391:17: note: (near initialization for ‘ahci_platform_sht.sdev_attrs’) drivers/ata/ahci_brcm.c:414:2: note: in expansion of macro ‘AHCI_SHT’ Cc: Jens Axboe Cc: linux-ide@vger.kernel.org Signed-off-by: Lee Jones --- drivers/ata/Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/ata/Makefile b/drivers/ata/Makefile index cf851f5a4e7fd..a6755a524efa0 100644 --- a/drivers/ata/Makefile +++ b/drivers/ata/Makefile @@ -1,6 +1,7 @@ # SPDX-License-Identifier: GPL-2.0 CFLAGS_acard-ahci.o = $(call cc-disable-warning, override-init) +CFLAGS_ahci_brcm.o = $(call cc-disable-warning, override-init) CFLAGS_ahci_ceva.o = $(call cc-disable-warning, override-init) CFLAGS_ahci_dm816.o = $(call cc-disable-warning, override-init) CFLAGS_ahci_mtk.o = $(call cc-disable-warning, override-init) From patchwork Thu Jan 28 18:02:36 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1432970 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=linux-ide-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=tIoUH1MM; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4DRTFq6FMKz9sW0 for ; Fri, 29 Jan 2021 05:17:03 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231559AbhA1SQq (ORCPT ); Thu, 28 Jan 2021 13:16:46 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32834 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231563AbhA1SGv (ORCPT ); Thu, 28 Jan 2021 13:06:51 -0500 Received: from mail-wr1-x436.google.com (mail-wr1-x436.google.com [IPv6:2a00:1450:4864:20::436]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 777FEC06178B for ; Thu, 28 Jan 2021 10:03:04 -0800 (PST) Received: by mail-wr1-x436.google.com with SMTP id g10so6350179wrx.1 for ; Thu, 28 Jan 2021 10:03:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=BlJPa4weJ+jes2vrsBZmFk9aHoMXb6b/UAhdjjLI1xw=; b=tIoUH1MMZgHPgcFm1H5xu5GhnyoOc6pk1LknTNWKf1oRwOVc068CLd4D+hvcZXd3Dt ZWekkNvjydaiLPrxtaSjQZWwB6pworR01AK+cB7oEEL5CfA9vfOx3l2cYwFWPEmGD5WX /XUfMWHAgo+JLnjCquaGOUWO0E3+vodO+gsmcFkAWrLPeF+8MEPEDMGH9yg5HEp9GXQ+ pNWuR1mkrY1sscEUp1LswyjfN6lD84DZp0la7v5j7tIuyACn7j2ddg4MpbihmbuX7Zim RnZxc6rXRoC14A6KgxJbyA2TXVc2x8e+Gh2mNWBEWqhnzwEMJKWV+Iep3OU9jqog7yQb +2fA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=BlJPa4weJ+jes2vrsBZmFk9aHoMXb6b/UAhdjjLI1xw=; b=TpVvbhG/NKa57Bo9atFMmRap0LcUarkuSezcTlDLrw2Na/VhLoSM0McxnZLBwUSyIw DrDwJ0TuKqy5L/lee3Ez7bwY15QkT+mU4Ooy5OkXLocVVTsxIuRROubtQxq9qgy2e6Lk KTYsIGPurvwkAxwCCFyeFQEIjxI3qeOe4hQoIBmv9hHneMT3TtkoCy+VQ1nKxoJhr5vW ECLfExhACbId1Oq/F9ZoewCsdGRhASJlUHOw1s+AJnBSHNkaKlX0CJNdGw90I0lOHn+3 QWJCiirXVF+w7w0/iZAkp2F2t5ec7+Ve1oHkT2KgjISOY/DGyhbFksP8BxcFganK2WuE kovw== X-Gm-Message-State: AOAM53391H+P+Ya89purk/Ma1GlqP7gORma9UZSjrkHEw9lUyXX+dWld h9XB5Z89bmn72389zZkb+XBt5g== X-Google-Smtp-Source: ABdhPJzCh/6Len5XnN+iFyPGMOmxw2mV+V4tO818WFPny0PyiE6vtR+TA1iztn7KqE0i9aOnTYVTwQ== X-Received: by 2002:adf:80c3:: with SMTP id 61mr357970wrl.100.1611856983215; Thu, 28 Jan 2021 10:03:03 -0800 (PST) Received: from dell.default ([91.110.221.188]) by smtp.gmail.com with ESMTPSA id u6sm8280794wro.75.2021.01.28.10.03.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Jan 2021 10:03:02 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Jens Axboe , Loc Ho , Tuan Phan , Suman Tripathi , linux-ide@vger.kernel.org Subject: [PATCH 17/20] ata: ahci_xgene: Fix incorrect naming of 'xgene_ahci_handle_broken_edge_irq()'s 'host' param Date: Thu, 28 Jan 2021 18:02:36 +0000 Message-Id: <20210128180239.548512-18-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210128180239.548512-1-lee.jones@linaro.org> References: <20210128180239.548512-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/ata/ahci_xgene.c:564: warning: Function parameter or member 'host' not described in 'xgene_ahci_handle_broken_edge_irq' drivers/ata/ahci_xgene.c:564: warning: Excess function parameter 'ata_host' description in 'xgene_ahci_handle_broken_edge_irq' Cc: Jens Axboe Cc: Loc Ho Cc: Tuan Phan Cc: Suman Tripathi Cc: linux-ide@vger.kernel.org Signed-off-by: Lee Jones --- drivers/ata/ahci_xgene.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/ata/ahci_xgene.c b/drivers/ata/ahci_xgene.c index 16246c843365e..dffc432b9d54a 100644 --- a/drivers/ata/ahci_xgene.c +++ b/drivers/ata/ahci_xgene.c @@ -537,7 +537,7 @@ static int xgene_ahci_softreset(struct ata_link *link, unsigned int *class, /** * xgene_ahci_handle_broken_edge_irq - Handle the broken irq. - * @ata_host: Host that recieved the irq + * @host: Host that recieved the irq * @irq_masked: HOST_IRQ_STAT value * * For hardware with broken edge trigger latch From patchwork Thu Jan 28 18:02:37 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1432969 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=linux-ide-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=VOWAoFI7; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4DRTFq2fxDz9sWK for ; Fri, 29 Jan 2021 05:17:03 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231593AbhA1SQq (ORCPT ); Thu, 28 Jan 2021 13:16:46 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32836 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231579AbhA1SGx (ORCPT ); Thu, 28 Jan 2021 13:06:53 -0500 Received: from mail-wr1-x42e.google.com (mail-wr1-x42e.google.com [IPv6:2a00:1450:4864:20::42e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B9392C0611BE for ; Thu, 28 Jan 2021 10:03:05 -0800 (PST) Received: by mail-wr1-x42e.google.com with SMTP id 6so6341814wri.3 for ; Thu, 28 Jan 2021 10:03:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=uUtjn0S2LB1hEBiPsRyILzvTGxsfFgJnwAguVJkwf8M=; b=VOWAoFI7f87mmQpF61/B6XhrpLRiOTDKRgEzgQUruqg8nla/mCupvO58MKBvSqkMGg FCrwCgcHxom4YbO8EwoZlPubu2t9ejuP33iBOTlNe+632hC+nrhvzfROOAV0YUscqN4W ISmw/4ebKvXCCw5NgyawYbvhPd93k/VZ1bFBOGt+uv+BVbZ6DUnQ5KnQeZNmvfjlKpCy gJVhcZwkDBs2PWCHnFn9yo6716dRaWTOXvjY15FcC3PiYWhz4784EPLhTD+x4TwERxhA sxYlwlNERTo6gO3curiKUdKz4Egu2R4wdK3MnMBr0nS9F8YVS2Jm5RgqVuqxHQXQi6DT Xbcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=uUtjn0S2LB1hEBiPsRyILzvTGxsfFgJnwAguVJkwf8M=; b=QMZr2gKS64uw5TjeOnz+b3bJ56W1nHqJ4aLRRhfANSaJkkmEmKGEjf7kNRNPp1TMld E3YjEiRtfYMShCbfkPNqfhQr9PiXAyOCjPWbQj9hXxu52YhbR8blQYHzgdnPOv5N9p9f k588ztsac9DxVSET5d3XbczZWIS7KRnG39sbjW31jqkgbGIql5WgNtR8kLiXigppyimJ dJNoAKg3EiuiFuvd3rDKmzzfPJ131PDoGcSnTL+bQQrm/zAkzOJC8I3YECBZL5Dt00t9 IUZmeiqEnCu41I8QKY+u6U/fNgKoI1C05CvqspTTZGkKMZBEk9o7z1NP5R4NokoEcEta Vd4w== X-Gm-Message-State: AOAM532B0aAtqPaR4t/OECOlJ4xCGteKstht3kwD1+SGxLQOw2TZ2bQo qgR1AlVE31XfiwEQ5geWxjtJtuIzLCknInuJ X-Google-Smtp-Source: ABdhPJxPzc0IA9xahgijtPLfT9dZqdD9ejn57gN/lqF5wwV6CnFzhmlrLK3RGRvHy7StR5WPLMJ2jg== X-Received: by 2002:adf:c109:: with SMTP id r9mr255640wre.261.1611856984478; Thu, 28 Jan 2021 10:03:04 -0800 (PST) Received: from dell.default ([91.110.221.188]) by smtp.gmail.com with ESMTPSA id u6sm8280794wro.75.2021.01.28.10.03.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Jan 2021 10:03:03 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Jens Axboe , Mark Lord , ALWAYS copy Subject: [PATCH 18/20] ata: sata_mv: Fix worthy headers and demote others Date: Thu, 28 Jan 2021 18:02:37 +0000 Message-Id: <20210128180239.548512-19-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210128180239.548512-1-lee.jones@linaro.org> References: <20210128180239.548512-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/ata/sata_mv.c:1162: warning: Function parameter or member 'ap' not described in 'mv_start_edma' drivers/ata/sata_mv.c:1162: warning: Function parameter or member 'port_mmio' not described in 'mv_start_edma' drivers/ata/sata_mv.c:1162: warning: Function parameter or member 'protocol' not described in 'mv_start_edma' drivers/ata/sata_mv.c:1162: warning: Excess function parameter 'base' description in 'mv_start_edma' drivers/ata/sata_mv.c:1535: warning: Function parameter or member 'enable_bmdma' not described in 'mv_bmdma_enable_iie' drivers/ata/sata_mv.c:1535: warning: expecting prototype for mv_bmdma_enable(). Prototype was for mv_bmdma_enable_iie() instead drivers/ata/sata_mv.c:1930: warning: Function parameter or member 'ap' not described in 'mv_bmdma_stop_ap' drivers/ata/sata_mv.c:1930: warning: expecting prototype for mv_bmdma_stop(). Prototype was for mv_bmdma_stop_ap() instead drivers/ata/sata_mv.c:2228: warning: Function parameter or member 'ap' not described in 'mv_send_fis' drivers/ata/sata_mv.c:3263: warning: Function parameter or member 'hpriv' not described in 'mv6_reset_hc' drivers/ata/sata_mv.c:3263: warning: Function parameter or member 'n_hc' not described in 'mv6_reset_hc' drivers/ata/sata_mv.c:3541: warning: Function parameter or member 'hpriv' not described in 'soc_is_65n' drivers/ata/sata_mv.c:3541: warning: expecting prototype for soc_is_65(). Prototype was for soc_is_65n() instead Cc: Jens Axboe Cc: Mark Lord Cc: ALWAYS copy Cc: linux-ide@vger.kernel.org Signed-off-by: Lee Jones --- drivers/ata/sata_mv.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/ata/sata_mv.c b/drivers/ata/sata_mv.c index 664ef658a955f..eafca46d8feb4 100644 --- a/drivers/ata/sata_mv.c +++ b/drivers/ata/sata_mv.c @@ -1146,9 +1146,8 @@ static void mv_set_irq_coalescing(struct ata_host *host, spin_unlock_irqrestore(&host->lock, flags); } -/** +/* * mv_start_edma - Enable eDMA engine - * @base: port base address * @pp: port private data * * Verify the local cache of the eDMA state is accurate with a @@ -1519,7 +1518,7 @@ static void mv_60x1_errata_sata25(struct ata_port *ap, int want_ncq) writel(new, hpriv->base + GPIO_PORT_CTL); } -/** +/* * mv_bmdma_enable - set a magic bit on GEN_IIE to allow bmdma * @ap: Port being initialized * @@ -1919,7 +1918,7 @@ static void mv_bmdma_start(struct ata_queued_cmd *qc) /** * mv_bmdma_stop - Stop BMDMA transfer - * @qc: queued command to stop DMA on. + * @ap: port to stop * * Clears the ATA_DMA_START flag in the bmdma control register * @@ -2221,6 +2220,7 @@ static u8 mv_sff_check_status(struct ata_port *ap) /** * mv_send_fis - Send a FIS, using the "Vendor-Unique FIS" register + * @ap: ATA port to send a FIS * @fis: fis to be sent * @nwords: number of 32-bit words in the fis */ @@ -3249,7 +3249,7 @@ static void mv6_reset_flash(struct mv_host_priv *hpriv, void __iomem *mmio) writel(tmp, mmio + GPIO_PORT_CTL); } -/** +/* * mv6_reset_hc - Perform the 6xxx global soft reset * @mmio: base address of the HBA * @@ -3530,7 +3530,7 @@ static void mv_soc_65n_phy_errata(struct mv_host_priv *hpriv, writel(reg, port_mmio + PHY_MODE9_GEN1); } -/** +/* * soc_is_65 - check if the soc is 65 nano device * * Detect the type of the SoC, this is done by reading the PHYCFG_OFS From patchwork Thu Jan 28 18:02:38 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1432961 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=linux-ide-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=imMgoFtl; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4DRT5V2pkyz9sW0 for ; Fri, 29 Jan 2021 05:09:50 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231614AbhA1SJM (ORCPT ); Thu, 28 Jan 2021 13:09:12 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60624 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231706AbhA1SHI (ORCPT ); Thu, 28 Jan 2021 13:07:08 -0500 Received: from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com [IPv6:2a00:1450:4864:20::42a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 07491C061A28 for ; Thu, 28 Jan 2021 10:03:07 -0800 (PST) Received: by mail-wr1-x42a.google.com with SMTP id 7so6362546wrz.0 for ; Thu, 28 Jan 2021 10:03:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=JAIDQ52yty18Fyb/YeAsOfkiyO3vjgo1F5NJ+/twun8=; b=imMgoFtlkjloJ+OspitfwQCei1PhD4tUkQ8n4W661tybxoH12p9ephNZH/jRUaqGRl 5G77kRHPX4TI9pHwjL2AK3CWnD9htKFzwuEftp/q1nAjFIrQDdAoo1D9J69T+s806X6+ rOI44p2L0yKdO5cgFX9JW0YorcXDy56kJBh6vwDmW1KBzWIIxqYAeGwSLNmvjW9FFfOH 3o2LBirukSDHYozGAycnTpuREqSe50YP3RZNsxMH1kKywBJf2Kq3FlKRZRIg3a41+aY2 jO75FNUh9Jf1ztHPdyxcQBXXeEQZSxOAdu68p0LUMQEf9Qvn8RXUEff3lY/ngv4F1pcQ YluA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=JAIDQ52yty18Fyb/YeAsOfkiyO3vjgo1F5NJ+/twun8=; b=TPHNCe01zL3lqYjkTApIhGkXgc9vztYJCMGmpIskcDskUr2Y+fMLDUsbQbpd+8Quoc lhFfkpw8rDJUhBRIaEzoD/S1W6vJZiDaqko2dm45LkTixlZbw2vB0zDqqZ6LOQktBbho CXmc59CZxY1Mog6Dap4zjAu4PtlPMpUnVq3lL/2qybekLgIILzPcL44VvFXW//UM+35f /dMz1QKd5dbEiCFjiylZZI72yTisLIQWDqaAiGdxaRjUxyQQvK7ernACC0LKZeexZ1tl 4kiSnjMQglivgrUOmeuHJBxKoYNFhY1tMmvdu2lQORPainSeNYdCUjnq5jax/k0el8uI labw== X-Gm-Message-State: AOAM5329T/RmsBTDa/t5x4CeGcrCr9Kz0VwvXRi6OLX6I2R+gcfF9FfI eJK47tXIOv9p6/+EnJzvPM+eAQ== X-Google-Smtp-Source: ABdhPJyVgNtveW+MCIr6+u0POnj/CePkkyGFEb/lmovqSafnYMRpj3kHzr30TDzgukgfeEjN28RSGg== X-Received: by 2002:a5d:524a:: with SMTP id k10mr307969wrc.394.1611856985730; Thu, 28 Jan 2021 10:03:05 -0800 (PST) Received: from dell.default ([91.110.221.188]) by smtp.gmail.com with ESMTPSA id u6sm8280794wro.75.2021.01.28.10.03.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Jan 2021 10:03:05 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Jens Axboe , CJ , Andre Hedrick , Alan Cox , Clear Zhang , linux-ide@vger.kernel.org, and cc Subject: [PATCH 19/20] ata: pata_ali: Supply description for 'ali_20_filter()'s 'mask' param Date: Thu, 28 Jan 2021 18:02:38 +0000 Message-Id: <20210128180239.548512-20-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210128180239.548512-1-lee.jones@linaro.org> References: <20210128180239.548512-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/ata/pata_ali.c:119: warning: Function parameter or member 'mask' not described in 'ali_20_filter' Cc: Jens Axboe Cc: CJ Cc: Andre Hedrick Cc: Alan Cox Cc: Clear Zhang Cc: linux-ide@vger.kernel.org Cc: and cc Signed-off-by: Lee Jones --- drivers/ata/pata_ali.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/ata/pata_ali.c b/drivers/ata/pata_ali.c index e18aa02f89530..557ecf4661022 100644 --- a/drivers/ata/pata_ali.c +++ b/drivers/ata/pata_ali.c @@ -109,7 +109,7 @@ static int ali_c2_cable_detect(struct ata_port *ap) /** * ali_20_filter - filter for earlier ALI DMA * @adev: ATA device - * @adev: attached device + * @mask: received mask to manipulate and pass back * * Ensure that we do not do DMA on CD devices. We may be able to * fix that later on. Also ensure we do not do UDMA on WDC drives From patchwork Thu Jan 28 18:02:39 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1432963 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=linux-ide-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=XxpSF2uP; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4DRTCy0ySVz9sWK for ; Fri, 29 Jan 2021 05:15:25 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231678AbhA1SPC (ORCPT ); Thu, 28 Jan 2021 13:15:02 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32958 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231436AbhA1SHV (ORCPT ); Thu, 28 Jan 2021 13:07:21 -0500 Received: from mail-wr1-x433.google.com (mail-wr1-x433.google.com [IPv6:2a00:1450:4864:20::433]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E2003C061A2A for ; Thu, 28 Jan 2021 10:03:07 -0800 (PST) Received: by mail-wr1-x433.google.com with SMTP id c12so6334146wrc.7 for ; Thu, 28 Jan 2021 10:03:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=uLTjdVY72aKyqSF59N/uJRYV12gUSHg1TskoZb+zwxc=; b=XxpSF2uP2v0W9RW2VCJqhChGAX6WSCAXs6w4ijZe6v+12yrVxLzHWT1Ec/Q+f/FtXI 9HqklksJde6eMBy/0MI4UQM5rIzajbYvZgaXfZv1WnfdVhfWIadYljnqt0OGCCgOgex4 kYi6InAkGU0oFT0kDeOzCT+T/eYaBP8f/ATqDzUoD2dJ8ZBTmZsjNw28UDwA2i30psU7 QjTanU5sTVW7sPPBj6jpc+3Ct+XEYM6sH+DrHzWoXx2ysWqds68bJPs1xsvqbBsqszxJ ctswyt4WdjEGjUELBK2BBMQNfdqOv/aNhV7mWh0K0JpxUZbLVLQBV/OJPzqMr4dnsFdl kXzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=uLTjdVY72aKyqSF59N/uJRYV12gUSHg1TskoZb+zwxc=; b=RYbdgY29y4vwDOX5dKZd+pd+Vu4l8IvV4Hd0BUAht78smr3gF9ARo3yBBSmLztOpBj YILnX5ylQSXxUMQM3cLDkN0nWuQWJZ3KgRyJtV+cHNcNSVRWRwn2ZeKP4WKIqHb7fJc/ Xc8S/ip63x4IVdv6p2+jH2VQ1pksbHmdP3pOyrPY81x8jyjUYAFFKrcjl6s07SBeJ3Yh 9GDBZ+4OIKt+wofoIwUk+S/aerSa2I6QN4kchMSmNdT9tcHXcLEoIzf0vKuC7cx0m40U 6dIn9HVeZI85dm6T4Qvve60e53+nEXH0jFB4jMu1x6aczVDlrGRvG3lSL8L4Tf+3hpJi yBHQ== X-Gm-Message-State: AOAM5325a9dOyQ953YoU8i6i+UADcL1Syn01AQt2qyIPa6rulVJZH02U qB+cp2pqfa0RvtqIHp3t9xx48A== X-Google-Smtp-Source: ABdhPJyWSuYrKMWdaIv71fSya9X1MGXlIYeadHHN2MFhUwF+tSJksHr5Ryna9O09obzzpWv9VnBglg== X-Received: by 2002:a5d:6044:: with SMTP id j4mr247434wrt.287.1611856986700; Thu, 28 Jan 2021 10:03:06 -0800 (PST) Received: from dell.default ([91.110.221.188]) by smtp.gmail.com with ESMTPSA id u6sm8280794wro.75.2021.01.28.10.03.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Jan 2021 10:03:06 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Jens Axboe , linux-ide@vger.kernel.org Subject: [PATCH 20/20] ata: ahci: Ignore -Woverride-init Date: Thu, 28 Jan 2021 18:02:39 +0000 Message-Id: <20210128180239.548512-21-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210128180239.548512-1-lee.jones@linaro.org> References: <20210128180239.548512-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org Some ATA drivers use the SCSI host template, a series of interwoven macros, to aid with initialisation. Some of these macros conflict, resulting in the over-writing of previously set values. This is known behaviour and can be safely ignored. Fixes the following W=1 kernel build warning(s): In file included from drivers/ata/ahci.c:35: drivers/ata/ahci.h:387:16: warning: initialized field overwritten [-Woverride-init] drivers/ata/ahci.c:104:2: note: in expansion of macro ‘AHCI_SHT’ drivers/ata/ahci.h:387:16: note: (near initialization for ‘ahci_sht.can_queue’) drivers/ata/ahci.c:104:2: note: in expansion of macro ‘AHCI_SHT’ drivers/ata/ahci.h:391:17: warning: initialized field overwritten [-Woverride-init] drivers/ata/ahci.c:104:2: note: in expansion of macro ‘AHCI_SHT’ drivers/ata/ahci.h:391:17: note: (near initialization for ‘ahci_sht.sdev_attrs’) drivers/ata/ahci.c:104:2: note: in expansion of macro ‘AHCI_SHT’ Cc: Jens Axboe Cc: linux-ide@vger.kernel.org Signed-off-by: Lee Jones --- drivers/ata/Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/ata/Makefile b/drivers/ata/Makefile index a6755a524efa0..4580a0306bf3d 100644 --- a/drivers/ata/Makefile +++ b/drivers/ata/Makefile @@ -1,6 +1,7 @@ # SPDX-License-Identifier: GPL-2.0 CFLAGS_acard-ahci.o = $(call cc-disable-warning, override-init) +CFLAGS_ahci.o = $(call cc-disable-warning, override-init) CFLAGS_ahci_brcm.o = $(call cc-disable-warning, override-init) CFLAGS_ahci_ceva.o = $(call cc-disable-warning, override-init) CFLAGS_ahci_dm816.o = $(call cc-disable-warning, override-init)