From patchwork Mon Jan 18 21:32:49 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Adam Ford X-Patchwork-Id: 1428311 X-Patchwork-Delegate: sbabic@denx.de Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=85.214.62.61; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=YtrSOO0O; dkim-atps=neutral Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4DKQ4r3YQjz9sT6 for ; Tue, 19 Jan 2021 08:33:16 +1100 (AEDT) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 8E17F82854; Mon, 18 Jan 2021 22:33:11 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="YtrSOO0O"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id CEE7E8289B; Mon, 18 Jan 2021 22:33:09 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE autolearn=ham autolearn_force=no version=3.4.2 Received: from mail-io1-xd2f.google.com (mail-io1-xd2f.google.com [IPv6:2607:f8b0:4864:20::d2f]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 1C9E9827E5 for ; Mon, 18 Jan 2021 22:33:07 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=aford173@gmail.com Received: by mail-io1-xd2f.google.com with SMTP id x21so17399828iog.10 for ; Mon, 18 Jan 2021 13:33:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=EzJx4/K9k2cqBQATX5A1dR2gwxPV8g4czpfh7JjEGlU=; b=YtrSOO0OAKEvPQj7xHJRfUzpre+DYyB+qHvBXv+kuBISsbfmOSJKbNVmYqm7XpVNf5 J7S/2HL5FoPw8XbNAyYoqTVttQhP/MH5VPSUtyydgYAejJfdu3GpnJgTX2c65T5WxKaL aTcpJABAPCtRCfKXQCDr291ZSlWG20WYAjhtzbjVME4dsFpNwGMBcwxBWdNXMDuSjtmD HSbXfuhvLp+fs3TVZMfFYdY/gNpGn8s/J/P64R++kcY3uJDp/JtQ8Ty1hWqmqsQr/pA0 il+EnfedgGpHkfL2phiWQefmd1UdHlrAlaLlmoOnrdmthCJQkGqmopZvDxblCdPA/ZGz xy1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=EzJx4/K9k2cqBQATX5A1dR2gwxPV8g4czpfh7JjEGlU=; b=NXTPmeiQNxmjvpBovPxyKHVIwoQEW6dbvgjWR3F4I6TotlJcwW4YzFiRzylYvJBEGx 99c5ivBGJ1enGzt3+vhPgfoGkJuf9OkaXO/5aqOyJFSG+4QIxwrf855fJAJlY7/L/AaG Ozr6wq1xXqn+AFq7H6eDDO04ifJauc7QfOGizS79BacmUOeeqQAR01sfB+IgavpPo/8n P4TMtfE0x6Ex7GebggjL9L46gIreoTQXI6lMWTu5e8uMEnVzlIAvIsjM1jj3SNdmLhiM W4DFrryJnRWlX0Pcg7aHpcu8wJkM5Hj7BSdt4GjWrebQQAitMFO09sD2xkvi8iUap6ju 6K4A== X-Gm-Message-State: AOAM532C37M6v8H7IX/gEhwIgcxSbP0nGQVpPKPH3liyrIF6tLLNyuOg nGNXIEn+0tKKvzUjk0T/yR1m4SH7yfJsZw== X-Google-Smtp-Source: ABdhPJyBhJIFT79xP1M52VwJ0Xbmhiifvi5UpJjrBefmSNhTuFEs/dabL5a/qP9YWVMUaaJ0vpAfTA== X-Received: by 2002:a05:6e02:1aab:: with SMTP id l11mr935154ilv.300.1611005585458; Mon, 18 Jan 2021 13:33:05 -0800 (PST) Received: from aford-IdeaCentre-A730.lan ([2601:448:8400:9e8:7d19:4333:ea49:585b]) by smtp.gmail.com with ESMTPSA id v18sm4881859ila.29.2021.01.18.13.33.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Jan 2021 13:33:04 -0800 (PST) From: Adam Ford To: u-boot@lists.denx.de Cc: jagan@amarulasolutions.com, aford@beaconembedded.com, Adam Ford Subject: [PATCH 1/2] spi: nxp_fspi: Fix error reporting Date: Mon, 18 Jan 2021 15:32:49 -0600 Message-Id: <20210118213250.727994-1-aford173@gmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.102.3 at phobos.denx.de X-Virus-Status: Clean On the i.MX8M Mini, ret = clk_set_rate() sets ret to the value of the rate the clock was able to set. When checking for errors, it only checks that it is not NULL. Since positive numbers are not errors, only check for negative numbers when handling errors. Fixes: 383fded70c4f ("spi: nxp_fspi: new driver for the FlexSPI controller") Signed-off-by: Adam Ford Reviewed-by: Pratyush Yadav diff --git a/drivers/spi/nxp_fspi.c b/drivers/spi/nxp_fspi.c index 006dd04b9e..d74561578a 100644 --- a/drivers/spi/nxp_fspi.c +++ b/drivers/spi/nxp_fspi.c @@ -815,7 +815,7 @@ static int nxp_fspi_default_setup(struct nxp_fspi *f) /* the default frequency, we will change it later if necessary. */ ret = clk_set_rate(&f->clk, 20000000); - if (ret) + if (ret < 0) return ret; ret = nxp_fspi_clk_prep_enable(f); @@ -906,7 +906,7 @@ static int nxp_fspi_set_speed(struct udevice *bus, uint speed) nxp_fspi_clk_disable_unprep(f); ret = clk_set_rate(&f->clk, speed); - if (ret) + if (ret < 0) return ret; ret = nxp_fspi_clk_prep_enable(f); From patchwork Mon Jan 18 21:32:50 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Adam Ford X-Patchwork-Id: 1428312 X-Patchwork-Delegate: sbabic@denx.de Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=85.214.62.61; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=NHodjmC5; dkim-atps=neutral Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4DKQ503yp1z9sVR for ; Tue, 19 Jan 2021 08:33:24 +1100 (AEDT) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 92813828A8; Mon, 18 Jan 2021 22:33:15 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="NHodjmC5"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 2374E8287D; Mon, 18 Jan 2021 22:33:11 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE autolearn=ham autolearn_force=no version=3.4.2 Received: from mail-io1-xd2e.google.com (mail-io1-xd2e.google.com [IPv6:2607:f8b0:4864:20::d2e]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 35FF182854 for ; Mon, 18 Jan 2021 22:33:08 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=aford173@gmail.com Received: by mail-io1-xd2e.google.com with SMTP id p72so10839463iod.12 for ; Mon, 18 Jan 2021 13:33:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=3VdOvWXINycJEsgF+sZsB3LXsI52+Q9CrIJeQTDX4Os=; b=NHodjmC5X/vWUUutk3zsdHtByQA+ho5ybGav5JYgh95p6el8lSC5y8MOt0jplEOj1K NCpM96gfH1PS9EkHFa6HbJtAmLrsshant2dT90sC0ZqtcNfiGuGPZo7tKMcYNnKRuh00 rpDZx5s/uwnyZrybdo5EfzF86XOGBWZ73cxvo97SVhayI2FrldcbW1g7K22LWanf+4gZ wAw9wYOW4nRNviBGU7RdoNVbl2IShsAoo4+ZSRMMwSYkRphvHKFfqIaop54TTSfq81cj hwKw/17YKQML6JmbZlJgx/DBHaAfjxcQaLt/Jn3tApebHQt8qIR0smiGUN868shOaKka b2XA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=3VdOvWXINycJEsgF+sZsB3LXsI52+Q9CrIJeQTDX4Os=; b=JjkZiYBZvKJXdOARbpry2UdWu3IP1fPLaxEt09o1RaOFsv7UPYHeTXlGLpuEJKkEYP pY4/2ay+0NTpwM+4KSxRRCyZfiD0L27nASIXmmYadPOQKVIavP173DFE2S3btxbQzFCA IxOEgbyV/O/gmNAD0hpZsPu4U8/sfzSglO7XMy9mW28dWI5FOP7dODnwPCSggpwPpckS /dOd6QgEV6LI0UJ17+cfi1Y4dYsrAF7pgxpUNJeIdbgL1Zi7rzLMCi5eiiNBei3AXV65 Vdzx+gWPc0aK7n2JsOH6W+pd7LTQzu+mwIwr5e8CKcFg5YWOMYnJE+GdwbzY6n7UaY0h mfxg== X-Gm-Message-State: AOAM532JtXPLTxUW8B6mSxBVnW3dj+Vtfh/5tud4iL0qEnMLVlxdLpWY dHoUPYfzyo4AweqfDhZcw2OeOQRStkoLxA== X-Google-Smtp-Source: ABdhPJyNt1C8jExD6oDDOSjvLbCd6dCFjvBCooZB6wFhcXlmU6kjgB83eZhWY9ntW49YNFUj3Nlciw== X-Received: by 2002:a92:48c5:: with SMTP id j66mr877018ilg.230.1611005586673; Mon, 18 Jan 2021 13:33:06 -0800 (PST) Received: from aford-IdeaCentre-A730.lan ([2601:448:8400:9e8:7d19:4333:ea49:585b]) by smtp.gmail.com with ESMTPSA id v18sm4881859ila.29.2021.01.18.13.33.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Jan 2021 13:33:05 -0800 (PST) From: Adam Ford To: u-boot@lists.denx.de Cc: jagan@amarulasolutions.com, aford@beaconembedded.com, Adam Ford Subject: [PATCH 2/2] spi: nxp_fspi: Enable support for nxp,imx8mm-fspi Date: Mon, 18 Jan 2021 15:32:50 -0600 Message-Id: <20210118213250.727994-2-aford173@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210118213250.727994-1-aford173@gmail.com> References: <20210118213250.727994-1-aford173@gmail.com> MIME-Version: 1.0 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.102.3 at phobos.denx.de X-Virus-Status: Clean The i.MX8M Mini can use the FlexSPI driver. Add support for it to the driver. Signed-off-by: Adam Ford diff --git a/drivers/spi/nxp_fspi.c b/drivers/spi/nxp_fspi.c index d74561578a..6c5bad4c2c 100644 --- a/drivers/spi/nxp_fspi.c +++ b/drivers/spi/nxp_fspi.c @@ -320,6 +320,14 @@ static const struct nxp_fspi_devtype_data lx2160a_data = { .little_endian = true, /* little-endian */ }; +static const struct nxp_fspi_devtype_data imx8mm_data = { + .rxfifo = SZ_512, /* (64 * 64 bits) */ + .txfifo = SZ_1K, /* (128 * 64 bits) */ + .ahb_buf_size = SZ_2K, /* (256 * 64 bits) */ + .quirks = 0, + .little_endian = true, /* little-endian */ +}; + struct nxp_fspi { struct udevice *dev; void __iomem *iobase; @@ -985,6 +993,7 @@ static const struct dm_spi_ops nxp_fspi_ops = { static const struct udevice_id nxp_fspi_ids[] = { { .compatible = "nxp,lx2160a-fspi", .data = (ulong)&lx2160a_data, }, + { .compatible = "nxp,imx8mm-fspi", .data = (ulong)&imx8mm_data, }, { } };