From patchwork Mon Jan 11 05:56:13 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: wenxu X-Patchwork-Id: 1424421 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org (client-ip=140.211.166.137; helo=fraxinus.osuosl.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=ucloud.cn Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4DDjd85Xmjz9sWj for ; Mon, 11 Jan 2021 16:56:28 +1100 (AEDT) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id 23B8D85BE4; Mon, 11 Jan 2021 05:56:27 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 9sPShk_QVRar; Mon, 11 Jan 2021 05:56:25 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by fraxinus.osuosl.org (Postfix) with ESMTP id 4456485B09; Mon, 11 Jan 2021 05:56:25 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 26259C0893; Mon, 11 Jan 2021 05:56:25 +0000 (UTC) X-Original-To: dev@openvswitch.org Delivered-To: ovs-dev@lists.linuxfoundation.org Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by lists.linuxfoundation.org (Postfix) with ESMTP id 90200C013A for ; Mon, 11 Jan 2021 05:56:23 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 7C06F20490 for ; Mon, 11 Jan 2021 05:56:23 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id X3CQd3e1Hxk4 for ; Mon, 11 Jan 2021 05:56:22 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from m9785.mail.qiye.163.com (m9785.mail.qiye.163.com [220.181.97.85]) by silver.osuosl.org (Postfix) with ESMTPS id B8E042041C for ; Mon, 11 Jan 2021 05:56:21 +0000 (UTC) Received: from localhost.localdomain (unknown [123.59.132.129]) by m9785.mail.qiye.163.com (Hmail) with ESMTPA id 91B115C1D96; Mon, 11 Jan 2021 13:56:13 +0800 (CST) From: wenxu@ucloud.cn To: simon.horman@netronome.com Date: Mon, 11 Jan 2021 13:56:13 +0800 Message-Id: <1610344573-15780-1-git-send-email-wenxu@ucloud.cn> X-Mailer: git-send-email 1.8.3.1 X-HM-Spam-Status: e1kfGhgUHx5ZQUtXWQgYFAkeWUFZS1VLWVdZKFlBSUI3V1ktWUFJV1kPCR oVCBIfWUFZHU0YGEpNGEkaTUxKVkpNSktIT09OTEhMSktVGRETFhoSFyQUDg9ZV1kWGg8SFR0UWU FZT0tIVUpKS0hKQ1VLWQY+ X-HM-Sender-Digest: e1kMHhlZQR0aFwgeV1kSHx4VD1lBWUc6PEk6MDo6ST0xEBFCSQsrLgFK KCtPCh9VSlVKTUpLSE9PTkxIQk9IVTMWGhIXVQweFQMOOw4YFxQOH1UYFUVZV1kSC1lBWUpJSFVO QlVKSElVSklCWVdZCAFZQUpIQ0s3Bg++ X-HM-Tid: 0a76f0042abb2087kuqy91b115c1d96 Cc: dev@openvswitch.org Subject: [ovs-dev] [PATCH] netdev-offload-tc: UNSUPPORT for the OVS_CS_F_INVALID ct_state flag X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: ovs-dev-bounces@openvswitch.org Sender: "dev" From: wenxu TC flower do't support the INVALID ct state flag. So it is better to reject this rule but not just ignore this flag. Signed-off-by: wenxu --- lib/netdev-offload-tc.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/lib/netdev-offload-tc.c b/lib/netdev-offload-tc.c index 717a987..9b277b0 100644 --- a/lib/netdev-offload-tc.c +++ b/lib/netdev-offload-tc.c @@ -1651,6 +1651,10 @@ netdev_tc_flow_put(struct netdev *netdev, struct match *match, } if (mask->ct_state) { + if (mask->ct_state & OVS_CS_F_INVALID) { + return EOPNOTSUPP; + } + if (mask->ct_state & OVS_CS_F_NEW) { if (key->ct_state & OVS_CS_F_NEW) { flower.key.ct_state |= TCA_FLOWER_KEY_CT_FLAGS_NEW;