From patchwork Mon Jan 8 20:36:48 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kamal Dasu X-Patchwork-Id: 857113 X-Patchwork-Delegate: boris.brezillon@free-electrons.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.infradead.org (client-ip=65.50.211.133; helo=bombadil.infradead.org; envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="SJMKKAZ2"; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="K3GjHfwU"; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3zFnBs3l7dz9s4q for ; Tue, 9 Jan 2018 07:37:25 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Owner; bh=s6KrRbQXufHUa9Zj+buF0BgfbSd6MWMYfFE5SwqdUNg=; b=SJM KKAZ2/iHxHr7ViIMZKd0YWxcL+D7ezNkPb05mYtMTW/IeGKnbc7INsYbuFGziKikfAibwLiCuGl5I KwaI8+FapwM/Pr05bVYsWB1Hlb2u5mseSgm7BYqIUX0RGRzl1d2drw98y5UilBiyxjAx/mIhyn4Pe 5xY+zlNNZKu0IsX1frGqFKDBKBqoZvHX5oXLatLN3BwWFJ/Ux7WMpEbytCp+uYwKQpFpMPXB87r+M BfYtfqbAochJeXaqbd+T0rB4lE0AwhbV88WS5QgQoIwFClUljKdt8NJ/ygcm7t/YZqOpdgdmmRTmP xYmFKKf21xsAhfaDm8AyoA4bbKcGA3A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.89 #1 (Red Hat Linux)) id 1eYeAY-0001Rt-MR; Mon, 08 Jan 2018 20:37:18 +0000 Received: from mail-qk0-x244.google.com ([2607:f8b0:400d:c09::244]) by bombadil.infradead.org with esmtps (Exim 4.89 #1 (Red Hat Linux)) id 1eYeAV-0001Mf-6Y for linux-mtd@lists.infradead.org; Mon, 08 Jan 2018 20:37:17 +0000 Received: by mail-qk0-x244.google.com with SMTP id o126so15836122qke.12 for ; Mon, 08 Jan 2018 12:37:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=+G2KIYH372zAOGjkV4EllE2eJRG7QAkhcQcIYhaJ8m4=; b=K3GjHfwUNtGWxDLlirBXMN/Zzph9eZtl2C17bpUTU6GGW26rpT5t3UUgnAukr5F40D SP9EgUToNRfTmhTd6zw7W7eKPy1nITh5bQ5fZsRqWk2VDwYoh140QfQ9Kf3EkrZFExWo IPjgR5sr/YQFVDoixyQtrys0r/9eV9RLK1hgTc7X90mrdy75aSlfXEdPIXY4qNNGWfs6 /bolo2jH8qIx0fDp8/f0LmyLAp20zjy23bxIx5JmC9DiNpXTDKw1tVkFcT7WzEfQk3iE HeW18PMbXju9mxCPXVR0h7IgCA8tMBKjStOxC7/12hV3Is5mwRsnoQvn+pZRUp+Oxfs8 UfKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=+G2KIYH372zAOGjkV4EllE2eJRG7QAkhcQcIYhaJ8m4=; b=rDBCo1SbpFak7OTCpyBwzbKAZQzgify7jcVHR8ybik8h3STXVznvd3pENgV+xw3soX V1pb2S64yffCvFzSB1GUXXuX/V8/OPrt0FALxa4iVm7jHo/MqzokMR3+2AAfEe0ZABxa EVy8gNnx1OfgmNCQDVI0YCUEPRvJZ2iu/a72FWrA2PUcvG7vtmgXbPBP7VR1Cq+DGH0D B8hVT1WPARB2vxRW9kGa1ZH3HLJwWuDy0iv7fSSFXktyddZ6LjhURfUt2WztuUNe6Sbt 4n+S/85poEOYQQqXutPcOknGhLxX7nmbGwUBOEePtxXzISOgjZrCo9ToVwU1TRXLO4PV sJPw== X-Gm-Message-State: AKwxytcTha1A+6rLO702NBkgKhHZyaxWbvpEOvPgKpzbuEJeZMo3N3cD X3m6D2Gl+aJoYZhlDP4W6Wc= X-Google-Smtp-Source: ACJfBou/pdJxOPdtUteNKPy3eWKyY96P/T9a1T3zQTwGBbVXTzY2QbwO+q2Joi1sYb9Lk4Asd3WRzg== X-Received: by 10.55.174.67 with SMTP id x64mr18581146qke.55.1515443823716; Mon, 08 Jan 2018 12:37:03 -0800 (PST) Received: from mail.broadcom.com ([192.19.231.250]) by smtp.gmail.com with ESMTPSA id o5sm8111708qtc.72.2018.01.08.12.37.02 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 08 Jan 2018 12:37:03 -0800 (PST) From: Kamal Dasu To: boris.brezillon@free-electrons.com, linux-mtd@lists.infradead.org, bcm-kernel-feedback-list@broadcom.com Subject: [PATCH v3] mtd: nand: brcmnand: Disable prefetch by default Date: Mon, 8 Jan 2018 15:36:48 -0500 Message-Id: <1515443808-31105-1-git-send-email-kdasu.kdev@gmail.com> X-Mailer: git-send-email 2.7.4 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180108_123715_319865_0715D21D X-CRM114-Status: UNSURE ( 7.64 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -2.0 (--) X-Spam-Report: SpamAssassin version 3.4.1 on bombadil.infradead.org summary: Content analysis details: (-2.0 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [2607:f8b0:400d:c09:0:0:0:244 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (kdasu.kdev[at]gmail.com) -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kamal Dasu , richard@nod.at, stable@vger.kernel.org, marek.vasut@gmail.com, cyrille.pitchen@wedev4u.fr, computersforpeace@gmail.com, dwmw2@infradead.org MIME-Version: 1.0 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org Brcm nand controller prefetch feature needs to be disabled by default. Enabling affects performance on random reads as well as dma reads. Signed-off-by: Kamal Dasu Fixes: 27c5b17cd1b1 ("mtd: nand: add NAND driver "library" for Broadcom STB NAND controller") Cc: stable@vger.kernel.org Acked-by: Florian Fainelli --- drivers/mtd/nand/brcmnand/brcmnand.c | 13 +++---------- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/drivers/mtd/nand/brcmnand/brcmnand.c b/drivers/mtd/nand/brcmnand/brcmnand.c index dd56a67..2a978d9 100644 --- a/drivers/mtd/nand/brcmnand/brcmnand.c +++ b/drivers/mtd/nand/brcmnand/brcmnand.c @@ -2193,16 +2193,9 @@ static int brcmnand_setup_dev(struct brcmnand_host *host) if (ctrl->nand_version >= 0x0702) tmp |= ACC_CONTROL_RD_ERASED; tmp &= ~ACC_CONTROL_FAST_PGM_RDIN; - if (ctrl->features & BRCMNAND_HAS_PREFETCH) { - /* - * FIXME: Flash DMA + prefetch may see spurious erased-page ECC - * errors - */ - if (has_flash_dma(ctrl)) - tmp &= ~ACC_CONTROL_PREFETCH; - else - tmp |= ACC_CONTROL_PREFETCH; - } + if (ctrl->features & BRCMNAND_HAS_PREFETCH) + tmp &= ~ACC_CONTROL_PREFETCH; + nand_writereg(ctrl, offs, tmp); return 0;