From patchwork Thu Dec 3 04:57:41 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pragnesh Patel X-Patchwork-Id: 1410154 X-Patchwork-Delegate: trini@ti.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=85.214.62.61; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=sifive.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=sifive.com header.i=@sifive.com header.a=rsa-sha256 header.s=selector1 header.b=jEtMUH5Z; dkim-atps=neutral Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4CmkCH0nfwz9sRK for ; Thu, 3 Dec 2020 15:59:23 +1100 (AEDT) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 261098271E; Thu, 3 Dec 2020 05:59:17 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=sifive.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=sifive.com header.i=@sifive.com header.b="jEtMUH5Z"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 134D482744; Thu, 3 Dec 2020 05:59:15 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FORGED_SPF_HELO,MSGID_FROM_MTA_HEADER, SPF_HELO_PASS autolearn=no autolearn_force=no version=3.4.2 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on20618.outbound.protection.outlook.com [IPv6:2a01:111:f400:7e88::618]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id AB230825DE for ; Thu, 3 Dec 2020 05:59:11 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=sifive.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=pragnesh.patel@openfive.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IRzkpdNS6ArTw0GdvEi9fjDWsKsoZGdDpHYCVCb/cdUkkoiHQnOnIIppR8IzzGuq8pO5S5J4F5bxrmjOa6A6TEGEXs6cRX7fnpEwW5gNaIaDCXtsqY+oW+vuvNe1WCsNZA8Ts13IaYuqHAZsmPqRzc07ps/Fx8bKyVUIK8HZLTVy0qYdPS9xkPS/MXDhoO5vDkkJNjY+Wz7X56vqTvfNt/qj1mvdpHnb1nGZRX5JVnXLd1qRO2CZxIFDKXYHKM6MywzKfkqfgHH15vsLTxTVwSnDQN6pijhfmIAuvlWEB2mdc6iXuU/n3fNrYIDa1rqnc+LjTpRu2LwodHhaHMdSmA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6KW0yu7o3NctDSSaNHYY835It9UxoYLiTORmhDY/DBo=; b=eouerIvwcwy44UrlXtx16XM030SgB36P//MoCaa1tU+TgFRmuYnUUDFOvYNe5YoHlNfRrwVdM4Z4UrZVH3ozJ7U9yE5Pg7qyYsWbSx4SczZ9X7NduV9WJD3M9XxZ7uWKH/SxzM2tXNNkuLQOoRdTLC61CZkGVVu9EqDqi7v5lHcfD3jrL6wWpZZg2FIujMcOUVIz/NPVzJyhb1xfp9I+hpf5kNBMSwH18yrjAuQ+S8eFQvG8H8d02R1Ts26AU7jWlprqhZfTE05VNf79NSDfO8OmcjZIyU5ppD0KaG92u2zfKYG68+oWxhYwNb9swNck+VYs3ZeQGigYX4mQZtNIdw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=openfive.com; dmarc=pass action=none header.from=sifive.com; dkim=pass header.d=sifive.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6KW0yu7o3NctDSSaNHYY835It9UxoYLiTORmhDY/DBo=; b=jEtMUH5ZA0u1P9iwipLdk146wNQr0FCl/osFO/tSyMt+DOavy6Sp8kedjyG3HojCsYk23Gg5BhmVpLTT/y2n4ByXJaaUYi8GZ5YfOv8KYBj36aNF6zyqGrWsehlPmI9A36jb1C/6OaK3HIctwLRV80B0Ez0Agu3LAD3aowJaN10= Authentication-Results: lists.denx.de; dkim=none (message not signed) header.d=none;lists.denx.de; dmarc=none action=none header.from=sifive.com; Received: from MN2PR13MB2797.namprd13.prod.outlook.com (2603:10b6:208:f2::30) by MN2PR13MB4381.namprd13.prod.outlook.com (2603:10b6:208:181::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3632.19; Thu, 3 Dec 2020 04:59:06 +0000 Received: from MN2PR13MB2797.namprd13.prod.outlook.com ([fe80::390d:16fc:b871:f82e]) by MN2PR13MB2797.namprd13.prod.outlook.com ([fe80::390d:16fc:b871:f82e%4]) with mapi id 15.20.3632.019; Thu, 3 Dec 2020 04:59:06 +0000 From: Pragnesh Patel To: u-boot@lists.denx.de Cc: atish.patra@wdc.com, palmerdabbelt@google.com, bmeng.cn@gmail.com, paul.walmsley@sifive.com, anup.patel@wdc.com, sagar.kadam@sifive.com, rick@andestech.com, Pragnesh Patel , Simon Glass , Naoki Hayama , Marek Vasut , Patrick Delaunay , Adam Ford , Thomas Hebb , Ramon Fried , Heinrich Schuchardt , Bin Meng , Sam Protsenko , Miquel Raynal , =?utf-8?q?Fr=C3=A9d=C3=A9ric_Dan?= =?utf-8?q?is?= , Philippe Reynes , Patrice Chotard , Baruch Siach , Vladimir Olovyannikov Subject: [RESEND,PATCH v3] cmd: Add a pwm command Date: Thu, 3 Dec 2020 10:27:41 +0530 Message-Id: <20201203045743.11501-1-pragnesh.patel@sifive.com> X-Mailer: git-send-email 2.17.1 X-Originating-IP: [49.248.91.34] X-ClientProxiedBy: LO2P123CA0025.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600::13) To MN2PR13MB2797.namprd13.prod.outlook.com (2603:10b6:208:f2::30) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from sachinj2-OptiPlex-7010.open-silicon.com (49.248.91.34) by LO2P123CA0025.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3632.17 via Frontend Transport; Thu, 3 Dec 2020 04:59:00 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: acb78128-3351-4bb8-82af-08d897482973 X-MS-TrafficTypeDiagnostic: MN2PR13MB4381: X-LD-Processed: 22f88e9d-ae0d-4ed9-b984-cdc9be1529f1,ExtAddr X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:2449; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: dtj1G/M+V+StP80nJtkxBu51RqfmM4hTq7vETZ2PW0foyBxnaBPl4mETzxFw5t9Gil0tgZKlX8xw4LG7DQK1WV3pp2wP4jaLzyyYk7EJKyWV5T0iDGSmDQsFhrMbxzJsF3fH4e42e3wY2pPOm0ya8bByfwzjm10rMy/w86UJi+rE0PF5Okln5yNiz3bmMYbAEGODhhdFUjM5eu8XGymlyoo0pSrzK9yqI3PfRFQZQprGpbgII4PvqDS+jnIqM8II6opwcPhi4GnNUJWjXxPNXDpHQHkR5V+CohxKh1hn48y93mF05UN1e0X9b40cN4S4v58fbGjS3tfNpd9WUwE+8g== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR13MB2797.namprd13.prod.outlook.com; PTR:; CAT:NONE; SFS:(396003)(39840400004)(376002)(346002)(136003)(366004)(7416002)(26005)(478600001)(54906003)(5660300002)(55236004)(4326008)(52116002)(83380400001)(6506007)(83170400001)(8676002)(1076003)(2616005)(956004)(1006002)(6512007)(6486002)(8936002)(44832011)(186003)(16526019)(6916009)(36756003)(316002)(2906002)(66476007)(42882007)(6666004)(66946007)(66556008); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: nS5cTs5z6XfLiSlx3au8Ia1pIPS0AAw+qbsnajeJoleV9EmIRND7C5d3kbzrTs5ZzBfOg57NI3kN6rd2DIE+cuqanHH8Zs1CQymEYn9tIALRTIUAiez2Eblq0TZIS0/SZ2ULWcMlv1dsAI/7J3g/C70mTkc3Bl80+WJD6rl2g5HX+/uyFW3grXN6kg1xiiqGGFySEq7cl0x01b0J9/Kf83O5Foioi8m02DyhBw84dPS+wWJDxaoEf0e44q928PSGYT0svfH+g1qMDPGi2ZajZSFK73wVXMuP+l0rhr51a4YCA80FdyvEWbA59GXuMmZH7Ftkifv5H9J6dnqkxgV7OBzSMOTmmpLRaWXVLkcOdaF4/OgvVp4aSkvPMNF2DsHhL1/mJyS/1fNfV/ehXLeuWBKegHuHaBRCHZZ4zgvW6tLuVCbse5KBzu0bpZ3be9OMbMz93OJheNyiocARPqXjs7kOJzeiEsi+P5N6P/lcCu86KsilgmQbQGgmSDPCbwwqrpI6xCOyDxTNzl52DSDY3mcCrmThzWiTi7b2rjxMcjymXX/fA+yMdOPHmY7xuwT2QCpaJ2wDNyL2+JBMCGIqeuY18vvWCXuH4mv2+Be4fWluYxMSQwA7GqW91lRcY7oI1CjReGrlOk32GoCEVqavqxREikZzHexYDA9ZjTnMEBN3k3ncHl8dyn2MKN74JXk7XX4/TqFT2iJfpjxazEIaJgYS0UeuuMkp+5kDEbZxPJzU82alK2IoS7CMV7TNZOVIwyAw/JCYnXAopPpLFwtIstcLJCA8a23Lmkk6s4QplOjffBS3JKzc8WQzNF7OYaSSnWgpxk7TmUi/2Ktlvn0JSIqZFULs3Wq4bhMXwQE68SaOhRD4mUmg8wP2hswFqdW8hsip9jJdgIzXYJcVe6y5eRY9mgjHoYpbq3Uyd/YiMf9XvwviFfo8iDofZohcojQUL+0/wmLhfLjPLv9eS6n0qsBdNGothld54Dl6sExj6NA= X-OriginatorOrg: sifive.com X-MS-Exchange-CrossTenant-AuthSource: MN2PR13MB2797.namprd13.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Dec 2020 04:59:06.0571 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 22f88e9d-ae0d-4ed9-b984-cdc9be1529f1 X-MS-Exchange-CrossTenant-Network-Message-Id: acb78128-3351-4bb8-82af-08d897482973 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: fERkPwwLvLazP16RgVkCtSTJaD1nUrjxBCV0qGDvjKTmBWtLN813biew25YvUgLULRMRm+ggb5SAnZ4ya+CXwR/I18DAjKutpnsIO/6Teac= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR13MB4381 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.102.3 at phobos.denx.de X-Virus-Status: Clean Add the command "pwm" for controlling the pwm channels. This command provides pwm invert/config/enable/disable functionalities via PWM uclass drivers Signed-off-by: Pragnesh Patel Reviewed-by: Simon Glass --- Changes in v3: - Replace goto with return - Print return value for error - Change the assert condition for success Changes in v2: - Add test for pwm command README | 1 + cmd/Kconfig | 6 ++ cmd/Makefile | 1 + cmd/pwm.c | 117 ++++++++++++++++++++++++++++++++++++++ configs/sandbox_defconfig | 1 + test/cmd/Makefile | 1 + test/cmd/pwm.c | 47 +++++++++++++++ 7 files changed, 174 insertions(+) create mode 100644 cmd/pwm.c create mode 100644 test/cmd/pwm.c diff --git a/README b/README index cb49aa15da..dab291e0d0 100644 --- a/README +++ b/README @@ -3160,6 +3160,7 @@ i2c - I2C sub-system sspi - SPI utility commands base - print or set address offset printenv- print environment variables +pwm - control pwm channels setenv - set environment variables saveenv - save environment variables to persistent storage protect - enable or disable FLASH write protection diff --git a/cmd/Kconfig b/cmd/Kconfig index 1595de999b..0d085108f4 100644 --- a/cmd/Kconfig +++ b/cmd/Kconfig @@ -918,6 +918,12 @@ config CMD_GPIO help GPIO support. +config CMD_PWM + bool "pwm" + depends on DM_PWM + help + Control PWM channels, this allows invert/config/enable/disable PWM channels. + config CMD_GPT bool "GPT (GUID Partition Table) command" select EFI_PARTITION diff --git a/cmd/Makefile b/cmd/Makefile index dd86675bf2..75df3c136c 100644 --- a/cmd/Makefile +++ b/cmd/Makefile @@ -120,6 +120,7 @@ endif obj-$(CONFIG_CMD_PINMUX) += pinmux.o obj-$(CONFIG_CMD_PMC) += pmc.o obj-$(CONFIG_CMD_PSTORE) += pstore.o +obj-$(CONFIG_CMD_PWM) += pwm.o obj-$(CONFIG_CMD_PXE) += pxe.o pxe_utils.o obj-$(CONFIG_CMD_WOL) += wol.o obj-$(CONFIG_CMD_QFW) += qfw.o diff --git a/cmd/pwm.c b/cmd/pwm.c new file mode 100644 index 0000000000..5849fc57b6 --- /dev/null +++ b/cmd/pwm.c @@ -0,0 +1,117 @@ +// SPDX-License-Identifier: GPL-2.0+ +/* + * Control PWM channels + * + * Copyright (c) 2020 SiFive, Inc + * author: Pragnesh Patel + */ + +#include +#include +#include + +enum pwm_cmd { + PWM_SET_INVERT, + PWM_SET_CONFIG, + PWM_SET_ENABLE, + PWM_SET_DISABLE, +}; + +static int do_pwm(struct cmd_tbl *cmdtp, int flag, int argc, + char *const argv[]) +{ + const char *str_cmd, *str_channel = NULL, *str_enable = NULL; + const char *str_pwm = NULL, *str_period = NULL, *str_duty = NULL; + enum pwm_cmd sub_cmd; + struct udevice *dev; + u32 channel, pwm_enable, pwm_dev, period_ns = 0, duty_ns = 0; + int ret; + + if (argc < 4) + return CMD_RET_USAGE; + + str_cmd = argv[1]; + argc -= 2; + argv += 2; + + if (argc > 0) { + str_pwm = *argv; + argc--; + argv++; + } + + if (!str_pwm) + return CMD_RET_USAGE; + + switch (*str_cmd) { + case 'i': + sub_cmd = PWM_SET_INVERT; + break; + case 'c': + sub_cmd = PWM_SET_CONFIG; + break; + case 'e': + sub_cmd = PWM_SET_ENABLE; + break; + case 'd': + sub_cmd = PWM_SET_DISABLE; + break; + default: + return CMD_RET_USAGE; + } + + pwm_dev = simple_strtoul(str_pwm, NULL, 10); + ret = uclass_get_device(UCLASS_PWM, pwm_dev, &dev); + if (ret) { + printf("pwm: '%s' not found\n", str_pwm); + return cmd_process_error(cmdtp, ret); + } + + if (argc > 0) { + str_channel = *argv; + channel = simple_strtoul(str_channel, NULL, 10); + argc--; + argv++; + } else { + return CMD_RET_USAGE; + } + + if (sub_cmd == PWM_SET_INVERT && argc > 0) { + str_enable = *argv; + pwm_enable = simple_strtoul(str_enable, NULL, 10); + ret = pwm_set_invert(dev, channel, pwm_enable); + } else if (sub_cmd == PWM_SET_CONFIG && argc == 2) { + str_period = *argv; + argc--; + argv++; + period_ns = simple_strtoul(str_period, NULL, 10); + + if (argc > 0) { + str_duty = *argv; + duty_ns = simple_strtoul(str_duty, NULL, 10); + } + + ret = pwm_set_config(dev, channel, period_ns, duty_ns); + } else if (sub_cmd == PWM_SET_ENABLE) { + ret = pwm_set_enable(dev, channel, 1); + } else if (sub_cmd == PWM_SET_DISABLE) { + ret = pwm_set_enable(dev, channel, 0); + } else { + printf("PWM arguments missing\n"); + return CMD_RET_FAILURE; + } + + if (ret) { + printf("error(%d)\n", ret); + return CMD_RET_FAILURE; + } + + return CMD_RET_SUCCESS; +} + +U_BOOT_CMD(pwm, 6, 0, do_pwm, + "control pwm channels", + "pwm \n" + "pwm \n" + "pwm \n" + "Note: All input values are in decimal"); diff --git a/configs/sandbox_defconfig b/configs/sandbox_defconfig index f2a767a4cd..7a16603461 100644 --- a/configs/sandbox_defconfig +++ b/configs/sandbox_defconfig @@ -58,6 +58,7 @@ CONFIG_CMD_LSBLK=y CONFIG_CMD_MUX=y CONFIG_CMD_OSD=y CONFIG_CMD_PCI=y +CONFIG_CMD_PWM=y CONFIG_CMD_READ=y CONFIG_CMD_REMOTEPROC=y CONFIG_CMD_SPI=y diff --git a/test/cmd/Makefile b/test/cmd/Makefile index 859dcda239..dde98dd371 100644 --- a/test/cmd/Makefile +++ b/test/cmd/Makefile @@ -4,3 +4,4 @@ obj-y += mem.o obj-$(CONFIG_CMD_MEM_SEARCH) += mem_search.o +obj-$(CONFIG_CMD_PWM) += pwm.o diff --git a/test/cmd/pwm.c b/test/cmd/pwm.c new file mode 100644 index 0000000000..3cc1aaffd4 --- /dev/null +++ b/test/cmd/pwm.c @@ -0,0 +1,47 @@ +// SPDX-License-Identifier: GPL-2.0+ +/* + * Test for pwm command + * + * Copyright 2020 SiFive, Inc + * + * Authors: + * Pragnesh Patel + */ + +#include +#include +#include +#include + +/* Basic test of 'pwm' command */ +static int dm_test_pwm_cmd(struct unit_test_state *uts) +{ + struct udevice *dev; + + ut_assertok(uclass_get_device(UCLASS_PWM, 0, &dev)); + ut_assertnonnull(dev); + + ut_assertok(console_record_reset_enable()); + + /* pwm */ + run_command("pwm invert 0 0 1", 0); + ut_assert_console_end(); + + run_command("pwm invert 0 0 0", 0); + ut_assert_console_end(); + + /* pwm */ + run_command("pwm config 0 0 period_ns duty_ns", 0); + ut_assert_console_end(); + + /* pwm */ + run_command("pwm enable 0 0", 0); + ut_assert_console_end(); + + run_command("pwm disable 0 0", 0); + ut_assert_console_end(); + + return 0; +} + +DM_TEST(dm_test_pwm_cmd, UT_TESTF_SCAN_PDATA | UT_TESTF_SCAN_FDT | UT_TESTF_CONSOLE_REC);