From patchwork Sat Jan 6 15:07:45 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: SF Markus Elfring X-Patchwork-Id: 856384 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.infradead.org (client-ip=65.50.211.133; helo=bombadil.infradead.org; envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="AUcrPfjw"; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3zDPzy0CZ4z9s7G for ; Sun, 7 Jan 2018 02:08:14 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:References:To:From:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Fwg6BomC1+yYUkTnwr5+sUX3oRdVa1oKSL4M+Bhft3o=; b=AUcrPfjwQMeebj 5291G+bZxGcA9qv8JEe0HjZc52ORC4U9S5aeSN9TFMdyrn1weX0x5FobHytfYs0MWkfIyRH3cfPiE xGZbYi+ZgE1rgxFc/El//cogU/dPI/SLj12erNeRoST7haFXXQ1cwY7mP9M1IdeNQGPGUbi3sEyEl YnMfqM6cjdwAA97QlmvcZRBUFWOOneqrpoYnlMJtSI8NnKV3+qhwzRCD9HJpwLO53SvIvqUi027Ym yF5ylK8XQXnmErApI/jZgrx3F6FCebAfRIZ9/iGemws9xCGlRHlxZcKyBGwvJOXYb6+ANLWTS0BfR /MnVMek8Sv7/tCvaKhfw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.89 #1 (Red Hat Linux)) id 1eXq4w-0007sr-FB; Sat, 06 Jan 2018 15:08:10 +0000 Received: from mout.web.de ([212.227.15.4]) by bombadil.infradead.org with esmtps (Exim 4.89 #1 (Red Hat Linux)) id 1eXq4s-0007rk-BT for linux-mtd@lists.infradead.org; Sat, 06 Jan 2018 15:08:08 +0000 Received: from [192.168.1.3] ([85.182.74.56]) by smtp.web.de (mrweb004 [213.165.67.108]) with ESMTPSA (Nemesis) id 0MCvVz-1ehQav2eyB-009jZU; Sat, 06 Jan 2018 16:07:46 +0100 Subject: [PATCH 1/5] mtd/rfd_ftl: Delete an error message for a failed memory allocation in scan_header() From: SF Markus Elfring To: linux-mtd@lists.infradead.org, Boris Brezillon , Brian Norris , Cyrille Pitchen , David Woodhouse , Marek Vasut , Richard Weinberger References: Message-ID: <90d58d5f-73e4-b47e-d013-19cd84c4ccda@users.sourceforge.net> Date: Sat, 6 Jan 2018 16:07:45 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: Content-Language: en-GB X-Provags-ID: V03:K0:KxVpeYtLt0YonYiqzjfCtFYt9PSfUKYENVG1wH+svtqiVadocX8 8QOMq2uItpZonWikX/dXlTehwiACFtgG1YD/PwjoFjrpy38BjJOPtgqLa1YKLDFvNSE36yk GCOBtDI3kxX6kFdicm8dsEKvZXdAiar7BDY7awM5RlPjm7eN0O9FVzGU8i1rBXM8+ycU7U/ WS4AaKVrtcr8Se55PkxRQ== X-UI-Out-Filterresults: notjunk:1; V01:K0:m3c1okAkK3Y=:wBvj48R4SpOVc2YlWVfzrF Y6y8nVhJmJP3d4X6YvF57iS54ztATxJQlPLhKN3SE8WIZxT4yY/2TWnX58FYagSsTRID1a3ZY ICF4NrJGdB5vSbrxK1MX2OPSLZs0vMH7TJEJM5lL9VbuEVEI5wfeMJR89mIIZAY52gzjWq11t ERUkcv+OmvR9pLD1lIqP1wwgAetmX73Mi+9Mit1kH0A5pFqSSsNfGjx2Yy8O/vWsGbd6TuGeL yesLkV4k8e8P3avRplwgbS6rsJRJoQTNTS2l2I5HUV0k23VdImoI1FBNR11n4TBkoWEPyTPv6 Z+bKR4zKm5minsgUwrTOWmP6kk929rwRIGKCPk4BcqxM1CiklZ3krQw84+yA8SCL9zw3As0hY NaRVWRRCjXlT8vONduAo7v8GQj82A/elQaSgWT/VOAk8Bb4qraxvFvywj2et/7h90sE8VOL4s u8rFHCnBx81SqUoPfHFCn9uOr1y9clilc7MrTvM/xH+0Lsb9YCw28mhvVafoiVNzT9CetHn/7 h0LUsGRMiuaEWP9gFprlFPacTC9xxvPMJ+nSZlPWABXru6BrBK56mNg/aVqfdXlFPZ/TDHXIE GgmKLCTzaJGO9EEjJ2+oyXSXnZZW2ok+bErVwgYZzHGiiCQly5ZB6Q0pgZMSI27gH/RHlBXGN 8aPq1RB5u+uiVd/GhQQIXOlxcLBMoPKHCd8ceiwoc+ZJJgjfeTGIVTTa/W1n2wT8yQgIA3aD5 0twlGek23hcgcTLng6uCROwTaFXCv7fuTYBnNa7mKdcFgDbXFhmeebUP1c7c2OVtOWXIYtvZt lwz9tI9G0Ay8DisfFQpc53L643yJarjMnBmk/PTHAKv+IIvmuI= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180106_070806_943246_EC89D1B8 X-CRM114-Status: UNSURE ( 8.78 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -2.6 (--) X-Spam-Report: SpamAssassin version 3.4.1 on bombadil.infradead.org summary: Content analysis details: (-2.6 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [212.227.15.4 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] -0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [212.227.15.4 listed in wl.mailspike.net] -0.0 RCVD_IN_MSPIKE_WL Mailspike good senders X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kernel-janitors@vger.kernel.org, LKML Sender: "linux-mtd" Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org From: Markus Elfring Date: Sat, 6 Jan 2018 14:07:31 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/mtd/rfd_ftl.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/mtd/rfd_ftl.c b/drivers/mtd/rfd_ftl.c index d1cbf26db2c0..efff25f15d5b 100644 --- a/drivers/mtd/rfd_ftl.c +++ b/drivers/mtd/rfd_ftl.c @@ -190,11 +190,8 @@ static int scan_header(struct partition *part) goto err; part->sector_map = vmalloc(part->sector_count * sizeof(u_long)); - if (!part->sector_map) { - printk(KERN_ERR PREFIX "'%s': unable to allocate memory for " - "sector map", part->mbd.mtd->name); + if (!part->sector_map) goto err; - } for (i=0; isector_count; i++) part->sector_map[i] = -1; From patchwork Sat Jan 6 15:08:51 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: SF Markus Elfring X-Patchwork-Id: 856385 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.infradead.org (client-ip=65.50.211.133; helo=bombadil.infradead.org; envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="C/NHpvZB"; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3zDQ1F3NsPz9s7M for ; Sun, 7 Jan 2018 02:09:21 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:References:To:From:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=hoGGsO32Y7V6Y7I4M7UD9d8PFg+aHgenkqOIYNZdJnA=; b=C/NHpvZBEG25AF Tn8B1zvx1TE4PmeDqv2MpL4CBcFu6V59bn6fHrtOq2llI5F50W/n5oZH10liIuRS6y1rD4K5dGMKv 6qLxRmMyBkj+fi+MmuBPpQ9fKJCcmrKlDBlcwFBmU+xNYDoyTf9WBROa22uZpBmUJnkatBY2g9yh7 IZ/vcJB8oIbGx7xYdpvx4oWbIuVdbJmKiDvhlh3BNivg/zsFVAtn/VghqEUZYbsGSZEzg+J9RZ2UI vAnAke2q3jHwC3RTqgrEX9FS0cpVCDfneuPHcJl9s4luv8R4yEqdlm7zHjMyvU1OHCUNs/IjIEUwP 5ekfD2qxXdPfltIRmUPA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.89 #1 (Red Hat Linux)) id 1eXq61-0008Ed-Tb; Sat, 06 Jan 2018 15:09:17 +0000 Received: from mout.web.de ([212.227.15.3]) by bombadil.infradead.org with esmtps (Exim 4.89 #1 (Red Hat Linux)) id 1eXq5w-0008DM-V6 for linux-mtd@lists.infradead.org; Sat, 06 Jan 2018 15:09:15 +0000 Received: from [192.168.1.3] ([85.182.74.56]) by smtp.web.de (mrweb002 [213.165.67.108]) with ESMTPSA (Nemesis) id 0M0Qxx-1esoO13GVZ-00uXvy; Sat, 06 Jan 2018 16:08:52 +0100 Subject: [PATCH 2/5] mtd/rfd_ftl: Less function calls in scan_header() after error detection From: SF Markus Elfring To: linux-mtd@lists.infradead.org, Boris Brezillon , Brian Norris , Cyrille Pitchen , David Woodhouse , Marek Vasut , Richard Weinberger References: Message-ID: <6f10248e-d2c9-3c48-922c-be95ac5caba9@users.sourceforge.net> Date: Sat, 6 Jan 2018 16:08:51 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: Content-Language: en-GB X-Provags-ID: V03:K0:3ll9OR9loEMTCwy0KCbPzQ+zMsDuBhNjgh1vK0E6bsv0JUJAbP1 wOU/S4PPpWYuKt9Q509/Tg3FROM1n5PSefHLSK0PDmVmhVCku7h5jYbNEA3M7Ghww9BZQ9o GRXXV91OPCcdHuI/5DmuQKIJ5xjfxTGtDO/Xlv9V8ePR0cTmkx+di8jpVbaxuDKTNs79Ygq 5KrWYu3KvNvUv5cMqSdCw== X-UI-Out-Filterresults: notjunk:1; V01:K0:UdliNnAmQCw=:BHQ3xNng9yE+m/n8CLwqW9 pEPPJPNvkXI3o8jBedyZMzl1taAlZIUST3GS0bjlro3ZKmtYWHxz9/Z+suLPzMxs95WKRuD4u tPAL4VxsQRQLUyuRZ5vYvoRWycfOhPmsGm0oWLsmGgmoZopC7jnB+dPcPnq4Gq7hukapSDl5D vxPsbxSqq+lynCXK+dbF+dNhwgswk56YCP3uYpwL7ONGD48mhQcRkGKMkwHLfCeMa4uvmDbQH Yo4V0V+D6vpPMZGKGHlVmlIgbKFDHgnWGTElozoRW0VkQd2PQudHELDtWOLDpHIwQCJINB4dX b/pEAHR94OVpwJJzaVUJ7muPga7TMyDy6XHd0FWirXH/aEy/IG+24/ErRAYhis2RJmA9MkugG 1Wp2g+1RCYAhQQyvH1pp96Yw7pQXXGQCujloL5Vhe5eYrABwferapXPUaeBJn0xH5WAfFWe3S FLNQ4pc0F3As+u0zLq3shw2I1GR4GZYqDi+mZZk/izVp/iXlIU9w3sRVS9skacfV9Xr1rMb7M urArqWumJHu+syn/5suef6JfEFY8KIji/mMftNoO5xO2wFuJMlyE3WbbLkpLC3GrZOb4LaKLM 1GWQjBIWf7Oa/lUlvWzbANgLh27u9s+Uf4ZHIsvn8dWN9rW5VA4RewG/SgMQBKYpiFa3aF2l6 l6dqkzjYlVw1TZUBSfLjSnJGlciPtGRSFO8ZCLoW3RHtSb3G1JDZYt9+nFMvEUcUgAwJg2/qD E29S3oCLmxq+JNIT1lt9BJod+aizy8Mq8DChsmMqNbdbRe1KQty8uNmGu91P+mI8WWCoxGr0h mDCWfoQKOntdPIjVBbbtVk/JeCzaNQePCqlZKz1zk8NdAtAhLQ= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180106_070913_398476_65D6A11D X-CRM114-Status: UNSURE ( 9.25 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -2.6 (--) X-Spam-Report: SpamAssassin version 3.4.1 on bombadil.infradead.org summary: Content analysis details: (-2.6 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [212.227.15.3 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record -0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [212.227.15.3 listed in wl.mailspike.net] -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] -0.0 RCVD_IN_MSPIKE_WL Mailspike good senders X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kernel-janitors@vger.kernel.org, LKML Sender: "linux-mtd" Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org From: Markus Elfring Date: Sat, 6 Jan 2018 14:50:58 +0100 The functions "kfree" and "vfree" were called in three cases by the scan_header() function during error handling even if the passed data structure member contained a null pointer. Adjust jump targets according to the Linux coding style convention. Signed-off-by: Markus Elfring --- drivers/mtd/rfd_ftl.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/mtd/rfd_ftl.c b/drivers/mtd/rfd_ftl.c index efff25f15d5b..19e14f909dc6 100644 --- a/drivers/mtd/rfd_ftl.c +++ b/drivers/mtd/rfd_ftl.c @@ -182,16 +182,16 @@ static int scan_header(struct partition *part) part->header_cache = kmalloc(part->header_size, GFP_KERNEL); if (!part->header_cache) - goto err; + return -ENOMEM; part->blocks = kcalloc(part->total_blocks, sizeof(struct block), GFP_KERNEL); if (!part->blocks) - goto err; + goto free_cache; part->sector_map = vmalloc(part->sector_count * sizeof(u_long)); if (!part->sector_map) - goto err; + goto free_blocks; for (i=0; isector_count; i++) part->sector_map[i] = -1; @@ -229,9 +229,10 @@ static int scan_header(struct partition *part) err: vfree(part->sector_map); - kfree(part->header_cache); +free_blocks: kfree(part->blocks); - +free_cache: + kfree(part->header_cache); return rc; } From patchwork Sat Jan 6 15:09:44 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: SF Markus Elfring X-Patchwork-Id: 856386 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.infradead.org (client-ip=65.50.211.133; helo=bombadil.infradead.org; envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="IFgs1Pvf"; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3zDQ2F1WtFz9s7G for ; Sun, 7 Jan 2018 02:10:13 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:References:To:From:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=dSqK3g8IV5YzzuDoxGg7l866sVEwo82xHM4diPWX1qo=; b=IFgs1Pvf9vFuTo wLmJgxKvMMXASJYPsjq1oC19iBejTInaONWor0Hs0BPqLMEAuPr77zLoJGcpOlYchkYuZ0XL1vXjQ W5QAs1hb++S+vpsBs+Z7/OD8MmnFlzpM38GIyCZggOYEhpWWbyfR8ws5IiTapTLurpNPyV1NaxIto IO0BvrEuo3ctev4jLZZ2HZSCHlFqNALoPGzD+19C3N8KgQerqBtBHc16GvSXzZQwot2BgDCXK70TO rbyFCsJWMWvM6YrYb/p9o1hCIDNJYl3w7YcW6BGuRkfA+rbdEQdEoSjek91sEqNickcpnkT3F5/GU wHrkeEvIyhlyQNqxH2Mg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.89 #1 (Red Hat Linux)) id 1eXq6q-0000bG-FB; Sat, 06 Jan 2018 15:10:08 +0000 Received: from mout.web.de ([212.227.15.3]) by bombadil.infradead.org with esmtps (Exim 4.89 #1 (Red Hat Linux)) id 1eXq6m-0008UW-C1 for linux-mtd@lists.infradead.org; Sat, 06 Jan 2018 15:10:06 +0000 Received: from [192.168.1.3] ([85.182.74.56]) by smtp.web.de (mrweb004 [213.165.67.108]) with ESMTPSA (Nemesis) id 0MYI9h-1eKpY01HoP-00V88G; Sat, 06 Jan 2018 16:09:45 +0100 Subject: [PATCH 3/5] mtd/rfd_ftl: Improve a size determination in two functions From: SF Markus Elfring To: linux-mtd@lists.infradead.org, Boris Brezillon , Brian Norris , Cyrille Pitchen , David Woodhouse , Marek Vasut , Richard Weinberger References: Message-ID: Date: Sat, 6 Jan 2018 16:09:44 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: Content-Language: en-GB X-Provags-ID: V03:K0:IFPaM2ed2dhTUg/E18Z9/YC1arrVRLM4gnHftg5WwuRS/oziwfo BPDXNnOabiWIzHO0FFWxLEk1GkQAJ6pjA+qOHdpXWCituwxgIdUhOKF6jCkMeMl7f6W3Y8z 3097kEXAo/cLMAJgjszx3g3syFfvzEpmdLRUL5TNs1bDfTU7M9k8fjCLEMzUvwodYf/cqNI VZOy1dDCcfCy+KesRMPgQ== X-UI-Out-Filterresults: notjunk:1; V01:K0:lNVXpI88+50=:hcmSZa3knntMF+tewTaCbi 4Ps8Nz0R94e8FFpyMDDVPXQpuGFPZOySBsCLVh+02f+5fWxaXan21Qna3cs0Ew730k8jSvi3G G0yDieUkNZ7DHKcf/ssF6HeSMLJwrX0MFPxl8yDpb4+jUl98+5t7NbfgFHxSOewKsY/PoiMS9 docGcaVowXmWcM1GiLu7CtcRpa5O2XxCeht1EC9blHWtDGwfPkoMtHEaBCo1h0AFTNlYobjs4 8WMBpFGtERHmEyxqr7F6m4yTS70gIREo901uJeAUmAd+nrUt5Lf5poJuTUXzKCyO36n5MiGq1 dvFiaCqoaPzI+tFEnwgWvbUQ8tRFJXgIiCrAez0hN21Bf576y9a0QszOcBLGlf5GGqTVQQwps LXmJJ8537/nAboUZbfPdogMlMR0gbXaMyVkxa7GsQf8Z2jXLqS2lmFbho+jimyLFt1s3HO3Hz aDJKDO61ZsqWySxgTvjuN8GVGXcbMwD0kkAaazF0iJlDd39A4rs/IzOFB+084Sl6Xl6lit9/f INDSB7k1WKEMi/wN5OSgBsMpT+za9Y3SCYigyH9CmBwa5XERMl2nMZ/hgwmB3FKfLFMtcYehr Jkh3ipdPt9PIGU6ZRXWW3jGxQUslR8ohgQxu2SYRYZwH3S1ji/v+7z7mkUK6SkZqnmy7HErHQ UpIVBlrJt7q5+I9bUYsKlDgxmOkBnHru93xLOi/T+svhYDCuGAh5s32venP0JVYSRzXOWDMp8 /nvBrOdoJhNazuWZ6Y5lzmL3SWi87WxBRgNhs72JYxb9P7DWCUQJC+AUIya9LU/mf/UWez1U9 UPNrrE9YUSNZePLdnpgb4Zm/q6wqpZHtUPRvlycivMAbGaVjw0= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180106_071004_881948_605B4AF3 X-CRM114-Status: UNSURE ( 9.92 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -2.6 (--) X-Spam-Report: SpamAssassin version 3.4.1 on bombadil.infradead.org summary: Content analysis details: (-2.6 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [212.227.15.3 listed in list.dnswl.org] -0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [212.227.15.3 listed in wl.mailspike.net] -0.0 SPF_PASS SPF: sender matches SPF record -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] -0.0 RCVD_IN_MSPIKE_WL Mailspike good senders X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kernel-janitors@vger.kernel.org, LKML Sender: "linux-mtd" Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org From: Markus Elfring Date: Sat, 6 Jan 2018 15:03:29 +0100 Replace the specification of data structures by pointer dereferences as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/mtd/rfd_ftl.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/mtd/rfd_ftl.c b/drivers/mtd/rfd_ftl.c index 19e14f909dc6..dcf1b88e1193 100644 --- a/drivers/mtd/rfd_ftl.c +++ b/drivers/mtd/rfd_ftl.c @@ -323,10 +323,9 @@ static void erase_callback(struct erase_info *erase) static int erase_block(struct partition *part, int block) { - struct erase_info *erase; int rc = -ENOMEM; + struct erase_info *erase = kmalloc(sizeof(*erase), GFP_KERNEL); - erase = kmalloc(sizeof(struct erase_info), GFP_KERNEL); if (!erase) goto err; @@ -759,7 +758,7 @@ static void rfd_ftl_add_mtd(struct mtd_blktrans_ops *tr, struct mtd_info *mtd) if (mtd->type != MTD_NORFLASH || mtd->size > UINT_MAX) return; - part = kzalloc(sizeof(struct partition), GFP_KERNEL); + part = kzalloc(sizeof(*part), GFP_KERNEL); if (!part) return; From patchwork Sat Jan 6 15:10:40 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: SF Markus Elfring X-Patchwork-Id: 856387 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.infradead.org (client-ip=65.50.211.133; helo=bombadil.infradead.org; envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="uMCaCXh9"; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3zDQ3J45sJz9s7G for ; Sun, 7 Jan 2018 02:11:08 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:References:To:From:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=y9uv6H5WQwkdLcPuf7bVqUyErRT9M3fYaSiEiVe64xQ=; b=uMCaCXh967JZf9 w1X1KtplHyNh553EdeEK5macWf43Nu4p+55eecdKIyQiHLf6T1fPeADqWBCJ4pQ6ZaBHkqY0ozR5U uIe99Sw8JodSyfPBDU+Wlzu8p+x+EKv1MliZuBcDUSdd1DPYJChmACGKv8kQ2n6tplV5ZqSmNLbL3 0SSI2JkkwzfZ2/noXVbkzM+7gK/FOuo5F3L8olwYtv4KJGz7sTwAvym0KWlPk3Vz9fvDHm2QD13xy yssPLeK23KL7NbQeLirL7cMc4u06FWvbjDHFI/4RMJ8fCZQ6vSlAEdasfNypyzQWzaTrJT5nJM9+g WqALnQwWlASg7TqDgURw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.89 #1 (Red Hat Linux)) id 1eXq7l-0001oY-1b; Sat, 06 Jan 2018 15:11:05 +0000 Received: from mout.web.de ([212.227.15.14]) by bombadil.infradead.org with esmtps (Exim 4.89 #1 (Red Hat Linux)) id 1eXq7h-0001mq-JJ for linux-mtd@lists.infradead.org; Sat, 06 Jan 2018 15:11:03 +0000 Received: from [192.168.1.3] ([85.182.74.56]) by smtp.web.de (mrweb004 [213.165.67.108]) with ESMTPSA (Nemesis) id 0MevzF-1eEH1s1FwP-00OVF3; Sat, 06 Jan 2018 16:10:41 +0100 Subject: [PATCH 4/5] mtd/rfd_ftl: Return directly after a failed kmalloc() in erase_block() From: SF Markus Elfring To: linux-mtd@lists.infradead.org, Boris Brezillon , Brian Norris , Cyrille Pitchen , David Woodhouse , Marek Vasut , Richard Weinberger References: Message-ID: <7b381eef-c54f-d2c9-7281-a90d519c22f1@users.sourceforge.net> Date: Sat, 6 Jan 2018 16:10:40 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: Content-Language: en-GB X-Provags-ID: V03:K0:F7JGxL3M42F4E7pULqa8dQapOf/q99MYq8W4cfdwRbexVqhKfV6 wrlWybuqNbjd52MaTp88GSVnKxRTE6WZQcvJ1qYQtC/M5uw56unEIC6Nml74S3+NpnMF1UA FQkMnwNjEzIsxqIRgVXa5q2SaJlwPWC324+YFeqgS63qG1T2M8LUgxPG0FRnrsXUROfhMgZ RXizVXSA9zp+UDiamtLPg== X-UI-Out-Filterresults: notjunk:1; V01:K0:LbwBnzPeB10=:wDP/t4lVn321Oljz7XaBCJ QPvVfNf/AzQWbGDQ7+NkEJEAzuaLb1W3cZw7YKYSRSR9lAKLknCNdlNHVGrMh/rydows389t1 98GwjWiwRquIj0mhOq7ct3FAj6FrlJU9hK6qjdMZOqXasFXMiLvlHgtcRR6QDi7wNibebxBIC v5y3R370xp3o1SvLRpvZSWVmDP4uS1zVaXxh/veqxMC1/+0WaP4ei7DsJw6q7iLJq/4uxthQH xNhmGQYYrhBqn4B3dK1I0dvVzY2ETjmozcltENkdarr+R7I2/ApSAh05hFlVPtnBcB5hLbUQE gGMLeDOMMPT1c8ODukCdutToyv7x3jeFt99sfG5P4OW2u4eJ4JNJ9V71DTI25lDp439M+5Tw6 r40PkPfqCrJVEv5hJusZvvhlolDMKAS7sIQ0ljOkirnO6xwOF3QobYjyCUaJsTFlRwzm09DPW w6EMJwkgH+Op0tSajxjcQuaPd9EwnIwrAvJRFiIkoA/zC29k9j6diChdNVGz1rwUXwml/H21b 0Ej6L4R69dh4FVWM3ArFmAsWcuhM/o+wBOAvkuOhwkYbR1nJ0KAHrtPNLiCh0FkrofZxVkZsr bmzU7iQoYtyaviela5vlyM4z2jG8KLdE1ZmfbZazHAE7V/STo3XLC9VTH6oOJ1bIO8eCw0dY1 KJYmQhZKnLWXbnMWiz6KffdvG9OKpRNV59u/wzRUMJH/f67SAxuCPmyim+fCimqbD3WtUhcg/ QJZValXH1lPY+NIEWsQfWyHrOVu/GtN6Ih9he8UPwUU3MrewkaF0WKlZSDQf6QI1zs6XImFKE l8SpHQGYrUD4+I5eouTJ3eyeZK0Xqu+iRz+gRTrbBU/G07Mb7U= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180106_071101_977498_877B1118 X-CRM114-Status: UNSURE ( 9.93 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -2.6 (--) X-Spam-Report: SpamAssassin version 3.4.1 on bombadil.infradead.org summary: Content analysis details: (-2.6 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [212.227.15.14 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] -0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [212.227.15.14 listed in wl.mailspike.net] -0.0 RCVD_IN_MSPIKE_WL Mailspike good senders X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kernel-janitors@vger.kernel.org, LKML Sender: "linux-mtd" Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org From: Markus Elfring Date: Sat, 6 Jan 2018 15:18:28 +0100 * Return directly after a call of the function "kmalloc" failed at the beginning. * Delete an initialisation for the variable "rc" and the jump label "err" which became unnecessary with this refactoring. Signed-off-by: Markus Elfring --- drivers/mtd/rfd_ftl.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mtd/rfd_ftl.c b/drivers/mtd/rfd_ftl.c index dcf1b88e1193..e3155ec4be64 100644 --- a/drivers/mtd/rfd_ftl.c +++ b/drivers/mtd/rfd_ftl.c @@ -323,11 +323,11 @@ static void erase_callback(struct erase_info *erase) static int erase_block(struct partition *part, int block) { - int rc = -ENOMEM; + int rc; struct erase_info *erase = kmalloc(sizeof(*erase), GFP_KERNEL); if (!erase) - goto err; + return -ENOMEM; erase->mtd = part->mbd.mtd; erase->callback = erase_callback; @@ -346,8 +346,6 @@ static int erase_block(struct partition *part, int block) (unsigned long long)erase->len, part->mbd.mtd->name); kfree(erase); } - -err: return rc; } From patchwork Sat Jan 6 15:11:38 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: SF Markus Elfring X-Patchwork-Id: 856388 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.infradead.org (client-ip=65.50.211.133; helo=bombadil.infradead.org; envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="MPpYZFAz"; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3zDQ4J0zzlz9s7G for ; Sun, 7 Jan 2018 02:12:00 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:References:To:From:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=eMZyarTNECcCOwAooHVB9acAR+8Uwxd1nQ1r07+ubso=; b=MPpYZFAzLSkrDG TpsfYvsX+c5aAKkbaSIBOJksGnPcEeAaP205bxBweWJP+dR0MXvWn8opPyP9KXF8Eyj+umnnutQgH 2U7L1PmTJ4Y7CSCJ823sC2NTNp3kl/tDh0QhH88cb83TFgniwLVqHhczwMwSAeqOTGbZ6pKAw4Vps czS/d2Qp+RHWPj4XX5I4R/Tz4WK7+S/dy4TaJ7fqTIg3v3vJby0laTSBvfABlIkWw0c31HpfoCrt6 /ALJWD0+erfwHXv1mnPYf2ofAriFJumQmimwYLNu+hYNxTgi2K3cvLEGbGRDAdq4XdWtMYJfoLJ2c 9tpSN8a164NzKyTBH8+Q==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.89 #1 (Red Hat Linux)) id 1eXq8Z-00027i-Ki; Sat, 06 Jan 2018 15:11:55 +0000 Received: from mout.web.de ([212.227.15.3]) by bombadil.infradead.org with esmtps (Exim 4.89 #1 (Red Hat Linux)) id 1eXq8W-00026D-Hg for linux-mtd@lists.infradead.org; Sat, 06 Jan 2018 15:11:54 +0000 Received: from [192.168.1.3] ([85.182.74.56]) by smtp.web.de (mrweb004 [213.165.67.108]) with ESMTPSA (Nemesis) id 0MAjet-1ejdQW2GKZ-00BwTe; Sat, 06 Jan 2018 16:11:39 +0100 Subject: [PATCH 5/5] mtd/rfd_ftl: Add some spaces for better code readability From: SF Markus Elfring To: linux-mtd@lists.infradead.org, Boris Brezillon , Brian Norris , Cyrille Pitchen , David Woodhouse , Marek Vasut , Richard Weinberger References: Message-ID: <847904e4-c5a2-0716-24ae-c2ac085fe3a3@users.sourceforge.net> Date: Sat, 6 Jan 2018 16:11:38 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: Content-Language: en-GB X-Provags-ID: V03:K0:yZqjO2/lkIkFvLzLKA0u/LnLq7d9Ndgklf99Do32ml89mwHA4Ai tGWUH3URrGE46FyPHlh8J16a16QcnJcGSf5VsAYQwJxTe96oEG/Q263X7vDu6/QhczAGs3x 2N2kW/HuhIpeGbx0WyPHYqdFlCn0v+gY5OQMTxpxfi27UIuvg/kEv/6gSUIvTNHQESD9ebC 85BebE9hq55sCBdPocl9Q== X-UI-Out-Filterresults: notjunk:1; V01:K0:oWrvHMrzKPY=:1DaQIvGPkpvJOKmeAyYMBY 6MRuatWicLdAHkzi7l90O+XadIHsQSFPhTRoSltbru24h6DHKXpOewVT8hO61AKWzxHJ/447x X632HIfc3Rvr6j7mXJR9SMa5OW5NPfH+SQ1sP9XFR1kFhmx7Baw7Ig9nLrLdvyZPXq1aKj39h aezZaqVXcp13StiVVLukVCZwN/UMxf+hfyNJ38JG2U2HGGXShL+zLKK1SuT3i+3CZ4YgPm8u6 d/F73DjNp3UvnD2Kwn4zxXb+Wjv4sIiQ3spJrF/S7Ih8g2rT4SAHJ28e3M7TGQGkwet8fDT27 Z+0x1YmISJZQ/kUJNC9I30dPnHT0xbTgOkjdGm6XTypTTVx6gtc6tVjX/ciZ/srq2alHTP1BR 72ARaam+Z7lizdAOQo0VQPxr0RVrd0KMl9txe+bFEzeW5YomiMecOrhv23Jjj4B2ixnA4kxN+ fLc01yPvTwSMZOEATDZPJ+pT0lT5sRU608DSpqi728VKGlMhtUlPN2WfcfpRMpG07NXSmldxt aL43sH04Upo+3p+UUPw4RIaEFLOoGYFyRpILErcrUsfrv+p9YyMQOXKqxLP9/FdngG1n/uUvH U4DGvh+WApTBZQWnmtmaiI+za9cE0se7IZhIh8d3hgzrZ6nqpjDsvx04kbOsnY6rNv/rjaRwO Ze5iOCHk/arX5JJ9pidUdx4CPowYR3p0LC6SnsoNHjCLLx/BUHgN/p7gXGedaY5TjuZp4b4Ho 3ISTjGB3Euq3kEG9DiKiZxmznDYVOsEeItODDoSZQ2hotL5Qaus4i8MKOXzg4efljZ12nTyaY kwmvFXQ+tOnFovBgwdZdN4DzhEQOPswIztE3sw8BQBYi8udqnM= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180106_071152_927345_D67DB472 X-CRM114-Status: GOOD ( 10.83 ) X-Spam-Score: -2.6 (--) X-Spam-Report: SpamAssassin version 3.4.1 on bombadil.infradead.org summary: Content analysis details: (-2.6 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [212.227.15.3 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record -0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [212.227.15.3 listed in wl.mailspike.net] -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] -0.0 RCVD_IN_MSPIKE_WL Mailspike good senders X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kernel-janitors@vger.kernel.org, LKML Sender: "linux-mtd" Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org From: Markus Elfring Date: Sat, 6 Jan 2018 15:47:01 +0100 Use space characters at some source code places according to the Linux coding style convention. Signed-off-by: Markus Elfring --- drivers/mtd/rfd_ftl.c | 18 ++++++++---------- 1 file changed, 8 insertions(+), 10 deletions(-) diff --git a/drivers/mtd/rfd_ftl.c b/drivers/mtd/rfd_ftl.c index e3155ec4be64..b6cc3690b9ed 100644 --- a/drivers/mtd/rfd_ftl.c +++ b/drivers/mtd/rfd_ftl.c @@ -103,7 +103,7 @@ static int build_block_map(struct partition *part, int block_no) block->state = BLOCK_OK; - for (i=0; idata_sectors_per_block; i++) { + for (i = 0; i < part->data_sectors_per_block; i++) { u16 entry; entry = le16_to_cpu(part->header_cache[HEADER_MAP_OFFSET + i]); @@ -193,10 +193,10 @@ static int scan_header(struct partition *part) if (!part->sector_map) goto free_blocks; - for (i=0; isector_count; i++) + for (i = 0; i < part->sector_count; i++) part->sector_map[i] = -1; - for (i=0, blocks_found=0; itotal_blocks; i++) { + for (i = 0, blocks_found = 0; i < part->total_blocks; i++) { rc = mtd_read(part->mbd.mtd, i * part->block_size, part->header_size, &retlen, (u_char *)part->header_cache); @@ -380,7 +380,7 @@ static int move_block_contents(struct partition *part, int block_no, u_long *old goto err; } - for (i=0; idata_sectors_per_block; i++) { + for (i = 0; i < part->data_sectors_per_block; i++) { u16 entry = le16_to_cpu(map[HEADER_MAP_OFFSET + i]); u_long addr; @@ -452,7 +452,7 @@ static int reclaim_block(struct partition *part, u_long *old_sector) else old_sector_block = -1; - for (block=0; blocktotal_blocks; block++) { + for (block = 0; block < part->total_blocks; block++) { int this_score; if (block == part->reserved_block) @@ -625,8 +625,7 @@ static int find_free_sector(const struct partition *part, const struct block *bl if (++i == part->data_sectors_per_block) i = 0; - } - while(i != stop); + } while (i != stop); return -1; } @@ -718,7 +717,7 @@ static int rfd_ftl_writesect(struct mtd_blktrans_dev *dev, u_long sector, char * old_addr = part->sector_map[sector]; - for (i=0; itotal_blocks; i++) { + for (i = 0; i < part->total_blocks; i++) pr_debug("rfd_ftl_remove_dev:'%s': erase unit #%02d: %d erases\n", part->mbd.mtd->name, i, part->blocks[i].erases); - } del_mtd_blktrans_dev(dev); vfree(part->sector_map);