From patchwork Thu Nov 26 13:38:46 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1406682 Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=y4FJagoo; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4Chf5G0lXDz9sWX for ; Fri, 27 Nov 2020 00:40:02 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390385AbgKZNjB (ORCPT ); Thu, 26 Nov 2020 08:39:01 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58194 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390296AbgKZNjA (ORCPT ); Thu, 26 Nov 2020 08:39:00 -0500 Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D7921C0617A7 for ; Thu, 26 Nov 2020 05:38:59 -0800 (PST) Received: by mail-wm1-x343.google.com with SMTP id d142so2184782wmd.4 for ; Thu, 26 Nov 2020 05:38:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=oYgpjf76kzokq1lw9peNjpiGw2Ji8yFXqiIQfoAuuvM=; b=y4FJagoo/uFkFIGb96frMqyuiNZVvOjuzF9cDotLK2J14gCs1/9OOWUKHXWpmu8cn0 INafeNn2tupT3IlCatcz1uWm1GdKTDqbpCi9ybMRsziKI+C8M7xtadC+38sZw0rhSfsN v7czwnA2juH7RgUqK/P1rd3ssDMhnwx2JFGQXPAhcDeMAe+b0nN7zRR/k9LzHSfO7Bm1 36Fqa4Y2cJEfwFD1YTbn57rKRst/SbOIuvDLA6N1JeA+RNyeW2ZmLJxvPU22Ii+yaS6E cfboCQeCTQk/oWmlURxIGqqwUMnyMlKuHWhkHKE+8xuYm/CDuA/bv3T7XzoRaVNPz+oS e1qQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=oYgpjf76kzokq1lw9peNjpiGw2Ji8yFXqiIQfoAuuvM=; b=RzutP5CNMRKk/Wpjrz93CqwMVEBLSlcNG+8+Aj1rKWtXem1b1x7fVkcrYNo0AryZZ4 r+MOxyguC8oHxpbjJkVqbNFl6iHg+UrYScNgWeLVt8DnWQV2LkOayKdVNl5z5+KQxXiI /8e0SjJspJqNJ28YT/tTaWI10iM4BRzX9eQhETiYq8SRTIBSQ6Udm4TuFsiArstRyUc8 guNoKD6enzLCFG7Y3xNxZYjJGfuZBlsdxeE9NZxCNlcvi+wR8BfXhlto9Bx1+Gugc0al 4+FalOFS4qg+7XzZB8qThAeSOHjAZjJKbxhxRUAQp9jbPW0WJ9oOMJ0K4ipvDEoDp5kc hlcw== X-Gm-Message-State: AOAM530LZT3ErlyrSxcFGIeTpjXDnAaPbIQU6LF7XzG3SngaEs5tY82D 9Fo/4DRCMjYdtEEqOvT2MDE2WZMw0TcL322S X-Google-Smtp-Source: ABdhPJw9d0nl0bdUXvf8PW+xbx0DbCWa+K1+8tzn+QVpmQ3XABcpMY3u0DkVLZAwm02EkA6E+L6HzA== X-Received: by 2002:a05:600c:2908:: with SMTP id i8mr3521713wmd.182.1606397938612; Thu, 26 Nov 2020 05:38:58 -0800 (PST) Received: from dell.default ([91.110.221.235]) by smtp.gmail.com with ESMTPSA id s133sm7035825wmf.38.2020.11.26.05.38.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Nov 2020 05:38:57 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Nicolas Pitre , "David S. Miller" , Jakub Kicinski , Erik Stahlman , Peter Cammaert , Daris A Nevil , Russell King , netdev@vger.kernel.org Subject: [PATCH 1/8] net: ethernet: smsc: smc91x: Demote non-conformant kernel function header Date: Thu, 26 Nov 2020 13:38:46 +0000 Message-Id: <20201126133853.3213268-2-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201126133853.3213268-1-lee.jones@linaro.org> References: <20201126133853.3213268-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/net/ethernet/smsc/smc91x.c:2200: warning: Function parameter or member 'dev' not described in 'try_toggle_control_gpio' drivers/net/ethernet/smsc/smc91x.c:2200: warning: Function parameter or member 'desc' not described in 'try_toggle_control_gpio' drivers/net/ethernet/smsc/smc91x.c:2200: warning: Function parameter or member 'name' not described in 'try_toggle_control_gpio' drivers/net/ethernet/smsc/smc91x.c:2200: warning: Function parameter or member 'index' not described in 'try_toggle_control_gpio' drivers/net/ethernet/smsc/smc91x.c:2200: warning: Function parameter or member 'value' not described in 'try_toggle_control_gpio' drivers/net/ethernet/smsc/smc91x.c:2200: warning: Function parameter or member 'nsdelay' not described in 'try_toggle_control_gpio' Cc: Nicolas Pitre Cc: "David S. Miller" Cc: Jakub Kicinski Cc: Erik Stahlman Cc: Peter Cammaert Cc: Daris A Nevil Cc: Russell King Cc: netdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/net/ethernet/smsc/smc91x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/smsc/smc91x.c b/drivers/net/ethernet/smsc/smc91x.c index 56c36798cb111..3b90dc065ff2d 100644 --- a/drivers/net/ethernet/smsc/smc91x.c +++ b/drivers/net/ethernet/smsc/smc91x.c @@ -2191,7 +2191,7 @@ static const struct of_device_id smc91x_match[] = { MODULE_DEVICE_TABLE(of, smc91x_match); #if defined(CONFIG_GPIOLIB) -/** +/* * of_try_set_control_gpio - configure a gpio if it exists * @dev: net device * @desc: where to store the GPIO descriptor, if it exists From patchwork Thu Nov 26 13:38:47 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1406675 Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=hfIUxVh9; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4Chf4X6ql6z9sWW for ; Fri, 27 Nov 2020 00:39:24 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390444AbgKZNjD (ORCPT ); Thu, 26 Nov 2020 08:39:03 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58202 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390368AbgKZNjB (ORCPT ); Thu, 26 Nov 2020 08:39:01 -0500 Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3FEA5C0617A7 for ; Thu, 26 Nov 2020 05:39:01 -0800 (PST) Received: by mail-wr1-x444.google.com with SMTP id l1so2176186wrb.9 for ; Thu, 26 Nov 2020 05:39:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=PvDQ8jiSdggfocg7QevhSStHyCThX2E8vELTACyHnVM=; b=hfIUxVh9cOOEk1+Xnm9Js0JYx8f+4mDVffWLE+RpCmxL0UzygV22nLn5ImHdR94WtJ V84dJowMWFbBc/vOV5VcNtNwABoiSipolRFrT0sotRub7aAlqP7agQXikgVrvCdA2QhE 1XMvyzZ2DaV11usuc9FgvVwCcGCAeKOuUfuG2YhlvYZaw/Cosi3dFUAOofTHESywFkhR lXBStbyPFd9fMWdFbVbWSRWZUoZaIwrvHuPNfaOuddOq/VwH+UM2FYbBPeQvNclUYX3v bWqIk2ZR8IZOZymlbf8n4zvsR+avPkwgP+ylWMDUOng9/e7F1EqjwxWl5IwWm0RAijtc 4L4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=PvDQ8jiSdggfocg7QevhSStHyCThX2E8vELTACyHnVM=; b=HhsYUMgcWbloGxgSF/tZokFM0BiavONcoTCgyTFAeld9sB9IN/o+0e0psA7BIE6yP/ pgMS014q8vbToQI7XwyaCrCoPHzzYF2ulQ20V5x/p1XH3W0maabOzS3IE1b8rxCQW9WC rPbDxgX5unB75mzAdQrfwTaIP6pFHP/bpSaetvO87P/x+xPOKjQmYJRf5BFrarGWdOA4 v3U6oFv9p39GEuIH/cFNZmmUvLnN6cqQVeV8diBTQyNzshiY9TWbQG+siF1+MQNOtomd taJEEcMSu4hRuQyQt2rUHvkorj8cc51hAvaFV6LW19muGynMyYWhaOfRetNUMJodJ2tE zhww== X-Gm-Message-State: AOAM531pfXdtXzGpkqlN7HaXA5i3arEMzQgxeBtonsZUvs2tiAyzkAzo GK2z9wmy5BF/H2OIisedgua+cw== X-Google-Smtp-Source: ABdhPJxxuDr0CFihwvoh9qXdvCtCohE03uRRltH7bO3tWEys9Iub2oFH9hIvPdZDltlla0WbomeVaw== X-Received: by 2002:adf:ed12:: with SMTP id a18mr3939773wro.5.1606397940009; Thu, 26 Nov 2020 05:39:00 -0800 (PST) Received: from dell.default ([91.110.221.235]) by smtp.gmail.com with ESMTPSA id s133sm7035825wmf.38.2020.11.26.05.38.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Nov 2020 05:38:59 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Wei Liu , Paul Durrant , "David S. Miller" , Jakub Kicinski , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , Rusty Russell , xen-devel@lists.xenproject.org, netdev@vger.kernel.org, bpf@vger.kernel.org Subject: [PATCH 2/8] net: xen-netback: xenbus: Demote nonconformant kernel-doc headers Date: Thu, 26 Nov 2020 13:38:47 +0000 Message-Id: <20201126133853.3213268-3-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201126133853.3213268-1-lee.jones@linaro.org> References: <20201126133853.3213268-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/net/xen-netback/xenbus.c:419: warning: Function parameter or member 'dev' not described in 'frontend_changed' drivers/net/xen-netback/xenbus.c:419: warning: Function parameter or member 'frontend_state' not described in 'frontend_changed' drivers/net/xen-netback/xenbus.c:1001: warning: Function parameter or member 'dev' not described in 'netback_probe' drivers/net/xen-netback/xenbus.c:1001: warning: Function parameter or member 'id' not described in 'netback_probe' Cc: Wei Liu Cc: Paul Durrant Cc: "David S. Miller" Cc: Jakub Kicinski Cc: Alexei Starovoitov Cc: Daniel Borkmann Cc: Jesper Dangaard Brouer Cc: John Fastabend Cc: Rusty Russell Cc: xen-devel@lists.xenproject.org Cc: netdev@vger.kernel.org Cc: bpf@vger.kernel.org Signed-off-by: Lee Jones Reviewed-by: Andrew Lunn --- drivers/net/xen-netback/xenbus.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/xen-netback/xenbus.c b/drivers/net/xen-netback/xenbus.c index f1c1624cec8f5..de1b5471d929b 100644 --- a/drivers/net/xen-netback/xenbus.c +++ b/drivers/net/xen-netback/xenbus.c @@ -411,7 +411,7 @@ static void read_xenbus_frontend_xdp(struct backend_info *be, vif->xdp_headroom = headroom; } -/** +/* * Callback received when the frontend's state changes. */ static void frontend_changed(struct xenbus_device *dev, @@ -992,7 +992,7 @@ static int netback_remove(struct xenbus_device *dev) return 0; } -/** +/* * Entry point to this code when a new device is created. Allocate the basic * structures and switch to InitWait. */ From patchwork Thu Nov 26 13:38:48 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1406676 Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=XQcUa9RJ; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4Chf4d3dw1z9sWY for ; Fri, 27 Nov 2020 00:39:29 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390516AbgKZNjF (ORCPT ); Thu, 26 Nov 2020 08:39:05 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58208 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390368AbgKZNjE (ORCPT ); Thu, 26 Nov 2020 08:39:04 -0500 Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 84EA6C0613D4 for ; Thu, 26 Nov 2020 05:39:02 -0800 (PST) Received: by mail-wr1-x442.google.com with SMTP id s8so2163228wrw.10 for ; Thu, 26 Nov 2020 05:39:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=szFDNNaKEVDZSNkDXGPen7gT5j56LfEHgacJ/wxEkwY=; b=XQcUa9RJyQ/gWcNlwnIDYsoz9CPu4L8xvrmIDJ592eF8o2DJIReBeKuEc+gq3RRIt/ nQPH+ufwSfcAaL79gTVRhMaOZMiJcnEbwQqiP3QYuxR7R/z6gos71eyI4Adzxafv5hNm vXsy+OuhjicOJnUejRk/8eALGEpjzxBm7D45YOIStx0Qhtc3zo/OSBnefvVKWryXENLY F5Hk0U55K0ORvu8H6H2hl3KqbQVkyuh3xmHx7NQ2ojjKsibIT6oH434LsgM+/cBPxa5J 6HaLrGMfOh/MCXSDhdbeUX7GBqmkVMj+Hv9eMwzP3iL3YK6MB5IksUSO5A0rnBSuoe4y lscA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=szFDNNaKEVDZSNkDXGPen7gT5j56LfEHgacJ/wxEkwY=; b=H+JicQaFozdRPQ39K1ASuYTvoY2ogXKqFW14rhIVJPBSa+jonwRejzuC7wQsmrP3wM WO86FSbRKTYMpWlmeACnEjeZyMMWX3qhnO89LkLoHIL6o7cvumyKRa1ssNpgaibz818t 9qJdQ2fSKnYFAsQb2YyFDymv10k2ul0bGrvwhrYp1VnW+Jtv+hTXvNmb3ahrHaCCK0vj dYkIQlo4Mfy+FIxXmApqhBu74UC53lhxe+Lw2zD+HK0t0rC8HN9cefVNWYaHPFcgc3fJ 3sNgx7MSBw6uZYcPnzYlUCMLWHv9eEirfcCgJp2RCu7+iHSYEnD/f5+5YA9+uSXziwgA 2YoA== X-Gm-Message-State: AOAM532nG/9yJtGtE39ik6rlse/02vY/fShSNdfcKy02eoyXMvIrHb0b FuwaTefHKLZ+/SBro1OAeGB9Yw== X-Google-Smtp-Source: ABdhPJyhCYTyjqMsQtRTV3z9ziWXG4cHAd3j08UndG1d38L+TaN2yXdvWRjgLSbALCW+AFDo3ljalA== X-Received: by 2002:adf:f1d2:: with SMTP id z18mr4168184wro.244.1606397941240; Thu, 26 Nov 2020 05:39:01 -0800 (PST) Received: from dell.default ([91.110.221.235]) by smtp.gmail.com with ESMTPSA id s133sm7035825wmf.38.2020.11.26.05.39.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Nov 2020 05:39:00 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, "David S. Miller" , Jakub Kicinski , Ivan Khoronzhuk , "Gustavo A. R. Silva" , netdev@vger.kernel.org Subject: [PATCH 3/8] net: ethernet: ti: am65-cpsw-qos: Demote non-conformant function header Date: Thu, 26 Nov 2020 13:38:48 +0000 Message-Id: <20201126133853.3213268-4-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201126133853.3213268-1-lee.jones@linaro.org> References: <20201126133853.3213268-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/net/ethernet/ti/am65-cpsw-qos.c:364: warning: Function parameter or member 'ndev' not described in 'am65_cpsw_timer_set' drivers/net/ethernet/ti/am65-cpsw-qos.c:364: warning: Function parameter or member 'est_new' not described in 'am65_cpsw_timer_set' Cc: "David S. Miller" Cc: Jakub Kicinski Cc: Ivan Khoronzhuk Cc: "Gustavo A. R. Silva" Cc: netdev@vger.kernel.org Signed-off-by: Lee Jones Reviewed-by: Andrew Lunn --- drivers/net/ethernet/ti/am65-cpsw-qos.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/ti/am65-cpsw-qos.c b/drivers/net/ethernet/ti/am65-cpsw-qos.c index 3bdd4dbcd2ff1..ebcc6386cc34a 100644 --- a/drivers/net/ethernet/ti/am65-cpsw-qos.c +++ b/drivers/net/ethernet/ti/am65-cpsw-qos.c @@ -356,7 +356,7 @@ static void am65_cpsw_est_set_sched_list(struct net_device *ndev, writel(~all_fetch_allow & AM65_CPSW_FETCH_ALLOW_MSK, ram_addr); } -/** +/* * Enable ESTf periodic output, set cycle start time and interval. */ static int am65_cpsw_timer_set(struct net_device *ndev, From patchwork Thu Nov 26 13:38:49 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1406677 Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=zW7MMznP; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4Chf4g4K99z9sWT for ; Fri, 27 Nov 2020 00:39:31 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390257AbgKZNjH (ORCPT ); Thu, 26 Nov 2020 08:39:07 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58216 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390368AbgKZNjF (ORCPT ); Thu, 26 Nov 2020 08:39:05 -0500 Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3EB09C0613D4 for ; Thu, 26 Nov 2020 05:39:04 -0800 (PST) Received: by mail-wr1-x441.google.com with SMTP id g14so2148400wrm.13 for ; Thu, 26 Nov 2020 05:39:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=asMRiFXnX8bIejsGLdsKd//d7tf76QwNOuS+l2qSTCE=; b=zW7MMznPCETTHz4zROspqv2du3yYqsKX1Nfw0azktaP1HEVWUt3rMdVPlaq6yXMbas 3yhr+cEAE3vWmkLa004JLlNztUcdiKLbHZX/WXD8OecqJaKU6rRdTr6KDwoTkxL3CNVO Hooa3JFwUyXKWcKVkVSPkM/see7T/+iT4C7uYPUhc1sKNCz8imewjTl8rkB6saX5y1DG xng30XCWW/ZPK5fflNXYYEHQxD8AmjRPSeOnBXjtkN6b0bd3oAHshuPsqWmy2fY+rpli lvsH3xtIxn2vT0ihIIc5DmsRf+yHHQeNPDHo2BOF78pRHtZqFTwoKteElv+IdzaQeBoW CHhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=asMRiFXnX8bIejsGLdsKd//d7tf76QwNOuS+l2qSTCE=; b=KUKbffCbb1O025dQSr5bpr/PgE/ehmKOHcs7zuxxnpoSYpnj16BZ+jeH+6GzAqncuH hTfsa/BhhZyTtmzWCpgbcl+gPDcDuxGlflGOhDZWLamXlN+4W5Md5EX6Hi2vb/J8UQmZ 2jE4Xxea/GH7zsDxSPE8zGi75CLov/mt3PwaemfIVRUVGBTpQXq/z/62hAGlU3qLobqp pWXDqMWrmR/txxG9XwcTqdXPjvBXHurS7XsKGGtIEOCbVS1qmdmDBehnXbHJrLwj9wXp p9bSSvs1nnI12XpDBUIBGzxlGBN/0fe9ZVD+g6PX6L8BGBQrpFNpltfYfZpnj6rsLkgL o6aw== X-Gm-Message-State: AOAM533FzJTXWIwfnuKwi2CV/pGvAVdho5K14fJXGRpu3n8EZFLr04eO zBeulGjvgr7vCaEMY8CuLJNuHTcLjT85b1Ce X-Google-Smtp-Source: ABdhPJzl4D8fEEpQ2tRn+/Qdw0W+XFDT2YGhmLvOlXBtJXOVwoqzejps9snDILVpDq6S1uQGjbdsEA== X-Received: by 2002:a5d:4087:: with SMTP id o7mr3778199wrp.27.1606397943010; Thu, 26 Nov 2020 05:39:03 -0800 (PST) Received: from dell.default ([91.110.221.235]) by smtp.gmail.com with ESMTPSA id s133sm7035825wmf.38.2020.11.26.05.39.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Nov 2020 05:39:02 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, "David S. Miller" , Jakub Kicinski , Grygorii Strashko , Kurt Kanzenbach , netdev@vger.kernel.org Subject: [PATCH 4/8] net: ethernet: ti: am65-cpts: Document am65_cpts_rx_enable()'s 'en' parameter Date: Thu, 26 Nov 2020 13:38:49 +0000 Message-Id: <20201126133853.3213268-5-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201126133853.3213268-1-lee.jones@linaro.org> References: <20201126133853.3213268-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/net/ethernet/ti/am65-cpts.c:736: warning: Function parameter or member 'en' not described in 'am65_cpts_rx_enable' drivers/net/ethernet/ti/am65-cpts.c:736: warning: Excess function parameter 'skb' description in 'am65_cpts_rx_enable' Cc: "David S. Miller" Cc: Jakub Kicinski Cc: Grygorii Strashko Cc: Kurt Kanzenbach Cc: netdev@vger.kernel.org Signed-off-by: Lee Jones Reviewed-by: Andrew Lunn --- drivers/net/ethernet/ti/am65-cpts.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/ti/am65-cpts.c b/drivers/net/ethernet/ti/am65-cpts.c index 5dc60ecabe561..9caaae79fc957 100644 --- a/drivers/net/ethernet/ti/am65-cpts.c +++ b/drivers/net/ethernet/ti/am65-cpts.c @@ -727,7 +727,7 @@ static long am65_cpts_ts_work(struct ptp_clock_info *ptp) /** * am65_cpts_rx_enable - enable rx timestamping * @cpts: cpts handle - * @skb: packet + * @en: enable * * This functions enables rx packets timestamping. The CPTS can timestamp all * rx packets. From patchwork Thu Nov 26 13:38:50 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1406681 Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=ASuVkVTc; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4Chf5C0Bl5z9sWD for ; Fri, 27 Nov 2020 00:39:59 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390585AbgKZNjb (ORCPT ); Thu, 26 Nov 2020 08:39:31 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58226 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390522AbgKZNjG (ORCPT ); Thu, 26 Nov 2020 08:39:06 -0500 Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 44CB3C0613D4 for ; Thu, 26 Nov 2020 05:39:06 -0800 (PST) Received: by mail-wr1-x444.google.com with SMTP id r3so2201416wrt.2 for ; Thu, 26 Nov 2020 05:39:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=J04TG1Pd2VMEs10XeVongpt36rd/B3l0W5A2vaR7ZWw=; b=ASuVkVTcgwd/WCUwH04MEIkheHtx5Wjw2rIYLxShk06kubCFMXm+otYbDyMnX4BqK7 Sw1YvK+F3whskVSDQyijQJWP7yXIzzCYuEDLCKtx2CaUJkAaRY1C2HtdJ2Z8I09aj+rp S7o4H42oKh3GRNmuAm5XHVbFFoICws/3LxAPUwMelCmfba3MAskBeFnhHo7SrMLj9Qzv pqCV6UV2zzo6SwVIk6pGdX+MUAIfe4Jcqn7ui7qfpp/Tex0G3XWC9wWhnwJfB/nUIj9q Op9fEXSZhUanQjdXi4sNoUK3Vohya2vRNVaOZcacB5tfg2zCCFjjNgHXL1xH6rtkqcV6 H9iw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=J04TG1Pd2VMEs10XeVongpt36rd/B3l0W5A2vaR7ZWw=; b=MXjMxmkih2S97j7Jj0PGRoDOr5oZmimDccPfKnkYLZMhEpCw9RAobO3NjZl+QFb4Gv uYA7Rvgtn6fJHG19kgb/LTI8VbE/O4QQdiQQAPaFf5zKTNLQ6N82YJOu2oHUQxAN+RNL 1BIPoxjATWb0DYHT5pTG8y1R5I1bIz+am/YNPByJcSeHmlX9PRqsxeASFeyQp6Pqqw+O i8dxQj8jGjXaOINedd/NTNFRamSZnAXlWj8YF7Ah9oP4cYKnvJMC0x64gaTOSQWO8vHb ThhaDITLOPbTcDPfcY+vLfjJaYR6bvwt4BnjfLTLbyrXIPz1evG/AjWzuUkX3YVXGlcs m37Q== X-Gm-Message-State: AOAM530WU1dGhr9w9x8LgAU6NkO1AXV81mRrPNWO6JOQlKzBR0w3WGtN mBD/MU6E9fax5pxuFi50JMpxLg== X-Google-Smtp-Source: ABdhPJyN8/8GK8ahfAZyW4Z6JsWycoHhBBqMueSu1OkgXz5UfUCb7Xd72OlnNvdvg9ydmIIzt1uCJQ== X-Received: by 2002:a5d:4cca:: with SMTP id c10mr3926754wrt.176.1606397944966; Thu, 26 Nov 2020 05:39:04 -0800 (PST) Received: from dell.default ([91.110.221.235]) by smtp.gmail.com with ESMTPSA id s133sm7035825wmf.38.2020.11.26.05.39.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Nov 2020 05:39:03 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Dany Madden , Lijun Pan , Sukadev Bhattiprolu , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , "David S. Miller" , Jakub Kicinski , Santiago Leon , Thomas Falcon , John Allen , netdev@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Subject: [PATCH 5/8] net: ethernet: ibm: ibmvnic: Fix some kernel-doc misdemeanours Date: Thu, 26 Nov 2020 13:38:50 +0000 Message-Id: <20201126133853.3213268-6-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201126133853.3213268-1-lee.jones@linaro.org> References: <20201126133853.3213268-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Fixes the following W=1 kernel build warning(s): from drivers/net/ethernet/ibm/ibmvnic.c:35: inlined from ‘handle_vpd_rsp’ at drivers/net/ethernet/ibm/ibmvnic.c:4124:3: drivers/net/ethernet/ibm/ibmvnic.c:1362: warning: Function parameter or member 'hdr_field' not described in 'build_hdr_data' drivers/net/ethernet/ibm/ibmvnic.c:1362: warning: Function parameter or member 'skb' not described in 'build_hdr_data' drivers/net/ethernet/ibm/ibmvnic.c:1362: warning: Function parameter or member 'hdr_len' not described in 'build_hdr_data' drivers/net/ethernet/ibm/ibmvnic.c:1362: warning: Function parameter or member 'hdr_data' not described in 'build_hdr_data' drivers/net/ethernet/ibm/ibmvnic.c:1423: warning: Function parameter or member 'hdr_field' not described in 'create_hdr_descs' drivers/net/ethernet/ibm/ibmvnic.c:1423: warning: Function parameter or member 'hdr_data' not described in 'create_hdr_descs' drivers/net/ethernet/ibm/ibmvnic.c:1423: warning: Function parameter or member 'len' not described in 'create_hdr_descs' drivers/net/ethernet/ibm/ibmvnic.c:1423: warning: Function parameter or member 'hdr_len' not described in 'create_hdr_descs' drivers/net/ethernet/ibm/ibmvnic.c:1423: warning: Function parameter or member 'scrq_arr' not described in 'create_hdr_descs' drivers/net/ethernet/ibm/ibmvnic.c:1474: warning: Function parameter or member 'txbuff' not described in 'build_hdr_descs_arr' drivers/net/ethernet/ibm/ibmvnic.c:1474: warning: Function parameter or member 'num_entries' not described in 'build_hdr_descs_arr' drivers/net/ethernet/ibm/ibmvnic.c:1474: warning: Function parameter or member 'hdr_field' not described in 'build_hdr_descs_arr' drivers/net/ethernet/ibm/ibmvnic.c:1832: warning: Function parameter or member 'adapter' not described in 'do_change_param_reset' drivers/net/ethernet/ibm/ibmvnic.c:1832: warning: Function parameter or member 'rwi' not described in 'do_change_param_reset' drivers/net/ethernet/ibm/ibmvnic.c:1832: warning: Function parameter or member 'reset_state' not described in 'do_change_param_reset' drivers/net/ethernet/ibm/ibmvnic.c:1911: warning: Function parameter or member 'adapter' not described in 'do_reset' drivers/net/ethernet/ibm/ibmvnic.c:1911: warning: Function parameter or member 'rwi' not described in 'do_reset' drivers/net/ethernet/ibm/ibmvnic.c:1911: warning: Function parameter or member 'reset_state' not described in 'do_reset' Cc: Dany Madden Cc: Lijun Pan Cc: Sukadev Bhattiprolu Cc: Michael Ellerman Cc: Benjamin Herrenschmidt Cc: Paul Mackerras Cc: "David S. Miller" Cc: Jakub Kicinski Cc: Santiago Leon Cc: Thomas Falcon Cc: John Allen Cc: netdev@vger.kernel.org Cc: linuxppc-dev@lists.ozlabs.org Signed-off-by: Lee Jones --- drivers/net/ethernet/ibm/ibmvnic.c | 28 ++++++++++++++-------------- drivers/net/xen-netfront.c | 6 +++--- 2 files changed, 17 insertions(+), 17 deletions(-) diff --git a/drivers/net/ethernet/ibm/ibmvnic.c b/drivers/net/ethernet/ibm/ibmvnic.c index b0884eba568d7..36ea37721e3c8 100644 --- a/drivers/net/ethernet/ibm/ibmvnic.c +++ b/drivers/net/ethernet/ibm/ibmvnic.c @@ -1376,10 +1376,10 @@ static int ibmvnic_close(struct net_device *netdev) /** * build_hdr_data - creates L2/L3/L4 header data buffer - * @hdr_field - bitfield determining needed headers - * @skb - socket buffer - * @hdr_len - array of header lengths - * @tot_len - total length of data + * @hdr_field: bitfield determining needed headers + * @skb: socket buffer + * @hdr_len: array of header lengths + * @tot_len: total length of data * * Reads hdr_field to determine which headers are needed by firmware. * Builds a buffer containing these headers. Saves individual header @@ -1436,11 +1436,11 @@ static int build_hdr_data(u8 hdr_field, struct sk_buff *skb, /** * create_hdr_descs - create header and header extension descriptors - * @hdr_field - bitfield determining needed headers - * @data - buffer containing header data - * @len - length of data buffer - * @hdr_len - array of individual header lengths - * @scrq_arr - descriptor array + * @hdr_field: bitfield determining needed headers + * @data: buffer containing header data + * @len: length of data buffer + * @hdr_len: array of individual header lengths + * @scrq_arr: descriptor array * * Creates header and, if needed, header extension descriptors and * places them in a descriptor array, scrq_arr @@ -1488,10 +1488,10 @@ static int create_hdr_descs(u8 hdr_field, u8 *hdr_data, int len, int *hdr_len, /** * build_hdr_descs_arr - build a header descriptor array - * @skb - socket buffer - * @num_entries - number of descriptors to be sent - * @subcrq - first TX descriptor - * @hdr_field - bit field determining which headers will be sent + * @skb: socket buffer + * @num_entries: number of descriptors to be sent + * @subcrq: first TX descriptor + * @hdr_field: bit field determining which headers will be sent * * This function will build a TX descriptor array with applicable * L2/L3/L4 packet header descriptors to be sent by send_subcrq_indirect. @@ -1997,7 +1997,7 @@ static int do_change_param_reset(struct ibmvnic_adapter *adapter, return 0; } -/** +/* * do_reset returns zero if we are able to keep processing reset events, or * non-zero if we hit a fatal error and must halt. */ diff --git a/drivers/net/xen-netfront.c b/drivers/net/xen-netfront.c index 920cac4385bf7..93740ef4cf1b4 100644 --- a/drivers/net/xen-netfront.c +++ b/drivers/net/xen-netfront.c @@ -1582,7 +1582,7 @@ static struct net_device *xennet_create_dev(struct xenbus_device *dev) return ERR_PTR(err); } -/** +/* * Entry point to this code when a new device is created. Allocate the basic * structures and the ring buffers for communication with the backend, and * inform the backend of the appropriate details for those. @@ -1659,7 +1659,7 @@ static void xennet_disconnect_backend(struct netfront_info *info) } } -/** +/* * We are reconnecting to the backend, due to a suspend/resume, or a backend * driver restart. We tear down our netif structure and recreate it, but * leave the device-layer structures intact so that this is transparent to the @@ -2305,7 +2305,7 @@ static int xennet_connect(struct net_device *dev) return 0; } -/** +/* * Callback received when the backend's state changes. */ static void netback_changed(struct xenbus_device *dev, From patchwork Thu Nov 26 13:38:51 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1406678 Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=MpLT1rTc; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4Chf4j4wZ8z9sWD for ; Fri, 27 Nov 2020 00:39:33 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390554AbgKZNjK (ORCPT ); Thu, 26 Nov 2020 08:39:10 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58234 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390368AbgKZNjH (ORCPT ); Thu, 26 Nov 2020 08:39:07 -0500 Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 930A2C0617A7 for ; Thu, 26 Nov 2020 05:39:07 -0800 (PST) Received: by mail-wr1-x443.google.com with SMTP id s8so2163504wrw.10 for ; Thu, 26 Nov 2020 05:39:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=DTJOzm0gZUliIM1CJNEOWqPKlNYApXefDQfPPtC85HY=; b=MpLT1rTcOQFXj5o4p45U25gq5Wthd5hRlOe6Ee20BztH8fDINAFaP0ZGPZrw/fdu38 SQDpyQIFeHvBMZPN84C6jFq3J/b9fMFZUIqyfyvASKnB4KKLD2TTzAPoMoOaBwcjGw0W Q/dLgkJXs8gJC3AhstDCm/oTI4DLuAkMXHGatvyRdaPI6XbX5O5rP642oQxh5iZCK86S gBKa8VwBXCPDpUt90nGEOfBD1oM7WZIuQofLaxEdI4/vzc2IhjdS4Y7G3j7IaZBOT7q2 4ENAa5iQyd+BgkiP2sMF01e4mBpRVZiTs7Wn2xKv4duAzKRegKdJkcE929j47H1/FM7t Sh4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=DTJOzm0gZUliIM1CJNEOWqPKlNYApXefDQfPPtC85HY=; b=Yw2ZCYP0vOsq4CFgyzwygD14DWyVEO7T23J0bycMvDGl5saFpuUNFDSCN1xQ4wwor8 r4vdIhpgqdpXAVrj8JmIe00g+6hVmXKXRKR5jRJRn/uTP1sNu3rdI2n38LbBBPyASqX2 pgSenAzu4yvH4x8dQQjKCGi9TGVB9gze183C1OsMvzYweeeGtSWxLygI6cznSdUbGeCF zlsEkKOxJi7fPL9mTVRSP+SDpSowG+R+ibJGuIOrtdiT+vqiJZXwwO3qpt6Um1xIlxYW dISZFZwO0eGuUrq0afkmUs84nItXr1eMy7XJ1dLueUr/m+vX6hiklYr2oFc+N68aIHfY LCrA== X-Gm-Message-State: AOAM531giokN1Iz84lSlCG46jSxeLrWjT7uylUpVi9eKDZv6aMOgmu+l BQTTNa0PWjUpNJBqVx/r8ULJ7w== X-Google-Smtp-Source: ABdhPJy76iTnF7RZ2IDKEHoxBDI4A4RdHy3hLm2gVUChhl9eVgcpueWg4kEabKQmMRsE+zIvq6jEcQ== X-Received: by 2002:adf:e551:: with SMTP id z17mr3940424wrm.374.1606397946311; Thu, 26 Nov 2020 05:39:06 -0800 (PST) Received: from dell.default ([91.110.221.235]) by smtp.gmail.com with ESMTPSA id s133sm7035825wmf.38.2020.11.26.05.39.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Nov 2020 05:39:05 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Geoff Levand , "David S. Miller" , Jakub Kicinski , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Utz Bacher , Jens Osterkamp , netdev@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Subject: [PATCH 6/8] net: ethernet: toshiba: ps3_gelic_net: Fix some kernel-doc misdemeanours Date: Thu, 26 Nov 2020 13:38:51 +0000 Message-Id: <20201126133853.3213268-7-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201126133853.3213268-1-lee.jones@linaro.org> References: <20201126133853.3213268-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/net/ethernet/toshiba/ps3_gelic_net.c:1107: warning: Function parameter or member 'irq' not described in 'gelic_card_interrupt' drivers/net/ethernet/toshiba/ps3_gelic_net.c:1107: warning: Function parameter or member 'ptr' not described in 'gelic_card_interrupt' drivers/net/ethernet/toshiba/ps3_gelic_net.c:1407: warning: Function parameter or member 'txqueue' not described in 'gelic_net_tx_timeout' drivers/net/ethernet/toshiba/ps3_gelic_net.c:1439: warning: Function parameter or member 'napi' not described in 'gelic_ether_setup_netdev_ops' drivers/net/ethernet/toshiba/ps3_gelic_net.c:1639: warning: Function parameter or member 'dev' not described in 'ps3_gelic_driver_probe' drivers/net/ethernet/toshiba/ps3_gelic_net.c:1795: warning: Function parameter or member 'dev' not described in 'ps3_gelic_driver_remove' Cc: Geoff Levand Cc: "David S. Miller" Cc: Jakub Kicinski Cc: Michael Ellerman Cc: Benjamin Herrenschmidt Cc: Paul Mackerras Cc: Utz Bacher Cc: Jens Osterkamp Cc: netdev@vger.kernel.org Cc: linuxppc-dev@lists.ozlabs.org Signed-off-by: Lee Jones Reviewed-by: Andrew Lunn --- drivers/net/ethernet/toshiba/ps3_gelic_net.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/toshiba/ps3_gelic_net.c b/drivers/net/ethernet/toshiba/ps3_gelic_net.c index d9a5722f561b5..f886e23f8ed0a 100644 --- a/drivers/net/ethernet/toshiba/ps3_gelic_net.c +++ b/drivers/net/ethernet/toshiba/ps3_gelic_net.c @@ -1100,7 +1100,7 @@ static int gelic_net_poll(struct napi_struct *napi, int budget) return packets_done; } -/** +/* * gelic_card_interrupt - event handler for gelic_net */ static irqreturn_t gelic_card_interrupt(int irq, void *ptr) @@ -1400,6 +1400,7 @@ static void gelic_net_tx_timeout_task(struct work_struct *work) /** * gelic_net_tx_timeout - called when the tx timeout watchdog kicks in. * @netdev: interface device structure + * @txqueue: unused * * called, if tx hangs. Schedules a task that resets the interface */ @@ -1431,6 +1432,7 @@ static const struct net_device_ops gelic_netdevice_ops = { /** * gelic_ether_setup_netdev_ops - initialization of net_device operations * @netdev: net_device structure + * @napi: napi structure * * fills out function pointers in the net_device structure */ @@ -1632,7 +1634,7 @@ static void gelic_card_get_vlan_info(struct gelic_card *card) dev_info(ctodev(card), "internal vlan %s\n", card->vlan_required? "enabled" : "disabled"); } -/** +/* * ps3_gelic_driver_probe - add a device to the control of this driver */ static int ps3_gelic_driver_probe(struct ps3_system_bus_device *dev) @@ -1787,10 +1789,9 @@ static int ps3_gelic_driver_probe(struct ps3_system_bus_device *dev) return result; } -/** +/* * ps3_gelic_driver_remove - remove a device from the control of this driver */ - static int ps3_gelic_driver_remove(struct ps3_system_bus_device *dev) { struct gelic_card *card = ps3_system_bus_get_drvdata(dev); From patchwork Thu Nov 26 13:38:52 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1406680 Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=UEZU7070; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4Chf55469Zz9sWD for ; Fri, 27 Nov 2020 00:39:53 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390569AbgKZNjW (ORCPT ); Thu, 26 Nov 2020 08:39:22 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58242 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390543AbgKZNjJ (ORCPT ); Thu, 26 Nov 2020 08:39:09 -0500 Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CC865C0617A7 for ; Thu, 26 Nov 2020 05:39:08 -0800 (PST) Received: by mail-wr1-x444.google.com with SMTP id 23so2176256wrc.8 for ; Thu, 26 Nov 2020 05:39:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=x/23In7GphBjuvLzsFPzeVbxW1AkJoC7VMLuq9ClVEg=; b=UEZU7070gAWrlkVS/SYDGQ+9C95/de63HCNZ65/cX/5BWpx/6BcM7agMCTUeKx/06w 69/AsA5jdtT3qRFfxI6HF+jy5/obbKLu0FOteMDf9qbcZnraymJGR5vzEq/tg8lERYOf wmfr2Gev2IkGxLru4olxTDfHTQ9DQB1eztZliBIUoQj+dVsnduLoyv8SCulplTL7Pg3C 5/tA2LWbNxRbXYQZRAfREtCjyc7da6PPF+w9uL2dKRlfzd4sw1De4odDvMiRHblF82FI 4Id0tHmnrwkdwLpcZ91rH635Ti5iYzvsOAgvUyAiYQd6caMi4BfYa3o6NMZ99CfGwZ96 zeDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=x/23In7GphBjuvLzsFPzeVbxW1AkJoC7VMLuq9ClVEg=; b=jzQ0ZGg1wL4gU/gIcFsJLsK4XD19cgvf5XEN1b+/yhtNTXYKWtnYEnycK8ayaIYaY5 lzS3G6DfQ2KOuKKUEvriK2INr/xB2GXZofSekZ9v/IKZtexHEOkiLvMfzFuIAGghzE5I CyVf4k6yvKxwTzsBDeGFWwOx3PNBtgAHfrHbwnhDbgjtePJ3bqM6nvXxQqM0Fm3CLBb0 HB1DuoQPAigABIoCdmb5/R0FgxlQNe8I4051O/+OM3Mc00zKafvJdEGh1HgdfVenXbuJ XYHu3IwmHKz2caZvF+Kebug0PLshvtbh//zooSPEKkSaygIo4ko7lsY54chPkmMBnroI hVNw== X-Gm-Message-State: AOAM5318P5SAzHt8lGEelu+MGIizBAUCpIwm5xIrYLvGecKvj81wCr2M 4RuJQyDUKxsEdrM4uBHXg3K+VwSDp7SbE1vC X-Google-Smtp-Source: ABdhPJxSopU6jVkoXk+6uS11exgwGi6kmMxE34CJKNAI1nyYQxx9mod7s9FvAbxeTyST+kFeTclXAQ== X-Received: by 2002:a5d:4349:: with SMTP id u9mr3805104wrr.319.1606397947553; Thu, 26 Nov 2020 05:39:07 -0800 (PST) Received: from dell.default ([91.110.221.235]) by smtp.gmail.com with ESMTPSA id s133sm7035825wmf.38.2020.11.26.05.39.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Nov 2020 05:39:06 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Ishizaki Kou , "David S. Miller" , Jakub Kicinski , Utz Bacher , Jens Osterkamp , netdev@vger.kernel.org Subject: [PATCH 7/8] net: ethernet: toshiba: spider_net: Document a whole bunch of function parameters Date: Thu, 26 Nov 2020 13:38:52 +0000 Message-Id: <20201126133853.3213268-8-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201126133853.3213268-1-lee.jones@linaro.org> References: <20201126133853.3213268-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/net/ethernet/toshiba/spider_net.c:263: warning: Function parameter or member 'hwdescr' not described in 'spider_net_get_descr_status' drivers/net/ethernet/toshiba/spider_net.c:263: warning: Excess function parameter 'descr' description in 'spider_net_get_descr_status' drivers/net/ethernet/toshiba/spider_net.c:554: warning: Function parameter or member 'netdev' not described in 'spider_net_get_multicast_hash' drivers/net/ethernet/toshiba/spider_net.c:902: warning: Function parameter or member 't' not described in 'spider_net_cleanup_tx_ring' drivers/net/ethernet/toshiba/spider_net.c:902: warning: Excess function parameter 'card' description in 'spider_net_cleanup_tx_ring' drivers/net/ethernet/toshiba/spider_net.c:1074: warning: Function parameter or member 'card' not described in 'spider_net_resync_head_ptr' drivers/net/ethernet/toshiba/spider_net.c:1234: warning: Function parameter or member 'napi' not described in 'spider_net_poll' drivers/net/ethernet/toshiba/spider_net.c:1234: warning: Excess function parameter 'netdev' description in 'spider_net_poll' drivers/net/ethernet/toshiba/spider_net.c:1278: warning: Function parameter or member 'p' not described in 'spider_net_set_mac' drivers/net/ethernet/toshiba/spider_net.c:1278: warning: Excess function parameter 'ptr' description in 'spider_net_set_mac' drivers/net/ethernet/toshiba/spider_net.c:1350: warning: Function parameter or member 'error_reg1' not described in 'spider_net_handle_error_irq' drivers/net/ethernet/toshiba/spider_net.c:1350: warning: Function parameter or member 'error_reg2' not described in 'spider_net_handle_error_irq' drivers/net/ethernet/toshiba/spider_net.c:1968: warning: Function parameter or member 't' not described in 'spider_net_link_phy' drivers/net/ethernet/toshiba/spider_net.c:1968: warning: Excess function parameter 'data' description in 'spider_net_link_phy' drivers/net/ethernet/toshiba/spider_net.c:2149: warning: Function parameter or member 'work' not described in 'spider_net_tx_timeout_task' drivers/net/ethernet/toshiba/spider_net.c:2149: warning: Excess function parameter 'data' description in 'spider_net_tx_timeout_task' drivers/net/ethernet/toshiba/spider_net.c:2182: warning: Function parameter or member 'txqueue' not described in 'spider_net_tx_timeout' Cc: Ishizaki Kou Cc: "David S. Miller" Cc: Jakub Kicinski Cc: Utz Bacher Cc: Jens Osterkamp Cc: netdev@vger.kernel.org Signed-off-by: Lee Jones Reviewed-by: Andrew Lunn --- drivers/net/ethernet/toshiba/spider_net.c | 18 +++++++++++------- 1 file changed, 11 insertions(+), 7 deletions(-) diff --git a/drivers/net/ethernet/toshiba/spider_net.c b/drivers/net/ethernet/toshiba/spider_net.c index 5f5b33e6653b2..d5a75ef7e3ca9 100644 --- a/drivers/net/ethernet/toshiba/spider_net.c +++ b/drivers/net/ethernet/toshiba/spider_net.c @@ -254,7 +254,7 @@ spider_net_set_promisc(struct spider_net_card *card) /** * spider_net_get_descr_status -- returns the status of a descriptor - * @descr: descriptor to look at + * @hwdescr: descriptor to look at * * returns the status as in the dmac_cmd_status field of the descriptor */ @@ -542,6 +542,7 @@ spider_net_alloc_rx_skbs(struct spider_net_card *card) /** * spider_net_get_multicast_hash - generates hash for multicast filter table + * @netdev: interface device structure * @addr: multicast address * * returns the hash value. @@ -890,7 +891,7 @@ spider_net_xmit(struct sk_buff *skb, struct net_device *netdev) /** * spider_net_cleanup_tx_ring - cleans up the TX ring - * @card: card structure + * @t: timer context used to obtain the pointer to net card data structure * * spider_net_cleanup_tx_ring is called by either the tx_timer * or from the NAPI polling routine. @@ -1063,6 +1064,7 @@ static void show_rx_chain(struct spider_net_card *card) /** * spider_net_resync_head_ptr - Advance head ptr past empty descrs + * @card: card structure * * If the driver fails to keep up and empty the queue, then the * hardware wil run out of room to put incoming packets. This @@ -1220,7 +1222,7 @@ spider_net_decode_one_descr(struct spider_net_card *card) /** * spider_net_poll - NAPI poll function called by the stack to return packets - * @netdev: interface device structure + * @napi: napi device structure * @budget: number of packets we can pass to the stack at most * * returns 0 if no more packets available to the driver/stack. Returns 1, @@ -1268,7 +1270,7 @@ static int spider_net_poll(struct napi_struct *napi, int budget) /** * spider_net_set_mac - sets the MAC of an interface * @netdev: interface device structure - * @ptr: pointer to new MAC address + * @p: pointer to new MAC address * * Returns 0 on success, <0 on failure. Currently, we don't support this * and will always return EOPNOTSUPP. @@ -1340,6 +1342,8 @@ spider_net_link_reset(struct net_device *netdev) * spider_net_handle_error_irq - handles errors raised by an interrupt * @card: card structure * @status_reg: interrupt status register 0 (GHIINT0STS) + * @error_reg1: interrupt status register 1 (GHIINT1STS) + * @error_reg2: interrupt status register 2 (GHIINT2STS) * * spider_net_handle_error_irq treats or ignores all error conditions * found when an interrupt is presented @@ -1961,8 +1965,7 @@ spider_net_open(struct net_device *netdev) /** * spider_net_link_phy - * @data: used for pointer to card structure - * + * @t: timer context used to obtain the pointer to net card data structure */ static void spider_net_link_phy(struct timer_list *t) { @@ -2140,7 +2143,7 @@ spider_net_stop(struct net_device *netdev) /** * spider_net_tx_timeout_task - task scheduled by the watchdog timeout * function (to be called not under interrupt status) - * @data: data, is interface device structure + * @work: work context used to obtain the pointer to net card data structure * * called as task when tx hangs, resets interface (if interface is up) */ @@ -2174,6 +2177,7 @@ spider_net_tx_timeout_task(struct work_struct *work) /** * spider_net_tx_timeout - called when the tx timeout watchdog kicks in. * @netdev: interface device structure + * @txqueue: unused * * called, if tx hangs. Schedules a task that resets the interface */ From patchwork Thu Nov 26 13:38:53 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1406679 Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=CRjmklKz; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4Chf4s56zqz9sWD for ; Fri, 27 Nov 2020 00:39:41 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390013AbgKZNjR (ORCPT ); Thu, 26 Nov 2020 08:39:17 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58248 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389552AbgKZNjL (ORCPT ); Thu, 26 Nov 2020 08:39:11 -0500 Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5EEC7C0617A7 for ; Thu, 26 Nov 2020 05:39:10 -0800 (PST) Received: by mail-wr1-x444.google.com with SMTP id z7so2187831wrn.3 for ; Thu, 26 Nov 2020 05:39:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=xRpAJlbq6+V+ePZQw5yqXL7428RUL9OWlsKS5RA6BKg=; b=CRjmklKzjv8jTVM8y5ehKKzL+Eel4+NeZfyvFpAJcJJCxkpaa/dQY/KI+1cxh1uKQ4 x31XOW25cX4mFhG9B7f7Iq2OIMx1+YfwDvE8nsKg8nvngYAjmgAV1fdsiTKsLKsqr20d AVbJvZ+6JOoefJT03HN8cVZvAS/fcbeQr1wDFZHm80j3PrkvXxeRl91q4S97uqp5DDi6 c8V8JkOpiN+wGrHi1sLekRUKouPglPzl1kSpPXorZqMDILV4Mo6Nd0z19ltIH1Hu0zoN wUZihn3nrw73DDDpfNkwdhmP6qJozeDF8vGvP60mgCrsT6gXef46skpBc28THKvD2tXQ 6Iwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=xRpAJlbq6+V+ePZQw5yqXL7428RUL9OWlsKS5RA6BKg=; b=rXeXeaOKTH3O6pdbJZRh0JlT04HMwrtFCRzetSRbeNXk5Zrqr+DUkWA1yoXNWpzRdW M8dqdjCD3XS2lpdduRI88BP9dVktYZaJIgOcqNaaFSj7z2loARCPzcFC+053X5l0v9r9 EgsSU7lvu208V/TOS+TVkrMoW/Chnxg68pPHMsqQT8DGAbVDZlo+6paX7Ov+wtXEE40b Q/Mg3uR52tXs8391xRt/6N566a5sl/sy1qAgzSocEt4fYCSaaahDNmoXzFwqBrL4/ojl 2KNFqHDH5+7cDIYBeTK5XwgN/jIzCkKCVJHKAZG2NPtsDyLzUR0jQNkrb80LyGmPGlOG skkw== X-Gm-Message-State: AOAM533UX3YOHlzXkzPr9usWrlEdC0sWyYg9+0CXLGUQwqFZvoXSnLug apymMt176/tS+VH2JJbIBkujkw== X-Google-Smtp-Source: ABdhPJyLZT0V4+zVqDNFo6SwnsBmTFtnBfv+6D8SII+64k4pMDJ9qNUY8G8xUyMfkpwcg4n/U1GplQ== X-Received: by 2002:a5d:66cd:: with SMTP id k13mr3908174wrw.365.1606397949075; Thu, 26 Nov 2020 05:39:09 -0800 (PST) Received: from dell.default ([91.110.221.235]) by smtp.gmail.com with ESMTPSA id s133sm7035825wmf.38.2020.11.26.05.39.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Nov 2020 05:39:08 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Dany Madden , Lijun Pan , Sukadev Bhattiprolu , "David S. Miller" , Jakub Kicinski , Santiago Leon , Thomas Falcon , John Allen , linuxppc-dev@lists.ozlabs.org, netdev@vger.kernel.org Subject: [PATCH 8/8] net: ethernet: ibm: ibmvnic: Fix some kernel-doc issues Date: Thu, 26 Nov 2020 13:38:53 +0000 Message-Id: <20201126133853.3213268-9-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201126133853.3213268-1-lee.jones@linaro.org> References: <20201126133853.3213268-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Fixes the following W=1 kernel build warning(s): from drivers/net/ethernet/ibm/ibmvnic.c:35: inlined from ‘handle_vpd_rsp’ at drivers/net/ethernet/ibm/ibmvnic.c:4124:3: drivers/net/ethernet/ibm/ibmvnic.c:1362: warning: Function parameter or member 'hdr_data' not described in 'build_hdr_data' drivers/net/ethernet/ibm/ibmvnic.c:1362: warning: Excess function parameter 'tot_len' description in 'build_hdr_data' drivers/net/ethernet/ibm/ibmvnic.c:1423: warning: Function parameter or member 'hdr_data' not described in 'create_hdr_descs' drivers/net/ethernet/ibm/ibmvnic.c:1423: warning: Excess function parameter 'data' description in 'create_hdr_descs' drivers/net/ethernet/ibm/ibmvnic.c:1474: warning: Function parameter or member 'txbuff' not described in 'build_hdr_descs_arr' drivers/net/ethernet/ibm/ibmvnic.c:1474: warning: Excess function parameter 'skb' description in 'build_hdr_descs_arr' drivers/net/ethernet/ibm/ibmvnic.c:1474: warning: Excess function parameter 'subcrq' description in 'build_hdr_descs_arr' Cc: Michael Ellerman Cc: Benjamin Herrenschmidt Cc: Paul Mackerras Cc: Dany Madden Cc: Lijun Pan Cc: Sukadev Bhattiprolu Cc: "David S. Miller" Cc: Jakub Kicinski Cc: Santiago Leon Cc: Thomas Falcon Cc: John Allen Cc: linuxppc-dev@lists.ozlabs.org Cc: netdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/net/ethernet/ibm/ibmvnic.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/ibm/ibmvnic.c b/drivers/net/ethernet/ibm/ibmvnic.c index 36ea37721e3c8..0687f6cb0c7a2 100644 --- a/drivers/net/ethernet/ibm/ibmvnic.c +++ b/drivers/net/ethernet/ibm/ibmvnic.c @@ -1379,7 +1379,7 @@ static int ibmvnic_close(struct net_device *netdev) * @hdr_field: bitfield determining needed headers * @skb: socket buffer * @hdr_len: array of header lengths - * @tot_len: total length of data + * @hdr_data: buffer to write the header to * * Reads hdr_field to determine which headers are needed by firmware. * Builds a buffer containing these headers. Saves individual header @@ -1437,7 +1437,7 @@ static int build_hdr_data(u8 hdr_field, struct sk_buff *skb, /** * create_hdr_descs - create header and header extension descriptors * @hdr_field: bitfield determining needed headers - * @data: buffer containing header data + * @hdr_data: buffer containing header data * @len: length of data buffer * @hdr_len: array of individual header lengths * @scrq_arr: descriptor array @@ -1488,9 +1488,8 @@ static int create_hdr_descs(u8 hdr_field, u8 *hdr_data, int len, int *hdr_len, /** * build_hdr_descs_arr - build a header descriptor array - * @skb: socket buffer + * @txbuff: tx buffer * @num_entries: number of descriptors to be sent - * @subcrq: first TX descriptor * @hdr_field: bit field determining which headers will be sent * * This function will build a TX descriptor array with applicable