From patchwork Tue Nov 24 17:14:52 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Philipp Tomsich X-Patchwork-Id: 1405734 X-Patchwork-Delegate: sjg@chromium.org Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=85.214.62.61; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=vrull.eu Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=vrull-eu.20150623.gappssmtp.com header.i=@vrull-eu.20150623.gappssmtp.com header.a=rsa-sha256 header.s=20150623 header.b=ek8MyuBR; dkim-atps=neutral Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4Cgb613J6cz9s0b for ; Wed, 25 Nov 2020 07:22:01 +1100 (AEDT) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 7546E82607; Tue, 24 Nov 2020 21:21:35 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=vrull.eu Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=vrull-eu.20150623.gappssmtp.com header.i=@vrull-eu.20150623.gappssmtp.com header.b="ek8MyuBR"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id C2085825D0; Tue, 24 Nov 2020 18:15:35 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,SPF_HELO_NONE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from mail-lf1-x12a.google.com (mail-lf1-x12a.google.com [IPv6:2a00:1450:4864:20::12a]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id CF86C825EC for ; Tue, 24 Nov 2020 18:15:25 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=vrull.eu Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=philipp.tomsich@vrull.eu Received: by mail-lf1-x12a.google.com with SMTP id a9so29953801lfh.2 for ; Tue, 24 Nov 2020 09:15:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vrull-eu.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id; bh=k++UjmnDi/rf7hTYKhSxis+B6iB594BvVN6nm6iFjSw=; b=ek8MyuBRhazNTHzGYUUHnTPagD6JIJSzI1gPM0NsMwFdb4YjEMwwdc+5fuonde7HU2 DrEfBvvtBlpP0V3FO1bFXfbsnBMLb7xcKhweZ68oY2N/3VtzjO/dWRexcWun+5GcPeH9 Lt9j+xxEZdrqSzWrMoP00kg6BHLQjntO8qhvX/l+c4A5HZpBinCve8c+AWDAauF4AkDW aPN2IPjokSajeF+bHAr0RMhmR/l1UilYJFwa5+nElMYIFi8g72Ge2p7pUh5El1oz9t3Q GKnmABF5stMUgzQdM3LkQ0Uy4EYt7Y+wMc6WZsUK98n5iMprhtduC0vyP8lOcv2mHwAt AL9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=k++UjmnDi/rf7hTYKhSxis+B6iB594BvVN6nm6iFjSw=; b=XvpLe3Z6MD4/S8Gup6CCKK1j/XDf0yFXRLpGmAQbyzjgz7RviOeyf+ZvtMEf7V6XWL dJ7VWrzV3/pPhQk2yfFldhzotjR6vfzbIWbjjPH8nhLZ8iX27WHuhrBZCTmseqpEGoHz waN6WJLH2Xz/FpVxFPFnyLvDqgekBXjri5q+3ETgkvhi+mMdFmSTF62nmzEPhisvb7eP yZ3MXDGlZE3sK9IY/jxsq3LDaX7w05u2+TcErdp7+xhdjleTv7EmqqHNoGBx0q5MgaP4 a0m4jTYA775qcep5qRbTLMa1K7cBGdsDIjUktiO5rU+pOcpOERvgvc0HmASoYLdioMtZ 7xsg== X-Gm-Message-State: AOAM530Z3tsyqUB8Eph07qTO69GO7+o+NHupmqjE+Z7E20ra83V9aGKh q4Sv8k4CpGW+AFvCrq1/lHgtOTbcd+vWuQ== X-Google-Smtp-Source: ABdhPJwzjVvsK1CJVlH8Ukwmq03FD98V+XjNr33Sv/++0qP56WRgiMpWbGgpak50yZ1kLISLg2niCQ== X-Received: by 2002:a19:bce:: with SMTP id 197mr2346642lfl.468.1606238109841; Tue, 24 Nov 2020 09:15:09 -0800 (PST) Received: from centos7.localdomain (static.214.61.181.135.clients.your-server.de. [135.181.61.214]) by smtp.gmail.com with ESMTPSA id x24sm393200ljj.112.2020.11.24.09.15.08 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 24 Nov 2020 09:15:09 -0800 (PST) From: Philipp Tomsich To: u-boot@lists.denx.de Cc: Simon Glass , Philipp Tomsich Subject: [PATCH 1/3] patman: Add --no-signoff to suppress adding signoffs Date: Tue, 24 Nov 2020 18:14:52 +0100 Message-Id: <1606238094-28940-1-git-send-email-philipp.tomsich@vrull.eu> X-Mailer: git-send-email 1.8.3.1 X-Mailman-Approved-At: Tue, 24 Nov 2020 21:21:28 +0100 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.102.3 at phobos.denx.de X-Virus-Status: Clean To enable use of patman with FSF/GNU projects, such as GCC or Binutils, no Signed-off-by may be added. This adds a command line flag '--no-signoff' to suppress adding signoffs in patman when processing commits. Signed-off-by: Philipp Tomsich Reviewed-by: Simon Glass Reviewed-by: Simon Glass --- tools/patman/control.py | 6 +++--- tools/patman/gitutil.py | 6 ++++-- tools/patman/main.py | 2 ++ 3 files changed, 9 insertions(+), 5 deletions(-) diff --git a/tools/patman/control.py b/tools/patman/control.py index 2330682..ee9717c 100644 --- a/tools/patman/control.py +++ b/tools/patman/control.py @@ -20,7 +20,7 @@ def setup(): """Do required setup before doing anything""" gitutil.Setup() -def prepare_patches(col, branch, count, start, end, ignore_binary): +def prepare_patches(col, branch, count, start, end, ignore_binary, signoff): """Figure out what patches to generate, then generate them The patch files are written to the current directory, e.g. 0001_xxx.patch @@ -56,7 +56,7 @@ def prepare_patches(col, branch, count, start, end, ignore_binary): to_do = count - end series = patchstream.get_metadata(branch, start, to_do) cover_fname, patch_files = gitutil.CreatePatches( - branch, start, to_do, ignore_binary, series) + branch, start, to_do, ignore_binary, series, signoff) # Fix up the patch files to our liking, and insert the cover letter patchstream.fix_patches(series, patch_files) @@ -163,7 +163,7 @@ def send(args): col = terminal.Color() series, cover_fname, patch_files = prepare_patches( col, args.branch, args.count, args.start, args.end, - args.ignore_binary) + args.ignore_binary, args.add_signoff) ok = check_patches(series, patch_files, args.check_patch, args.verbose) diff --git a/tools/patman/gitutil.py b/tools/patman/gitutil.py index 31fb3b2..5736d37 100644 --- a/tools/patman/gitutil.py +++ b/tools/patman/gitutil.py @@ -305,7 +305,7 @@ def PruneWorktrees(git_dir): if result.return_code != 0: raise OSError('git worktree prune: %s' % result.stderr) -def CreatePatches(branch, start, count, ignore_binary, series): +def CreatePatches(branch, start, count, ignore_binary, series, signoff = True): """Create a series of patches from the top of the current branch. The patch files are written to the current directory using @@ -323,7 +323,9 @@ def CreatePatches(branch, start, count, ignore_binary, series): """ if series.get('version'): version = '%s ' % series['version'] - cmd = ['git', 'format-patch', '-M', '--signoff'] + cmd = ['git', 'format-patch', '-M' ] + if signoff: + cmd.append('--signoff') if ignore_binary: cmd.append('--no-binary') if series.get('cover'): diff --git a/tools/patman/main.py b/tools/patman/main.py index 342fd44..c4e4d80 100755 --- a/tools/patman/main.py +++ b/tools/patman/main.py @@ -81,6 +81,8 @@ send.add_argument('--no-check', action='store_false', dest='check_patch', help="Don't check for patch compliance") send.add_argument('--no-tags', action='store_false', dest='process_tags', default=True, help="Don't process subject tags as aliases") +send.add_argument('--no-signoff', action='store_false', dest='add_signoff', + default=True, help="Don't add Signed-off-by to patches") send.add_argument('--smtp-server', type=str, help="Specify the SMTP server to 'git send-email'") From patchwork Tue Nov 24 17:14:53 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Philipp Tomsich X-Patchwork-Id: 1405733 X-Patchwork-Delegate: sjg@chromium.org Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=vrull.eu Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=vrull-eu.20150623.gappssmtp.com header.i=@vrull-eu.20150623.gappssmtp.com header.a=rsa-sha256 header.s=20150623 header.b=Yb7MABwO; dkim-atps=neutral Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4Cgb5w0dzXz9s0b for ; Wed, 25 Nov 2020 07:21:56 +1100 (AEDT) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 91126825FB; Tue, 24 Nov 2020 21:21:32 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=vrull.eu Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=vrull-eu.20150623.gappssmtp.com header.i=@vrull-eu.20150623.gappssmtp.com header.b="Yb7MABwO"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id B65C8825E3; Tue, 24 Nov 2020 18:15:21 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,SPF_HELO_NONE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from mail-lj1-x22e.google.com (mail-lj1-x22e.google.com [IPv6:2a00:1450:4864:20::22e]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id BFBAF825C4 for ; Tue, 24 Nov 2020 18:15:14 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=vrull.eu Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=philipp.tomsich@vrull.eu Received: by mail-lj1-x22e.google.com with SMTP id o24so22902166ljj.6 for ; Tue, 24 Nov 2020 09:15:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vrull-eu.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=ck16Fa17rVMnbQ8hb4HbGoJDbmdfrSwuReTwpZc3KM8=; b=Yb7MABwObwa+AQhwiMH64HBcq/1CKF5FC3IUpEbe1Yq2khCErkxKvj6YtEoObdF4qi iWoEeT7qn3PMnW1IDBdlZtZeZV1cTMJeiHxTXrXISz8g0M0iTq4CjgzAS9MEqoqlDqkS W/od0BbVbJIKlnNcKTJyVbmr0ciXk+0l56jaB7l7B+WtDeG8lRLRjeXstw4TRRCMFfj+ qpr8t1dnq7w9aQVDy8ntNkhgP4mpUGtZXapdaLn6uHOlLi9gIOoMC2RRMYC/LkJhpCsz 5ZUoHTQI+BEh7m8abRA6b1se2BXv1OTNW8zB1xqQP+IpbrmXDJzSluMX5Bu6ywd+zv3n nZng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=ck16Fa17rVMnbQ8hb4HbGoJDbmdfrSwuReTwpZc3KM8=; b=qDY9FqIHUMTOkxh/oM51xnt2dADelSmIGr3tcVpcIgpTSW7yPNWHZ5QbnJjhDDBurx 8p7fo5Gbm6cEUxwAjGtdj+7xvx2xRahfrIPqe8GciUf29zziifWUyEHQ04dDbevJXYAP j100w+zbn3Uzs0FdHnQdKgn/EALgy3VHndkytGyhn53PTAQd2t43N/ELXVOrECunED64 vuABLv1/eA8N6HD8H69jY+zlbmr7IdtdEeznnQdN6CK36oDKetVXyW7jS3KTaikH4+WE sO529PVak4suA2ANxSqwEXqUP32m3E4+uHBbdkDQoT7KKNq+LsQWQnZAHWQxdCMwVau1 05bw== X-Gm-Message-State: AOAM531Eqk39efYJigqIwZwhynTEUChyBG6PQ/FIZOm8E+CFUO8TehhU +yEq6+8XzS17v8/1kaBQma9wlbGuAu8A6w== X-Google-Smtp-Source: ABdhPJxQ1GRRCLB3PspJCrFeSQPxYnZmHqebwRvD5VcDg/TqK+3mNXOv/TUD/9gPpO0BKMhv3CLZGQ== X-Received: by 2002:a2e:888a:: with SMTP id k10mr2212700lji.341.1606238112128; Tue, 24 Nov 2020 09:15:12 -0800 (PST) Received: from centos7.localdomain (static.214.61.181.135.clients.your-server.de. [135.181.61.214]) by smtp.gmail.com with ESMTPSA id x24sm393200ljj.112.2020.11.24.09.15.11 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 24 Nov 2020 09:15:11 -0800 (PST) From: Philipp Tomsich To: u-boot@lists.denx.de Cc: Simon Glass , Philipp Tomsich Subject: [PATCH 2/3] patman: Add project-default for 'gcc' Date: Tue, 24 Nov 2020 18:14:53 +0100 Message-Id: <1606238094-28940-2-git-send-email-philipp.tomsich@vrull.eu> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1606238094-28940-1-git-send-email-philipp.tomsich@vrull.eu> References: <1606238094-28940-1-git-send-email-philipp.tomsich@vrull.eu> X-Mailman-Approved-At: Tue, 24 Nov 2020 21:21:28 +0100 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.102.3 at phobos.denx.de X-Virus-Status: Clean Add defaults for FSF/GNU projects, such as gcc, that provide sensible settings for those projects. Signed-off-by: Philipp Tomsich Reviewed-by: Simon Glass Reviewed-by: Simon Glass --- tools/patman/settings.py | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/tools/patman/settings.py b/tools/patman/settings.py index 8c10eab..bb3f868 100644 --- a/tools/patman/settings.py +++ b/tools/patman/settings.py @@ -23,7 +23,12 @@ _default_settings = { "u-boot": {}, "linux": { "process_tags": "False", - } + }, + "gcc": { + "process_tags": "False", + "add_signoff": "False", + "check_patch": "False", + }, } class _ProjectConfigParser(ConfigParser.SafeConfigParser): From patchwork Tue Nov 24 17:14:54 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Philipp Tomsich X-Patchwork-Id: 1405732 X-Patchwork-Delegate: sjg@chromium.org Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=85.214.62.61; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=vrull.eu Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=vrull-eu.20150623.gappssmtp.com header.i=@vrull-eu.20150623.gappssmtp.com header.a=rsa-sha256 header.s=20150623 header.b=OwTn67cx; dkim-atps=neutral Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4Cgb5n2yzdz9s0b for ; Wed, 25 Nov 2020 07:21:42 +1100 (AEDT) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id B0371825EC; Tue, 24 Nov 2020 21:21:29 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=vrull.eu Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=vrull-eu.20150623.gappssmtp.com header.i=@vrull-eu.20150623.gappssmtp.com header.b="OwTn67cx"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 992F7825EC; Tue, 24 Nov 2020 18:15:21 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,SPF_HELO_NONE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from mail-lj1-x243.google.com (mail-lj1-x243.google.com [IPv6:2a00:1450:4864:20::243]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 11DB8825D0 for ; Tue, 24 Nov 2020 18:15:15 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=vrull.eu Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=philipp.tomsich@vrull.eu Received: by mail-lj1-x243.google.com with SMTP id y16so22927143ljk.1 for ; Tue, 24 Nov 2020 09:15:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vrull-eu.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=Gu8CWPxbbx+n74m0qusuVLRX3OkEusEnQUVJKJhlgrk=; b=OwTn67cxc5hLPRKuHP4dkHGRFttR9aMzpYxyw0BHWWSNKkplHI7uYFIcAGrSygLqGm sGLOSbcJ1OBA+riP+kAxRqkDC8o06rM4tymJEhSN+CYdAjccV6m5JMUDqjZTSEMEgkNK Z8KsmGYuAfilGKnzpFNtA3uxb7U9BpOijtMzCNYjHjdYaEfdf9D0JZN8QGrJ3txZOZtT LGLE09odHJgawMrJBWEA8Kf6bExR1RQza5Zu6L0jjpxTswwTGS5718S/iLngoWHxIK4g t/H8B9QB48mmJhyZXgfezaDknL0XRbBmBUV8cIiz4GlBD5vVZSc+HmNCUbJ6pS1sNEgg iR9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=Gu8CWPxbbx+n74m0qusuVLRX3OkEusEnQUVJKJhlgrk=; b=eFQpYZNG3OzE0Ys7bcw0KqJy/kP/jure9l36Mg7dH2ks8xKuZ7wrTuiM6R7FU9FGms uOgaWMo2ut9eccQVV2kKwj1cqvtp53e6uE9HJIWIDCbmyus3VGukkv86fIoFwKzrKEM5 /xYDjsTWu+FHJ4+PLAmbrNpVr2tX3D/JOn0ix/PlnRf0llTqzrOvHpc+fbqeZpaoa+CK NfSEkF3yjusJ0KoPSyoBpAqvtaLb59nypBlsdRB0njVUNNAYk37Kl/K15NzLbAKJCobt pD28zXS+dvzQHTxT0tISvv1EHBabIB//FNtdxDHfZOXQq0OmoQv0fTw6Idr/TFsnk3gN CL4w== X-Gm-Message-State: AOAM532k0QbP0gccEi48qbnNJjEfYxFzD9iF8JIJiblFxrh6RnKHmN79 TIgIU58nSqlB3HEzfPd5Be0glA0InnqV1+Cj X-Google-Smtp-Source: ABdhPJx1VT8HWs7GBaKYfkGhqixwcczcdmVvZ8IH8+07LeCHfHHXLoJetu4Z8XiKKv9cRVO0+ySzgA== X-Received: by 2002:a2e:8745:: with SMTP id q5mr2308088ljj.347.1606238114031; Tue, 24 Nov 2020 09:15:14 -0800 (PST) Received: from centos7.localdomain (static.214.61.181.135.clients.your-server.de. [135.181.61.214]) by smtp.gmail.com with ESMTPSA id x24sm393200ljj.112.2020.11.24.09.15.13 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 24 Nov 2020 09:15:13 -0800 (PST) From: Philipp Tomsich To: u-boot@lists.denx.de Cc: Simon Glass , Philipp Tomsich Subject: [PATCH 3/3] patman: fix project-defaults not propagating into parsers Date: Tue, 24 Nov 2020 18:14:54 +0100 Message-Id: <1606238094-28940-3-git-send-email-philipp.tomsich@vrull.eu> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1606238094-28940-1-git-send-email-philipp.tomsich@vrull.eu> References: <1606238094-28940-1-git-send-email-philipp.tomsich@vrull.eu> X-Mailman-Approved-At: Tue, 24 Nov 2020 21:21:28 +0100 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.102.3 at phobos.denx.de X-Virus-Status: Clean Project defaults (e.g. for linux and gcc) do not propagate into the subparsers. As both the processing of tags (e.g. in the defaults for the linux project) and supressing the signoff (in the defaults for the gcc project) are settings from subparsers, these would still require an explicit commandline option mirroring the (ignored) default. This change ensures that defaults are updated in all parsers. Signed-off-by: Philipp Tomsich --- tools/patman/settings.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tools/patman/settings.py b/tools/patman/settings.py index bb3f868..dc57b2f 100644 --- a/tools/patman/settings.py +++ b/tools/patman/settings.py @@ -266,7 +266,8 @@ def _UpdateDefaults(main_parser, config): print("WARNING: Unknown setting %s" % name) # Set all the defaults (this propagates through all subparsers) - main_parser.set_defaults(**defaults) + for parser in parsers: + parser.set_defaults(**defaults) def _ReadAliasFile(fname): """Read in the U-Boot git alias file if it exists.