From patchwork Wed Nov 11 19:14:48 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Thierry Reding X-Patchwork-Id: 1398476 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=linux-pwm-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=QE26x8iC; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4CWZDh6ZDFz9s0b for ; Thu, 12 Nov 2020 06:15:00 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726101AbgKKTO7 (ORCPT ); Wed, 11 Nov 2020 14:14:59 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50604 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725949AbgKKTO6 (ORCPT ); Wed, 11 Nov 2020 14:14:58 -0500 Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1DF35C0613D1 for ; Wed, 11 Nov 2020 11:14:58 -0800 (PST) Received: by mail-wm1-x341.google.com with SMTP id c9so3246645wml.5 for ; Wed, 11 Nov 2020 11:14:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=jd3wbJ3vVNk5UwiBFv65+aM2MiEbeIfcv2k72Ub2E5k=; b=QE26x8iCYKuwmH247YGo2r/C+qG+geqi1BUFTawDMsYavUsFsKciesxdSHCSnh3a0Z e+1ivhoVjjBgvEX+X3MqxoA74L86njQkSTzQ6PYYYMxy6MOaMazgtXx2u4Wuq+o7iSpS zB4rsDEfUXi3/9mTXm55FwgCl0HTzRJGBFY+XX/cWirFztToYGv+JzNdDPI7+RAZSfpJ m46LpjRb/RX5nIrVWbeN0IYxHLsn44jw8K7NyLrj4P/Ys+sB74Yd3+RTFitfaGBp7yPi +LU5TJ2C1EioTDENHHMuS1ftjnxxKggR0BpRwD0SQCvJgHrnf4iaZgYNIPAY7ERcX9o+ O0bA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=jd3wbJ3vVNk5UwiBFv65+aM2MiEbeIfcv2k72Ub2E5k=; b=IOSq3voyyJU3FjlTA2ygUJXqgnsFUOkuzTiPPYik3KaapPmtWobNgBCm6EsUr1urDw HCiTA+lREzVobSTYNvr89WY4iS3FLJr2CaYoKH4YhknAdw34zWHa/Ozlrd+z2505YpN+ QCweRoGDVfOaxerQqRxyjQbb0Hec+rrPn1zCTpSpVzaQb6oug84JC7oWVeGfr+AlorNe obFFoAIo7QV6A0OHbz6jtXLIme21VnfOxXRaEqcoNtjgyXys7251WuHxyZC8GcQTNrxQ D9TbojzTzpH6Umo606+qtIwP3aGWFgMpN8/jPRBR3A9bM47X/6Y8d+p9LuJ7TEkFHJk+ ZxIA== X-Gm-Message-State: AOAM531GlSMhKwBIKFCzjIFmfl7ofms3y118pNAZfnCSO5Qfk2ieHNXa Lh0abVf3ufB2y9RaRZqSBgMsWaSt7ss= X-Google-Smtp-Source: ABdhPJwEs5lXDzAIgLvkN/ZaRCRQmv7sdajM1AWQr37TRSX32PdHaYptv9uw++fSIjWxBJ29ftIAHg== X-Received: by 2002:a1c:5f45:: with SMTP id t66mr5805265wmb.20.1605122096699; Wed, 11 Nov 2020 11:14:56 -0800 (PST) Received: from localhost ([217.111.27.204]) by smtp.gmail.com with ESMTPSA id f17sm3581995wmf.41.2020.11.11.11.14.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Nov 2020 11:14:55 -0800 (PST) From: Thierry Reding To: Thierry Reding Cc: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , Lee Jones , Ajit Pal Singh , linux-pwm@vger.kernel.org Subject: [PATCH 1/2] pwm: sti: Avoid conditional gotos Date: Wed, 11 Nov 2020 20:14:48 +0100 Message-Id: <20201111191449.409402-1-thierry.reding@gmail.com> X-Mailer: git-send-email 2.29.2 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-pwm@vger.kernel.org Using gotos for conditional code complicates this code significantly. Convert the code to simple conditional blocks to increase readability. Suggested-by: Uwe Kleine-König Signed-off-by: Thierry Reding Acked-by: Uwe Kleine-König Acked-by: Lee Jones --- drivers/pwm/pwm-sti.c | 53 ++++++++++++++++++++----------------------- 1 file changed, 24 insertions(+), 29 deletions(-) diff --git a/drivers/pwm/pwm-sti.c b/drivers/pwm/pwm-sti.c index a1392255955f..c6c82724d327 100644 --- a/drivers/pwm/pwm-sti.c +++ b/drivers/pwm/pwm-sti.c @@ -590,48 +590,43 @@ static int sti_pwm_probe(struct platform_device *pdev) if (ret) return ret; - if (!cdata->pwm_num_devs) - goto skip_pwm; - - pc->pwm_clk = of_clk_get_by_name(dev->of_node, "pwm"); - if (IS_ERR(pc->pwm_clk)) { - dev_err(dev, "failed to get PWM clock\n"); - return PTR_ERR(pc->pwm_clk); - } + if (cdata->pwm_num_devs) { + pc->pwm_clk = of_clk_get_by_name(dev->of_node, "pwm"); + if (IS_ERR(pc->pwm_clk)) { + dev_err(dev, "failed to get PWM clock\n"); + return PTR_ERR(pc->pwm_clk); + } - ret = clk_prepare(pc->pwm_clk); - if (ret) { - dev_err(dev, "failed to prepare clock\n"); - goto put_pwm_clk; + ret = clk_prepare(pc->pwm_clk); + if (ret) { + dev_err(dev, "failed to prepare clock\n"); + goto put_pwm_clk; + } } -skip_pwm: - if (!cdata->cpt_num_devs) - goto skip_cpt; - - pc->cpt_clk = of_clk_get_by_name(dev->of_node, "capture"); - if (IS_ERR(pc->cpt_clk)) { - dev_err(dev, "failed to get PWM capture clock\n"); - ret = PTR_ERR(pc->cpt_clk); - goto unprepare_pwm_clk; - } + if (cdata->cpt_num_devs) { + pc->cpt_clk = of_clk_get_by_name(dev->of_node, "capture"); + if (IS_ERR(pc->cpt_clk)) { + dev_err(dev, "failed to get PWM capture clock\n"); + ret = PTR_ERR(pc->cpt_clk); + goto unprepare_pwm_clk; + } - ret = clk_prepare(pc->cpt_clk); - if (ret) { - dev_err(dev, "failed to prepare clock\n"); - goto put_cpt_clk; + ret = clk_prepare(pc->cpt_clk); + if (ret) { + dev_err(dev, "failed to prepare clock\n"); + goto put_cpt_clk; + } } -skip_cpt: pc->chip.dev = dev; pc->chip.ops = &sti_pwm_ops; pc->chip.base = -1; pc->chip.npwm = pc->cdata->pwm_num_devs; ret = pwmchip_add(&pc->chip); - if (ret < 0) { + if (ret < 0) goto unprepare_cpt_clk; - } for (i = 0; i < cdata->cpt_num_devs; i++) { struct sti_cpt_ddata *ddata; From patchwork Wed Nov 11 19:14:49 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Thierry Reding X-Patchwork-Id: 1398477 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=linux-pwm-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=PFBUUn4+; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4CWZDk6fmSz9s0b for ; Thu, 12 Nov 2020 06:15:02 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726104AbgKKTPC (ORCPT ); Wed, 11 Nov 2020 14:15:02 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50610 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725949AbgKKTPB (ORCPT ); Wed, 11 Nov 2020 14:15:01 -0500 Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4C624C0613D1 for ; Wed, 11 Nov 2020 11:15:00 -0800 (PST) Received: by mail-wr1-x441.google.com with SMTP id l1so3596492wrb.9 for ; Wed, 11 Nov 2020 11:15:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=hkr0WLco4uBLugzGlKBSOKTZjoWTigiQkc3F7HbhM9Y=; b=PFBUUn4+teEAvKkqraC6L1xDpq8KlxQ9HpBZeG3LNPKtQ5+47HPLY9ID5BEw8+DLQO TogpZR2Vp1Mc1wHOVe4+aJPNg+4zqU3aubCdDM7tFsu/MczOnxB0i6a6OevKZmjt5Cmh qnDTqIh3o06AG9IkqowtwloixfFgSsEZngA4vHM2f2n9gchVghSqqjF1BOSipiymxgI9 FfwUrAXl847tG1FpACNQCv2eYs+91lXn9FuRXZmydcO8FwG2I2mWyuu5p9wIuD46zeeX M3zQUZHW6zmygz6AbCdb8nnwZJrZy/zptC/fLSLeYAYan56Yh9fzWd2USMeqNzpeieP7 OMRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=hkr0WLco4uBLugzGlKBSOKTZjoWTigiQkc3F7HbhM9Y=; b=hveDqDiNqlEK2KoDvCQ13v2iW07RY39UNtTuXoxyxElpFrVeUoL1eAYpnedvu+m1pT nUu3AP+wJO36q7UGBaVWYielLPhs62yQpkZJFzzpzpVabeRUFbJ0bjANKCWnYq+CYro9 uWwn23DrgerzG89c7R9MD+5Z3XMhdU0+Nj/QZ7B/Lw8QvQk6hzZIcqGni8dGOR8wLAe7 tDQIwANOcGVfFcDxhtxiUMaHP30QbtJW6OHreWfLkMbXIcqCUS3af48p4eF1RF4xtV1B x5kU4Thlli8ElnkbjY9+AxGjLsaencvdmNzD1Oh8xvDCXkgeK0QmPzR6qwfC4kKlZ8lP FDFw== X-Gm-Message-State: AOAM531D2l+PzYXevPS0qGPcPY/0VSi5ndSaSwmspRuZz+BnlafvAqy5 f7j82irMD3yKfw6/RqeP+uQ= X-Google-Smtp-Source: ABdhPJyofdT5oBECt+yKVRhyuYlURaKQEqJLCZhyOYeBg4vwHqGswbrZ2oMNW4e3JiEFhVcCw91PPg== X-Received: by 2002:a5d:51c1:: with SMTP id n1mr25892680wrv.395.1605122099013; Wed, 11 Nov 2020 11:14:59 -0800 (PST) Received: from localhost ([217.111.27.204]) by smtp.gmail.com with ESMTPSA id s12sm3657459wmc.6.2020.11.11.11.14.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Nov 2020 11:14:58 -0800 (PST) From: Thierry Reding To: Thierry Reding Cc: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , Lee Jones , Ajit Pal Singh , linux-pwm@vger.kernel.org Subject: [PATCH 2/2] pwm: sti: Remove unnecessary blank line Date: Wed, 11 Nov 2020 20:14:49 +0100 Message-Id: <20201111191449.409402-2-thierry.reding@gmail.com> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20201111191449.409402-1-thierry.reding@gmail.com> References: <20201111191449.409402-1-thierry.reding@gmail.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-pwm@vger.kernel.org A single blank line is enough to separate logical code blocks. Signed-off-by: Thierry Reding Acked-by: Lee Jones Acked-by: Uwe Kleine-König --- drivers/pwm/pwm-sti.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/pwm/pwm-sti.c b/drivers/pwm/pwm-sti.c index c6c82724d327..ec667b31d7ec 100644 --- a/drivers/pwm/pwm-sti.c +++ b/drivers/pwm/pwm-sti.c @@ -505,7 +505,6 @@ static int sti_pwm_probe_dt(struct sti_pwm_chip *pc) if (IS_ERR(pc->prescale_high)) return PTR_ERR(pc->prescale_high); - pc->pwm_out_en = devm_regmap_field_alloc(dev, pc->regmap, reg_fields[PWM_OUT_EN]); if (IS_ERR(pc->pwm_out_en))