From patchwork Thu Oct 29 17:27:34 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Steven Lawrance X-Patchwork-Id: 1390309 X-Patchwork-Delegate: trini@ti.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=softathome.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=softathome1.onmicrosoft.com header.i=@softathome1.onmicrosoft.com header.a=rsa-sha256 header.s=selector1-softathome1-onmicrosoft-com header.b=ln0Oe6bh; dkim-atps=neutral Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4CMXp35scyz9sRK for ; Fri, 30 Oct 2020 04:42:35 +1100 (AEDT) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id AA4308235F; Thu, 29 Oct 2020 18:42:30 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=softathome.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=softathome1.onmicrosoft.com header.i=@softathome1.onmicrosoft.com header.b="ln0Oe6bh"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id A487982369; Thu, 29 Oct 2020 18:27:50 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-0.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,FORGED_SPF_HELO,MSGID_FROM_MTA_HEADER,SPF_HELO_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.2 Received: from FRA01-MR2-obe.outbound.protection.outlook.com (mail-mr2fra01hn0329.outbound.protection.outlook.com [IPv6:2a01:111:f400:7e19::329]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 1B2628002F for ; Thu, 29 Oct 2020 18:27:47 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=softathome.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=steven.lawrance@softathome.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bEuf5pxATNjUZpukK6ndnmJivVgMc+ecVyjL55VxYcOTYXqUFysmz5xmJbbelojx+I0kP/ZnSGUUy7Li8wPBAkz+ixS85eqjUuQGP2+ug66hCaUA4DWU2+afNtD4bARYgjfKvNSPYSZUG4LnGOurHlb3KbLf2eq7aisId3umua5GDgtpli5DWJc0JE2fX/X18mOFDSyLqWpLaHNX2SqW+iX67+8m5OqSU9oM+Zdrl1VlPzfuYYQMD5Ily3Z9qGzhGFwHbI8ejFj2GvttA+WAWiefyRzna/aXasXxUGAxQC0UeB8qubfsnU3v+tpQG+f9xfMCqnPUtcUIE7tgmdP7+w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=boqisKuH+HN21rKzQI4BBhOzNTS6nAQJbAdW4nRr/LM=; b=XIrKgWSPNYTziYMDRaQ5qfEu7wLPFCd/36vJnADogQrwsYmNTI+I3m+uY/fjsKTVJRQjFw/ktSW2zYqNS9QxQkM6v6CwEl1xZc/HNk+2M4KK8u86ncw1/uBkZ8vkbtLkzK8AqBMbnRHBJuf32PiYKXHj+YUJb81CBnKdIK96hppX/aN0KpxDZY07jqQNgBUDMYDFz61n70Yvnc6uSbM2rCCcO2KPDfPz2zAcWWEBtOgORK1zPE3BS4KGjnLsTvEjtpBst5MUOH2tyd4nYFGuL1Kqi3lDRbnQjPncQcu5sb/OiYi+aLKN8XF5zyf9PnbcmK45z1E4ThTgmUZlcss1bA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=softathome.com; dmarc=pass action=none header.from=softathome.com; dkim=pass header.d=softathome.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=softathome1.onmicrosoft.com; s=selector1-softathome1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=boqisKuH+HN21rKzQI4BBhOzNTS6nAQJbAdW4nRr/LM=; b=ln0Oe6bhQc17sEwfjiHt61vrW8T7aqS7YQMnyzBMYYk+NxdBB5lsuh8B+ZYXYLaMlJamC2GhreGJiRTdpGwdWVsUF2voCXPVYTu78J+DdFZdfXVaTpVjA+niIv+v1tv0sJMZRXymZoOEbQwzULxvLre3W7rQO8dKBeX0E3y5It4PUEsYWJgj55jYjSxdH8WBBbATDO0oFpX3ilhZ+SEnWC90AsilTbTuijDnFedbBaEf1WJafgCzUc8tL6X80OwnLxp1GPvPxF1sAo/hlH+tT58yfoWaQh1YjBdamXBIIkEwMqC9v7/hbOybFL+xMA/uXdHSrQEbMlEEAJdWSSc/9w== Authentication-Results: lists.denx.de; dkim=none (message not signed) header.d=none;lists.denx.de; dmarc=none action=none header.from=softathome.com; Received: from MRXP264MB0807.FRAP264.PROD.OUTLOOK.COM (2603:10a6:500:24::18) by MRXP264MB0040.FRAP264.PROD.OUTLOOK.COM (2603:10a6:500:18::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3477.20; Thu, 29 Oct 2020 17:27:46 +0000 Received: from MRXP264MB0807.FRAP264.PROD.OUTLOOK.COM ([fe80::652c:b2fc:3eb9:f1]) by MRXP264MB0807.FRAP264.PROD.OUTLOOK.COM ([fe80::652c:b2fc:3eb9:f1%7]) with mapi id 15.20.3499.018; Thu, 29 Oct 2020 17:27:46 +0000 From: Steven Lawrance To: u-boot@lists.denx.de, Simon Glass Subject: [PATCH] drivers: led: bcm6858: set the correct led polarity register Date: Thu, 29 Oct 2020 18:27:34 +0100 Message-Id: <20201029172734.17261-1-steven.lawrance@softathome.com> X-Mailer: git-send-email 2.20.1 X-Originating-IP: [2a02:578:85c8:700:ad4:cff:fed8:3f6f] X-ClientProxiedBy: AM3PR07CA0095.eurprd07.prod.outlook.com (2603:10a6:207:6::29) To MRXP264MB0807.FRAP264.PROD.OUTLOOK.COM (2603:10a6:500:24::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from localhost (2a02:578:85c8:700:ad4:cff:fed8:3f6f) by AM3PR07CA0095.eurprd07.prod.outlook.com (2603:10a6:207:6::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3499.7 via Frontend Transport; Thu, 29 Oct 2020 17:27:45 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: b8fd27e7-8ce0-4a6b-fa3f-08d87c2ff355 X-MS-TrafficTypeDiagnostic: MRXP264MB0040: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:6108; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: v5Eu0lJ9AhOK/s7zpGg8vBipk4jLB6LcXk2/j4BiYPUprrnfL/wI8OOU7BMP+mdPM8siODC4vmdrHdt1JmUpUVC+hfbXxc/ZMAJNFz2T/tigg1//jNvSIb2DtNDipd5naiq81l+lsTWimFb3ahQF2FzDIyVyFHGm/ac0x6aFpB+I6OwYS9Na8S8ayJRoAE+qM8NDdur6c2qQmrJg/RLVF0Vnaieb+68PUW6THpox9vGGooKz1hvDp7iTUQN6Nez2z4Or5IsBXrRBsMogUpd+gNn9R/P+USSXx9DBOXMOf2ek0WhoSswdo4/TPBifU5Hu4kXpommwLBEGIusup1KqzGLMRzeg8Ih7Z3ZMbOSViu6nkBVZgs4iDGo9CTa+aTsGXRKZhdPWf10GsU7Pskuv90drxghmEeAHo5Zgc4GFQdbrkTG9ivKlBHsJUX1/WJ5A9nVi4U3KfzG6vFIo9svSUpLRjmbylGIyCDFPwVcl3qgf6ME0TrnKS/ED3ANX3Rr96NrDt1Fo/36NfdH7Ss7uIQ59IJ6fzokzTruohTYKhBpUCkA547AYVDCXLk/hDNPVmF9G9cbXigu3P1pj+Q/5Z1ihsFzR6wG/RoezFFeGdqwuZzNWgQuJWkfGZ42AU+9OscQocnuenQxG9OjNCh+vUt4IbMJUuAXJjhT9/L6xWBXKjNIR4NuTmd+WVI08wRXk X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:5; SRV:; IPV:NLI; SFV:SPM; H:MRXP264MB0807.FRAP264.PROD.OUTLOOK.COM; PTR:; CAT:OSPM; SFS:(4636009)(346002)(376002)(366004)(136003)(396003)(39840400004)(8936002)(2616005)(6666004)(52116002)(1076003)(316002)(86362001)(8676002)(44832011)(2906002)(83380400001)(478600001)(6486002)(6496006)(186003)(16526019)(36756003)(66946007)(66556008)(6916009)(66476007)(5660300002)(23200700001); DIR:OUT; SFP:1501; X-MS-Exchange-AntiSpam-MessageData: WBJmkhsXiIwJPjWJpOgkiBojdQ5QuqKV0Kxf7XZwhrlCxJ3Q4rbPKMlXbJdefpKqx1al8EIfVyXr9n0cvKyqQnIdVx873a0E6XQQUCyVzVc9nOCEOwiGoXC89uB7/cy88lFoZLblEo8wpVCXPUDeEP8TRVxFzYFo4Bg7ZT1cxK4d153GDKlsq5hf0XsrcCf+xM0W5oVSBiNlEY88RFqjFvPIG2sXHY0+TK9sSDkWwsaXETYdEoOvT7lNk7xfqIa/I/D37fMMcIF8mgc4hg3fTt+xETP1SZS8LRiz9mLqq9o7GHFJ6IBzt4TAYeP+YhPemavZ7tlswOweUFELhEzh9ozoU/N3nBMQrKnaRZfMjVyXleURmPKOx3CgU9BqI+s9EWinAJ8M2R2a30pmjv0Ijkxm3hW40FnLjHQFYX65ztznU8GonicLJM7AAA5R6EW++YhuovbMBKXH/UdzlR/VanrwYonPgI7eweU9NdBMjV3nTKVpeEgwb3IdbnFeIdtJEYJ1HIK9ZUKNfdeKBD9Bu6SVobIpxqBCNXGp/L68b4jRwXLQuK0lFB48cdFML3tRuffyk02W7mIb0RG8Bl4RDDd3QSMqtSlvGU5H17OYnEA4BYSjzhMTsq8RCGt9xl9loqm8/tcc8DMkdv9+hkmZGgmPMmvz92K8uaRIz4tLozjAybr0/3n7Mnkc5ojV9CDO X-OriginatorOrg: softathome.com X-MS-Exchange-CrossTenant-Network-Message-Id: b8fd27e7-8ce0-4a6b-fa3f-08d87c2ff355 X-MS-Exchange-CrossTenant-AuthSource: MRXP264MB0807.FRAP264.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Oct 2020 17:27:46.2419 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: aa10e044-e405-4c10-8353-36b4d0cce511 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: N7f83CKq6320Pw7XMw/ndx+RktYGeYxOVyoTU7a7lAwjf4nFTvZmc35Fd39Ml85I0MnuBHE3Xmt8ZWyy+4tJNAhEAegsq1WgXx3tvd8QgHU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MRXP264MB0040 X-Mailman-Approved-At: Thu, 29 Oct 2020 18:42:29 +0100 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.102.3 at phobos.denx.de X-Virus-Status: Clean This change sets the output (hardware) polarity register instead of the input (software) polarity register for the bcm6858 LED controller. The logic was inverted (a LED configued active high behaved as active low). Signed-off-by: Steven Lawrance Reviewed-by: Philippe Reynes --- drivers/led/led_bcm6858.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/led/led_bcm6858.c b/drivers/led/led_bcm6858.c index b415d8b2b4..511185ffad 100644 --- a/drivers/led/led_bcm6858.c +++ b/drivers/led/led_bcm6858.c @@ -40,8 +40,8 @@ #define LED_FLASH_RATE_CONTROL_REG0 0x10 /* Soft LED input register */ #define LED_SW_LED_IP_REG 0xb8 -/* Soft LED input polarity register */ -#define LED_SW_LED_IP_PPOL_REG 0xbc +/* Parallel LED Output Polarity Register */ +#define LED_PLED_OP_PPOL_REG 0xc0 struct bcm6858_led_priv { void __iomem *regs; @@ -198,9 +198,9 @@ static int bcm6858_led_probe(struct udevice *dev) /* configure the polarity */ if (dev_read_bool(dev, "active-low")) - clrbits_32(regs + LED_SW_LED_IP_PPOL_REG, 1 << pin); + clrbits_32(regs + LED_PLED_OP_PPOL_REG, 1 << pin); else - setbits_32(regs + LED_SW_LED_IP_PPOL_REG, 1 << pin); + setbits_32(regs + LED_PLED_OP_PPOL_REG, 1 << pin); } return 0;