From patchwork Wed Oct 28 00:22:34 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Andrew Lunn X-Patchwork-Id: 1389645 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=lunn.ch Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4CM5Wd24sQz9sSf for ; Thu, 29 Oct 2020 11:13:33 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390771AbgJ2ANb (ORCPT ); Wed, 28 Oct 2020 20:13:31 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:50752 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390799AbgJ2ANa (ORCPT ); Wed, 28 Oct 2020 20:13:30 -0400 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1kXZEs-003tgs-Pi; Wed, 28 Oct 2020 01:22:54 +0100 From: Andrew Lunn To: Jakub Kicinski Cc: netdev , Thomas Petazzoni , Ralf Baechle , Andrew Lunn Subject: [PATCH net-next 1/2] net: marvell: mvneta: Fix trigraph warning with W=1 Date: Wed, 28 Oct 2020 01:22:34 +0100 Message-Id: <20201028002235.928999-2-andrew@lunn.ch> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20201028002235.928999-1-andrew@lunn.ch> References: <20201028002235.928999-1-andrew@lunn.ch> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org drivers/net/ethernet/marvell/mvneta.c: In function ‘mvneta_tx_tso’: drivers/net/ethernet/marvell/mvneta.c:2651:39: warning: trigraph ??! ignored, use -trigraphs to enable [-Wtrigraphs] 2651 | pr_info("*** Is this even possible???!?!?\n"); Simply the questioning exclamation to a plain question to avoid the warning. Signed-off-by: Andrew Lunn --- drivers/net/ethernet/marvell/mvneta.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/marvell/mvneta.c b/drivers/net/ethernet/marvell/mvneta.c index 54b0bf574c05..55f4c49c1278 100644 --- a/drivers/net/ethernet/marvell/mvneta.c +++ b/drivers/net/ethernet/marvell/mvneta.c @@ -2648,7 +2648,7 @@ static int mvneta_tx_tso(struct sk_buff *skb, struct net_device *dev, return 0; if (skb_headlen(skb) < (skb_transport_offset(skb) + tcp_hdrlen(skb))) { - pr_info("*** Is this even possible???!?!?\n"); + pr_info("*** Is this even possible????\n"); return 0; } From patchwork Wed Oct 28 00:22:35 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Andrew Lunn X-Patchwork-Id: 1389649 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=lunn.ch Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4CM5Wy29mfz9sSP for ; Thu, 29 Oct 2020 11:13:50 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390842AbgJ2ANt (ORCPT ); Wed, 28 Oct 2020 20:13:49 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:50784 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390834AbgJ2ANr (ORCPT ); Wed, 28 Oct 2020 20:13:47 -0400 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1kXZEu-003th5-1u; Wed, 28 Oct 2020 01:22:56 +0100 From: Andrew Lunn To: Jakub Kicinski Cc: netdev , Thomas Petazzoni , Ralf Baechle , Andrew Lunn Subject: [PATCH net-next 2/2] net: rose: Escape trigraph to fix warning with W=1 Date: Wed, 28 Oct 2020 01:22:35 +0100 Message-Id: <20201028002235.928999-3-andrew@lunn.ch> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20201028002235.928999-1-andrew@lunn.ch> References: <20201028002235.928999-1-andrew@lunn.ch> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org net/rose/af_rose.c: In function ‘rose_info_show’: net/rose/af_rose.c:1413:20: warning: trigraph ??- ignored, use -trigraphs to enable [-Wtrigraphs] 1413 | callsign = "??????-?"; ??- is a trigraph, and should be replaced by a ˜ by the compiler. However, trigraphs are being ignored in the build. Fix the warning by escaping the ?? prefix of a trigraph. Signed-off-by: Andrew Lunn --- net/rose/af_rose.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/rose/af_rose.c b/net/rose/af_rose.c index cf7d974e0f61..2c297834d268 100644 --- a/net/rose/af_rose.c +++ b/net/rose/af_rose.c @@ -1410,7 +1410,7 @@ static int rose_info_show(struct seq_file *seq, void *v) ax2asc(buf, &rose->dest_call)); if (ax25cmp(&rose->source_call, &null_ax25_address) == 0) - callsign = "??????-?"; + callsign = "????\?\?-?"; else callsign = ax2asc(buf, &rose->source_call);