From patchwork Sun Oct 11 11:24:35 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Ren=C3=A9_Rebe?= X-Patchwork-Id: 1380640 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.helo=coreboot.org (client-ip=78.46.105.101; helo=coreboot.org; envelope-from=flashrom-bounces@flashrom.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=exactcode.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=exactco.de header.i=@exactco.de header.a=rsa-sha256 header.s=x header.b=NVcX+LFl; dkim-atps=neutral Received: from coreboot.org (coreboot.org [78.46.105.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4C8pbT4X3Zz9sSs for ; Mon, 12 Oct 2020 17:26:13 +1100 (AEDT) Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) by coreboot.org (Postfix) with ESMTPA id 6875310C0069; Mon, 12 Oct 2020 06:26:08 +0000 (UTC) Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) by coreboot.org (Postfix) with ESMTP id E94D410C00E0 for ; Sun, 11 Oct 2020 11:24:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=exactco.de; s=x; h=Content-Transfer-Encoding:Content-Type:Mime-Version:From:Subject:To:Message-Id:Date; bh=/uT1ez2N601NnyXYy7aSpEU6PgOjiYNCiVnd0Wtzyg0=; b=NVcX+LFlNO6cXNBFInFKENFps8s9MlBcHSS4JtLw79JZ3k6En0lHAUwAz2/P+4vD7bfPSgJauenxsd0+u49gjLF8ULwZY2arCVG5LH5fv0qveZS5Wad9SmZAFApuFe7sS66EO3Z1tXnYh2/Qe4Pdss+FT5wN3WrpBn0cTfpHNpQ=; Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) by mx.exactcode.de with esmtp (Exim 4.82) (envelope-from ) id 1kRZTV-0005m0-MG for flashrom@flashrom.org; Sun, 11 Oct 2020 11:25:13 +0000 Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) by exactco.de with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.86_2) (envelope-from ) id 1kRZQq-0007Xb-4o for flashrom@flashrom.org; Sun, 11 Oct 2020 11:22:31 +0000 Date: Sun, 11 Oct 2020 13:24:35 +0200 (CEST) Message-Id: <20201011.132435.1051523223630255892.rene@exactcode.com> To: flashrom@flashrom.org From: Rene Rebe Mime-Version: 1.0 X-Spam-Score: -3.1 (---) X-Spam-Level: * X-MailFrom: rene@exactcode.com X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-flashrom.flashrom.org-0; header-match-flashrom.flashrom.org-1; header-match-flashrom.flashrom.org-2; header-match-flashrom.flashrom.org-3; header-match-flashrom.flashrom.org-4; header-match-flashrom.flashrom.org-5; header-match-flashrom.flashrom.org-6; header-match-flashrom.flashrom.org-7; header-match-flashrom.flashrom.org-8; header-match-flashrom.flashrom.org-9; header-match-flashrom.flashrom.org-10; header-match-flashrom.flashrom.org-11; header-match-flashrom.flashrom.org-12; header-match-flashrom.flashrom.org-13; header-match-flashrom.flashrom.org-14; header-match-flashrom.flashrom.org-15; header-match-flashrom.flashrom.org-16; header-match-flashrom.flashrom.org-17; header-match-flashrom.flashrom.org-18; header-match-flashrom.flashrom.org-19; header-match-flashrom.flashrom.org-20; header-match-flashrom.flashrom.org-21; header-match-flashrom.flashrom.org- 22; header-match-flashrom.flashrom.org-23; header-match-flashrom.flashrom.org-24; header-match-flashrom.flashrom.org-25; header-match-flashrom.flashrom.org-26; header-match-flashrom.flashrom.org-27; header-match-flashrom.flashrom.org-28; header-match-flashrom.flashrom.org-29; header-match-flashrom.flashrom.org-30; header-match-flashrom.flashrom.org-31; header-match-flashrom.flashrom.org-32; header-match-flashrom.flashrom.org-33; header-match-flashrom.flashrom.org-34; header-match-flashrom.flashrom.org-35; header-match-flashrom.flashrom.org-36; header-match-flashrom.flashrom.org-37; header-match-flashrom.flashrom.org-38; header-match-flashrom.flashrom.org-39; header-match-flashrom.flashrom.org-40; header-match-flashrom.flashrom.org-41; header-match-flashrom.flashrom.org-42; header-match-flashrom.flashrom.org-43; header-match-flashrom.flashrom.org-44; header-match-flashrom.flashrom.org-45; header-match-flashrom.flashrom.org-46; header-match-flashrom.flashrom.org-47; header-match-flash rom.flashrom.org-48; header-match-flashrom.flashrom.org-49; header-match-flashrom.flashrom.org-50; header-match-flashrom.flashrom.org-51; header-match-flashrom.flashrom.org-52; header-match-flashrom.flashrom.org-53; header-match-flashrom.flashrom.org-54; header-match-flashrom.flashrom.org-55; header-match-flashrom.flashrom.org-56; header-match-flashrom.flashrom.org-57; header-match-flashrom.flashrom.org-58; header-match-flashrom.flashrom.org-59; header-match-flashrom.flashrom.org-60; header-match-flashrom.flashrom.org-61; header-match-flashrom.flashrom.org-62; header-match-flashrom.flashrom.org-63; header-match-flashrom.flashrom.org-64; header-match-flashrom.flashrom.org-65; header-match-flashrom.flashrom.org-66; header-match-flashrom.flashrom.org-67; header-match-flashrom.flashrom.org-68; header-match-flashrom.flashrom.org-69; header-match-flashrom.flashrom.org-70; header-match-flashrom.flashrom.org-71; header-match-flashrom.flashrom.org-72; header-match-flashrom.flashrom.org-73 Message-ID-Hash: FFICFR5BOBWGCI4AQLPW5DFQJTMLXDL4 X-Message-ID-Hash: FFICFR5BOBWGCI4AQLPW5DFQJTMLXDL4 X-Mailman-Approved-At: Mon, 12 Oct 2020 06:25:56 +0000 X-Mailman-Version: 3.3.2b1 Precedence: list Subject: [flashrom] [PATCH] sb600 List-Id: flashrom discussion and development mailing list Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: Authentication-Results: coreboot.org; auth=pass smtp.auth=mailman@coreboot.org smtp.mailfrom=flashrom-bounces@flashrom.org X-Spamd-Bar: - Added AMD Ryzen 3950x X570 and AMD Ryzen 4000 Mobile PCI revisions to AMD FP4 / AM4 sb600spi.c. Trying to use flashrom to downgrade my Asus WS X570 ACE bios to a previous, more stable and performant version I just got this output: flashrom -p internal flashrom v1.2 on Linux 5.8.13-dist (x86_64) flashrom is free software, get the source code at https://flashrom.org Using clock_gettime for delay loops (clk_id: 1, resolution: 1ns). Found chipset "AMD FP4". Enabling flash write... FCH device found but SMBus revision 0x61 does not match known values. So I patched mine and a friends MSI Modern 14 Ryzen 4700 laptop revisions in and we could both read the BIOS and I also tested flashing the Asus WS X570 ACE succesfully. Signed-of-by: René Rebe diff --git a/sb600spi.c b/sb600spi.c index 5892d57..8a3c87d 100644 --- a/sb600spi.c +++ b/sb600spi.c @@ -143,7 +143,7 @@ static int determine_generation(struct pci_dev *dev) if (rev == 0x4a) { amd_gen = CHIPSET_YANGTZE; msg_pdbg("Yangtze detected.\n"); - } else if (rev == 0x4b) { + } else if (rev == 0x4b || rev == 0x51 || rev == 0x61) { amd_gen = CHIPSET_PROMONTORY; msg_pdbg("Promontory detected.\n"); } else {