From patchwork Fri Sep 4 14:21:32 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lorenzo Pieralisi X-Patchwork-Id: 1357533 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=linux-pci-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=arm.com Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4Bjg2M609mz9sVR for ; Sat, 5 Sep 2020 00:25:47 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730476AbgIDOZp (ORCPT ); Fri, 4 Sep 2020 10:25:45 -0400 Received: from foss.arm.com ([217.140.110.172]:51340 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730536AbgIDOVt (ORCPT ); Fri, 4 Sep 2020 10:21:49 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id DF5EB1045; Fri, 4 Sep 2020 07:21:43 -0700 (PDT) Received: from red-moon.arm.com (unknown [10.57.6.237]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 0C2E33F71F; Fri, 4 Sep 2020 07:21:42 -0700 (PDT) From: Lorenzo Pieralisi To: linux-pci@vger.kernel.org Cc: Lorenzo Pieralisi , Rob Herring , Thomas Petazzoni , linux-arm-kernel@lists.infradead.org Subject: [PATCH] PCI: mvebu: Remove useless msi_controller allocation/initialization Date: Fri, 4 Sep 2020 15:21:32 +0100 Message-Id: <20200904142132.6054-1-lorenzo.pieralisi@arm.com> X-Mailer: git-send-email 2.26.1 MIME-Version: 1.0 Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org The mvebu host controller driver allocates an msi_controller structure without assigning its methods. This means that the PCI IRQ MSI layer ignores it and that after all it should not really be needed. Remove it. Signed-off-by: Lorenzo Pieralisi Cc: Rob Herring Cc: Thomas Petazzoni Reviewed-by: Rob Herring --- drivers/pci/controller/pci-mvebu.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/pci/controller/pci-mvebu.c b/drivers/pci/controller/pci-mvebu.c index c39978b750ec..eee82838f4ba 100644 --- a/drivers/pci/controller/pci-mvebu.c +++ b/drivers/pci/controller/pci-mvebu.c @@ -12,7 +12,6 @@ #include #include #include -#include #include #include #include @@ -70,7 +69,6 @@ struct mvebu_pcie_port; struct mvebu_pcie { struct platform_device *pdev; struct mvebu_pcie_port *ports; - struct msi_controller *msi; struct resource io; struct resource realio; struct resource mem; @@ -1127,7 +1125,6 @@ static int mvebu_pcie_probe(struct platform_device *pdev) bridge->sysdata = pcie; bridge->ops = &mvebu_pcie_ops; bridge->align_resource = mvebu_pcie_align_resource; - bridge->msi = pcie->msi; return mvebu_pci_host_probe(bridge); }