From patchwork Sat Aug 8 16:59:59 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heinrich Schuchardt X-Patchwork-Id: 1342539 X-Patchwork-Delegate: xypron.glpk@gmx.de Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=gmx.de Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; secure) header.d=gmx.net header.i=@gmx.net header.a=rsa-sha256 header.s=badeba3b8450 header.b=TM+Qa2I5; dkim-atps=neutral Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4BP7lD4Yvjz9sPC for ; Sun, 9 Aug 2020 03:00:22 +1000 (AEST) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 20FE682189; Sat, 8 Aug 2020 19:00:12 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=gmx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; secure) header.d=gmx.net header.i=@gmx.net header.b="TM+Qa2I5"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 7B9B182192; Sat, 8 Aug 2020 19:00:10 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,FREEMAIL_FROM,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from mout.gmx.net (mout.gmx.net [212.227.17.20]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id C148C80E47 for ; Sat, 8 Aug 2020 19:00:06 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=gmx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=xypron.glpk@gmx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1596906005; bh=uE1rGCVcAMadbLfPcU2/ZJpE8/q1u/aJn4ik/8TbBHA=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date; b=TM+Qa2I5nG8pGlNv3hhy+eVApMuzjqM6z6RySD6Zam4ML/Y3nyLXX0yHsD9XXVQYB Q3QRo2386vZZJ2wgPBoIDaEcIgn5HkfZjDV/rn2TRjVzb0TdqUO7Twkn8nzHR1bxIf QoZR1rknGrh4xzxcGhWSFwBjeIkmT/TMDFOPrVHk= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from LT02.fritz.box ([178.202.41.107]) by mail.gmx.com (mrgmx105 [212.227.17.174]) with ESMTPSA (Nemesis) id 1MBUm7-1js6o60fhX-00D3TZ; Sat, 08 Aug 2020 19:00:05 +0200 From: Heinrich Schuchardt To: Tom Rini Cc: AKASHI Takahiro , Simon Glass , Anatolij Gustschin , u-boot@lists.denx.de, Heinrich Schuchardt Subject: [PATCH 1/1] lib/crypto: simplify public_key_verify_signature Date: Sat, 8 Aug 2020 18:59:59 +0200 Message-Id: <20200808165959.14919-1-xypron.glpk@gmx.de> X-Mailer: git-send-email 2.28.0 MIME-Version: 1.0 X-Provags-ID: V03:K1:qiJxKX2LgyHJmfUBLONw11SFegwoAcnJU7K4iR9ZDe8qBB3mXap vqPchjhzL2xcbI57fSJVZw3uDLEWikE/A5hOnWjm0DKpdyEY5iA1qQLgPmYkdMS3jyXeMBY Xzwaxo2mXoYxJT2klyActDIlPFlICr2LpcRPqTKeNCzGdw67LTETkhd9bwoy+YS53Eow27g sDF5YDPV6R3vhqaXE88/g== X-UI-Out-Filterresults: notjunk:1;V03:K0:GbJWm5BeFic=:DPwumMA/FkXS7AJ1w4CxFE W4IWjcGefp61sBbfk7/7PU+tW4mifVEbjJa1mX7hC7E+q2T8Uh+RN+apMhMoNUbeBx9qYp2x/ 5Sei/6/xXMZka+M+a0CwFwnZ3gj7hqPoAa+5CgrRpSWAdHSdr8f6s6MNsec7O7/wcFfFWWJsV hSpj404LTQbKZcaFRueT2UUMo5r7bJJo3VM5LKWiFFZUmmweuBvV11qW+hp/Afi+LG72yQrC4 Z0RVBWlP8iyKMHpN5b4oouJPeN+PQUW+Bmb3kJU+VyoUN+mYuwBkhNdVQLs4L10paYkgpH6xC 2yTZHT8n1qWm+ZYK6ImaXzFxpflgzuvvSgMtGkRDE6b+7gvHE4jEfcSLoTPeNHKtg1ecHKUI3 ftcIR4gofircx64XTy+aPh+DcyXE8HZ7M9mfyD+YlnDe/LGJHgMuHQj4HA4dn0jHVO2eWACuD g1iWArP+p/cOtKBZUN7/WYMfpUFx3qyAqg/A+ymF682hzHtDuzuObca9jF1tArS1xfy7zX8NB xJURqvgQfuYnsxl26ReFvi3dYi4rVFW5ns0gqV5WYh7mJ0dqSG5lzZ85chqYtayjiStqGtGMk dZU65c8ltFkUjgyIDAMBD9jxb89pCPoPXqz22z+zP4zcQkzTF+6Ut4aKTvUgDDZV2EZEwk+rf c/SfFlUA4my/IQSIZRzwLRlLBFtdciIWZyM2RzGbVts+ehVyqM2qYRrC8W9bonDgR2DHEBkDN CBPvgLFzom5SETQMk4HAeyjiKbsFoyDB+WoN8WJopYq3rhPA94QUiJ92OBS4Pxq0YtYXmE4Yy gX/buL+S1PYXEy+gKoV+sxpoJbjf94k8GTjGxngrad5jbEIEY2DMrLZXTEWc0Y6hn/4a72yN/ Gu9axhk58HYpwsyyQtz7jeEpIp9CsgQDdsVaeWAIpWAsOc3I9qfkrIsEou+VlMV9MTzPs8Ey7 LNknJuHx4DhHx0I6QzMOH/7Q77jkDerNc8ob8q2Yq0MnvYKmAPWcY0h9xmD5VwIwnMuLCz97k gaqM42T8urMFFlFso6ypSJZo2v78il5oiYhrsrfuiqi/pkx3YZloukU72A9iVOit/IOs7JlXh E0FoLpp37skRDj+KiU6ylLK8rwLWf+rYshw+tsAIjHVwD74K2tb7gsknh9efBHpNN9fVKhVXz OdZT7taqz08Q124V5b/1T6OHKbEE5LUeA99yaTIulCF4rGNssC1V3Fzff31U1j1/ZyhWhFpTi Mjw5yu8lEvvUEI0MitxXwUloCVV/09rynaHLaTw== X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.102.3 at phobos.denx.de X-Virus-Status: Clean The variable region is filled but never used. Remove it. Signed-off-by: Heinrich Schuchardt --- lib/crypto/public_key.c | 4 ---- 1 file changed, 4 deletions(-) -- 2.28.0 diff --git a/lib/crypto/public_key.c b/lib/crypto/public_key.c index a8f7fbed45..df6033cdb4 100644 --- a/lib/crypto/public_key.c +++ b/lib/crypto/public_key.c @@ -97,7 +97,6 @@ int public_key_verify_signature(const struct public_key *pkey, const struct public_key_signature *sig) { struct image_sign_info info; - struct image_region region; int ret; pr_devel("==>%s()\n", __func__); @@ -137,9 +136,6 @@ int public_key_verify_signature(const struct public_key *pkey, info.key = pkey->key; info.keylen = pkey->keylen; - region.data = sig->digest; - region.size = sig->digest_size; - if (rsa_verify_with_pkey(&info, sig->digest, sig->s, sig->s_size)) ret = -EKEYREJECTED; else