From patchwork Tue Jul 28 15:56:33 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heinrich Schuchardt X-Patchwork-Id: 1337909 X-Patchwork-Delegate: trini@ti.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=gmx.de Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; secure) header.d=gmx.net header.i=@gmx.net header.a=rsa-sha256 header.s=badeba3b8450 header.b=lmpZ6T1n; dkim-atps=neutral Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4BGLs016c5z9sRX for ; Wed, 29 Jul 2020 01:56:52 +1000 (AEST) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 58F2A823C5; Tue, 28 Jul 2020 17:56:48 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=gmx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; secure) header.d=gmx.net header.i=@gmx.net header.b="lmpZ6T1n"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 09A4A82443; Tue, 28 Jul 2020 17:56:47 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,FREEMAIL_FROM,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from mout.gmx.net (mout.gmx.net [212.227.15.19]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id A15EE80390 for ; Tue, 28 Jul 2020 17:56:44 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=gmx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=xypron.glpk@gmx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1595951800; bh=pxQtpTyyNGrDx+IO5VDKTJJeW/unbZiJWC8qjJt5cJU=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date; b=lmpZ6T1n08FdMDJgjIvjUH653DDg+kcuk7X/9mG4O7kueIpn/SAk4jp7IsVrwlzsP TQNshmNP68nRdQbZGDKP/sPzebMrB/DlFqPliSvnHwFqRKdjoi+nxxDh+9276Sg38a ijQaxhL7jBFwTT8bXAQJAKFmHzbjO8VlvSdvcc8A= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from workstation4.fritz.box ([178.202.41.107]) by mail.gmx.com (mrgmx004 [212.227.17.184]) with ESMTPSA (Nemesis) id 1MWRVh-1kGeBv2UXL-00XsQ2; Tue, 28 Jul 2020 17:56:40 +0200 From: Heinrich Schuchardt To: Tom Rini Cc: Simon Glass , Bin Meng , Stefan Roese , Heiko Schocher , Alexey Brodkin , u-boot@lists.denx.de, Heinrich Schuchardt Subject: [PATCH 1/1] cmd: bdinfo: cleanup phys_addr_t output Date: Tue, 28 Jul 2020 17:56:33 +0200 Message-Id: <20200728155633.96301-1-xypron.glpk@gmx.de> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 X-Provags-ID: V03:K1:IEzN5lcrZBd3whfe3/soJs0KUCeORRqFxRIULYzOiI9//fJa/xx Z5E0OSaxrP2Bji+Lt9tTq92z/EJ5A/1Uprn8SrGSM/wdT+5b1bs1pqPjS8DcvkJPn5zBt4h 0gbuGGoLeER03BtCA0tflCoGVMnAF/TF5QvEFB17qGCjHFNlBkQfWVg+jSQoo6p65s572w2 rBDlJ7uTDJ0xIXWRyAA0A== X-UI-Out-Filterresults: notjunk:1;V03:K0:lG6488TpU54=:QTtLB453F2p0WDRc3xSjs3 ItBzNtqBLghQgvlcWkE7V/J5ha7+x0mtaAYsuiv7bveeQU313DT+HdPcOpL5xagKfOBKfpZ7t +dXriSv02rZTMlsQGwQqdGo0ZYnaA2msVA2yljItwGpTFdlTw4QONpPB8J8EkFvQkIAaEDQgA xjKgfeQ2w+ZJsVaQU9skCkGZNfeP5WLZPt86SKzZRXrjcuyzvV5xXomgWDLseJUmbokdXrnjN Vu9eWwjaXnO1Y7Uy1VTnOj9+vxYKQPLhYnab4gC+/pCSmLKNqV8cwLUDeE88CN38j2Fnirfrr NS/UjJJkZ2B489wh+mao2OQM18ENNgLg9qC8JxpRBWPPPEB0teee77dc1pC1nWddlAqQW6yT/ K4OhCKBiZbh07bk3fCLw9teWbTFxmbmKexEmCg+BKccgaFVKDmF2gOf43FqRg7AgkVHrjWNeF blF5pzMSBj5KhUIQa8oDiSczTt0DfT8NvTq7D+ooMJKz9PRDOMKLcnnEtJl//isDX6hYo40YE b+WXFg8RzFJPmDXoR24pz+wqn0ooQH/l9Yt9G1LcE40wRVg9CCLcynWIuFa5+lmSnRIFI2qHf ejIGmQ4QeBD8UcJTeGBoeaZAVv6Uz5GYol/YK8A2SLZhusqjmC0TqJfE4XHpKYu6RGClHtYDd EY+7YGfhLA5NwV8IBiY14Si3E+4aZjh6RuGO8qodcHMQw7vnLEh3I+mgycMpogwWOC1/gtfhr ny+dYWOaBToxT8UmHcp/6PqvAvvF/0VmI+gGIf4sYqoTB4p67LABj5ZKmR+45FQGtkkyVFmrQ ZZptRhZpvbWG/CfoXzrRjs5PYZXzuW9acYHMO2cBjXTQK3/rs9TjwXGid2gCNsNh7btt1K0Ho Jriv2CnjAGgK+9aURhcMKMUCR2ylAiVO6JlmQFoeZhHjP+FerHgCvBTq3roj4/U40XtzX9aHy buP97xDKrSg55YJAbxdUXKYvtqFGb4fClXmQ5qvXpVxtRLx27/RO+k5/txMKQ0EGC47WM9/Rs kr8iuYcPhe4rhy5WNxTnkwoh0iZjGFj1fRYNu2RUxtFoWRprVoqTnvPnWUH4s5fHdLknNSRj9 IIVwxt4+rCrhSo3fuecxnyS4+ZihFUWmLsxtIG8nD09LxzdnYB85FWfCasPEc5ZUdrQmoW6K5 XhQBaW/1NFqsPpENUIJzZrmfM1R4gl9eVs6S5D7k5e2eKIHGohToeVay2lSe+HkcpGP2+V4x4 qVU+CNUQGiOAXlSR50XqKvYH9IAYR2yacns2i2g== X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.102.3 at phobos.denx.de X-Virus-Status: Clean We currently print the memory size with at least 8 hexadecimal digits. This creates a ragged output on 64 bit boards, e.g. on a Kendryte K210: DRAM bank = 0x0000000000000002 -> start = 0x0000000080600000 -> size = 0x0000000000200000 memstart = 0x0000000000000000 memsize = 0x00000000 flashstart = 0x0000000000000000 flashsize = 0x0000000000000000 flashoffset = 0x0000000000000000 All other numbers are printed with the number of digits needed for the type ulong. So use this value as minimum number of digits (precision) for printing physical addresses. Signed-off-by: Heinrich Schuchardt Reviewed-by: Heiko Schocher Reviewed-by: Stefan Roese Reviewed-by: Simon Glass --- cmd/bdinfo.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) -- 2.27.0 diff --git a/cmd/bdinfo.c b/cmd/bdinfo.c index 8b2c105e77..519f5de146 100644 --- a/cmd/bdinfo.c +++ b/cmd/bdinfo.c @@ -33,9 +33,10 @@ static void print_eth(int idx) printf("%-12s= %s\n", name, val); } -static void print_lnum(const char *name, unsigned long long value) +static void print_phys_addr(const char *name, phys_addr_t value) { - printf("%-12s= 0x%.8llX\n", name, value); + printf("%-12s= 0x%.*llx\n", name, 2 * (int)sizeof(ulong), + (unsigned long long)value); } void bdinfo_print_mhz(const char *name, unsigned long hz) @@ -74,7 +75,7 @@ int do_bdinfo(struct cmd_tbl *cmdtp, int flag, int argc, char *const argv[]) bdinfo_print_num("boot_params", (ulong)bd->bi_boot_params); print_bi_dram(bd); bdinfo_print_num("memstart", (ulong)bd->bi_memstart); - print_lnum("memsize", (u64)bd->bi_memsize); + print_phys_addr("memsize", bd->bi_memsize); bdinfo_print_num("flashstart", (ulong)bd->bi_flashstart); bdinfo_print_num("flashsize", (ulong)bd->bi_flashsize); bdinfo_print_num("flashoffset", (ulong)bd->bi_flashoffset);