From patchwork Mon Dec 18 12:13:01 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jerzy Grzegorek X-Patchwork-Id: 850022 X-Patchwork-Delegate: jacmet@gmail.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=busybox.net (client-ip=140.211.166.138; helo=whitealder.osuosl.org; envelope-from=buildroot-bounces@busybox.net; receiver=) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="kyTSRKQf"; dkim-atps=neutral Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3z0g0v5LCqz9s83 for ; Mon, 18 Dec 2017 23:13:19 +1100 (AEDT) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 5840A86252; Mon, 18 Dec 2017 12:13:15 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id rjWCHl8Wr6MC; Mon, 18 Dec 2017 12:13:13 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by whitealder.osuosl.org (Postfix) with ESMTP id F3FCC861D1; Mon, 18 Dec 2017 12:13:12 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by ash.osuosl.org (Postfix) with ESMTP id B2CDE1C2AB3 for ; Mon, 18 Dec 2017 12:13:11 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id AECF42F2B2 for ; Mon, 18 Dec 2017 12:13:11 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Y7cXWch5cT-u for ; Mon, 18 Dec 2017 12:13:08 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-lf0-f68.google.com (mail-lf0-f68.google.com [209.85.215.68]) by silver.osuosl.org (Postfix) with ESMTPS id 8965D2F257 for ; Mon, 18 Dec 2017 12:13:08 +0000 (UTC) Received: by mail-lf0-f68.google.com with SMTP id o26so3262224lfc.10 for ; Mon, 18 Dec 2017 04:13:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=ihjLMx7+r18R2CFj28BeZ8iU/ksyuOM8pBa4sr93/h8=; b=kyTSRKQfcVpuQe6hz1nA7UQm3B0X9vj0rRfFYQc/wp/XEXUuRGGA9nvJ1aC1iQ4HB8 l4Oq++COa3/+a+7L6SddvmFrG5shmzQaV5VfGgWXBHRTj/zh0vjg/aOhRTenf/SFMnOk 4KS5xKQf/SWqqvuEmZTmJnpS1UG6N8uXqTZA5JIr1SnbvaviGRxKInIWhXwTIYhGpXrM PXioaLsj6xwyUfSkXOl2Y6QNUfo1gF32CR0D6VdfMJXy+KJ7iNZfKqUleni3agHwLm/1 CuoHnu9TsQXvQ5xBH5/lRn+hQ8FQR9CjMl3fXluoH0JOLw2FVYcxozhR4oQiULUZsMRT Bo7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=ihjLMx7+r18R2CFj28BeZ8iU/ksyuOM8pBa4sr93/h8=; b=NfBMT+oCfvnQbxVKpuJmKSqEoXmPpA2D1+FuYaIxFyfUxuqwz0QOTgp4NDZxqL+s5N Myfdg+7lfFNLK0V8SujmWupgTDnDKPmTKW1VpZtdTrZPyNzo1BeUxAnjsRGPY3zXVd88 79bu4Q46NIjXFde2fuCwQoNNN6K3lwA0UCFcMnUZxKHe9CLihcv/cwNK/aiyylGjTJUF qsxpwVjQT6AgbcpbC/zLZmELlTclG8+qlr8u/QTgqbDGvY9CxPGeMQZsUNKuUf+FLeLA AhQvd3hydTRkDh+RWq5cuBOBy7Vt7uNwh5uDk/OozJ+0Cfm/UXmpYUFxH7AMn6z3l6q/ kCdA== X-Gm-Message-State: AKGB3mITE2TkOsDkP+TsfAMVZEY9wn7gdJ5Z+/RP9FlNkjOxffLL0Hgy mKZhwRUMeq5dBQwQKhKuwiSLXg== X-Google-Smtp-Source: ACJfBouaGt3xgwj1BqoA2TYXGeR+tv628XznleGBpuBeUiKPT7YMLmlm0PGQ48k9gJAuGiLmXgw9LA== X-Received: by 10.25.40.134 with SMTP id o128mr6863010lfo.22.1513599186632; Mon, 18 Dec 2017 04:13:06 -0800 (PST) Received: from localhost.localdomain (93-181-142-99.internetia.net.pl. [93.181.142.99]) by smtp.gmail.com with ESMTPSA id e2sm225291lfg.8.2017.12.18.04.13.04 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 18 Dec 2017 04:13:05 -0800 (PST) From: Jerzy Grzegorek To: buildroot@buildroot.org Date: Mon, 18 Dec 2017 13:13:01 +0100 Message-Id: <1513599181-6902-1-git-send-email-jerzy.m.grzegorek@gmail.com> X-Mailer: git-send-email 1.9.1 Subject: [Buildroot] [PATCH 1/1] utils/checkpackagelib: add function to check of X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.24 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jerzy Grzegorek MIME-Version: 1.0 Errors-To: buildroot-bounces@busybox.net Sender: "buildroot" Signed-off-by: Jerzy Grzegorek --- utils/checkpackagelib/lib_mk.py | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) diff --git a/utils/checkpackagelib/lib_mk.py b/utils/checkpackagelib/lib_mk.py index 817e809..5ae565c 100644 --- a/utils/checkpackagelib/lib_mk.py +++ b/utils/checkpackagelib/lib_mk.py @@ -99,6 +99,25 @@ class PackageHeader(_CheckFunction): text] +class RemoveDefaultPackageSourceVariable(_CheckFunction): + PACKAGE_NAME = re.compile("/([^/]+)\.mk") + + def before(self): + package = self.PACKAGE_NAME.search(self.filename).group(1) + package_upper = package.replace("-", "_").upper() + self.package = package + self.package_upper = package_upper + self.FIND_SOURCE = re.compile( + "^{}_SOURCE\s*=\s*{}-\$\({}_VERSION\)\.tar\.gz" + .format(package_upper, package, package_upper)) + + def check_line(self, lineno, text): + if self.FIND_SOURCE.search(text): + return ["{}:{}: remove default value of _SOURCE variable ({}#writing-rules-mk)" + .format(self.filename, lineno, self.url_to_manual), + text] + + class SpaceBeforeBackslash(_CheckFunction): TAB_OR_MULTIPLE_SPACES_BEFORE_BACKSLASH = re.compile(r"^.*( |\t)\\$")