From patchwork Thu Jun 25 20:19:26 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Harald Anlauf X-Patchwork-Id: 1317193 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=8.43.85.97; helo=sourceware.org; envelope-from=gcc-patches-bounces@gcc.gnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=gmx.de Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; secure) header.d=gmx.net header.i=@gmx.net header.a=rsa-sha256 header.s=badeba3b8450 header.b=kiccbYhn; dkim-atps=neutral Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 49tBFQ0P6jz9s6w for ; Fri, 26 Jun 2020 06:19:37 +1000 (AEST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 49E07388A834; Thu, 25 Jun 2020 20:19:32 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mout.gmx.net (mout.gmx.net [212.227.15.15]) by sourceware.org (Postfix) with ESMTPS id 71EAB387084C; Thu, 25 Jun 2020 20:19:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 71EAB387084C Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=gmx.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=anlauf@gmx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1593116366; bh=yYrn9KCXTng5dt/khYSSPalVywhbRQu8o/y9TTCXYrI=; h=X-UI-Sender-Class:From:To:Subject:Date; b=kiccbYhnkobDtApBVlUGw4Q7tWrZSIAOj6iGkwIpK3fF/IhH0iMhT9KIW/F2Yya51 BHfdw7z6Rs6f+Hjkg6M1qD7UJl+kUq1twz3QL8gyM+jCoTLN7qV3Y1DaeoKCRgS/mg NfTgZxdjafcegEHLcZG+sHhfF3XcJDJCW5TACOYk= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [79.251.15.25] ([79.251.15.25]) by web-mail.gmx.net (3c-app-gmx-bs75.server.lan [172.19.170.219]) (via HTTP); Thu, 25 Jun 2020 22:19:26 +0200 MIME-Version: 1.0 Message-ID: From: Harald Anlauf To: fortran , gcc-patches Subject: [PATCH] [9/10/11 Regression] PR fortran/93337 - ICE in gfc_dt_upper_string, at fortran/module.c:441 Date: Thu, 25 Jun 2020 22:19:26 +0200 Importance: normal Sensitivity: Normal X-Priority: 3 X-Provags-ID: V03:K1:2yYApHT9lSWbgLUESJatA1rC1/pWIXzyIRnc890WCm70Ead7BDy9yVpKTwGzhLBa3dZ1W yfON0d2hE2pqRTaBn5EFpqOs9XUZ54tP7RgCh3fdXDcuKflnknWDbg8FkC/vmuX4jOefZuVVV5t2 4Taq5apPbCZc3yedBr35LQBabOlXuECGDQmUlxNpuVJThtPMpVLhcU6N00jTeFf+5IY23OCcmsCS F5i08SW8svU1cw/6L/3Q1nw3fspaLjQkaLdRYU1AIsWjUIq2ssXowqmIFfiCm3mmAoY2tkJ9J9kP z4= X-UI-Out-Filterresults: notjunk:1;V03:K0:Ai8o5MRvplk=:lYnwS7oAc7qgNb+TE/1/cu rz+zni1g5FQXnIzRutrGDKnM+rtMMRmw07DwJvHp3HcEPi3LSs4AkBhBYEPjer5etfBIZMsvg 3oR0CaQi4CQfWrdvaEioAWnF662FVuOI8CqskblnRxbId7jiufwEKxwkghpGSAd6tL9R7F82H EXPaIuoFC8v8UyhyED64fICzXcvZ2TV3DphIPkcUmmT9Hni1loqqmskxKEdMtNOwOaWE0QOif Pmto352wMWbPlR2rA8bNi/yEUPMug2A4odb+ELmy+feIosupX2UvnIeWYVxdJOr7wBMqE2Hs+ aoC3kWp064TT/tv3v4aBlQ0eb04/L/hNnI2kDEZUHlPv+D0EK1t5q1/rDf7i6AaXCwjsMVQ3G L8Ks3B5XOzl2dPTZbuNfZle5hRYJDhd1HfVRUS2Vc1ETVUADu3eeltvFpNR4yz4x444lK/P1/ L8bQQyTDOSi10hxqjxeYt1ptme7+F3LLcCXQhziqoOK8Nf1wDeovIMXnJvLy+rADZ3wGLrvec rFdNTuybtI+idm2q2u624cPRP9uu2Mfjdu0HicrzWI8T0UQ0u0NpzqD2yZrECi0rbXbym8sZQ C8V+eOTHsulnYAoa9rqPy6lcA/QIurjfi2diR7/HywqPAVm9oTaCtWXhhR0FDKnfJTti/85Pn bjArxLEdq2jTJUPXdeoUdpfvMpboghPsD+GC/+HVflb0vJw== X-Spam-Status: No, score=-10.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, FREEMAIL_FROM, GIT_PATCH_0, KAM_NUMSUBJECT, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces@gcc.gnu.org Sender: "Gcc-patches" This PR is due to a plain NULL pointer that needs to get caught in the right place. Regtested on x86_64-pc-linux-gnu. OK for master / backports where applicable? Thanks, Harald PR fortran/93337 - ICE in gfc_dt_upper_string, at fortran/module.c:441 When declaring a polymorphic variable that is not a dummy, allocatable or pointer, an ICE occurred due to a NULL pointer dereference. Check for that situation and punt. gcc/fortran/ PR fortran/93337 * class.c (gfc_find_derived_vtab): Punt if name is not set. diff --git a/gcc/fortran/class.c b/gcc/fortran/class.c index 2b760efe8d7..48f81d89a74 100644 --- a/gcc/fortran/class.c +++ b/gcc/fortran/class.c @@ -2277,6 +2277,9 @@ gfc_find_derived_vtab (gfc_symbol *derived) if (!derived) return NULL; + if (!derived->name) + return NULL; + /* Find the gsymbol for the module of use associated derived types. */ if ((derived->attr.use_assoc || derived->attr.used_in_submodule) && !derived->attr.vtype && !derived->attr.is_class) diff --git a/gcc/testsuite/gfortran.dg/pr93337.f90 b/gcc/testsuite/gfortran.dg/pr93337.f90 new file mode 100644 index 00000000000..5cfb9297990 --- /dev/null +++ b/gcc/testsuite/gfortran.dg/pr93337.f90 @@ -0,0 +1,10 @@ +! { dg-do compile } +! PR fortran/93337 - ICE in gfc_dt_upper_string, at fortran/module.c:441 + +program p + type t + character(:), allocatable :: a + end type t + class(t) :: x ! { dg-error "must be dummy, allocatable or pointer" } + x = x ! { dg-error "must not be polymorphic in intrinsic assignment" } +end