From patchwork Thu Jun 25 10:50:29 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fabio Estevam X-Patchwork-Id: 1316836 X-Patchwork-Delegate: trini@ti.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=85.214.62.61; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=hMdcFH58; dkim-atps=neutral Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 49sxdP3GK2z9sPF for ; Thu, 25 Jun 2020 20:51:05 +1000 (AEST) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 5974082113; Thu, 25 Jun 2020 12:51:00 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="hMdcFH58"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id D1E0A82114; Thu, 25 Jun 2020 12:50:57 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,SPF_HELO_NONE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from mail-qv1-xf44.google.com (mail-qv1-xf44.google.com [IPv6:2607:f8b0:4864:20::f44]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id ABFC28210F for ; Thu, 25 Jun 2020 12:50:54 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=festevam@gmail.com Received: by mail-qv1-xf44.google.com with SMTP id g11so2547938qvs.2 for ; Thu, 25 Jun 2020 03:50:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=9SacIvqIEWClGspvh2xSLGhBdive/of08B9DY1mVcvg=; b=hMdcFH58nJtJt0fW5EYLRC9I9e+MuuSVJY9+UqZZJMjew8QIKmG/haZEex1U3vvkof dnUZ44d2kqc926zCp/m53vVawZeivztsg77w8LWZbySsXhJwuoJj6epoZaHO6NNZ3ivK a5QGQjP1xdmfD3Hbq5e5j80Ssxb7y+x9XDkJFvHQnPv/0NB/Ai/MMx5ajtI6RqPF5c/W pZiFHaypR1/dfHt0HpstSpfSnc8OPpinkOtUojas6C2ri81N03DJk+cr27M05Qt6xlRD n0o/DgQgW6CXcc6c4HcDCyOtyd2Tkv6uy5+NYbcBentFxJ0GEpO4ZWaxbgKcaNd4ktYd iGTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=9SacIvqIEWClGspvh2xSLGhBdive/of08B9DY1mVcvg=; b=mzalVdbTb4al5ElXeTQxJHbCKgvxYyfZSc8MWelcLlqll3Pi5KZkAKPzEAZyieVvFO KdSiDAA4fX0hDkrAZfXrdYVdRnNy3bqRGdA3XiB40z0Xj9zL0ILHDqUktT0ACVKoWv/M FSf8x2oECGUObx1ghXHy77Io/wOhx3jf222CepYL4/dMPa+4EUAQ/FcDIzVt4tkYJ9Rr 2AhAVYKT5zyNh/+jGz/YferfMDskQkKRzo9rCosRtJT22zTjud8T+2APXiCy7DJiUgol FCcpbXYLxkL/zbFOK4hWkRScXbk5zhACuRFX8ZgAH3UBdphpHFTV0D9wevZ3L+d+JCLI hlOQ== X-Gm-Message-State: AOAM532K50CsOVK28/Wlgo0TZDXPB9Y8XGwr5tFz+S0oDzqf7sFLfNX2 bvep7Ird4AZsdesr5Q4N4FI= X-Google-Smtp-Source: ABdhPJyIFTLqUFtqXAxr0KQODyr/tZd1hfBRV6Gk2SqPNuNvV4u82DatMPfmYc1dEMTffJU+siapUQ== X-Received: by 2002:a05:6214:1584:: with SMTP id m4mr16505176qvw.60.1593082253205; Thu, 25 Jun 2020 03:50:53 -0700 (PDT) Received: from localhost.localdomain ([2804:14c:482:92b:9524:444f:ca0e:d637]) by smtp.gmail.com with ESMTPSA id w28sm3399748qkw.92.2020.06.25.03.50.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Jun 2020 03:50:52 -0700 (PDT) From: Fabio Estevam To: sbabic@denx.de Cc: u-boot@lists.denx.de, smoch@web.de, trini@konsulko.com, Fabio Estevam Subject: [PATCH] ARM: dts: imx6q-tbs2910: Fix Ethernet regression Date: Thu, 25 Jun 2020 07:50:29 -0300 Message-Id: <20200625105029.3700-1-festevam@gmail.com> X-Mailer: git-send-email 2.17.1 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.30rc1 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.102.2 at phobos.denx.de X-Virus-Status: Clean Since commit: commit 6333cbb3817ed551cd7d4e92f7359c73ccc567fc Author: Michael Walle Date: Thu May 7 00:11:58 2020 +0200 phy: atheros: ar8035: remove static clock config We can configure the clock output in the device tree. Disable the hardcoded one in here. This is highly board-specific and should have never been enabled in the PHY driver. If bisecting shows that this commit breaks your board it probably depends on the clock output of your Atheros AR8035 PHY. Please have a look at doc/device-tree-bindings/net/phy/atheros.txt. You need to set "clk-out-frequency = <125000000>" because that value was the hardcoded value until this commit. Signed-off-by: Michael Walle Acked-by: Joe Hershberger , the clock output setting for the AR803x driver is removed from being hardcoded in the PHY driver and should be passed via device tree instead. Update the device tree with the "qca,clk-out-frequency" property so that Ethernet can work again. Reported-by: Soeren Moch Signed-off-by: Fabio Estevam --- arch/arm/dts/imx6q-tbs2910.dts | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/arch/arm/dts/imx6q-tbs2910.dts b/arch/arm/dts/imx6q-tbs2910.dts index cc5df37b46..eb08801044 100644 --- a/arch/arm/dts/imx6q-tbs2910.dts +++ b/arch/arm/dts/imx6q-tbs2910.dts @@ -107,7 +107,19 @@ pinctrl-0 = <&pinctrl_enet>; phy-mode = "rgmii-id"; phy-reset-gpios = <&gpio1 25 GPIO_ACTIVE_LOW>; + phy-handle = <&phy>; + status = "okay"; + + mdio { + #address-cells = <1>; + #size-cells = <0>; + + phy: ethernet-phy@4 { + reg = <4>; + qca,clk-out-frequency = <125000000>; + }; + }; }; &hdmi {