From patchwork Tue Dec 12 14:47:42 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Storm, Christian" X-Patchwork-Id: 847529 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=googlegroups.com (client-ip=2a00:1450:400c:c09::23b; helo=mail-wm0-x23b.google.com; envelope-from=swupdate+bncbdd6bwv65qpbb7gyx7iqkgqeekztrxa@googlegroups.com; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=googlegroups.com header.i=@googlegroups.com header.b="qSBZEFk7"; dkim-atps=neutral Received: from mail-wm0-x23b.google.com (mail-wm0-x23b.google.com [IPv6:2a00:1450:400c:c09::23b]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3yx2m04MqQz9s03 for ; Wed, 13 Dec 2017 01:49:35 +1100 (AEDT) Received: by mail-wm0-x23b.google.com with SMTP id v184sf6112398wmf.1 for ; Tue, 12 Dec 2017 06:49:35 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1513090173; cv=pass; d=google.com; s=arc-20160816; b=M7hilCaA0djYPa4JWuO3ZLMRbs6wO1weXLVbouHWbPK8Ngp1BvRDq9xeqCqmtmei8T xG08e1LmSb74A9akO9CaC7+PEg0wTcxFD6q4R+Bx6wlVcjlFtOIOYGlHhhoVYokKbLgE 0gMdaMxAu8SbUB7Bnt68VSg4GBU+eWie3NlszMVHjaBi4pwIYzacti7TyT7tIqXpAli1 KKix4LX0PXb87AxT2tiMnuVvTFDyEgodBcH1y1Hx26vZ4YjELaHnXmzCgVcI7YNzXpLh sC5voCvK6ZwC0NxaS9RQIVNtiJxwhrG7cTl2Ul90zjxcFfJwIygtXphG9sIraVTWdvmz L1HA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:arc-authentication-results :arc-message-signature:mime-version:sender:dkim-signature :arc-authentication-results; bh=uF0M4K8C7dYNdywIJLU5k44ZaAOmvfFXYMG8QcPMeCA=; b=vN+sxGbkqeGRw8j07kmVoYZa+nTus7edQ1mpecGBCvtcFPPuBezz39+CIzF/OC+Ai3 qY564q0MElU+DZWMi52h5xdVEDXVwAJHtBSvpa9vCy+W5OFe4+8gwhIBW4tAvDd5VeaQ vdl7QsEAZzhpPWkwRe/bmIYXx8d6pOC79QXVCmp9JIhMb09lwP/5iAIk6U6nCThCnH9t 0gwv10iMmDhR16be7vZ9Q5cEA9LpbDDdoSwlRXMamBhw8qayStrXMqyGo6nYdg6youIo kBHv5Klen3ZqX1SKrZ3l/GpRLHDJ6uxgsQy8CmJx4+NeXmyStzOm5zqBXHUuNOWsUY8O KNVg== ARC-Authentication-Results: i=2; gmr-mx.google.com; spf=pass (google.com: domain of christian.storm@siemens.com designates 192.35.17.28 as permitted sender) smtp.mailfrom=christian.storm@siemens.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20161025; h=sender:mime-version:from:to:cc:subject:date:message-id:in-reply-to :references:x-original-sender:x-original-authentication-results :precedence:mailing-list:list-id:list-post:list-help:list-archive :list-subscribe:list-unsubscribe; bh=uF0M4K8C7dYNdywIJLU5k44ZaAOmvfFXYMG8QcPMeCA=; b=qSBZEFk7vegRgtKYoGta15ZCpTgPcKc8aMGzjlrmnCwZ5R20m0xcxbeS4bPJL6GiDt 4FFE6bhhy4/fGCnV9MFzGpbYKrFLKuwGgEoXGznpue3ikgcedPB4rTTC/dOiLHW6+MKh eDswg1EY8Ym18TWguazIFYHubTG9vdSODZIOPWgsoQm10QAAbumsAcJRiMFAh9qEXJBU jAe5c/7lDrd7al5Tsna86vuEjYoFJpuCxFpsqfxMgNeXz1iV6dm5dvPByxe4WjXApJH/ XcbLQcLZH0ex+xHYsSSiijvmD9x0S+je5i6RbI9HQ+FjPw+vurbnD+J+/MeyNborjWyd l36Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=sender:x-gm-message-state:mime-version:from:to:cc:subject:date :message-id:in-reply-to:references:x-original-sender :x-original-authentication-results:precedence:mailing-list:list-id :x-spam-checked-in-group:list-post:list-help:list-archive :list-subscribe:list-unsubscribe; bh=uF0M4K8C7dYNdywIJLU5k44ZaAOmvfFXYMG8QcPMeCA=; b=gnbf7nsbVHwGiAk12sxEnGfrR00o1x8AjrH80CYtM1EAGTM7crIgSskQhRyGBospSO RCOf0JDKnVA7TFwy3UrssEZkInxoXB3hi8cDzKWMh6fmpCbJOcUlMhnzeGqnaofYtMkI yqlHDhHExyOTn8kb1XKT3uoNrBb0NeBjhFQBlEOTr/pbqGLv/+dR1Bq4sv9QPCvgAsSZ CfAhFw8GSF91YMvxWz/+XkU2/ABl4wBhg7F8sDRy2fHo2MvAqZHAEDAbC1OwEt8IWQv0 kiCjdoU0g6eLP9dulC9iJVTpWNxl9Hm//DTasPA7s07s6w60wK7C8U5BF0IMkYZTbwUw r5Bw== Sender: swupdate@googlegroups.com X-Gm-Message-State: AKGB3mLakF0WavJYwQgzXnXuRlHLYOarTuRHHsc0dMjPP6wKbSJpPXN6 +KGWilnW6pAn7Q8hG/wc8PQ= X-Google-Smtp-Source: ACJfBoupg40hPAyLdihIaVeL3FJKNtBu3g7EQxlLOLhx9kwzcFv0gNvIZpGXw/iwT31zbseNfJTqzA== X-Received: by 10.28.209.143 with SMTP id i137mr25538wmg.4.1513090173153; Tue, 12 Dec 2017 06:49:33 -0800 (PST) MIME-Version: 1.0 X-BeenThere: swupdate@googlegroups.com Received: by 10.28.193.142 with SMTP id r136ls2267150wmf.0.canary-gmail; Tue, 12 Dec 2017 06:49:32 -0800 (PST) X-Received: by 10.28.189.85 with SMTP id n82mr213325wmf.23.1513090172343; Tue, 12 Dec 2017 06:49:32 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1513090172; cv=none; d=google.com; s=arc-20160816; b=G1ECi9NYOlxI7JbTRsp+RsWfI6R2vLgVmDN+YNrFDuIrHQsCd4TIQi8nYY6ckJPJJ7 nG9FKNaAeFZdtCQ59Gzky6pAY/VnPF1zRpFvGn84i+/bxBTXAO9tijU0gGLEkyh0pyN8 jZGBqy3pSfBmpd2AmoOVdmxl/hmmlTskikAWWJ0tPE+kZtS9sphISddgXIfPcXd79gv4 GG8mmRXVUknv02qDopNmcGxFXoZW0CKYuzVAD0bvlWHEaDptUUxaKSQ1l3xB6AFEEkYk 9S+ihjhBems3UGloY1HgOfdjxKPyrnmT/i2s0oRQnuyjY4twrzq/DO1/ZEU3elSHCbTo m+QA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=references:in-reply-to:message-id:date:subject:cc:to:from :arc-authentication-results; bh=8Rqeiz7uqKTTIv0vySKbJrZ/4an3d9NY8xFC+/CVuqg=; b=xP/o7n8PlAIHJ1HVhrgCmTxv0S9j+8z+0bpmu2y3KQSFONC75ekiA54XfAL0eCA/Y0 MfjT5lQFA0/ksF7BPTC7fWxyOHGKN9kFOeLbVvtVU3yxdfR4GERn8baM+bQEwEPzCaTk epSLQWqgBNWfd+dhvKu77vV2apMlPjqvUvzi/tPuuDawcvsA6/8Weo4ThTTp2omHUUSm ElF3oQzTu400nNEfhrvfQ+mHtk52IFUi5HNIOOF5gU5wOyV/7pLBJvxTBOP0znacP8/D DOP7hbzLmQguKjB5OZpWYuvCrNEbWpskFaTTZR2Nnx8w6Nkok8BkXK7Sv7MmI/lo46iU XUKA== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of christian.storm@siemens.com designates 192.35.17.28 as permitted sender) smtp.mailfrom=christian.storm@siemens.com Received: from goliath.siemens.de (goliath.siemens.de. [192.35.17.28]) by gmr-mx.google.com with ESMTPS id e80si1220554wmi.2.2017.12.12.06.49.32 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 12 Dec 2017 06:49:32 -0800 (PST) Received-SPF: pass (google.com: domain of christian.storm@siemens.com designates 192.35.17.28 as permitted sender) client-ip=192.35.17.28; Received: from mail1.siemens.de (mail1.siemens.de [139.23.33.14]) by goliath.siemens.de (8.15.2/8.15.2) with ESMTPS id vBCEnVoR005103 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Tue, 12 Dec 2017 15:49:32 +0100 Received: from MD1KR9XC.ww002.siemens.net ([139.25.69.251]) by mail1.siemens.de (8.15.2/8.15.2) with ESMTP id vBCEnVAp013171; Tue, 12 Dec 2017 15:49:31 +0100 From: Christian Storm To: swupdate@googlegroups.com Cc: Christian Storm Subject: [swupdate] [PATCH 2/4] channel: add missing prototypes to channel_curl Date: Tue, 12 Dec 2017 15:47:42 +0100 Message-Id: <20171212144744.24224-2-christian.storm@siemens.com> X-Mailer: git-send-email 2.15.1 In-Reply-To: <20171212144744.24224-1-christian.storm@siemens.com> References: <20171212144744.24224-1-christian.storm@siemens.com> X-Original-Sender: christian.storm@siemens.com X-Original-Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of christian.storm@siemens.com designates 192.35.17.28 as permitted sender) smtp.mailfrom=christian.storm@siemens.com Precedence: list Mailing-list: list swupdate@googlegroups.com; contact swupdate+owners@googlegroups.com List-ID: X-Spam-Checked-In-Group: swupdate@googlegroups.com X-Google-Group-Id: 605343134186 List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , The functions for opening, closing, receiving, and sending data over the channel should be exposed for testability as described in the header comment. This reverts commit f531694 as it breaks suricatta-tests. Signed-off-by: Christian Storm --- include/channel_curl.h | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/include/channel_curl.h b/include/channel_curl.h index 98240a9..94d3c55 100644 --- a/include/channel_curl.h +++ b/include/channel_curl.h @@ -21,6 +21,7 @@ #include #include #include "sslapi.h" +#include /* hawkBit Channel Implementation Private Header File. * @@ -59,3 +60,10 @@ typedef struct { struct swupdate_digest *dgst; char sha1hash[SHA_DIGEST_LENGTH * 2 + 1]; } channel_data_t; + +channel_op_res_t channel_close(channel_t *this); +channel_op_res_t channel_open(channel_t *this, void *cfg); +channel_op_res_t channel_put(channel_t *this, void *data); +channel_op_res_t channel_get_file(channel_t *this, void *data, int file_handle); +channel_op_res_t channel_get(channel_t *this, void *data); +channel_op_res_t channel_curl_init(void);