From patchwork Thu Apr 23 12:37:31 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Flaviof X-Patchwork-Id: 1275727 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org (client-ip=140.211.166.137; helo=fraxinus.osuosl.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=flaviof.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=flaviof.com header.i=@flaviof.com header.a=rsa-sha1 header.s=flaviof.com header.b=R//KvQHd; dkim-atps=neutral Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 497Gxp3bslz9sSx for ; Thu, 23 Apr 2020 22:36:14 +1000 (AEST) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id 9963086CC1; Thu, 23 Apr 2020 12:36:11 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id kpKKP-bGgH2q; Thu, 23 Apr 2020 12:36:09 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by fraxinus.osuosl.org (Postfix) with ESMTP id 212CF86CB5; Thu, 23 Apr 2020 12:36:09 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 028CFC1797; Thu, 23 Apr 2020 12:36:09 +0000 (UTC) X-Original-To: dev@openvswitch.org Delivered-To: ovs-dev@lists.linuxfoundation.org Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by lists.linuxfoundation.org (Postfix) with ESMTP id 99083C0175 for ; Thu, 23 Apr 2020 12:36:07 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 81B0A885BD for ; Thu, 23 Apr 2020 12:36:07 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id pC-s0tq1o0I2 for ; Thu, 23 Apr 2020 12:36:06 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from anteater.elm.relay.mailchannels.net (anteater.elm.relay.mailchannels.net [23.83.212.3]) by hemlock.osuosl.org (Postfix) with ESMTPS id 3FB7C885BA for ; Thu, 23 Apr 2020 12:36:06 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|flavio@flaviof.com Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 64F9C920EAA; Thu, 23 Apr 2020 12:36:05 +0000 (UTC) Received: from pdx1-sub0-mail-a93.g.dreamhost.com (100-96-21-20.trex.outbound.svc.cluster.local [100.96.21.20]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 8900C921514; Thu, 23 Apr 2020 12:36:04 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|flavio@flaviof.com Received: from pdx1-sub0-mail-a93.g.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.18.6); Thu, 23 Apr 2020 12:36:05 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|flavio@flaviof.com X-MailChannels-Auth-Id: dreamhost X-Zesty-Decisive: 078b251b2045fbc1_1587645365149_3891283449 X-MC-Loop-Signature: 1587645365149:2309990805 X-MC-Ingress-Time: 1587645365148 Received: from pdx1-sub0-mail-a93.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a93.g.dreamhost.com (Postfix) with ESMTP id 1BEFD815FF; Thu, 23 Apr 2020 05:36:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=flaviof.com; h=from:to:cc :subject:date:message-id; s=flaviof.com; bh=EzP4tt+oiKtdI/9DLsBv Bf65t3c=; b=R//KvQHdX7T6++NZXx88fn3FKAXZsGswqCbnW7j0LQeg8hLEoRz7 nLgYWPlVZOhyV4+6+Os7rHwOoMTGhJuuQjRcDgqUjk+SeYFJ+id+BCJmu3WNUSqm /HmAHKkrchuY5OEVIeByE9pjIiJJenzlP5/5Vhutsyn5HTu85jZ/gpM= Received: from flaviof-laptop.bos.redhat.com (nat-pool-bos-t.redhat.com [66.187.233.206]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: flavio@flaviof.com) by pdx1-sub0-mail-a93.g.dreamhost.com (Postfix) with ESMTPSA id 39F63815FD; Thu, 23 Apr 2020 05:36:02 -0700 (PDT) X-DH-BACKEND: pdx1-sub0-mail-a93 From: Flavio Fernandes To: dev@openvswitch.org Date: Thu, 23 Apr 2020 08:37:31 -0400 Message-Id: <20200423123731.29123-1-flavio@flaviof.com> X-Mailer: git-send-email 2.17.1 X-VR-OUT-STATUS: OK X-VR-OUT-SCORE: 0 X-VR-OUT-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgeduhedrgeelgdehudcutefuodetggdotefrodftvfcurfhrohhfihhlvgemucggtfgfnhhsuhgsshgtrhhisggvpdfftffgtefojffquffvnecuuegrihhlohhuthemuceftddtnecunecujfgurhephffvufffkffosedttdertdertddtnecuhfhrohhmpefhlhgrvhhiohcuhfgvrhhnrghnuggvshcuoehflhgrvhhiohesfhhlrghvihhofhdrtghomheqnecukfhppeeiiedrudekjedrvdeffedrvddtieenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhhouggvpehsmhhtphdphhgvlhhopehflhgrvhhiohhfqdhlrghpthhophdrsghoshdrrhgvughhrghtrdgtohhmpdhinhgvthepieeirddukeejrddvfeefrddvtdeipdhrvghtuhhrnhdqphgrthhhpefhlhgrvhhiohcuhfgvrhhnrghnuggvshcuoehflhgrvhhiohesfhhlrghvihhofhdrtghomheqpdhmrghilhhfrhhomhepfhhlrghvihhosehflhgrvhhiohhfrdgtohhmpdhnrhgtphhtthhopehflhgrvhhiohesfhhlrghvihhofhdrtghomh Subject: [ovs-dev] [PATCH ovn v1] tests: Fix failures in 4 HV, 1 LS, 1 LR, packet test with HA dist rtr gw prt X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: ovs-dev-bounces@openvswitch.org Sender: "dev" The test case "76: ovn -- 4 HV, 1 LS, 1 LR, packet test with HA distributed router gateway port" fails sometimes. This patch fixes this by leveraging the command ovn-nbctl sync. It also adds a delay before sending a packet between foo1 and outside1, so it does not get out of order with the gratuitous arp broadcast. The failed test would look like this: checking packets in ext1/vif1-tx.pcap against ext1-vif1.expected: ovn.at:12: waiting until $PYTHON "$ovs_srcdir/utilities/ovs-pcap.in" $rcv_pcap > $rcv_text rcv_n=`wc -l < "$rcv_text"` echo "rcv_n=$rcv_n exp_n=$exp_n" test $rcv_n -ge $exp_n... ovn.at:12: wait succeeded after 2 seconds ./ovn.at:8865: sort $rcv_text expout 2020-04-22 15:24:29.948703642 -0400 /home/ffernand/work/ovn/tests/testsuite.dir/at-groups/76/stdout 2020-04-22 15:24:29.948703642 -0400 -1,2 +1,2 -f0000001020400000201020308004500001c000000003f110100c0a80102ac1001030035111100080000 +ffffffffffff00000201020308060001080006040001000002010203ac100101000000000000ac100101 ffffffffffff00000201020308060001080006040001000002010203ac100101000000000000ac100101 76. ovn.at:8695: 76. ovn -- 4 HV, 1 LS, 1 LR, packet test with HA distributed router gateway port (ovn.at:8695): FAILED (ovn.at:8865) Reported-by: Dumitru Ceara Signed-off-by: Flavio Fernandes --- tests/ovn.at | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/tests/ovn.at b/tests/ovn.at index 2a7ee7528..149345101 100644 --- a/tests/ovn.at +++ b/tests/ovn.at @@ -8818,8 +8818,7 @@ as ext1 ovs-vsctl set open . external-ids:ovn-bridge-mappings=phys:br-phys AT_CHECK([ovn-nbctl --timeout=3 --wait=sb sync], [0], [ignore]) # Allow some time for ovn-northd and ovn-controller to catch up. -# XXX This should be more systematic. -sleep 2 +ovn-nbctl --wait=hv sync ip_to_hex() { printf "%02x%02x%02x%02x" "$@" @@ -8886,6 +8885,8 @@ grep actions=mod_dl_dst:f0:00:00:01:02:04 | wc -l` -eq 1 fi as ext1 reset_pcap_file ext1-vif1 ext1/vif1 + sleep 1 + # Resend packet from foo1 to outside1 as hv1 ovs-appctl netdev-dummy/receive hv1-vif1 $packet